Re: [Xen-devel] [PATCH 2/2] x86: use invpcid to do global flushing

2018-03-05 Thread Juergen Gross
On 05/03/18 12:50, Andrew Cooper wrote: > On 05/03/18 11:31, Jan Beulich wrote: > On 05.03.18 at 10:50, wrote: >>> Signed-off-by: Wei Liu >> No description at all? I'd at least expect mention of how much of a >> performance win this is (for whichever

Re: [Xen-devel] [PATCH 1/2] x86: report if PCID and INVPCID are supported

2018-03-05 Thread Juergen Gross
On 05/03/18 13:37, Jan Beulich wrote: On 05.03.18 at 12:43, wrote: >> On 05/03/18 12:20, Jan Beulich wrote: >> On 05.03.18 at 10:50, wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1701,6 +1701,13 @@ void __init

Re: [Xen-devel] [PATCH 2/2] x86: use invpcid to do global flushing

2018-03-05 Thread Juergen Gross
On 05/03/18 13:57, Andrew Cooper wrote: > On 05/03/18 12:54, Jan Beulich wrote: >>>>> On 05.03.18 at 13:35, <andrew.coop...@citrix.com> wrote: >>> On 05/03/18 12:06, Juergen Gross wrote: >>>> On 05/03/18 12:50, Andrew Cooper wrote: >>>>>

Re: [Xen-devel] Crash with your meltdown patches

2018-03-01 Thread Juergen Gross
On 01/03/18 19:26, Andrew Cooper wrote: > On 01/03/18 18:23, Juergen Gross wrote: >> On 01/03/18 18:48, Andrew Cooper wrote: >>> On 01/03/18 17:05, Juergen Gross wrote: >>>> Jan, >>>> >>>> I just rebased my patch series for speeding up XP

Re: [Xen-devel] Crash with your meltdown patches

2018-03-01 Thread Juergen Gross
On 01/03/18 18:48, Andrew Cooper wrote: > On 01/03/18 17:05, Juergen Gross wrote: >> Jan, >> >> I just rebased my patch series for speeding up XPTI to current >> staging. This included your pending speedup series. I'm now seeing >> a crash with the first patch

Re: [Xen-devel] [PATCH v2 2/2] x86/xpti: don't map stack guard pages

2018-03-02 Thread Juergen Gross
On 02/03/18 17:10, Jan Beulich wrote: On 02.03.18 at 16:43, wrote: >> On 02/03/18 15:35, Jan Beulich wrote: >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -5576,6 +5576,14 @@ void memguard_unguard_stack(void *p) >>> STACK_SIZE -

Re: [Xen-devel] Setting up a Xen x86 community call

2018-03-02 Thread Juergen Gross
On 02/03/18 16:39, Lars Kurth wrote: > Hi all, > (sorry for the extensive distribution list - I went through MAINTAINERS and > people who may have an interest) > > I would like to start organizing a recurring x86 community call to discuss > and sync-up on upcoming features for Xen on x86. This

Re: [Xen-devel] update_runstate_area and Linux KPTI

2018-03-02 Thread Juergen Gross
On 02/03/18 17:25, Julien Grall wrote: > > > On 02/03/18 16:18, Jan Beulich wrote: > On 02.03.18 at 17:04, wrote: >>> The proper way to do this is indeed by a nominated (guest) physical >>> address, at which point Xen can make all/any updates at times of its >>>

Re: [Xen-devel] update_runstate_area and Linux KPTI

2018-03-02 Thread Juergen Gross
On 02/03/18 18:09, Andrew Cooper wrote: > On 02/03/18 17:05, Juergen Gross wrote: >> On 02/03/18 17:51, Jan Beulich wrote: >>>>>> On 02.03.18 at 17:25, <julien.gr...@arm.com> wrote: >>>> On 02/03/18 16:18, Jan Beulich wrote: >>>>>

Re: [Xen-devel] update_runstate_area and Linux KPTI

2018-03-02 Thread Juergen Gross
On 02/03/18 17:51, Jan Beulich wrote: On 02.03.18 at 17:25, wrote: >> On 02/03/18 16:18, Jan Beulich wrote: >> On 02.03.18 at 17:04, wrote: The proper way to do this is indeed by a nominated (guest) physical address, at which

Re: [Xen-devel] pvh+vcpus startup issue

2018-02-26 Thread Juergen Gross
On 22/02/18 21:38, x...@randomwebstuff.com wrote: > > On 22/02/18 6:35 PM, Juergen Gross wrote: >> On 22/02/18 05:37, x...@randomwebstuff.com wrote: >>> Hi.  I have a domU.  Its params file has: vcpus = 8.  It will start with >>> pv, but not type="pvh".  I

[Xen-devel] [PATCH] xen: use hvc console for dom0

2018-02-26 Thread Juergen Gross
Today the hvc console is added as a preferred console for pv domUs only. As this requires a boot parameter for getting dom0 messages per default add it for dom0, too. Signed-off-by: Juergen Gross <jgr...@suse.com> --- arch/x86/xen/enlighten_pv.c | 4 +++- 1 file changed, 3 insertions

Re: [Xen-devel] (partial) Spectre v2 mitigation without on Skylake IBRS

2018-02-26 Thread Juergen Gross
On 26/02/18 10:44, Jan Beulich wrote: > All, > > if running PV Linux on older Xen (4.5 and earlier) is relevant, it may be > necessary to use a mechanism other than IBRS to mitigate Spectre v2 > on Skylake. That is because the new MSR value can't be migrated > prior to migration v2. Of course one

Re: [Xen-devel] [PATCH] xen: use hvc console for dom0

2018-02-27 Thread Juergen Gross
On 26/02/18 20:02, Boris Ostrovsky wrote: > On 02/26/2018 06:08 AM, Juergen Gross wrote: >> Today the hvc console is added as a preferred console for pv domUs >> only. As this requires a boot parameter for getting dom0 messages per >> default add it for dom0, too. >>

[Xen-devel] [PATCH v2] x86/xen: add tty0 and hvc0 as preferred consoles for dom0

2018-02-27 Thread Juergen Gross
Today the tty0 and hvc0 consoles are added as a preferred consoles for pv domUs only. As this requires a boot parameter for getting dom0 messages per default, add them for dom0, too. Signed-off-by: Juergen Gross <jgr...@suse.com> --- arch/x86/xen/enlighten_pv.c | 6 -- 1 file chan

Re: [Xen-devel] (partial) Spectre v2 mitigation without on Skylake IBRS

2018-02-26 Thread Juergen Gross
On 26/02/18 14:11, Jan Beulich wrote: On 26.02.18 at 13:36, wrote: >> On 26/02/18 11:49, Jan Beulich wrote: >> On 26.02.18 at 11:18, wrote: If this is the case I believe the easiest solution would be to let the kernel set the MSR again after

[Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

2018-02-26 Thread Juergen Gross
Older Xen versions (4.5 and before) might have problems migrating pv guests with MSR_IA32_SPEC_CTRL having a non-zero value. So before suspending zero that MSR and restore it after being resumed. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross <jgr...@suse.com> --- arch/x86/xen/sus

Re: [Xen-devel] [PATCH] xen: use hvc console for dom0

2018-02-26 Thread Juergen Gross
On 26/02/18 13:06, Andrii Anisov wrote: > Hello Juergen, > > > On 26.02.18 13:08, Juergen Gross wrote: >> Today the hvc console is added as a preferred console for pv domUs >> only. As this requires a boot parameter for getting dom0 messages per >> default add it f

Re: [Xen-devel] (partial) Spectre v2 mitigation without on Skylake IBRS

2018-02-26 Thread Juergen Gross
the MSR again after leaving suspended state. suspend/resume >> require hooks in pv kernels after all. > > Hmm, this could be leveraged irrespective of what I've written > above - the kernel could then also clear the MSR during suspend, > thus allowing the check in libxc to

Re: [Xen-devel] [PATCH v2 2/2] xen: events: free irqs in error condition

2018-02-28 Thread Juergen Gross
dd support for MSI message >>>>> groups") >>>>> Reported-by: Hooman Mirhadi <mirha...@amazon.com> >>>>> CC: <sta...@vger.kernel.org> >>>>> CC: Roger Pau Monné <roger@citrix.com> >>>>> CC: Boris Ostrovsky

[Xen-devel] Xen 4.11 Development Update

2018-02-28 Thread Juergen Gross
=== ARM === * SMMUv3 driver (RFC v4) - Sameer Goel * IORT support (RFC) - Manish Jaggi * Implement branch predictor hardening for affected Cortex-A CPUs (v1) - Julien Grall == Grub2 == * Support PVH guest boot (v1) - Juergen Gross == Completed == === x86 === * Add dmops

Re: [Xen-devel] pvh+vcpus startup issue

2018-02-28 Thread Juergen Gross
On 28/02/18 09:27, Roger Pau Monné wrote: > On Wed, Feb 28, 2018 at 01:34:31PM +1300, x...@randomwebstuff.com wrote: >> >> Regards, Peter >> http://ri.mu Startups start here. Hosting. DNS. Offsite backups. >> Monitoring. Email. >> >> On 27/02/18 12:42 A

Re: [Xen-devel] Ping: [PATCH v2 0/7] x86: Meltdown band-aid overhead reduction

2018-02-28 Thread Juergen Gross
se, even if only a little; taking 3 as prereq), and >> 6+7 should be considered seriously. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> You can add to all of them: Tested-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Juergen Gross <jgr...@suse.com>

[Xen-devel] [PATCH v2 0/6] xen/x86: various XPTI speedups

2018-03-02 Thread Juergen Gross
/xen.git xpti Juergen Gross (6): x86/xpti: avoid copying L4 page table contents when possible x86/xpti: don't flush TLB twice when switching to 64-bit pv context xen/x86: support per-domain flag for xpti xen/x86: disable global pages for domains with XPTI active xen/x86: use flag byte

[Xen-devel] [PATCH v2 6/6] xen/x86: use PCID feature for XPTI

2018-03-02 Thread Juergen Gross
in user mode - guest active and in user mode The 2 hypervisor cases could possibly be merged, but for security reasons this is left for another patch. Add a pcid flag to struct pv_domain to make it possible using PCID without XPTI later. Signed-off-by: Juergen Gross <jgr...@suse.com> --- xe

[Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-02 Thread Juergen Gross
Instead of flushing the TLB from global pages when switching address spaces with XPTI being active just disable global pages via %cr4 completely when a domain subject to XPTI is active. This avoids the need for extra TLB flushes as loading %cr3 will remove all TLB entries. Signed-off-by: Juergen

[Xen-devel] [PATCH v2 1/6] x86/xpti: avoid copying L4 page table contents when possible

2018-03-02 Thread Juergen Gross
for that case. A simple performance check (compiling the hypervisor via "make -j 4") in dom0 with 4 vcpus shows a significant improvement: - real time drops from 112 seconds to 103 seconds - system time drops from 142 seconds to 131 seconds Signed-off-by: Juergen Gross <jg

[Xen-devel] [PATCH v2 5/6] xen/x86: use flag byte for decision whether xen_cr3 is valid

2018-03-02 Thread Juergen Gross
off-by: Juergen Gross <jgr...@suse.com> --- xen/arch/x86/domain.c | 1 + xen/arch/x86/mm.c | 1 + xen/arch/x86/smpboot.c | 2 ++ xen/arch/x86/x86_64/asm-offsets.c | 1 + xen/arch/x86/x86_64/compat/entry.S | 5 ++-- xen/arch/x86/x86_64/entry.S

[Xen-devel] [PATCH v2 2/6] x86/xpti: don't flush TLB twice when switching to 64-bit pv context

2018-03-02 Thread Juergen Gross
When switching to a 64-bit pv context the TLB is flushed twice today: the first time when switching to the new address space in write_ptbase(), the second time when switching to guest mode in restore_to_guest. Avoid the first TLB flush in that case. Signed-off-by: Juergen Gross <jgr...@suse.

[Xen-devel] [PATCH v2 3/6] xen/x86: support per-domain flag for xpti

2018-03-02 Thread Juergen Gross
n/arch/x86/pv/domain.c as it is pv-domain specific. Signed-off-by: Juergen Gross <jgr...@suse.com> --- docs/misc/xen-command-line.markdown | 8 +++- xen/arch/x86/domctl.c | 4 ++ xen/arch/x86/mm.c | 6 ++- xen/arch/x86/pv/dom0_build.c| 4 ++ xen/arch

Re: [Xen-devel] [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread

2018-03-02 Thread Juergen Gross
On 02/03/18 15:28, Wei Liu wrote: > On Fri, Mar 02, 2018 at 01:45:14PM +0100, Juergen Gross wrote: >> On 02/03/18 13:40, Wei Liu wrote: >>> On Fri, Mar 02, 2018 at 12:29:31PM +, Wei Liu wrote: >>>> On Mon, Feb 26, 2018 at 09:53:38AM -0700, Jim Fehlig wrote

Re: [Xen-devel] [PATCH 1/2] xen: xenbus_dev_frontend: Fix XS_TRANSACTION_END handling

2018-03-02 Thread Juergen Gross
On 02/03/18 15:58, Simon Gaiser wrote: > Juergen Gross: >> On 20/02/18 05:56, Simon Gaiser wrote: >>> Juergen Gross: >>>> On 07/02/18 23:22, Simon Gaiser wrote: >>>>> Commit fd8aa9095a95 ("xen: optimize xenbus driver for multiple >>

Re: [Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-02 Thread Juergen Gross
On 02/03/18 12:03, Wei Liu wrote: > On Fri, Mar 02, 2018 at 09:14:01AM +0100, Juergen Gross wrote: >> Instead of flushing the TLB from global pages when switching address >> spaces with XPTI being active just disable global pages via %cr4 >> completely when a domain subj

[Xen-devel] Crash with your meltdown patches

2018-03-01 Thread Juergen Gross
Jan, I just rebased my patch series for speeding up XPTI to current staging. This included your pending speedup series. I'm now seeing a crash with the first patch of yours: (XEN) Intel VT-d Queued Invalidation enabled. (XEN) Intel VT-d Interrupt Remapping enabled. (XEN) Intel VT-d Posted

Re: [Xen-devel] [PATCH 1/2] xen: xenbus_dev_frontend: Fix XS_TRANSACTION_END handling

2018-03-02 Thread Juergen Gross
On 20/02/18 05:56, Simon Gaiser wrote: > Juergen Gross: >> On 07/02/18 23:22, Simon Gaiser wrote: >>> Commit fd8aa9095a95 ("xen: optimize xenbus driver for multiple >>> concurrent xenstore accesses") made a subtle change to the semanti

Re: [Xen-devel] [PATCH] xen: use hvc console for dom0

2018-03-02 Thread Juergen Gross
On 27/02/18 21:09, Julien Grall wrote: > Hi, > > On 27/02/2018 20:03, Stefano Stabellini wrote: >> On Tue, 27 Feb 2018, Julien Grall wrote: >>> Hi, >>> >>> On 26/02/18 12:32, Juergen Gross wrote: >>>> On 26/02/18 13:06, Andrii Anisov wrote: &g

Re: [Xen-devel] [PATCH] x86/xpti: really hide almost all of Xen image

2018-03-02 Thread Juergen Gross
IDT now also needs to be page aligned. > > Note that the removed BUILD_BUG_ON()s don't get replaced by anything - > there already is a suitable ASSERT() in xen.lds.S. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Tested-by: Juergen Gross <jgr...@suse.com> Reviewe

Re: [Xen-devel] [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread

2018-03-02 Thread Juergen Gross
On 02/03/18 13:40, Wei Liu wrote: > On Fri, Mar 02, 2018 at 12:29:31PM +, Wei Liu wrote: >> On Mon, Feb 26, 2018 at 09:53:38AM -0700, Jim Fehlig wrote: >>> On 02/26/2018 01:46 AM, Juergen Gross wrote: >>>> When creating a pthread in xs_watch() try to ge

Re: [Xen-devel] [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread

2018-03-06 Thread Juergen Gross
On 06/03/18 12:24, Olaf Hering wrote: > On Fri, Mar 02, Wei Liu wrote: > >> But still, Juergen must have tested the change, so I wonder why it >> doesn't work in your setup. What is your build environment? Gcc version? > > Unclear what the difference is between building in clean chroot and

Re: [Xen-devel] [PATCH for-4.11] x86/suspend: Fix restoration of guest state across S3/S4

2018-06-20 Thread Juergen Gross
ocessor_state() are actually dead code, and removing > these highlights that the segment saving logic is also unused. > > Signed-off-by: Andrew Cooper Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.x

[Xen-devel] [GIT PULL] xen: fixes for 4.18-rc2

2018-06-22 Thread Juergen Gross
| 6 +- 14 files changed, 297 insertions(+), 22 deletions(-) Boris Ostrovsky (1): xen: Remove unnecessary BUG_ON from __unbind_from_irq() Juergen Gross (2): xen: add new hypercall buffer mapping device Oleksandr Andrushchenko (1): xen/grant-table: Export gnttab_{alloc

[Xen-devel] Xen 4.12 Development Update

2018-10-08 Thread Juergen Gross
* Intel Processor Trace virtualization enabling (v1) - Luwei Kang * Linux stub domains (RFC) - Marek Marczykowski-Górecki == Grub2 == * Support PVH guest boot (v1) - Juergen Gross == Completed == * guest resource mapping - Paul Durrant * PV-only hypervisor - Wei Liu

Re: [Xen-devel] [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'

2018-10-08 Thread Juergen Gross
On 08/10/2018 16:01, Ian Jackson wrote: > Tim Deegan writes ("Re: [PATCH 18/18] tools/debugger/kdd: Install as > `xen-kdd', not just `kdd'"): >> At 18:29 +0100 on 05 Oct (1538764157), Ian Jackson wrote: >>> `kdd' is an unfortunate namespace landgrab. >> >> Bah, humbug, etc. :) Can we have a note

Re: [Xen-devel] [RFC PATCH v1 00/16] xen: sched: implement core-scheduling

2018-10-11 Thread Juergen Gross
On 11/10/2018 19:37, Dario Faggioli wrote: > Hey, > > Sorry if replying took some time. :-P > > On Fri, 2018-09-07 at 18:00 +0200, Juergen Gross wrote: >> On 25/08/18 01:35, Dario Faggioli wrote: >>> >>> There are git branches here: >>> htt

Re: [Xen-devel] [RFC PATCH v1 00/16] xen: sched: implement core-scheduling

2018-10-12 Thread Juergen Gross
On 12/10/2018 09:49, Dario Faggioli wrote: > On Fri, 2018-10-12 at 07:15 +0200, Juergen Gross wrote: >> On 11/10/2018 19:37, Dario Faggioli wrote: >>> >>> So, for example: >>> - domain A has vCore0 and vCore1 >>> - each vCore has 2 threads ({vCor

Re: [Xen-devel] [RFC PATCH v1 00/16] xen: sched: implement core-scheduling

2018-10-12 Thread Juergen Gross
On 12/10/2018 11:15, Dario Faggioli wrote: > On Fri, 2018-10-12 at 10:35 +0200, Juergen Gross wrote: >> On 12/10/2018 09:49, Dario Faggioli wrote: >>> >>> But how easy it is to opt out, if one doesn't want it? E.g., in the >>> context of L1TF, wh

Re: [Xen-devel] [PATCH v2 1/5] x86/boot: Initialise the debug registers correctly

2018-10-15 Thread Juergen Gross
On 15/10/2018 13:28, Roger Pau Monné wrote: > On Mon, Oct 15, 2018 at 11:36:16AM +0100, Andrew Cooper wrote: >> In particular, initialising %dr6 with the value 0 is buggy, because on >> hardware supporting Transnational Memory, it will cause the sticky RTM bit to >> be asserted, even though a

Re: [Xen-devel] [PATCH v2 1/5] x86/boot: Initialise the debug registers correctly

2018-10-15 Thread Juergen Gross
On 15/10/2018 14:11, Andrew Cooper wrote: > On 15/10/18 12:44, Juergen Gross wrote: >> On 15/10/2018 13:28, Roger Pau Monné wrote: >>> On Mon, Oct 15, 2018 at 11:36:16AM +0100, Andrew Cooper wrote: >>>> In particular, initialising %dr6 with the value 0 is buggy, becau

Re: [Xen-devel] [PATCH v2 05/18] xen: add some dummy headers for PVH mode

2018-10-18 Thread Juergen Gross
On 18/10/2018 17:19, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:04PM +0200, Juergen Gross wrote: >> Xen PVH mode needs some headers including the common i386 headers. >> Add those to the tree. >> >> Signed-off-by: Juergen Gross >> --- >>

Re: [Xen-devel] [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-18 Thread Juergen Gross
On 18/10/2018 16:48, Daniel Kiper wrote: > On Thu, Oct 18, 2018 at 04:36:28PM +0200, Juergen Gross wrote: >> On 18/10/2018 16:30, Daniel Kiper wrote: >>> On Thu, Oct 18, 2018 at 04:18:26PM +0200, Juergen Gross wrote: >>>> On 18/10/2018 16:13, Daniel Kiper wrote: >&

Re: [Xen-devel] [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-18 Thread Juergen Gross
On 18/10/2018 16:13, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:01PM +0200, Juergen Gross wrote: >> Xen PVH guests will have the RSDP at an arbitrary address. Support that >> by passing the RSDP address via the boot parameters to Linux. >> >> The new protocol v

Re: [Xen-devel] [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-18 Thread Juergen Gross
On 18/10/2018 16:30, Daniel Kiper wrote: > On Thu, Oct 18, 2018 at 04:18:26PM +0200, Juergen Gross wrote: >> On 18/10/2018 16:13, Daniel Kiper wrote: >>> On Tue, Oct 09, 2018 at 01:03:01PM +0200, Juergen Gross wrote: >>>> Xen PVH guests will have the RSDP at

Re: [Xen-devel] [PATCH v2 04/18] xen: prepare common code for Xen PVH support

2018-10-18 Thread Juergen Gross
On 18/10/2018 16:59, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:03PM +0200, Juergen Gross wrote: >> Some common code needs to be special cased for Xen PVH mode. This hits >> mostly Xen PV mode specific areas. >> >> Signed-off-by: Juergen Gross >>

Re: [Xen-devel] [PATCH v2 01/18] xen: add some xen headers

2018-10-18 Thread Juergen Gross
On 18/10/2018 15:45, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:00PM +0200, Juergen Gross wrote: >> In order to support grub2 in Xen PVH environment some additional Xen >> headers are needed as grub2 will be started in PVH mode requiring to >> use several HVM hype

Re: [Xen-devel] [PATCH v2 04/18] xen: prepare common code for Xen PVH support

2018-10-19 Thread Juergen Gross
On 18/10/2018 17:39, Juergen Gross wrote: > On 18/10/2018 16:59, Daniel Kiper wrote: >> On Tue, Oct 09, 2018 at 01:03:03PM +0200, Juergen Gross wrote: >>> Some common code needs to be special cased for Xen PVH mode. This hits >>> mostly Xen PV mode specific areas. >

Re: [Xen-devel] [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-22 Thread Juergen Gross
On 22/10/2018 13:31, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: >> Add all usable memory regions to grub memory management and add the >> needed mmap iterate code. > > I am missing a few words why this patch is n

Re: [Xen-devel] [PATCH v2 14/18] xenpvh: add build runes for grub-core

2018-10-22 Thread Juergen Gross
On 22/10/2018 13:41, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:13PM +0200, Juergen Gross wrote: >> Add the modifications to the build system needed to build a xenpvh >> grub. >> >> Signed-off-by: Juergen Gross >> Reviewed-by: Daniel Kiper >> -

Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Juergen Gross
On 19/10/2018 17:40, Roger Pau Monné wrote: > On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: >> Add the needed code to setup the hypercall page for calling into the >> Xen hypervisor. >> >> Signed-off-by: Juergen Gross >> --- >&

Re: [Xen-devel] [PATCH v2 07/18] xen: add PVH specific defines to offset.h

2018-10-19 Thread Juergen Gross
On 19/10/2018 13:54, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:06PM +0200, Juergen Gross wrote: >> include/grub/offsets.h needs some defines for Xen PVH mode. >> >> Add them. While at it line up the values in the surrounding lines to >> start at the sa

Re: [Xen-devel] [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:17, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:08PM +0200, Juergen Gross wrote: >> Add the code for the Xen PVH mode boot entry. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/kern/i386/xen/startup_pvh.S | 50 >> +++

Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:30, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: >> Add the needed code to setup the hypercall page for calling into the >> Xen hypervisor. >> >> Signed-off-by: Juergen Gross >> --- >&

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Juergen Gross
On 19/10/2018 17:33, Roger Pau Monné wrote: > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:05, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. > > I am not against the code itself but it would be nice to know why you > add, AIUI, just stubs here which will be

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-19 Thread Juergen Gross
On 19/10/2018 18:10, Roger Pau Monné wrote: > On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: >> Initialize the needed Xen specific data. This is: >> >> - the Xen start of day page containing the console and Xenstore ring >> page PFN and event c

Re: [Xen-devel] per-domain configuration and inappropriate use of globals

2018-10-19 Thread Juergen Gross
On 19/10/2018 18:57, Andrew Cooper wrote: > In practice, having fine grain control of all the features like would be > excellent for testing purposes, because it allows you to boot two > otherwise-identical VMs with one configuration difference between them. > > In the spirit of the already in

Re: [Xen-devel] [PATCH] xen: remove redundant 'default n' from Kconfig

2018-10-17 Thread Juergen Gross
people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] add myself as reviewer for Xen support in Linux

2018-10-24 Thread Juergen Gross
On 17/10/2018 15:44, Stefano Stabellini wrote: > It would be good for me to keep an eye on the patches that touch Xen > support in Linux to try to spot changes that break Xen on ARM early on. > > Signed-off-by: Stefano Stabellini Pushed to xen.tip for-linus-4.20a Juergen

Re: [Xen-devel] [PATCH] xen: remove redundant 'default n' from Kconfig

2018-10-24 Thread Juergen Gross
On 16/10/2018 16:33, Bartlomiej Zolnierkiewicz wrote: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible symbols") the Kconfig

[Xen-devel] [PATCH v3 03/18] xen: carve out grant tab initialization into dedicated function

2018-10-24 Thread Juergen Gross
Initialize the grant tab in a dedicated function. This will enable using it for PVH guests, too. Call the new function from grub_machine_init() as this will later be common between Xen PV and Xen PVH mode. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- V2: update commit message

[Xen-devel] [PATCH v3 06/18] xen: rearrange xen/init.c to prepare it for Xen PVH mode

2018-10-24 Thread Juergen Gross
Rearrange grub-core/kern/xen/init.c to prepare adding PVH mode support to it. This includes putting some code under #ifdef GRUB_MACHINE_XEN as it will not be used when running as PVH. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- grub-core/kern/xen/init.c | 60

[Xen-devel] [PATCH v3 14/18] xen_pvh: add build runes for grub-core

2018-10-24 Thread Juergen Gross
Add the modifications to the build system needed to build a xen_pvh grub. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- V3: sorted some filenames (Daniel Kiper) --- gentpl.py | 4 ++-- grub-core/Makefile.am | 12 grub-core/Makefile.core.def

[Xen-devel] [PATCH v3 18/18] xen_pvh: add support to configure

2018-10-24 Thread Juergen Gross
Support platform i386/xen_pvh in configure. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 5e63c4af3..81a19afd5 100644 --- a/configure.ac +++ b/configure.ac @@ -151,6 +151,7

[Xen-devel] [PATCH v3 04/18] xen: prepare common code for Xen PVH support

2018-10-24 Thread Juergen Gross
of struct grub_e820_mmap_entry from grub-core/mmap/i386/pc/mmap.c to include/grub/i386/memory.h in order to make it usable from xen_pvh code. Signed-off-by: Juergen Gross --- V3: GRUB_MACHINE_XENPVH -> GRUB_MACHINE_XEN_PVH (Daniel Kiper) split include/grub/i386/pc/int.h (Daniel Kiper) m

[Xen-devel] [PATCH v3 05/18] xen: add some dummy headers for PVH mode

2018-10-24 Thread Juergen Gross
With Xen PVH mode adding a new machine type the machine related headers need to be present for the build to succeed. Most of the headers just need to include the related common i386 headers. Add those to the tree. Signed-off-by: Juergen Gross --- V3: updated commit message (Daniel Kiper

[Xen-devel] [PATCH v3 12/18] xen: setup Xen specific data for PVH

2018-10-24 Thread Juergen Gross
-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 106 ++ 1 file changed, 106 insertions(+) diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c index 58e6fefd5..487a87214 100644 --- a/grub-core/kern/i386/xen/pvh.c +++ b/grub-core/kern/i386

[Xen-devel] [PATCH v3 07/18] xen: add PVH specific defines to offset.h

2018-10-24 Thread Juergen Gross
include/grub/offsets.h needs some defines for Xen PVH mode. Add them. While at it line up the values in the surrounding lines to start at the same column. Signed-off-by: Juergen Gross --- V3: XENPVH->XEN_PVH (Daniel Kiper) --- include/grub/offsets.h | 21 - 1 file chan

[Xen-devel] [PATCH v3 10/18] xen: setup hypercall page for PVH

2018-10-24 Thread Juergen Gross
Add the needed code to setup the hypercall page for calling into the Xen hypervisor. Signed-off-by: Juergen Gross --- V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) issue panic message (Roger Pau Monné) rewrite grub_xen_hypercall to avoid register variables (Daniel Ki

[Xen-devel] [PATCH v3 02/18] loader/linux: support passing rsdp address via boot params

2018-10-24 Thread Juergen Gross
and the grub2 supported protocol version) if 2.14 or higher are in effect. Signed-off-by: Juergen Gross --- V2: add oring 0x8000 to version field V3: move including machine/kernel.h to patch 8 (Daniel Kiper) --- grub-core/loader/i386/linux.c | 8 include/grub/i386/linux.h | 5 - 2

[Xen-devel] [PATCH v3 15/18] grub-module-verifier: Ignore all_video for xenpvh

2018-10-24 Thread Juergen Gross
Signed-off-by: Juergen Gross --- util/grub-module-verifier.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/grub-module-verifier.c b/util/grub-module-verifier.c index 03ba1ab43..97cb9 100644 --- a/util/grub-module-verifier.c +++ b/util/grub-module-verifier.c @@ -129,6 +129,7

[Xen-devel] [PATCH v3 01/18] xen: add some xen headers

2018-10-24 Thread Juergen Gross
. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- V2: update commit message (Daniel Kiper) --- include/xen/hvm/hvm_op.h | 296 +++ include/xen/hvm/params.h | 284 ++ include/xen/hvm/start_info.h | 98 +++ include/xen/memory.h | 665

[Xen-devel] [PATCH v3 00/18] xen: add pvh guest support

2018-10-24 Thread Juergen Gross
deo for xenpvh Juergen Gross (17): xen: add some xen headers loader/linux: support passing rsdp address via boot params xen: carve out grant tab initialization into dedicated function xen: prepare common code for Xen PVH support xen: add some dummy headers for PVH mode xen: rearrange

[Xen-devel] [PATCH v3 09/18] xen: add PVH boot entry code

2018-10-24 Thread Juergen Gross
Add the code for the Xen PVH mode boot entry. Signed-off-by: Juergen Gross --- V3: clear %fs and %gs, too (Daniel Kiper) use GRUB_MEMORY_MACHINE_PROT_STACK_SIZE for stack size (Daniel Kiper) --- grub-core/kern/i386/xen/startup_pvh.S | 52 +++ 1 file changed

[Xen-devel] [PATCH v3 08/18] xen: add basic hooks for PVH in current code

2018-10-24 Thread Juergen Gross
Add the hooks to current code needed for Xen PVH. They will be filled with code later when the related functionality is being added. Signed-off-by: Juergen Gross --- V3: xenpvh->xen_pvh (Daniel Kiper) adjust copyright date (Roger Pau Monné) --- grub-core/kern/i386/xen/pvh.c |

[Xen-devel] [PATCH v3 17/18] xen_pvh: support grub-install for xen_pvh

2018-10-24 Thread Juergen Gross
Add xen_pvh support to grub-install. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- include/grub/util/install.h | 1 + util/grub-install-common.c | 1 + util/grub-install.c | 7 +++ 3 files changed, 9 insertions(+) diff --git a/include/grub/util/install.h b/include

Re: [Xen-devel] How to use PV drivers with fully virtualized HVM on x86?

2018-10-24 Thread Juergen Gross
On 24/10/2018 16:16, Jintack Lim wrote: > Hi, > > I'm interested running HVM DomU only with PV drivers (network and > disk). Enabling CONFIG_XEN_NETDEV_FRONTEND and stuff didn't make DomU > see the PV devices until I enabled CONFIG_XEN_PVHVM. Right, that's how it is done in modern Linux kernels.

[Xen-devel] [PATCH v3 11/18] xen: get memory map from hypervisor for PVH

2018-10-24 Thread Juergen Gross
Retrieve the memory map from the hypervisor and normalize it to contain no overlapping entries and to be sorted by address. Signed-off-by: Juergen Gross --- V3: use grub_e820_mmap_entry instead of own struct (Daniel Kiper) --- grub-core/kern/i386/xen/pvh.c | 96

Re: [Xen-devel] [PATCH v3 00/18] xen: add pvh guest support

2018-10-24 Thread Juergen Gross
On 24/10/2018 22:52, Hans van Kranenburg wrote: > Hi, > > On 10/24/2018 04:54 PM, Juergen Gross wrote: >> This patch series adds support for booting Linux as PVH guest. >> >> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh >> platform grub is boot

Re: [Xen-devel] [v3 04/12] x86/fsgsbase/64: Enable FSGSBASE instructions in the helper functions

2018-10-25 Thread Juergen Gross
On 24/10/2018 21:41, Andrew Cooper wrote: > On 24/10/18 20:16, Andy Lutomirski wrote: >> On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae >> wrote: >>> The helper functions will switch on faster accesses to FSBASE and GSBASE >>> when the FSGSBASE feature is enabled. >>> >>> Accessing user GSBASE

[Xen-devel] [PATCH V2] Release: add release note link to SUPPORT.md

2018-10-26 Thread Juergen Gross
In order to have a link to the release notes in the feature list generated from SUPPORT.md add that link in the "Release Support" section of that file. The real link needs to be adapted when the version is being released. Signed-off-by: Juergen Gross ---

Re: [Xen-devel] [PATCH V2] Release: add release note link to SUPPORT.md

2018-10-26 Thread Juergen Gross
On 26/10/2018 14:11, Jan Beulich wrote: On 26.10.18 at 13:07, wrote: >> --- a/SUPPORT.md >> +++ b/SUPPORT.md >> @@ -13,6 +13,7 @@ for the definitions of the support status levels etc. >> Initial-Release: n/a >> Supported-Until: TBD >> Security-Support-Until: Unreleased - not

[Xen-devel] [PATCH] x86/paravirt: remove unused _paravirt_ident_32

2018-10-30 Thread Juergen Gross
There is no user of _paravirt_ident_32 left in the tree. Remove it together with the related paravirt_patch_ident_32(). paravirt_patch_ident_64() can be moved inside CONFIG_PARAVIRT_XXL. Signed-off-by: Juergen Gross --- arch/x86/include/asm/paravirt_types.h | 2 -- arch/x86/kernel/paravirt.c

[Xen-devel] [GIT PULL] xen: fixes for 4.20-rc1

2018-10-30 Thread Juergen Gross
): xen: Make XEN_BACKEND selectable by DomU Juergen Gross (4): xen: fix race in xen_qlock_wait() xen: make xen_qlock_wait() nestable xen/pvh: don't try to unplug emulated devices xen: drop writing error messages to xenstore Roger Pau Monne (1): xen/pvh: increase early

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Juergen Gross
On 29/10/2018 19:31, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP: blkif_free_ring+33] > RIP:

Re: [Xen-devel] [PATCH v2] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM

2018-10-30 Thread Juergen Gross
On 30/10/2018 00:28, Stefano Stabellini wrote: > On Fri, 26 Oct 2018, Julien Grall wrote: >> Hi Stefano, >> >> On 10/26/18 7:04 PM, Stefano Stabellini wrote: >>> From: Stefano Stabellini >>> >>> xen_create_contiguous_region has now only an implementation if >>> CONFIG_XEN_PV is defined. However,

Re: [Xen-devel] [PATCH] xen: remove size limit of privcmd-buf mapping interface

2018-11-01 Thread Juergen Gross
On 01/11/2018 16:50, Jan Beulich wrote: >>>> Juergen Gross 11/01/18 3:23 PM >>> >> On 01/11/2018 15:18, Jan Beulich wrote: >>>>>> Juergen Gross 11/01/18 1:34 PM >>> >>>> Currently the size of hypercall buffers allocated via

Re: [Xen-devel] [PATCH] xen: remove size limit of privcmd-buf mapping interface

2018-11-01 Thread Juergen Gross
On 01/11/2018 15:18, Jan Beulich wrote: >>>> Juergen Gross 11/01/18 1:34 PM >>> >> Currently the size of hypercall buffers allocated via >> /dev/xen/hypercall is limited to a default of 64 memory pages. For live >> migration of guests this might be too s

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-30 Thread Juergen Gross
On 30/10/2018 12:23, Roger Pau Monné wrote: > On Mon, Oct 29, 2018 at 03:19:34PM +0100, Juergen Gross wrote: >> On 29/10/2018 13:57, Roger Pau Monné wrote: >>> On Fri, Oct 19, 2018 at 06:39:50PM +0200, Juergen Gross wrote: >>>> On 19/10/2018 18:10, Roger Pau Monné wro

Re: [Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Juergen Gross
mq to cover all cases of > new VBDs") > Signed-off-by: Manjunath Patil Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen: drop writing error messages to xenstore

2018-10-25 Thread Juergen Gross
On 11/10/2018 13:03, Joao Martins wrote: > On 10/11/2018 06:05 AM, Juergen Gross wrote: >> On 10/10/2018 18:57, Boris Ostrovsky wrote: >>> On 10/10/18 11:53 AM, Juergen Gross wrote: >>>> On 10/10/2018 17:09, Joao Martins wrote: >>>>>

[Xen-devel] [PATCH v4 10/19] xen: setup hypercall page for PVH

2018-11-02 Thread Juergen Gross
Add the needed code to setup the hypercall page for calling into the Xen hypervisor. Signed-off-by: Juergen Gross --- V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) issue panic message (Roger Pau Monné) rewrite grub_xen_hypercall to avoid register variables (Daniel Ki

<    6   7   8   9   10   11   12   13   14   15   >