Re: [Xen-devel] [PATCH] xen: remove size limit of privcmd-buf mapping interface

2018-11-02 Thread Juergen Gross
On 02/11/2018 08:26, Jan Beulich wrote: >>>> On 01.11.18 at 17:27, wrote: >> On 01/11/2018 16:50, Jan Beulich wrote: >>>>>> Juergen Gross 11/01/18 3:23 PM >>> >>>> On 01/11/2018 15:18, Jan Beulich wrote: >>>>>>>> J

[Xen-devel] [PATCH v4 01/19] xen: add some xen headers

2018-11-02 Thread Juergen Gross
. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- V2: update commit message (Daniel Kiper) --- include/xen/hvm/hvm_op.h | 296 +++ include/xen/hvm/params.h | 284 ++ include/xen/hvm/start_info.h | 98 +++ include/xen/memory.h | 665

[Xen-devel] [PATCH v4 07/19] xen: add PVH specific defines to offset.h

2018-11-02 Thread Juergen Gross
include/grub/offsets.h needs some defines for Xen PVH mode. Add them. While at it line up the values in the surrounding lines to start at the same column. Signed-off-by: Juergen Gross --- V3: XENPVH->XEN_PVH (Daniel Kiper) --- include/grub/offsets.h | 21 - 1 file chan

[Xen-devel] [PATCH v4 14/19] xen: init memory regions for PVH

2018-11-02 Thread Juergen Gross
Add all usable memory regions to grub memory management and add the needed mmap iterate code, which will be used by grub core (e.g. grub-core/lib/relocator.c or grub-core/mmap/mmap.c). As we are running in 32-bit mode don't add memory above 4GB. Signed-off-by: Juergen Gross --- grub-core/kern

[Xen-devel] [PATCH v4 03/19] xen: carve out grant tab initialization into dedicated function

2018-11-02 Thread Juergen Gross
Initialize the grant tab in a dedicated function. This will enable using it for PVH guests, too. Call the new function from grub_machine_init() as this will later be common between Xen PV and Xen PVH mode. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- V2: update commit message

[Xen-devel] [PATCH v4 06/19] xen: rearrange xen/init.c to prepare it for Xen PVH mode

2018-11-02 Thread Juergen Gross
Rearrange grub-core/kern/xen/init.c to prepare adding PVH mode support to it. This includes putting some code under #ifdef GRUB_MACHINE_XEN as it will not be used when running as PVH. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- grub-core/kern/xen/init.c | 60

[Xen-devel] [PATCH v4 08/19] xen: add basic hooks for PVH in current code

2018-11-02 Thread Juergen Gross
Add the hooks to current code needed for Xen PVH. They will be filled with code later when the related functionality is being added. Signed-off-by: Juergen Gross --- V3: xenpvh->xen_pvh (Daniel Kiper) adjust copyright date (Roger Pau Monné) --- grub-core/kern/i386/xen/pvh.c |

[Xen-devel] [PATCH v4 02/19] loader/linux: support passing rsdp address via boot params

2018-11-02 Thread Juergen Gross
and the grub2 supported protocol version) if 2.14 or higher are in effect. Signed-off-by: Juergen Gross --- V2: add oring 0x8000 to version field V3: move including machine/kernel.h to patch 8 (Daniel Kiper) --- grub-core/loader/i386/linux.c | 8 include/grub/i386/linux.h | 5 - 2

[Xen-devel] [PATCH v4 09/19] xen: add PVH boot entry code

2018-11-02 Thread Juergen Gross
Add the code for the Xen PVH mode boot entry. Signed-off-by: Juergen Gross --- V3: clear %fs and %gs, too (Daniel Kiper) use GRUB_MEMORY_MACHINE_PROT_STACK_SIZE for stack size (Daniel Kiper) --- grub-core/kern/i386/xen/startup_pvh.S | 52 +++ 1 file changed

[Xen-devel] [PATCH v4 18/19] xen_pvh: support grub-install for xen_pvh

2018-11-02 Thread Juergen Gross
Add xen_pvh support to grub-install. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- include/grub/util/install.h | 1 + util/grub-install-common.c | 1 + util/grub-install.c | 7 +++ 3 files changed, 9 insertions(+) diff --git a/include/grub/util/install.h b/include

[Xen-devel] [PATCH v4 00/19] xen: add pvh guest support

2018-11-02 Thread Juergen Gross
ual patches) Hans van Kranenburg (1): grub-module-verifier: Ignore all_video for xenpvh Juergen Gross (18): xen: add some xen headers loader/linux: support passing rsdp address via boot params xen: carve out grant tab initialization into dedicated function xen: prepare common code for

[Xen-devel] [PATCH v4 17/19] xen_pvh: support building a standalone image

2018-11-02 Thread Juergen Gross
Support mkimage for xen_pvh. In order to avoid using plain integers for the ELF notes use the available Xen include instead. While at it replace the plain numbers for Xen PV mode, too. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- V2: some style adjustments (Daniel Kiper) use

[Xen-devel] [PATCH v4 05/19] xen: add some dummy headers for PVH mode

2018-11-02 Thread Juergen Gross
With Xen PVH mode adding a new machine type the machine related headers need to be present for the build to succeed. Most of the headers just need to include the related common i386 headers. Add those to the tree. Signed-off-by: Juergen Gross --- V3: updated commit message (Daniel Kiper

[Xen-devel] [PATCH v4 11/19] xen: get memory map from hypervisor for PVH

2018-11-02 Thread Juergen Gross
Retrieve the memory map from the hypervisor and normalize it to contain no overlapping entries and to be sorted by address. Signed-off-by: Juergen Gross --- V3: use grub_e820_mmap_entry instead of own struct (Daniel Kiper) --- grub-core/kern/i386/xen/pvh.c | 96

[Xen-devel] [PATCH v4 19/19] xen_pvh: add support to configure

2018-11-02 Thread Juergen Gross
Support platform i386/xen_pvh in configure. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 5e63c4af3..81a19afd5 100644 --- a/configure.ac +++ b/configure.ac @@ -151,6 +151,7

[Xen-devel] [PATCH v4 15/19] xen_pvh: add build runes for grub-core

2018-11-02 Thread Juergen Gross
Add the modifications to the build system needed to build a xen_pvh grub. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- V3: sorted some filenames (Daniel Kiper) V4: add bus/pci.c to xen_pvh --- gentpl.py | 4 ++-- grub-core/Makefile.am | 12

[Xen-devel] [PATCH v4 16/19] grub-module-verifier: Ignore all_video for xenpvh

2018-11-02 Thread Juergen Gross
Signed-off-by: Juergen Gross --- util/grub-module-verifier.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/grub-module-verifier.c b/util/grub-module-verifier.c index 03ba1ab43..97cb9 100644 --- a/util/grub-module-verifier.c +++ b/util/grub-module-verifier.c @@ -129,6 +129,7

[Xen-devel] [PATCH v4 12/19] xen: add PCI MMIO areas to memory map

2018-11-02 Thread Juergen Gross
Add possible PCI space MMIO areas as "Reserved" to the memory map in order to avoid using those areas for special Xen pages later. Signed-off-by: Juergen Gross --- V4: new patch (Roger Pau Monné) --- grub-core/kern/i386/xen/pvh.c | 70 +++ 1 fi

[Xen-devel] [PATCH v4 13/19] xen: setup Xen specific data for PVH

2018-11-02 Thread Juergen Gross
there again. Set the RSDP address for the guest from the start_info page passed as boot parameter. Signed-off-by: Juergen Gross --- V4: write back memory map to Xen (Roger Pau Monné) --- grub-core/kern/i386/xen/pvh.c | 119 ++ 1 file changed, 119 insertions

[Xen-devel] [PATCH v4 04/19] xen: prepare common code for Xen PVH support

2018-11-02 Thread Juergen Gross
of struct grub_e820_mmap_entry from grub-core/mmap/i386/pc/mmap.c to include/grub/i386/memory.h in order to make it usable from xen_pvh code. Signed-off-by: Juergen Gross --- V3: GRUB_MACHINE_XENPVH -> GRUB_MACHINE_XEN_PVH (Daniel Kiper) split include/grub/i386/pc/int.h (Daniel Kiper) m

Re: [Xen-devel] [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message

2018-11-02 Thread Juergen Gross
('xen/grant-table: Allow allocating buffers suitable for > DMA') > Reported-by: Ross Philipson > Signed-off-by: Liam Merwick > Reviewed-by: Mark Kanda Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenp

Re: [Xen-devel] [PATCH v3] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM

2018-11-02 Thread Juergen Gross
ks.com > CC: jarvis.ro...@dornerworks.com > CC: nathan.stu...@dornerworks.com > CC: vkuzn...@redhat.com > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com > CC: julien.gr...@arm.com Reviewed-by: Juergen Gross Juergen ___

Re: [Xen-devel] [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM

2018-10-26 Thread Juergen Gross
On 16/10/2018 10:38, Stefano Stabellini wrote: > xen_create_contiguous_region has now only an implementation if > CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but > we do have an implementation of xen_create_contiguous_region which is > required for swiotlb-xen to work

[Xen-devel] [PATCH] Release: add release note link to SUPPORT.md

2018-10-26 Thread Juergen Gross
In order to have a link to the release notes in the feature list generated from SUPPORT.md add that link in the "Release Support" section of that file. The real link needs to be adapted when the version is being released. Signed-off-by: Juergen Gross --- SUPPORT.md | 1 + 1 file

[Xen-devel] [PATCH] docs: remove ChangeLog file

2018-10-26 Thread Juergen Gross
docs/ChangeLog has been updated for Xen 3.3 last time. It seems to be interesting for archaeologists only today. Remove it. Signed-off-by: Juergen Gross --- docs/ChangeLog | 135 - 1 file changed, 135 deletions(-) delete mode 100644 docs

[Xen-devel] [PATCH] x86/paravirt: pv_ops isn't GPL only

2018-10-29 Thread Juergen Gross
). Change that by using EXPORT_SYMBOL(pv_ops). Fixes: 5c83511bdb9832 ("x86/paravirt: Use a single ops structure") Signed-off-by: Juergen Gross --- arch/x86/kernel/paravirt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/ker

Re: [Xen-devel] [PATCH] Release: add release note link to SUPPORT.md

2018-10-26 Thread Juergen Gross
On 26/10/2018 12:39, Jan Beulich wrote: On 26.10.18 at 12:22, wrote: >> --- a/SUPPORT.md >> +++ b/SUPPORT.md >> @@ -13,6 +13,7 @@ for the definitions of the support status levels etc. >> Initial-Release: n/a >> Supported-Until: TBD >> Security-Support-Until: Unreleased - not

[Xen-devel] [PATCH V2] Release: add release note link to SUPPORT.md

2018-10-26 Thread Juergen Gross
In order to have a link to the release notes in the feature list generated from SUPPORT.md add that link in the "Release Support" section of that file. The real link needs to be adapted when the version is being released. Signed-off-by: Juergen Gross ---

[Xen-devel] [PATCH] xen/pvh: don't try to unplug emulated devices

2018-10-25 Thread Juergen Gross
value Cc: # 4.11 Signed-off-by: Juergen Gross --- arch/x86/xen/platform-pci-unplug.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c index 66ab96a4e2b3..96d7f7d39cb9 100644 --- a/arch/x86/xen/platform-pci-unplug.c +++ b

Re: [Xen-devel] [PATCH] idle/x86: remove the call to boot_init_stack_canary() from cpu_startup_entry()

2018-10-19 Thread Juergen Gross
artup_entry(): > - start_secondary() > - cpu_bringup_and_idle() > > start_secondary() already calls boot_init_stack_canary(). > > This patch adds the call to boot_init_stack_canary() in > cpu_bringup_and_idle() and removes it from cpu_startup_entry() > > Signed-off-by: Christophe

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-08 Thread Juergen Gross
On 08/11/2018 09:14, Sander Eikelenboom wrote: > On 08/11/18 08:08, Juergen Gross wrote: >> On 07/11/2018 10:30, Sander Eikelenboom wrote: >>> Hi Juergen / Boris, >>> >>> Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20"

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-08 Thread Juergen Gross
On 08/11/2018 10:57, Sander Eikelenboom wrote: > On 08/11/18 09:18, Juergen Gross wrote: >> On 08/11/2018 09:14, Sander Eikelenboom wrote: >>> On 08/11/18 08:08, Juergen Gross wrote: >>>> On 07/11/2018 10:30, Sander Eikelenboom wrote: >>>>> Hi Juergen

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-07 Thread Juergen Gross
On 07/11/2018 10:30, Sander Eikelenboom wrote: > Hi Juergen / Boris, > > Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" > branch pulled on top. > Unfortunately i was seeing guests lockup after some time, see below for the > logging from one of the guest > which i

Re: [Xen-devel] [PATCH v4 05/19] xen: add some dummy headers for PVH mode

2018-11-08 Thread Juergen Gross
On 08/11/2018 16:36, Daniel Kiper wrote: > On Wed, Nov 07, 2018 at 03:49:51PM +0100, Juergen Gross wrote: >> On 07/11/2018 13:21, Daniel Kiper wrote: >>> On Fri, Nov 02, 2018 at 01:37:24PM +0100, Juergen Gross wrote: >>>> With Xen PVH mode adding a new machine ty

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

2018-11-10 Thread Juergen Gross
On 10/11/2018 08:16, H. Peter Anvin wrote: > On 11/9/18 11:02 PM, Juergen Gross wrote: >>> >>> Yes. We know that and it is resolved by: >>> >>> a) the length field in setup_header; >>> b) the "sentinel" field which catches legacy non-

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

2018-11-09 Thread Juergen Gross
On 10/11/2018 07:32, H. Peter Anvin wrote: >> >> Unfortunately there are many major distros shipping boot loaders which >> write crap data past the end of setup_header. >> > > Yes. We know that and it is resolved by: > > a) the length field in setup_header; > b) the "sentinel" field which

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

2018-11-09 Thread Juergen Gross
On 09/11/2018 23:23, H. Peter Anvin wrote: > I just noticed this patch -- I missed it because the cover message > seemed far more harmless so I didn't notice this change. > > THIS PATCH IS FATALLY WRONG AND NEEDS TO BE IMMEDIATELY REVERTED BEFORE > ANYONE STARTS RELYING ON IT; IT HAS THE

Re: [Xen-devel] [PATCH v4 08/19] xen: add basic hooks for PVH in current code

2018-11-08 Thread Juergen Gross
On 08/11/2018 16:45, Daniel Kiper wrote: > On Fri, Nov 02, 2018 at 01:37:27PM +0100, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. They will be filled >> with code later when the related functionality is being added. >> >> Signed-off-by:

[Xen-devel] [GIT PULL] xen: fixes for 4.20-rc2

2018-11-10 Thread Juergen Gross
| 12 +++- 7 files changed, 53 insertions(+), 36 deletions(-) Juergen Gross (3): x86/xen: fix pv boot xen: fix xen_qlock_wait() xen: remove size limit of privcmd-buf mapping interface Liam Merwick (1): xen/grant-table: Fix incorrect gnttab_dma_free_pages

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

2018-11-10 Thread Juergen Gross
On 09/11/2018 23:23, H. Peter Anvin wrote: > I just noticed this patch -- I missed it because the cover message > seemed far more harmless so I didn't notice this change. > > THIS PATCH IS FATALLY WRONG AND NEEDS TO BE IMMEDIATELY REVERTED BEFORE > ANYONE STARTS RELYING ON IT; IT HAS THE

Re: [Xen-devel] [PATCH] x86/xen: fix pv boot

2018-11-07 Thread Juergen Gross
On 07/11/2018 13:02, Andrew Cooper wrote: > On 07/11/18 11:55, Andrew Cooper wrote: >> On 07/11/18 11:30, Juergen Gross wrote: >>> + return ret; >>> } >>> >>> static inline int xen_safe_read_ulong(unsigned long *addr, unsigned long >>>

[Xen-devel] [PATCH] x86/xen: fix pv boot

2018-11-07 Thread Juergen Gross
s helpers fault on kernel addresses") Signed-off-by: Juergen Gross --- arch/x86/include/asm/xen/page.h | 39 --- arch/x86/xen/p2m.c | 3 +-- 2 files changed, 37 insertions(+), 5 deletions(-) diff --git a/arch/x86/include/asm/xen/page.h b/arch

Re: [Xen-devel] [PATCH v3] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM

2018-11-06 Thread Juergen Gross
On 01/11/2018 00:11, Stefano Stabellini wrote: > From: Stefano Stabellini > > xen_create_contiguous_region has now only an implementation if > CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but > we do have an implementation of xen_create_contiguous_region which is >

Re: [Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-11-06 Thread Juergen Gross
On 30/10/2018 17:49, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP: blkif_free_ring+33] > RIP:

Re: [Xen-devel] [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message

2018-11-06 Thread Juergen Gross
On 02/11/2018 15:04, Liam Merwick wrote: > If a call to xenmem_reservation_increase() in gnttab_dma_free_pages() > fails it triggers a message "Failed to decrease reservation..." which > should be "Failed to increase reservation..." > > Fixes: 9bdc7304f536 ('xen/grant-table: Allow allocating

Re: [Xen-devel] [PATCH v4 05/19] xen: add some dummy headers for PVH mode

2018-11-07 Thread Juergen Gross
On 07/11/2018 13:21, Daniel Kiper wrote: > On Fri, Nov 02, 2018 at 01:37:24PM +0100, Juergen Gross wrote: >> With Xen PVH mode adding a new machine type the machine related headers >> need to be present for the build to succeed. Most of the headers just >> need to include th

Re: [Xen-devel] x86 Community Call: Nov 14 - 15:00 - 16:00 UTC - Call for Agenda Items

2018-11-07 Thread Juergen Gross
On 07/11/2018 16:06, Daniel Kiper wrote: > On Wed, Nov 07, 2018 at 11:49:38AM +0100, Daniel Kiper wrote: >> On Tue, Nov 06, 2018 at 09:54:54AM -0700, Jan Beulich wrote: >> On 02.11.18 at 18:59, wrote: It’s time again for the x86 community call: for the agenda see

Re: [Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Juergen Gross
On 09/11/2018 11:56, George Dunlap wrote: > On 11/9/18 10:16 AM, Juergen Gross wrote: >> This email only tracks big items for xen.git tree. Please reply for items you >> would like to see in 4.12 so that people have an idea what is going on and >> prioritise accordingly.

[Xen-devel] Xen 4.12 Development Update

2018-11-09 Thread Juergen Gross
(v1) - Luwei Kang * Linux stub domains (RFC v2) - Marek Marczykowski-Górecki * dom0less (boot multiple domains from device tree) (v4) - Stefano Stabellini == Grub2 == * Support PVH guest boot (v4) - Juergen Gross == Completed == * guest resource mapping - Paul Durrant

[Xen-devel] [PATCH v2] x86/xen: fix pv boot

2018-11-07 Thread Juergen Gross
s helpers fault on kernel addresses") Signed-off-by: Juergen Gross --- arch/x86/include/asm/xen/page.h | 35 +++ arch/x86/xen/p2m.c | 3 +-- 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/xen/page.h b/arch

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Juergen Gross
On 09/11/2018 16:02, Sander Eikelenboom wrote: > On 09/11/18 13:04, Juergen Gross wrote: >> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") >> introduced a regression for Xen guests running fully virtualized >> (HVM or PVH mode). The Xen hyperviso

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Juergen Gross
On 09/11/2018 16:29, Sander Eikelenboom wrote: > On 09/11/18 16:20, Juergen Gross wrote: >> On 09/11/2018 16:02, Sander Eikelenboom wrote: >>> On 09/11/18 13:04, Juergen Gross wrote: >>>> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") >

Re: [Xen-devel] [PATCH] xen/netfront: remove unnecessary wmb

2018-11-08 Thread Juergen Gross
On 09/11/2018 07:53, Jacob Wen wrote: > RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees > requests before req_prod is updated. > > Signed-off-by: Jacob Wen Reviewed-by: Juergen Gross Juergen ___ Xen-devel

Re: [Xen-devel] [PATCH] xen: remove size limit of privcmd-buf mapping interface

2018-11-08 Thread Juergen Gross
Ping? Jan's remark regarding de-privileged qemu is no issue as the hypercall node is being closed by the de-privilege library function. Juergen On 01/11/2018 13:33, Juergen Gross wrote: > Currently the size of hypercall buffers allocated via > /dev/xen/hypercall is limited to a default

Re: [Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with blkfront_remove()

2018-11-08 Thread Juergen Gross
On 09/11/2018 02:10, Manjunath Patil wrote: > When we try to detach the device, blkfront_remove() tries to access > blkfront_info leading to kernel panic. > > Typical call stack involving panic - > #10 page_fault at 816f25df > [exception RIP: blkif_free+46] > #11 blkfront_remove at

[Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Juergen Gross
So instead of disabling interrupts in xen_qlock_wait() use a nesting counter to avoid calling xen_clear_irq_pending() in case xen_qlock_wait() is nested. Fixes: a856531951dc80 ("xen: make xen_qlock_wait() nestable") Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- arch/x86

Re: [Xen-devel] [PATCH] libxl: Restore scheduling parameters after migrate in best-effort fashion

2018-10-03 Thread Juergen Gross
LIBXL_SCHEDULER_UNKNOWN. This will propagate > scheduler parameters from the previous instantiation on a best-effort > basis. > > Signed-off-by: George Dunlap Acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 00/12] add per-domain and per-cpupool generic parameters

2018-10-03 Thread Juergen Gross
On 03/10/2018 13:00, Wei Liu wrote: > On Wed, Sep 26, 2018 at 07:30:38PM +0200, Dario Faggioli wrote: >> On Fri, 2018-09-21 at 09:52 +0100, Wei Liu wrote: >>> On Fri, Sep 21, 2018 at 07:23:23AM +0200, Juergen Gross wrote: >>>> On 20/09/18 18:06, Wei Liu

[Xen-devel] [PATCH v5 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-10 Thread Juergen Gross
In case the rsdp address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- V3: use a generic retrieval function with a __weak annotated default function (Ingo Molnar) V4

[Xen-devel] [PATCH v5 0/3] x86: make rsdp address accessible via boot params

2018-10-10 Thread Juergen Gross
. In order to support an arbitrary RSDP address this patch series adds the physical address of the RSDP to the boot params structure filled by the boot loader. Juergen Gross (3): x86/xen: fix boot loader version reported for pvh guests x86/boot: add acpi rsdp address to setup_header x86/acpi

[Xen-devel] [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

2018-10-10 Thread Juergen Gross
. Signed-off-by: Juergen Gross --- V3: fix commit message and some documentation bits (Ingo Molnar) V4: add version feedback from bootloader --- Documentation/x86/boot.txt| 32 +++- arch/x86/boot/header.S| 6 +- arch/x86/include/asm

[Xen-devel] [PATCH v5 1/3] x86/xen: fix boot loader version reported for pvh guests

2018-10-10 Thread Juergen Gross
# 4.12 Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pvh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c index c85d1a88f476..f7f77023288a 100644 --- a/arch/x86/xen/enlighten_pvh.c +++ b/arch/x86/xen/enlighten

Re: [Xen-devel] [PATCH v5 0/3] x86: make rsdp address accessible via boot params

2018-10-10 Thread Juergen Gross
On 10/10/2018 08:23, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> In the non-EFI boot path the ACPI RSDP table is currently found via >> either EBDA or by searching through low memory for the RSDP magic. >> This requires the RSDP to be located in the first 1MB

Re: [Xen-devel] [PATCH v5 0/3] x86: make rsdp address accessible via boot params

2018-10-10 Thread Juergen Gross
On 10/10/2018 09:19, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> You can just dive into the discussion we had back in February: > > That was half a year and a thousand commits ago! ;-) Yes. :-) > >> https://lore.kernel.org/lkml/20180213163

[Xen-devel] [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Juergen Gross
In case the rsdp address in struct boot_params is specified don't try to find the table by searching, but take the address directly as set by the boot loader. Signed-off-by: Juergen Gross --- V3: use a generic retrieval function with a __weak annotated default function (Ingo Molnar) V4

[Xen-devel] [PATCH v4 2/3] x86/boot: add acpi rsdp address to setup_header

2018-10-09 Thread Juergen Gross
. Signed-off-by: Juergen Gross --- V3: fix commit message and some documentation bits (Ingo Molnar) V4: add version feedback from bootloader --- Documentation/x86/boot.txt| 32 +++- arch/x86/boot/header.S| 6 +- arch/x86/include/asm

[Xen-devel] [PATCH v4 0/3] x86: make rsdp address accessible via boot params

2018-10-09 Thread Juergen Gross
. In order to support an arbitrary RSDP address this patch series adds the physical address of the RSDP to the boot params structure filled by the boot loader. Juergen Gross (3): x86/xen: fix boot loader version reported for pvh guests x86/boot: add acpi rsdp address to setup_header x86/acpi

[Xen-devel] [PATCH v4 1/3] x86/xen: fix boot loader version reported for pvh guests

2018-10-09 Thread Juergen Gross
# 4.12 Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pvh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c index c85d1a88f476..f7f77023288a 100644 --- a/arch/x86/xen/enlighten_pvh.c +++ b/arch/x86/xen/enlighten

[Xen-devel] [PATCH v2 13/18] xen: init memory regions for PVH

2018-10-09 Thread Juergen Gross
Add all usable memory regions to grub memory management and add the needed mmap iterate code. As we are running in 32-bit mode don't add memory above 4GB. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 35 +++ 1 file changed, 35 insertions

[Xen-devel] [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-09 Thread Juergen Gross
Add the code for the Xen PVH mode boot entry. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/startup_pvh.S | 50 +++ 1 file changed, 50 insertions(+) diff --git a/grub-core/kern/i386/xen/startup_pvh.S b/grub-core/kern/i386/xen/startup_pvh.S index

[Xen-devel] [PATCH v2 00/18] xen: add pvh guest support

2018-10-09 Thread Juergen Gross
the setup_header) - split former patch 4 into 10 patches - fix memmap handling for >4GB of memory - added new patch from Hans (thanks for that one) - addressed most of Daniel's comments (see individual patches) Hans van Kranenburg (1): grub-module-verifier: Ignore all_video for xenpvh Juergen Gross

[Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-09 Thread Juergen Gross
Add the hooks to current code needed for Xen PVH. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 36 +++ grub-core/kern/i386/xen/startup_pvh.S | 29 grub-core/kern/xen/init.c | 6 ++ include

[Xen-devel] [PATCH v2 07/18] xen: add PVH specific defines to offset.h

2018-10-09 Thread Juergen Gross
include/grub/offsets.h needs some defines for Xen PVH mode. Add them. While at it line up the values in the surrounding lines to start at the same column. Signed-off-by: Juergen Gross --- include/grub/offsets.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff

[Xen-devel] [PATCH v2 18/18] xenpvh: add support to configure

2018-10-09 Thread Juergen Gross
Support platform i386/xenpvh in configure. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 5e63c4af3..96d81a3f2 100644 --- a/configure.ac +++ b/configure.ac @@ -151,6 +151,7 @@ case

[Xen-devel] [PATCH v2 04/18] xen: prepare common code for Xen PVH support

2018-10-09 Thread Juergen Gross
Some common code needs to be special cased for Xen PVH mode. This hits mostly Xen PV mode specific areas. Signed-off-by: Juergen Gross --- grub-core/kern/i386/tsc.c | 2 +- include/grub/i386/pc/int.h| 3 +++ include/grub/i386/tsc.h | 2 +- include/grub/i386/xen

[Xen-devel] [PATCH v2 11/18] xen: get memory map from hypervisor for PVH

2018-10-09 Thread Juergen Gross
Retrieve the memory map from the hypervisor and normalize it to contain no overlapping entries and to be sorted by address. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 98 +++ 1 file changed, 98 insertions(+) diff --git a/grub-core

[Xen-devel] [PATCH v2 06/18] xen: rearrange xen/init.c to prepare it for Xen PVH mode

2018-10-09 Thread Juergen Gross
Rearrange grub-core/kern/xen/init.c to prepare adding PVH mode support to it. This includes putting some code under #ifdef GRUB_MACHINE_XEN as it will not be used when running as PVH. Signed-off-by: Juergen Gross --- grub-core/kern/xen/init.c | 60

[Xen-devel] [PATCH v2 03/18] xen: carve out grant tab initialization into dedicated function

2018-10-09 Thread Juergen Gross
Initialize the grant tab in a dedicated function. This will enable using it for PVH guests, too. Call the new function from grub_machine_init() as this will later be common between Xen PV and Xen PVH mode. Signed-off-by: Juergen Gross --- V2: update commit message (Daniel Kiper) --- grub-core

[Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-09 Thread Juergen Gross
Add the needed code to setup the hypercall page for calling into the Xen hypervisor. Signed-off-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern

Re: [Xen-devel] [PATCH] xen/pvh: increase early stack size

2018-10-09 Thread Juergen Gross
gned-off-by: Roger Pau Monné Reviewed-by: Juergen Gross I'll add a "Cc: stable" when committing. Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params

2018-10-09 Thread Juergen Gross
and the grub2 supported protocol version) if 2.14 or higher are in effect. Signed-off-by: Juergen Gross --- V2: add oring 0x8000 to version field --- grub-core/loader/i386/linux.c | 9 + include/grub/i386/linux.h | 5 - 2 files changed, 13 insertions(+), 1 deletion(-) diff --git

[Xen-devel] [PATCH v2 14/18] xenpvh: add build runes for grub-core

2018-10-09 Thread Juergen Gross
Add the modifications to the build system needed to build a xenpvh grub. Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper --- gentpl.py | 4 ++-- grub-core/Makefile.am | 12 grub-core/Makefile.core.def | 35 +++ 3

[Xen-devel] [PATCH v2 01/18] xen: add some xen headers

2018-10-09 Thread Juergen Gross
. Signed-off-by: Juergen Gross --- V2: update commit message (Daniel Kiper) --- include/xen/hvm/hvm_op.h | 296 +++ include/xen/hvm/params.h | 284 ++ include/xen/hvm/start_info.h | 98 +++ include/xen/memory.h | 665

[Xen-devel] [PATCH v2 15/18] grub-module-verifier: Ignore all_video for xenpvh

2018-10-09 Thread Juergen Gross
From: Hans van Kranenburg This solves the build failing with "Error: no symbol table and no .moddeps section" Also see: - 6371e9c10433578bb236a8284ddb9ce9e201eb59 - https://savannah.gnu.org/bugs/?49012 Signed-off-by: Hans van Kranenburg --- V2: new patch Signed-off-by: Jue

[Xen-devel] [PATCH v2 16/18] xenpvh: support building a standalone image

2018-10-09 Thread Juergen Gross
Support mkimage for xenpvh. In order to avoid using plain integers for the ELF notes use the available Xen include instead. While at it replace the plain numbers for Xen PV mode, too. Signed-off-by: Juergen Gross --- V2: some style adjustments (Daniel Kiper) use defines for elf-notes

[Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-09 Thread Juergen Gross
-by: Juergen Gross --- grub-core/kern/i386/xen/pvh.c | 107 ++ 1 file changed, 107 insertions(+) diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c index b4933b454..93ed68245 100644 --- a/grub-core/kern/i386/xen/pvh.c +++ b/grub-core/kern/i386

Re: [Xen-devel] [PATCH 0/8] xen: add pvh guest support

2018-10-09 Thread Juergen Gross
On 15/02/2018 13:02, Daniel Kiper wrote: > Hi Juergen, > > Sorry for huge delay. It looks that I am recovering slowly and > probably I will have more time for reviews. > > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: >> This patch series adds support

Re: [Xen-devel] [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling

2018-10-09 Thread Juergen Gross
On 09/10/2018 16:40, David Woodhouse wrote: > On Mon, 2018-10-01 at 09:16 +0200, Juergen Gross wrote: >> The Xen specific queue spinlock wait function has two issues which >> could result in a hanging system. >> >> They have a similar root cause of clearing a pending

Re: [Xen-devel] [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Juergen Gross
On 09/10/2018 15:22, Boris Ostrovsky wrote: > On 10/9/18 6:54 AM, Juergen Gross wrote: >> + >> +u64 x86_default_get_root_pointer(void) >> +{ >> +return boot_params.hdr.acpi_rsdp_addr; >> +} > > > Should we then update init_pvh_bootparams() with

Re: [Xen-devel] [PATCH] xen/balloon: Support xend-based toolstack

2018-10-09 Thread Juergen Gross
> Cc: # 4.13 Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] xen: drop writing error messages to xenstore

2018-10-09 Thread Juergen Gross
was added in the first pvops rush of commits in 2007. So remove the additional message when writing to Xenstore failed as a minimum step. Signed-off-by: Juergen Gross --- I am considering removing the Xenstore write altogether, but I'm not sure it isn't needed e.g. by xend based installations. So pleas

Re: [Xen-devel] [PATCH] xen/pvh: increase early stack size

2018-10-10 Thread Juergen Gross
On 09/10/2018 12:32, Roger Pau Monne wrote: > While booting on an AMD EPYC box the stack canary would detect stack > overflows when using the current PVH early stack size (256). Switch to > using the value defined by BOOT_STACK_SIZE, which prevents the stack > overflow. > > Signed-off-by: Roger

Re: [Xen-devel] [PATCH] xen/balloon: Support xend-based toolstack

2018-10-10 Thread Juergen Gross
On 07/10/2018 22:05, Boris Ostrovsky wrote: > Xend-based toolstacks don't have static-max entry in xenstore. The > equivalent node for those toolstacks is memory_static_max. > > Fixes: 5266b8e4445c (xen: fix booting ballooned down hvm guest) > Signed-off-by: Boris Ostrovsky > Cc: # 4.13

Re: [Xen-devel] [PATCH 2/2] xl: add target cpupool parameter to xl migrate

2018-10-02 Thread Juergen Gross
On 02/10/2018 16:42, Andrew Cooper wrote: > On 02/10/18 15:19, Juergen Gross wrote: >> Add an option to specify the cpupool on the target machine when doing >> a migration of a domain. Currently a domain is always migrated to the >> cpupool with the same name as

[Xen-devel] [PATCH 1/2] libxl: modify domain config when moving domain to another cpupool

2018-10-02 Thread Juergen Gross
Today the domain config info contains the cpupool name the domain was started in only if the cpupool was specified at domain creation. Moving the domain to another cpupool later won't change that information. Correct that by modifying the domain config accordingly. Signed-off-by: Juergen Gross

[Xen-devel] [PATCH 2/2] xl: add target cpupool parameter to xl migrate

2018-10-02 Thread Juergen Gross
Specifying an empty string for will use the default cpupool (normally "Pool-0") on the target machine. Signed-off-by: Juergen Gross --- docs/man/xl.pod.1.in | 5 + tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c| 3 +++ tools/xl/xl_migrate.c | 15 +

Re: [Xen-devel] [PATCH 1/2] xen: fix race in xen_qlock_wait()

2018-10-01 Thread Juergen Gross
Correcting Waiman's mail address On 01/10/2018 09:16, Juergen Gross wrote: > In the following situation a vcpu waiting for a lock might not be > woken up from xen_poll_irq(): > > CPU 1:CPU 2: CPU 3: > takes a spinlock >

Re: [Xen-devel] [PATCH 2/2] xen: make xen_qlock_wait() nestable

2018-10-01 Thread Juergen Gross
Correcting Waiman's mail address On 01/10/2018 09:16, Juergen Gross wrote: > xen_qlock_wait() isn't safe for nested calls due to interrupts. A call > of xen_qlock_kick() might be ignored in case a deeper nesting level > was active right before the call of xen_poll_irq(): &

[Xen-devel] [PATCH 1/2] xen: fix race in xen_qlock_wait()

2018-10-01 Thread Juergen Gross
waiman.l...@hp.com Cc: pet...@infradead.org Signed-off-by: Juergen Gross --- arch/x86/xen/spinlock.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c index 973f10e05211..cd210a4ba7b1 100644 --- a/arch/x86/xen/

[Xen-devel] [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling

2018-10-01 Thread Juergen Gross
The Xen specific queue spinlock wait function has two issues which could result in a hanging system. They have a similar root cause of clearing a pending wakeup of a waiting vcpu and later going to sleep waiting for the just cleared wakeup event, which of course won't ever happen. Juergen Gross

<    7   8   9   10   11   12   13   14   15   16   >