Re: [Xen-devel] [PATCH v3 0/7] LLVM coverage support for Xen

2018-02-13 Thread Roger Pau Monné
On Wed, Jan 24, 2018 at 10:01:18AM +, Roger Pau Monne wrote: > Hello, > > The following patch series enables LLVM coverage support for the Xen > hypervisor. A sample coverage report obtained after booting a PVHv2 Dom0 > can be found at: > > http://xenbits.xen.org/people/royger/xen_profile/ >

Re: [Xen-devel] [PATCH v3 0/7] LLVM coverage support for Xen

2018-02-13 Thread Roger Pau Monné
On Tue, Feb 13, 2018 at 09:16:19AM -0700, Jan Beulich wrote: > >>> On 13.02.18 at 16:53, wrote: > > On Wed, Jan 24, 2018 at 10:01:18AM +, Roger Pau Monne wrote: > >> Hello, > >> > >> The following patch series enables LLVM coverage support for the Xen > >> hypervisor. A

Re: [Xen-devel] [PATCH v2] x86: fix a crash in SPEC_CTRL_ENTRY_FROM_INTR_IST

2018-02-14 Thread Roger Pau Monné
reproduce without bti=0. > > Signed-off-by: Zhenzhong Duan <zhenzhong.d...@oracle.com> > > Re-do actual code change. Also drop an unused label. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/spec_ctrl: Fix several bugs in SPEC_CTRL_ENTRY_FROM_INTR_IST

2018-02-14 Thread Roger Pau Monné
gt; > Also, drop an unused label which was a copy/paste mistake. > > Reported-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > Reported-by: Zhenzhong Duan <zhenzhong.d...@oracle.com> > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Rog

Re: [Xen-devel] [PATCH] libxl: allow libxl_domain_suspend to simply suspend a domain, without saving it

2018-02-09 Thread Roger Pau Monné
On Fri, Feb 09, 2018 at 12:14:03AM +0100, Marek Marczykowski-Górecki wrote: > When fd=-1, no savefile will be written, but the domain will still be > suspended (but not destroyed). The main reason for this functionality is > to suspend the host while some domains are running, potentially holding >

Re: [Xen-devel] [PATCH 1/3] libxc: Cleanup xc_dom_parse_elf_kernel()'s return value

2018-02-09 Thread Roger Pau Monné
On Thu, Feb 08, 2018 at 10:49:08PM +0100, Simon Gaiser wrote: > xc_dom_loader.parser() should return elf_negerrnoval. > > Signed-off-by: Simon Gaiser <si...@invisiblethingslab.com> LGTM: Reviewed-by: Roger Pau Monné <roger@c

Re: [Xen-devel] [PATCH] libxl: do not fail device removal if backend domain is gone

2018-02-09 Thread Roger Pau Monné
On Fri, Feb 09, 2018 at 12:41:58PM +0100, Marek Marczykowski-Górecki wrote: > On Fri, Feb 09, 2018 at 11:27:04AM +0000, Roger Pau Monné wrote: > > I'm also wondering, if you jump to 'out' here, you avoid the call to > > libxl__xs_transaction_commit and instead

Re: [Xen-devel] [PATCH v4 01/28] Xen/doc: Add Xen virtual IOMMU doc

2018-02-09 Thread Roger Pau Monné
On Fri, Nov 17, 2017 at 02:22:08PM +0800, Chao Gao wrote: > From: Lan Tianyu > > This patch is to add Xen virtual IOMMU doc to introduce motivation, > framework, vIOMMU hypercall and xl configuration. > > Signed-off-by: Lan Tianyu > Signed-off-by:

Re: [Xen-devel] [PATCH 3/3] libxc: xc_dom_parse_elf_kernel: Return error for invalid kernel images

2018-02-09 Thread Roger Pau Monné
gt; invalid elf images and the domain build only failed later. Now the build > process will fail immediately on detecting the error. > > Signed-off-by: Simon Gaiser <si...@invisiblethingslab.com> LGTM: Reviewed-by: Roger Pau Monné <roger@citrix.com> I'm not sure ab

Re: [Xen-devel] [RFC XEN PATCH v4 00/41] Add vNVDIMM support to HVM domains

2018-02-09 Thread Roger Pau Monné
Thanks for the series, I'm however wondering whether it's appropriate to post a v4 as RFC. Ie: at v4 the reviewer expects the submitter to have a clear picture of what needs to be implemented. On Thu, Dec 07, 2017 at 06:09:49PM +0800, Haozhong Zhang wrote: > All patches can also be found at >

Re: [Xen-devel] [PATCH v1] x86/msr: add Raw and Host domain policies

2018-02-08 Thread Roger Pau Monné
On Thu, Feb 08, 2018 at 10:23:21AM +, Sergey Dyasli wrote: > +static void __init calculate_host_policy(void) > +{ > +struct msr_domain_policy *dp = _msr_domain_policy; > + > +*dp = raw_msr_domain_policy; host_msr_domain_policy = raw_msr_domain_policy; Should work AFAICT. > diff

Re: [Xen-devel] [PATCH RFC 0/8] libxl, xl, public/io: PV backends feature control

2018-02-07 Thread Roger Pau Monné
On Thu, Nov 02, 2017 at 06:06:08PM +, Joao Martins wrote: > Hey folks, > > Presented herewith is an attempt to implement PV backends feature control > as discussed in the list > (https://lists.xen.org/archives/html/xen-devel/2017-09/msg00766.html) > > Given that this a simple proposal hence

Re: [Xen-devel] [PATCH RFC 1/8] public/io/blkif: add directory for backend parameters

2018-02-07 Thread Roger Pau Monné
On Thu, Nov 02, 2017 at 06:06:09PM +, Joao Martins wrote: > The proposed directory provides a mechanism for tools to control the > maximum feature set of the device being provisioned by backends. > Examples include max ring page order, persistent grants, number of > queues etc. > >

Re: [Xen-devel] [PATCH 3/4] firmware/shim: better filtering of intermediate files during Xen tree setup

2018-02-07 Thread Roger Pau Monné
On Wed, Feb 07, 2018 at 08:08:15AM -0700, Jan Beulich wrote: > I have no idea what *.1 is meant to cover. Instead also exclude > preprocessed and non-source assembly files. Oh, I guess that answers my question in 2/4 then. I don't seem to have neither .i or .a files, but certainly .s should be

Re: [Xen-devel] [PATCH 4/4] firmware/shim: avoid mkdir error during Xen tree setup

2018-02-07 Thread Roger Pau Monné
ted-by: Wei Liu <wei.l...@citrix.com> > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 4/7] kconfig/gcov: rename to coverage

2018-02-07 Thread Roger Pau Monné
On Wed, Feb 07, 2018 at 08:37:13AM -0700, Jan Beulich wrote: > >>> On 07.02.18 at 11:53, wrote: > > docs/misc/coverage.markdown | 2 +- > > xen/Kconfig.debug| 6 +++--- > > xen/Rules.mk | 9 +++-- > > xen/arch/x86/efi/Makefile| 2 +- > >

Re: [Xen-devel] [PATCH RFC 7/8] xen-blkback: frontend feature control

2018-02-07 Thread Roger Pau Monné
On Thu, Nov 02, 2017 at 06:06:15PM +, Joao Martins wrote: > Toolstack may write values to the "require" subdirectory in the > backend main directory (e.g. backend/vbd/X/Y/). Read these values > and use them when announcing those to the frontend. When backend > scans frontend features the

Re: [Xen-devel] [PATCH] vmx/hap: optimize CR4 trapping

2018-02-16 Thread Roger Pau Monné
sing shadow paging more CR4 > >> bits need to be unconditionally trapped, which makes this approach > >> unlikely to yield any important performance improvements. > >> > >> Reported-by: Andrew Cooper <andrew.coop...@citrix.com> > >> Signed-off-by: Roger

Re: [Xen-devel] [PATCH v2 2/2] vmx/hap: optimize CR4 trapping

2018-02-16 Thread Roger Pau Monné
On Fri, Feb 16, 2018 at 02:30:55PM +0200, Razvan Cojocaru wrote: > On 02/16/2018 02:10 PM, Roger Pau Monne wrote: > > diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c > > index f229e69948..4317658c56 100644 > > --- a/xen/arch/x86/monitor.c > > +++ b/xen/arch/x86/monitor.c > > @@

Re: [Xen-devel] [PATCH] vmx/hap: optimize CR4 trapping

2018-02-16 Thread Roger Pau Monné
; > > Note that this optimized trapping is currently only applied to guests > > running with HAP on Intel hardware. If using shadow paging more CR4 > > bits need to be unconditionally trapped, which makes this approach > > unlikely to yield any important performance imp

Re: [Xen-devel] PVH Dom0 ACPI tables

2018-02-15 Thread Roger Pau Monné
On Thu, Feb 15, 2018 at 03:05:03AM -0700, Jan Beulich wrote: > >>> On 14.02.18 at 11:30, wrote: > > Hello, > > > > After the comments on the ACPI whitelisting patch for PVH Dom0 I've > > decided to post the list of ACPI tables that I've used to create the > > current

Re: [Xen-devel] [PATCH 5/5] x86: Rework MSR_TSC_AUX handling from scratch.

2018-02-21 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 06:28:15PM +, Andrew Cooper wrote: > On 20/02/18 17:35, Roger Pau Monné wrote: > > On Tue, Feb 20, 2018 at 11:58:43AM +, Andrew Cooper wrote: > >> There are many problems with MSR_TSC_AUX handling. > >> > >> To being with, the

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

2018-02-21 Thread Roger Pau Monné
On Wed, Feb 21, 2018 at 10:03:34AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Introduce skeleton of the para-virtualized Xen display > frontend driver. This patch only adds required > essential stubs. > > Signed-off-by: Oleksandr

Re: [Xen-devel] [PATCH v3 1/2] x86/hvm: introduce cr{0, 4}_host_mask to store trapped bits of CR accesses

2018-02-21 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 07:23:44PM -0500, Boris Ostrovsky wrote: > On 02/20/2018 03:56 AM, Roger Pau Monne wrote: > > At the moment this is currently set at VMC{S/B} creation and not changed, > > but further patches are going to change the CR4 mask at runtime. > > > &g

Re: [Xen-devel] [PATCH v3 1/2] x86/hvm: introduce cr{0, 4}_host_mask to store trapped bits of CR accesses

2018-02-21 Thread Roger Pau Monné
On Wed, Feb 21, 2018 at 08:48:20AM -0500, Boris Ostrovsky wrote: > On 02/21/2018 03:27 AM, Roger Pau Monné wrote: > > On Tue, Feb 20, 2018 at 07:23:44PM -0500, Boris Ostrovsky wrote: > >> On 02/20/2018 03:56 AM, Roger Pau Monne wrote: > >>> At the moment this is curr

Re: [Xen-devel] Ability to crash a HVM guest by accessing /dev/hpet

2018-02-21 Thread Roger Pau Monné
On Wed, Feb 21, 2018 at 03:12:15PM +0100, Stefan Bader wrote: > This seems to have been found by us[1] and Citrix[2] recently. To trigger this > one needs to be root in the guest, so it is not super critical but still it > seems to be a bit harsh that purely opening /dev/hpet read-only is leading

Re: [Xen-devel] [PATCH v5 3/5] x86/clang: restore integrated assembler usage with indirect thunks

2018-02-22 Thread Roger Pau Monné
> > > > Only disable the integrated assembler for assembly files, like it was > > done prior to "x86: Support indirect thunks from assembly code". > > > > Signed-off-by: Roger Pau Monné <roger@citrix.com> > > --- > > Cc: Andrew Cooper <and

Re: [Xen-devel] [PATCH] intel_iommu: allow updating FEADDR and FEUADDR with one 64bit write

2018-02-22 Thread Roger Pau Monné
On Wed, Jan 24, 2018 at 03:18:48PM +0100, Marek Marczykowski-Górecki wrote: > Allow updating those two adjacent 32bit fields with one 64bit write. > This fixes qemu crash when booting Xen inside. > > See discussion on Xen side of the thing here: > http://xen.markmail.org/message/6mrmemrnmhxvaxba

Re: [Xen-devel] [PATCH v2] VT-d: use two 32-bit writes to update DMAR fault address registers

2018-02-22 Thread Roger Pau Monné
On Wed, Oct 11, 2017 at 05:27:05AM -0600, Jan Beulich wrote: > >>> On 11.10.17 at 05:03, wrote: > > --- a/xen/drivers/passthrough/vtd/iommu.c > > +++ b/xen/drivers/passthrough/vtd/iommu.c > > @@ -1105,7 +1105,13 @@ static void dma_msi_set_affinity(struct irq_desc > >

Re: [Xen-devel] [PATCH] xenstore: increase default thread stack size to 32k

2018-02-22 Thread Roger Pau Monné
On Thu, Feb 22, 2018 at 11:16:53AM +, Ian Jackson wrote: > Jim Fehlig writes ("[PATCH] xenstore: increase default thread stack size to > 32k"): > > On several Skylake machines I've observed xl segfaults when running > > create or destroy subcommands. Other subcommands may segfault too, > >

Re: [Xen-devel] [PATCH v4 3/4] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 04:13:42AM -0700, Jan Beulich wrote: > >>> On 20.02.18 at 12:01, wrote: > > --- a/xen/include/asm-x86/asm_defns.h > > +++ b/xen/include/asm-x86/asm_defns.h > > @@ -15,6 +15,9 @@ > > #include > > > > #ifdef __ASSEMBLY__ > > +#ifndef

Re: [Xen-devel] [PATCH v4 3/4] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 10:19:16AM +, Roger Pau Monné wrote: > On Tue, Feb 20, 2018 at 02:15:24AM -0700, Jan Beulich wrote: > > >>> On 19.02.18 at 15:16, <roger@citrix.com> wrote: > > > --- a/xen/include/asm-x86/indirect_thunk_asm.h > > > +++

Re: [Xen-devel] [PATCH v4 3/4] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 02:15:24AM -0700, Jan Beulich wrote: > >>> On 19.02.18 at 15:16, wrote: > > --- a/xen/include/asm-x86/indirect_thunk_asm.h > > +++ b/xen/include/asm-x86/indirect_thunk_asm.h > > @@ -3,6 +3,10 @@ > > * usual #ifdef'ary to turn into comments. > > */

Re: [Xen-devel] [PATCH] build: remove shim related targets

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 02:04:24AM -0700, Jan Beulich wrote: > >>> On 20.02.18 at 09:23, wrote: > > There's no need to have shim specific targets, so just use the regular > > xen makefile targets in order to build the shim binary. > > > > When the shim is build as part of

Re: [Xen-devel] [PATCH] build: remove shim related targets

2018-02-20 Thread Roger Pau Monné
n the shim is build as part of the firmware directory use the > > xen-syms as the shim binary. > > > > Signed-off-by: Roger Pau Monné <roger@citrix.com> > > diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile > > index 389096139c..5563c813dd 100644

Re: [Xen-devel] [PATCH] shim: allow building of just the shim with build-ID-incapable linker

2018-02-19 Thread Roger Pau Monné
gt; Also drop a stray variable setting from the x86 Makefile. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> Thanks, there certainly no need to build the regular xen target AFAICT if only xen-shim is desired. I also

Re: [Xen-devel] [PATCH v2 1/2] x86/hvm: introduce cr_mask to store trapped bits of CR accesses

2018-02-19 Thread Roger Pau Monné
On Fri, Feb 16, 2018 at 12:49:57PM +, Andrew Cooper wrote: > On 16/02/18 12:10, Roger Pau Monne wrote: > > diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/asm-x86/hvm/vcpu.h > > index d93166fb92..811d4c10ae 100644 > > --- a/xen/include/asm-x86/hvm/vcpu.h > > +++

Re: [Xen-devel] [PATCH v4 3/4] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 05:53:08AM -0700, Jan Beulich wrote: > >>> On 20.02.18 at 13:42, wrote: > > On Tue, Feb 20, 2018 at 05:32:17AM -0700, Jan Beulich wrote: > >> >>> On 20.02.18 at 12:22, wrote: > >> > On Tue, Feb 20, 2018 at 04:13:42AM -0700, Jan

Re: [Xen-devel] [PATCH v4 3/4] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 05:32:17AM -0700, Jan Beulich wrote: > >>> On 20.02.18 at 12:22, wrote: > > On Tue, Feb 20, 2018 at 04:13:42AM -0700, Jan Beulich wrote: > >> >>> On 20.02.18 at 12:01, wrote: > >> > --- a/xen/include/asm-x86/asm_defns.h > >> >

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Don't shadow the domain parameter in hvm_save_cpu_msrs()

2018-02-20 Thread Roger Pau Monné
. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> Would be nice to enable -Wshadow but that requires a lot more of work. Thanks, Roger. ___ Xen-devel mailing list Xen-de

Re: [Xen-devel] [PATCH v2] build: remove shim related targets

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 02:43:25PM +, Wei Liu wrote: > On Tue, Feb 20, 2018 at 02:37:54PM +, Roger Pau Monne wrote: > > xen-shim: $(D) shim-olddefconfig > > - $(MAKE) -C $(D)/xen install-shim \ > > + $(MAKE) -C $(D)/xen build \ > > XEN_CONFIG_EXPERT=y \ > > -

Re: [Xen-devel] [PATCH] build: remove shim related targets

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 03:09:18PM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH] build: remove shim related targets"): > > There's no need to have shim specific targets, so just use the regular > > xen makefile targets in order to build the shim binary. > > I haven't been following

Re: [Xen-devel] [PATCH 3/5] x86/time: Rework pv_soft_rdtsc() to aid further cleanup

2018-02-20 Thread Roger Pau Monné
const. > > No functional change. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger@citrix.com> > CC: Konrad Rzeszutek Wilk

Re: [Xen-devel] [PATCH 4/5] x86/pv: Remove deferred RDTSC{, P} handling in pv_emulate_privileged_op()

2018-02-20 Thread Roger Pau Monné
groundwork for further fixes. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger@citrix.com> > CC: Konrad Rzeszutek Wilk <ko

Re: [Xen-devel] [PATCH 2/5] x86/pv: Avoid leaking other guests' MSR_TSC_AUX values into PV context

2018-02-20 Thread Roger Pau Monné
UX, using 0 in the common case. > > To amortise overhead cost, introduce wrmsr_tsc_aux() which performs a lazy > update of the MSR, and use this function consistently across the codebase. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Ro

Re: [Xen-devel] [PATCH v4 1/4] build: filter out command line assembler arguments

2018-02-19 Thread Roger Pau Monné
On Mon, Feb 19, 2018 at 08:43:51AM -0700, Jan Beulich wrote: > >>> On 19.02.18 at 15:16, wrote: > > --- > > xen/arch/x86/Makefile | 6 +++--- > > xen/arch/x86/Rules.mk | 5 + > > xen/include/Makefile | 2 +- > > 3 files changed, 5 insertions(+), 8 deletions(-) > >

Re: [Xen-devel] PV guest with PCI passthrough crash on Xen 4.8.3 inside KVM when booted through OVMF

2018-02-19 Thread Roger Pau Monné
On Fri, Feb 16, 2018 at 04:35:14PM -0500, Rich Persaud wrote: > On Feb 16, 2018, at 14:02, Andrew Cooper wrote: > > > > IMO, PCI Passthrough is a trainwreck, and it is a miracle it functions > > at all. > > Would that statement apply to other hypervisors like KVM,

Re: [Xen-devel] Getting Hypercall [op = 0x0040001a ] on trace 

2018-02-19 Thread Roger Pau Monné
On Mon, Feb 19, 2018 at 04:23:33PM +, Charles Gonçalves wrote: > Hello, > > Im getting this Hypercall [op = 0x0040001a ] on xen trace but can't figure > out which operation this is. I guess 0x1a is the hypercall number (26 in decimal), which matches to __HYPERVISOR_mmuext_op. See

Re: [Xen-devel] [PATCH v4 1/4] build: filter out command line assembler arguments

2018-02-19 Thread Roger Pau Monné
On Mon, Feb 19, 2018 at 09:14:30AM -0700, Jan Beulich wrote: > >>> On 19.02.18 at 17:05, wrote: > > On Mon, Feb 19, 2018 at 08:43:51AM -0700, Jan Beulich wrote: > >> >>> On 19.02.18 at 15:16, wrote: > >> > --- > >> > xen/arch/x86/Makefile | 6 +++--- >

Re: [Xen-devel] [PATCH v4 2/4] x86/clang: restore integrated assembler usage with indirect thunks

2018-02-19 Thread Roger Pau Monné
On Mon, Feb 19, 2018 at 08:57:15AM -0700, Jan Beulich wrote: > >>> On 19.02.18 at 15:16, wrote: > > --- a/xen/arch/x86/Rules.mk > > +++ b/xen/arch/x86/Rules.mk > > @@ -44,3 +44,17 @@ endif > > > > # Set up the assembler include path properly for older toolchains. > >

Re: [Xen-devel] [PATCH 5/5] x86: Rework MSR_TSC_AUX handling from scratch.

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 11:58:43AM +, Andrew Cooper wrote: > There are many problems with MSR_TSC_AUX handling. > > To being with, the RDPID instruction reads MSR_TSC_AUX, but it is only the > RDTSCP feature which enumerates the MSR. Therefore, RDPID functionally > depends on RDTSCP. > >

Re: [Xen-devel] [PATCH] shut down domain when last vCPU goes down

2018-02-16 Thread Roger Pau Monné
own its > only vCPU. By translating this to a shutdown, the situation will be > better recognizable. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> I'm wondering, is it common for a domain to shutdown by shutting dow

Re: [Xen-devel] [PATCH] shut down domain when last vCPU goes down

2018-02-16 Thread Roger Pau Monné
On Fri, Feb 16, 2018 at 03:59:45PM +, Wei Liu wrote: > On Fri, Feb 16, 2018 at 03:52:48PM +0000, Roger Pau Monné wrote: > > On Fri, Feb 16, 2018 at 08:10:48AM -0700, Jan Beulich wrote: > > > I've just had to deal with an early boot crash of Linux which occurred > &

Re: [Xen-devel] [PATCH v4 17/28] x86/vvtd: save and restore emulated VT-d

2018-02-23 Thread Roger Pau Monné
On Fri, Feb 23, 2018 at 01:22:23PM +0800, Chao Gao wrote: > On Mon, Feb 12, 2018 at 02:49:12PM +0000, Roger Pau Monné wrote: > >On Fri, Nov 17, 2017 at 02:22:24PM +0800, Chao Gao wrote: > > > >> +struct hvm_hw_vvtd > >> +{ > >> +uint32_t eim_enabled :

Re: [Xen-devel] [PATCH v4 08/28] x86/vvtd: Add MMIO handler for VVTD

2018-02-23 Thread Roger Pau Monné
On Thu, Feb 22, 2018 at 02:20:12PM +0800, Chao Gao wrote: > On Fri, Feb 09, 2018 at 05:51:29PM +0000, Roger Pau Monné wrote: > >On Sat, Feb 10, 2018 at 01:21:09AM +0800, Chao Gao wrote: > >> On Fri, Feb 09, 2018 at 04:39:15PM +0000, Roger Pau Monné wrote: > >> >On F

Re: [Xen-devel] [PATCH v4 11/28] x86/vvtd: Process interrupt remapping request

2018-02-23 Thread Roger Pau Monné
On Sun, Feb 11, 2018 at 01:31:41PM +0800, Chao Gao wrote: > On Fri, Feb 09, 2018 at 05:44:17PM +0000, Roger Pau Monné wrote: > >On Fri, Nov 17, 2017 at 02:22:18PM +0800, Chao Gao wrote: > >> +static int vvtd_delivery(struct domain *d, uint8_t vector, > >> +

Re: [Xen-devel] [PATCH v8 01/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2018-02-23 Thread Roger Pau Monné
On Fri, Feb 23, 2018 at 04:02:17PM +, Julien Grall wrote: > Hi, > > On 23/02/18 15:55, Jan Beulich wrote: > > > > > On 23.01.18 at 16:07, wrote: > > > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > > > index c9b9546435..98b82680c6 100644 > > > ---

Re: [Xen-devel] [PATCH] libxl: set channel devid when not provided by application

2018-02-23 Thread Roger Pau Monné
On Wed, Feb 07, 2018 at 08:04:10PM -0700, Jim Fehlig wrote: > Applications like libvirt may not populate a device devid field, > delegating that to libxl. If needed, the application can later > retrieve the libxl-produced devid. Indeed most devices are handled > this way in libvirt, channel

Re: [Xen-devel] [RFC PATCH v2 2/9] hyper_dmabuf: architecture specification and reference guide

2018-02-23 Thread Roger Pau Monné
On Tue, Feb 13, 2018 at 05:50:01PM -0800, Dongwon Kim wrote: > Reference document for hyper_DMABUF driver > > Documentation/hyper-dmabuf-sharing.txt This should likely be patch 1 in order for reviewers to have the appropriate context. > > Signed-off-by: Dongwon Kim >

Re: [Xen-devel] [RFC Patch v4 4/8] hvmloader: boot cpu through broadcast

2018-02-23 Thread Roger Pau Monné
On Wed, Dec 06, 2017 at 03:50:10PM +0800, Chao Gao wrote: > Intel SDM Extended XAPIC (X2APIC) -> "Initialization by System Software" > has the following description: > > "The ACPI interfaces for the x2APIC are described in Section 5.2, “ACPI System > Description Tables,” of the Advanced

Re: [Xen-devel] [PATCH] xtf: fix cdefs.h conflict with __section

2018-02-23 Thread Roger Pau Monné
On Thu, Feb 22, 2018 at 06:30:47AM -0700, Jan Beulich wrote: > >>> On 22.02.18 at 13:28, wrote: > > On 22/02/18 12:24, Jan Beulich wrote: > > On 22.02.18 at 13:03, wrote: > >>> On FreeBSD the build fails with: > >>> > >>>

Re: [Xen-devel] [RFC Patch v4 8/8] x86/hvm: bump the maximum number of vcpus to 512

2018-02-23 Thread Roger Pau Monné
On Wed, Dec 06, 2017 at 03:50:14PM +0800, Chao Gao wrote: > Signed-off-by: Chao Gao > --- > xen/include/public/hvm/hvm_info_table.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/public/hvm/hvm_info_table.h >

Re: [Xen-devel] [PATCH v2 5/5] x86: Rework MSR_TSC_AUX handling from scratch.

2018-02-21 Thread Roger Pau Monné
t;arch.incarnation to > all vCPUs MSR block if in TSC_MODE_PVRDTSCP, so the context switching and > emulation code functions correctly. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Roger Pau Monné <roger@citrix.com> Just one comment nit below. &g

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

2018-02-21 Thread Roger Pau Monné
On Wed, Feb 21, 2018 at 11:42:23AM +0200, Oleksandr Andrushchenko wrote: > On 02/21/2018 11:17 AM, Roger Pau Monné wrote: > > On Wed, Feb 21, 2018 at 10:03:34AM +0200, Oleksandr Andrushchenko wrote: > > > --- /dev/null > > > +++ b/drivers/gpu/drm/xen/xen_drm_

Re: [Xen-devel] [PATCH v2] build: remove shim related targets

2018-02-20 Thread Roger Pau Monné
On Tue, Feb 20, 2018 at 02:42:27PM +, Andrew Cooper wrote: > On 20/02/18 14:37, Roger Pau Monne wrote: > > diff --git a/tools/firmware/xen-dir/Makefile > > b/tools/firmware/xen-dir/Makefile > > index 7fd36a0e15..01a2850194 100644 > > --- a/tools/firmware/xen-dir/Makefile > > +++

Re: [Xen-devel] Getting Hypercall [op = 0x0040001a ] on trace 

2018-02-19 Thread Roger Pau Monné
On Mon, Feb 19, 2018 at 05:13:11PM +, Wei Liu wrote: > On Mon, Feb 19, 2018 at 04:23:33PM +, Charles Gonçalves wrote: > > Hello, > > > > Im getting this Hypercall [op = 0x0040001a ] on xen trace but can't figure > > out which operation this is. > > > > Using old Xen 4.4.1. > > Looking

Re: [Xen-devel] [PATCH v2] tools/xenstore: try to get minimum thread stack size for watch thread

2018-02-26 Thread Roger Pau Monné
On Mon, Feb 26, 2018 at 09:46:12AM +0100, Juergen Gross wrote: > When creating a pthread in xs_watch() try to get the minimal needed > size of the thread from glibc instead of using a constant. This avoids > problems when the library is used in programs with large per-thread > memory. > > Use

Re: [Xen-devel] [PATCH] build: Rename as-insn-check to as-insn-add

2018-02-23 Thread Roger Pau Monné
On Fri, Feb 23, 2018 at 11:40:34AM +, Andrew Cooper wrote: > On 22/02/18 13:39, Jan Beulich wrote: > On 22.02.18 at 13:39, wrote: > >> On 02/22/2018 12:22 PM, Jan Beulich wrote: > >> On 22.02.18 at 12:41, wrote: > On 22/02/18

Re: [Xen-devel] [PATCH v3 2/2] vmx/hap: optimize CR4 trapping

2018-02-23 Thread Roger Pau Monné
17488} > >clts2 0.00s 0.00% 8232 cyc { 5352|2|2} > > > > Note that this optimized trapping is currently only applied to guests > > running with HAP on Intel hardware. If using shadow paging more CR4 > > bits need to be unconditionally trapped, which

Re: [Xen-devel] [PATCH v2] build: Rename as-insn-check to as-option-add

2018-02-23 Thread Roger Pau Monné
On Fri, Feb 23, 2018 at 01:10:34PM +, Andrew Cooper wrote: > as-insn-check mutates the passed-in flags. Rename it to as-option-add, in > line with cc-option-add, and update all callers. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Roge

Re: [Xen-devel] [PATCH] x86: implement cpu_possible_map

2017-12-28 Thread Roger Pau Monné
e_map with the current CPUs > > plus the hotpluggable ones. > > > > Note that this is already implemented on ARM. > > > > Signed-off-by: Roger Pau Monné <roger@citrix.com> > > --- > > Cc: Jan Beulich <jbeul...@suse.com> > > Cc: Andrew Co

Re: [Xen-devel] [PATCH] x86/upcall: inject a spurious event after setting upcall vector

2018-01-04 Thread Roger Pau Monné
On Thu, Jan 04, 2018 at 03:53:39AM -0700, Jan Beulich wrote: > >>> On 04.01.18 at 10:13, wrote: > > On Tue, Jan 02, 2018 at 09:47:40AM -0700, Jan Beulich wrote: > >> >>> On 28.12.17 at 13:57, wrote: > >> > In case the vCPU has pending events to inject.

Re: [Xen-devel] [PATCH] x86/upcall: inject a spurious event after setting upcall vector

2018-01-04 Thread Roger Pau Monné
On Thu, Jan 04, 2018 at 05:10:52AM -0700, Jan Beulich wrote: > >>> On 04.01.18 at 12:37, wrote: > > On Thu, Jan 04, 2018 at 03:53:39AM -0700, Jan Beulich wrote: > >> >>> On 04.01.18 at 10:13, wrote: > >> > On Tue, Jan 02, 2018 at 09:47:40AM -0700, Jan

Re: [Xen-devel] [PATCH v8 07/11] vpci/bars: add handlers to map the BARs

2018-02-26 Thread Roger Pau Monné
On Mon, Feb 26, 2018 at 04:20:17AM -0700, Jan Beulich wrote: > (re-sending with xen-devel re-added; not sure how it got lost) > > >>> On 23.01.18 at 16:07, wrote: > > --- > > tools/tests/vpci/emul.h | 1 + > > xen/arch/x86/hvm/ioreq.c | 4 + > > Again the Cc to Paul

Re: [Xen-devel] [PATCH 2/2] xen: events: free irqs in error condition

2018-02-26 Thread Roger Pau Monné
On Mon, Feb 26, 2018 at 05:36:35PM +, Amit Shah wrote: > In case of errors in irq setup for MSI, free up the allocated irqs. > > Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups") > Reported-by: Hooman Mirhadi <mirha...@amazon.com> > CC: <sta..

Re: [Xen-devel] [PATCH 2/2] xen: events: free irqs in error condition

2018-02-27 Thread Roger Pau Monné
On Mon, Feb 26, 2018 at 06:57:03PM +, Shah, Amit wrote: > > On Mo, 2018-02-26 at 18:14 +, Roger Pau Monné wrote: > > On Mon, Feb 26, 2018 at 05:36:35PM +, Amit Shah wrote: > > > > > > In case of errors in irq setup for MSI, free up the allo

Re: [Xen-devel] [OSSTEST PATCH 0/4] FreeBSD fixups

2018-06-21 Thread Roger Pau Monné
TestSupport: Rename package_install_cmd to > package_install_cmd\b/pkg_manager_install_cmd_line > TestSupport: Export pkg_manager_install_cmd_line > ts-xen-install: Use pkg_manager_install_cmd_line > > Roger Pau Monné (1): > TestSupport: Honour $force option to package_install_cmd

Re: [Xen-devel] [PATCH] xen: Remove unnecessary BUG_ON from __unbind_from_irq()

2018-06-22 Thread Roger Pau Monné
() with an unbound irq, which would result in > triggering the BUG_ON there. > > Since there is really no reason for the BUG_ON (xen_free_irq() can > operate on unbound irqs) we can remove it. > > Reported-by: Ben Hutchings > Signed-off-by: Boris Ostrovsky Reviewed-by: Roger

Re: [Xen-devel] [PATCH v4 30/32] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

2018-08-02 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 03:06:12PM +0100, Anthony PERARD wrote: > +static void dm_stopped(libxl__egc *egc, libxl__ev_qmp *ev, > + const libxl__json_object *response, int rc) > +{ > +EGC_GC; > +libxl__domain_suspend_state *dsps = CONTAINER_OF(ev, *dsps, qmp); > +

Re: [Xen-devel] [PATCH v4 27/32] libxl: QEMU startup sync based on QMP

2018-08-02 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 03:06:09PM +0100, Anthony PERARD wrote: > This is only activated when dm_restrict=1, as explained in the previous > patch "libxl_dm: Pre-open QMP socket for QEMU" > > Signed-off-by: Anthony PERARD Reviewed-by: Roger Pau Monné Just one nit... >

Re: [Xen-devel] [RFC] OVMF on PVH

2018-08-02 Thread Roger Pau Monné
On Thu, Aug 02, 2018 at 12:24:35PM +0100, Anthony PERARD wrote: > Hi, > > I've been working on booting OVMF in a PVH guest. There are few changes > that I'd like your comments on. Those are changes that I've already made > in my private branch, there are either required or will make things >

Re: [Xen-devel] [PATCH v4 31/32] libxl_disk: Cut libxl_cdrom_insert into step

2018-08-02 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 03:06:13PM +0100, Anthony PERARD wrote: > This is to prepare libxl_cdrom_insert to be able to send commands to > QEMU via the libxl__ev_qmp. The next patch is going to make use of it. > > Signed-off-by: Anthony PERARD > --- > tools/libxl/libxl_disk.c | 194

Re: [Xen-devel] [PATCH v4 29/32] libxl: Change libxl__domain_suspend_device_model() to be async.

2018-08-02 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 03:06:11PM +0100, Anthony PERARD wrote: > This create an extra step for the two calls sites of the function. ^ call > > Signed-off-by: Anthony PERARD Reviewed-by: Roger Pau Monné Than

Re: [Xen-devel] [PATCH v4 28/32] libxl_qmp: Store advertised QEMU version in libxl__ev_qmp

2018-08-02 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 03:06:10PM +0100, Anthony PERARD wrote: > This will be used in a later patch. > > Signed-off-by: Anthony PERARD > --- > tools/libxl/libxl_internal.h | 7 +++ > tools/libxl/libxl_qmp.c | 16 > 2 files changed, 23 insertions(+) > > diff --git

Re: [Xen-devel] [PATCH v4 26/32] libxl_dm: Pre-open QMP socket for QEMU

2018-08-02 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 03:06:08PM +0100, Anthony PERARD wrote: > When starting QEMU with dm_restrict=1, pre-open the QMP socket before > exec QEMU. That socket will be usefull to findout if QEMU is ready, and > pre-opening it means that libxl can connect to it without waiting for > QEMU to create

Re: [Xen-devel] [PATCH v4 01/15] re-work commit 3e06b989 "IOMMU: make page table population preemptible"...

2018-08-01 Thread Roger Pau Monné
devel/2018-07/msg01870.html > > Signed-off-by: Paul Durrant Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen: Remove domain_crash_synchronous() completely

2018-08-01 Thread Roger Pau Monné
> Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné This however removes the printk with the file an line number from where the domain_crash was called. I don't think it's a big issue because each call site already has a message. Roger. ___

Re: [Xen-devel] [PATCH v2 2/5] iommu: introduce dom0-iommu option

2018-08-03 Thread Roger Pau Monné
On Fri, Aug 03, 2018 at 09:35:58AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > > Of Roger Pau Monné > > Sent: 03 August 2018 09:14 > > To: Jan Beulich > > Cc: Kevin

Re: [Xen-devel] [PATCH v2 2/5] iommu: introduce dom0-iommu option

2018-08-03 Thread Roger Pau Monné
n Fri, Aug 03, 2018 at 09:35:58AM +0100, Paul Durrant wrote: > > > > -Original Message- > > > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On > > Behalf > > > > Of Roger Pau Monné > > > > Sent: 03 August 2018 09

Re: [Xen-devel] [PATCH v2 2/5] iommu: introduce dom0-iommu option

2018-08-03 Thread Roger Pau Monné
On Fri, Aug 03, 2018 at 10:14:49AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 03 August 2018 10:09 > > To: Paul Durrant > > Cc: Jan Beulich ; Kevin Tian ; > > Stefano Stabellini ; Wei Liu ; > > George Dunlap ; Andrew Cooper > > ; Ian Jackson ;

Re: [Xen-devel] [PATCH v2 2/5] iommu: introduce dom0-iommu option

2018-08-03 Thread Roger Pau Monné
On Thu, Aug 02, 2018 at 02:23:23AM -0600, Jan Beulich wrote: > >>> On 02.08.18 at 09:46, wrote: > >> From: Roger Pau Monne [mailto:roger@citrix.com] > >> Sent: Wednesday, August 1, 2018 7:04 PM > >> --- a/docs/misc/xen-command-line.markdown > >> +++ b/docs/misc/xen-command-line.markdown > >>

Re: [Xen-devel] [PATCH v2 3/5] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-08-03 Thread Roger Pau Monné
On Thu, Aug 02, 2018 at 07:58:48AM +, Tian, Kevin wrote: > > +void __hwdom_init arch_iommu_hwdom_init(struct domain *d) > > +{ > > +unsigned long i, top, max_pfn; > > + > > +BUG_ON(!is_hardware_domain(d)); > > + > > +/* Set the default value of inclusive depending on the hardware.

Re: [Xen-devel] [PATCH v4 13/32] libxl_qmp: Connect to QMP socket

2018-08-03 Thread Roger Pau Monné
On Fri, Aug 03, 2018 at 02:54:20PM +0100, Anthony PERARD wrote: > On Thu, Aug 02, 2018 at 11:35:53AM +0200, Roger Pau Monné wrote: > > On Fri, Jul 27, 2018 at 03:05:55PM +0100, Anthony PERARD wrote: > > > +typedef enum { > > > +qmp_state_disconnected = 1, >

Re: [Xen-devel] [PATCH v4 14/32] libxl_qmp: Implement fd callback and read data

2018-08-03 Thread Roger Pau Monné
On Fri, Aug 03, 2018 at 03:32:09PM +0100, Anthony PERARD wrote: > On Thu, Aug 02, 2018 at 11:56:11AM +0200, Roger Pau Monné wrote: > > On Fri, Jul 27, 2018 at 03:05:56PM +0100, Anthony PERARD wrote: > > > +/* The -1 is because there is always space for a NUL character *

Re: [Xen-devel] [PATCH v4 12/32] libxl: Design of an async API to issue QMP commands to QEMUç

2018-08-03 Thread Roger Pau Monné
On Fri, Aug 03, 2018 at 12:18:02PM +0100, Anthony PERARD wrote: > On Thu, Aug 02, 2018 at 11:01:43AM +0200, Roger Pau Monné wrote: > > On Fri, Jul 27, 2018 at 03:05:54PM +0100, Anthony PERARD wrote: > > > +/* > > > + * This facility allows a command to be sen

Re: [Xen-devel] [PATCH v4 12/32] libxl: Design of an async API to issue QMP commands to QEMUç

2018-08-03 Thread Roger Pau Monné
On Fri, Aug 03, 2018 at 03:45:39PM +0100, Anthony PERARD wrote: > On Fri, Aug 03, 2018 at 03:55:48PM +0200, Roger Pau Monné wrote: > > On Fri, Aug 03, 2018 at 12:18:02PM +0100, Anthony PERARD wrote: > > > On Thu, Aug 02, 2018 at 11:01:43AM +0200, Roger Pau Monné wrote: > >

Re: [Xen-devel] PVH dom0 creation fails - the system freezes

2018-07-27 Thread Roger Pau Monné
On Fri, Jul 27, 2018 at 08:48:32AM +, Bercaru, Gabriel wrote: > I tried the patch and it fixes the unusable USB devices problem. > However, I captured the boot messages and the "IOMMU mapping failed" printk > seems to have been executed on each iteration of the loop. > > I attached a small

Re: [Xen-devel] PVH dom0 creation fails - the system freezes

2018-07-26 Thread Roger Pau Monné
On Wed, Jul 25, 2018 at 05:19:03PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > > Of Roger Pau Monné > > Sent: 25 July 2018 15:12 > > To: berca...@amazon.com > > Cc: x

Re: [Xen-devel] [BUG] Serial port prevents PVH dom0 boot

2018-07-26 Thread Roger Pau Monné
On Wed, Jul 25, 2018 at 04:10:59PM -0400, Connor Davis wrote: > When booting into dom0=pvh, using the serial console prevents > dom0 from booting. Serial works until Xen tries to hand off to dom0. > The specific crash varies with the arguments passed to iommu: > > iommu=1,debug console=com1

Re: [Xen-devel] [Memory Accounting] was: Re: PVH dom0 creation fails - the system freezes

2018-07-26 Thread Roger Pau Monné
On Thu, Jul 26, 2018 at 10:45:08AM +0100, George Dunlap wrote: > On Thu, Jul 26, 2018 at 12:07 AM, Boris Ostrovsky > wrote: > > On 07/25/2018 02:56 PM, Andrew Cooper wrote: > >> On 25/07/18 17:29, Juergen Gross wrote: > >>> On 25/07/18 18:12, Roger Pau Monné w

<    1   2   3   4   5   6   7   8   9   10   >