Jackson'
> > ; 'Wei Liu'
> > Subject: Re: [PATCH v1] kdd: remove zero-length arrays
> >
> > On Wed, Jun 17, 2020 at 09:21:22AM +0100, Paul Durrant wrote:
> > > > -Original Message-
> > > > From: Christopher Clark
> > > > Sent:
> -Original Message-
> From: Wei Liu
> Sent: 26 June 2020 11:27
> To: p...@xen.org
> Cc: 'Christopher Clark' ; 'Olaf Hering'
> ; 'Tim Deegan'
> ; 'xen-devel' ; 'Ian Jackson'
> ; 'Wei Liu'
> Subject: Re: [PATCH v1] kdd: remove zero-length arrays
>
> O
On Wed, Jun 17, 2020 at 09:21:22AM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Christopher Clark
> > Sent: 16 June 2020 21:50
> > To: Olaf Hering
> > Cc: Tim Deegan ; xen-devel ;
> > Ian Jackson
> > ; Wei Liu ; p...@xen.org
&g
> -Original Message-
> From: Christopher Clark
> Sent: 16 June 2020 21:50
> To: Olaf Hering
> Cc: Tim Deegan ; xen-devel ;
> Ian Jackson
> ; Wei Liu ; p...@xen.org
> Subject: Re: [PATCH v1] kdd: remove zero-length arrays
>
> On Thu, Jun 11, 2020
On Thu, Jun 11, 2020 at 12:12 PM Olaf Hering wrote:
>
> Am Wed, 10 Jun 2020 20:16:57 +0100
> schrieb Tim Deegan :
>
> > How tedious.
>
> Indeed. This compiles for me as well:
just a nudge on this; it would be nice to get a patch into the tree
since the build failure affects master builds of Xen
Am Wed, 10 Jun 2020 20:16:57 +0100
schrieb Tim Deegan :
> How tedious.
Indeed. This compiles for me as well:
--- orig/kdd.h 2020-06-08 17:40:05.0 +
+++ kdd.h 2020-06-11 19:00:44.234364040 +
@@ -68,7 +68,6 @@
uint16_t len; /* Payload length, excl. header and
At 15:22 +0200 on 09 Jun (1591716153), Olaf Hering wrote:
> Am Tue, 9 Jun 2020 13:15:49 +0100
> schrieb Tim Deegan :
>
> > Olaf, can you try dropping the 'payload' field from the header and
> > replacing the payload[0] in pkt with payload[] ?
>
> In file included from kdd.c:53:
> kdd.h:325:17:
Am Tue, 9 Jun 2020 14:26:46 +0100
schrieb Ian Jackson :
> +uint8_t payload[];
This compiles, but will access memory behind the union{};, which is most likely
not what the intention is.
Olaf
pgpxOU96iXev2.pgp
Description: Digitale Signatur von OpenPGP
Olaf Hering writes ("Re: [PATCH v1] kdd: remove zero-length arrays"):
> Am Tue, 9 Jun 2020 13:15:49 +0100
> schrieb Tim Deegan :
>
> > Olaf, can you try dropping the 'payload' field from the header and
> > replacing the payload[0] in pkt with payload[] ?
>
Am Tue, 9 Jun 2020 13:15:49 +0100
schrieb Tim Deegan :
> Olaf, can you try dropping the 'payload' field from the header and replacing
> the payload[0] in pkt with payload[] ?
In file included from kdd.c:53:
kdd.h:325:17: error: flexible array member in union
325 | uint8_t payload[];
> Tim Deegan ;
> > Wei Liu
> > Subject: [PATCH v1] kdd: remove zero-length arrays
> >
> > Struct 'kdd_hdr' already has a member named 'payload[]' to easily
> > refer to the data after the header. Remove the payload member from
> > 'kdd_pkt' and always use 'kdd_hdr
Am Tue, 9 Jun 2020 10:04:30 +0100
schrieb Paul Durrant :
> OOI which compiler (might be worth mentioning in the commit comment too, for
> reference)? I'm not seeing a problem.
This is from gcc10. I think the build automation for Tumbleweed will show this
error, unless the Tumbleweed image is
> -Original Message-
> From: Jürgen Groß
> Sent: 09 June 2020 10:06
> To: p...@xen.org; 'Olaf Hering' ; 'Paul Durrant'
>
> Cc: xen-devel@lists.xenproject.org; 'Ian Jackson'
> ; 'Wei Liu' ;
> 'Tim Deegan'
> Subject: Re: [PATCH v1] kdd: remove zero-length ar
On 09.06.20 11:04, Paul Durrant wrote:
-Original Message-
From: Olaf Hering
Sent: 09 June 2020 10:00
To: Paul Durrant
Cc: p...@xen.org; xen-devel@lists.xenproject.org; 'Ian Jackson'
; 'Tim
Deegan' ; 'Wei Liu'
Subject: Re: [PATCH v1] kdd: remove zero-length arrays
Am Tue, 9 Jun 2020
> -Original Message-
> From: Olaf Hering
> Sent: 09 June 2020 10:00
> To: Paul Durrant
> Cc: p...@xen.org; xen-devel@lists.xenproject.org; 'Ian Jackson'
> ; 'Tim
> Deegan' ; 'Wei Liu'
> Subject: Re: [PATCH v1] kdd: remove zero-length arrays
>
> Am
Am Tue, 9 Jun 2020 09:55:52 +0100
schrieb Paul Durrant :
> Is it not sufficient to just change the declaration of payload in kdd_pkt
> from [0] to []?
AFAIR this lead to compile errors.
Olaf
pgpeRRQw92FvJ.pgp
Description: Digitale Signatur von OpenPGP
> -Original Message-
> From: Xen-devel On Behalf Of Olaf
> Hering
> Sent: 08 June 2020 21:39
> To: xen-devel@lists.xenproject.org
> Cc: Ian Jackson ; Olaf Hering ;
> Tim Deegan ;
> Wei Liu
> Subject: [PATCH v1] kdd: remove zero-length arrays
>
> Stru
Struct 'kdd_hdr' already has a member named 'payload[]' to easily
refer to the data after the header. Remove the payload member from
'kdd_pkt' and always use 'kdd_hdr' to fix the following compile error:
kdd.c: In function 'kdd_tx':
kdd.c:746:30: error: array subscript 65534 is outside the
18 matches
Mail list logo
