Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Rahul Singh
Hi Ian > On 7 Oct 2021, at 11:50 am, Ian Jackson wrote: > > Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree > node in libxl"): >> On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: >>> We try >>> to make the libxl API &q

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Ian Jackson
Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"): > On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: > > We try > > to make the libxl API "do the right thing" by default. In this case I > > think that means t

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-07 Thread Rahul Singh
Hi Julien, > On 6 Oct 2021, at 6:53 pm, Julien Grall wrote: > > Hi Rahul, > > On 06/10/2021 19:34, Rahul Singh wrote: >>> On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: >>> >>> Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PC

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Julien Grall
Hi Rahul, On 06/10/2021 19:34, Rahul Singh wrote: On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"): Hi Ian What is wrong with putting it in libxl__arch_domain_build_info_setdefault whi

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Rahul Singh
Hi Ian, > On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: > > Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree > node in libxl"): >> Hi Ian >>> What is wrong with putting it in >>> libxl__arch_domain_build_info

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Ian Jackson
Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"): > Hi Ian > > What is wrong with putting it in > > libxl__arch_domain_build_info_setdefault > > which I think exists precisely for this kind of thing ? > >

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Rahul Singh
Hi Ian > On 6 Oct 2021, at 12:07 pm, Ian Jackson wrote: > > Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree > node in libxl"): >> libxl_defbool_val(libxl_defbool db) is implemented in such a way that it >> will assert >&g

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Ian Jackson
Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"): > libxl_defbool_val(libxl_defbool db) is implemented in such a way that it will > assert > if db value is the default. Therefore we have to explicitly set it to > LIBXL_

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Rahul Singh
Hi Stefano, > On 5 Oct 2021, at 10:32 pm, Stefano Stabellini wrote: > > On Tue, 5 Oct 2021, Rahul Singh wrote: >>> On 5 Oct 2021, at 1:38 am, Stefano Stabellini >>> wrote: >>> >>> On Mon, 4 Oct 2021, Rahul Singh wrote: libxl will create an emulated PCI device tree node in the device

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-05 Thread Stefano Stabellini
On Tue, 5 Oct 2021, Rahul Singh wrote: > > On 5 Oct 2021, at 1:38 am, Stefano Stabellini > > wrote: > > > > On Mon, 4 Oct 2021, Rahul Singh wrote: > >> libxl will create an emulated PCI device tree node in the device tree to > >> enable the guest OS to discover the virtual PCI during guest

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-05 Thread Rahul Singh
Hi Stefano, > On 5 Oct 2021, at 1:38 am, Stefano Stabellini wrote: > > On Mon, 4 Oct 2021, Rahul Singh wrote: >> libxl will create an emulated PCI device tree node in the device tree to >> enable the guest OS to discover the virtual PCI during guest boot. >> Emulated PCI device tree node will

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-04 Thread Stefano Stabellini
On Mon, 4 Oct 2021, Rahul Singh wrote: > libxl will create an emulated PCI device tree node in the device tree to > enable the guest OS to discover the virtual PCI during guest boot. > Emulated PCI device tree node will only be created when there is any > device assigned to guest. > > A new area

[PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-04 Thread Rahul Singh
libxl will create an emulated PCI device tree node in the device tree to enable the guest OS to discover the virtual PCI during guest boot. Emulated PCI device tree node will only be created when there is any device assigned to guest. A new area has been reserved in the arm guest physical map at