Re: [Xen-devel] [PATCH 2/4] xen: limit grant v2 interface to the v1 functionality

2017-09-14 Thread Juergen Gross
On 13/09/17 18:20, Boris Ostrovsky wrote: > On 09/13/2017 10:45 AM, Juergen Gross wrote: >> On 13/09/17 15:50, Boris Ostrovsky wrote: >>> On 09/13/2017 09:38 AM, Juergen Gross wrote: On 13/09/17 15:22, Boris Ostrovsky wrote: > On 09/12/2017 02:18 PM, Juergen Gross wrote: >> On

Re: [Xen-devel] [PATCH 04/17] x86emul: support F16C insns

2017-09-14 Thread George Dunlap
On Wed, Sep 13, 2017 at 6:10 PM, George Dunlap wrote: > On Wed, Jun 21, 2017 at 1:01 PM, Jan Beulich wrote: >> Note that this avoids emulating the behavior of VCVTPS2PH found on at >> least some Intel CPUs, which update MXCSR even when the memory

Re: [Xen-devel] [PATCH v5 09/11] vpci/msi: add MSI handlers

2017-09-14 Thread Jan Beulich
>>> On 14.09.17 at 12:08, wrote: > On Thu, Sep 07, 2017 at 09:29:41AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, wrote: >> > +int vpci_msi_arch_enable(struct vpci_arch_msi *arch, struct pci_dev *pdev, >> > + uint64_t

Re: [Xen-devel] [xen-unstable-smoke test] 113438: regressions - FAIL

2017-09-14 Thread Wei Liu
On Thu, Sep 14, 2017 at 11:17:23AM +0100, Wei Liu wrote: > On Thu, Sep 14, 2017 at 04:14:29AM -0600, Jan Beulich wrote: > > >>> On 14.09.17 at 10:49, wrote: > > > flight 113438 xen-unstable-smoke real [real] > > >

Re: [Xen-devel] [PATCH v5 09/11] vpci/msi: add MSI handlers

2017-09-14 Thread Jan Beulich
>>> On 14.09.17 at 12:42, wrote: > On Thu, Sep 14, 2017 at 04:19:44AM -0600, Jan Beulich wrote: >> >>> On 14.09.17 at 12:08, wrote: >> > On Thu, Sep 07, 2017 at 09:29:41AM -0600, Jan Beulich wrote: >> >> >>> On 14.08.17 at 16:28,

Re: [Xen-devel] [xen-unstable-smoke test] 113438: regressions - FAIL

2017-09-14 Thread Jan Beulich
>>> On 14.09.17 at 10:49, wrote: > flight 113438 xen-unstable-smoke real [real] > http://logs.test-lab.xenproject.org/osstest/logs/113438/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >

[Xen-devel] [xen-unstable-smoke test] 113440: regressions - FAIL

2017-09-14 Thread osstest service owner
flight 113440 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/113440/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 15 guest-saverestore.2 fail REGR. vs. 113384

Re: [Xen-devel] [PATCH v3 4/5] ARM: Introduce get_hwdom_madt_size in gic_hw_operations

2017-09-14 Thread Julien Grall
Hi, On 05/09/17 18:14, mja...@caviumnetworks.com wrote: From: Manish Jaggi estimate_acpi_efi_size needs to be updated to provide correct size of hardware domains MADT, which now adds ITS information as well. Introducing gic_get_hwdom_madt_size. Signed-off-by: Manish Jaggi

Re: [Xen-devel] [PATCH 3/3] credit2: xen related changes to add support for runqueue per cpupool.

2017-09-14 Thread Jan Beulich
>>> On 12.09.17 at 02:45, wrote: > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -538,7 +538,34 @@ struct xen_sysctl_numainfo { > typedef struct xen_sysctl_numainfo xen_sysctl_numainfo_t; > DEFINE_XEN_GUEST_HANDLE(xen_sysctl_numainfo_t); >

[Xen-devel] [linux-next test] 113405: regressions - FAIL

2017-09-14 Thread osstest service owner
flight 113405 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/113405/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 19 guest-start/debian.repeat fail REGR. vs. 113353 build-armhf-pvops

Re: [Xen-devel] [PATCH 04/17] x86emul: support F16C insns

2017-09-14 Thread Jan Beulich
>>> On 14.09.17 at 11:13, wrote: > I see now -- you're using a construct that is common all over the code. > > I think the construct could probably use changing, but currently for > readability it's probably better to follow suit. Perhaps, though at the time I couldn't

Re: [Xen-devel] [PATCH v5 04/11] x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for PVH Dom0

2017-09-14 Thread Jan Beulich
>>> On 13.09.17 at 17:55, wrote: > On Tue, Sep 05, 2017 at 08:57:54AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, wrote: >> > --- a/xen/arch/x86/physdev.c >> > +++ b/xen/arch/x86/physdev.c >> > @@ -559,6 +559,15 @@ ret_t do_physdev_op(int

Re: [Xen-devel] q35 support in Xen

2017-09-14 Thread Yi Sun
Hi, Alexey, Have you submitted the patches? If yes, could you please share the link? Thanks, Sun Yi On 17-06-30 06:03:51, Alexey G wrote: > Hi, > > > I saw Anthony's patch, but your extension patch seems still in > > development. Do you have plan to upstream it? I'm also interested in > > this

[Xen-devel] [PATCH] custom parameter handling fixes

2017-09-14 Thread Jan Beulich
The recent changes to their handling introduced a few false warnings, due to checks looking at the wrong string slot. While going through all those commits and looking for patterns similar to the "dom0_mem=" I've noticed this with, I also realized that there were other issues with "dom0_nodes="

Re: [Xen-devel] [PATCH] custom parameter handling fixes

2017-09-14 Thread Juergen Gross
On 14/09/17 10:57, Jan Beulich wrote: > The recent changes to their handling introduced a few false warnings, > due to checks looking at the wrong string slot. While going through all > those commits and looking for patterns similar to the "dom0_mem=" I've > noticed this with, I also realized that

Re: [Xen-devel] [xen-unstable-smoke test] 113438: regressions - FAIL

2017-09-14 Thread Jan Beulich
>>> On 14.09.17 at 12:19, wrote: > On Thu, Sep 14, 2017 at 11:17:23AM +0100, Wei Liu wrote: >> On Thu, Sep 14, 2017 at 04:14:29AM -0600, Jan Beulich wrote: >> > >>> On 14.09.17 at 10:49, wrote: >> > > flight 113438 xen-unstable-smoke real [real]

Re: [Xen-devel] Last posting date for Xen 4.10 is September 15

2017-09-14 Thread Julien Grall
Hi all, A quick reminder, the last posting date for Xen 4.10 is tomorrow (September 15). Cheers, On 07/09/17 09:22, Wei Liu wrote: Hi all, The last posting date for Xen 4.10 is September 15. If you want your features to be included for the release, please make sure they are posted for the

Re: [Xen-devel] [PATCH v3 1/5] ARM: ITS: Introduce common function add_to_host_its_list

2017-09-14 Thread Julien Grall
Hi Manish, On 05/09/17 18:14, mja...@caviumnetworks.com wrote: From: Manish Jaggi add_to_host_its_list will update the host_its_list. This common function to be invoked from gicv3_its_dt_init and gic_v3_its_acpi_probe. Signed-off-by: Manish Jaggi ---

Re: [Xen-devel] [ovmf bisection] complete build-amd64-xsm

2017-09-14 Thread Anthony PERARD
On Thu, Sep 14, 2017 at 11:04:26AM +0100, Julien Grall wrote: > Hi, > > CC Anthony. It sounds like the latest ovmf build is broken. Thanks, This is probably fixed by 5afa5b815936e2b45a375b6521764195bed68680, not yet tested. At least, it build on my machine. Regards, -- Anthony PERARD

Re: [Xen-devel] [PATCH v2] hw/display/xenfb.c: Add trace_xenfb_key_event

2017-09-14 Thread Michael Tokarev
23.08.2017 18:27, Liang Yan wrote: > It may be better to add a trace event to monitor the last moment of > a key event from QEMU to guest VM The patch looks okay, hopefully it is also useful - I haven't dealt with xen and with keys it sends to a guest :) Applied to -trivial, thanks! /mjt

Re: [Xen-devel] [ovmf bisection] complete build-amd64-xsm

2017-09-14 Thread Julien Grall
Hi, CC Anthony. It sounds like the latest ovmf build is broken. Cheers, On 11/09/17 08:21, osstest service owner wrote: branch xen-unstable xenbranch xen-unstable job build-amd64-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu

Re: [Xen-devel] [xen-unstable-smoke test] 113438: regressions - FAIL

2017-09-14 Thread Wei Liu
On Thu, Sep 14, 2017 at 04:29:14AM -0600, Jan Beulich wrote: > >>> On 14.09.17 at 12:19, wrote: > > On Thu, Sep 14, 2017 at 11:17:23AM +0100, Wei Liu wrote: > >> On Thu, Sep 14, 2017 at 04:14:29AM -0600, Jan Beulich wrote: > >> > >>> On 14.09.17 at 10:49,

Re: [Xen-devel] [PATCH v6 05/11] arm64/mm: Add support for XPFO

2017-09-14 Thread Julien Grall
Hi, CC Juergen, Boris and Stefano. On 08/09/17 18:24, Tycho Andersen wrote: On Fri, Sep 08, 2017 at 12:53:47AM -0700, Christoph Hellwig wrote: +/* + * Lookup the page table entry for a virtual address and return a pointer to + * the entry. Based on x86 tree. + */ +static pte_t

Re: [Xen-devel] [PATCH v5 09/11] vpci/msi: add MSI handlers

2017-09-14 Thread Roger Pau Monné
On Thu, Sep 14, 2017 at 04:19:44AM -0600, Jan Beulich wrote: > >>> On 14.09.17 at 12:08, wrote: > > On Thu, Sep 07, 2017 at 09:29:41AM -0600, Jan Beulich wrote: > >> >>> On 14.08.17 at 16:28, wrote: > >> > +int vpci_msi_arch_enable(struct vpci_arch_msi

Re: [Xen-devel] [xen-unstable-smoke test] 113438: regressions - FAIL

2017-09-14 Thread Wei Liu
On Thu, Sep 14, 2017 at 04:14:29AM -0600, Jan Beulich wrote: > >>> On 14.09.17 at 10:49, wrote: > > flight 113438 xen-unstable-smoke real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/113438/ > > > > Regressions :-( > > > > Tests which did not

Re: [Xen-devel] [PATCH v3 2/5] ARM: ITS: Populate host_its_list from ACPI MADT Table

2017-09-14 Thread Julien Grall
On 07/09/17 17:56, Andre Przywara wrote: Hi, Hi Andre, On 05/09/17 18:14, mja...@caviumnetworks.com wrote: From: Manish Jaggi Added gicv3_its_acpi_init to update host_its_list from MADT table. For ACPI, host_its structure stores dt_node as NULL. Signed-off-by:

[Xen-devel] [xen-unstable baseline-only test] 72103: tolerable trouble: blocked/broken/fail/pass

2017-09-14 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72103 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72103/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1)

Re: [Xen-devel] [PATCH v5 09/11] vpci/msi: add MSI handlers

2017-09-14 Thread Roger Pau Monné
On Thu, Sep 07, 2017 at 09:29:41AM -0600, Jan Beulich wrote: > >>> On 14.08.17 at 16:28, wrote: > > +int vpci_msi_arch_enable(struct vpci_arch_msi *arch, struct pci_dev *pdev, > > + uint64_t address, uint32_t data, unsigned int > > vectors) > > +{ >

Re: [Xen-devel] Windows "heinsenbug" (WAS: Re: Notes Design Session: Making Releases Lessons Learned: Improving Our Release Process and Tooling)

2017-09-14 Thread Julien Grall
Hi Paul, On 13/09/17 19:26, Paul Durrant wrote: -Original Message- From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Julien Grall Sent: 13 September 2017 10:52 To: Ian Jackson ; Jan Beuli ch Cc: Juergen Gross

Re: [Xen-devel] [PATCH v3 2/5] ARM: ITS: Populate host_its_list from ACPI MADT Table

2017-09-14 Thread Julien Grall
Hi Manish, On 05/09/17 18:14, mja...@caviumnetworks.com wrote: From: Manish Jaggi Added gicv3_its_acpi_init to update host_its_list from MADT table. For ACPI, host_its structure stores dt_node as NULL. Signed-off-by: Manish Jaggi ---

[Xen-devel] [ovmf test] 113418: regressions - FAIL

2017-09-14 Thread osstest service owner
flight 113418 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/113418/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 113143 build-amd64-xsm

Re: [Xen-devel] [PATCH v3 3/5] ARM: ITS: Deny hardware domain access to ITS

2017-09-14 Thread Julien Grall
On 07/09/17 17:57, Andre Przywara wrote: Hi, Hi, On 05/09/17 18:14, mja...@caviumnetworks.com wrote: From: Manish Jaggi This patch extends the gicv3_iomem_deny_access functionality by adding support for ITS region as well. Add function gicv3_its_deny_access.

[Xen-devel] [xen-unstable-smoke test] 113438: regressions - FAIL

2017-09-14 Thread osstest service owner
flight 113438 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/113438/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 15 guest-saverestore.2 fail REGR. vs. 113384

Re: [Xen-devel] Restore PVHVM DomU with a different MAC

2017-09-14 Thread Wei Liu
On Thu, Sep 14, 2017 at 09:45:37AM +0800, Kangjie Xi wrote: > 2017-09-13 17:24 GMT+08:00 Wei Liu : > > On Wed, Sep 13, 2017 at 04:25:17PM +0800, Kangjie Xi wrote: > >> Hi, > >> > >> I created a Ubuntu-17.04-x64 PVHVM DomU, so I can use "xl > >> network-attach/detach" to

Re: [Xen-devel] [PATCH v5 09/11] vpci/msi: add MSI handlers

2017-09-14 Thread Jan Beulich
>>> On 14.09.17 at 13:35, wrote: > On Thu, Sep 14, 2017 at 04:50:10AM -0600, Jan Beulich wrote: >> >>> On 14.09.17 at 12:42, wrote: >> > On Thu, Sep 14, 2017 at 04:19:44AM -0600, Jan Beulich wrote: >> >> >>> On 14.09.17 at 12:08,

[Xen-devel] [PATCH v5 20/23] x86/mm: split out PV mm code to pv/mm.c

2017-09-14 Thread Wei Liu
A load of functions are moved: 1. {get,put}_page_from_l{2,3,4}e 2. pv_{alloc,free}_page_type 3. all helpers for the above The l1e functions can't be moved because they are needed by shadow code as well. Fix coding style issues while moving. Signed-off-by: Wei Liu ---

[Xen-devel] [PATCH v5 10/23] x86/mm: split out descriptor table manipulation code

2017-09-14 Thread Wei Liu
Move the code to pv/descriptor-tables.c. Change u64 to uint64_t while moving. Use currd in do_update_descriptor. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 155 - xen/arch/x86/pv/Makefile| 1 +

[Xen-devel] [PATCH v5 16/23] x86/mm: add pv prefix to {alloc, free}_page_type

2017-09-14 Thread Wei Liu
And move the declarations to pv/mm.h. The code will be moved later. The stubs contain BUG() because they aren't supposed to be called when PV is disabled. Signed-off-by: Wei Liu --- xen/arch/x86/domain.c | 2 +- xen/arch/x86/mm.c | 14 +++---

[Xen-devel] [PATCH v5 17/23] x86/mm: export base_disallow_mask and l1 mask in asm-x86/mm.h

2017-09-14 Thread Wei Liu
The l1 mask needs to stay in x86/mm.c while l{2,3,4} masks are only needed by PV code. Both x86 common mm code and PV mm code use base_disallow_mask and l1 maks. Export base_disallow_mask and l1 mask in asm-x86/mm.h. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 12

[Xen-devel] [PATCH v5 21/23] x86/mm: move and add pv prefix to invalidate_shadow_ldt

2017-09-14 Thread Wei Liu
It is needed by common mm code and pv code. Move it to pv/mm.c. Export it via asm-x86/pv/mm.h. Use bool for flush parameter while moving. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 44 xen/arch/x86/pv/mm.c|

Re: [Xen-devel] [PATCH 1/3] credit2: libxc related changes to add support for runqueue per cpupool.

2017-09-14 Thread Dario Faggioli
[Trimming the Cc-list a bit] On Tue, 2017-09-12 at 01:45 +0100, anshulmakkar wrote: > libxc receives scheduler specific configuration parametes from  > libxl. > > Signed-off-by: Anshul Makkar > Apart from what Juergen said (including the thing that the series won't

[Xen-devel] [PATCH v5 18/23] x86/mm: export some stuff via local mm.h

2017-09-14 Thread Wei Liu
They will be used by PV mm code and mm hypercall code, which is going to be split into two files. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 30 +++--- xen/arch/x86/pv/mm.h | 21 + 2 files changed, 32 insertions(+), 19

[Xen-devel] [PATCH v5 13/23] x86/mm: factor out pv_arch_init_memory

2017-09-14 Thread Wei Liu
Move the split l4 setup code into the new function. It can then be moved to pv/ in a later patch. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 73 ++- 1 file changed, 40 insertions(+), 33 deletions(-) diff --git

[Xen-devel] [PATCH v5 23/23] x86/mm: remove the now unused inclusion of pv/mm.h

2017-09-14 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 2ffcc53c6c..de66a5272c 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -127,8 +127,6 @@ #include #include -#include

[Xen-devel] [PATCH v5 14/23] x86/mm: move PV l4 table setup code

2017-09-14 Thread Wei Liu
Move the code to pv/mm.c. Export pv_arch_init_memory via global pv/mm.h and init_guest_l4_table via local pv/mm.h. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 82 +--- xen/arch/x86/pv/dom0_build.c | 2 ++

[Xen-devel] [PATCH v5 19/23] x86/mm: export get_page_light via asm-x86/mm.h

2017-09-14 Thread Wei Liu
It is going to be needed by common x86 mm code and pv mm code. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 2 +- xen/include/asm-x86/mm.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index

[Xen-devel] [PATCH v5 12/23] x86/mm: move and rename map_ldt_shadow_page

2017-09-14 Thread Wei Liu
Add pv prefix to it. Move it to pv/mm.c. Fix call sites. Take the chance to change v to curr and d to currd. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 73 --- xen/arch/x86/pv/mm.c| 75

[Xen-devel] [PATCH v5 11/23] x86/mm: move compat descriptor table manipulation code

2017-09-14 Thread Wei Liu
Move them alongside the non-compat variants. Change u{32,64} to uint{32,64}_t while moving. Signed-off-by: Wei Liu --- xen/arch/x86/pv/descriptor-tables.c | 40 + xen/arch/x86/x86_64/compat/mm.c | 39

Re: [Xen-devel] [PATCH v3 13/17] livepatch: Expand spin_debug_disable in [apply|revert]_payload

2017-09-14 Thread Julien Grall
Hi Konrad, On 12/09/17 01:37, Konrad Rzeszutek Wilk wrote: Under ARM64 the vmap calls were all done with IRQs disabled which didn't trip the spinlock debug check (as seen on x86): Well, I think it does not happen because spin_debug_enable() is never called on ARM at boot. So

Re: [Xen-devel] Windows "heinsenbug" (WAS: Re: Notes Design Session: Making Releases Lessons Learned: Improving Our Release Process and Tooling)

2017-09-14 Thread Paul Durrant
> -Original Message- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 14 September 2017 03:49 > To: Paul Durrant ; Ian Jackson > ; Jan Beuli ch > Cc: Juergen Gross ; Wei Liu

[Xen-devel] [PATCH v2 00/17] x86: emulator enhancements

2017-09-14 Thread Jan Beulich
01: support remaining AVX insns 02: re-order cases of main switch statement 03: build SIMD tests with -Os 04: support F16C insns 05: support FMA4 insns 06: support FMA insns 07: support most remaining AVX2 insns 08: fold/eliminate some local variables 09: support AVX2 gather insns 10: add tables

Re: [Xen-devel] [PATCH v3 14/17] livepatch/x86/arm: arch/x86/mm: generalize do_page_walk() and implement arch_livepatch_lookup_mfn

2017-09-14 Thread Julien Grall
Hi Konrad, On 12/09/17 01:37, Konrad Rzeszutek Wilk wrote: With this change we can use _do_page_walk() to implement arch_livepatch_lookup_mfn() which can be used to find out vmap virtual addresses (as under x86 virt_to_mfn won't work for vmap, but it does for arm!). The reason is on ARM,

[Xen-devel] [PATCH v5 00/23] x86: refactor mm.c

2017-09-14 Thread Wei Liu
This series is rather different from v4 because of two things: 1. The staging branch has changed a lot. 2. Try to export stuff via local header where appropriate. The end result is x86/mm.c goes from 6341 lines to 2930 lines, which means more than half of the files is moved. This series can be

[Xen-devel] [PATCH v5 08/23] x86/mm: split out pv grant table code

2017-09-14 Thread Wei Liu
Move the code to pv/grant_table.c. Nothing needs to be done with regard to headers. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 283 xen/arch/x86/pv/Makefile | 1 + xen/arch/x86/pv/grant_table.c | 327

[Xen-devel] [PATCH v5 01/23] x86/mm: move guest_get_eff_l1e to pv/mm.h

2017-09-14 Thread Wei Liu
Mkae it static inline. It well be used by map_ldt_shadow_page and ro page fault emulation code later. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 18 +- xen/arch/x86/pv/mm.h | 21 + 2 files changed, 22 insertions(+), 17 deletions(-)

[Xen-devel] [PATCH v5 02/23] x86/mm: export get_page_from_mfn

2017-09-14 Thread Wei Liu
It will be used later in multiple files. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 16 xen/include/asm-x86/mm.h | 14 ++ 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index

[Xen-devel] [PATCH v5 06/23] x86/mm: remove the now unused inclusion of pv/emulate.h

2017-09-14 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index cc0a7cab41..e77abb015b 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -126,7 +126,6 @@ #include #include -#include

[Xen-devel] [PATCH v5 09/23] x86/mm: add pv prefix to {set, destroy}_gdt

2017-09-14 Thread Wei Liu
Unfortunately they can't stay local to PV code because domain.c still needs them. Change their names and fix up call sites. The code will be moved later together with other descriptor table manipulation code. Also move the declarations to pv/mm.h and provide stubs. Signed-off-by: Wei Liu

[Xen-devel] [PATCH v5 07/23] x86/mm: move map_guest_l1e to pv/mm.c

2017-09-14 Thread Wei Liu
And export the function via pv/mm.h. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 29 xen/arch/x86/pv/Makefile | 1 + xen/arch/x86/pv/mm.c | 69 xen/arch/x86/pv/mm.h | 2 ++ 4 files

[Xen-devel] [PATCH v5 05/23] x86/mm: move ro page fault emulation code

2017-09-14 Thread Wei Liu
Move the code to pv/ro-page-fault.c. Create a new header file asm-x86/pv/mm.h and move the declaration of pv_ro_page_fault there. Include the new header file in traps.c. Fix some coding style issues. The prefixes (ptwr and mmio) are retained because there are two sets of emulation code in the

[Xen-devel] [PATCH v5 03/23] x86/mm: move update_intpte to pv/mm.h

2017-09-14 Thread Wei Liu
While at it, change the type of preserve_ad to bool. Also move UPDATE_ENTRY there. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 65 xen/arch/x86/pv/mm.h | 65 2

[Xen-devel] [PATCH v5 04/23] x86/mm: move {un, }adjust_guest_l*e to pv/mm.h

2017-09-14 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/mm.c| 57 --- xen/arch/x86/pv/mm.h | 62 2 files changed, 62 insertions(+), 57 deletions(-) diff --git a/xen/arch/x86/mm.c

Re: [Xen-devel] [PATCH 1/3] credit2: libxc related changes to add support for runqueue per cpupool.

2017-09-14 Thread Dario Faggioli
On Thu, 2017-09-14 at 08:42 +0200, Juergen Gross wrote: > > --- a/tools/libxc/include/xenctrl.h > > +++ b/tools/libxc/include/xenctrl.h > > @@ -1077,17 +1077,21 @@ typedef struct xc_cpupoolinfo { > >   > >  #define XC_CPUPOOL_POOLID_ANY 0x > >   > > +typedef xen_sysctl_sched_param_t

Re: [Xen-devel] [MirageOS-devel] [Minios-devel] [Xen-API] [RFC] Unicore Subproject Proposal

2017-09-14 Thread Anil Madhavapeddy
On 13 Sep 2017, at 17:13, Samuel Thibault wrote: > > Hello, > > Anil Madhavapeddy, on mer. 13 sept. 2017 11:11:03 +0100, wrote: >> Maintaining a forked MiniOS has been a multi-year source of a maintenance >> burden for MirageOS, > > I'm just wondering why this

Re: [Xen-devel] [PATCH v6 05/11] arm64/mm: Add support for XPFO

2017-09-14 Thread Juergen Gross
On 14/09/17 12:41, Julien Grall wrote: > Hi, > > CC Juergen, Boris and Stefano. > > On 08/09/17 18:24, Tycho Andersen wrote: >> On Fri, Sep 08, 2017 at 12:53:47AM -0700, Christoph Hellwig wrote: +/* + * Lookup the page table entry for a virtual address and return a pointer to

Re: [Xen-devel] [PATCH v3 12/17] livepatch/x86/arm[32, 64]: Unify arch_livepatch_revert

2017-09-14 Thread Julien Grall
Hi Konrad, On 12/09/17 01:37, Konrad Rzeszutek Wilk wrote: diff --git a/xen/include/xen/livepatch.h b/xen/include/xen/livepatch.h index 1659ffcdf0..065c1a323a 100644 --- a/xen/include/xen/livepatch.h +++ b/xen/include/xen/livepatch.h @@ -117,11 +117,10 @@ extern struct livepatch_vmap_stash

Re: [Xen-devel] [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't configured

2017-09-14 Thread Boris Ostrovsky
>> Did you make any changes in xenbus_map_ring_valloc_pv()? I don't see any >> but the diff looks pretty big --- I'd expect only the preprocessor >> directives to show up. > I moved the functions to require only one #ifdef (plus 1 for setting > the pv variants). Oh, OK, I didn't notice that.

Re: [Xen-devel] [PATCH] libxl: add back libxl_device_v{k,f}b_add

2017-09-14 Thread Wei Liu
On Thu, Sep 14, 2017 at 05:27:07PM +0300, Oleksandr Grytsov wrote: > > I've removed these functions as they weren't used. For proper removing > they should be removed from header as well. > If they are required by some extern application could they use generic > async function to add vkb and vfb

Re: [Xen-devel] [Minios-devel] [MirageOS-devel] [Xen-API] [RFC] Unicore Subproject Proposal

2017-09-14 Thread Samuel Thibault
Hello, Anil Madhavapeddy, on jeu. 14 sept. 2017 15:38:54 +0100, wrote: > On 13 Sep 2017, at 17:13, Samuel Thibault > wrote: > > Anil Madhavapeddy, on mer. 13 sept. 2017 11:11:03 +0100, wrote: > >> Maintaining a forked MiniOS has been a multi-year source of a

[Xen-devel] [PATCH] x86/mm: Initialize ol1e in create_grant_pv_mapping() for older compilers

2017-09-14 Thread Boris Ostrovsky
On gcc 4.4.4: mm.c: In function ‘create_grant_pv_mapping’: mm.c:3839: error: ‘ol1e.l1’ may be used uninitialized in this function While ol1e would not be used uninitialized (because rc needs to be properly set) we have to accommodate these older compliers. Signed-off-by: Boris Ostrovsky

[Xen-devel] [xen-4.6-testing baseline-only test] 72104: regressions - FAIL

2017-09-14 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72104 xen-4.6-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72104/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-521

Re: [Xen-devel] [PATCH v3 09/17] livepatch/arm[32, 64]: Modify livepatch_funcs

2017-09-14 Thread Julien Grall
Hi Konrad, On 12/09/17 01:37, Konrad Rzeszutek Wilk wrote: This was found when porting livepatch-build-tools to ARM64/32. When livepatch-build-tools are built (and test-case thanks to: livepatch/tests: Make sure all .livepatch.funcs sections are read-only) the .livepatch.funcs are in read-only

Re: [Xen-devel] [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't configured

2017-09-14 Thread Juergen Gross
On 14/09/17 16:00, Boris Ostrovsky wrote: > On 09/14/2017 08:38 AM, Juergen Gross wrote: >> xenbus_client.c contains some functions specific for pv guests. >> Enclose them with #ifdef CONFIG_XEN_PV to avoid compiling them when >> they are not needed (e.g. on ARM). >> >> Signed-off-by: Juergen

Re: [Xen-devel] [PATCH 3/3] credit2: xen related changes to add support for runqueue per cpupool.

2017-09-14 Thread Dario Faggioli
On Tue, 2017-09-12 at 01:45 +0100, anshulmakkar wrote: > --- a/xen/common/cpupool.c > +++ b/xen/common/cpupool.c > @@ -129,12 +129,13 @@ void cpupool_put(struct cpupool *pool) >   * - unknown scheduler >   */ >  static struct cpupool *cpupool_create( > -int poolid, unsigned int sched_id, int

Re: [Xen-devel] [PATCH v3 04/17] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong text alignment.

2017-09-14 Thread Julien Grall
Hi Konrad, On 12/09/17 01:37, Konrad Rzeszutek Wilk wrote: The ARM 32&64 ELF specification says "sections containing ARM code must be at least 32-bit aligned." This patch adds the check for that. We also make sure that this check is done when doing relocations for the types that are considered

Re: [Xen-devel] [PATCH v5 09/11] vpci/msi: add MSI handlers

2017-09-14 Thread Roger Pau Monné
On Thu, Sep 14, 2017 at 04:50:10AM -0600, Jan Beulich wrote: > >>> On 14.09.17 at 12:42, wrote: > > On Thu, Sep 14, 2017 at 04:19:44AM -0600, Jan Beulich wrote: > >> >>> On 14.09.17 at 12:08, wrote: > >> > On Thu, Sep 07, 2017 at 09:29:41AM -0600, Jan

[Xen-devel] [PATCH v5 15/23] x86/mm: move declaration of new_guest_cr3 to local pv/mm.h

2017-09-14 Thread Wei Liu
It is only used by PV. The code can only be moved together with other PV mm code. Signed-off-by: Wei Liu --- xen/arch/x86/pv/emul-priv-op.c | 1 + xen/arch/x86/pv/mm.h | 2 ++ xen/include/asm-x86/mm.h | 1 - 3 files changed, 3 insertions(+), 1 deletion(-)

[Xen-devel] [PATCH v5 22/23] x86/mm: split out PV mm hypercalls to pv/mm-hypercalls.c

2017-09-14 Thread Wei Liu
Also move new_guest_cr3 there so that we don't have to export mod_l1_entry. Fix coding style issues. Change v to curr, d to currd and u64 to uint64_t where appropriate. Signed-off-by: Wei Liu --- I can't convince git diff to produce sensible diff for donate_page and

[Xen-devel] [xen-4.5-testing test] 113408: regressions - FAIL

2017-09-14 Thread osstest service owner
flight 113408 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/113408/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-winxpsp3 16 guest-localmigrate/x10 fail REGR. vs. 112854 Tests

Re: [Xen-devel] [PATCH] xen: don't compile pv-specific parts if XEN_PV isn't configured

2017-09-14 Thread Boris Ostrovsky
On 09/14/2017 08:38 AM, Juergen Gross wrote: > xenbus_client.c contains some functions specific for pv guests. > Enclose them with #ifdef CONFIG_XEN_PV to avoid compiling them when > they are not needed (e.g. on ARM). > > Signed-off-by: Juergen Gross > --- >

[Xen-devel] FYI qemu-xen updated to v2.10

2017-09-14 Thread Anthony PERARD
On Wed, Aug 02, 2017 at 04:36:34PM +0100, Anthony PERARD wrote: > Hi, > > I've just pushed QEMU v2.9.0 to our qemu-xen tree. And now, v2.10 is in our tree. -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.xen.org

[Xen-devel] [PATCH v2 12/17] x86emul: support 3DNow! insns

2017-09-14 Thread Jan Beulich
Yes, recent AMD CPUs don't support them anymore, but I think we should nevertheless cope. Signed-off-by: Jan Beulich --- a/.gitignore +++ b/.gitignore @@ -223,6 +223,7 @@ tools/security/xensec_tool tools/tests/x86_emulator/*.bin tools/tests/x86_emulator/*.tmp

[Xen-devel] [PATCH 2/2] Introduce migration precopy policy

2017-09-14 Thread Jennifer Herbert
This Patch allows a migration precopy policy to be specified. The precopy phase of the xc_domain_save() live migration algorithm has historically been implemented to run until either a) (almost) no pages are dirty or b) some fixed, hard-coded maximum number of precopy iterations has been

[Xen-devel] [PATCH 0/2] Introduce migration precopy policy

2017-09-14 Thread Jennifer Herbert
Hi all, Here I present a updated/modified subset of patch 7/20, part of Joshua Otto's "Add postcopy live migration support." patch, dated 27th March 2017. As indicated on the original thread, I wish to make use of this this within the XenServer product, and hence am trying to get this subset

[Xen-devel] [PATCH 0/2] Introduce migration precopy policy

2017-09-14 Thread Jennifer Herbert
Hi all, Here I present a updated/modified subset of patch 7/20, part of Joshua Otto's "Add postcopy live migration support." patch, dated 27th March 2017. As indicated on the original thread, I wish to make use of this this within the XenServer product, and hence am trying to get this subset

[Xen-devel] [PATCH 2/2] Introduce migration precopy policy

2017-09-14 Thread Jennifer Herbert
This Patch allows a migration precopy policy to be specified. The precopy phase of the xc_domain_save() live migration algorithm has historically been implemented to run until either a) (almost) no pages are dirty or b) some fixed, hard-coded maximum number of precopy iterations has been

[Xen-devel] [PATCH 1/2] Tidy libxc xc_domain_save

2017-09-14 Thread Jennifer Herbert
Tidy up libxc's xc_domain_save, removing unused paramaters max_iters and max_factor, making matching changes to libxl. Signed-off-by: Jennifer Herbert --- tools/libxc/include/xenguest.h | 4 ++-- tools/libxc/xc_nomigrate.c | 3 +-- tools/libxc/xc_sr_save.c

[Xen-devel] [PATCH] libxl: fix disk listing function

2017-09-14 Thread Wei Liu
The path should be "vbd" not "disk". Fixes fbbaf2cc9 ("libxl: change disk to use generic getting list functions"). Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Ian Jackson Cc: Oleksandr Grytsov

Re: [Xen-devel] Feature control on PV devices

2017-09-14 Thread Joao Martins
On 09/14/2017 05:10 PM, Wei Liu wrote: > On Thu, Sep 07, 2017 at 05:53:54PM +0100, Joao Martins wrote: >> Hey! >> >> We wanted to brought up this small proposal regarding the lack of >> parameterization on PV devices on Xen. >> >> Currently users don't have a way for enforce and control what >>

Re: [Xen-devel] [PATCH v2 7/7] xen/arm: Limit the scope of cpregs.h

2017-09-14 Thread Julien Grall
Hi Stefano, On 13/09/17 22:13, Stefano Stabellini wrote: On Wed, 13 Sep 2017, Julien Grall wrote: Hi Stefano, On 09/12/2017 10:53 PM, Stefano Stabellini wrote: On Tue, 12 Sep 2017, Julien Grall wrote: Currently, cpregs.h is included in pretty much every files even for arm64. However, the

Re: [Xen-devel] [PATCH 06/14] fuzz/x86_emulate: Implement dread() and davail()

2017-09-14 Thread George Dunlap
On Fri, Aug 25, 2017 at 6:45 PM, Andrew Cooper wrote: > On 25/08/17 17:43, George Dunlap wrote: >> Rather than open-coding the "read" from the input file. >> >> Signed-off-by: George Dunlap > > This patch fills me with dread. > > How about

[Xen-devel] [PATCH v2 04/17] x86emul: support F16C insns

2017-09-14 Thread Jan Beulich
Note that this avoids emulating the behavior of VCVTPS2PH found on at least some Intel CPUs, which update MXCSR even when the memory write faults. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c

[Xen-devel] [PATCH v2 08/17] x86emul: fold/eliminate some local variables

2017-09-14 Thread Jan Beulich
Make i switch-wide (at once making it unsigned, as it should have been) and introduce n (for immediate use in enter and aam/aad handling). Eliminate on-stack arrays in pusha/popa handling. Use ea.val instead of a custom variable in bound handling. No (intended) functional change. Signed-off-by:

[Xen-devel] [xen-4.7-testing test] 113412: tolerable FAIL - PUSHED

2017-09-14 Thread osstest service owner
flight 113412 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/113412/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 6 xen-install fail in 113370 pass in 113412

[Xen-devel] [PATCH v2 17/17] x86/HVM: eliminate custom #MF/#XM handling

2017-09-14 Thread Jan Beulich
Use the generic stub exception handling instead. Signed-off-by: Jan Beulich --- v2: Re-base. --- a/tools/tests/x86_emulator/x86_emulate.c +++ b/tools/tests/x86_emulator/x86_emulate.c @@ -134,8 +134,6 @@ int emul_test_read_xcr( } int emul_test_get_fpu( -void

Re: [Xen-devel] [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

2017-09-14 Thread George Dunlap
Ping? I realize this isn't a major feature but it would be nice to get it in for 4.10. -George On Mon, Aug 28, 2017 at 11:34 AM, George Dunlap wrote: > On 08/25/2017 06:37 PM, Andrew Cooper wrote: >> On 25/08/17 17:43, George Dunlap wrote: >>> You don't need

Re: [Xen-devel] [PATCH] libxl: add back libxl_device_v{k,f}b_add

2017-09-14 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: add back libxl_device_v{k,f}b_add"): > On Thu, Sep 14, 2017 at 05:27:07PM +0300, Oleksandr Grytsov wrote: > > > > I've removed these functions as they weren't used. For proper removing > > they should be removed from header as well. > > If they are

Re: [Xen-devel] Booting signed xen.efi through shim

2017-09-14 Thread Tamas K Lengyel
On Thu, Sep 14, 2017 at 12:06 PM, Jan Beulich wrote: On 14.09.17 at 17:43, wrote: >> On Wed, Sep 13, 2017 at 11:42 AM, Jan Beulich wrote: >> On 13.09.17 at 16:40, wrote: On Wed, Sep 13, 2017 at 3:21

[Xen-devel] [PATCH] xen: grant-table: Simplify get_page_frame

2017-09-14 Thread Julien Grall
The implementation of get_page_frame is currently different whether the architecture support sharing memory or paging memory. Both version are extremely similar so it is possible to consolidate in a single implementation. The check for shared/paged memory are gated with the respective ifdef.

[Xen-devel] [PATCH v2 10/17] x86emul: add tables for XOP 08 and 09 extension spaces

2017-09-14 Thread Jan Beulich
Convert the few existing opcodes so far supported. Also adjust two vex_* case labels to better be ext_* (the values are identical). Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -458,6 +458,20 @@

  1   2   >