Re: [Xen-devel] [PATCH for-next 5/9] coverage: introduce generic file

2017-11-08 Thread Jan Beulich
>>> On 30.10.17 at 17:57, wrote: > On Mon, Oct 30, 2017 at 04:48:21PM +, Wei Liu wrote: >> On Thu, Oct 26, 2017 at 10:19:34AM +0100, Roger Pau Monne wrote: >> > --- /dev/null >> > +++ b/xen/common/coverage/coverage.c >> > @@ -0,0 +1,71 @@ >> > +/* >> > + * Generic

Re: [Xen-devel] [PATCH for-next 5/9] coverage: introduce generic file

2017-11-08 Thread Jan Beulich
>>> On 26.10.17 at 11:19, wrote: > --- a/xen/common/coverage/Makefile > +++ b/xen/common/coverage/Makefile > @@ -1,4 +1,4 @@ > -obj-y += gcov_base.o gcov.o > +obj-y += gcov_base.o gcov.o coverage.o These would better be sorted, too. > --- a/xen/include/xen/coverage.h > +++

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Jan Beulich
>>> On 26.10.17 at 12:24, wrote: > On 26/10/17 10:19, Roger Pau Monne wrote: >> diff --git a/xen/common/coverage/Makefile b/xen/common/coverage/Makefile >> index 0e0510679e..e4541a1233 100644 >> --- a/xen/common/coverage/Makefile >> +++ b/xen/common/coverage/Makefile >>

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Jan Beulich
>>> On 26.10.17 at 11:19, wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -28,10 +28,17 @@ config FRAME_POINTER > maybe slower, but it gives very useful debugging information > in case of any Xen bugs. > > +# Hidden option enabled when

[Xen-devel] [xen-unstable test] 115654: regressions - FAIL

2017-11-08 Thread osstest service owner
flight 115654 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/115654/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail REGR. vs. 115526

Re: [Xen-devel] [PATCH for-next 7/9] coverage: introduce support for llvm profiling

2017-11-08 Thread Jan Beulich
>>> On 26.10.17 at 11:19, wrote: > --- /dev/null > +++ b/xen/common/coverage/llvm.c > @@ -0,0 +1,148 @@ > +/* > + * Copyright (C) 2017 Citrix Systems R > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + *

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Roger Pau Monné
On Wed, Nov 08, 2017 at 01:13:29AM -0700, Jan Beulich wrote: > >>> On 26.10.17 at 12:10, wrote: > > On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger Pau Monné wrote: > >> On Thu, Oct 26, 2017 at 11:03:13AM +0100, Wei Liu wrote: > >> > On Thu, Oct 26, 2017 at 10:19:35AM +0100,

[Xen-devel] [qemu-mainline test] 115657: regressions - FAIL

2017-11-08 Thread osstest service owner
flight 115657 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/115657/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qcow2 17 guest-start/debian.repeat fail REGR. vs. 114507

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Jan Beulich
>>> On 26.10.17 at 12:10, wrote: > On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger Pau Monné wrote: >> On Thu, Oct 26, 2017 at 11:03:13AM +0100, Wei Liu wrote: >> > On Thu, Oct 26, 2017 at 10:19:35AM +0100, Roger Pau Monne wrote: >> > > config GCOV >> > > bool "Gcov

[Xen-devel] [distros-debian-squeeze test] 72431: tolerable FAIL

2017-11-08 Thread Platform Team regression test user
flight 72431 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72431/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-amd64-squeeze-netboot-pygrub 10 debian-di-install fail like 72403

Re: [Xen-devel] [PATCH for-next 7/9] coverage: introduce support for llvm profiling

2017-11-08 Thread Roger Pau Monné
On Wed, Nov 08, 2017 at 01:38:59AM -0700, Jan Beulich wrote: > >>> On 26.10.17 at 11:19, wrote: > > --- /dev/null > > +++ b/xen/common/coverage/llvm.c > > +#define LLVM_PROFILE_MAGIC_64 (uint64_t)255 << 56 | (uint64_t)'l' << 48 | \ > > + (uint64_t)'p' << 40 |

[Xen-devel] [libvirt test] 115660: regressions - FAIL

2017-11-08 Thread osstest service owner
flight 115660 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/115660/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qcow2 17 guest-start/debian.repeat fail REGR. vs. 115476

Re: [Xen-devel] [PATCH for-next 7/9] coverage: introduce support for llvm profiling

2017-11-08 Thread Jan Beulich
>>> On 08.11.17 at 09:56, wrote: > On Wed, Nov 08, 2017 at 01:38:59AM -0700, Jan Beulich wrote: >> >>> On 26.10.17 at 11:19, wrote: >> > --- a/xen/include/public/sysctl.h >> > +++ b/xen/include/public/sysctl.h >> > @@ -646,6 +646,12 @@ struct

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Jan Beulich
>>> On 08.11.17 at 12:55, wrote: > On 08/11/17 12:18, Jan Beulich wrote: > On 08.11.17 at 10:07, wrote: >>> In case we are booted via the default boot entry by a generic loader >>> like grub or OVMF it is necessary to distinguish between a HVM guest >>> with

Re: [Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-08 Thread Thomas Gleixner
On Wed, 8 Nov 2017, Joao Martins wrote: > On 11/08/2017 11:06 AM, Thomas Gleixner wrote: > > The only nit-pick I have are the convoluted function names: > > > > pvclock_set_pvti_cpu0_va() pvclock_pvti_cpu0_va() > > > > What on earth does that mean? > > > Those two functions respectively set

Re: [Xen-devel] [PATCH 0/3] x86/xen: support booting PVH guest via standard boot path

2017-11-08 Thread Juergen Gross
On 08/11/17 14:37, Boris Ostrovsky wrote: > On 11/08/2017 04:07 AM, Juergen Gross wrote: >> Booting a Xen PVH guest requires a special boot entry as it is >> mandatory to setup some Xen-specific interfaces rather early. When grub >> or OVMF are used as boot loaders, however, those will fill the

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Juergen Gross
On 08/11/17 12:18, Jan Beulich wrote: On 08.11.17 at 10:07, wrote: >> In case we are booted via the default boot entry by a generic loader >> like grub or OVMF it is necessary to distinguish between a HVM guest >> with a device model supporting legacy devices and a PVH guest

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Paolo Bonzini
On 08/11/2017 12:55, Juergen Gross wrote: > On 08/11/17 12:18, Jan Beulich wrote: > On 08.11.17 at 10:07, wrote: >>> In case we are booted via the default boot entry by a generic loader >>> like grub or OVMF it is necessary to distinguish between a HVM guest >>> with a device

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-08 Thread Julien Grall
Hi Anthony, On 08/11/17 12:13, Anthony PERARD wrote: On Thu, Nov 02, 2017 at 01:49:54PM +, Julien Grall wrote: On 27/10/17 21:16, Stefano Stabellini wrote: On Fri, 27 Oct 2017, Julien Grall wrote: On 27/10/17 08:27, Hao, Xudong wrote: This bug exist much long time, there are many

Re: [Xen-devel] [PATCH for-4.10] gcov: return EOPNOTSUPP for unimplemented gcov domctl

2017-11-08 Thread Julien Grall
Hi, On 07/11/17 14:20, Jan Beulich wrote: On 07.11.17 at 13:31, wrote: ENOSYS should only be used by unimplemented top-level syscalls. Use EOPNOTSUPP instead. Signed-off-by: Roger Pau Monné Reported-by: Jan Beulich

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Paolo Bonzini
On 08/11/2017 13:24, Juergen Gross wrote: >> My understanding of Xen is very rusty at this point, but I think a >> "completely" legacy-free HVM domain will still have a PCI bus and the >> Xen platform device on that bus. >> >> A PVH domain just knows how to access the Xen PV features. > > A HVM

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Jan Beulich
>>> On 08.11.17 at 13:45, wrote: > On 08/11/17 13:31, Jan Beulich wrote: > On 08.11.17 at 12:55, wrote: >>> On 08/11/17 12:18, Jan Beulich wrote: >>> On 08.11.17 at 10:07, wrote: > In case we are booted via the default boot entry by

Re: [Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-08 Thread Thomas Gleixner
On Tue, 7 Nov 2017, Joao Martins wrote: > On 11/06/2017 04:09 PM, Paolo Bonzini wrote: > > On 19/10/2017 15:39, Joao Martins wrote: > >> Right now there is only a pvclock_pvti_cpu0_va() which is defined > >> on kvmclock since: > >> > >> commit dac16fba6fc5 > >> ("x86/vdso: Get pvclock data from

[Xen-devel] [xen-unstable-coverity test] 115672: all pass - PUSHED

2017-11-08 Thread osstest service owner
flight 115672 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/115672/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 92f0d4392e73727819c5a83fcce447515efaf2f5 baseline version: xen

Re: [Xen-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-11-08 Thread Owen Smith
I'd imagine this would be merged via the Xen queue, as it primarily deals with the xen backend Owen > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: 08 November 2017 10:21 > To: Owen Smith > Cc: sstabell...@kernel.org; Anthony Perard

Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-i386-pvgrub

2017-11-08 Thread Wei Liu
On Tue, Nov 07, 2017 at 05:24:32PM +, Julien Grall wrote: > Hi Wei, > > On 07/11/17 15:13, Wei Liu wrote: > > On Tue, Nov 07, 2017 at 03:09:07PM +, Julien Grall wrote: > >> Hi Wei, > >> > >> On 06/11/17 14:55, Wei Liu wrote: > >>> On Mon, Nov 06, 2017 at 01:47:56PM +, osstest service

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-08 Thread Anthony PERARD
On Thu, Nov 02, 2017 at 01:49:54PM +, Julien Grall wrote: > On 27/10/17 21:16, Stefano Stabellini wrote: > > On Fri, 27 Oct 2017, Julien Grall wrote: > > > On 27/10/17 08:27, Hao, Xudong wrote: > > > > This bug exist much long time, there are many discussion last year but > > > > not a > > >

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Juergen Gross
On 08/11/17 13:26, Paolo Bonzini wrote: > On 08/11/2017 13:24, Juergen Gross wrote: >>> My understanding of Xen is very rusty at this point, but I think a >>> "completely" legacy-free HVM domain will still have a PCI bus and the >>> Xen platform device on that bus. >>> >>> A PVH domain just knows

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Juergen Gross
On 08/11/17 13:58, Jan Beulich wrote: On 08.11.17 at 13:45, wrote: >> On 08/11/17 13:31, Jan Beulich wrote: >> On 08.11.17 at 12:55, wrote: On 08/11/17 12:18, Jan Beulich wrote: On 08.11.17 at 10:07, wrote: >> In case

Re: [Xen-devel] [PATCH 0/3] x86/xen: support booting PVH guest via standard boot path

2017-11-08 Thread Boris Ostrovsky
On 11/08/2017 08:40 AM, Juergen Gross wrote: > On 08/11/17 14:37, Boris Ostrovsky wrote: >> On 11/08/2017 04:07 AM, Juergen Gross wrote: >>> Booting a Xen PVH guest requires a special boot entry as it is >>> mandatory to setup some Xen-specific interfaces rather early. When grub >>> or OVMF are

Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-i386-pvgrub

2017-11-08 Thread Julien Grall
Hi Wei, On 08/11/17 11:36, Wei Liu wrote: On Tue, Nov 07, 2017 at 05:24:32PM +, Julien Grall wrote: Hi Wei, On 07/11/17 15:13, Wei Liu wrote: On Tue, Nov 07, 2017 at 03:09:07PM +, Julien Grall wrote: Hi Wei, On 06/11/17 14:55, Wei Liu wrote: On Mon, Nov 06, 2017 at 01:47:56PM

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Juergen Gross
On 08/11/17 13:31, Jan Beulich wrote: On 08.11.17 at 12:55, wrote: >> On 08/11/17 12:18, Jan Beulich wrote: >> On 08.11.17 at 10:07, wrote: In case we are booted via the default boot entry by a generic loader like grub or OVMF it is necessary

Re: [Xen-devel] [PATCH for-4.10] libevtchn: fix build on non-Linux hosts

2017-11-08 Thread Wei Liu
On Wed, Nov 08, 2017 at 12:52:57PM +, Roger Pau Monne wrote: > Non-Linux hosts (where osdep_evtchn_restrict is not yet supported) > made use of errno without including errno.h, fix this by including the > header. > > Signed-off-by: Roger Pau Monné Acked-by: Wei Liu

Re: [Xen-devel] [PATCH 2/3] x86: add guest_late_init hook to hypervisor_x86 structure

2017-11-08 Thread Ingo Molnar
* Juergen Gross wrote: > On 08/11/17 10:40, Ingo Molnar wrote: > > > > * Juergen Gross wrote: > > > >>> Plus add a default empty function (which hypervisors can override). This > >>> avoids > >>> all the hidden conditions and wrappery. > >> > >> Hmm,

Re: [Xen-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-11-08 Thread Gerd Hoffmann
On Fri, Nov 03, 2017 at 11:56:27AM +, Owen Smith wrote: > Improve the input device model in xenfb, by updating the > Qemu input handlers and adding a feature to allow for > raw (unscaled) absolute coordinates to be represented. Reviewed-by: Gerd Hoffmann Will this be

Re: [Xen-devel] [PATCH 2/3] x86: add guest_late_init hook to hypervisor_x86 structure

2017-11-08 Thread Paolo Bonzini
On 08/11/2017 10:07, Juergen Gross wrote: > Add a new guest_late_init hook to the hypervisor_x86 structure. It > will replace the current kvm_guest_init() call which is changed to > make use of the new hook. > > Signed-off-by: Juergen Gross The trivial KVM changes are of course

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Jan Beulich
>>> On 08.11.17 at 10:07, wrote: > In case we are booted via the default boot entry by a generic loader > like grub or OVMF it is necessary to distinguish between a HVM guest > with a device model supporting legacy devices and a PVH guest without > device model. > > PVH guests

[Xen-devel] [linux-linus test] 115658: regressions - trouble: broken/fail/pass

2017-11-08 Thread osstest service owner
flight 115658 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/115658/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-xsm broken test-armhf-armhf-libvirt-xsm 4

[Xen-devel] [PATCH for-4.10] libevtchn: fix build on non-Linux hosts

2017-11-08 Thread Roger Pau Monne
Non-Linux hosts (where osdep_evtchn_restrict is not yet supported) made use of errno without including errno.h, fix this by including the header. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu Cc: Julien

Re: [Xen-devel] [PATCH v7 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-08 Thread Joao Martins
On 11/08/2017 11:06 AM, Thomas Gleixner wrote: > On Tue, 7 Nov 2017, Joao Martins wrote: >> On 11/06/2017 04:09 PM, Paolo Bonzini wrote: >>> On 19/10/2017 15:39, Joao Martins wrote: Right now there is only a pvclock_pvti_cpu0_va() which is defined on kvmclock since: commit

Re: [Xen-devel] [PATCH] xen/privcmd: remove unused variable pageidx

2017-11-08 Thread Juergen Gross
On 08/11/17 14:00, Colin King wrote: > From: Colin Ian King > > Variable pageidx is assigned a value but it is never read, hence it > is redundant and can be removed. Cleans up clang warning: > > drivers/xen/privcmd.c:199:2: warning: Value stored to 'pageidx' > is

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Jan Beulich
>>> On 08.11.17 at 09:49, wrote: > On Wed, Nov 08, 2017 at 01:13:29AM -0700, Jan Beulich wrote: >> >>> On 26.10.17 at 12:10, wrote: >> > On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger Pau Monné wrote: >> >> On Thu, Oct 26, 2017 at 11:03:13AM +0100, Wei

Re: [Xen-devel] [linux-4.9 test] 115504: regressions - FAIL

2017-11-08 Thread Ian Jackson
Roger Pau Monné writes ("Re: [Xen-devel] [linux-4.9 test] 115504: regressions - FAIL"): > On Fri, Nov 03, 2017 at 08:21:31PM +, osstest service owner wrote: > > flight 115504 linux-4.9 real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/115504/ > > > > Regressions :-( > > > >

Re: [Xen-devel] [linux-linus test] 115643: regressions - FAIL

2017-11-08 Thread Ian Jackson
osstest service owner writes ("[linux-linus test] 115643: regressions - FAIL"): > flight 115643 linux-linus real [real] > http://logs.test-lab.xenproject.org/osstest/logs/115643/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >

[Xen-devel] [PATCH] xen/privcmd: remove unused variable pageidx

2017-11-08 Thread Colin King
From: Colin Ian King Variable pageidx is assigned a value but it is never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/xen/privcmd.c:199:2: warning: Value stored to 'pageidx' is never read Signed-off-by: Colin Ian King

Re: [Xen-devel] [PATCH 0/3] x86/xen: support booting PVH guest via standard boot path

2017-11-08 Thread Boris Ostrovsky
On 11/08/2017 04:07 AM, Juergen Gross wrote: > Booting a Xen PVH guest requires a special boot entry as it is > mandatory to setup some Xen-specific interfaces rather early. When grub > or OVMF are used as boot loaders, however, those will fill the boot > parameters in zeropage and there is no

[Xen-devel] [RFC] [Draft Design v2] ACPI/IORT Support in Xen.

2017-11-08 Thread Manish Jaggi
ACPI/IORT Support in Xen. -- Draft 2 Revision History: Changes since v1- - Modified IORT Parsing data structures. - Added RID->StreamID and RID->DeviceID map as per Andre's suggestion. - Added reference code which can be read along with this document. - Removed

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Boris Ostrovsky
On 11/08/2017 08:36 AM, Juergen Gross wrote: > > Regarding ACPI tables: current PVH implementation in Linux kernel > seems not to make use of the special information presented in the boot > information block. It will need to do so for dom0 (and, then, for simplicity, for all PVH guests). -boris

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-08 Thread Govinda Tatti
On 11/8/2017 9:09 AM, Juergen Gross wrote: On 08/11/17 16:00, Govinda Tatti wrote: Thanks Roger for your review comments. Please see below for my comments. On 11/7/2017 5:21 AM, Roger Pau Monné wrote: On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: +out: +    if (!err) + 

Re: [Xen-devel] Unable to create guest PV domain on OMAP5432

2017-11-08 Thread Konrad Rzeszutek Wilk
On Wed, Nov 08, 2017 at 10:47:20AM +0530, Jayadev Kumaran wrote: > Hello all, > > I'm trying to implement Xen hypervisor support on OMAP5432.I have followed > the steps as in > https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions/OMAP5432_uEVM > for the initial setup. I'm able

Re: [Xen-devel] [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

2017-11-08 Thread Alistair Francis
On Tue, Nov 7, 2017 at 11:52 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/07/2017 04:12 AM, Markus Armbruster wrote: >>> Juan Quintela writes: >>> Alistair Francis wrote: > Replace

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-08 Thread Govinda Tatti
Thanks Jan for your review comments. Please see below for my comments. On 11/7/2017 8:40 AM, Jan Beulich wrote: On 06.11.17 at 18:48, wrote: --- a/Documentation/ABI/testing/sysfs-driver-pciback +++ b/Documentation/ABI/testing/sysfs-driver-pciback @@ -11,3 +11,15 @@

[Xen-devel] [qemu-mainline test] 115663: regressions - FAIL

2017-11-08 Thread osstest service owner
flight 115663 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/115663/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qcow2 17 guest-start/debian.repeat fail REGR. vs. 114507 Tests which

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Juergen Gross
On 08/11/17 15:10, Boris Ostrovsky wrote: > On 11/08/2017 08:36 AM, Juergen Gross wrote: >> >> Regarding ACPI tables: current PVH implementation in Linux kernel >> seems not to make use of the special information presented in the boot >> information block. > > It will need to do so for dom0 (and,

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Boris Ostrovsky
On 11/08/2017 09:17 AM, Juergen Gross wrote: > On 08/11/17 15:10, Boris Ostrovsky wrote: >> On 11/08/2017 08:36 AM, Juergen Gross wrote: >>> Regarding ACPI tables: current PVH implementation in Linux kernel >>> seems not to make use of the special information presented in the boot >>> information

Re: [Xen-devel] [RFC v2 5/7] acpi:arm64: Add support for parsing IORT table

2017-11-08 Thread Manish Jaggi
Hi Sameer On 9/21/2017 6:07 AM, Sameer Goel wrote: Add support for parsing IORT table to initialize SMMU devices. * The code for creating an SMMU device has been modified, so that the SMMU device can be initialized. * The NAMED NODE code has been commented out as this will need DOM0 kernel

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-08 Thread Govinda Tatti
Thanks Roger for your review comments. Please see below for my comments. On 11/7/2017 5:21 AM, Roger Pau Monné wrote: On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: The life-cycle of a PCI device in Xen pciback is complex and is constrained by the generic PCI locking mechanism.

Re: [Xen-devel] [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

2017-11-08 Thread Eric Blake
On 11/08/2017 08:51 AM, Alistair Francis wrote: Let me rephrase the question: do we really support compilers that don't understand __func__? The presence of numerous unconditional uses of __func__ in the tree means the answer is no. Let's replace AUDIO_FUNC by plain

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-08 Thread Juergen Gross
On 08/11/17 16:00, Govinda Tatti wrote: > Thanks Roger for your review comments. Please see below for my comments. > > On 11/7/2017 5:21 AM, Roger Pau Monné wrote: >> On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: >>> +out: >>> +    if (!err) >>> +    err = count; >>> + >>> +  

Re: [Xen-devel] [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

2017-11-08 Thread Alistair Francis
On Wed, Nov 8, 2017 at 7:00 AM, Eric Blake wrote: > On 11/08/2017 08:51 AM, Alistair Francis wrote: > > Let me rephrase the question: do we really support compilers that don't > understand __func__? The presence of numerous unconditional uses of > __func__ in the

[Xen-devel] [xen-unstable-smoke test] 115676: tolerable all pass - PUSHED

2017-11-08 Thread osstest service owner
flight 115676 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/115676/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl

Re: [Xen-devel] [PATCH v1] tools/hotplug: convert proc-xen.mount to proc-xen.service

2017-11-08 Thread Olaf Hering
On Thu, Oct 26, Olaf Hering wrote: > > If not, then out-of-tree packages are going to have compatibility > > problems with this change. > Only if they use Requires=proc-xen.mount. Any other objections to this change? How to proceed with this? Olaf signature.asc Description: PGP signature

Re: [Xen-devel] [PATCH v1] tools/hotplug: convert proc-xen.mount to proc-xen.service

2017-11-08 Thread Olaf Hering
On Wed, Nov 08, Wei Liu wrote: > But is there really no way to ask nicely to see if systemd would accept > a change in behaviour? That is, to make proc-xen.mount (or any attempt > to mount API fs) a nop when xenfs is added to API file system. I have considered that as well. If the failing unit

Re: [Xen-devel] [Qemu-devel] [PATCH v3] xen-disk: use an IOThread per instance

2017-11-08 Thread Stefan Hajnoczi
On Tue, Nov 07, 2017 at 05:46:53AM -0500, Paul Durrant wrote: > This patch allocates an IOThread object for each xen_disk instance and > sets the AIO context appropriately on connect. This allows processing > of I/O to proceed in parallel. > > The patch also adds tracepoints into xen_disk to make

[Xen-devel] [PATCH v8 1/5] ptp_kvm: probe for kvm guest availability

2017-11-08 Thread Joao Martins
In the event of moving pvclock_pvti_cpu0_va() definition to common pvclock code, this function would return a value on non KVM guests. Later on this would fail with a GPF on ptp_kvm_init when running on a Xen guest. Therefore, ptp_kvm_init() should check whether it is running in a KVM guest.

[Xen-devel] [PATCH v8 2/5] x86/pvclock: add setter for pvclock_pvti_cpu0_va

2017-11-08 Thread Joao Martins
Right now there is only a pvclock_pvti_cpu0_va() which is defined on kvmclock since: commit dac16fba6fc5 ("x86/vdso: Get pvclock data from the vvar VMA instead of the fixmap") The only user of this interface so far is kvm. This commit adds a setter function for the pvti page and moves

[Xen-devel] [PATCH v8 5/5] MAINTAINERS: xen, kvm: track pvclock-abi.h changes

2017-11-08 Thread Joao Martins
This file defines an ABI shared between guest and hypervisor(s) (KVM, Xen) and as such there should be an correspondent entry in MAINTAINERS file. Notice that there's already a text notice at the top of the header file, hence this commit simply enforces it more explicitly and have both peers

[Xen-devel] [PATCH v8 0/5] x86/xen: pvclock vdso support

2017-11-08 Thread Joao Martins
Hey, This is take 8 for vdso for Xen. PVCLOCK_TSC_STABLE_BIT can be set starting Xen 4.8 which is required for vdso time related calls. In order to have it on, you need to have the hypervisor clocksource be TSC e.g. with the following boot params "clocksource=tsc tsc=stable:socket". Series is

[Xen-devel] [PATCH v8 3/5] x86/xen/time: set pvclock flags on xen_time_init()

2017-11-08 Thread Joao Martins
Specifically check for PVCLOCK_TSC_STABLE_BIT and if this bit is set, then set it too on pvclock flags. This allows Xen clocksource to use it and thus speeding up xen_clocksource_read() callers (i.e. sched_clock()) Signed-off-by: Joao Martins Reviewed-by: Boris

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-08 Thread Pasi Kärkkäinen
Hi, On Wed, Nov 08, 2017 at 09:44:48AM -0600, Govinda Tatti wrote: > Thanks Jan for your review comments. Please see below for my comments. > > On 11/7/2017 8:40 AM, Jan Beulich wrote: > On 06.11.17 at 18:48, wrote: > >>---

[Xen-devel] [PATCH v8 4/5] x86/xen/time: setup vcpu 0 time info page

2017-11-08 Thread Joao Martins
In order to support pvclock vdso on xen we need to setup the time info page for vcpu 0 and register the page with Xen using the VCPUOP_register_vcpu_time_memory_area hypercall. This hypercall will also forcefully update the pvti which will set some of the necessary flags for vdso. Afterwards we

Re: [Xen-devel] [PATCH v1] tools/hotplug: convert proc-xen.mount to proc-xen.service

2017-11-08 Thread Wei Liu
On Wed, Nov 08, 2017 at 05:24:14PM +0100, Olaf Hering wrote: > On Thu, Oct 26, Olaf Hering wrote: > > > > If not, then out-of-tree packages are going to have compatibility > > > problems with this change. > > Only if they use Requires=proc-xen.mount. > > Any other objections to this change? > >

Re: [Xen-devel] [Qemu-devel] [PATCH v3] xen-disk: use an IOThread per instance

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 05:42:27PM +, Stefan Hajnoczi wrote: > On Tue, Nov 07, 2017 at 05:46:53AM -0500, Paul Durrant wrote: > > This patch allocates an IOThread object for each xen_disk instance and > > sets the AIO context appropriately on connect. This allows processing > > of I/O to

Re: [Xen-devel] [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-11-08 Thread Ian Jackson
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > Ian Jackson writes: > > qemu_strtoul fails (returns an error) if the delimiter (that is, the > > first character which is not processed as digit by strtoul) is not > >

Re: [Xen-devel] [PATCH for-next 6/9] kconfig: add llvm coverage option

2017-11-08 Thread Wei Liu
On Wed, Nov 08, 2017 at 04:07:35AM -0700, Jan Beulich wrote: > >>> On 08.11.17 at 09:49, wrote: > > On Wed, Nov 08, 2017 at 01:13:29AM -0700, Jan Beulich wrote: > >> >>> On 26.10.17 at 12:10, wrote: > >> > On Thu, Oct 26, 2017 at 11:08:21AM +0100, Roger

Re: [Xen-devel] Bringing up OSS test framework on moonshot(aarch64) systems

2017-11-08 Thread Ian Jackson
Bhupinder Thakur writes ("Bringing up OSS test framework on moonshot(aarch64) systems"): > While going through [1], I have some queries/doubts on the configuration. > > 1. The following configuration: > > DnsDomain uk.xensource.com > NetNameservers 10.80.248.2 10.80.16.28 10.80.16.67 >

Re: [Xen-devel] Bringing up OSS test framework on moonshot(aarch64) systems

2017-11-08 Thread Julien Grall
Hi Ian, On 08/11/17 11:39, Ian Jackson wrote: Bhupinder Thakur writes ("Bringing up OSS test framework on moonshot(aarch64) systems"): I am trying to bring up OSS test framework on a couple of moonshot systems which are accessible to me remotely. I'm not familiar with the referent of

Re: [Xen-devel] Bringing up OSS test framework on moonshot(aarch64) systems

2017-11-08 Thread Ian Jackson
Julien Grall writes ("Re: Bringing up OSS test framework on moonshot(aarch64) systems"): > On 08/11/17 11:39, Ian Jackson wrote: > > I'm not familiar with the referent of "moonshot" in this context. IME > > "moonshot" is a project name chosen multiple times, for different > > projects, by people

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Juergen Gross
On 08/11/17 13:03, Paolo Bonzini wrote: > On 08/11/2017 12:55, Juergen Gross wrote: >> On 08/11/17 12:18, Jan Beulich wrote: >> On 08.11.17 at 10:07, wrote: In case we are booted via the default boot entry by a generic loader like grub or OVMF it is necessary to

Re: [Xen-devel] [PATCH for-4.10] x86/cpuid: Minor fixups missed from previous work

2017-11-08 Thread Julien Grall
Hi, On 03/11/17 17:35, Andrew Cooper wrote: * Add more feature names to ./xen-cpuid * Vertically align the magic comments in cpufeatureset.h Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Ian Jackson CC: Wei

Re: [Xen-devel] [PATCH for-4.10] gcov: return EOPNOTSUPP for unimplemented gcov domctl

2017-11-08 Thread Jan Beulich
>>> On 07.11.17 at 13:31, wrote: > ENOSYS should only be used by unimplemented top-level syscalls. Use > EOPNOTSUPP instead. > > Signed-off-by: Roger Pau Monné > Reported-by: Jan Beulich Btw I've taken the liberty to make the

Re: [Xen-devel] [PATCH v6 1/1] xen/time: do not decrease steal time after live migration on xen

2017-11-08 Thread Boris Ostrovsky
On 10/31/2017 09:46 PM, Dongli Zhang wrote: > After guest live migration on xen, steal time in /proc/stat > (cpustat[CPUTIME_STEAL]) might decrease because steal returned by > xen_steal_lock() might be less than this_rq()->prev_steal_time which is > derived from previous return value of

Re: [Xen-devel] [PATCH] xen: xenbus_probe_frontend: mark expected switch fall-throughs

2017-11-08 Thread Boris Ostrovsky
On 11/03/2017 04:03 AM, Juergen Gross wrote: > On 02/11/17 19:41, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Addresses-Coverity-ID: 146562 >> Addresses-Coverity-ID: 146563 >> Signed-off-by:

Re: [Xen-devel] [PATCH v2 0/5] xen: grant table interface v2 support

2017-11-08 Thread Boris Ostrovsky
On 11/06/2017 03:46 PM, Boris Ostrovsky wrote: > On 11/02/2017 05:19 AM, Juergen Gross wrote: >> In order to support Linux to run as a pv guest on machines with huge >> memory (>16TB) or as a hvm guest with more than 16TB of memory the >> kernel has to support grant table interface v2, as v1 is

[Xen-devel] [linux-4.9 test] 115671: regressions - FAIL

2017-11-08 Thread osstest service owner
flight 115671 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/115671/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail REGR. vs. 115613 Regressions

Re: [Xen-devel] [PATCH v4] xen: support priv-mapping in an HVM tools domain

2017-11-08 Thread Boris Ostrovsky
On 11/03/2017 04:51 PM, Boris Ostrovsky wrote: > On 11/03/2017 01:04 PM, Paul Durrant wrote: >> If the domain has XENFEAT_auto_translated_physmap then use of the PV- >> specific HYPERVISOR_mmu_update hypercall is clearly incorrect. >> >> This patch adds checks in xen_remap_domain_gfn_array() and

Re: [Xen-devel] [PATCH] xen/pvcalls: remove redundant check for irq >= 0

2017-11-08 Thread Boris Ostrovsky
On 11/03/2017 06:01 AM, Juergen Gross wrote: > On 03/11/17 10:20, Colin King wrote: >> From: Colin Ian King >> >> This is a moot point, but irq is always less than zero at the label >> out_error, so the check for irq >= 0 is redundant and can be removed. >> >> Detected

Re: [Xen-devel] [PATCH] xen/privcmd: remove unused variable pageidx

2017-11-08 Thread Boris Ostrovsky
On 11/08/2017 08:30 AM, Juergen Gross wrote: > On 08/11/17 14:00, Colin King wrote: >> From: Colin Ian King >> >> Variable pageidx is assigned a value but it is never read, hence it >> is redundant and can be removed. Cleans up clang warning: >> >>

Re: [Xen-devel] [PATCH] xen/pvcalls-front: mark expected switch fall-through

2017-11-08 Thread Boris Ostrovsky
On 11/03/2017 04:04 AM, Juergen Gross wrote: > On 02/11/17 19:51, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Notice that in this particular case I placed the "fall through" comment >> on its

Re: [Xen-devel] [PATCH] xen/pvcalls: fix unsigned less than zero error check

2017-11-08 Thread Boris Ostrovsky
On 11/03/2017 05:01 AM, Juergen Gross wrote: > On 03/11/17 09:42, Colin King wrote: >> From: Colin Ian King >> >> The check on bedata->ref is never true because ref is an unsigned >> integer. Fix this by assigning signed int ret to the return of the >> call to

[Xen-devel] [PATCH v2] x86/hvm: do not register hpet mmio during s3 cycle

2017-11-08 Thread Eric Chanudet
Do it once at domain creation (hpet_init). Sleep -> Resume cycles will end up crashing an HVM guest with hpet as the sequence during resume takes the path: -> hvm_s3_suspend -> hpet_reset -> hpet_deinit -> hpet_init -> register_mmio_handler -> hvm_next_io_handler

[Xen-devel] Failed to build qemu-xen on Arch Linux

2017-11-08 Thread Petre Ovidiu PIRCALABU
Hi, I have encountered the following error while building xen ( staging - 9862926902ba035a3741afdf03da40a4d4b57a6f) : AR libqemuutil.a /home/pepi/work/xen/tools/qemu-xen-dir/ui/gtk.c: In function ‘gd_menu_copy’: /home/pepi/work/xen/tools/qemu-xen-dir/ui/gtk.c:1705:5: error:

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-08 Thread Govinda Tatti
Thanks Pasi for your response. Please see below for my comments. On 11/8/2017 11:38 AM, Pasi Kärkkäinen wrote: Hi, On Wed, Nov 08, 2017 at 09:44:48AM -0600, Govinda Tatti wrote: Thanks Jan for your review comments. Please see below for my comments. On 11/7/2017 8:40 AM, Jan Beulich wrote:

Re: [Xen-devel] [BUG] win2008 guest cannot get ip through sriov

2017-11-08 Thread Hao, Xudong
> -Original Message- > From: Roger Pau Monné [mailto:roger@citrix.com] > Sent: Tuesday, November 7, 2017 5:33 PM > To: Hao, Xudong > Cc: Julien Grall ; Stefano Stabellini > ; Lars Kurth ;

Re: [Xen-devel] [PATCH v3 4/7] libxl: support mapping static shared memory areas during domain creation

2017-11-08 Thread Zhongze Liu
Hi Wei, 2017-11-01 23:55 GMT+08:00 Wei Liu : > On Thu, Oct 19, 2017 at 10:36:32AM +0800, Zhongze Liu wrote: >> Add libxl__sshm_add to map shared pages from one DomU to another, The mapping >> process involves the follwing steps: >> >> * Set defaults and check for further

Re: [Xen-devel] [RFC v2 2/7] arm64: Add definitions for fwnode_handle

2017-11-08 Thread Goel, Sameer
On 10/24/2017 8:08 AM, Julien Grall wrote: > Hi Sameer, > > On 19/10/17 15:53, Goel, Sameer wrote: >> On 10/12/2017 6:45 AM, Julien Grall wrote: >>> On 21/09/17 01:37, Sameer Goel wrote: This will be used as a device property to match the DMA capable devices with the associated SMMU.

[Xen-devel] [PATCH V2] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-08 Thread Govinda Tatti
The life-cycle of a PCI device in Xen pciback is complex and is constrained by the generic PCI locking mechanism. - It starts with the device being bound to us, for which we do a function reset (done via SysFS so the PCI lock is held). - If the device is unbound from us, we also do a function

[Xen-devel] [linux-3.18 test] 115673: regressions - FAIL

2017-11-08 Thread osstest service owner
flight 115673 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/115673/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 17 guest-start/debian.repeat fail REGR. vs. 115495 Tests which did

[Xen-devel] [PATCH] x86/pvh: Do not add DSDT and FACS to PVH dom0 XSDT

2017-11-08 Thread Boris Ostrovsky
These tables are pointed to from FADT. Adding them will result in duplicate entries in the guest's tables. Signed-off-by: Boris Ostrovsky --- xen/arch/x86/hvm/dom0_build.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

[Xen-devel] [PATCH 0/3] x86/xen: support booting PVH guest via standard boot path

2017-11-08 Thread Juergen Gross
Booting a Xen PVH guest requires a special boot entry as it is mandatory to setup some Xen-specific interfaces rather early. When grub or OVMF are used as boot loaders, however, those will fill the boot parameters in zeropage and there is no longer a need to do something PVH specific in the early

  1   2   >