Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV display device driver interface

2017-04-14 Thread Oleksandr Grytsov
On Thu, Apr 13, 2017 at 3:54 PM, Ian Jackson wrote: > Oleksandr Grytsov writes ("Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV > display device driver interface"): >> After internal discussion we think that putting positions and >> z-orders of virtual connector

Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV display device driver interface

2017-04-26 Thread Oleksandr Grytsov
On Fri, Apr 14, 2017 at 1:12 PM, Oleksandr Grytsov wrote: > On Thu, Apr 13, 2017 at 3:54 PM, Ian Jackson > wrote: >> Oleksandr Grytsov writes ("Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV >> display device driver interface"): >>> After internal discussio

Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV display device driver interface

2017-05-03 Thread Oleksandr Grytsov
On Tue, May 2, 2017 at 5:28 PM, Ian Jackson wrote: > Oleksandr Grytsov writes ("Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV > display device driver interface"): >> On Thu, Apr 13, 2017 at 3:54 PM, Ian Jackson >> wrote: >> > Can you sketch out w

Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV display device driver interface

2017-05-04 Thread Oleksandr Grytsov
Hi All, Here is configuration proposal with connector (surface) id: 1. Configuration file: vdispl = [ 'backend=0, devId=0, beAlloc=1, connectors=id0:800x600;id1:1024x768' ] * backend - backend domain id or name (if different from dom 0); * devId - device id (if different from 0); * b

Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV display device driver interface

2017-05-12 Thread Oleksandr Grytsov
On Thu, May 4, 2017 at 11:49 AM, Oleksandr Grytsov wrote: > Hi All, > > Here is configuration proposal with connector (surface) id: > > 1. Configuration file: > vdispl = [ 'backend=0, devId=0, beAlloc=1, > connectors=id0:800x600;id1:1024x768' ] > > * ba

Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV display device driver interface

2017-05-18 Thread Oleksandr Grytsov
On Fri, May 12, 2017 at 3:12 PM, Oleksandr Grytsov wrote: > On Thu, May 4, 2017 at 11:49 AM, Oleksandr Grytsov wrote: >> Hi All, >> >> Here is configuration proposal with connector (surface) id: >> >> 1. Configuration file: >> vdispl = [ 'backend=0, d

[Xen-devel] [PATCH v2 3/3] docs: add virtual display driver information

2017-05-25 Thread Oleksandr Grytsov
Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 54 docs/man/xl.pod.1.in | 42 + 2 files changed, 96 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in index

[Xen-devel] [PATCH v2 2/3] xl: add PV display device commands

2017-05-25 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/xl/Makefile | 1 + tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 19 ++ tools/xl/xl_parse.c| 77 ++- tools/xl/xl_parse.h| 2 +- tools/xl/xl_vdispl.c | 166

[Xen-devel] [PATCH v2 0/3] libxl: add PV display device driver interface

2017-05-25 Thread Oleksandr Grytsov
From: Oleksandr Grytsov These patches add PV display device to libxl and xl. Changes since v1: * add connector id; * set connector resolution and id to Xen store; Oleksandr Grytsov (3): libxl: add PV display device driver interface xl: add PV display device commands docs: add virtual

[Xen-devel] [PATCH v2 1/3] libxl: add PV display device driver interface

2017-05-25 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 21 ++ tools/libxl/libxl_create.c | 3 + tools/libxl/libxl_device.c | 178 - tools/libxl/libxl_internal.h

Re: [Xen-devel] [PATCH v2 0/3] libxl: add PV display device driver interface

2017-06-02 Thread Oleksandr Grytsov
On Thu, May 25, 2017 at 3:17 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > These patches add PV display device to libxl and xl. > > Changes since v1: > * add connector id; > * set connector resolution and id to Xen store; > > Oleksandr Grytsov (3): >

Re: [Xen-devel] [PATCH v2 0/3] libxl: add PV display device driver interface

2017-06-09 Thread Oleksandr Grytsov
On Fri, Jun 2, 2017 at 6:22 PM, Oleksandr Grytsov wrote: > On Thu, May 25, 2017 at 3:17 PM, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> These patches add PV display device to libxl and xl. >> >> Changes since v1: >> * add connector id; >&

Re: [Xen-devel] [PATCH RESEND1 00/12] ALSA: vsnd: Add Xen para-virtualized frontend driver

2017-08-17 Thread Oleksandr Grytsov
>>done. > > Will do. If I split, do you think it would be better to move the driver > from sound/drivers to sound/xen folder, so all those files do not mix > with the rest? >> >> * In my taste, a prefix of the subject line should be 'xen-front', >> instead of 'vsnd'. It comes from name of your driver. >> > Will do >> >> [1] [alsa-devel] [PATCH 08/11] ALSA: vsnd: Add timer for period interrupt >> emulation >> >> http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/123617.html >> [2] [PATCH RESEND1 01/12] ALSA: vsnd: Introduce Xen para-virtualized sound >> frontend driver >> >> http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/123654.html >> [3] [alsa-devel] [PATCH RESEND1 12/12] ALSA: vsnd: Introduce Kconfig >> option to enable Xen PV sound >> >> http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/123662.html >> [4] You can see many posts for this; e.g. [alsa-devel] [PATCH 0/7] >> constify ALSA usb_device_id. >> >> http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/123564.html >> >> Regards >> >> Takashi Sakamoto > > Thank you, > Oleksandr > > > ___ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel -- Best Regards, Oleksandr Grytsov. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-17 Thread Oleksandr Grytsov
On Fri, Jul 28, 2017 at 5:13 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:17PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Changes since V3: >> * libxl__device_add renamed to libxl__device_add_async and reworked >&g

Re: [Xen-devel] [PATCH RESEND1 00/12] ALSA: vsnd: Add Xen para-virtualized frontend driver

2017-08-23 Thread Oleksandr Grytsov
frontend driver state? If you have in mind any other solution we would appreciate. -- Best Regards, Oleksandr Grytsov. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-30 Thread Oleksandr Grytsov
On Thu, Aug 17, 2017 at 2:11 PM, Wei Liu wrote: > On Thu, Aug 17, 2017 at 01:13:39PM +0300, Oleksandr Grytsov wrote: >> On Fri, Jul 28, 2017 at 5:13 PM, Wei Liu wrote: >> > On Tue, Jul 18, 2017 at 05:25:17PM +0300, Oleksandr Grytsov wrote: >> >> From: Oleksandr Gryt

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-31 Thread Oleksandr Grytsov
On Wed, Aug 30, 2017 at 6:52 PM, Ian Jackson wrote: > Oleksandr Grytsov writes ("Re: [PATCH v4 00/13] libxl: add PV display device > driver interface"): >> On Thu, Aug 17, 2017 at 2:11 PM, Wei Liu wrote: >> > I'm still waiting for the outcome from the othe

Re: [Xen-devel] [PATCH v4 01/13] libxl: add generic function to add device

2017-09-05 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 2:47 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:18PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Add libxl__device_add to simple write XenStore device conifg >> and libxl__device_add_async to update domain configur

Re: [Xen-devel] [PATCH v4 01/13] libxl: add generic function to add device

2017-09-06 Thread Oleksandr Grytsov
On Wed, Sep 6, 2017 at 12:36 PM, Wei Liu wrote: > On Tue, Sep 05, 2017 at 07:44:34PM +0300, Oleksandr Grytsov wrote: >> On Tue, Sep 5, 2017 at 2:47 PM, Wei Liu wrote: >> > On Tue, Jul 18, 2017 at 05:25:18PM +0300, Oleksandr Grytsov wrote: >> >> From: Olek

Re: [Xen-devel] [PATCH v4 02/13] libxl: add generic functions to get and free device list

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 2:51 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:19PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Add libxl__device_list and libxl__device_list_free >> functions to handle device list using the device >> framewor

Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 4:04 PM, Wei Liu wrote: > On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote: >> Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"): >> > > +rc = snprintf(connector_path, 128, "%s/%d", path, >> > > info->num_connectors); >> >> Why not use GCSPRINT

Re: [Xen-devel] [PATCH v4 10/13] libxl: change nic to use generec add function

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 4:03 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:27PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Signed-off-by: Oleksandr Grytsov >> diff --git a/tools/libxl/libxl_nic.c b/tools/libxl/libxl_nic.c >> index dd07a

Re: [Xen-devel] [PATCH v4 13/13] libxl: make pci and usb setdefault function generic

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 4:06 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:30PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Due to changes in device framework setdefault function >> should have same format. Otherwise calling devicetype >

[Xen-devel] [PATCH 6/6] docs: add vkb device to xl.cfg and xl

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 24 docs/man/xl.pod.1.in | 22 ++ 2 files changed, 46 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in index 4948dd7..a9e10aa

[Xen-devel] [PATCH 3/6] libxl: add backend type to vkb

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov New field backend_type is added to vkb device in order to have QEMU and user space backend simultaneously. Each vkb backend shall read appropriate XS entry and service only own frontends. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_create.c | 4 tools

[Xen-devel] [PATCH 2/6] libxl: fix vkb XS entry and type

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov vkb has vkbd name in XS. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_vkb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_vkb.c b/tools/libxl/libxl_vkb.c index 0d01262..ea6fca8 100644 --- a/tools/libxl/libxl_vkb.c

[Xen-devel] [PATCH 4/6] libxl: vkb add list and info functions

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 10 + tools/libxl/libxl_types.idl | 11 + tools/libxl/libxl_utils.h | 3 ++ tools/libxl/libxl_vkb.c | 106 ++-- 4 files changed, 127 insertions

[Xen-devel] [PATCH 0/6] libxl: create standalone vkb device

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Currently vkb device is the part of FB and console. In embedded application we use vkb protocol to communicate with user space backend. For this purpose we need to have possibility to enable vkb device without QEMU, FB etc. This particular issue was already discussed int

[Xen-devel] [PATCH 5/6] xl: add vkb config parser and CLI

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 ++ tools/xl/xl_cmdtable.c | 15 ++ tools/xl/xl_parse.c| 77 +-- tools/xl/xl_parse.h| 2 +- tools/xl/xl_vkb.c | 141

[Xen-devel] [PATCH 1/6] libxl: move vkb device to libxl_vkb.c

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Logically it is better to move vkb to separate file as vkb device used not only by vfb and console. Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile| 1 + tools/libxl/libxl_console.c | 53 - tools/libxl/libxl_vkb.c

[Xen-devel] [PATCH 2/4] libxl: use libxl__device_kind in LIBXL_DEFINE_UPDATE_DEVID

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Use libxl__..._devtype.type to update device id. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_9pfs.c | 2 +- tools/libxl/libxl_console.c | 2 +- tools/libxl/libxl_device.c | 7 --- tools/libxl/libxl_internal.h | 12 +++- tools/libxl

[Xen-devel] [PATCH 0/4] libxl: use libxl__device_kind string to access device

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov In current implementation the path of device XS entry is created with string from libxl__device_kind enum. But access to the device entry usually done with hardcoded path. This is source of potential errors. This patchset changes hardcoded device name in the XS path to

[Xen-devel] [PATCH 3/4] libxl: move libxl__device_from_ to LIBXL_DEFINE_DEVICE_FROM_TYPE

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov LIBXL_DEFINE_DEVICE_FROM_TYPE uses libxl__..._devtype.type to be assigned as device and backend type. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_9pfs.c | 19 +++ tools/libxl/libxl_console.c | 18 +++--- tools/libxl

[Xen-devel] [PATCH 1/4] libxl: use libxl__device_kind to get device XS entry

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov On adding to XS name of device is taken from libxl__device_kind enum. On getting device from XS the name is hardcoded. It leads to potential mistmatch errors. The patch is using libxl__device_kind everywere to have one source of device name. Signed-off-by: Oleksandr

[Xen-devel] [PATCH 4/4] libxl: move ibxl_devid_to_device_... to LIBXL_DEFINE_DEVID_TO_DEVICE

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_internal.h | 38 ++ tools/libxl/libxl_nic.c | 26 +- tools/libxl/libxl_vdispl.c | 35 +-- tools/libxl/libxl_vkb.c

Re: [Xen-devel] [PATCH 2/6] libxl: fix vkb XS entry and type

2017-10-05 Thread Oleksandr Grytsov
On Thu, Oct 5, 2017 at 12:32 PM, Wei Liu wrote: > On Thu, Oct 05, 2017 at 12:07:07PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> vkb has vkbd name in XS. >> >> Signed-off-by: Oleksandr Grytsov > > This series won't make it to 4.10

Re: [Xen-devel] [PATCH 2/6] libxl: fix vkb XS entry and type

2017-10-05 Thread Oleksandr Grytsov
On Thu, Oct 5, 2017 at 12:49 PM, Oleksandr Grytsov wrote: > On Thu, Oct 5, 2017 at 12:32 PM, Wei Liu wrote: >> On Thu, Oct 05, 2017 at 12:07:07PM +0300, Oleksandr Grytsov wrote: >>> From: Oleksandr Grytsov >>> >>> vkb has vkbd name in XS. >>> >

Re: [Xen-devel] [PATCH 0/5] libxl: add PV sound device

2017-10-24 Thread Oleksandr Grytsov
On Mon, Oct 2, 2017 at 12:49 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > This patch set adds PV sound device support to xl.cfg and xl. > See sndif.h for protocol implementation details. > > > Oleksandr Grytsov (5): > libxl: add PV sound device > li

Re: [Xen-devel] [PATCH 0/6] libxl: create standalone vkb device

2017-10-24 Thread Oleksandr Grytsov
On Thu, Oct 5, 2017 at 12:07 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Currently vkb device is the part of FB and console. > In embedded application we use vkb protocol to communicate > with user space backend. For this purpose we need to have > possibility to

Re: [Xen-devel] [PATCH 0/4] libxl: use libxl__device_kind string to access device

2017-10-24 Thread Oleksandr Grytsov
On Thu, Oct 5, 2017 at 12:30 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > In current implementation the path of device XS entry is created with > string from libxl__device_kind enum. But access to the device entry > usually done with hardcoded path. This is sour

Re: [Xen-devel] [PATCH 0/6] libxl: create standalone vkb device

2017-10-30 Thread Oleksandr Grytsov
On Tue, Oct 24, 2017 at 10:40 AM, Oleksandr Grytsov wrote: > On Thu, Oct 5, 2017 at 12:07 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> Currently vkb device is the part of FB and console. >> In embedded application we use vkb protocol

Re: [Xen-devel] [PATCH 0/4] libxl: use libxl__device_kind string to access device

2017-10-30 Thread Oleksandr Grytsov
On Tue, Oct 24, 2017 at 10:41 AM, Oleksandr Grytsov wrote: > On Thu, Oct 5, 2017 at 12:30 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> In current implementation the path of device XS entry is created with >> string from libxl__device_ki

Re: [Xen-devel] [PATCH 0/5] libxl: add PV sound device

2017-10-30 Thread Oleksandr Grytsov
On Tue, Oct 24, 2017 at 10:27 AM, Oleksandr Grytsov wrote: > On Mon, Oct 2, 2017 at 12:49 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> This patch set adds PV sound device support to xl.cfg and xl. >> See sndif.h for protocol implement

Re: [Xen-devel] [PATCH 3/6] libxl: add backend type to vkb

2017-10-31 Thread Oleksandr Grytsov
On Mon, Oct 30, 2017 at 8:11 PM, Wei Liu wrote: > On Thu, Oct 05, 2017 at 12:07:08PM +0300, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > New field backend_type is added to vkb device > > in order to have QEMU and user space backend > > simultaneo

Re: [Xen-devel] [PATCH 1/5] libxl: add PV sound device

2017-10-31 Thread Oleksandr Grytsov
On Mon, Oct 30, 2017 at 7:39 PM, Wei Liu wrote: > On Mon, Oct 02, 2017 at 12:49:20PM +0300, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > Add PV sound device described in sndif.h > > > > Signed-off-by: Oleksandr Grytsov > > [...] > &

Re: [Xen-devel] [PATCH 1/5] libxl: add PV sound device

2017-10-31 Thread Oleksandr Grytsov
On Mon, Oct 30, 2017 at 7:39 PM, Wei Liu wrote: > On Mon, Oct 02, 2017 at 12:49:20PM +0300, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > Add PV sound device described in sndif.h > > > > Signed-off-by: Oleksandr Grytsov > > [...] > &

Re: [Xen-devel] [PATCH 5/5] docs: add PV sound device config

2017-10-31 Thread Oleksandr Grytsov
On Mon, Oct 30, 2017 at 8:00 PM, Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> wrote: > On Mon, Oct 02, 2017 at 12:49:24PM +0300, Oleksandr Grytsov wrote: > > +=item B > > + > > +Short name of the virtual sound card. > > + > > +=item B &g

[Xen-devel] [PATCH v1 2/5] libxl: add vsnd list and info

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add getting vsnd list amd info API Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 10 ++ tools/libxl/libxl_types.idl | 19 +++ tools/libxl/libxl_utils.h | 3 + tools/libxl/libxl_vsnd.c| 375 +++- 4

[Xen-devel] [PATCH v1 5/5] docs: add PV sound device config

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Update documentation with virtual sound device Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 150 +++ docs/man/xl.pod.1.in | 30 ++ 2 files changed, 180 insertions(+) diff --git a/docs/man

[Xen-devel] [PATCH v1 4/5] xl: add vsnd CLI commands

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add CLI commands to attach, detach and list virtual sound devices Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 tools/xl/xl_vsnd.c | 203

[Xen-devel] [PATCH v1 3/5] xl: add PV sound condif parser

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add config parser for virtual sound devices Signed-off-by: Oleksandr Grytsov --- tools/xl/xl_parse.c | 246 tools/xl/xl_parse.h | 1 + 2 files changed, 247 insertions(+) diff --git a/tools/xl/xl_parse.c b/tools/xl

[Xen-devel] [PATCH v1 0/5] libxl: add PV sound device

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov This patch set adds PV sound device support to xl.cfg and xl. See sndif.h for protocol implementation details. Changes since initial: * fix code style * change unique-id from int to string (to make id more user readable) Oleksandr Grytsov (5): libxl: add PV sound

[Xen-devel] [PATCH v1 1/5] libxl: add PV sound device

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add PV sound device described in sndif.h Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 14 ++ tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools

[Xen-devel] [PATCH v1 0/6] libxl: create standalone vkb device

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Changes since initial: * add setting backend-type to xenstore * add id field to indentify the vkb device on backend side Oleksandr Grytsov (6): libxl: move vkb device to libxl_vkb.c libxl: fix vkb XS entry and type libxl: add backend type and id to vkb libxl

[Xen-devel] [PATCH v1 3/6] libxl: add backend type and id to vkb

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov New field backend_type is added to vkb device in order to have QEMU and user space backend simultaneously. Each vkb backend shall read appropriate XS entry and service only own frontends. Id is a string field which used by the backend to indentify the frontend. Signed

[Xen-devel] [PATCH v1 1/6] libxl: move vkb device to libxl_vkb.c

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Logically it is better to move vkb to separate file as vkb device used not only by vfb and console. Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/Makefile| 1 + tools/libxl/libxl_console.c | 53 - tools

[Xen-devel] [PATCH v1 4/6] libxl: vkb add list and info functions

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 10 tools/libxl/libxl_types.idl | 11 tools/libxl/libxl_utils.h | 3 ++ tools/libxl/libxl_vkb.c | 129 ++-- 4 files changed, 150 insertions

[Xen-devel] [PATCH v1 6/6] docs: add vkb device to xl.cfg and xl

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 28 docs/man/xl.pod.1.in | 22 ++ 2 files changed, 50 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in index 4948dd7

[Xen-devel] [PATCH v1 2/6] libxl: fix vkb XS entry and type

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov vkb has vkbd name in XS. Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_vkb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_vkb.c b/tools/libxl/libxl_vkb.c index 0d01262..ea6fca8 100644 --- a/tools

[Xen-devel] [PATCH v1 5/6] xl: add vkb config parser and CLI

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 ++ tools/xl/xl_cmdtable.c | 15 ++ tools/xl/xl_parse.c| 75 +- tools/xl/xl_parse.h| 2 +- tools/xl/xl_vkb.c | 142

Re: [Xen-devel] [PATCH RFC 3/8] libxl: add backend_features to libxl_device_disk

2017-11-07 Thread Oleksandr Grytsov
th additional parameter (brents). You can add nested entry in libxl__set_xenstore_ as following: flexarray_append(back, "require/feature-persistent", "0"); -- Best Regards, Oleksandr Grytsov. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v1 0/5] libxl: add PV sound device

2017-11-14 Thread Oleksandr Grytsov
On Wed, Nov 1, 2017 at 5:04 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > This patch set adds PV sound device support to xl.cfg and xl. > See sndif.h for protocol implementation details. > > Changes since initial: > * fix code style > * change unique-i

Re: [Xen-devel] [PATCH v1 0/6] libxl: create standalone vkb device

2017-11-14 Thread Oleksandr Grytsov
On Wed, Nov 1, 2017 at 5:05 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Changes since initial: > * add setting backend-type to xenstore > * add id field to indentify the vkb device on backend side > > Oleksandr Grytsov (6): > libxl: move vkb device

Re: [Xen-devel] [PATCH v1 0/5] libxl: add PV sound device

2017-11-20 Thread Oleksandr Grytsov
On Tue, Nov 14, 2017 at 2:38 PM, Oleksandr Grytsov wrote: > On Wed, Nov 1, 2017 at 5:04 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> This patch set adds PV sound device support to xl.cfg and xl. >> See sndif.h for protocol implementa

Re: [Xen-devel] [PATCH v1 0/6] libxl: create standalone vkb device

2017-11-20 Thread Oleksandr Grytsov
On Tue, Nov 14, 2017 at 2:39 PM, Oleksandr Grytsov wrote: > On Wed, Nov 1, 2017 at 5:05 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> Changes since initial: >> * add setting backend-type to xenstore >> * add id field to i

[Xen-devel] [PATCH v4 05/13] docs: add PV display driver information

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 49 docs/man/xl.pod.1.in | 42 + 2 files changed, 91 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs

[Xen-devel] [PATCH v4 08/13] libxl: change vfb to use generec add function

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_console.c | 74 tools/libxl/libxl_create.c | 3 +- tools/libxl/libxl_dm.c | 3 +- tools/libxl/libxl_internal.h | 6 +--- 4 files changed, 25 insertions(+), 61

[Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 24 +++ tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_types.idl | 38

[Xen-devel] [PATCH v4 07/13] libxl: change vkb to use generec add function

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_console.c | 79 tools/libxl/libxl_create.c | 5 +-- tools/libxl/libxl_dm.c | 3 +- tools/libxl/libxl_internal.h | 6 +--- 4 files changed, 19 insertions

[Xen-devel] [PATCH v4 02/13] libxl: add generic functions to get and free device list

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_list and libxl__device_list_free functions to handle device list using the device framework. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_device.c | 66 tools/libxl/libxl_internal.h | 8

[Xen-devel] [PATCH v4 11/13] libxl: change vtpm to use generec add function

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 12 ++- tools/libxl/libxl_vtpm.c | 231 +-- tools/xl/xl_vtpm.c | 3 +- 3 files changed, 73 insertions(+), 173 deletions(-) diff --git a/tools/libxl

[Xen-devel] [PATCH v4 12/13] libxl: remove unneeded DEVICE_ADD macro

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_device.c | 6 ++--- tools/libxl/libxl_disk.c | 5 +++-- tools/libxl/libxl_internal.h | 52 +++- tools/libxl/libxl_pci.c | 3 ++- tools/libxl/libxl_usb.c

[Xen-devel] [PATCH v4 06/13] libxl: change p9 to use generec add function

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_9pfs.c | 67 +++- tools/libxl/libxl_create.c | 2 +- tools/libxl/libxl_internal.h | 7 + tools/libxl/libxl_types.idl | 2 +- tools/xl/xl_parse.c | 4

[Xen-devel] [PATCH v4 04/13] xl: add PV display device commands

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add commands: vdispl-attach, vdispl-list, vdispl-detach and domain config vdispl parser Signed-off-by: Oleksandr Grytsov --- tools/xl/Makefile | 1 + tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 19 ++ tools/xl/xl_parse.c| 75

[Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Changes since V3: * libxl__device_add renamed to libxl__device_add_async and reworked to match the former design; * libxl__device_add used for devices which don't require updating domain config but simple write to Xen Store (9pfs, vkb, vfb); * foll

[Xen-devel] [PATCH v4 01/13] libxl: add generic function to add device

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_add to simple write XenStore device conifg and libxl__device_add_async to update domain configuration and write XenStore device config asynchroniously. Almost all devices have similar libxl__device__add function. This generic functions implement same

[Xen-devel] [PATCH v4 10/13] libxl: change nic to use generec add function

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 9 +- tools/libxl/libxl_checkpoint_device.c | 9 +- tools/libxl/libxl_colo_save.c | 4 +- tools/libxl/libxl_dm.c| 4 +- tools/libxl/libxl_internal.h

[Xen-devel] [PATCH v4 13/13] libxl: make pci and usb setdefault function generic

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Due to changes in device framework setdefault function should have same format. Otherwise calling devicetype set_default causes segfault. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_internal.h | 1 - tools/libxl/libxl_pci.c | 5 +++-- tools/libxl

[Xen-devel] [PATCH v4 09/13] libxl: change disk to use generic getting list functions

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 9 +++- tools/libxl/libxl_checkpoint_device.c | 7 ++- tools/libxl/libxl_create.c| 3 +- tools/libxl/libxl_disk.c | 94 ++- tools

Re: [Xen-devel] [PATCH v4 06/13] libxl: change p9 to use generec add function

2017-07-30 Thread Oleksandr Grytsov
On Fri, Jul 28, 2017 at 7:23 PM, Wei Liu wrote: > On Fri, Jul 28, 2017 at 03:11:34PM +0100, Wei Liu wrote: >> On Tue, Jul 18, 2017 at 05:25:23PM +0300, Oleksandr Grytsov wrote: >> [...] >> > /* Waits for the passed device to reach state XenbusStateInitWait. >> >

Re: [Xen-devel] [PATCH v4 06/13] libxl: change p9 to use generec add function

2017-08-01 Thread Oleksandr Grytsov
On Mon, Jul 31, 2017 at 5:36 PM, Wei Liu wrote: > On Sun, Jul 30, 2017 at 09:42:09PM +0300, Oleksandr Grytsov wrote: >> On Fri, Jul 28, 2017 at 7:23 PM, Wei Liu wrote: >> > On Fri, Jul 28, 2017 at 03:11:34PM +0100, Wei Liu wrote: >> >> On Tue, Jul 18, 2017 at 05:25

Re: [Xen-devel] [PATCH v4 06/13] libxl: change p9 to use generec add function

2017-08-02 Thread Oleksandr Grytsov
On Tue, Aug 1, 2017 at 4:00 PM, Wei Liu wrote: > On Tue, Aug 01, 2017 at 02:58:19PM +0300, Oleksandr Grytsov wrote: >> On Mon, Jul 31, 2017 at 5:36 PM, Wei Liu wrote: >> > On Sun, Jul 30, 2017 at 09:42:09PM +0300, Oleksandr Grytsov wrote: >> >> On Fri, Jul 28, 2

Re: [Xen-devel] [PATCH v4 06/13] libxl: change p9 to use generec add function

2017-08-08 Thread Oleksandr Grytsov
On Fri, Aug 4, 2017 at 2:53 PM, Wei Liu wrote: > On Wed, Aug 02, 2017 at 02:37:10PM +0300, Oleksandr Grytsov wrote: > [...] >> >> >> From other side this rename touches only internals changes: no changes >> >> >> in config file >> >> >

Re: [Xen-devel] [PATCH v2 1/3] libxl: add PV display device driver interface

2017-06-21 Thread Oleksandr Grytsov
On Tue, Jun 20, 2017 at 4:54 PM, Wei Liu wrote: > On Thu, May 25, 2017 at 03:17:29PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> Hi Wei, Thank you for your reply. > I'm sorry, patch like this is impossible to review because: 1. there is > no commit

[Xen-devel] [PATCH v3 08/11] libxl: add libxl__vdispl_devtype to device_type_tbl

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_create.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 4e5ba29..ba3943f 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c

[Xen-devel] [PATCH v3 09/11] libxl: add libxl_devid_to_device_vdispl interface function

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_utils.h | 4 tools/libxl/libxl_vdispl.c | 31 +++ 2 files changed, 35 insertions(+) diff --git a/tools/libxl/libxl_utils.h b/tools/libxl/libxl_utils.h index 25773d8..9e743dc

[Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_add functio. Almost all devices have similar libxl__device__add function. This generic function implements same functionality but using the device handling framework. The device specific part this is setting xen store configuration. This part is

[Xen-devel] [PATCH v3 05/11] libxl: add vdispl setting xen store configuration

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Implemet set_xenstore_config callback for vdispl device driver. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_device.c | 2 +- tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_vdispl.c | 117 ++- 3 files

[Xen-devel] [PATCH v3 11/11] docs: add PV display driver information

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 54 docs/man/xl.pod.1.in | 42 + 2 files changed, 96 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man

[Xen-devel] [PATCH v3 06/11] libxl: implement vdispl get info function

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add implementation of libxl_device_vdispl_getinfo. This function returns extended information about selected vdispl device. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_vdispl.c | 115 - 1 file changed, 114

[Xen-devel] [PATCH v3 10/11] xl: add PV display device commands

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add commands: vdispl-attach, vdispl-list, vdispl-detach and domain config vdispl parser Signed-off-by: Oleksandr Grytsov --- tools/xl/Makefile | 1 + tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 19 ++ tools/xl/xl_parse.c| 77

[Xen-devel] [PATCH v3 00/11] libxl: add PV display device driver interface

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov These patches add PV display device to libxl and xl. To avoid code duplication the device handling framework was extended with following callbacks: * set_default - initializes libxl_device_ structure with default values; * to_device - converts libxl_device_ to

[Xen-devel] [PATCH v3 07/11] libxl: implement device_from_vdispl and update_config_vdispl

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_vdispl.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_vdispl.c b/tools/libxl/libxl_vdispl.c index 1a6c8b7..ab90cb1 100644 --- a/tools/libxl/libxl_vdispl.c +++ b

[Xen-devel] [PATCH v3 03/11] libxl: add generic function to get and free device list

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_list, libxl__device_list_free. Device list is created from libxl xen store entries. In order to fill libxl device structure from xen store, the device handling framework extended with from_xenstore callback. On this callback libxl_device shall be filled

[Xen-devel] [PATCH v3 01/11] libxl: add vdispl structures to idl

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl_device_vdispl and libxl_vdisplinfo to libxl_types.idl Add VDISPL to libxl__device_kind enumerator Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_types.idl | 38 +++- tools/libxl/libxl_types_internal.idl | 1

[Xen-devel] [PATCH v3 02/11] libxl: add API for PV display device driver

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov add libxl_vdispl.c with API for display device driver add libxl_vdispl.o to Makefile Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h| 21 + tools/libxl/libxl_vdispl.c | 77

Re: [Xen-devel] [PATCH v3 01/11] libxl: add vdispl structures to idl

2017-06-30 Thread Oleksandr Grytsov
Hi Wei, Thanks for the review. This field is already defined in the display protocol. To avoid misunderstanding I prefer to use same name in libxl as well. On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu wrote: > On Tue, Jun 27, 2017 at 01:03:17PM +0300, Oleksandr Grytsov wrote: >> From:

Re: [Xen-devel] [PATCH v3 11/11] docs: add PV display driver information

2017-06-30 Thread Oleksandr Grytsov
Same as for idl file. I prefer to have name similar to one in the protocol. To avoid camel case it can be renamed to be-alloc. On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu wrote: > On Tue, Jun 27, 2017 at 01:03:27PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> &

Re: [Xen-devel] [PATCH v3 00/11] libxl: add PV display device driver interface

2017-06-30 Thread Oleksandr Grytsov
ndlers > mostly look OK to me. -- Best Regards, Oleksandr Grytsov. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-06-30 Thread Oleksandr Grytsov
On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu wrote: > On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Add libxl__device_add functio. > > function > >> Almost all devices have similar libxl__device__ad

  1   2   >