Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

2018-03-01 Thread Roger Pau Monné
On Wed, Feb 28, 2018 at 09:24:09AM -0700, Jan Beulich wrote: > >>> On 28.02.18 at 16:37, wrote: > > On Fri, Feb 23, 2018 at 07:07:18PM +, Wei Liu wrote: > >> On Fri, Feb 23, 2018 at 01:27:43PM +, Roger Pau Monne wrote: > >> > --- a/arch/x86/include/arch/lib.h > >> >

Re: [Xen-devel] [PATCH v3] x86/mm: Suppresses vm_events caused by page-walks

2018-03-01 Thread Razvan Cojocaru
On 02/28/2018 03:56 PM, Jan Beulich wrote: On 28.02.18 at 14:41, wrote: > On 28.02.18 at 14:25, wrote: >>> --- a/xen/arch/x86/mm/mem_access.c >>> +++ b/xen/arch/x86/mm/mem_access.c >>> @@ -137,6 +137,23 @@ bool

Re: [Xen-devel] [PATCH v3] x86/mm: Suppresses vm_events caused by page-walks

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 11:00, wrote: > On 02/28/2018 03:56 PM, Jan Beulich wrote: > On 28.02.18 at 14:41, wrote: >> On 28.02.18 at 14:25, wrote: --- a/xen/arch/x86/mm/mem_access.c +++

Re: [Xen-devel] [PATCH 2/6] xen/credit2: Move repl_timer into struct csched2_dom

2018-03-01 Thread Dario Faggioli
On Wed, 2018-02-28 at 15:26 +, George Dunlap wrote: > On 02/28/2018 02:14 PM, Andrew Cooper wrote: > > For exactly the same reason as 418ae6021d. Having a separate > > allocation is > > unnecessary and wasteful. > > > > Signed-off-by: Andrew Cooper > >

Re: [Xen-devel] [RFC Patch v4 8/8] x86/hvm: bump the maximum number of vcpus to 512

2018-03-01 Thread Chao Gao
On Thu, Mar 01, 2018 at 12:37:57AM -0700, Jan Beulich wrote: Chao Gao 03/01/18 7:34 AM >>> >>On Mon, Feb 26, 2018 at 09:10:33AM -0700, Jan Beulich wrote: >>>Again - here we're talking about implementation limits, not >>>bottlenecks. So in this context all I'm interested

Re: [Xen-devel] [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 07:11, Juergen Gross wrote: >> Probably a better place for these would be >> arch/x86/platform/pvh/{enlighten.c,head.S}. (Just because there are no >> .c or .S files in arch/x86). > Right. > >> Maybe Xen ought to be moved under >> arch/x86/platform too. > And hyperv and kvm, too?

Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 10:55, wrote: > On Wed, Feb 28, 2018 at 09:24:09AM -0700, Jan Beulich wrote: >> >>> On 28.02.18 at 16:37, wrote: >> > On Fri, Feb 23, 2018 at 07:07:18PM +, Wei Liu wrote: >> >> On Fri, Feb 23, 2018 at 01:27:43PM +, Roger Pau

Re: [Xen-devel] [PATCH 1/6] xen/domain: Reduce the quantity of initialisation for system domains

2018-03-01 Thread Dario Faggioli
On Wed, 2018-02-28 at 14:14 +, Andrew Cooper wrote: > * System domains don't need watchdog initialisation or iomem/irq > rangesets, >and will not plausibly be a xenstore or hardware domain. > * The idle domain doesn't need scheduler initialisation (and in > particular, >removing this

Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 11:14, wrote: > Hm, nice. Then I basically need to issue both a LFENCE and MFENCE > because I don't plan to introduce an alternatives framework to XTF > ATM. Or you could skip the test if you find LFENCE isn't serializing on AMD. After all the hypervisor

Re: [Xen-devel] [PATCH 0/9] drm/xen-front: Add support for Xen PV display frontend

2018-03-01 Thread Oleksandr Andrushchenko
On 03/01/2018 10:26 AM, Gerd Hoffmann wrote: Hi, 1. Possible security issues - VirtIO devices are PCI bus masters, thus allowing real device (running, for example, in untrusted driver domain) to get control over guest's memory by writing to its memory 2. VirtIO currently uses GFNs written

Re: [Xen-devel] [PATCH 3/6] xen/sched: Improvements to the {alloc, free}_domdata() interfaces

2018-03-01 Thread Dario Faggioli
On Wed, 2018-02-28 at 14:14 +, Andrew Cooper wrote: > The main purpose of this change is for the subsequent cleanup it > enables, but > it stands on its own merits. > > In principle, these hooks are optional, but the SCHED_OP() default > aliases a > memory allocation failure, which causes

[Xen-devel] [xen-unstable test] 120076: regressions - FAIL

2018-03-01 Thread osstest service owner
flight 120076 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/120076/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-cubietruck 6 xen-installfail REGR. vs. 120037

Re: [Xen-devel] [PATCH 0/9] drm/xen-front: Add support for Xen PV display frontend

2018-03-01 Thread Gerd Hoffmann
Hi, > 1. Possible security issues - VirtIO devices are PCI bus masters, thus > allowing real device (running, for example, in untrusted driver domain) > to get control over guest's memory by writing to its memory > > 2. VirtIO currently uses GFNs written into the shared ring, without Xen >

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

2018-03-01 Thread Jan Beulich
>>> On 28.02.18 at 19:32, wrote: > On 28/02/18 16:40, Jan Beulich wrote: > On 26.02.18 at 18:35, wrote: >>> --- a/xen/arch/x86/hvm/viridian.c >>> +++ b/xen/arch/x86/hvm/viridian.c >>> @@ -554,13 +554,11 @@ static void

Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

2018-03-01 Thread Roger Pau Monné
On Thu, Mar 01, 2018 at 03:04:29AM -0700, Jan Beulich wrote: > >>> On 01.03.18 at 10:55, wrote: > > On Wed, Feb 28, 2018 at 09:24:09AM -0700, Jan Beulich wrote: > >> >>> On 28.02.18 at 16:37, wrote: > >> > On Fri, Feb 23, 2018 at 07:07:18PM +, Wei

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-03-01 Thread Roger Pau Monné
On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: > >>> Andrew Cooper 02/28/18 7:20 PM >>> > >On 28/02/18 16:22, Jan Beulich wrote: > > On 26.02.18 at 12:35, wrote: > >>> --- a/xen/include/asm-x86/alternative-asm.h > >>> +++

[Xen-devel] Xen Security Advisory 255 (CVE-2018-7541) - grant table v2 -> v1 transition may crash Xen

2018-03-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-7541 / XSA-255 version 4 grant table v2 -> v1 transition may crash Xen UPDATES IN VERSION 4 CVE assigned. ISSUE DESCRIPTION

[Xen-devel] Xen Security Advisory 252 (CVE-2018-7540) - DoS via non-preemptable L3/L4 pagetable freeing

2018-03-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-7540 / XSA-252 version 3 DoS via non-preemptable L3/L4 pagetable freeing UPDATES IN VERSION 3 CVE assigned. ISSUE DESCRIPTION

[Xen-devel] Xen Security Advisory 256 (CVE-2018-7542) - x86 PVH guest without LAPIC may DoS the host

2018-03-01 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-7542 / XSA-256 version 3 x86 PVH guest without LAPIC may DoS the host UPDATES IN VERSION 3 CVE assigned. ISSUE DESCRIPTION

[Xen-devel] [PATCH] tools: drop stale references to xml2-config

2018-03-01 Thread Olaf Hering
Fixes commit 185bb58be3 ("tools: drop libxen") Signed-off-by: Olaf Hering --- config/Tools.mk.in | 1 - tools/configure.ac | 1 - 2 files changed, 2 deletions(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 0f79f4e0c2..7831159257 100644 --- a/config/Tools.mk.in

Re: [Xen-devel] [PATCH] tools: drop stale references to xml2-config

2018-03-01 Thread Olaf Hering
Am Thu, 1 Mar 2018 15:22:21 +0100 schrieb Olaf Hering : > Fixes commit 185bb58be3 ("tools: drop libxen") > CURL_CONFIG := @CURL@ > AC_ARG_VAR([CURL], [Path to curl-config tool]) These are stale as well. Somehow I overlooked that, will send v2. Olaf

Re: [Xen-devel] [PATCH 6/7] drivers/passthrough/arm: Refactor code for arm smmu drivers

2018-03-01 Thread Julien Grall
Hi, On 09/02/18 03:10, Sameer Goel wrote: Pull common defines for SMMU drives in a local header. s/drivers/ Signed-off-by: Sameer Goel --- xen/drivers/passthrough/arm/arm_smmu.h | 125 + xen/drivers/passthrough/arm/smmu-v3.c |

Re: [Xen-devel] get_page_from_gfn() for foreign pages

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 15:17, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 01 March 2018 14:00 >> To: Paul Durrant >> Cc: xen-devel (xen-devel@lists.xenproject.org) > de...@lists.xenproject.org> >>

Re: [Xen-devel] [PATCH v2 3/7] x86/alt: Clean up the assembly used to generate alternatives

2018-03-01 Thread Wei Liu
On Mon, Feb 26, 2018 at 11:35:00AM +, Andrew Cooper wrote: > * On the C side, switch to using local lables rather than hardcoded numbers. > * Rename parameters and lables to be consistent with alt_instr names, and >consistent between the the C and asm versions. > * On the asm side,

Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 12:46, wrote: > On 23/02/18 13:27, Roger Pau Monne wrote: >> Add a basic HPET functionality test, note that this test requires the >> HPET to support level triggered interrupts. >> >> Further improvements should add support for interrupt delivery, and

Re: [Xen-devel] [PATCH 5/6] xen/domain: Call sched_destroy_domain() in the domain_create() error path

2018-03-01 Thread Dario Faggioli
On Wed, 2018-02-28 at 14:14 +, Andrew Cooper wrote: > If domain_create() fails, complete_domain_destroy() doesn't get > called, > meaning that sched_destroy_domain() is missed. In practice, this can > only > fail because of exceptional late_hwdom_init() issues at the moment. > > Make

Re: [Xen-devel] get_page_from_gfn() for foreign pages

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 12:39, wrote: > Whilst debugging my PV-IOMMU code I ran into an issue with > get_page_from_gfn(): It is failing when the gfn in question is actually a > grant map from another domain, and the reason for this is that get_page(page, > domain)

Re: [Xen-devel] [PATCH 5/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-03-01 Thread Julien Grall
Hi, On 09/02/18 03:10, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced to bridge the API calls. - Called Linux functions from the Xen IOMMU function calls. - Xen modifications

Re: [Xen-devel] get_page_from_gfn() for foreign pages

2018-03-01 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 01 March 2018 14:32 > To: Paul Durrant > Cc: xen-devel (xen-devel@lists.xenproject.org) de...@lists.xenproject.org> > Subject: RE: [Xen-devel] get_page_from_gfn() for foreign pages > >

Re: [Xen-devel] [PATCH 5/6] xen/domain: Call sched_destroy_domain() in the domain_create() error path

2018-03-01 Thread Dario Faggioli
On Wed, 2018-02-28 at 14:14 +, Andrew Cooper wrote: > If domain_create() fails, complete_domain_destroy() doesn't get > called, > meaning that sched_destroy_domain() is missed. In practice, this can > only > fail because of exceptional late_hwdom_init() issues at the moment. > > Make

Re: [Xen-devel] get_page_from_gfn() for foreign pages

2018-03-01 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 01 March 2018 14:00 > To: Paul Durrant > Cc: xen-devel (xen-devel@lists.xenproject.org) de...@lists.xenproject.org> > Subject: Re: [Xen-devel] get_page_from_gfn() for foreign pages > >

Re: [Xen-devel] [PATCH 5/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 15:07, wrote: > On 09/02/18 03:10, Sameer Goel wrote: >> This driver follows an approach similar to smmu driver. The intent here >> is to reuse as much Linux code as possible. >> - Glue code has been introduced to bridge the API calls. >> - Called Linux

[Xen-devel] [PATCH v2] tools: drop stale references to curl/xml2-config

2018-03-01 Thread Olaf Hering
Fixes commit 185bb58be3 ("tools: drop libxen") Signed-off-by: Olaf Hering --- config/Tools.mk.in | 2 -- tools/configure.ac | 2 -- 2 files changed, 4 deletions(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 0f79f4e0c2..2d6c440324 100644 --- a/config/Tools.mk.in

Re: [Xen-devel] [PATCH 5/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-03-01 Thread Julien Grall
Hi Jan, On 01/03/18 14:21, Jan Beulich wrote: On 01.03.18 at 15:07, wrote: On 09/02/18 03:10, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced to bridge

Re: [Xen-devel] [PATCH 0/7] SMMUv3 driver

2018-03-01 Thread Julien Grall
Hi, On 09/02/18 03:10, Sameer Goel wrote: This patch set adds support for the SMMUv3 driver. This is a continuation on a RFCv4.[1] The IORT support came from [2]. This RFC has some conflicting defines that have to be addressed by introducing the linux_compat.h header in IORT patch set. In any

[Xen-devel] get_page_from_gfn() for foreign pages

2018-03-01 Thread Paul Durrant
Whilst debugging my PV-IOMMU code I ran into an issue with get_page_from_gfn(): It is failing when the gfn in question is actually a grant map from another domain, and the reason for this is that get_page(page, domain) explicitly fails if the page owner is not the domain specified to the call.

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-01 Thread Wei Liu
On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > XSA-256 forces the local APIC to always be enabled for PVH guests, so > ignore any apic option for PVH guests. Update the documentation > accordingly. I think how I will approach this is to dictate that PVH always has LAPIC in our

[Xen-devel] [seabios test] 120079: regressions - FAIL

2018-03-01 Thread osstest service owner
flight 120079 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/120079/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not

Re: [Xen-devel] [PATCH] libxc: really tolerate empty PV records

2018-03-01 Thread Wei Liu
On Tue, Feb 27, 2018 at 07:51:22AM -0700, Jan Beulich wrote: > Commit 119ee4d773 ("tools/libxc: Tolerate specific zero-content records > in migration v2 streams") meant tolerate those, but failed to set rc > accordingly. > > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu

Re: [Xen-devel] [PATCH v2 1/2] firmware/shim: better filtering of dependency files during Xen tree setup

2018-03-01 Thread Wei Liu
On Wed, Feb 28, 2018 at 04:34:58AM -0700, Jan Beulich wrote: > I have no idea what *.d1 is supposed to refer to - we only have .*.d > and .*.d2 files (note also the leading dot). Also switch to passing > -name instead of -path to find - that's a requirement for .*.d et al to > work, but would

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

2018-03-01 Thread Andrew Cooper
On 01/03/18 09:58, Jan Beulich wrote: > @@ -173,11 +175,26 @@ int guest_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val) _MSR_MISC_FEATURES_CPUID_FAULTING; break; +case 0x4000 ... 0x41ff: >>> As was already suggested,

Re: [Xen-devel] [PATCH V2] libxl: set channel devid when not provided by application

2018-03-01 Thread Wei Liu
On Mon, Feb 26, 2018 at 11:28:39AM -0700, Jim Fehlig wrote: > Applications like libvirt may not populate a device devid field, > delegating that to libxl. If needed, the application can later > retrieve the libxl-produced devid. Indeed most devices are handled > this way in libvirt, channel

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 11:36, wrote: > On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: >> >>> Andrew Cooper 02/28/18 7:20 PM >>> >> >On 28/02/18 16:22, Jan Beulich wrote: >> > On 26.02.18 at 12:35, wrote:

Re: [Xen-devel] [PATCH v3] x86/mm: Suppresses vm_events caused by page-walks

2018-03-01 Thread Razvan Cojocaru
On 03/01/2018 12:09 PM, Jan Beulich wrote: On 01.03.18 at 11:00, wrote: >> On 02/28/2018 03:56 PM, Jan Beulich wrote: >> On 28.02.18 at 14:41, wrote: >>> On 28.02.18 at 14:25, wrote: > ---

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

2018-03-01 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 28 February 2018 18:22 > To: Paul Durrant ; Xen-devel de...@lists.xen.org> > Cc: Jan Beulich ; Jun Nakajima > ; Kevin Tian ; Boris > Ostrovsky

Re: [Xen-devel] [PATCH 6/6] x86/msr: Blacklist various MSRs which guests definitely shouldn't be using

2018-03-01 Thread Jan Beulich
>>> On 26.02.18 at 18:35, wrote: > @@ -183,6 +187,15 @@ int guest_rdmsr(const struct vcpu *v, uint32_t msr, > uint64_t *val) > ret = guest_rdmsr_x2apic(v, msr, val); > goto out; > > +case 0xc80: > +/* Silicon Debug Inferface not

Re: [Xen-devel] [PATCH 4/6] xen/sched: Remove {init, destroy}_domain() interfaces

2018-03-01 Thread Dario Faggioli
On Wed, 2018-02-28 at 16:33 +, Andrew Cooper wrote: > On 28/02/18 16:22, George Dunlap wrote: > > > > I kind of feel like there was a reason for the init / alloc > > difference; > > but as you say, at the moment all the schedulers are basically > > identical. In the unlikely event that we

[Xen-devel] [libvirt test] 120084: tolerable all pass - PUSHED

2018-03-01 Thread osstest service owner
flight 120084 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/120084/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 120053 test-armhf-armhf-libvirt-xsm 14

Re: [Xen-devel] [PATCH V6] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-03-01 Thread Jan Beulich
>>> On 28.02.18 at 11:38, wrote: > In hardware, when PCID support is enabled and the NOFLUSH bit is set > when writing a CR3 value, the hardware will clear that that bit and > change the CR3 without flushing the TLB. hvm_set_cr3(), however, was > ignoring this bit; the

Re: [Xen-devel] [PATCH V6] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-03-01 Thread George Dunlap
On 03/01/2018 10:58 AM, Jan Beulich wrote: On 28.02.18 at 11:38, wrote: >> In hardware, when PCID support is enabled and the NOFLUSH bit is set >> when writing a CR3 value, the hardware will clear that that bit and >> change the CR3 without flushing the TLB.

Re: [Xen-devel] [PATCH 4/6] xen/sched: Remove {init, destroy}_domain() interfaces

2018-03-01 Thread Dario Faggioli
On Wed, 2018-02-28 at 14:14 +, Andrew Cooper wrote: > These hooks have one single caller (sched_{init,destroy}_domain() > respectively) and are all identical (when implemented). > > Previous changes have ensured that only real domains reach these > functions, so > ASSERT() that system domains

Re: [Xen-devel] [PATCH v4 06/16] xen/x86: Remove unused override of page_to_mfn/mfn_to_page

2018-03-01 Thread George Dunlap
On 02/21/2018 02:02 PM, Julien Grall wrote: > A few files override page_to_mfn/mfn_to_page but actually never use > those macros. So drop them. > > Signed-off-by: Julien Grall Acked-by: George Dunlap

Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

2018-03-01 Thread Andrew Cooper
On 23/02/18 13:27, Roger Pau Monne wrote: > Add a basic HPET functionality test, note that this test requires the > HPET to support level triggered interrupts. > > Further improvements should add support for interrupt delivery, and > testing all the available timers. > > Signed-off-by: Roger Pau

Re: [Xen-devel] [PATCH] tools/misc: Tweak reserved bit handling for xen-cpuid

2018-03-01 Thread Wei Liu
On Tue, Feb 27, 2018 at 04:28:30PM +, Andrew Cooper wrote: > Instead of printing REZ, use NULL pointers to indicate missing information, > and have dump_leaf() print out the bit which is unknown. > > E.g. > > > Dynamic sets: > Raw >

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 13:29, wrote: > On 01/03/18 09:58, Jan Beulich wrote: >> > @@ -173,11 +175,26 @@ int guest_rdmsr(const struct vcpu *v, uint32_t msr, > > uint64_t *val) > _MSR_MISC_FEATURES_CPUID_FAULTING; > break; >

Re: [Xen-devel] [PATCH 1/2] x86: improve MSR_SHADOW_GS accesses

2018-03-01 Thread Andrew Cooper
On 07/12/17 10:45, Jan Beulich wrote: On 06.12.17 at 20:34, wrote: >> On 06/12/17 16:37, Jan Beulich wrote: >>> @@ -172,6 +173,24 @@ static inline unsigned long rdgsbase(voi >>> return base; >>> } >>> >>> +static inline unsigned long rdgsshadow(void) >>> +{

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-01 Thread Wei Liu
On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: > On 01/03/18 12:22, Wei Liu wrote: > > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > >> XSA-256 forces the local APIC to always be enabled for PVH guests, so > >> ignore any apic option for PVH guests. Update the

Re: [Xen-devel] get_page_from_gfn() for foreign pages

2018-03-01 Thread Paul Durrant
> -Original Message- [snip] > >> And then you didn't really answer my question. > > > > Well, you can't revoke a grant whist a backend has it mapped... that's been > > a limitation forever. Also, I think it's reasonable that granting to a > > domain > > A allows domain A *and* any other

Re: [Xen-devel] [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree

2018-03-01 Thread Boris Ostrovsky
On 03/01/2018 03:46 AM, Paolo Bonzini wrote: > On 01/03/2018 07:11, Juergen Gross wrote: >>> Probably a better place for these would be >>> arch/x86/platform/pvh/{enlighten.c,head.S}. (Just because there are no >>> .c or .S files in arch/x86). >> Right. >> >>> Maybe Xen ought to be moved under

[Xen-devel] [PATCH] vvmx: fixes after CR4 trapping optimizations

2018-03-01 Thread Roger Pau Monne
Commit 406817 doesn't update nested VMX code in order to take into account L1 CR4 host mask when nested guest (L2) writes to CR4, and thus the mask written to CR4_GUEST_HOST_MASK is likely not as restrictive as it should be. Also the VVMCS GUEST_CR4 value should be updated to match the underlying

Re: [Xen-devel] [PATCH v2] tools: drop stale references to curl/xml2-config

2018-03-01 Thread Olaf Hering
Am Thu, 1 Mar 2018 15:32:05 + schrieb Wei Liu : > If you don't object I can replace the commit message. Yes, please. Olaf pgp_rL2Id687A.pgp Description: Digitale Signatur von OpenPGP ___ Xen-devel mailing list

Re: [Xen-devel] [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

2018-03-01 Thread Boris Ostrovsky
On 02/28/2018 01:27 PM, Maran Wilson wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index eb7f43f23521..fa7cd0305125 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -791,6 +791,14 @@ config KVM_GUEST > underlying device model, the host provides the guest with >

Re: [Xen-devel] [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 16:02, Boris Ostrovsky wrote: > On 02/28/2018 01:27 PM, Maran Wilson wrote: >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index eb7f43f23521..fa7cd0305125 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -791,6 +791,14 @@ config KVM_GUEST >>underlying

Re: [Xen-devel] [RFC PATCH v4 6/7] xen/pvh: Add memory map pointer to hvm_start_info struct

2018-03-01 Thread Konrad Rzeszutek Wilk
On Wed, Feb 28, 2018 at 10:28:02AM -0800, Maran Wilson wrote: > The start info structure that is defined as part of the x86/HVM direct boot > ABI and used for starting Xen PVH guests would be more versatile if it also > included a way to pass information about the memory map to the guest. This >

Re: [Xen-devel] [BUG] unable to shutdown (page fault in mwait_idle()/do_dbs_timer()/__find_next_bit()) (fwd)

2018-03-01 Thread Jan Beulich
>>> On 09.01.18 at 23:51, wrote: > Hello. I'm sorry for taking so long to get back to this. > On Tue, 9 Jan 2018, Jan Beulich wrote: > On 08.01.18 at 17:07, wrote: >>> On Mon, 8 Jan 2018, Jan Beulich wrote: >>> On 07.01.18 at 13:34,

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-qemuu-rhel6hvm-intel

2018-03-01 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemuu-rhel6hvm-intel testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

Re: [Xen-devel] get_page_from_gfn() for foreign pages

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 15:49, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 01 March 2018 14:32 >> >>> On 01.03.18 at 15:17, wrote: >> > Yes, it's the PV case I'm hitting, i.e: >> > >> > page =

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-01 Thread Andrew Cooper
On 01/03/18 12:22, Wei Liu wrote: > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: >> XSA-256 forces the local APIC to always be enabled for PVH guests, so >> ignore any apic option for PVH guests. Update the documentation >> accordingly. > I think how I will approach this is to

Re: [Xen-devel] [PATCH v2] tools: drop stale references to curl/xml2-config

2018-03-01 Thread Wei Liu
On Thu, Mar 01, 2018 at 03:26:32PM +0100, Olaf Hering wrote: > Fixes commit 185bb58be3 ("tools: drop libxen") > It would be nice to write something more specific like: Curl and xml2 are not required anymore since commit XXX (xxx) removed their only user. ? If you don't object I can

Re: [Xen-devel] [PATCH 5/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-03-01 Thread Jan Beulich
>>> On 01.03.18 at 15:33, wrote: > What Sameer has been doing for SMMUv3 is following the word we did on > the ARM SMMUv2 driver. The header is a suggestion for consolidating the > macros over the files here. In which case - why isn't the patch introducing this compat

Re: [Xen-devel] [RFC PATCH v4 4/7] xen/pvh: Move Xen specific PVH VM initialization out of common code

2018-03-01 Thread Boris Ostrovsky
On 02/28/2018 01:28 PM, Maran Wilson wrote: > We need to refactor PVH entry code so that support for other hypervisors > like Qemu/KVM can be added more easily. > > This patch moves the small block of code used for initializing Xen PVH > virtual machines into the Xen specific file. This

[Xen-devel] [xen-unstable-smoke test] 120130: tolerable all pass - PUSHED

2018-03-01 Thread osstest service owner
flight 120130 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120130/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH 1/2] sndif: introduce protocol version

2018-03-01 Thread Konrad Rzeszutek Wilk
On Mon, Feb 05, 2018 at 10:24:59AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Protocol version was referenced in the protocol description, > but missed its definition. Fix this by adding a constant > for current protocol version. >

[Xen-devel] [linux-4.9 test] 120091: regressions - FAIL

2018-03-01 Thread osstest service owner
flight 120091 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/120091/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 5 host-ping-check-native fail REGR. vs. 120047 Tests which did not

[Xen-devel] [PATCH] xen/arm: Read the cacheline size from CTR register

2018-03-01 Thread Stefano Stabellini
See the corresponding Linux commit as reference: commit f91e2c3bd427239c198351f44814dd39db91afe0 Author: Catalin Marinas Date: Tue Dec 7 16:52:04 2010 +0100 ARM: 6527/1: Use CTR instead of CCSIDR for the D-cache line size on ARMv7 The current

[Xen-devel] [xen-unstable-smoke test] 120134: tolerable all pass - PUSHED

2018-03-01 Thread osstest service owner
flight 120134 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120134/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [PATCH v3 4/6] xen/arm: set VPIDR based on the MIDR value of the underlying pCPU

2018-03-01 Thread Stefano Stabellini
On big.LITTLE systems not all cores have the same MIDR. Instead of storing only one VPIDR per domain, initialize it to the value of the MIDR of the pCPU where the vCPU will run. This way, assuming that the vCPU has been created with the right pCPU affinity, the guest will be able to read the

[Xen-devel] [PATCH v3 1/6] xen/arm: Park CPUs with a MIDR different from the boot CPU.

2018-03-01 Thread Stefano Stabellini
From: Julien Grall From: Julien Grall Xen does not properly support big.LITTLE platform. All vCPUs of a guest will always have the MIDR of the boot CPU (see arch_domain_create). At best the guest may see unreliable performance (vCPU switching between

[Xen-devel] [PATCH v3 3/6] xen/arm: read ACTLR on the pcpu where the vcpu will run

2018-03-01 Thread Stefano Stabellini
On big.LITTLE systems not all cores have the same ACTLR. Instead of reading ACTLR and setting v->arch.actlr in vcpu_initialise, do it later on the same pcpu where the vcpu will run. This way, assuming that the vcpu has been created with the right pcpu affinity, the guest will be able to read the

[Xen-devel] [PATCH v3 5/6] xen/arm: update the docs about heterogeneous computing

2018-03-01 Thread Stefano Stabellini
Introduce a new document about big.LITTLE and update the documentation of hmp-unsafe. Also update the warning messages to point users to the docs. Signed-off-by: Stefano Stabellini CC: jbeul...@suse.com CC: konrad.w...@oracle.com CC: t...@xen.org CC: wei.l...@citrix.com

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

2018-03-01 Thread Roger Pau Monné
On Thu, Mar 01, 2018 at 04:01:23PM +, Wei Liu wrote: > On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: > > On 01/03/18 12:22, Wei Liu wrote: > > > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > > >> XSA-256 forces the local APIC to always be enabled for PVH

Re: [Xen-devel] [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree

2018-03-01 Thread Maran Wilson
On 2/28/2018 1:35 PM, Paolo Bonzini wrote: On 28/02/2018 22:08, Konrad Rzeszutek Wilk wrote: +obj-$(CONFIG_XEN_PVH) += pvh.o +obj-$(CONFIG_XEN_PVH) += pvh-head.o + Probably a better place for these would be arch/x86/platform/pvh/{enlighten.c,head.S}. (Just because there are no .c or .S files

[Xen-devel] [xen-unstable-smoke test] 120126: regressions - FAIL

2018-03-01 Thread osstest service owner
flight 120126 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120126/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 120107 Tests which

Re: [Xen-devel] Crash with your meltdown patches

2018-03-01 Thread Andrew Cooper
On 01/03/18 18:23, Juergen Gross wrote: > On 01/03/18 18:48, Andrew Cooper wrote: >> On 01/03/18 17:05, Juergen Gross wrote: >>> Jan, >>> >>> I just rebased my patch series for speeding up XPTI to current >>> staging. This included your pending speedup series. I'm now seeing >>> a crash with the

Re: [Xen-devel] [PATCH v2 2/7] x86: remove CR reads from exit-to-guest path

2018-03-01 Thread Andrew Cooper
On 07/02/18 16:12, Jan Beulich wrote: > CR3 is - during normal operation - only ever loaded from v->arch.cr3, > so there's no need to read the actual control register. For CR4 we can > generally use the cached value on all synchronous entry end exit paths. > Drop the write_cr3 macro, as the two

[Xen-devel] [linux-3.18 test] 120090: regressions - FAIL

2018-03-01 Thread osstest service owner
flight 120090 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/120090/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 11 guest-start fail REGR. vs. 120043 Tests which did not

Re: [Xen-devel] [PATCH] Please Welcome Julien, our new Committer

2018-03-01 Thread Andrew Cooper
On 01/03/2018 20:03, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 01, 2018 at 11:17:13AM -0800, Stefano Stabellini wrote: >> In recognition of his expertise and commitment to Xen Project, please >> join me in welcoming Julien among the Committers and REST Maintainers. >> >> Signed-off-by: Stefano

[Xen-devel] [PATCH v3 2/6] xen/arm: make processor a per cpu variable

2018-03-01 Thread Stefano Stabellini
There can be processors of different kinds on a single system. Make processor a per_cpu variable pointing to the right processor type for each core. Suggested-by: Julien Grall Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall

[Xen-devel] [PATCH v3 6/6] xen/arm: disable CPUs with different cacheline sizes

2018-03-01 Thread Stefano Stabellini
Even different cpus in big.LITTLE systems are expected to have the same cacheline size. Unless the minimum of all cacheline sizes is used across all cpu cores, cache coherency protocols can go wrong. Instead, for now, just disable any cpu with a different cacheline size. This check is not covered

[Xen-devel] [PATCH v3 0/6] unsafe big.LITTLE support

2018-03-01 Thread Stefano Stabellini
Hi all, This series changes the initialization of two virtual registers to make sure they match the value of the underlying physical cpu. It also disables cpus different from the boot cpu, unless a newly introduced command line option is specified. In that case, it explains how to setup the

Re: [Xen-devel] [PATCH 2/2] sndif: add explicit back and front synchronization

2018-03-01 Thread Konrad Rzeszutek Wilk
> * +++++ > * | gref_directory | 24 > * +++++ > - * | reserved

Re: [Xen-devel] [PATCH v2 1/7] x86: slightly reduce Meltdown band-aid overhead

2018-03-01 Thread Andrew Cooper
On 08/02/18 09:20, Jan Beulich wrote: On 07.02.18 at 20:35, wrote: >> On 07/02/18 16:12, Jan Beulich wrote: >>> I'm not sure why I didn't do this right away: By avoiding the use of >>> global PTEs in the cloned directmap, there's no need to fiddle with >>> CR4.PGE

Re: [Xen-devel] [PATCH v2 4/7] x86: NOP out most XPTI entry/exit code when it's not in use

2018-03-01 Thread Andrew Cooper
On 07/02/18 16:13, Jan Beulich wrote: > --- a/xen/arch/x86/x86_64/compat/entry.S > +++ b/xen/arch/x86/x86_64/compat/entry.S > @@ -199,7 +199,7 @@ ENTRY(compat_post_handle_exception) > > /* See lstar_enter for entry register state. */ > ENTRY(cstar_enter) > -/* sti could live here when

Re: [Xen-devel] [RFC PATCH v4 4/7] xen/pvh: Move Xen specific PVH VM initialization out of common code

2018-03-01 Thread Maran Wilson
On 3/1/2018 8:05 AM, Boris Ostrovsky wrote: On 02/28/2018 01:28 PM, Maran Wilson wrote: We need to refactor PVH entry code so that support for other hypervisors like Qemu/KVM can be added more easily. This patch moves the small block of code used for initializing Xen PVH virtual machines into

Re: [Xen-devel] [PATCH] public: correct GNTTABOP_set_version comment

2018-03-01 Thread Andrew Cooper
On 28/02/18 08:38, Jan Beulich wrote: > Version changes are allowed any number of times. Simply re-use the > comment XTF has (thanks Andrew). > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___

Re: [Xen-devel] [RFC PATCH v4 6/7] xen/pvh: Add memory map pointer to hvm_start_info struct

2018-03-01 Thread Maran Wilson
On 2/28/2018 11:41 PM, Jan Beulich wrote: Juergen Gross 03/01/18 8:29 AM >>> On 28/02/18 19:28, Maran Wilson wrote: The start info structure that is defined as part of the x86/HVM direct boot ABI and used for starting Xen PVH guests would be more versatile if it also included

[Xen-devel] [PATCH v2] x86/link: Don't merge .init.text and .init.data

2018-03-01 Thread Andrew Cooper
c/s 1308f0170c merged .init.text and .init.data, because EFI might properly write-protect r/o sections. However, that change makes xen-syms unusable for disassembly analysis. In particular, searching for indirect branches as part of the SP2/Spectre mitigation series. As the merging isn't

[Xen-devel] [PULL 29/30] Fix up dangling references to qmp-commands.* in comment and doc

2018-03-01 Thread Eric Blake
From: Markus Armbruster Fix up the reference to qmp-commands.hx in qmp.c. Missed in commit 5032a16d1d. Fix up the reference to qmp-commands.txt in docs/xen-save-devices-state.txt. Missed in commit 4d8bb958fa. Signed-off-by: Markus Armbruster Message-Id:

Re: [Xen-devel] [PATCH] Please Welcome Julien, our new Committer

2018-03-01 Thread Konrad Rzeszutek Wilk
On Thu, Mar 01, 2018 at 11:17:13AM -0800, Stefano Stabellini wrote: > In recognition of his expertise and commitment to Xen Project, please > join me in welcoming Julien among the Committers and REST Maintainers. > > Signed-off-by: Stefano Stabellini Acked-by: Konrad

Re: [Xen-devel] Crash with your meltdown patches

2018-03-01 Thread Andrew Cooper
On 01/03/18 17:05, Juergen Gross wrote: > Jan, > > I just rebased my patch series for speeding up XPTI to current > staging. This included your pending speedup series. I'm now seeing > a crash with the first patch of yours: > > (XEN) Intel VT-d Queued Invalidation enabled. > (XEN) Intel VT-d

  1   2   >