Re: [Xen-devel] Interrupt injection with ISR set on Intel hardware

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 18:06, wrote: > On 29/10/18 16:58, Jan Beulich wrote: > On 29.10.18 at 17:44, wrote: >>> On 29/10/18 16:33, Jan Beulich wrote: >>> On 15.10.18 at 12:30, wrote: > (XEN) [22641] PUSH {sp 0, irq 30, vec 0x21} This is the last push or pop. >

[Xen-devel] [PATCH] x86/paravirt: remove unused _paravirt_ident_32

2018-10-30 Thread Juergen Gross
There is no user of _paravirt_ident_32 left in the tree. Remove it together with the related paravirt_patch_ident_32(). paravirt_patch_ident_64() can be moved inside CONFIG_PARAVIRT_XXL. Signed-off-by: Juergen Gross --- arch/x86/include/asm/paravirt_types.h | 2 -- arch/x86/kernel/paravirt.c

Re: [Xen-devel] Interrupt injection with ISR set on Intel hardware

2018-10-30 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, October 25, 2018 9:58 PM > > >>> On 25.10.18 at 15:02, wrote: > > On 25/10/18 13:51, Jan Beulich wrote: > > On 15.10.18 at 14:06, wrote: > >>> From the debugging, we see that PPR/IRR/ISR appear to retain their > state > >>>

Re: [Xen-devel] [PATCH 2/4] x86/vvmx: Drop the now-obsolete vmx_inst_check_privilege()

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, October 25, 2018 11:39 PM > > Now that nvmx_handle_vmx_insn() performs all VT-x instruction checks, > there is > no need for redundant checking in vmx_inst_check_privilege(). Remove it, > and > take out the vmxon_check

Re: [Xen-devel] [PATCH 1/4] x86/vvmx: Unconditionally initialise vmxon_region_pa during vcpu construction

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, October 25, 2018 11:37 PM > > This is a stopgap solution until the toolstack side of initialisation can be > sorted out, but it does result in the nvmx_vcpu_in_vmx() predicate working > correctly even when nested virt

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vladimir Botka
On Tue, 30 Oct 2018 10:03:22 +0530 Vikram K wrote: > Hello, > We are using Hikey960 with Debian as Dom0 and DomU. This board has only > WiFi interface. We want to create bridge between Dom0 and DomU so that DomU > has internet access. We tried to create bridge using brtcl command, but it > is

Re: [Xen-devel] [PATCH 3/4] x86/vvmx: INVVPID instructions should be handled at by L1

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, October 25, 2018 11:39 PM > > Signed-off-by: Andrew Cooper Acked-by: Kevin Tian ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [GIT PULL] xen: fixes for 4.20-rc1

2018-10-30 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.20a-rc1-tag xen: fixes for 4.20-rc1 It contains only several small fixes and cleanups this time. Thanks. Juergen MAINTAINERS| 1 +

Re: [Xen-devel] [PATCH v1 2/6] x86/vvmx: correct vmfail() usage for vmptrld and vmclear

2018-10-30 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Friday, October 12, 2018 11:28 PM > > Calling vmfail_valid() is correct only if vvmcx is valid. Modify > functions to use vmfail() instead which performs the necessary check. > > Signed-off-by: Sergey Dyasli Acked-by: Kevin Tian .

Re: [Xen-devel] [PATCH v1 3/6] x86/vvmx: add VMX_INSN_VMPTRLD_WITH_VMXON_PTR errno

2018-10-30 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Friday, October 12, 2018 11:28 PM > > And make nvmx_handle_vmptrld() return the new errno in case the > provided > address is the same as vmxon region address. > > While at it, correct the return value for not-4KB-aligned case. > >

Re: [Xen-devel] [PATCH v1] x86/hvm: Clean up may_defer from hvm_* helpers

2018-10-30 Thread Tian, Kevin
> From: Alexandru Stefan ISAILA [mailto:aisa...@bitdefender.com] > Sent: Wednesday, October 24, 2018 5:19 PM > > The may_defer var was left with the older bool_t type. This patch > changes the type to bool. > > Signed-off-by: Alexandru Isaila Reviewed-by: Kevin Tian

Re: [Xen-devel] [PATCH RFC] VMX: fix vmx_handle_eoi()

2018-10-30 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, October 25, 2018 5:46 PM > > >>> On 19.10.18 at 16:30, wrote: > > On Fri, Oct 12, 2018 at 03:32:59AM -0600, Jan Beulich wrote: > >>In commit 303066fdb1e ("VMX: fix interaction of APIC-V and Viridian > >>emulation") I screwed up

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Juergen Gross
On 29/10/2018 19:31, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP: blkif_free_ring+33] > RIP:

[Xen-devel] [linux-next test] 129127: tolerable FAIL

2018-10-30 Thread osstest service owner
flight 129127 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/129127/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail like 129105

Re: [Xen-devel] [PATCH 4/4] x86/vvmx: Don't handle unknown nested vmexit reasons at L0

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, October 25, 2018 11:39 PM > > This is very dangerous from a security point of view, because a missing > entry > will cause L2's action to be interpreted as L1's action. > > Signed-off-by: Andrew Cooper Acked-by: Kevin

[Xen-devel] [ovmf test] 129171: all pass - PUSHED

2018-10-30 Thread osstest service owner
flight 129171 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129171/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4222e8e7e421e9c8d2c2f319a3860dd3332d6255 baseline version: ovmf

Re: [Xen-devel] [PATCH v2] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM

2018-10-30 Thread Juergen Gross
On 30/10/2018 00:28, Stefano Stabellini wrote: > On Fri, 26 Oct 2018, Julien Grall wrote: >> Hi Stefano, >> >> On 10/26/18 7:04 PM, Stefano Stabellini wrote: >>> From: Stefano Stabellini >>> >>> xen_create_contiguous_region has now only an implementation if >>> CONFIG_XEN_PV is defined. However,

Re: [Xen-devel] [PATCH v2 5/5] x86: Reorganise and rename debug register fields in struct vcpu

2018-10-30 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Monday, October 15, 2018 6:36 PM > > Reusing debugreg[5] for the PV emulated IO breakpoint information is > confusing > to read. Instead, introduce a dr7_emul field in pv_vcpu for the pupose. > > With the PV emulation out of the

Re: [Xen-devel] [PATCH v1 4/6] x86/vvmx: add VMX_INSN_VMCLEAR_WITH_VMXON_PTR errno

2018-10-30 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Friday, October 12, 2018 11:28 PM > > And make nvmx_handle_vmclear() return the new errno in case the > provided > address is the same as vmxon region address. > > While at it, correct the return value for not-4KB-aligned case and

[Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Christian Lindig
The type of Xsraw.sync is made more precise: from val sync : (Xenbus.Xb.t -> 'a) -> con -> string to val sync : (Xenbus.Xb.t -> unit) -> con -> string The first argument is enforced to return unit rather than a value that is not used anyway. Signed-off-by: Christian Lindig ---

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vladimir Botka
> On Tue, Oct 30, 2018 at 12:39 PM Vladimir Botka wrote: > > On Tue, 30 Oct 2018 10:03:22 +0530 > > Vikram K wrote: > > > Hello, > > > We are using Hikey960 with Debian as Dom0 and DomU. This board has only > > > WiFi interface. We want to create bridge between Dom0 and DomU so that > > > DomU

Re: [Xen-devel] [PATCH v5 22/25] xen/arm: Allow vpl011 to be used by DomU

2018-10-30 Thread Oleksandr Tyshchenko
On Mon, Oct 29, 2018 at 10:03 PM Stefano Stabellini wrote: > > On Wed, 24 Oct 2018, Oleksandr Tyshchenko wrote: > > Hi, Stefano > > > > On Tue, Oct 23, 2018 at 5:04 AM Stefano Stabellini > > wrote: > > > > > > Make vpl011 being able to be used without a userspace component in Dom0. > > > In that

[Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Alexandru Stefan ISAILA
This patch adds a couple of regs to the vm_event that are used by the introspection. The base, limit and ar bits are compressed into a uint64_t union so as not to enlarge the vm_event. Signed-off-by: Alexandru Isaila --- Changes since V4: - Change the comment into one line -

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 11:31:56AM -0700, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP:

[Xen-devel] [OSSTEST PATCH] production-config-cambridge: Use squid cache, not local apt proxy

2018-10-30 Thread Ian Jackson
debian.uk.xensource.com is no more (and the service name seems to have been discarded). There is repo.citrite.net instead but it is a proprietary appliance which - although it claims to be able to handle apt repositories - is not compatible with debian-installer; at least, jessie's d-i. Swap to

Re: [Xen-devel] [PATCH v2 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 08:19:20AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 17:20, wrote: > > --- a/xen/arch/x86/hvm/svm/svm.c > > +++ b/xen/arch/x86/hvm/svm/svm.c > > @@ -1272,6 +1272,24 @@ void svm_host_osvw_init() > > spin_unlock(_lock); > > } > > > > +static int

Re: [Xen-devel] [RFC 07/16] xen/arm: p2m: Introduce p2m_is_valid and use it

2018-10-30 Thread Julien Grall
Hi, On 30/10/2018 00:21, Stefano Stabellini wrote: On Mon, 8 Oct 2018, Julien Grall wrote: The LPAE format allows to store information in an entry even with the valid bit unset. In a follow-up patch, we will take advantage of this feature to re-purpose the valid bit for generating a

Re: [Xen-devel] [PATCH v2 2/7] x86/hvm: introduce a define for the debug output IO port

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 10:51:07AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 17:20, wrote: > > No functional change intended. > > > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > with one remark: > > > --- a/xen/include/public/arch-x86/xen.h > > +++

Re: [Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 13:26, wrote: > On 10/30/18 1:33 PM, Jan Beulich wrote: > On 30.10.18 at 11:07, wrote: >>> --- a/xen/include/public/vm_event.h >>> +++ b/xen/include/public/vm_event.h >>> @@ -29,7 +29,7 @@ >>> >>> #include "xen.h" >>> >>> -#define VM_EVENT_INTERFACE_VERSION 0x0003

Re: [Xen-devel] [PATCH v1 1/6] x86/vvmx: introduce vvmcx_valid()

2018-10-30 Thread Sergey Dyasli
On 30/10/2018 07:41, Tian, Kevin wrote: >> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] >> Sent: Friday, October 12, 2018 11:28 PM >> >> As a convenient helper function and refactor the code to use it. >> >> No functional change. >> >> Signed-off-by: Sergey Dyasli > > since vmcx is hvm

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Joe Jin
On 10/30/18 7:21 AM, Paul Durrant wrote: >> -Original Message- >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Joe Jin >> Sent: 30 October 2018 14:13 >> To: Paul Durrant ; Boris Ostrovsky >> ; Konrad Rzeszutek Wilk >> >> Cc: John Sobecki ; DONGLI.ZHANG

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vladimir Botka
> > > > > Hello, > > > > > We are using Hikey960 with Debian as Dom0 and DomU. This board has > > > > > only WiFi interface. We want to create bridge between Dom0 and DomU > > > > > so that DomU has internet access. We tried to create bridge using > > > > > brtcl > > > > > command, but it is not

Re: [Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Razvan Cojocaru
On 10/30/18 1:33 PM, Jan Beulich wrote: On 30.10.18 at 11:07, wrote: >> --- a/xen/include/public/vm_event.h >> +++ b/xen/include/public/vm_event.h >> @@ -29,7 +29,7 @@ >> >> #include "xen.h" >> >> -#define VM_EVENT_INTERFACE_VERSION 0x0003 >> +#define VM_EVENT_INTERFACE_VERSION

Re: [Xen-devel] dom0/pvh: Dom0 PVH with PCI passthrough support status

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 01:32:38PM +0200, Alexandru Vasile wrote: > Hello, > > > > There is some low-hanging fruit, both in Xen and the Linux kernel, > > which can really be worked in parallel by different parties, so let me > > know if you have some capacity and we can speak about sharing the >

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Joe Jin
On 10/30/18 1:59 AM, Paul Durrant wrote: >> On 10/25/18 11:56 AM, Joe Jin wrote: >>> I just discussed this patch with Boris in private, his opinions(Boris, >>> please correct me if any misunderstood) are: >>> >>> 1. With/without the check, both are incorrect, he thought we need to >>>prevented

Re: [Xen-devel] [Xen-users] [XEN][ARM] WiFi bridge creation

2018-10-30 Thread Vikram K
Thanks Vladimir. Can some one provide pointer/reference on how to use NAT to share WiFi between Dom0 and DomU. Followed the instruction provided in the below link, but no success. https://wiki.debian.org/BridgeNetworkConnections#Bridging_with_a_wireless_NIC On Tue, Oct 30, 2018 at 4:04 PM

[Xen-devel] [ovmf baseline-only test] 75546: regressions - FAIL

2018-10-30 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75546 ovmf real [real] http://osstest.xensource.com/osstest/logs/75546/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail

[Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Jan Beulich
There's no guarantee that e.g. a switch() control expression's memory operand(s) get(s) read just once. Guard against the compiler producing "unexpected" code by sprinkling around some ACCESS_ONCE(). I'm leaving alone opt_conswitch[]: It gets accessed in quite a few places anyway, and an

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 01:29:28PM +, Paul Durrant wrote: > The P2M code currently contains many loops to deal with the fact that, > while it may be require to handle page orders greater than 4k, the > IOMMU map and unmap functions do not. > This patch adds a page_order parameter to those

[Xen-devel] [distros-debian-snapshot test] 75544: trouble: broken/fail/pass

2018-10-30 Thread Platform Team regression test user
flight 75544 distros-debian-snapshot real [real] http://osstest.xensource.com/osstest/logs/75544/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-current-netinst-pygrubbroken Tests

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Joe Jin > Sent: 30 October 2018 14:48 > To: Paul Durrant ; Boris Ostrovsky > ; Konrad Rzeszutek Wilk > > Cc: John Sobecki ; DONGLI.ZHANG > ; linux-ker...@vger.kernel.org"

Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Andrew Cooper
On 30/10/18 14:44, Jan Beulich wrote: > There's no guarantee that e.g. a switch() control expression's memory > operand(s) get(s) read just once. Guard against the compiler producing > "unexpected" code by sprinkling around some ACCESS_ONCE(). > > I'm leaving alone opt_conswitch[]: It gets

Re: [Xen-devel] [PATCH v5] arch/x86: Add registers to vm_event

2018-10-30 Thread Tamas K Lengyel
On Tue, Oct 30, 2018 at 7:19 AM Jan Beulich wrote: > > >>> On 30.10.18 at 13:26, wrote: > > On 10/30/18 1:33 PM, Jan Beulich wrote: > > On 30.10.18 at 11:07, wrote: > >>> --- a/xen/include/public/vm_event.h > >>> +++ b/xen/include/public/vm_event.h > >>> @@ -29,7 +29,7 @@ > >>> > >>>

Re: [Xen-devel] [PATCH v8 6/8] docs: documentation about static shared memory regions

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 6/8] docs: documentation about static shared memory regions"): > Author: Zhongze Liu > > Add docs to document the motivation, usage, use cases and other > relevant information about the static shared memory feature. > > This is for the proposal "Allow

Re: [Xen-devel] [PATCH v5 08/25] xen/arm: probe domU kernels and initrds

2018-10-30 Thread Julien Grall
Hi Stefano, On 23/10/2018 03:02, Stefano Stabellini wrote: Find addresses, sizes on device tree from kernel_probe. Find the cmdline from the bootcmdlines array. Introduce a new boot_module_find_by_addr_and_kind function to match not just on boot module kind, but also by address so that we can

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-30 Thread Juergen Gross
On 30/10/2018 12:23, Roger Pau Monné wrote: > On Mon, Oct 29, 2018 at 03:19:34PM +0100, Juergen Gross wrote: >> On 29/10/2018 13:57, Roger Pau Monné wrote: >>> On Fri, Oct 19, 2018 at 06:39:50PM +0200, Juergen Gross wrote: On 19/10/2018 18:10, Roger Pau Monné wrote: > On Tue, Oct 09, 2018

Re: [Xen-devel] [PATCH v5 11/25] xen/arm: introduce allocate_memory

2018-10-30 Thread Julien Grall
Hi, On 23/10/2018 03:02, Stefano Stabellini wrote: Introduce an allocate_memory function able to allocate memory for DomUs and map it at the right guest addresses, according to the guest memory map: GUEST_RAM0_BASE and GUEST_RAM1_BASE. This is under #if 0 as not used for now. Signed-off-by:

Re: [Xen-devel] [PATCH v1 5/6] x86/vvmx: correctly report vvmcs size

2018-10-30 Thread Sergey Dyasli
On 30/10/2018 08:06, Tian, Kevin wrote: >> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] >> Sent: Friday, October 12, 2018 11:28 PM >> >> The size of Xen's virtual vmcs region is 4096 bytes. Correctly report >> it to the guest in case when VMCS shadowing is not available instead of >>

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Joe Jin > Sent: 30 October 2018 14:13 > To: Paul Durrant ; Boris Ostrovsky > ; Konrad Rzeszutek Wilk > > Cc: John Sobecki ; DONGLI.ZHANG > ; linux-ker...@vger.kernel.org"

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 16:46, wrote: > On Tue, Oct 30, 2018 at 09:40:17AM -0600, Jan Beulich wrote: >> >>> On 30.10.18 at 16:32, wrote: >> > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: >> >> >>> On 22.10.18 at 14:58, wrote: >> >> > --- a/xen/common/efi/boot.c >> >> > +++

Re: [Xen-devel] [PATCH V3 1/3] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-10-30 Thread Razvan Cojocaru
On 10/30/18 6:14 PM, Jan Beulich wrote: On 29.10.18 at 13:40, wrote: >> This patch is a pre-requisite for fixing the logdirty VGA issue >> (display freezes when switching to a new altp2m view early in a >> domain's lifetime), but sent separately for easier review. >> The new

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 17:32, wrote: > On 10/30/18 6:22 PM, Jan Beulich wrote: > On 29.10.18 at 13:40, wrote: >>> This patch is a pre-requisite for the one fixing VGA logdirty >>> freezes when using altp2m. It only concerns itself with the >>> ranges allocation / deallocation / initialization

Re: [Xen-devel] [PATCH v2] arm, smmu: backport "Disable stalling faults for all endpoints"

2018-10-30 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Jan Beulich wrote: > >>> On 29.10.18 at 22:14, wrote: > > From: Stefano Stabellini > > > > Backport commit 3714ce1d6655098ee69ede632883e5874d67e4ab > > "iommu/arm-smmu: Disable stalling faults for all endpoints" from the > > Linux kernel. This works-around Erratum #842869.

Re: [Xen-devel] [PATCH v8 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 2/8] libxl: introduce a new structure to represent static shared memory regions"): > From: Zhongze Liu > > Author: Zhongze Liu > > Add a new structure to the IDL family to represent static shared memory > regions > as proposed in the proposal "Allow

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Wei Liu
On Mon, Oct 22, 2018 at 01:58:02PM +0100, Andrew Cooper wrote: > With almost all users of keyhandler_scratch gone, clean up the 3 remaining > users and drop the buffer. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 16:32, wrote: > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: >> >>> On 22.10.18 at 14:58, wrote: >> > --- a/xen/common/efi/boot.c >> > +++ b/xen/common/efi/boot.c >> > @@ -487,6 +487,7 @@ static EFI_FILE_HANDLE __init >> > get_parent_handle(EFI_LOADED_IMAGE

Re: [Xen-devel] [PATCH v8 4/8] libxl: support unmapping static shared memory areas during domain destruction

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 4/8] libxl: support unmapping static shared memory areas during domain destruction"): > Add libxl__sshm_del to unmap static shared memory areas mapped by > libxl__sshm_add during domain creation. The unmapping process is: This whole part should be in a

Re: [Xen-devel] [PATCH V3 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 13:40, wrote: > @@ -316,6 +339,22 @@ void p2m_memory_type_changed(struct domain *d) > } > } > > +void p2m_memory_type_changed(struct domain *d) > +{ > +_memory_type_changed(p2m_get_hostp2m(d)); > + > +#ifdef CONFIG_HVM > +if ( unlikely(altp2m_active(d)) ) > +

Re: [Xen-devel] [PATCH 2/8] viridian: remove MSR perf counters

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:05PM +, Paul Durrant wrote: > They're not really useful so maintaining them is pointless. > > Signed-off-by: Paul Durrant If you think they are not helpful: Reviewed-by: Roger Pau Monné Thanks, Roger. ___

Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 10:28:21AM -0600, Jan Beulich wrote: > >>> On 30.10.18 at 17:23, wrote: > > On Tue, Oct 30, 2018 at 08:44:20AM -0600, Jan Beulich wrote: > >> There's no guarantee that e.g. a switch() control expression's memory > >> operand(s) get(s) read just once. Guard against the

Re: [Xen-devel] [PATCH 3/8] viridian: remove comments referencing section number in the spec.

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:06PM +, Paul Durrant wrote: > Microsoft has a habit of re-numbering sections in the spec. so avoid > referring to section numbers in comments. Also remove the URL for the > spec. from the boilerplate... Again, Microsoft has a habit of changing > these too. > >

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Christian Lindig
> On 30 Oct 2018, at 16:50, Ian Jackson wrote: > > I'm not much of an ocaml programmer but this seems like it has no > overall functional change ? > > I take it that ignore is the trivial function with type ('a -> unit). That is correct. Except that types now reflect more accurately what is

Re: [Xen-devel] [PATCH 5/8] viridian: separate interrupt related enlightenment implementations...

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:08PM +, Paul Durrant wrote: > ...into new 'synic' module. > > The SynIC (synthetic interrupt controller) is specified [1] to be a super- > set of a virtualized LAPIC, and its definition encompasses all > enlightenments related to virtual interrupt control. > >

Re: [Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Juergen Gross
On 30/10/2018 17:49, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP: blkif_free_ring+33] > RIP:

Re: [Xen-devel] [PATCH v8 3/8] libxl: support mapping static shared memory areas during domain creation

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 3/8] libxl: support mapping static shared memory areas during domain creation"): > +_hidden > +bool libxl__arch_domain_support_sshm(const libxl_domain_build_info *b_info); > + > +_hidden > +int libxl__arch_domain_sshm_cachepolicy_setdefault(libxl_static_shm

Re: [Xen-devel] [PATCH 4/8] viridian: remove duplicate union types

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:07PM +, Paul Durrant wrote: > The 'viridian_vp_assist', 'viridian_hypercall_gpa' and > 'viridian_reference_tsc' union types are identical in layout. The layout > is also common throughout the specification [1]. > > This patch declares a common 'viridian_page_msr'

Re: [Xen-devel] [PATCH v2] libxencall: Improve linux syscall error messages

2018-10-30 Thread Wei Liu
On Mon, Oct 15, 2018 at 03:32:05PM +0100, Ian Jackson wrote: > Make the bufdev and non-bufdev messages distinct, and always print the > non-constant argument (ie, the size). > > This assists diagnosis. > > CC: Andrew Cooper > CC: Hans van Kranenburg Acked-by: Wei Liu

Re: [Xen-devel] [PATCH] libxl: libxl__ev_fd_callback: Document perhaps-no-retry semantics

2018-10-30 Thread Wei Liu
On Mon, Oct 15, 2018 at 03:01:07PM +0100, Ian Jackson wrote: > Signed-off-by: Ian Jackson > CC: Anthony PERARD I think you understand the event machinery more than I do, so feel free to apply this patch. Wei. ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper"): > You are right - close_handle should set the handle to None in addition. > > > For that matter, why is close_handle needed at all ? > > I mostly added it for symmetry and it is needed

Re: [Xen-devel] [PATCH] libxencall: Make bufdev/nobufdev mmap error messages distinct

2018-10-30 Thread Wei Liu
On Mon, Oct 15, 2018 at 03:24:11PM +0100, Ian Jackson wrote: > This assists diagnosis. Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/8] viridian: remove comments referencing section number in the spec.

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 16:34 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Jan Beulich > > Subject: Re: [Xen-devel] [PATCH 3/8] viridian: remove comments referencing > section number in the spec. > > On

Re: [Xen-devel] [PATCH 5/8] viridian: separate interrupt related enlightenment implementations...

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 16:52 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Jan Beulich > > Subject: Re: [Xen-devel] [PATCH 5/8] viridian: separate interrupt related > enlightenment implementations... >

Re: [Xen-devel] [PATCH V2] Release: add release note link to SUPPORT.md

2018-10-30 Thread Wei Liu
On Fri, Oct 26, 2018 at 03:13:44PM +0200, Juergen Gross wrote: > In order to have a link to the release notes in the feature list > generated from SUPPORT.md add that link in the "Release Support" > section of that file. > > The real link needs to be adapted when the version is being released. >

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 09:40:17AM -0600, Jan Beulich wrote: > >>> On 30.10.18 at 16:32, wrote: > > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: > >> >>> On 22.10.18 at 14:58, wrote: > >> > --- a/xen/common/efi/boot.c > >> > +++ b/xen/common/efi/boot.c > >> > @@ -487,6 +487,7 @@

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 17:13, wrote: > New document-cum-checklist, for helping with hardware procurement. > > Signed-off-by: Ian Jackson I don't think any acks should be needed here, but if so: Acked-by: Jan Beulich Jan ___ Xen-devel mailing list

[Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in error path. Typical call stack involving panic - #8 page_fault at 8175936f [exception RIP: blkif_free_ring+33] RIP: a0149491 RSP: 8804f7673c08 RFLAGS: 00010292

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("[Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper"): > Commit 81946a73dc975a7dafe9017a8e61d1e64fdbedbf removed > Xenctrl.with_intf based on its undesirable behaviour of opening and > closing a Xenctrl connection with every invocation. This

Re: [Xen-devel] [PATCH V3 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 10:25:20AM -0600, Jan Beulich wrote: > >>> On 29.10.18 at 13:40, wrote: > > @@ -316,6 +339,22 @@ void p2m_memory_type_changed(struct domain *d) > > } > > } > > > > +void p2m_memory_type_changed(struct domain *d) > > +{ > > +

Re: [Xen-devel] [PATCH] libxl: libxl__ev_fd_callback: Document perhaps-no-retry semantics

2018-10-30 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: libxl__ev_fd_callback: Document perhaps-no-retry semantics"): > On Mon, Oct 15, 2018 at 03:01:07PM +0100, Ian Jackson wrote: > > Signed-off-by: Ian Jackson > > CC: Anthony PERARD > > I think you understand the event machinery more than I do, so feel free >

Re: [Xen-devel] [PATCH] docs: remove ChangeLog file

2018-10-30 Thread Wei Liu
On Fri, Oct 26, 2018 at 12:38:06PM +0200, Juergen Gross wrote: > docs/ChangeLog has been updated for Xen 3.3 last time. It seems to be > interesting for archaeologists only today. > > Remove it. > > Signed-off-by: Juergen Gross I wouldn't mind removing it. Nowadays I mostly use git to do

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 October 2018 17:05 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap ; Ian > Jackson ; Wei Liu ; Jun > Nakajima ; Kevin Tian ; > Stefano Stabellini ; xen-devel

Re: [Xen-devel] [PULL v2 00/20] Qemu trivial for 3.1 patches

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:23, Laurent Vivier wrote: > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > > are available in the Git repository

[Xen-devel] [PATCH v3 5/7] vpci: fix execution of long running operations

2018-10-30 Thread Roger Pau Monne
BAR map/unmap is a long running operation that needs to be preempted in order to avoid overrunning the assigned vCPU time (or even triggering the watchdog). Current logic for this preemption is wrong, and won't work at all for AMD since only Intel makes use of hvm_io_pending (and even in that

[Xen-devel] [PATCH v3 2/7] x86/hvm: introduce a define for the debug output IO port

2018-10-30 Thread Roger Pau Monne
No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu Cc: George Dunlap Cc: Ian Jackson Cc: Julien Grall Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan --- xen/arch/x86/hvm/hvm.c

[Xen-devel] [PATCH v3 0/7] x86/pvh: fix fixes for PVH Dom0

2018-10-30 Thread Roger Pau Monne
Hello, The following series contain miscellaneous fixes for a PVH Dom0. I've found out this issues while trying to boot on an AMD EPYC box. The series can be found on my git repo: git://xenbits.xen.org/people/royger/xen.git fixes-pvh-v3 Roger Pau Monne (7): x86/pvh: fix TSC mode setup for

[Xen-devel] [PATCH v3 1/7] x86/pvh: fix TSC mode setup for PVH Dom0

2018-10-30 Thread Roger Pau Monne
A PVH Dom0 might use TSC scaling or other HVM specific TSC adjustments, so only short-circuit the TSC setup for a classic PV Dom0. Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xen/arch/x86/time.c | 2 +- 1 file changed, 1

[Xen-devel] [PATCH v3 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

2018-10-30 Thread Roger Pau Monne
PV Dom0 has a quirk for some AMD processors, where enabling ACPI can also enable C1E mode. Apply the same workaround as done on PV for a PVH Dom0, which consist on trapping accesses to the SMI command IO port and disabling C1E if ACPI is enabled. Reported-by: Jan Beulich Signed-off-by: Roger Pau

[Xen-devel] [PATCH v3 4/7] vpci: fix updating the command register

2018-10-30 Thread Roger Pau Monne
When switching the memory decoding bit in the command register the rest of the changes where dropped, leading to only the memory decoding bit being updated. Fix this by unconditionally writing the guest-requested command except for the memory decoding bit, which will be updated once the p2m

[Xen-devel] [PATCH v3 6/7] vpci/msix: carve p2m hole for MSIX MMIO regions

2018-10-30 Thread Roger Pau Monne
Make sure the MSIX MMIO regions don't have p2m entries setup, so that accesses to them trap into the hypervisor and can be handled by vpci. This is a side-effect of commit 042678762 for PVH Dom0, which added mappings for all the reserved regions into the Dom0 p2m. Signed-off-by: Roger Pau Monné

Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 08:44:20AM -0600, Jan Beulich wrote: > There's no guarantee that e.g. a switch() control expression's memory > operand(s) get(s) read just once. Guard against the compiler producing > "unexpected" code by sprinkling around some ACCESS_ONCE(). > > I'm leaving alone

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 13:40, wrote: > This patch is a pre-requisite for the one fixing VGA logdirty > freezes when using altp2m. It only concerns itself with the > ranges allocation / deallocation / initialization part. But while looking (briefly only for now) over patch 3 I couldn't see any

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Razvan Cojocaru
On 10/30/18 6:22 PM, Jan Beulich wrote: On 29.10.18 at 13:40, wrote: >> This patch is a pre-requisite for the one fixing VGA logdirty >> freezes when using altp2m. It only concerns itself with the >> ranges allocation / deallocation / initialization part. > > But while looking (briefly only

Re: [Xen-devel] [PATCH v5 13/25] xen/arm: move unregister_init_virtual_region to init_done

2018-10-30 Thread Julien Grall
Hi Stefano, On 23/10/2018 03:02, Stefano Stabellini wrote: Move unregister_init_virtual_region to init_done. Follow the same path as x86. It is also useful to move it later so that create_domUs can be called before that in following patches. Signed-off-by: Stefano Stabellini Reviewed-by:

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 October 2018 16:08 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap ; Wei > Liu ; Ian Jackson ; Jun > Nakajima ; Kevin Tian ; > Stefano Stabellini ; xen-devel

Re: [Xen-devel] [PATCH 8/8] viridian: introduce struct viridian_page

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 17:18 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Wei Liu ; Ian > Jackson ; Jan Beulich ; Andrew > Cooper > Subject: Re: [Xen-devel] [PATCH 8/8] viridian: introduce struct > viridian_page > > On Mon, Oct

Re: [Xen-devel] [PATCH RESEND qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time

2018-10-30 Thread Pasi Kärkkäinen
On Mon, Oct 29, 2018 at 08:55:09PM +, Paraschiv, Andra-Irina wrote: > > > On Mon, Oct 29, 2018 at 04:58:22PM +0200, Pasi Kärkkäinen wrote: > > Hi, > > > > On Wed, Oct 24, 2018 at 04:20:35PM +0100, Ian Jackson wrote: > > > Andra Paraschiv writes ("[PATCH RESEND qemu-xen-traditional] xen/pt:

[Xen-devel] [ovmf test] 129191: all pass - PUSHED

2018-10-30 Thread osstest service owner
flight 129191 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129191/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a0f01e8a22e15000e564f09e82eae13d7127be3c baseline version: ovmf

Re: [Xen-devel] [PATCH v2 03/16] x86: make traps.c build with !CONFIG_PV

2018-10-30 Thread Wei Liu
On Fri, Oct 26, 2018 at 10:02:19AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 16:28, wrote: > > @@ -1337,8 +1339,15 @@ static int fixup_page_fault(unsigned long addr, > > struct cpu_user_regs *regs) > > { > > if ( !(regs->error_code & (PFEC_user_mode | PFEC_reserved_bit)) && >

[Xen-devel] [PATCH v6] arch/x86: Add registers to vm_event

2018-10-30 Thread Alexandru Stefan ISAILA
This patch adds a couple of regs to the vm_event that are used by the introspection. The base, limit and ar bits are compressed into a uint64_t union so as not to enlarge the vm_event. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V5: - Rename

[Xen-devel] [OSSTEST PATCH] README.hardware-acquisition

2018-10-30 Thread Ian Jackson
New document-cum-checklist, for helping with hardware procurement. Signed-off-by: Ian Jackson CC: in...@xenproject.org --- README.hardware-acquisition | 310 1 file changed, 310 insertions(+) create mode 100644 README.hardware-acquisition diff

  1   2   >