[PATCH mini-os] console: add newline at EOF

2020-05-18 Thread Jan Beulich
Some gcc versions get pretty unhappy without. Signed-off-by: Jan Beulich --- a/console/console.c +++ b/console/console.c @@ -174,4 +174,4 @@ void resume_console(void) { xencons_ring_resume(xen_console); console_initialised = 1; -} \ No newline at end of file +}

RE: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of Manuel > Bouyer > Sent: 17 May 2020 18:56 > To: Andrew Cooper > Cc: xen-devel@lists.xenproject.org > Subject: Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0 > > On Sun, May 17, 2020 at 07:32:59PM +0200, Manuel Bouyer wrote: > > I've been

Patch "x86/paravirt: Remove the unused irq_enable_sysexit pv op" has been added to the 4.4-stable tree

2020-05-18 Thread gregkh
This is a note to let you know that I've just added the patch titled x86/paravirt: Remove the unused irq_enable_sysexit pv op to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH mini-os] console: add newline at EOF

2020-05-18 Thread Samuel Thibault
Jan Beulich, le lun. 18 mai 2020 09:09:14 +0200, a ecrit: > Some gcc versions get pretty unhappy without. > > Signed-off-by: Jan Beulich That was an easy one :) Reviewed-by: Samuel Thibault > > --- a/console/console.c > +++ b/console/console.c > @@ -174,4 +174,4 @@ void resume_console(void)

[libvirt test] 150228: regressions - FAIL

2020-05-18 Thread osstest service owner
flight 150228 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/150228/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

Re: [PATCH] optee: immediately free buffers that are released by OP-TEE

2020-05-18 Thread Julien Grall
On 18/05/2020 03:04, Volodymyr Babchuk wrote: Hi Julien, Hi, On Mon, 2020-05-11 at 10:34 +0100, Julien Grall wrote: Hi Volodymyr, On 06/05/2020 02:44, Volodymyr Babchuk wrote: Normal World can share buffer with OP-TEE for two reasons: 1. Some client application wants to exchange data

Re: [PATCH] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Jürgen Groß
On 18.05.20 10:24, Denis Kirjanov wrote: The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. For Linux the offset value is going to be passed via xenstore. Why? I can only see disadvantages

[linux-linus test] 150226: regressions - FAIL

2020-05-18 Thread osstest service owner
flight 150226 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150226/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt 7 xen-boot fail REGR. vs. 150225 Regressions which

[PATCH] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. For Linux the offset value is going to be passed via xenstore. Signed-off-by: Denis Kirjanov --- xen/include/public/io/netif.h | 7 ++-

Re: use of "stat -"

2020-05-18 Thread Jan Beulich
On 14.05.2020 13:02, Ian Jackson wrote: > I've read this thread. Jan, I'm sorry that this causes you > inconvenience. I'm hoping it won't come down to a choice between > supporting people who want to ship a dom0 without perl, and people who > want a dom0 using more-than-a-decade-old coreutils. >

RE: [PATCH] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Paul Durrant
> -Original Message- > From: Jürgen Groß > Sent: 18 May 2020 11:28 > To: Denis Kirjanov > Cc: xen-devel@lists.xenproject.org; p...@xen.org > Subject: Re: [PATCH] public/io/netif.h: add a new extra type for XDP > > On 18.05.20 11:52, Denis Kirjanov wrote: > > On 5/18/20, Jürgen Groß

Re: [PATCH] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Jürgen Groß
On 18.05.20 12:37, Denis Kirjanov wrote: On 5/18/20, Jürgen Groß wrote: On 18.05.20 11:52, Denis Kirjanov wrote: On 5/18/20, Jürgen Groß wrote: On 18.05.20 10:24, Denis Kirjanov wrote: The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side

Re: [XEN PATCH v2] xen/build: use the correct kconfig makefile

2020-05-18 Thread Anthony PERARD
On Fri, May 15, 2020 at 02:25:09PM -0400, Stewart Hildebrand wrote: > This resolves the following observed error during config merge: > > /bin/sh /path/to/xen/xen/../xen/tools/kconfig/merge_config.sh -m .config > /path/to/xen/xen/../xen/arch/arm/configs/custom.config > Using .config as base >

[PATCH v2] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. For Linux the offset value is going to be passed via xenstore. Signed-off-by: Denis Kirjanov v2: - added documentation - fixed padding for

Re: [PATCH] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Denis Kirjanov
On 5/18/20, Jürgen Groß wrote: > On 18.05.20 10:24, Denis Kirjanov wrote: >> The patch adds a new extra type to be able to diffirentiate >> between RX responses on xen-netfront side with the adjusted offset >> required for XDP processing. >> >> For Linux the offset value is going to be passed via

Re: [PATCH] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Jürgen Groß
On 18.05.20 11:52, Denis Kirjanov wrote: On 5/18/20, Jürgen Groß wrote: On 18.05.20 10:24, Denis Kirjanov wrote: The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. For Linux the offset

Re: [PATCH mini-os] console: add newline at EOF

2020-05-18 Thread Wei Liu
On Mon, May 18, 2020 at 09:53:00AM +0200, Samuel Thibault wrote: > Jan Beulich, le lun. 18 mai 2020 09:09:14 +0200, a ecrit: > > Some gcc versions get pretty unhappy without. > > > > Signed-off-by: Jan Beulich > > That was an easy one :) > > Reviewed-by: Samuel Thibault Applied.

Re: [PATCH] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Denis Kirjanov
On 5/18/20, Jürgen Groß wrote: > On 18.05.20 11:52, Denis Kirjanov wrote: >> On 5/18/20, Jürgen Groß wrote: >>> On 18.05.20 10:24, Denis Kirjanov wrote: The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset

Re: [PATCH] x86/hvm: Fix memory leaks in hvm_copy_context_and_params()

2020-05-18 Thread Jan Beulich
On 16.05.2020 14:22, Andrew Cooper wrote: > Any error from hvm_save() or hvm_set_param() leaks the c.data allocation. > > Spotted by Coverity. > > Fixes: 353744830 "x86/hvm: introduce hvm_copy_context_and_params" > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [PATCH] x86/hvm: Fix shifting in stdvga_mem_read()

2020-05-18 Thread Jan Beulich
On 16.05.2020 21:02, Andrew Cooper wrote: > stdvga_mem_read() has a return type of uint8_t, which promotes to int rather > than unsigned int. Shifting by 24 may hit the sign bit. > > Spotted by Coverity. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

[PATCH for-4.14 2/3] xen/arm: Take into account the DMA width when allocating Dom0 memory banks

2020-05-18 Thread Julien Grall
From: Julien Grall At the moment, Xen is assuming that all the devices are at least 32-bit DMA capable. However, some SoCs have devices that may be able to access a much restricted range. For instance, the Raspberry PI 4 has devices that can only access the first GB of RAM. The function

[PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

2020-05-18 Thread Julien Grall
From: Julien Grall Hi all, At the moment, a user who wants to boot Xen on the Raspberry Pi 4 can only use the first GB of memory. This is because several devices cannot DMA above 1GB but Xen doesn't necessarily allocate memory for Dom0 below 1GB. This small series is trying to address the

[PATCH for-4.14 1/3] xen/arm: Allow a platform to override the DMA width

2020-05-18 Thread Julien Grall
From: Julien Grall At the moment, Xen is assuming that all the devices are at least 32-bit DMA capable. However, some SoC have devices that may be able to access a much restricted range. For instance, the RPI has devices that can only access the first 1GB of RAM. The structure platform_desc is

[PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

2020-05-18 Thread Julien Grall
From: Julien Grall The raspberry PI 4 has devices that can only DMA into the first GB of the RAM. Therefore we want allocate as much as possible memory below 1GB for dom0. Use the recently introduced dma_bitsize field to specify the DMA width supported. Signed-off-by: Julien Grall

[linux-linus test] 150230: tolerable FAIL - PUSHED

2020-05-18 Thread osstest service owner
flight 150230 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150230/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 150225 test-amd64-amd64-xl-qemut-win7-amd64

Re: [RESEND PATCH v2 for-4.14] pvcalls: Document correctly and explicitely the padding for all arches

2020-05-18 Thread Julien Grall
Hi Jan, On 18/05/2020 12:51, Jan Beulich wrote: On 16.05.2020 12:21, Julien Grall wrote: --- a/xen/include/public/io/pvcalls.h +++ b/xen/include/public/io/pvcalls.h @@ -65,6 +65,9 @@ struct xen_pvcalls_request { uint32_t domain; uint32_t type; uint32_t

Re: [PATCH v4] x86: clear RDRAND CPUID bit on AMD family 15h/16h

2020-05-18 Thread Jan Beulich
On 15.05.2020 17:18, Roger Pau Monné wrote: > On Mon, Mar 09, 2020 at 10:08:50AM +0100, Jan Beulich wrote: >> Inspired by Linux commit c49a0a80137c7ca7d6ced4c812c9e07a949f6f24: >> >> There have been reports of RDRAND issues after resuming from suspend on >> some AMD family 15h and family

Re: [PATCH] x86: refine guest_mode()

2020-05-18 Thread Roger Pau Monné
On Tue, Apr 28, 2020 at 08:30:12AM +0200, Jan Beulich wrote: > On 27.04.2020 22:11, Andrew Cooper wrote: > > On 27/04/2020 16:15, Jan Beulich wrote: > >> On 27.04.2020 16:35, Andrew Cooper wrote: > >>> On 27/04/2020 09:03, Jan Beulich wrote: > The 2nd of the assertions as well as the macro's

Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain

2020-05-18 Thread Marek Marczykowski-Górecki
On Mon, May 18, 2020 at 03:15:17PM +0100, Ian Jackson wrote: > Jason Andryuk writes ("Re: [PATCH v5 09/21] libxl: add save/restore support > for qemu-xen in stubdomain"): > > On Thu, May 14, 2020 at 12:35 PM Ian Jackson wrote: > > > It's not stated anywhere here that I can see but I think what

Re: [PATCH v3 2/2] x86/idle: prevent entering C6 with in service interrupts on Intel

2020-05-18 Thread Roger Pau Monné
On Mon, May 18, 2020 at 05:05:12PM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 15.05.2020 15:58, Roger Pau Monne wrote: > > --- a/docs/misc/xen-command-line.pandoc

Re: [PATCH for-4.14 2/3] xen/arm: Take into account the DMA width when allocating Dom0 memory banks

2020-05-18 Thread Volodymyr Babchuk
Hi Julien, On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: > From: Julien Grall > > At the moment, Xen is assuming that all the devices are at least 32-bit > DMA capable. However, some SoCs have devices that may be able to access > a much restricted range. For instance, the Raspberry PI

Re: [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

2020-05-18 Thread Volodymyr Babchuk
Hi Julien, On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: > From: Julien Grall > > The raspberry PI 4 has devices that can only DMA into the first GB of > the RAM. Therefore we want allocate as much as possible memory below 1GB > for dom0. > > Use the recently introduced dma_bitsize

[xen-unstable-smoke test] 150233: tolerable all pass - PUSHED

2020-05-18 Thread osstest service owner
flight 150233 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150233/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v3 1/5] x86: suppress XPTI-related TLB flushes when possible

2020-05-18 Thread Roger Pau Monné
On Wed, Sep 25, 2019 at 05:23:11PM +0200, Jan Beulich wrote: > When there's no XPTI-enabled PV domain at all, there's no need to issue > respective TLB flushes. Hardwire opt_xpti_* to false when !PV, and > record the creation of PV domains by bumping opt_xpti_* accordingly. > > As to the sticky

Re: [RESEND PATCH v2 for-4.14] pvcalls: Document correctly and explicitely the padding for all arches

2020-05-18 Thread Jan Beulich
On 16.05.2020 12:21, Julien Grall wrote: > --- a/xen/include/public/io/pvcalls.h > +++ b/xen/include/public/io/pvcalls.h > @@ -65,6 +65,9 @@ struct xen_pvcalls_request { > uint32_t domain; > uint32_t type; > uint32_t protocol; > +#ifndef CONFIG_X86_32 > +

[seabios test] 150229: tolerable FAIL - PUSHED

2020-05-18 Thread osstest service owner
flight 150229 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/150229/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 150201 test-amd64-amd64-xl-qemuu-win7-amd64 17

RE: [PATCH v3] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Paul Durrant
> -Original Message- > From: Denis Kirjanov > Sent: 18 May 2020 14:49 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; jgr...@suse.com > Subject: Re: [PATCH v3] public/io/netif.h: add a new extra type for XDP > > On 5/18/20, Paul Durrant wrote: > >> -Original Message- >

Re: [PATCH v6 09/18] libxl: add save/restore support for qemu-xen in stubdomain

2020-05-18 Thread Jason Andryuk
On Mon, May 18, 2020 at 10:24 AM Ian Jackson wrote: > > Jason Andryuk writes ("[PATCH v6 09/18] libxl: add save/restore support for > qemu-xen in stubdomain"): > > From: Marek Marczykowski-Górecki > ... > > if (state->saved_state) { > > -/* This file descriptor is meant to be used

Re: [PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-18 Thread Andrew Cooper
On 18/05/2020 16:38, Andrew Cooper wrote: > The reserved_bit_page_fault() paths effectively turn reserved bit faults into > a warning, but in the light of L1TF, the real impact is far more serious. > > Xen does not have any reserved bits set in its pagetables, nor do we permit PV > guests to write

Re: [PATCH v6 09/18] libxl: add save/restore support for qemu-xen in stubdomain

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("Re: [PATCH v6 09/18] libxl: add save/restore support for qemu-xen in stubdomain"): > On Mon, May 18, 2020 at 10:24 AM Ian Jackson wrote: > > Provided that you update the docs commit and take my ack off that, > > please add my ack to this code :-). > > I updated "[PATCH v6

Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0

2020-05-18 Thread Manuel Bouyer
On Mon, May 18, 2020 at 08:36:24AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Xen-devel On Behalf Of > > Manuel Bouyer > > Sent: 17 May 2020 18:56 > > To: Andrew Cooper > > Cc: xen-devel@lists.xenproject.org > > Subject: Re: IOCTL_PRIVCMD_MMAPBATCH on Xen 4.13.0 > > >

[PATCH 4.4 67/86] x86/paravirt: Remove the unused irq_enable_sysexit pv op

2020-05-18 Thread Greg Kroah-Hartman
From: Boris Ostrovsky commit 88c15ec90ff16880efab92b519436ee17b198477 upstream. As result of commit "x86/xen: Avoid fast syscall path for Xen PV guests", the irq_enable_sysexit pv op is not called by Xen PV guests anymore and since they were the only ones who used it we can safely remove it.

[ovmf test] 150232: all pass - PUSHED

2020-05-18 Thread osstest service owner
flight 150232 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/150232/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7b6327ff03bb4436261ffad246ba3a14de10391f baseline version: ovmf

Re: [PATCH] x86/hvm: Fix memory leaks in hvm_copy_context_and_params()

2020-05-18 Thread Tamas K Lengyel
On Sat, May 16, 2020 at 6:22 AM Andrew Cooper wrote: > > Any error from hvm_save() or hvm_set_param() leaks the c.data allocation. > > Spotted by Coverity. > > Fixes: 353744830 "x86/hvm: introduce hvm_copy_context_and_params" > Signed-off-by: Andrew Cooper Thanks for the fix, my bad! Tamas

Re: [PATCH v6 06/18] libxl: write qemu arguments into separate xenstore keys

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("Re: [PATCH v6 06/18] libxl: write qemu arguments into separate xenstore keys"): > On Mon, May 18, 2020 at 10:20 AM Ian Jackson wrote: > > I think this should be "goto out". That conforms to standard libxl > > error handling discipline and avoids future leak bugs etc. > >

Re: [PATCH v3] x86/PV: remove unnecessary toggle_guest_pt() overhead

2020-05-18 Thread Roger Pau Monné
On Tue, May 05, 2020 at 08:16:03AM +0200, Jan Beulich wrote: > While the mere updating of ->pv_cr3 and ->root_pgt_changed aren't overly > expensive (but still needed only for the toggle_guest_mode() path), the > effect of the latter on the exit-to-guest path is not insignificant. > Move the logic

Re: [PATCH 02/16] x86/traps: Clean up printing in do_reserved_trap()/fatal_trap()

2020-05-18 Thread Andrew Cooper
On 11/05/2020 16:09, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 11.05.2020 17:01, Andrew Cooper wrote: >> On 04/05/2020 14:08, Jan Beulich wrote: >>> On 02.05.2020 00:58,

Re: [PATCH v1] tools: use HOSTCC/CPP to compile rombios code and helper

2020-05-18 Thread Wei Liu
On Mon, May 18, 2020 at 04:44:00PM +0200, Olaf Hering wrote: > Use also HOSTCFLAGS for biossums while touching the code. > > Spotted by inspecting build logfile. > > Signed-off-by: Olaf Hering Acked-by: Wei Liu > --- > tools/firmware/rombios/Makefile | 4 ++-- > 1 file changed, 2

[xen-unstable-smoke test] 150231: tolerable all pass - PUSHED

2020-05-18 Thread osstest service owner
flight 150231 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150231/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain [and 1 more messages]

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain [and 1 more messages]"): > On Mon, May 18, 2020 at 11:18 AM Ian Jackson wrote: > > [explanation of confusion] > > Do you want the commit message to add a blurb about this? So the > message

Re: [PATCH for-4.14 1/3] xen/arm: Allow a platform to override the DMA width

2020-05-18 Thread Volodymyr Babchuk
Hi Julien, On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: > From: Julien Grall > > At the moment, Xen is assuming that all the devices are at least 32-bit > DMA capable. However, some SoC have devices that may be able to access > a much restricted range. For instance, the RPI has

[PATCH v5] x86: clear RDRAND CPUID bit on AMD family 15h/16h

2020-05-18 Thread Jan Beulich
Inspired by Linux commit c49a0a80137c7ca7d6ced4c812c9e07a949f6f24: There have been reports of RDRAND issues after resuming from suspend on some AMD family 15h and family 16h systems. This issue stems from a BIOS not performing the proper steps during resume to ensure RDRAND continues

Re: [PATCH v9 04/12] xen: add basic hypervisor filesystem support

2020-05-18 Thread Jan Beulich
On 15.05.2020 13:58, Juergen Gross wrote: > --- /dev/null > +++ b/xen/common/hypfs.c > @@ -0,0 +1,418 @@ > +/** > + * > + * hypfs.c > + * > + * Simple sysfs-like file system for the hypervisor. > + */ > + > +#include >

Re: [PATCH v6 13/18] libxl: use vchan for QMP access with Linux stubdomain

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("[PATCH v6 13/18] libxl: use vchan for QMP access with Linux stubdomain"): > Ian, you acked the original and the squashed in "libxl: Kill > vchan-socket-proxy when cleaning up qmp". However, I also added the > libxl__qmp_cleanup() call, so I did not retain your Ack. That

Re: [PATCH v6 14/18] libxl: require qemu in dom0 for multiple stubdomain consoles

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("[PATCH v6 14/18] libxl: require qemu in dom0 for multiple stubdomain consoles"): > From: Marek Marczykowski-Górecki > > Device model stubdomains (both Mini-OS + qemu-trad and linux + qemu-xen) > are always started with at least 3 consoles: log, save, and restore. > Until

[PATCH v4] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. The offset value from a guest is passed via xenstore. Signed-off-by: Denis Kirjanov --- v4: - updated the commit and documenation v3: -

Re: [PATCH v3 2/2] x86/idle: prevent entering C6 with in service interrupts on Intel

2020-05-18 Thread Jan Beulich
On 15.05.2020 15:58, Roger Pau Monne wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -652,6 +652,15 @@ Specify the size of the console debug trace buffer. By > specifying `cpu:` > additionally a trace buffer of the specified size is allocated per

Re: [PATCH v6 06/18] libxl: write qemu arguments into separate xenstore keys

2020-05-18 Thread Jason Andryuk
On Mon, May 18, 2020 at 10:20 AM Ian Jackson wrote: > > Jason Andryuk writes ("[PATCH v6 06/18] libxl: write qemu arguments into > separate xenstore keys"): > > From: Marek Marczykowski-Górecki > ... > > +static int libxl__write_stub_linux_dm_argv(libxl__gc *gc, > > +

Re: [PATCH v3 0/3] various: Remove unnecessary casts

2020-05-18 Thread Paolo Bonzini
On 15/05/20 07:58, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Remove unnecessary casts using coccinelle scripts. >> >> The CPU()/OBJECT() patches don't introduce logical change, >> The DEVICE() one removes various OBJECT_CHECK() calls. > Queued, thanks! > > Managing

[PATCH v3] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Denis Kirjanov
The patch adds a new extra type to be able to diffirentiate between RX responses on xen-netfront side with the adjusted offset required for XDP processing. The offset value from a guest is passed via xenstore. Signed-off-by: Denis Kirjanov --- v3: - updated the commit message v2: - added

RE: [PATCH v3] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Paul Durrant
> -Original Message- > From: Denis Kirjanov > Sent: 18 May 2020 14:26 > To: xen-devel@lists.xenproject.org > Cc: p...@xen.org; jgr...@suse.com > Subject: [PATCH v3] public/io/netif.h: add a new extra type for XDP > > The patch adds a new extra type to be able to diffirentiate > between

Re: [PATCH v3] public/io/netif.h: add a new extra type for XDP

2020-05-18 Thread Denis Kirjanov
On 5/18/20, Paul Durrant wrote: >> -Original Message- >> From: Denis Kirjanov >> Sent: 18 May 2020 14:26 >> To: xen-devel@lists.xenproject.org >> Cc: p...@xen.org; jgr...@suse.com >> Subject: [PATCH v3] public/io/netif.h: add a new extra type for XDP >> >> The patch adds a new extra type

Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain [and 1 more messages]

2020-05-18 Thread Jason Andryuk
On Mon, May 18, 2020 at 11:18 AM Ian Jackson wrote: > > > > Marek Marczykowski-Górecki writes ("Re: [PATCH v5 09/21] libxl: add > save/restore support for qemu-xen in stubdomain"): > > On Mon, May 18, 2020 at 03:15:17PM +0100, Ian Jackson wrote: > > > Err, by "the qemu savefile pathname" I meant

Re: [PATCH v3 2/2] x86/idle: prevent entering C6 with in service interrupts on Intel

2020-05-18 Thread Jan Beulich
On 18.05.2020 17:45, Roger Pau Monné wrote: > On Mon, May 18, 2020 at 05:05:12PM +0200, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 15.05.2020 15:58, Roger Pau Monne

Re: [PATCH v3 0/3] various: Remove unnecessary casts

2020-05-18 Thread Markus Armbruster
Paolo Bonzini writes: > On 15/05/20 07:58, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Remove unnecessary casts using coccinelle scripts. >>> >>> The CPU()/OBJECT() patches don't introduce logical change, >>> The DEVICE() one removes various OBJECT_CHECK() calls. >>

Re: [XEN PATCH 0/2] Fix installation of python scripts

2020-05-18 Thread Anthony PERARD
Ping? Cheers. On Wed, Mar 11, 2020 at 05:59:31PM +, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > br.fix-python-install-v1 > > Hi, > > A patch to make packaging of xen on centos8 easier. rpmbuild >

[PATCH] x86: determine MXCSR mask in all cases

2020-05-18 Thread Jan Beulich
For its use(s) by the emulator to be correct in all cases, the filling of the variable needs to be independent of XSAVE availability. As there's no suitable function in i387.c to put the logic in, keep it in xstate_init(), arrange for the function to be called unconditionally, and pull the logic

Re: [PATCH v6 06/18] libxl: write qemu arguments into separate xenstore keys

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("[PATCH v6 06/18] libxl: write qemu arguments into separate xenstore keys"): > From: Marek Marczykowski-Górecki ... > +static int libxl__write_stub_linux_dm_argv(libxl__gc *gc, > + int dm_domid, int guest_domid, > +

[xen-unstable test] 150227: tolerable FAIL

2020-05-18 Thread osstest service owner
flight 150227 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150227/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail like 150223 test-armhf-armhf-libvirt 14

Re: [PATCH v6 00/18] Add support for qemu-xen runnning in a Linux-based stubdomain

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("[PATCH v6 00/18] Add support for qemu-xen runnning in a Linux-based stubdomain"): > In coordination with Marek, I'm making a submission of his patches for Linux > stubdomain device-model support. I made a few of my own additions, but Marek > did the heavy lifting. Thank

Re: [PATCH v9 04/12] xen: add basic hypervisor filesystem support

2020-05-18 Thread Jürgen Groß
On 18.05.20 16:27, Jan Beulich wrote: On 15.05.2020 13:58, Juergen Gross wrote: --- /dev/null +++ b/xen/common/hypfs.c @@ -0,0 +1,418 @@ +/** + * + * hypfs.c + * + * Simple sysfs-like file system for the hypervisor. +

Re: [PATCH v9 09/12] xen: add runtime parameter access support to hypfs

2020-05-18 Thread Jan Beulich
On 15.05.2020 13:58, Juergen Gross wrote: > Add support to read and modify values of hypervisor runtime parameters > via the hypervisor file system. > > As runtime parameters can be modified via a sysctl, too, this path has > to take the hypfs rw_lock as writer. > > For custom runtime parameters

Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain"): > On Thu, May 14, 2020 at 12:35 PM Ian Jackson wrote: > > I suggest randomly allocating one in the range [64,192>. My random > > number generator picked 119. So 118 and 119 ? > > This

Re: [PATCH v6 09/18] libxl: add save/restore support for qemu-xen in stubdomain

2020-05-18 Thread Ian Jackson
Jason Andryuk writes ("[PATCH v6 09/18] libxl: add save/restore support for qemu-xen in stubdomain"): > From: Marek Marczykowski-Górecki ... > if (state->saved_state) { > -/* This file descriptor is meant to be used by QEMU */ > -*dm_state_fd = open(state->saved_state,

[PATCH v1] tools: use HOSTCC/CPP to compile rombios code and helper

2020-05-18 Thread Olaf Hering
Use also HOSTCFLAGS for biossums while touching the code. Spotted by inspecting build logfile. Signed-off-by: Olaf Hering --- tools/firmware/rombios/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/firmware/rombios/Makefile

Re: [PATCH] x86: determine MXCSR mask in all cases

2020-05-18 Thread Andrew Cooper
On 18/05/2020 14:16, Jan Beulich wrote: > For its use(s) by the emulator to be correct in all cases, the filling > of the variable needs to be independent of XSAVE availability. As > there's no suitable function in i387.c to put the logic in, keep it in > xstate_init(), arrange for the function to

Re: [PATCH v3 1/2] x86/idle: rework C6 EOI workaround

2020-05-18 Thread Jan Beulich
On 15.05.2020 15:58, Roger Pau Monne wrote: > Change the C6 EOI workaround (errata AAJ72) to use x86_match_cpu. Also > call the workaround from mwait_idle, previously it was only used by > the ACPI idle driver. Finally make sure the routine is called for all > states equal or greater than

Re: [PATCH v1] tools: use HOSTCC/CPP to compile rombios code and helper

2020-05-18 Thread Andrew Cooper
On 18/05/2020 15:44, Olaf Hering wrote: > Use also HOSTCFLAGS for biossums while touching the code. > > Spotted by inspecting build logfile. > > Signed-off-by: Olaf Hering Acked-by: Andrew Cooper

[PATCH] x86/traps: Rework #PF[Rsvd] bit handling

2020-05-18 Thread Andrew Cooper
The reserved_bit_page_fault() paths effectively turn reserved bit faults into a warning, but in the light of L1TF, the real impact is far more serious. Xen does not have any reserved bits set in its pagetables, nor do we permit PV guests to write any. An HVM shadow guest may have reserved bits

Re: [PATCH v3 0/3] various: Remove unnecessary casts

2020-05-18 Thread Cédric Le Goater
On 5/18/20 3:17 PM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 15/05/20 07:58, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> Remove unnecessary casts using coccinelle scripts. The CPU()/OBJECT() patches don't introduce logical change, The

Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain [and 1 more messages]

2020-05-18 Thread Ian Jackson
> Marek Marczykowski-Górecki writes ("Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain"): > On Mon, May 18, 2020 at 03:15:17PM +0100, Ian Jackson wrote: > > Err, by "the qemu savefile pathname" I meant the pathname in dom0. > > I assume your wrapper script opens

Re: [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI

2020-05-18 Thread Corey Minyard
On Mon, May 18, 2020 at 08:36:08PM +, Volodymyr Babchuk wrote: > Hi Julien, > > On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: > > From: Julien Grall > > > > The raspberry PI 4 has devices that can only DMA into the first GB of > > the RAM. Therefore we want allocate as much as

Re: [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4

2020-05-18 Thread Tamas K Lengyel
On Mon, May 18, 2020 at 5:32 AM Julien Grall wrote: > > From: Julien Grall > > Hi all, > > At the moment, a user who wants to boot Xen on the Raspberry Pi 4 can > only use the first GB of memory. > > This is because several devices cannot DMA above 1GB but Xen doesn't > necessarily allocate

[PATCH v7 05/19] libxl: Handle Linux stubdomain specific QEMU options.

2020-05-18 Thread Jason Andryuk
From: Eric Shelton This patch creates an appropriate command line for the QEMU instance running in a Linux-based stubdomain. NOTE: a number of items are not currently implemented for Linux-based stubdomains, such as: - save/restore - QMP socket - graphics output (e.g., VNC) Signed-off-by: Eric

[PATCH v7 03/19] libxl: fix qemu-trad cmdline for no sdl/vnc case

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki When qemu is running in stubdomain, any attempt to initialize vnc/sdl there will crash it (on failed attempt to load a keymap from a file). If vfb is present, all those cases are skipped. But since b053f0c4c9e533f3d97837cf897eb920b8355ed3 "libxl: do not start

[PATCH v7 02/19] Document ioemu Linux stubdomain protocol

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Add documentation for upcoming Linux stubdomain for qemu-upstream. Signed-off-by: Marek Marczykowski-Górecki Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian Jackson - Replace dmargs with dm-argv for xenstore

[PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki This allows using arguments with spaces, like -append, without nominating any special "separator" character. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jason Andryuk Write arguments in dm-argv directory instead of overloading mini-os's dmargs

[PATCH v7 04/19] libxl: Allow running qemu-xen in stubdomain

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Do not prohibit anymore using stubdomain with qemu-xen. To help distingushing MiniOS and Linux stubdomain, add helper inline functions libxl__stubdomain_is_linux() and libxl__stubdomain_is_linux_running(). Those should be used where really the difference is about

[PATCH v7 11/19] tools: add missing libxenvchan cflags

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki libxenvchan.h include xenevtchn.h and xengnttab.h, so applications built with it needs applicable -I in CFLAGS too. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jason Andryuk Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6 -

[PATCH v7 08/19] xl: add stubdomain related options to xl config parser

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jason Andryuk Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian Jackson --- docs/man/xl.cfg.5.pod.in | 27 +++ tools/xl/xl_parse.c |

[PATCH v7 18/19] docs: Add device-model-domid to xenstore-paths

2020-05-18 Thread Jason Andryuk
Document device-model-domid for when using a device model stubdomain. Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian Jackson --- docs/misc/xenstore-paths.pandoc | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/misc/xenstore-paths.pandoc

[PATCH v7 14/19] libxl: use vchan for QMP access with Linux stubdomain

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Access to QMP of QEMU in Linux stubdomain is possible over vchan connection. Handle the actual vchan connection in a separate process (vchan-socket-proxy). This simplified integration with QMP (already quite complex), but also allows preliminary filtering of

[PATCH v7 06/19] libxl: Use libxl__xs_* in libxl__write_stub_dmargs

2020-05-18 Thread Jason Andryuk
Re-work libxl__write_stub_dmargs to use libxl_xs_* functions in a loop. Signed-off-by: Jason Andryuk --- New in v7 --- tools/libxl/libxl_dm.c | 53 ++ 1 file changed, 38 insertions(+), 15 deletions(-) diff --git a/tools/libxl/libxl_dm.c

[PATCH v7 12/19] tools: add simple vchan-socket-proxy

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Add a simple proxy for tunneling socket connection over vchan. This is based on existing vchan-node* applications, but extended with socket support. vchan-socket-proxy serves both as a client and as a server, depending on parameters. It can be used to

[PATCH v7 15/19] libxl: require qemu in dom0 for multiple stubdomain consoles

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Device model stubdomains (both Mini-OS + qemu-trad and linux + qemu-xen) are always started with at least 3 consoles: log, save, and restore. Until xenconsoled learns how to handle multiple consoles, this is needed for save/restore support. For Mini-OS stubdoms,

[PATCH v7 00/19] Add support for qemu-xen runnning in a Linux-based stubdomain

2020-05-18 Thread Jason Andryuk
Hi, Below is mostly the v6 cover leter with a few additions. All patches are Acked except for libxl: Use libxl__xs_* in libxl__write_stub_dmargs libxl: write qemu arguments into separate xenstore keys These are refactored into Ian's preferred form (I think). A single loop for the xenstore

[PATCH v7 09/19] tools/libvchan: notify server when client is connected

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Let the server know when the client is connected. Otherwise server will notice only when client send some data. This change does not break existing clients, as libvchan user should handle spurious notifications anyway (for example acknowledge of remote side

[PATCH v7 19/19] libxl: Check stubdomain kernel & ramdisk presence

2020-05-18 Thread Jason Andryuk
Just out of context is the following comment for libxl__domain_make: /* fixme: this function can leak the stubdom if it fails */ When the stubdomain kernel or ramdisk is not present, the domid and stubdomain name will indeed be leaked. Avoid the leak by checking the file presence and erroring

[PATCH v7 01/19] Document ioemu MiniOS stubdomain protocol

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Add documentation based on reverse-engineered toolstack-ioemu stubdomain protocol. Signed-off-by: Marek Marczykowski-Górecki Signed-off-by: Jason Andryuk Acked-by: Ian Jackson --- Changes in v6: - Add Acked-by: Ian Jackson --- docs/misc/stubdom.txt | 53

[PATCH v7 10/19] libxl: add save/restore support for qemu-xen in stubdomain

2020-05-18 Thread Jason Andryuk
From: Marek Marczykowski-Górecki Rely on a wrapper script in stubdomain to attach relevant consoles to qemu. The save console (1) must be attached to fdset/1. When performing a restore, $STUBDOM_RESTORE_INCOMING_ARG must be replaced on the qemu command line by "fd:$FD", where $FD is an open

  1   2   >