Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT

2019-08-29 Thread Jan Beulich
On 28.08.2019 20:24, Andrew Cooper wrote: > On 27/08/2019 15:36, Jan Beulich wrote: >> On 14.08.2019 12:44, Andrew Cooper wrote: >>> Introduce a new ENDDATA() helper which sets type and size together. >> >> Except this isn't very natural: Setting the size late is quite >> common, to avoid the need

Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT

2019-08-28 Thread Andrew Cooper
On 27/08/2019 15:36, Jan Beulich wrote: > On 14.08.2019 12:44, Andrew Cooper wrote: >> Introduce a new ENDDATA() helper which sets type and size together. > > Except this isn't very natural: Setting the size late is quite > common, to avoid the need for an "end" label. But the type would > better b

Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT

2019-08-27 Thread Jan Beulich
On 14.08.2019 12:44, Andrew Cooper wrote: Introduce a new ENDDATA() helper which sets type and size together. Except this isn't very natural: Setting the size late is quite common, to avoid the need for an "end" label. But the type would better be set together with the label definition, i.e. by

Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT

2019-08-27 Thread Jan Beulich
On 14.08.2019 14:00, Wei Liu wrote: On Wed, Aug 14, 2019 at 11:44:04AM +0100, Andrew Cooper wrote: [...] diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h index 22dc795eea..35705441ff 100644 --- a/xen/include/asm-x86/config.h +++ b/xen/include/asm-x86/config.h @@ -56,6 +56

Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT

2019-08-14 Thread Andrew Cooper
On 14/08/2019 13:00, Wei Liu wrote: > On Wed, Aug 14, 2019 at 11:44:04AM +0100, Andrew Cooper wrote: > [...] >> diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h >> index 22dc795eea..35705441ff 100644 >> --- a/xen/include/asm-x86/config.h >> +++ b/xen/include/asm-x86/config.h

Re: [Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT

2019-08-14 Thread Wei Liu
On Wed, Aug 14, 2019 at 11:44:04AM +0100, Andrew Cooper wrote: [...] > diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h > index 22dc795eea..35705441ff 100644 > --- a/xen/include/asm-x86/config.h > +++ b/xen/include/asm-x86/config.h > @@ -56,6 +56,11 @@ > #define GLOBAL(name

[Xen-devel] [PATCH] x86/boot: Annotate pagetables with STT_OBJECT

2019-08-14 Thread Andrew Cooper
Introduce a new ENDDATA() helper which sets type and size together. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/boot/x86_64.S | 18 +- xen/include/asm-x86/config.h | 5 + 2 files changed, 14 insertions(+), 9 deletion