Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-26 Thread Tamas K Lengyel
On Thu, Mar 26, 2020 at 3:10 AM Roger Pau Monné wrote: > > On Thu, Mar 26, 2020 at 08:07:09AM +0100, Jan Beulich wrote: > > On 25.03.2020 16:47, Roger Pau Monné wrote: > > > On Mon, Mar 23, 2020 at 10:04:35AM -0700, Tamas K Lengyel wrote: > > >> +static int copy_vcpu_settings(struct domain *cd,

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-26 Thread Tamas K Lengyel
On Thu, Mar 26, 2020 at 6:33 AM Jan Beulich wrote: > > On 23.03.2020 18:04, Tamas K Lengyel wrote: > > --- a/xen/arch/x86/domain.c > > +++ b/xen/arch/x86/domain.c > > @@ -2202,6 +2202,17 @@ int domain_relinquish_resources(struct domain *d) > > ret = relinquish_shared_pages(d); > >

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-26 Thread Jan Beulich
On 23.03.2020 18:04, Tamas K Lengyel wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -2202,6 +2202,17 @@ int domain_relinquish_resources(struct domain *d) > ret = relinquish_shared_pages(d); > if ( ret ) > return ret; > + > +

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-26 Thread Roger Pau Monné
On Thu, Mar 26, 2020 at 08:07:09AM +0100, Jan Beulich wrote: > On 25.03.2020 16:47, Roger Pau Monné wrote: > > On Mon, Mar 23, 2020 at 10:04:35AM -0700, Tamas K Lengyel wrote: > >> +static int copy_vcpu_settings(struct domain *cd, struct domain *d) > >> +{ > >> +unsigned int i; > >> +

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-26 Thread Roger Pau Monné
On Thu, Mar 26, 2020 at 08:02:22AM +0100, Jan Beulich wrote: > On 25.03.2020 17:54, Roger Pau Monné wrote: > > On Wed, Mar 25, 2020 at 04:42:07PM +, Julien Grall wrote: > >> On 25/03/2020 16:34, Tamas K Lengyel wrote: > > --- a/xen/common/domain.c > > +++ b/xen/common/domain.c > >

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-26 Thread Jan Beulich
On 25.03.2020 16:47, Roger Pau Monné wrote: > On Mon, Mar 23, 2020 at 10:04:35AM -0700, Tamas K Lengyel wrote: >> +static int copy_vcpu_settings(struct domain *cd, struct domain *d) >> +{ >> +unsigned int i; >> +struct p2m_domain *p2m = p2m_get_hostp2m(cd); >> +int ret = -EINVAL; >> +

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-26 Thread Jan Beulich
On 25.03.2020 17:54, Roger Pau Monné wrote: > On Wed, Mar 25, 2020 at 04:42:07PM +, Julien Grall wrote: >> On 25/03/2020 16:34, Tamas K Lengyel wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -1270,6 +1270,9 @@ int map_vcpu_info(struct vcpu *v, unsigned long

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Tamas K Lengyel
On Wed, Mar 25, 2020 at 11:16 AM Roger Pau Monné wrote: > > On Wed, Mar 25, 2020 at 11:00:05AM -0600, Tamas K Lengyel wrote: > > On Wed, Mar 25, 2020 at 10:52 AM Julien Grall wrote: > > > > > > > > > > > > On 25/03/2020 16:47, Tamas K Lengyel wrote: > > > > On Wed, Mar 25, 2020 at 10:42 AM

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Roger Pau Monné
On Wed, Mar 25, 2020 at 11:00:05AM -0600, Tamas K Lengyel wrote: > On Wed, Mar 25, 2020 at 10:52 AM Julien Grall wrote: > > > > > > > > On 25/03/2020 16:47, Tamas K Lengyel wrote: > > > On Wed, Mar 25, 2020 at 10:42 AM Julien Grall wrote: > > >> > > >> Hi, > > >> > > >> On 25/03/2020 16:34,

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Tamas K Lengyel
On Wed, Mar 25, 2020 at 10:52 AM Julien Grall wrote: > > > > On 25/03/2020 16:47, Tamas K Lengyel wrote: > > On Wed, Mar 25, 2020 at 10:42 AM Julien Grall wrote: > >> > >> Hi, > >> > >> On 25/03/2020 16:34, Tamas K Lengyel wrote: > > diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Roger Pau Monné
On Wed, Mar 25, 2020 at 04:42:07PM +, Julien Grall wrote: > Hi, > > On 25/03/2020 16:34, Tamas K Lengyel wrote: > > > > diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c > > > > index 9f51370327..1ed7d13084 100644 > > > > --- a/xen/arch/x86/mm/p2m.c > > > > +++

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Julien Grall
On 25/03/2020 16:47, Tamas K Lengyel wrote: On Wed, Mar 25, 2020 at 10:42 AM Julien Grall wrote: Hi, On 25/03/2020 16:34, Tamas K Lengyel wrote: diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 9f51370327..1ed7d13084 100644 --- a/xen/arch/x86/mm/p2m.c +++

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Tamas K Lengyel
On Wed, Mar 25, 2020 at 10:42 AM Julien Grall wrote: > > Hi, > > On 25/03/2020 16:34, Tamas K Lengyel wrote: > >>> diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c > >>> index 9f51370327..1ed7d13084 100644 > >>> --- a/xen/arch/x86/mm/p2m.c > >>> +++ b/xen/arch/x86/mm/p2m.c > >>> @@

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Julien Grall
Hi, On 25/03/2020 16:34, Tamas K Lengyel wrote: diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 9f51370327..1ed7d13084 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -509,6 +509,12 @@ mfn_t __get_gfn_type_access(struct p2m_domain *p2m, unsigned long gfn_l,

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Tamas K Lengyel
On Wed, Mar 25, 2020 at 9:47 AM Roger Pau Monné wrote: > > Sorry it has taken me a while to get to this. > > On Mon, Mar 23, 2020 at 10:04:35AM -0700, Tamas K Lengyel wrote: > > VM forking is the process of creating a domain with an empty memory space > > and a > > parent domain specified from

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Tamas K Lengyel
> > +static int bring_up_vcpus(struct domain *cd, struct domain *d) > > +{ > > +unsigned int i; > > +int ret = -EINVAL; > > Nit: you can get rid of ret... > > > + > > +if ( d->max_vcpus != cd->max_vcpus || > > +(ret = cpupool_move_domain(cd, d->cpupool)) ) > > +return

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Tamas K Lengyel
On Wed, Mar 25, 2020 at 9:47 AM Roger Pau Monné wrote: > > Sorry it has taken me a while to get to this. Thanks for the review, I'm addressing all the items you noticed in the next revision. Tamas

Re: [Xen-devel] [PATCH v12 1/3] xen/mem_sharing: VM forking

2020-03-25 Thread Roger Pau Monné
Sorry it has taken me a while to get to this. On Mon, Mar 23, 2020 at 10:04:35AM -0700, Tamas K Lengyel wrote: > VM forking is the process of creating a domain with an empty memory space and > a > parent domain specified from which to populate the memory when necessary. For > the new domain to