Re: [Xen-devel] [PATCH v2 1/4] xen/console: Don't treat NUL character as the end of the buffer

2019-10-02 Thread Julien Grall
Hi Stefano, On 10/2/19 2:25 AM, Stefano Stabellini wrote: On Mon, 5 Aug 2019, Julien Grall wrote: After upgrading Debian to Buster, I have began to notice console mangling when using zsh in Dom0. This is happenning because output sent by zsh to the console may contain NULs in the middle of the

Re: [Xen-devel] [PATCH v2 1/4] xen/console: Don't treat NUL character as the end of the buffer

2019-10-01 Thread Stefano Stabellini
On Mon, 5 Aug 2019, Julien Grall wrote: > After upgrading Debian to Buster, I have began to notice console > mangling when using zsh in Dom0. This is happenning because output sent by > zsh to the console may contain NULs in the middle of the buffer. > > The actual implementation of

Re: [Xen-devel] [PATCH v2 1/4] xen/console: Don't treat NUL character as the end of the buffer

2019-08-08 Thread Jan Beulich
On 08.08.2019 16:10, Julien Grall wrote: > On 08/08/2019 14:51, Jan Beulich wrote: >> On 05.08.2019 15:29, Julien Grall wrote: >>> --- a/xen/include/xen/video.h >>> +++ b/xen/include/xen/video.h >>> @@ -13,11 +13,11 @@ >>>  #ifdef CONFIG_VIDEO >>>  void video_init(void); >>> -extern void

Re: [Xen-devel] [PATCH v2 1/4] xen/console: Don't treat NUL character as the end of the buffer

2019-08-08 Thread Julien Grall
Hi Jan, On 08/08/2019 14:51, Jan Beulich wrote: On 05.08.2019 15:29, Julien Grall wrote: @@ -1261,14 +1259,15 @@ void debugtrace_printk(const char *fmt, ...) ASSERT(debugtrace_buf[debugtrace_bytes - 1] == 0); va_start(args, fmt); -vsnprintf(buf, sizeof(buf), fmt, args); +

Re: [Xen-devel] [PATCH v2 1/4] xen/console: Don't treat NUL character as the end of the buffer

2019-08-08 Thread Jan Beulich
On 05.08.2019 15:29, Julien Grall wrote: > @@ -1261,14 +1259,15 @@ void debugtrace_printk(const char *fmt, ...) > ASSERT(debugtrace_buf[debugtrace_bytes - 1] == 0); > > va_start(args, fmt); > -vsnprintf(buf, sizeof(buf), fmt, args); > +nr = vscnprintf(buf, sizeof(buf), fmt,