Re: [XenPPC] [PATCH/RFC] Support Xen console=comX option

2006-08-10 Thread Hollis Blanchard
On Thu, 2006-08-10 at 13:25 -0400, Amos Waterland wrote: > > +str = strrchr(buf, '/'); > +if (str == NULL || strncmp(str + 1, "serial@", 7) != 0) > +continue; OK, I was wrong. :) (You can disagree, you know...) The original strchr() was better. Actually, don't we wan

Re: [XenPPC] [PATCH/RFC] Support Xen console=comX option

2006-08-10 Thread Amos Waterland
Let Xen/PPC support the console=comX option that Xen/x86 uses, so one need simply supply CMDLINE="console=com2" on the make invocation to get proper use of the physical serial port on a JS21. We do this by pruning all serial devices from the device tree, and then initializing both com1 and com2

Re: [XenPPC] [PATCH/RFC] Support Xen console=comX option

2006-08-10 Thread Hollis Blanchard
On Wed, 2006-08-09 at 19:37 -0400, Amos Waterland wrote: > The below patch allows Xen/PPC to support the console=comX option > that Xen/x86 uses. With this patch applied, one need simply > supply CMDLINE="console=com2" on the make invocation to get proper use > of the physical serial port on a J

Re: [XenPPC] [PATCH/RFC] Support Xen console=comX option

2006-08-10 Thread Segher Boessenkool
I had an error in my logic that was caching the package-to-path conversion. Also, the exit condition from the loop walking the peer list should be zero or negative. Thanks to Jimi for pointing this out. SLOF is not broken :) Oh it is, just not in this aspect ;-) Segher _

Re: [XenPPC] [PATCH/RFC] Support Xen console=comX option

2006-08-09 Thread Amos Waterland
On Wed, Aug 09, 2006 at 07:37:14PM -0400, Amos Waterland wrote: > The below patch allows Xen/PPC to support the console=comX option > that Xen/x86 uses. With this patch applied, one need simply > supply CMDLINE="console=com2" on the make invocation to get proper use > of the physical serial port

[XenPPC] [PATCH/RFC] Support Xen console=comX option

2006-08-09 Thread Amos Waterland
The below patch allows Xen/PPC to support the console=comX option that Xen/x86 uses. With this patch applied, one need simply supply CMDLINE="console=com2" on the make invocation to get proper use of the physical serial port on a JS21. I will soon split out the pieces for submission, but I am p