Re: [Xenomai-core] [PATCH] semicolon delimiters & quotes

2006-08-24 Thread Paul 

Hi Gilles

On Wednesday 23 August 2006 19:53, Gilles Chanteperdrix wrote:
> I never got any error when sticking the semicolon to the last
> shell line token. I also read the portable shell rules in autobook and
> do not find any mention to such a problem. As for quoting the arguments
> of echo, I am pretty sure that it is not needed.

You are of course correct on both counts - I got in to the habit of quoting 
echos (cedit's syntax highlighter would pick up on them) and placing 
whitespaces either side of semicolons.. If nothing else, it makes the files a 
little easier to read.


Regards, Paul.


___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core

Re: [Xenomai-core] [PATCH] semicolon delimiters & quotes

2006-08-23 Thread Philippe Gerum 
On Wed, 2006-08-23 at 19:31 +0100, Paul wrote:
> Hi Folks
> 
> Having found a problem with another project where semicolons in a few make 
> targets were causing the shell to barf, I grepped xenomai trunk for similar 
> problems. In doing so, I also spotted a few echos where the text wasn't 
> quoted - A sure fire problem should anyone run the offending rule.
> 
> Small patch attached.
> 

Builds fine. Applied, thanks.

> 
> Regards, Paul.
> 
> ___
> Xenomai-core mailing list
> Xenomai-core@gna.org
> https://mail.gna.org/listinfo/xenomai-core
-- 
Philippe.



___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core

Re: [Xenomai-core] [PATCH] semicolon delimiters & quotes

2006-08-23 Thread Gilles Chanteperdrix 
Paul wrote:
 > 
 > Hi Folks
 > 
 > Having found a problem with another project where semicolons in a few make 
 > targets were causing the shell to barf, I grepped xenomai trunk for similar 
 > problems. In doing so, I also spotted a few echos where the text wasn't 
 > quoted - A sure fire problem should anyone run the offending rule.
 > 
 > Small patch attached.

Could you tell us a bit more about the errors you had on the other
project ? I never got any error when sticking the semicolon to the last
shell line token. I also read the portable shell rules in autobook and
do not find any mention to such a problem. As for quoting the arguments
of echo, I am pretty sure that it is not needed.

-- 


Gilles Chanteperdrix.

___
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core