Re: [Xenomai-core] [PATCH 2/4] Fix and optimize xnlock_put

2008-02-23 Thread Philippe Gerum
Jan Kiszka wrote: > Gilles Chanteperdrix wrote: >> Jan Kiszka wrote: >> > Gilles Chanteperdrix wrote: >> > > Jan Kiszka wrote: >> > > > As the #ifdef forest was cut down, I once again looked at xnlock_put. >> > > > Why do you have this safety check for the owner also in production >> code? >

Re: [Xenomai-core] [PATCH 2/4] Fix and optimize xnlock_put

2008-02-23 Thread Gilles Chanteperdrix
Jan Kiszka wrote: > Gilles Chanteperdrix wrote: > > Jan Kiszka wrote: > > > Gilles Chanteperdrix wrote: > > > > Jan Kiszka wrote: > > > > > As the #ifdef forest was cut down, I once again looked at > > xnlock_put. > > > > > Why do you have this safety check for the owner also in produ

Re: [Xenomai-core] [PATCH 2/4] Fix and optimize xnlock_put

2008-02-23 Thread Jan Kiszka
Gilles Chanteperdrix wrote: > Jan Kiszka wrote: > > Gilles Chanteperdrix wrote: > > > Jan Kiszka wrote: > > > > As the #ifdef forest was cut down, I once again looked at xnlock_put. > > > > Why do you have this safety check for the owner also in production > code? > > > > > > Because only

Re: [Xenomai-core] [PATCH 2/4] Fix and optimize xnlock_put

2008-02-23 Thread Gilles Chanteperdrix
Jan Kiszka wrote: > Gilles Chanteperdrix wrote: > > Jan Kiszka wrote: > > > As the #ifdef forest was cut down, I once again looked at xnlock_put. > > > Why do you have this safety check for the owner also in production code? > > > > Because only one broken xnlock_put could entail a chain r

Re: [Xenomai-core] [PATCH 2/4] Fix and optimize xnlock_put

2008-02-23 Thread Jan Kiszka
Gilles Chanteperdrix wrote: > Jan Kiszka wrote: > > As the #ifdef forest was cut down, I once again looked at xnlock_put. > > Why do you have this safety check for the owner also in production code? > > Because only one broken xnlock_put could entail a chain reaction of > broken xnlock sections

Re: [Xenomai-core] [PATCH 2/4] Fix and optimize xnlock_put

2008-02-23 Thread Gilles Chanteperdrix
Jan Kiszka wrote: > As the #ifdef forest was cut down, I once again looked at xnlock_put. > Why do you have this safety check for the owner also in production code? Because only one broken xnlock_put could entail a chain reaction of broken xnlock sections with code on multiple CPU violating crit