[Xfce-bugs] [Bug 15455] New: creating an smb share saves a wrong port

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15455

Bug ID: 15455
   Summary: creating an smb share saves a wrong port
Classification: Apps
   Product: Gigolo
   Version: unspecified
  Hardware: Other
OS: OpenBSD
Status: NEW
  Severity: normal
  Priority: Medium
 Component: General
  Assignee: xfce-bugs@xfce.org
  Reporter: lan...@xfce.org
CC: bluesa...@xfce.org
  Target Milestone: ---

with 0.4.91, if i create a new bookmark it defaults to FTP/port 21. if i switch
to SMB type, the port field is hidden, but the value is retained, and saved in
the config. Trying to connect to the share will fail with connection refused,
as it tries on port 21.

to make the smb share work, i need to edit .config/gigolo/bookmark and remove
the port line for the given bookmark.

a bit similar to bug #14928 ? probably easy to fix, just filing it so its
tracked..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

Andre Miranda  changed:

   What|Removed |Added

 CC||andre...@xfce.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15452] Crash when we right click on any unmounted volume in left tree panel

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15452

Andre Miranda  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED
 CC||andre...@xfce.org

--- Comment #6 from Andre Miranda  ---
I guess this regression was introduce by this commit:
https://git.xfce.org/xfce/thunar/commit/?id=cb12bc1

We should not rely on _thunar_return_val_if_fail or g_return_val_if_fail for
NULL check, those macros are only meant for debugging.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15452] Crash when we right click on any unmounted volume in left tree panel

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15452

--- Comment #4 from Git Bot  ---
Andre Miranda referenced this bugreport in commit
479655f5ccaf9189d9599c941c563fe5ae32578e

Fix crash on unmounted volume in tree pane right click (Bug #15452)

https://git.xfce.org/xfce/thunar/commit?id=479655f5ccaf9189d9599c941c563fe5ae32578e

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15452] Crash when we right click on any unmounted volume in left tree panel

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15452

--- Comment #5 from Git Bot  ---
Andre Miranda referenced this bugreport in commit
ba3502eaaf398ef5fac12dcc9d23fe47959c4eba

Fix crash on unmounted volume in tree pane right click (Bug #15452)

https://git.xfce.org/xfce/thunar/commit?id=ba3502eaaf398ef5fac12dcc9d23fe47959c4eba

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15454] Provide a collection of preinstalled custom actions, which can be enabled

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15454

Andre Miranda  changed:

   What|Removed |Added

 CC||andre...@xfce.org

--- Comment #1 from Andre Miranda  ---
(In reply to alexxcons from comment #0)
> You would like such a feature ?
Are you asking this to me? :)

Well, I mostly disagree, we can for sure ship some more actions, the idea to
make them disable by the default is a very good one, but there many from the
wiki that doesn't make sense to the average user IMHO.

"Finding files inside the current/selected folder with
catfish/gnome-search-tool" - catfish at least is now an official project.
"Working with archives (tar, gzip, etc)" - What about TAP?
"Playing music files" - xmms? what about mpc, clementine, vlc, Gnome music and
Spotify? I think that's the reason we have "Open with".
"Burning an ISO file to a CD" - Same
"Viewing images" - Same
"Converting PNGs to JPEGs" - What about gif, webp, tiff...?
"Losslessly Rotating JPEGs" - Image viewers can do that, or just open the file
with Gimp
"* as root" - Not sure it's a good idea to ship this, anyone that cares to do
stuff as root will do it in a terminal or is savvy enough to create the custom
action.
"Creating a symbolic link" - What about drag + ctrl + shift?
"Saving the selected file/folder's pathname to the clipboard" -  When copying a
file/folder and pasting in a text field we get the full path
"Setting an image as the desktop background" - We already have a plugin for
this.
"Viewing the disk usage of the current directory" - Folder properties already
shows this info
"Using 'nano' text editor in a terminal" - What about vim, visual studio code,
atom, intellij...?
"Download subtitles with periscope" -  Why not download stock prices, format
them as csv and open Calc?

My point is: most of them are specific to few users, even with them disabled by
default they would clutter the actions list. I think makes more sense to put in
the dialog something catchy like "Custom actions are very powerful if you are
creative. Have a look at what is possible." that would be link to this wiki.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15451] 'Insert emoji' in Thunar search causes lockup

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15451

Andre Miranda  changed:

   What|Removed |Added

 CC||andre...@xfce.org

--- Comment #1 from Andre Miranda  ---
I can reproduce, with Icons and Compact List views the search input just
disappears, but with Detailed view Thunar is unresponsive, no error message,
the CPU is at 0~1%.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15452] Crash when we right click on any unmounted volume in left tree panel

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15452

--- Comment #3 from hapical  ---
Created attachment 8577
  --> https://bugzilla.xfce.org/attachment.cgi?id=8577&action=edit
Backtrace

Yes, the crash happens with all UNMOUNTED partitions, volumes (connected hard
disk, ssd), MTP device(android) and usb pendrives, when I click with right
mouse button on them. Only unmounted ones that shows the tree view

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15452] Crash when we right click on any unmounted volume in left tree panel

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15452

--- Comment #2 from hapical  ---
Created attachment 8576
  --> https://bugzilla.xfce.org/attachment.cgi?id=8576&action=edit
Backtrace  Trace.log

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15352] Thunar shows "Move to Trash" menu entry on volumes without trash

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15352

alexxcons  changed:

   What|Removed |Added

 CC||alexxc...@xfce.org

--- Comment #3 from alexxcons  ---
I am currently trying to reproduce the bug .. but while doing so, I get a
different bug  :F
And it seems not to matter if I apply the "proposed patch v2" (Whereas the
patch actually looks good to me)

I open thunar in  /run/user/1000, which, according to "mount | column -t" is a
tmpfs which allows user to write.
Now I create some file, e.g. "test".
I get "move to trash" in the context menu.  However on click, I dont get any
confirmation dialog. The file is just deleted. The trash is empty. 
"Delete" is only shown, if enable it in the settings. (However on "delete" I
get a confirmation dialog)

Maybe the difference is related in me, using the current thunar master ? ...
iirc we changed something related lately.

Possibly there is a problem with "thunar_file_can_be_trashed" for volumes
without trash ... to be further debugged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15452] Crash when we right click on any unmounted volume in left tree panel

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15452

alexxcons  changed:

   What|Removed |Added

 CC||alexxc...@xfce.org
 Status|NEW |NEEDINFO

--- Comment #1 from alexxcons  ---
Thanks for reporting !

I cannot reproduce this bug. Does it always happen for you, or just rarely ?

Does the crash happen for all kind of volumes ? How did you mount / unmount it
?

Could you please try to generate a backtrace with debug symbols ? ( Without
symbols it is almost useless ) 
Here some distro-specific how to: https://docs.xfce.org/contribute/bugs/start

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15454] Provide a collection of preinstalled custom actions, which can be enabled

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15454

alexxcons  changed:

   What|Removed |Added

   Priority|Medium  |Very Low
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15454] New: Provide a collection of preinstalled custom actions, which can be enabled

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15454

Bug ID: 15454
   Summary: Provide a collection of preinstalled custom actions,
which can be enabled
Classification: Xfce Core
   Product: Thunar
   Version: git
  Hardware: Other
OS: Linux
Status: NEW
  Severity: normal
  Priority: Medium
 Component: UCA
  Assignee: xfce-bugs@xfce.org
  Reporter: alexxc...@xfce.org
  Target Milestone: 1.8.7

Currently a long list of all sort of possible custom actions exists in the
Wiki:
https://docs.xfce.org/xfce/thunar/custom-actions

However we only provide a single one by default, which is "open terminal here".
 And I bet many users dont even know about the existence of the wiki page.

So the idea would be:
1. Add all UCA's we have on the Wiki page to thunar per default (Side effect:
Translations for all predefined ucas possible) 
2. Add some bool attribute "enabled" to each uca. So that we can only enable
"open terminal here" by default. Disabled ucas should be grayed out in the
uca-list, and ofc not shown in the context menu.
3. We can check if required packages for a specific uca are installed and give
an error if not installed on toggle "enabled".

You would like such a feature ?

I explicitly dont want to follow the dolphin approach (load "services" from a
server, just like an appstore), since I think it is a potential security risk
to bypass the package manager and execute 3rd party code just like that.

.. not that I have time to start implementation on it. :P Just as a reminder
for myself, for some later day.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

--- Comment #3 from alexxcons  ---

Just checked the nautilus code. No suprise, it as well uses "g_file_copy". Just
like thunar it does not make use of G_FILE_COPY_ALL_METADATA

However after copy, in nautilus there is a check  "handled_invalid_filename",
which possibly could make the difference:
https://gitlab.gnome.org/GNOME/nautilus/blob/master/src/nautilus-file-operations.c#L5279

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15357] Error building libxfce4util from tonights Xfce4 Git compile

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15357

--- Comment #5 from Olivier Duchateau  ---
Problem comes from Fedora's .spec file (GObject Introspection is not set [1]).
I use my own .spec and everything is fine (and I explained how to avoid this
error).

[1]
https://src.fedoraproject.org/rpms/libxfce4util/blob/master/f/libxfce4util.spec

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15323] Thunar & plugins pages: install, dead links, dev URL

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15323

--- Comment #4 from Simon Dedman  ---
I did! I have! Cheers, I'll get onto this when I have some free time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15437] Display settings resolution not saved

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15437

--- Comment #4 from Landry Breuil  ---
Created attachment 8575
  --> https://bugzilla.xfce.org/attachment.cgi?id=8575&action=edit
displays.xml with desired values

after settings proper resolution

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15437] Display settings resolution not saved

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15437

Landry Breuil  changed:

   What|Removed |Added

 CC||och...@xfce.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15437] Display settings resolution not saved

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15437

--- Comment #3 from Landry Breuil  ---
Created attachment 8574
  --> https://bugzilla.xfce.org/attachment.cgi?id=8574&action=edit
displays.xml with the default values

default values reseted at startup ?

note the strange " in the name property..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

--- Comment #2 from Myk  ---
> Possibly it would help to set G_FILE_COPY_ALL_METADATA as copy_flag. Could 
> you check if that helps ?

I'm not aware how to do that. and have not looked at the code at all. 

> Can you reproduce the problem as well with nautilus ? (There is the chance 
> that gvfs or google-gvfs is to blame )

Sorry, should have said that I tested using Nautilus, and it copies the files
across making the copied filename the G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME
instead of the ID. Using Nautilus, I do not experience the same problem, thus I
believe the issue is with Thunar, since both Thunar and Nautilus are using the
same GVFS libraries as far as I know.

I think the direction to maintain the attributes is within the GVFS filesystem,
perhaps? Thunar's internal representation of the file object should use the ID,
and that should be used when interacting with the GVFS remote system. But in
order to maintain the displayed filename when copying to a non-GVFS filesystem,
the display name needs to be used for the filename, since in local filesystems,
they are the same thing. I'm making some assumptions based on general knowledge
rather than any specific knowledge of GFile or Thunar code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

alexxcons  changed:

   What|Removed |Added

 CC||alexxc...@xfce.org

--- Comment #1 from alexxcons  ---
Thanks for reporting !

Thunar is using "g_file_copy" to copy files (See ttj_copy_file in
thunar-transfer-job.c)

Possibly it would help to set G_FILE_COPY_ALL_METADATA as copy_flag. Could you
check if that helps ?

I dont have time to test this myself in detail currently ... will put it on my
list (though my list already is very long).
If you can, please feel free to debug yourself !


I dont know if we should always copy all metadata .. to be checked what that
would mean.

Can you reproduce the problem as well with nautilus ? (There is the chance that
gvfs or google-gvfs is to blame )

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15437] Display settings resolution not saved

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15437

Landry Breuil  changed:

   What|Removed |Added

 CC||lan...@xfce.org

--- Comment #2 from Landry Breuil  ---
can confirm too on OpenBSD with the same versions, i thought it was due to a
xfce4-session crash upon exit..

the displays channel in xfconf has the properties correctly set in a running
session.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15438] Display settings are reverted back to previous values after reboot/relogin

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15438

Andre Miranda  changed:

   What|Removed |Added

 CC||andre...@xfce.org
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Andre Miranda  ---


*** This bug has been marked as a duplicate of bug 15437 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15437] Display settings resolution not saved

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15437

Andre Miranda  changed:

   What|Removed |Added

 CC||wa...@mageia.org

--- Comment #1 from Andre Miranda  ---
*** Bug 15438 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15323] Thunar & plugins pages: install, dead links, dev URL

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15323

--- Comment #3 from Skunnyk  ---
You should have received a mail, and now have write access to
https://docs.xfce.org/ :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15357] Error building libxfce4util from tonights Xfce4 Git compile

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15357

Skunnyk  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs