[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 alexxcons changed: What|Removed |Added Version|Unspecified |git Assignee|xfce-bugs@xfce.org |a...@xfce.org Target Milestone|Xfce 4.14 |--- CC||e...@xfce.org, ||hj...@xfce.org, ||och...@xfce.org Component|General |General Product|Xfce4-session |Xfce4-power-manager -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #13 from alexxcons --- yes, I as well noticed no notification :/ ... I will add some notification and rename "do nothing" to "only notification". -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #12 from DarkTrick --- I'm glad this topic did not go silent. I didn't have time to check your fix, yet. So my following concerns might not be necessary. > So finally we decided to remove the feature "ask on critical power" feature > from xfce4-power-manager. If the feature is just removed, there is no other option for notifications ( at least not on my system). There is indeed a warning at 20% (?), but that's not choosable in any menu. I would at least add on option for a popup-notification, that might be spawned. > I am sorry for the trouble you had with building the patch now that you > know xfce4-session and gtk a bit It was a good first practice ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #11 from alexxcons --- Sorry for the long delay ... we did some testing of the xfce4-power-manager to reproduce the problem in detail and had some longer internal discussion what would be the best fix for it. Were I would have taken your fix in the beginning, other devs did not like the idea to change the keboard control behaviour of the logout dialog. In the end we agreed that it might be no good idea at all to popup an xfce4-session-logout dialog out of nowhere. ( E.g. If you are about to click something, this may as well end up in a undesired shutdown ) So finally we decided to remove the feature "ask on critical power" feature from xfce4-power-manager. There is already a Notification ( to be checked if it is a "critical" notification, so that it only disappears when acknowledged ) ... this should be sufficient to warn people on critical power level. I prepared a preleminary fix for xfce4-power-manager here: https://github.com/alexxcons/xfce4-power-manager/commits/master (I still need to verify if the said notification is critical, add the bug id to the commit message and test if it works fine if the old enum value is still active ) I am sorry for the trouble you had with building the patch now that you know xfce4-session and gtk a bit, possibly you are interested in taking a look into other bugs ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #10 from DarkTrick --- > Xfce4-power-manager may send a notification asking the user what to do when > the battery level is critical. Sending this notification is afaik the default setting. ( I can't remember changing it ) > AFAICT currently it's not so easy to mistakenly open the logout dialog, is it? > I mean that dialog only appears when the user means it. Based the the notification settings of Xfce4-power-manager, it does appear, when the user does not mean it. I understand that for the user who is always using power via an electrical outlet this is not a problem. However: - Mobile clients are in use with xubuntu (and might increase). - Mobile clients can run low on battery. - "show logout dialog" might be triggered without the user meaning it. ( Default or not shouldn't matter. It's configurable, so it should be safe) - "Accidental confirmation" might happen. Therefore I think it's necessary for a good user experience to supply a "safe" handling of the logout dialog. The current patch must not be the solution though. Others I can think of atm: - Focus cancel only, when triggered automatically (might be confusing because the same dialog has different behaviours) - Add a "are you sure" dialog for each option in die logout window. To be safe "no" would be the default selection here. - Make the dialog not accept user input within 1 second after appearing: Only, if triggered automatically. regards -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #9 from Andre Miranda --- (In reply to DarkTrick from comment #8) > > it is already fairly simple to dismiss the logout dialog, one just needs to > > press ESC > The point of this change is not make dismissing easier. It's to prevent > accidental "ok"s. AFAICT currently it's not so easy to mistakenly open the logout dialog, is it? > > one just needs to press ESC. > Like I stated before: If you're writing something you make heavy use of > "space" and "enter". You make almost no use of "esc". Therefore the > probability to accidentally hit "logout" is imo fairly high for a portable > office machine. > > With the first proposed change we end up with two easy ways to cancel and > > none to previously mentioned operations. > I would follow the "the default option should be the save option"-principle. Again, I don't see how the logout dialog would pop up when the user is writing, playing, browsing, etc. I mean that dialog only appears when the user means it. And when using the keyboard (alt+f4 when no window is focused), with the proposed patch, the user will need to move away from the "safe" option. > > The current notification issued by xfpm is more passive and less > > error-prone. > I don't understand this one. What do you "current notification" do you mean? Depending on the configuration, Xfce4-power-manager may send a notification asking the user what to do when the battery level is critical. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #8 from DarkTrick --- Thank you for your comment. > it is already fairly simple to dismiss the logout dialog, one just needs to > press ESC The point of this change is not make dismissing easier. It's to prevent accidental "ok"s. > one just needs to press ESC. Like I stated before: If you're writing something you make heavy use of "space" and "enter". You make almost no use of "esc". Therefore the probability to accidentally hit "logout" is imo fairly high for a portable office machine. > With the first proposed change we end up with two easy ways to cancel and > none to previously mentioned operations. I would follow the "the default option should be the save option"-principle. > The current notification issued by xfpm is more passive and less error-prone. I don't understand this one. What do you "current notification" do you mean? regards -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 Andre Miranda changed: What|Removed |Added CC||andre...@xfce.org --- Comment #7 from Andre Miranda --- Thanks for the patch, but I don't think the changeis for the better: keyboard-wise, it is already fairly simple to dismiss the logout dialog, one just needs to press ESC. It is also somewhat easy to logout/reboot/shutdown, one just needs to press 0/1/2 times to left and press enter/space. With the first proposed change we end up with two easy ways to cancel and none to previously mentioned operations. The focus on cancel button only makes sense with your second suggestion, yet it's very intrusive IMHO. The current notification issued by xfpm is more passive and less error-prone. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #6 from DarkTrick --- Looks fine to me. Thank you very much for the assistance! -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 alexxcons changed: What|Removed |Added Attachment #8317|0 |1 is obsolete|| Attachment #8322|0 |1 is obsolete|| --- Comment #5 from alexxcons --- Created attachment 8329 --> https://bugzilla.xfce.org/attachment.cgi?id=8329=edit patch > git format-patch creates a patch file about something I didn't change (chinese > translation) and ignores my actual changes. Therefore I used git diff. "git format patch HEAD -1" will turn the latest commit into a patch ... I guess you just forgot to first commit your changes. I added your Nick / mail to the patch and generated it with git. Is it fine for you like that ? I as well changed the comment style further, to match other multi-line comments ... sorry to be a bit pedantic ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #4 from DarkTrick --- Created attachment 8322 --> https://bugzilla.xfce.org/attachment.cgi?id=8322=edit Patch for selection "Cancel" button by default I changed the comment style. git format-patch creates a patch file about something I didn't change (chinese translation) and ignores my actual changes. Therefore I used git diff. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #3 from alexxcons --- Best create patches with git format-patch. Like that, the name and email you provided in git automatically will be added to the patch. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 alexxcons changed: What|Removed |Added CC||alexxc...@xfce.org --- Comment #2 from alexxcons --- Finally time to do some coding & testing :) Your patch works great for me, IMO no problem to get it applied to master. Just some cosmetics: /* Use this comment style */ + there are some whitespaces on the first comment line. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 --- Comment #1 from TheTrowsers --- Created attachment 8317 --> https://bugzilla.xfce.org/attachment.cgi?id=8317=edit Focusses Cancel button instead of Logout button This is a patch for preventing the accidental log out while writing on the keyboard. It will not prevent the case of accidentally click one of the buttons with the mouse. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 15158] Logout window focusses "Cancel" by default AND/OR add reaction time delay for usage
https://bugzilla.xfce.org/show_bug.cgi?id=15158 TheTrowsers changed: What|Removed |Added Summary|Logout window focusses |Logout window focusses |"Cancel" by default OR add |"Cancel" by default AND/OR |reaction time delay for |add reaction time delay for |usage |usage -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
