[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 alexxcons changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|xfce-bugs@xfce.org |alexxc...@xfce.org --- Comment #17 from alexxcons --- Created attachment 8658 --> https://bugzilla.xfce.org/attachment.cgi?id=8658&action=edit patch Attached a patch to fix the concrete bug .. the approach seems to work suprisingly well. Possibly it makes sense to use the same burst prevention for other "reload" triggers on other thunar components. I randomly picked a delay of 100ms. However burst prevention as well seems to work fine with 10ms, or only 1ms delay .. any preferences ? Would be great to have some more testers before I push this fix. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #16 from alexxcons --- Thanks for that hint ! Before going for a central reload queue, I'll see if I can find a more simple fix. My plan would be to add a minimal delay before doing a reload of a specific thunar-folder (via g_timeout_add). And after that delay, only the latest "reload trigger" is considered, so that burst-triggers only result in a single reload. .. will see if I can come up with some patch soon. (hopefully not breaking something else ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #15 from Harald Judt --- Last time I worked on thunar code, that reload stuff was a big mess and did not even work for jobs (copying, moving files). What makes it more complicated is that there are folder reloads and file reloads. I couldn't fix it completely, and if you change one part, it often breaks the other parts. I believe the proper solution would be to create a reload queue that gets processed regularly (e.g. while idle) and confined to a single place. That way, reloads could also be prioritized if necessary and perhaps unneeded/duplicate reloads could even be avoided (network accesses for example are quite expensive regarding performance). It could be more complicated than the current implementation, but the current implementation looks also complicated and is hard to understand, so maybe it doesn't matter. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #14 from alexxcons --- - Removing "thunar_folder_file_changed" is not an option, because like that, "mv test1 test2" in an open folder will not be recognized by thunar. - Removing only the if (G_UNLIKELY (folder->corresponding_file == file)) is as well bad, since this will cause many unnecesarry folder reloads. The Problem comes from "thunar_folder_reload" beeing executed repeatedly. Each reload stops a job and than starts a new job. A stopped, stopped/unfinished job may lead to: (thunar:2655): thunar-CRITICAL **: thunar_folder_finished: assertion 'folder->content_type_idle_id == 0' failed That will cause the view to dont update. ... to be further investigated -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #13 from alexxcons --- > removing the following if block helps: > https://git.xfce.org/xfce/thunar/tree/thunar/thunar-folder.c#n607 Good spot ! I can confirm that removing the block helps (= removing the whole method). A bit obscure: Removing just the "if" contition ( always executing "thunar_folder_reload") as well helps. I'll further investigate to understand whats going on here. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 Theo Linkspfeifer changed: What|Removed |Added CC||fatero...@gmail.com --- Comment #12 from Theo Linkspfeifer --- *** Bug 14704 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 Theo Linkspfeifer changed: What|Removed |Added CC||lastonestand...@tutanota.co ||m --- Comment #11 from Theo Linkspfeifer --- This pretty much always happens when moving two or more files via drag and drop from Thunar to the desktop. I tried to debug the issue and noticed that removing the following if block helps: https://git.xfce.org/xfce/thunar/tree/thunar/thunar-folder.c#n607 -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #10 from slumbergod --- I'm now using Thunar 1.82 in the Xubuntu test ppa. The bug is still present. In fact, it is worse if anything. There is ALWAYS a ghost file left after moving files. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #9 from alexxcons --- - create some empty files in some folder - move them out of the folder (either by cut + paste, or via drag & drop. will be the same result ) -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains
https://bugzilla.xfce.org/show_bug.cgi?id=13364 alexxcons changed: What|Removed |Added Summary|After moving files, a Ghost |After moving files, a Ghost |file sometimes remains in |file sometimes remains |Detail View | CC||alexxc...@xfce.org --- Comment #8 from alexxcons --- Can reproduce the problem. Happens for all views, not only detailed view. + -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains in Detail View
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #7 from slumbergod --- still present in thunar 1.8.2. It also happens when extracting an archive. The archive might extract a folder, then rename it the temporary one and you end up with an incorrectly named folder requiring a refresh to see the renamed one. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains in Detail View
https://bugzilla.xfce.org/show_bug.cgi?id=13364 BalTun changed: What|Removed |Added CC||iv...@mail.ru --- Comment #6 from BalTun --- still appears, XFCE 4.12 moving files. After moving in thunar source window shows one file that is still not moved. But actually it is moved and not exsist in source. Compact list view. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains in Detail View
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #5 from flocculant --- Created attachment 7048 --> https://bugzilla.xfce.org/attachment.cgi?id=7048&action=edit unrefreshed thunar At the point when I stopped zsync Thunar should show these files: zesty-desktop-amd64.iso zesty-desktop-amd64.iso.zs-old zesty-desktop-i386.iso zesty-desktop-i386.iso.part -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains in Detail View
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #4 from flocculant --- Compact view ... I've seen also where a file gets added to an already opened instance of thunar at the correct location - nothing is there until I reload. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains in Detail View
https://bugzilla.xfce.org/show_bug.cgi?id=13364 --- Comment #3 from slumbergod --- Actually, I forgot to add that I only use Detailed View and the bug is definitely present there. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains in Detail View
https://bugzilla.xfce.org/show_bug.cgi?id=13364 Will changed: What|Removed |Added CC||lightnin...@gmail.com --- Comment #2 from Will --- I have seen this using icon view. It is not consistently doing it though; sometimes it was fine, sometimes 1 or 2 files would remain visible. I guess it is a threading issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 13364] After moving files, a Ghost file sometimes remains in Detail View
https://bugzilla.xfce.org/show_bug.cgi?id=13364 flocculant changed: What|Removed |Added CC||floccul...@gmx.co.uk --- Comment #1 from flocculant --- Confirmed seeing this - in fact I moved a 'bunch' of files and all the moved files were apparently still in the source folder till reload -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
