[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

alexxcons  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #24 from alexxcons  ---
Found a fix \o/  ... and found out that this bug definitively is a duplicate of
12435
I added a patch there.

*** This bug has been marked as a duplicate of bug 12435 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #23 from alexxcons  ---
Possibly same bug than described in Bug 12435 and Bug 14288

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #22 from alexxcons  ---
Thanks, nice! Now I as well can reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

Andre Miranda  changed:

   What|Removed |Added

   Attachment #7592|0   |1
is obsolete||

--- Comment #21 from Andre Miranda  ---
Created attachment 7593
  --> https://bugzilla.xfce.org/attachment.cgi?id=7593=edit
test.tar.gz

Even simpler reproducer, no need to open inkscape.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #20 from Andre Miranda  ---
Created attachment 7592
  --> https://bugzilla.xfce.org/attachment.cgi?id=7592=edit
test.tar.gz

Thanks Jakub for the video, now I can reproduce the bug!
Alex, you won't need xfce4-places-plugin, just grab the attached tar and run
test.sh, pay attention to the instructions it outputs.
Also notice that this bug doesn't occur with Detailed List, you need to use
either Icons or Compact List and make sure it's using this sorting: View ->
Arrange Items -> Sort By Modification Date (Ascending).

The top of backtrace is:

#0  0x555b8f5a in thunar_list_model_get_value (model=0x55a960c0,
iter=, column=, value=0x7fffc6c0) at
thunar-list-model.c:683
#1  0x779ab4de in exo_icon_view_set_cell_data
(icon_view=icon_view@entry=0x55e2e330, item=item@entry=0x55bdd1e0) at
exo-icon-view.c:5390
#2  0x779aeb84 in exo_icon_view_paint_item
(icon_view=icon_view@entry=0x55e2e330, item=item@entry=0x55bdd1e0,
cr=cr@entry=0x55cf2000, x=155, y=7, draw_focus=1) at exo-icon-view.c:4115
#3  0x779b6e25 in exo_icon_view_draw (widget=0x55e2e330,
cr=0x55cf2000) at exo-icon-view.c:2039
#4  0x769bbc00 in  () at /usr/lib/libgtk-3.so.0
#5  0x7678fb2f in gtk_container_propagate_draw () at
/usr/lib/libgtk-3.so.0
#6  0x7678fc13 in  () at /usr/lib/libgtk-3.so.0
#7  0x768ea53e in  () at /usr/lib/libgtk-3.so.0
#8  0x76794e4d in  () at /usr/lib/libgtk-3.so.0
#9  0x76799c58 in  () at /usr/lib/libgtk-3.so.0
#10 0x768e8782 in  () at /usr/lib/libgtk-3.so.0
#11 0x555ea38c in thunar_standard_view_draw (widget=0x55dc7eb0,
cr=0x55cf2000) at thunar-standard-view.c:1114

The offending line (thunar-list-model.c:683) contains _thunar_assert
(THUNAR_IS_FILE (file)); So it suggests that the swapped files in status bar is
very likely related. It makes no difference if you refresh the view before
removing the pdf file. Needs more investigation...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #19 from alexxcons  ---
Gna, for unknown reason I cannot add the xfce4-places-plugin to my panel.

Installed it via apt-get, but it does not show if I select "add new element
...".

Looks like I first need to investigate this before I can try another attempt to
reproduce. O_o

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #18 from Jakub Jankiewicz  ---
Sorry about the delay, I've created a video that demonstrate the issue
http://jcubic.pl/Thunar-crash.ogv .

I've forget about one step. Before you save from Inkscape, you need to touch
the full.pdf file, so it will show last.

In video after save from inkscape the status bar for files show wrong files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #17 from Jakub Jankiewicz  ---
It happen every time, will try to create video later today.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #16 from Andre Miranda  ---
Alex, he means this panel plugin:
https://git.xfce.org/panel-plugins/xfce4-places-plugin

After half an hour, following your instructions to the letter and trying other
crazy stuff, no crash at all.
I even switched back to Thunar 1.6.13 to no avail.

I really appreciate your time and effort to report bugs, if it's not asking too
much, could you record a small video of your steps, perhaps we're missing one
little important detail. Just one more question, is this 100% reproducible? I
mean, it happens every time or once in a couple?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #14 from Jakub Jankiewicz  ---
My laptop break, it wont turn on, so I'm using right now old Xubuntu 17.04 with
my old laptop, but the issue is the same.  Only the time before Thunar crash is
longer. It freezes for few seconds and the crash.

Steps to reproduce:

1. Extract files from provided tar ball into test directory.
2. You need to have Places applet (I have translated to pl as Miejsca) included
in xfce panel
3. Open any directory (may be home) from Places applet and navigate to test
directory 
4. Set sorting by time
5. In terminal open test directory
6. execute cp jakub-jankiewicz-cv-full.pdf copy.pdf (so you will be able copy
it back in last step)
7. Open in Inkscape jakub-jankiewicz-cv.svg
8. Save as pdf jakub-jankiewicz-cv-page1.pdf
9. In terminal execute:

test -e jakub-jankiewicz-cv-full.pdf && rm jakub-jankiewicz-cv-full.pdf
cp copy.pdf jakub-jankiewicz-cv-full.pdf
touch jakub-jankiewicz-cv-full.pdf

cp and touch is only needed if you want to repeat it again, so you can remove
the file after you save that other file from inkscape.

The problem is that when you save from inkscape the files are swapped if you
click on  *full.pdf it show page1.pdf in status bar at the bottom.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #13 from alexxcons  ---
ummm .. this is getting a bit confused..
Maybe you can provide a detailed list of steps what exactly to do now ? (
simplest possible case to provoke crash )

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #12 from alexxcons  ---
Created attachment 7562
  --> https://bugzilla.xfce.org/attachment.cgi?id=7562=edit
places applet ?

This is the "Places applet" ?  Or is it something else ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #11 from Jakub Jankiewicz  ---
I've replaced pdfmerge with cp + touch and it also crash.

New info for directory to crash it need to be opened from places applet for
xfce panel. Because I've called:

Thunar . &
make

and it didn't crashed.

And it seems that it crash only for those windows that was open from same
window that was "linked" to the one opened from click in places, because I now
have one directory after crash (but I've got crash report  link in notification
abot crash of Thunar).

Maybe places create new Thunar process that's somehow different.

And I've notice one more thing I had 2 directories open and it didn't crashed
but when I closed them and open from places it crashed. And I had one crash
when I was saving in Inkscape before rm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #10 from alexxcons  ---
I am afraid you as well will need to build exo from source (same for debian)
and install it.

Did you manage to reproduce the bug with pdfunite instead of pdfmerge ? Can it
be replaced by something more simple, like "cp" for reproduce ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #9 from Jakub Jankiewicz  ---
The touch is working maybe it's related to Inkscape that do something
unexpected. See https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/1300398


I've tried to test on 1.17 and build from source but I can't find exo-2 on
Fedora only exo is is there and I've installed devel 64bit version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #8 from Andre Miranda  ---
I'm using Alex's Makefile due pdfunite and the following commands:

touch *.pdf && sleep 1 && make && sleep 1 && rm *full.pdf

I can't reproduce with neither Thunar from master nor 1.6.13. I'm using the
Detailed List view sorted by ascending Date Modified (i.e.
jakub-jankiewicz-cv-full.pdf is the last file).
Can you reproduce with those commands?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #7 from alexxcons  ---
Created attachment 7560
  --> https://bugzilla.xfce.org/attachment.cgi?id=7560=edit
modified makefile (pdfunite)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #6 from alexxcons  ---
Still no success .. however I had to do some modification to the makefile to
get it to run for me, since I have no glue from where to get "pdfmerge". I have
"pdfunite" which I quess does the same and comes with the package
"poppler-utils".
Could you take a try if this modification matters ? ... attached the modified
makefile

1. Open directory in Thunar
2. Sort by time
3. in terminal run make  ( use right-click - open terminal here ? )  ( First
delete jakub-jankiewicz-cv-full.pdf so that makefile does something ? )
4. open jakub-jankiewicz-cv.svg in Inkscape
5. save as jakub-jankiewicz-cv-page1.pdf
6. run rm jakub-jankiewicz-cv-full.pdf or make

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #5 from Jakub Jankiewicz  ---
Created attachment 7556
  --> https://bugzilla.xfce.org/attachment.cgi?id=7556=edit
Directory listing

Directory listing that make Thunar crash.

1. Open directory in Thunar
2. Sort by time
3. in terminal run make
4. open jakub-jankiewicz-cv.svg in Inkscape
5. save as jakub-jankiewicz-cv-page1.pdf
6. run rm jakub-jankiewicz-cv-full.pdf or make

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #4 from Jakub Jankiewicz  ---
Found more info, you need to sort directory by time and both files need to be
at the end so you first need to generate the file that you need to delete and
then save as pdf from inkscape.
Steps:

create file-delete.pdf
save-as file.pdf
delete file-deleted.pdf from terminal (the file-delete.pdf need to be generated
before you save as pdf)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

--- Comment #2 from alexxcons  ---
Err ... ok, I have to delete a different file, but still cannot reproduce:
1. Open folder in thunar
2. Open folder in terminal
3. Generate 2 pdf with e.g. gimp ( file1.pdf and file2.pdf ) and close gimp
4. Open inkscape --> save as --> select pdf --> overwrite file2.pdf 
5. In terminal: rm file1.pdf

Does the bug trigger for you with these steps ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

alexxcons  changed:

   What|Removed |Added

 CC||ac...@gmx.de

--- Comment #1 from alexxcons  ---
I cannot reproduce that for thunar-master.
Following steps done ( tried some variations):
1. Open folder in thunar
2. Open folder in terminal
3. Generate some pdf with e.g. gimp ( file.pdf )
4. Open inkscape --> save as --> select pdf --> overwrite file.pdf 
5. In terminal: rm file.pdf

Does the bug trigger for you with the exact steps I took ?  Or is the pdfmerge
somehow required ? ( Since you wrote thunar crashed already on "rm" )

> I can compile Thunar from git and see if this still happen in this version.
This would be great !

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs

[Xfce-bugs] [Bug 14173] Thunar Crashed with segfault when deleting file from terminal

[bugzilla-daemon]

https://bugzilla.xfce.org/show_bug.cgi?id=14173

Jakub Jankiewicz  changed:

   What|Removed |Added

 CC||jcu...@onet.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs