[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-24 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

--- Comment #4 from alexxcons  ---
ops, should use permalink instead of pointing to master which might change:
https://gitlab.gnome.org/GNOME/nautilus/blob/326fa60685f165ab74a09ac9c53f53a5b30fd66d/src/nautilus-file-operations.c#L5279

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

Andre Miranda  changed:

   What|Removed |Added

 CC||andre...@xfce.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

--- Comment #3 from alexxcons  ---

Just checked the nautilus code. No suprise, it as well uses "g_file_copy". Just
like thunar it does not make use of G_FILE_COPY_ALL_METADATA

However after copy, in nautilus there is a check  "handled_invalid_filename",
which possibly could make the difference:
https://gitlab.gnome.org/GNOME/nautilus/blob/master/src/nautilus-file-operations.c#L5279

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

--- Comment #2 from Myk  ---
> Possibly it would help to set G_FILE_COPY_ALL_METADATA as copy_flag. Could 
> you check if that helps ?

I'm not aware how to do that. and have not looked at the code at all. 

> Can you reproduce the problem as well with nautilus ? (There is the chance 
> that gvfs or google-gvfs is to blame )

Sorry, should have said that I tested using Nautilus, and it copies the files
across making the copied filename the G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME
instead of the ID. Using Nautilus, I do not experience the same problem, thus I
believe the issue is with Thunar, since both Thunar and Nautilus are using the
same GVFS libraries as far as I know.

I think the direction to maintain the attributes is within the GVFS filesystem,
perhaps? Thunar's internal representation of the file object should use the ID,
and that should be used when interacting with the GVFS remote system. But in
order to maintain the displayed filename when copying to a non-GVFS filesystem,
the display name needs to be used for the filename, since in local filesystems,
they are the same thing. I'm making some assumptions based on general knowledge
rather than any specific knowledge of GFile or Thunar code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 15447] Should use G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME as filename instead of ID when copying from GVFS mounted file systems

2019-05-23 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=15447

alexxcons  changed:

   What|Removed |Added

 CC||alexxc...@xfce.org

--- Comment #1 from alexxcons  ---
Thanks for reporting !

Thunar is using "g_file_copy" to copy files (See ttj_copy_file in
thunar-transfer-job.c)

Possibly it would help to set G_FILE_COPY_ALL_METADATA as copy_flag. Could you
check if that helps ?

I dont have time to test this myself in detail currently ... will put it on my
list (though my list already is very long).
If you can, please feel free to debug yourself !


I dont know if we should always copy all metadata .. to be checked what that
would mean.

Can you reproduce the problem as well with nautilus ? (There is the chance that
gvfs or google-gvfs is to blame )

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs