Re: [xml] The issue around LoadLibrary on Windows

2012-08-16 Thread Patrick Gansterer
Am 23.07.2012 um 16:23 schrieb Earnie Boyd: On Wed, May 23, 2012 at 8:30 AM, Patrick Gansterer wrote: On Wed, 23 May 2012 14:16:48 +0200, Bjoern Hoehrmann wrote: * Daniel Veillard wrote: C.f. the bug Fix windows unicode build https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the

Re: [xml] The issue around LoadLibrary on Windows

2012-07-23 Thread Patrick Gansterer
On Wed, 23 May 2012 14:16:48 +0200, Bjoern Hoehrmann wrote: * Daniel Veillard wrote: C.f. the bug Fix windows unicode build https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the previous discussions here: http://mail.gnome.org/archives/xml/2008-February/msg00094.html now that the

Re: [xml] The issue around LoadLibrary on Windows

2012-07-23 Thread Nikolay Sivov
On 7/23/2012 17:23, Earnie Boyd wrote: On Wed, May 23, 2012 at 8:30 AM, Patrick Gansterer wrote: On Wed, 23 May 2012 14:16:48 +0200, Bjoern Hoehrmann wrote: * Daniel Veillard wrote: C.f. the bug Fix windows unicode build https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the previous

Re: [xml] The issue around LoadLibrary on Windows

2012-07-23 Thread Earnie Boyd
On Mon, Jul 23, 2012 at 11:33 AM, Nikolay Sivov wrote: On 7/23/2012 17:23, Earnie Boyd wrote: How would that ignore the UNICODE work? Defining UNICODE will cause the API to do different things. This define only controls macros so if you want LoadLibraryW nothing stops you to use it

Re: [xml] The issue around LoadLibrary on Windows

2012-05-25 Thread Ralf Junker
On 25.05.2012 05:01, Daniel Veillard wrote: So I am tempted to take the patches using the A versions of the Windows entry point but mainly document xmlModuleOpen and xmlModuleSymbol that use of character in the given strings outside of ASCII will have undefined behaviour (optionally we could

Re: [xml] The issue around LoadLibrary on Windows

2012-05-25 Thread Daniel Veillard
On Fri, May 25, 2012 at 09:26:13AM +0200, Ralf Junker wrote: On 25.05.2012 05:01, Daniel Veillard wrote: So I am tempted to take the patches using the A versions of the Windows entry point but mainly document xmlModuleOpen and xmlModuleSymbol that use of character in the given strings

Re: [xml] The issue around LoadLibrary on Windows

2012-05-25 Thread Earnie Boyd
On Thu, May 24, 2012 at 11:01 PM, Daniel Veillard wrote: On Wed, May 23, 2012 at 05:41:35PM +0800, Daniel Veillard wrote:   C.f. the bug Fix windows unicode build   https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the previous discussions here:  

Re: [xml] The issue around LoadLibrary on Windows

2012-05-24 Thread Csaba Raduly
On Wed, May 23, 2012 at 8:58 PM, Michael Ludwig wrote: Csaba Raduly schrieb am 23.05.2012 um 14:34 (+0200): xmlModuleOpen and its worker, xmlModulePlatformOpen take a const char*, not const xmlChar*. This suggests that the parameter is not UTF-8, in which case libxml2 should just use

Re: [xml] The issue around LoadLibrary on Windows

2012-05-24 Thread Daniel Veillard
On Wed, May 23, 2012 at 05:41:35PM +0800, Daniel Veillard wrote: C.f. the bug Fix windows unicode build https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the previous discussions here: http://mail.gnome.org/archives/xml/2008-February/msg00094.html now that the release is done,

[xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Daniel Veillard
C.f. the bug Fix windows unicode build https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the previous discussions here: http://mail.gnome.org/archives/xml/2008-February/msg00094.html now that the release is done, can we have a final decision on this. As I understand it, LoadLibraryW

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Nikolay Sivov
On 5/23/2012 12:41, Daniel Veillard wrote: C.f. the bug Fix windows unicode build https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the previous discussions here: http://mail.gnome.org/archives/xml/2008-February/msg00094.html now that the release is done, can we have a final

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Peter Jacobi
There's no reason to use a macro, that's true. I don't see any indication that passed name argument is UTF-8 encoded, so I don't see what's a justification of UTF-8 - WCHAR If this is of any concern, LoadLibraryA interprets the 8-bit characters of the filename according to the user's

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Ralf Junker
I strongly believe that LoadLibraryW should be used for any Windows version that supports it. The SQLite OS layer for Win32 shows how this can be done. It converts UTF-8 to wchar_t* before calling the appropriate function Windows ...W functions. The code is in the public domain. Here is the link

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Nikolay Sivov
On 5/23/2012 14:19, Ralf Junker wrote: I strongly believe that LoadLibraryW should be used for any Windows version that supports it. Of course it should be preferred if you've got choice. The SQLite OS layer for Win32 shows how this can be done. It converts UTF-8 to wchar_t* before calling

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Ralf Junker
On 23.05.2012 14:26, Nikolay Sivov wrote: It's not a question how to use MultiByteToWideChar() to do UTF-8 - WCHAR, the question is does 'name' argument is UTF-8 string or not. By the way, is dlopen() supposed to work on UTF-8 input? I doubt so, and since xmlModuleOpen() has ifdef-ed version

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Nikolay Sivov
On 5/23/2012 14:44, Ralf Junker wrote: On 23.05.2012 14:26, Nikolay Sivov wrote: It's not a question how to use MultiByteToWideChar() to do UTF-8 - WCHAR, the question is does 'name' argument is UTF-8 string or not. By the way, is dlopen() supposed to work on UTF-8 input? I doubt so, and since

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Bjoern Hoehrmann
* Daniel Veillard wrote: C.f. the bug Fix windows unicode build https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the previous discussions here: http://mail.gnome.org/archives/xml/2008-February/msg00094.html now that the release is done, can we have a final decision on this. As I

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Csaba Raduly
Hi On Wed, May 23, 2012 at 2:16 PM, Bjoern Hoehrmann wrote: * Daniel Veillard wrote:  C.f. the bug Fix windows unicode build  https://bugzilla.gnome.org/show_bug.cgi?id=638650 and the previous discussions here:  http://mail.gnome.org/archives/xml/2008-February/msg00094.html now that the

Re: [xml] The issue around LoadLibrary on Windows

2012-05-23 Thread Ralf Junker
On 23.05.2012 15:07, Nikolay Sivov wrote: On 5/23/2012 14:44, Ralf Junker wrote: On 23.05.2012 14:26, Nikolay Sivov wrote: It's not a question how to use MultiByteToWideChar() to do UTF-8 - WCHAR, the question is does 'name' argument is UTF-8 string or not. By the way, is dlopen() supposed