Re: [xml] Entering freeze for release of libxml2-2.9.9

[Daniel Veillard via xml]

  Hi Mike,

On Thu, Dec 13, 2018 at 04:37:53PM -0500, Mike Dalessio wrote:
> Hi Daniel,
> 
> I'm curious if you have an updated release schedule for 2.9.9 final?
> 
> Thanks much for coordinating this release.
> 
> -m

  Sorry it's out now, between work, Xmas with familly haeading to my place
and a short trip, it got delayed,

Daniel

> 
> On Thu, Nov 29, 2018 at 4:58 PM Daniel Veillard via xml 
> wrote:
> 
> >   I pushed RC2 in git and pushed signed tarball and rpms to the usual
> > place:
> >
> >ftp://xmlsoft.org/libxml2
> >
> > we have a couple of issues which were raised against rc1 and not completely
> > solved, depending on how we resolve those and if no new ones pop-up I
> > will either push an rc3 around Monday or proceed to 2.9.9 release.
> >
> >   So please ocntinue to give it some testing,
> >
> >thanks everybody,
> >
> > Daniel
> >
> > --
> > Daniel Veillard  | Red Hat Developers Tools
> > http://developer.redhat.com/
> > veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> > http://veillard.com/ | virtualization library  http://libvirt.org/
> > ___
> > xml mailing list, project page  http://xmlsoft.org/
> > xml@gnome.org
> > https://mail.gnome.org/mailman/listinfo/xml
> >

-- 
Daniel Veillard  | Red Hat Developers Tools http://developer.redhat.com/
veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | virtualization library  http://libvirt.org/
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Stefan Behnel]

Nikolai Weibull schrieb am 24.12.18 um 12:00:
> Stefan Behnel, 2018-12-24 11:43:
>> Nick Wellnhofer schrieb am 19.12.18 um 17:02:
>>> On 30/11/2018 11:41, Nikolai Weibull via xml wrote:
 OK, now I understand why it was working in my copy of the repository and
 not yours. Something went wrong when you applied the patch, Daniel, as a
 line was elided. Here’s a fix. We want to include XML_RELAXNG_TEXT here
 as well, otherwise it won’t work. The second part of the patch below was
 just to reorder the types to be listed in alphabetical order, so you may
 certainly skip that.
>>>
>>> Stefan, can you confirm that Nikolai's patch fixes the lxml issue?
>>
>> Sorry for the silence, I wasn't aware that I had to do something. Problem
>> is, the patch that Nikolai sent doesn't apply for me.
> 
>> Nikolai, could you create a patch against the latest master that makes
>> relaxng.c the way you think it should be? (Or should have been in the first
>> place?) Please attach it rather than pasting it into a mail, to make sure
>> it passes without whitespace issues.
> 
> I just applied the patch (with patch < a.patch) without issue against
> master.  I’m attaching it as well so that you can try that.

With that patch applied, all tests in lxml pass again, and the stipped-down
test case as well. I also double-checked it by unapplying the patch, things
are still failing with the master branch and it's really just this change
that makes them work again.

Thanks, Nikolai!

Stefan
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nikolai Weibull via xml]

Hi!

Stefan Behnel, 2018-12-24 11:43:


Nick Wellnhofer schrieb am 19.12.18 um 17:02:

On 30/11/2018 11:41, Nikolai Weibull via xml wrote:
OK, now I understand why it was working in my copy of the 
repository and
not yours. Something went wrong when you applied the patch, 
Daniel, as a
line was elided. Here’s a fix. We want to include 
XML_RELAXNG_TEXT here
as well, otherwise it won’t work. The second part of the patch 
below was
just to reorder the types to be listed in alphabetical order, 
so you may

certainly skip that.


Stefan, can you confirm that Nikolai's patch fixes the lxml 
issue?


Sorry for the silence, I wasn't aware that I had to do 
something. Problem

is, the patch that Nikolai sent doesn't apply for me.


Nikolai, could you create a patch against the latest master that 
makes
relaxng.c the way you think it should be? (Or should have been 
in the first
place?) Please attach it rather than pasting it into a mail, to 
make sure

it passes without whitespace issues.


I just applied the patch (with patch < a.patch) without issue against master.  
I’m attaching it as well so that you can try that.--- ../libxml2/relaxng.c	2018-11-30 11:28:37.0 +0100
+++ relaxng.c	2018-11-30 11:25:54.0 +0100
@@ -4023,8 +4023,8 @@
 ((eora == 2) && ((cur->type == XML_RELAXNG_DATATYPE) ||
 	 (cur->type == XML_RELAXNG_ELEMENT) ||
 			 (cur->type == XML_RELAXNG_LIST) ||
+ (cur->type == XML_RELAXNG_TEXT) ||
 			 (cur->type == XML_RELAXNG_VALUE {
-
 if (ret == NULL) {
 max = 10;
 ret = (xmlRelaxNGDefinePtr *)
@@ -9285,9 +9285,9 @@
 return (1);
 } else if (((node->type == XML_TEXT_NODE) ||
 (node->type == XML_CDATA_SECTION_NODE)) &&
-   ((cur->type == XML_RELAXNG_TEXT) ||
-		(cur->type == XML_RELAXNG_DATATYPE) ||
+   ((cur->type == XML_RELAXNG_DATATYPE) ||
 		(cur->type == XML_RELAXNG_LIST) ||
+(cur->type == XML_RELAXNG_TEXT) ||
 (cur->type == XML_RELAXNG_VALUE))) {
 return (1);
 }


 Nikolai
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Stefan Behnel]

Nick Wellnhofer schrieb am 19.12.18 um 17:02:
> On 30/11/2018 11:41, Nikolai Weibull via xml wrote:
>> OK, now I understand why it was working in my copy of the repository and
>> not yours.  Something went wrong when you applied the patch, Daniel, as a
>> line was elided.  Here’s a fix.  We want to include XML_RELAXNG_TEXT here
>> as well, otherwise it won’t work. The second part of the patch below was
>> just to reorder the types to be listed in alphabetical order, so you may
>> certainly skip that.
> 
> Stefan, can you confirm that Nikolai's patch fixes the lxml issue?

Sorry for the silence, I wasn't aware that I had to do something. Problem
is, the patch that Nikolai sent doesn't apply for me.

Nikolai, could you create a patch against the latest master that makes
relaxng.c the way you think it should be? (Or should have been in the first
place?) Please attach it rather than pasting it into a mail, to make sure
it passes without whitespace issues.

Thanks!

Stefan
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 30/11/2018 11:41, Nikolai Weibull via xml wrote:
OK, now I understand why it was working in my copy of the repository and not 
yours.  Something went wrong when you applied the patch, Daniel, as a line was 
elided.  Here’s a fix.  We want to include XML_RELAXNG_TEXT here as well, 
otherwise it won’t work. The second part of the patch below was just to 
reorder the types to be listed in alphabetical order, so you may certainly 
skip that.


Stefan, can you confirm that Nikolai's patch fixes the lxml issue?

Nick

___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Mike Dalessio via xml]

Hi Daniel,

I'm curious if you have an updated release schedule for 2.9.9 final?

Thanks much for coordinating this release.

-m


On Thu, Nov 29, 2018 at 4:58 PM Daniel Veillard via xml 
wrote:

>   I pushed RC2 in git and pushed signed tarball and rpms to the usual
> place:
>
>ftp://xmlsoft.org/libxml2
>
> we have a couple of issues which were raised against rc1 and not completely
> solved, depending on how we resolve those and if no new ones pop-up I
> will either push an rc3 around Monday or proceed to 2.9.9 release.
>
>   So please ocntinue to give it some testing,
>
>thanks everybody,
>
> Daniel
>
> --
> Daniel Veillard  | Red Hat Developers Tools
> http://developer.redhat.com/
> veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> http://veillard.com/ | virtualization library  http://libvirt.org/
> ___
> xml mailing list, project page  http://xmlsoft.org/
> xml@gnome.org
> https://mail.gnome.org/mailman/listinfo/xml
>
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Mike Dalessio via xml]

Nokogiri (a Ruby wrapper around libxml2) went green with RC2. I'll keep
this github PR up to date as more RCs or the Final get released:
https://github.com/sparklemotion/nokogiri/pull/1824

On Thu, Nov 29, 2018 at 4:58 PM Daniel Veillard via xml 
wrote:

>   I pushed RC2 in git and pushed signed tarball and rpms to the usual
> place:
>
>ftp://xmlsoft.org/libxml2
>
> we have a couple of issues which were raised against rc1 and not completely
> solved, depending on how we resolve those and if no new ones pop-up I
> will either push an rc3 around Monday or proceed to 2.9.9 release.
>
>   So please ocntinue to give it some testing,
>
>thanks everybody,
>
> Daniel
>
> --
> Daniel Veillard  | Red Hat Developers Tools
> http://developer.redhat.com/
> veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> http://veillard.com/ | virtualization library  http://libvirt.org/
> ___
> xml mailing list, project page  http://xmlsoft.org/
> xml@gnome.org
> https://mail.gnome.org/mailman/listinfo/xml
>
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 29/11/2018 22:50, Daniel Veillard wrote:

On Fri, Nov 23, 2018 at 11:12:13PM +0100, Nick Wellnhofer wrote:

The function now claims to work without preparsed documents, so the
workaround isn't used. But apparently there's problem with the commit. I'm
CC'ing the author. If we can't get this fixed, let's revert.


I let you double check this post RC2, we can either delay or just revert,
tell me what you think,


I just reverted the commit:

https://gitlab.gnome.org/GNOME/libxml2/commit/6fc04d714a019cb3be351bc472f7a64a08f51008

Nick

___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nikolai Weibull via xml]

Hi!

OK, now I understand why it was working in my copy of the 
repository and not yours.  Something went wrong when you applied 
the patch, Daniel, as a line was elided.  Here’s a fix.  We want 
to include XML_RELAXNG_TEXT here as well, otherwise it won’t work. 
The second part of the patch below was just to reorder the types 
to be listed in alphabetical order, so you may certainly skip 
that.


I’m really sorry about the confusion this has caused.  It got a 
bit messy with provisional patches on the mailing list and merge 
requests on GitLab.  I’ll make sure to post proper patches on the 
mailing list in the future.


Thank you, Stefan, for reporting this and being so patient.

 Nikolai

--- ../libxml2/relaxng.c	2018-11-30 11:28:37.0 
   +0100

+++ relaxng.c   2018-11-30 11:25:54.0 +0100
@@ -4023,8 +4023,8 @@
((eora == 2) && ((cur->type == XML_RELAXNG_DATATYPE) 
||

 (cur->type == XML_RELAXNG_ELEMENT) ||
 (cur->type == XML_RELAXNG_LIST) ||
+ (cur->type == XML_RELAXNG_TEXT) ||
 (cur->type == XML_RELAXNG_VALUE {
-
if (ret == NULL) {
max = 10;
ret = (xmlRelaxNGDefinePtr *)
@@ -9285,9 +9285,9 @@
return (1);
} else if (((node->type == XML_TEXT_NODE) ||
(node->type == XML_CDATA_SECTION_NODE)) &&
-   ((cur->type == XML_RELAXNG_TEXT) ||
-   (cur->type == XML_RELAXNG_DATATYPE) ||
+   ((cur->type == XML_RELAXNG_DATATYPE) ||
(cur->type == XML_RELAXNG_LIST) ||
+(cur->type == XML_RELAXNG_TEXT) ||
(cur->type == XML_RELAXNG_VALUE))) {
return (1);
}

Stefan Behnel, 2018-11-30 08:48:


Daniel Veillard schrieb am 29.11.18 um 21:20:
On Mon, Nov 26, 2018 at 11:48:37AM +0100, Nikolai Weibull via 
xml wrote:

Stefan Behnel, 2018-11-25 15:37:

Nikolai Weibull schrieb am 24.11.18 um 00:12:
Yes, it seems that my patch for data in interleaves was 
added and
this may be the cause of these issues. The regression tests 
didn’t
display them, so this is something different. Could we 
perhaps get a

minimal test that breaks?


Here is what I could come up with so far. Since it's heavily 
stripped

down,
it probably isn't very reasonable anymore. The original 
schema is here:


https://raw.githubusercontent.com/lxml/lxml/82601a09d015bc3e7a4090223fcbb9a5d5d4590d/src/lxml/isoschematron/resources/rng/iso-schematron.rng

This is the direct file link now. I had attached the shortened 
test files here:


https://mail.gnome.org/archives/xml/2018-November/msg00023.html


Thank you!  As far as my tests go, with the patches that I’ve 
provided, this
validates without any issues.  I really hope we can get my 
patches from the

merge request into master so that this issue can be fixed.


  TBH it's weird it fails to validate for me with 2.9.8, with 
  2.9.9-rc1 and

with 2.9.9-rc1 with the data interleave patch reverted ...


I tried both lxml's test suite and my stripped down test files 
with 2.9.8
and the two RCs now, and all of them pass with 2.9.8, but fail 
with both

2.9.9-rc1 and 2.9.9-rc2.

I figured out how to build libxml2 from a git checkout now so 
that I could
bisect it. The bug was definitely introduced in c8e5f9588, which 
is

Nikolai's change from November 22nd.

I used

git bisect run bash -c "make clean && make &&
./xmllint --relaxng ../iso-schematron.rng 
../fail_schema.sch"


The change looks simple, but also a bit opaque to me. It could 
be that it's
related to the interleaving of optional tags/attributes and text 
somehow.

At least, that's what this part of the change might suggest:

-groups[nbgroups]->defs = xmlRelaxNGGetElements(ctxt, 
cur, 0);
+groups[nbgroups]->defs = xmlRelaxNGGetElements(ctxt, 
cur, 2);


And, in fact, changing that line in the latest master branch 
back to the
original "0" argument makes the validation pass for me. It 
probably also
reverts most of the intented behaviour that Nikolai wanted to 
achieve. :(


Stefan


___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Stefan Behnel]

Daniel Veillard schrieb am 29.11.18 um 21:20:
> On Mon, Nov 26, 2018 at 11:48:37AM +0100, Nikolai Weibull via xml wrote:
>> Stefan Behnel, 2018-11-25 15:37:
>>> Nikolai Weibull schrieb am 24.11.18 um 00:12:
 Yes, it seems that my patch for data in interleaves was added and
 this may be the cause of these issues. The regression tests didn’t
 display them, so this is something different. Could we perhaps get a
 minimal test that breaks?
>>
>>> Here is what I could come up with so far. Since it's heavily stripped
>>> down,
>>> it probably isn't very reasonable anymore. The original schema is here:

https://raw.githubusercontent.com/lxml/lxml/82601a09d015bc3e7a4090223fcbb9a5d5d4590d/src/lxml/isoschematron/resources/rng/iso-schematron.rng

This is the direct file link now. I had attached the shortened test files here:

https://mail.gnome.org/archives/xml/2018-November/msg00023.html


>> Thank you!  As far as my tests go, with the patches that I’ve provided, this
>> validates without any issues.  I really hope we can get my patches from the
>> merge request into master so that this issue can be fixed.
> 
>   TBH it's weird it fails to validate for me with 2.9.8, with 2.9.9-rc1 and
> with 2.9.9-rc1 with the data interleave patch reverted ...

I tried both lxml's test suite and my stripped down test files with 2.9.8
and the two RCs now, and all of them pass with 2.9.8, but fail with both
2.9.9-rc1 and 2.9.9-rc2.

I figured out how to build libxml2 from a git checkout now so that I could
bisect it. The bug was definitely introduced in c8e5f9588, which is
Nikolai's change from November 22nd.

I used

git bisect run bash -c "make clean && make &&
./xmllint --relaxng ../iso-schematron.rng ../fail_schema.sch"

The change looks simple, but also a bit opaque to me. It could be that it's
related to the interleaving of optional tags/attributes and text somehow.
At least, that's what this part of the change might suggest:

-groups[nbgroups]->defs = xmlRelaxNGGetElements(ctxt, cur, 0);
+groups[nbgroups]->defs = xmlRelaxNGGetElements(ctxt, cur, 2);

And, in fact, changing that line in the latest master branch back to the
original "0" argument makes the validation pass for me. It probably also
reverts most of the intented behaviour that Nikolai wanted to achieve. :(

Stefan
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Daniel Veillard via xml]

  I pushed RC2 in git and pushed signed tarball and rpms to the usual
place:

   ftp://xmlsoft.org/libxml2

we have a couple of issues which were raised against rc1 and not completely
solved, depending on how we resolve those and if no new ones pop-up I
will either push an rc3 around Monday or proceed to 2.9.9 release.

  So please ocntinue to give it some testing,

   thanks everybody,

Daniel

-- 
Daniel Veillard  | Red Hat Developers Tools http://developer.redhat.com/
veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | virtualization library  http://libvirt.org/
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Daniel Veillard via xml]

On Fri, Nov 23, 2018 at 11:12:13PM +0100, Nick Wellnhofer wrote:
> On 23/11/2018 22:38, Nick Wellnhofer wrote:
> > On 23/11/2018 20:51, Shlomi Fish wrote:
> > > I am getting a failure in one of the tests of
> > > https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8:
> > 
> > Can you check if it's caused by one of the following commits?
> 
> Nevermind, it's this commit:
> 
> https://gitlab.gnome.org/GNOME/libxml2/commit/bfec41b3de1cbd35e547b57c80ae3a5101f8891c
> 
> It seems that XML::LibXML implements its own workaround for
> xmlTextReaderNextSibling only being supported on preparsed documents:
> 
> https://github.com/shlomif/perl-XML-LibXML/blob/master/LibXML.xs#L8667
> 
> The function now claims to work without preparsed documents, so the
> workaround isn't used. But apparently there's problem with the commit. I'm
> CC'ing the author. If we can't get this fixed, let's revert.

  Nick,

I let you double check this post RC2, we can either delay or just revert,
tell me what you think,

Daniel

-- 
Daniel Veillard  | Red Hat Developers Tools http://developer.redhat.com/
veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | virtualization library  http://libvirt.org/
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Daniel Veillard via xml]

On Mon, Nov 26, 2018 at 11:48:37AM +0100, Nikolai Weibull via xml wrote:
> Hi!
> 
> Stefan Behnel, 2018-11-25 15:37:
> 
> > Nikolai Weibull schrieb am 24.11.18 um 00:12:
> 
> > > Yes, it seems that my patch for data in interleaves was added and
> > > this may be the cause of these issues. The regression tests didn’t
> > > display them, so this is something different. Could we perhaps get a
> > > minimal test that breaks?
> 
> > Here is what I could come up with so far. Since it's heavily stripped
> > down,
> > it probably isn't very reasonable anymore. The original schema is here:
> 
> Thank you!  As far as my tests go, with the patches that I’ve provided, this
> validates without any issues.  I really hope we can get my patches from the
> merge request into master so that this issue can be fixed.

  TBH it's weird it fails to validate for me with 2.9.8, with 2.9.9-rc1 and
with 2.9.9-rc1 with the data interleave patch reverted ...
I'm getting quite confused and starting to wonder if the schema I got
from github is correct (github interface serves me first ahn html page,
then I have to guess to use raw, to dwoload that and pray that it is actually
the data one is supposed to use.

---
thinkpad2:~/XML -> ./xmllint --relaxng iso-schematron.rng fail_to_validate.xml 

http://purl.oclc.org/dsdl/schematron;>
Open Model

 BBB element is not present
 CCC element is not present


fail_to_validate.xml:2: element title: Relax-NG validity error : Expecting 
element ns, got title
fail_to_validate.xml:1: element schema: Relax-NG validity error : Expecting an 
element ns, got nothing
fail_to_validate.xml:2: element title: Relax-NG validity error : Expecting 
element p, got title
fail_to_validate.xml:1: element schema: Relax-NG validity error : Expecting an 
element p, got nothing
fail_to_validate.xml:2: element title: Relax-NG validity error : Expecting 
element let, got title
fail_to_validate.xml:3: element rule: Relax-NG validity error : Invalid 
sequence in interleave
fail_to_validate.xml:3: element rule: Relax-NG validity error : Element schema 
failed to validate content
fail_to_validate.xml fails to validate
thinkpad2:~/XML -> 
---

  the "email patch" from gitlab seems to get me back to some sanity there,
it still makes it a mess to review and apply cleanly.

  The 4 patches looks sensible, seems to not introduce regression in existing
tests, the behaviour seems to be exactly the same with Stefan's tests so
I will assume that's unrelated or I didn't get the tests correctly.
I will push them to RC2 and if Stephan still has troubles with it can you please
send mail to the error case as attachments.

  thanks !

Daniel
   
-- 
Daniel Veillard  | Red Hat Developers Tools http://developer.redhat.com/
veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | virtualization library  http://libvirt.org/
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nikolai Weibull via xml]

Hi!

Stefan Behnel, 2018-11-25 15:37:


Nikolai Weibull schrieb am 24.11.18 um 00:12:


Yes, it seems that my patch for data in interleaves was added 
and this may be the cause of these issues. The regression tests 
didn’t display them, so this is something different. Could we 
perhaps get a minimal test that breaks?


Here is what I could come up with so far. Since it's heavily 
stripped down,
it probably isn't very reasonable anymore. The original schema 
is here:


Thank you!  As far as my tests go, with the patches that I’ve 
provided, this validates without any issues.  I really hope we can 
get my patches from the merge request into master so that this 
issue can be fixed.


 Nikolai
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Stefan Behnel]

Nikolai Weibull schrieb am 24.11.18 um 00:12:
> Yes, it seems that my patch for data in interleaves was added and this may
> be the cause of these issues.  The regression tests didn’t display them, so
> this is something different.  Could we perhaps get a minimal test that breaks?

Here is what I could come up with so far. Since it's heavily stripped down,
it probably isn't very reasonable anymore. The original schema is here:

https://github.com/lxml/lxml/blob/82601a09d015bc3e7a4090223fcbb9a5d5d4590d/src/lxml/isoschematron/resources/rng/iso-schematron.rng

If any of the "interleave" tags is removed or otherwise modified (as far as
I tried), it either validates (i.e. stops failing) or fails with a
different error than the one I was chasing. The validation succeeds in
xmllint 2.9.4 (and probably later versions), and fails in 2.9.9-rc1.

Does this help?

Stefan


iso-schematron.rng
Description: XML document
http://purl.oclc.org/dsdl/schematron;>
Open Model

 BBB element is not present
 CCC element is not present


___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Stefan Behnel]

Nikolai Weibull schrieb am 24.11.18 um 00:12:
> Yes, it seems that my patch for data in interleaves was added and this may
> be the cause of these issues.  The regression tests didn’t display them, so
> this is something different.  Could we perhaps get a minimal test that breaks?

It's a bit tricky to cut it down, but I'll try.

In any case, you can already reproduce it with the files I sent, maybe
there's something obvious that goes wrong.

Stefan
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Shlomi Fish]

On Fri, 23 Nov 2018 23:12:13 +0100
Nick Wellnhofer  wrote:

> On 23/11/2018 22:38, Nick Wellnhofer wrote:
> > On 23/11/2018 20:51, Shlomi Fish wrote:  
> >> I am getting a failure in one of the tests of
> >> https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8:  
> > 
> > Can you check if it's caused by one of the following commits?  
> 
> Nevermind, it's this commit:
> 
> https://gitlab.gnome.org/GNOME/libxml2/commit/bfec41b3de1cbd35e547b57c80ae3a5101f8891c
> 
> It seems that XML::LibXML implements its own workaround for 
> xmlTextReaderNextSibling only being supported on preparsed documents:
> 
> https://github.com/shlomif/perl-XML-LibXML/blob/master/LibXML.xs#L8667
> 
> The function now claims to work without preparsed documents, so the
> workaround isn't used. But apparently there's problem with the commit. I'm
> CC'ing the author. If we can't get this fixed, let's revert.
> 
> Nick

thanks for investigating!

-- 
-
Shlomi Fish   http://www.shlomifish.org/
http://www.shlomifish.org/humour/bits/facts/Emma-Watson/

Xena the warrior princess can meet King David for breakfast and Julius Caesar
for lunch. Without time travel.
— http://www.shlomifish.org/humour/bits/facts/Xena/

Please reply to list if it's a mailing list post - http://shlom.in/reply .
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 24/11/2018 14:01, Daniel Veillard via xml wrote:

  Nick there seems to be 7 merge requests, maybe we need to go though those
before I push an RC2,


https://gitlab.gnome.org/GNOME/libxml2/merge_requests/5

This should be kept externally, IMO.

https://gitlab.gnome.org/GNOME/libxml2/merge_requests/7

Also see the discussion in issue #2. I'd simply document that xmlInitGlobals 
shouldn't be called from application code.


https://gitlab.gnome.org/GNOME/libxml2/merge_requests/8

I added a hardcoded newline separator which should be enough for now.

https://gitlab.gnome.org/GNOME/libxml2/merge_requests/9

Should be discussed on this list first. Personally, I'm in favor of adding 
CMake support (as an option). In the long run, it could replace the weird 
Win32 build system with something more standard.


https://gitlab.gnome.org/GNOME/libxml2/merge_requests/10

That's Nikolas's merge request.

https://gitlab.gnome.org/GNOME/libxml2/merge_requests/11

Trivial.

https://gitlab.gnome.org/GNOME/libxml2/merge_requests/12

Looks good but I didn't have time to review properly.

Nick
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nikolai Weibull via xml]

Hi!

Daniel Veillard, 2018-11-24 14:01:


On Sat, Nov 24, 2018 at 12:14:06AM +0100, Nikolai Weibull wrote:



Daniel Veillard via xml, 2018-11-22 18:32:

>   I have just tagged the Release Candidate 1 in git and 
>   pushed a

> signed
> tarball and signed rpms to the usual place:

Could we please get merge request 10 into

https://gitlab.gnome.org/GNOME/libxml2/merge_requests/10


 Okay that looks different from the other patch for interleaves 
 I applied
earlier. Could you provide a little bit more description, seems 
it avoid
creating a choice child of a choice element among other things, 
correct ?


Yes, it is.  I did provide some documentation in the commits, see 
below.  They’re available in gitlab as well, but it’s not obvious 
how to show them (you press the … after the commit subject line). 
If you want more, I’ll try to expand on them.


0d0ad65b: Remove redefined starts and defines inside include 
elements


When including a grammar from another grammar, we need to make 
sure that any
redefines of starts and includes that that grammar does inside any 
of its

include elements are also removed.

4f5d2b9b: Allow choice within choice in nameClass in RELAX NG


The pattern nameClass allows for nested choice elements, for 
example


 
   
 
   a
   b
 
 c
   
 

which is semantically equivalent to

 
   
 a
 b
 c
   
 

The old code didn’t handle this correctly, as it never expected a 
choice inside
another choice.  This patch fixes this by flattening any nested 
choices.


This pattern of nested choice elements comes up in RELAX NG 
simplification,
where all choice elements are rewritten in this nested manner, see 
section 4.12

of the RELAX NG specification.

3cf2a68b: Look inside divs for starts and defines inside include

RELAX NG allows for div elements inside of include elements.  We 
need to look
inside those div elements for start and define elements that may 
be redefining

start and define elements in the included grammar.

this release?  It fixes various issues with the RELAX NG code 
and it even

has tests!


 I have never been fond of the github interface and it seems 
 gitlab is kind of mimicking it, In general I will fetch the raw 
 patch, make sure this applies to master and make sure all 
 commits are linear (c.f. from a gitk viewpoint).  Nick there 
 seems to be 7 merge requests, maybe we need to go though those 
 before I push an RC2,


Neither have I, I just saw that there were a bunch of merge 
requests already, so I figured that that was the way to go.  I’ll 
post to the mailing list in the future.  If you’d like for me to 
send the above patches to the mailing list instead, I’ll gladly do 
that as well.


   thanks for raising this Nikolai, and for your contributions 
   :-)


No problem, it has been fun.  I’ve got a couple of more minor 
patches, but I don’t know if I have time to get them out (or if I 
want to bother you with more patches right before release).

___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Daniel Veillard via xml]

On Sat, Nov 24, 2018 at 12:14:06AM +0100, Nikolai Weibull wrote:
> Hi!
> 
> Daniel Veillard via xml, 2018-11-22 18:32:
> 
> >   I have just tagged the Release Candidate 1 in git and pushed a
> > signed
> > tarball and signed rpms to the usual place:
> 
> Could we please get merge request 10 into
> 
> https://gitlab.gnome.org/GNOME/libxml2/merge_requests/10

 Okay that looks different from the other patch for interleaves I applied
earlier. Could you provide a little bit more description, seems it avoid
creating a choice child of a choice element among other things, correct ?

> this release?  It fixes various issues with the RELAX NG code and it even
> has tests!

 I have never been fond of the github interface and it seems gitlab is kind
of mimicking it, In general I will fetch the raw patch, make sure this applies
to master and make sure all commits are linear (c.f. from a gitk viewpoint).
 Nick there seems to be 7 merge requests, maybe we need to go though those
before I push an RC2,

   thanks for raising this Nikolai, and for your contributions :-)

Daniel

-- 
Daniel Veillard  | Red Hat Developers Tools http://developer.redhat.com/
veill...@redhat.com  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | virtualization library  http://libvirt.org/
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nikolai Weibull via xml]

Hi!

Daniel Veillard via xml, 2018-11-22 18:32:

  I have just tagged the Release Candidate 1 in git and pushed a 
  signed

tarball and signed rpms to the usual place:


Could we please get merge request 10 into 


https://gitlab.gnome.org/GNOME/libxml2/merge_requests/10

this release?  It fixes various issues with the RELAX NG code and 
it even has tests!


 Nikolai
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nikolai Weibull via xml]

Hi!

Stefan Behnel, 2018-11-23 21:54:


I think something changed in the RelaxNG code.


Yes, it seems that my patch for data in interleaves was added and 
this may be the cause of these issues.  The regression tests 
didn’t display them, so this is something different.  Could we 
perhaps get a minimal test that breaks?


 Nikolai
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Earnie via xml]

On 11/23/2018 1:11 PM, Nick Wellnhofer wrote:

On 22/11/2018 18:32, Daniel Veillard via xml wrote:
Please give it some testing, if we need to make changes I will likely 
push

an RC2 mid next week, and if everything goes well I will push 2.9.9 final
end of next week.


Built and tested (with `make check`) succesfully on:

- Windows 10
   - MingW64, gcc 7.2.0, both 64 and 32 bits (requires CFLAGS=-posix


I suggest that you test with gcc 8.x.x as well if possible.  I don't 
have version 8 as yet and no time to build it at the moment.


--
Earnie
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 23/11/2018 22:38, Nick Wellnhofer wrote:

On 23/11/2018 20:51, Shlomi Fish wrote:

I am getting a failure in one of the tests of
https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8:


Can you check if it's caused by one of the following commits?


Nevermind, it's this commit:

https://gitlab.gnome.org/GNOME/libxml2/commit/bfec41b3de1cbd35e547b57c80ae3a5101f8891c

It seems that XML::LibXML implements its own workaround for 
xmlTextReaderNextSibling only being supported on preparsed documents:


https://github.com/shlomif/perl-XML-LibXML/blob/master/LibXML.xs#L8667

The function now claims to work without preparsed documents, so the workaround 
isn't used. But apparently there's problem with the commit. I'm CC'ing the 
author. If we can't get this fixed, let's revert.


Nick
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 23/11/2018 20:51, Shlomi Fish wrote:

I am getting a failure in one of the tests of
https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8:


Can you check if it's caused by one of the following commits?

https://gitlab.gnome.org/GNOME/libxml2/commit/d2ef114c6b0d9a840b94cdecf554a873fc6f6df5
https://gitlab.gnome.org/GNOME/libxml2/commit/bfec41b3de1cbd35e547b57c80ae3a5101f8891c
https://gitlab.gnome.org/GNOME/libxml2/commit/39fbfb4fd08eae88d4b0c15f3a8ac33babc740e6

Thanks,
Nick
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Stefan Behnel]

Salut Daniel!

Daniel Veillard via xml schrieb am 22.11.18 um 18:32:
>   I have just tagged the Release Candidate 1 in git and pushed a signed
> tarball and signed rpms to the usual place:
> 
>   ftp://xmlsoft.org/libxml2/

I think something changed in the RelaxNG code. When I try to validate a
simple Schematron schema file (attached) against the schematron RNG spec here:

https://github.com/lxml/lxml/blob/82601a09d015bc3e7a4090223fcbb9a5d5d4590d/src/lxml/isoschematron/resources/rng/iso-schematron.rng

it validates in libxml2 2.9.4 (sorry, that's what I have installed, but I'm
pretty sure it also worked with at least 2.9.7 and probably also 2.9.8) but
fails in 2.9.9-rc1. I attached the output of both attempts.

Specifically, I get the following error, which seems nonsense, given that
"title" is the first child:

"""
-:3: element title: Relax-NG validity error : Expecting element p, got title
Relax-NG validity error : Extra element rule in interleave
"""

Something seems to be wrong with the interleave/group combination in the
schema, lines 56/61.

Any idea?

Stefan
$ xmllint --relaxng src/lxml/isoschematron/resources/rng/iso-schematron.rng - 


Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



EOF


http://purl.oclc.org/dsdl/schematron;>

Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



- validates

$ build/tmp/libxml2-2.9.9/xmllint --relaxng 
src/lxml/isoschematron/resources/rng/iso-schematron.rng - 

Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



EOF


http://purl.oclc.org/dsdl/schematron;>

Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



-:3: element title: Relax-NG validity error : Expecting element p, got title
Relax-NG validity error : Extra element rule in interleave
-:4: element rule: Relax-NG validity error : Element pattern failed to validate 
content
-:10: element title: Relax-NG validity error : Expecting element p, got title
Relax-NG validity error : Extra element rule in interleave
-:11: element rule: Relax-NG validity error : Element pattern failed to 
validate content
-:9: element pattern: Relax-NG validity error : Expecting element p, got pattern
Relax-NG validity error : Extra element pattern in interleave
-:9: element pattern: Relax-NG validity error : Element schema failed to 
validate content
- fails to validate
http://purl.oclc.org/dsdl/schematron;>

Open Model

 BBB element is not present
 CCC element is not present



Closed model"

 BBB element is not present
 CCC element is not present
There is an extra 
element



___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Shlomi Fish]

Hi,

On Thu, 22 Nov 2018 18:32:59 +0100
Daniel Veillard via xml  wrote:

>   I have just tagged the Release Candidate 1 in git and pushed a signed
> tarball and signed rpms to the usual place:
> 
>   ftp://xmlsoft.org/libxml2/
> 
> (also available as http://xmlsoft.org/download/)
> 

I am getting a failure in one of the tests of
https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8:

Test Summary Report
---
t/40reader.t (Wstat: 256 Tests: 100 Failed: 1)
  Failed test:  79
  Non-zero exit status: 1
Files=1, Tests=100,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.12 cusr  0.04 
csys =  0.21 CPU)
Result: FAIL
shlomif[XML-LibXML]:$trunk$ gvim s
shlomif[XML-LibXML]:$trunk$ prove -b t/40reader.t   
t/40reader.t .. 1/100 
#   Failed test 'preserved content'
#   at t/40reader.t line 184.
#  got: ' xx preserved yy FOO
#   
#   
#   '
# expected: 'preserved'
# Looks like you failed 1 test of 100.
t/40reader.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/100 subtests 

Test Summary Report
---
t/40reader.t (Wstat: 256 Tests: 100 Failed: 1)
  Failed test:  79
  Non-zero exit status: 1
Files=1, Tests=100,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.12 cusr  0.01 
csys =  0.17 CPU)
Result: FAIL
shlomif[XML-LibXML]:$trunk$ 



-- 
-
Shlomi Fish   http://www.shlomifish.org/
Selina Mandrake - The Slayer (Buffy parody) - http://shlom.in/selina

Sarah: Ken, would you like some more juice?
Ken: No, Sarah, that's OK, I’m stuffed. Anyway, I think I’ll return to my
dimension of evil now - they will be clueless without me. Thanks for everything.
— http://www.shlomifish.org/humour/Buffy/A-Few-Good-Slayers/

Please reply to list if it's a mailing list post - http://shlom.in/reply .
___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Re: [xml] Entering freeze for release of libxml2-2.9.9

[Nick Wellnhofer]

On 22/11/2018 18:32, Daniel Veillard via xml wrote:

Please give it some testing, if we need to make changes I will likely push
an RC2 mid next week, and if everything goes well I will push 2.9.9 final
end of next week.


Built and tested (with `make check`) succesfully on:

- Windows 10
  - MingW64, gcc 7.2.0, both 64 and 32 bits (requires CFLAGS=-posix
and PRINTF_EXPONENT_DIGITS=2 to make the XPath tests pass)
  - MSVC 14.11
- macOS 10.14 with stock command-line developer tools

Nick

___
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml