Re: [PATCH] Cygwin/X: Fix compilation for mandated XKB

2009-02-02 Thread Jon TURNEY
Peter Hutterer wrote: I think it'd be better to call XkbGetRulesDflts(g_winInfo.xkb); + memset(rmlvo, 0, sizeof(rmlvo)); arguably superfluous, since you set everything anyway. Good point. I'd failed to make g_winInfo.xkb a XkbRMLVOSet which fixes both your comments. Thanks for

[PATCH] Cygwin/X: Fix compilation for mandated XKB

2009-01-30 Thread Jon TURNEY
Fix a stray '}' Update to use RMLVO interface Remove g_winInfo.xkb.disable, can never be set since noXkbExtension has been removed Change to retrieve modifier key state using XkbStateFieldFromRec() from Colin Harrison Update to use XKB defaults from xkb-config.h Signed-off-by: Jon TURNEY

[PATCH] Cygwin/X: Fix compilation for mandated XKB

2009-01-30 Thread Colin Harrison
Hi, Looks OK by me. Thanks, Colin ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg

Re: [PATCH] Cygwin/X: Fix compilation for mandated XKB

2009-01-30 Thread Peter Hutterer
Two comments, see below. On Fri, Jan 30, 2009 at 02:23:45PM +, Jon TURNEY wrote: Fix a stray '}' Update to use RMLVO interface Remove g_winInfo.xkb.disable, can never be set since noXkbExtension has been removed Change to retrieve modifier key state using XkbStateFieldFromRec() from