Re: [PATCH 3/3] Xi: ask handlers before deletion of property.

2008-09-22 Thread Simon Thum
Peter Hutterer wrote: > Without the handler disallowing that, a client could potentially delete > properties that are "owned" by the server or a driver. Ooops, I thought you were keeping the fromClient bit internally. Now it makes much more sense :) Cheers, Simon ___

Re: [PATCH 3/3] Xi: ask handlers before deletion of property.

2008-09-22 Thread Peter Hutterer
On Mon, Sep 22, 2008 at 11:30:59AM +0200, Simon Thum wrote: >> -DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop) >> +DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop, >> + BOOL delete) >> { >> if (property == XIGetKnownProp

Re: [PATCH 3/3] Xi: ask handlers before deletion of property.

2008-09-22 Thread Simon Thum
Hi Peter, its good news you're done with that. A thing though: > -DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop) > +DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop, > + BOOL delete) > { > if (property == XIGetKnownProp

[PATCH 3/3] Xi: ask handlers before deletion of property.

2008-09-22 Thread Peter Hutterer
From: Peter Hutterer <[EMAIL PROTECTED]> Add "delete" parameter to SetProperty handler, handlers can refuse to delete a property by returning something other than Success. --- Xi/xiproperty.c| 20 ++-- dix/devices.c |6 +- include/exevents.h |3 ++- include/