Re: [PATCH xserver] os: Call FlushClient() before sending FD-passing messages

2018-04-09 Thread Giuseppe Bilotta
On Tue, Apr 10, 2018 at 5:14 AM, Keith Packard wrote: >> libxcb stores received file descriptors in the buffer of size 16 >> (XCB_MAX_PASS_FD). >> Whether it's possible that the X server will send more than 16 fds in a >> single reply >> and overflow the libxcb's buffer? > > It

Re: [PATCH xserver] os: Call FlushClient() before sending FD-passing messages

2018-04-09 Thread Keith Packard
Alexander Volkov writes: > libxcb stores received file descriptors in the buffer of size 16 > (XCB_MAX_PASS_FD). > Whether it's possible that the X server will send more than 16 fds in a > single reply > and overflow the libxcb's buffer? It wouldn't be if the X server

[ANNOUNCE] xf86-input-libinput 0.27.1

2018-04-09 Thread Peter Hutterer
Just one bugfix, a regression introduced by the new property handling in 0.27.0 caused the property to toggle left-handed to not be initialized on all devices that required it. Evangelos Foutras (1): Fix "left handed" property not set on all pointers Peter Hutterer (1):

[ANNOUNCE] xf86-input-libinput 0.27.1

2018-04-09 Thread Peter Hutterer
Just one bugfix, a regression introduced by the new property handling in 0.27.0 caused the property to toggle left-handed to not be initialized on all devices that required it. Evangelos Foutras (1): Fix "left handed" property not set on all pointers Peter Hutterer (1):

Re: [PATCH xserver] dix: always send focus event on grab change

2018-04-09 Thread Peter Hutterer
On Mon, Apr 09, 2018 at 02:35:30PM +0200, Samuel Thibault wrote: > Focus events are useless when 'from' and 'to' are the same. But when > this is the result of a (Un)GrabKeyboard request, we should always send > them, including when the window manager had previously used XSetInputFocus > to

Re: [PATCH xserver] hw/xwin/glx: Allocate fbconfigs correctly

2018-04-09 Thread Adam Jackson
On Tue, 2018-04-03 at 16:54 +0100, Jon Turney wrote: > 4b0a3cba fixed leaking of GLX fbconfigs, so now xwin needs to allocate them > correctly (individually, rather than all at once), so they can be freed > successfully. > > Signed-off-by: Jon Turney > Reviewed-by:

Re: [PATCH xserver] GLX: Fix a use after free error with the GLVND vendor handle.

2018-04-09 Thread Adam Jackson
On Fri, 2018-04-06 at 12:42 -0600, Kyle Brenneman wrote: > The GLVND layer will destroy all of the vendor handles at the end of each > server generation, but the GLX module then tries to re-use the same > (now-freed) > handle in xorgGlxServerInit at the start of the next generation. > > In

Unsupported locale errors in XOrg

2018-04-09 Thread Prashanth Chandra
Hello, I'm getting "unsupported locale" warnings and crashes when running programs such as xterm or dmenu on a clean install of Ubuntu 17.10 Examples: warning: no locale support Warning: locale not supported by Xlib, locale set to C Here's the offending line from dmenu's source code: if

Re: XRandr adaptive mirrored screens

2018-04-09 Thread Adam Jackson
On Mon, 2018-04-09 at 18:25 +0200, Prunk Dump wrote: > Is there a way to make Xorg mirror screens by default and choose > itself the best resolution ? Ideally a config file that I can deploy > in all my teacher's station. In the upcoming 1.20 release there is a feature for this, Option

XRandr adaptive mirrored screens

2018-04-09 Thread Prunk Dump
Hi Xorg Team ! I'm the network administrator of a French High school and I'm face of a new problem since the integration of XRandr in Debian Stretch. Many of my Debian Stretch stations are teacher's desktop. Each of them are connected to a screen and to an interactive projector. I would like

Re: [PATCH xserver] os: Call FlushClient() before sending FD-passing messages

2018-04-09 Thread Alexander Volkov
03.04.2018 21:57, Keith Packard пишет: Alexander Volkov writes: Yes, it would be easier to fix this in libxcb, but I believe that it would be more correct to do this in the X server. At least I want to try to fix the X server. Hrm. The problem is that there are two

Re: Dual monitor problem

2018-04-09 Thread Leslie Katz
Thank you to both Michal Srb and Marius Gedminas for taking the trouble to reply to my query and for their suggestions. I tried Michal's suggestion, but the same strange behaviour occurred on the laptop's display when the edited script ran without the external monitor plugged in. Marius's

[PATCH xserver] dix: always send focus event on grab change

2018-04-09 Thread Samuel Thibault
Focus events are useless when 'from' and 'to' are the same. But when this is the result of a (Un)GrabKeyboard request, we should always send them, including when the window manager had previously used XSetInputFocus to specify the focus on a window which happens to be now taking a grab. This is

Re: NotifyGrab

2018-04-09 Thread Samuel Thibault
Hello, I have kept the story below for the record and attached the testcase again in case it could be useful. So the issue is that DoFocusEvents does not send focus events if from == to, which happens here because the focus-grab.c is calling XSetInputFocus to set the input focus (as expected for

Re: Dual monitor problem

2018-04-09 Thread Marius Gedminas
On Sat, Apr 07, 2018 at 04:13:48PM -0500, Leslie Katz wrote: > I have a laptop that I usually connect to an external monitor. I use Ubuntu > 16.04 and Gnome 3.18.5. When I do connect to the external monitor, I like to > turn the laptop screen off. I can do that by going to System Settings, >

Re: [PATCH app/xdpyinfo v2] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

2018-04-09 Thread Giuseppe Bilotta
On Sun, Apr 8, 2018 at 8:25 PM, Pali Rohár wrote: > On Sunday 08 April 2018 19:22:28 Giuseppe Bilotta wrote: >> The values reported by xdpyinfo aren't bogus, they are what the core >> protocol is providing. > > For users as human readable output from xdpyinfo, those values

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

2018-04-09 Thread Mike Lothian
Switching between egl and glx can only be done these days by editing the kwinrc file (egl however is used by default on wayland I believe), egl was still enabled from years ago when switching was easy I've attached some coredumps on the bug, though I don't have any debugging compiled into the

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

2018-04-09 Thread Roman Gilg
On Sat, Apr 7, 2018 at 9:56 AM, Mike Lothian wrote: > Switching to glx from egl gets things started for me Do you mean switching from egl to glx as in switching the compositing backend? And it did not work with egl backend but with glx? The egl backend on X in KWin isn't

Re: [PATCH] revolve possible null pointer dereference issue found by cppcheck

2018-04-09 Thread Илья Шипицин
thank you. sorry for false positive 2018-04-09 12:43 GMT+05:00 Michal Srb : > On pondělí 9. dubna 2018 9:31:54 CEST Ilya Shipitsin wrote: > > [dix/inpututils.c:909] -> [dix/inpututils.c:905]: (warning) Either the > > condition 'if(list)' is redundant or there is possible null

Re: Dual monitor problem

2018-04-09 Thread Michal Srb
On sobota 7. dubna 2018 23:13:48 CEST Leslie Katz wrote: > I have a laptop that I usually connect to an external monitor. I use > Ubuntu 16.04 and Gnome 3.18.5. When I do connect to the external > monitor, I like to turn the laptop screen off. I can do that by going to > System Settings, Screen

Re: [PATCH] revolve possible null pointer dereference issue found by cppcheck

2018-04-09 Thread Michal Srb
On pondělí 9. dubna 2018 9:31:54 CEST Ilya Shipitsin wrote: > [dix/inpututils.c:909] -> [dix/inpututils.c:905]: (warning) Either the > condition 'if(list)' is redundant or there is possible null pointer > dereference: list. I think this is a false positive by cppcheck. It looks like it

[PATCH] revolve possible null pointer dereference issue found by cppcheck

2018-04-09 Thread Ilya Shipitsin
[dix/inpututils.c:909] -> [dix/inpututils.c:905]: (warning) Either the condition 'if(list)' is redundant or there is possible null pointer dereference: list. Signed-off-by: Ilya Shipitsin --- dix/inpututils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff