Re: [PATCH] xkb: fix turbo-repeat of RedirectKey-ed keysyms

Hi, On 14 September 2016 at 11:47, Daniel Stone <dani...@collabora.com> wrote: > RedirectKey() action had been broken by commit 2e6190. > A dropped check caused over-intense autorepeat of keysyms enriched > with the action. > > Previous to this commit, the check wrapped the

[PATCH] xkb: fix turbo-repeat of RedirectKey-ed keysyms

nction. Restore the checking. Signed-off-by: Mihail Konev <k@ya.ru> Reviewed-by: Daniel Stone <dani...@collabora.com> --- xkb/xkbActions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c index 048ed44..2ffd3fa 100644 ---

Re: [PATCH xserver 1/3] xwayland: Fix relinking when dix changes

by: Adam Jackson <a...@redhat.com> > > Anyone? Yeah. Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] xwayland: Plug memleak in frame callbacks

livier Fourdan <ofour...@redhat.com> Reviewed-by: Daniel Stone <dani...@collabora.com> ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] xkb: add a cause to the xkb indicator update after a keymap change

<peter.hutte...@who-t.net> Reviewed-by: Daniel Stone <dani...@collabora.com> ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] xwayland: Process queued events before making wayland mods effective

be to add an event we send down the mi event queue, which carried the modifier information and was processed with that. But, this works, so: Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Ar

Re: [PATCH RFC v2 xserver] xwayland-input: Fake crossing to rootwin

pretend that the > pointer entered the root window in this case so that the LeaveNotify > event is emitted. > > Signed-off-by: Olivier Fourdan <ofour...@redhat.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96437 I'm currently travelling so can't easily test

Re: [xserver-xorg][PATCH V2 1/1] xwayland-shm: block signals during fallocate

cheduler's SIGALRM. > > Changes since v1 - big comment in the code to explain what is going on > > Signed-off-by: Ian Ray <ian....@ge.com> Acked-by: Daniel Stone <dani...@collabora.com> ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH xserver v2] xwayland: Use the CLOCK_MONOTONIC clock

Hi, On 16 March 2016 at 08:11, Jonas Ådahl wrote: > @@ -180,6 +183,10 @@ extern _X_EXPORT void ListenOnOpenFD(int /* fd */ , int > /* noxauth */ ); > > extern _X_EXPORT Bool AddClientOnOpenFD(int /* fd */ ); > > +#ifdef MONOTONIC_CLOCK > +extern _X_EXPORT void

Re: [PATCH xserver] XMir DDX

Hi, On 5 May 2016 at 06:40, Peter Hutterer wrote: > On Fri, Apr 29, 2016 at 11:11:20AM +0200, Robert Ancell wrote: >> +for (i = 0; i < 3; ++i) { >> +MirPointerButton mir_button = map[i].mir_button; >> +int x_button = map[i].x_button; >> +int

Re: [PATCH xserver] xkb: after changing the keymap, force an indicator update

; Avoid this issue by forcing an SLI update after changing the keymap. This > updates the sli->effectiveState and thus restores everything to happy working > order. > > https://bugzilla.redhat.com/show_bug.cgi?id=1047151 > > Signed-off-by: Peter Hutterer <

Re: [PATCH xserver] xkb: fix SlowKeys release/reject beeps

Fix the mask to check for the >> correct enabled controls. >> >> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> > > ping? anyone? beeps are pretty exciting stuff, especially to review. I was just too excited to review it the first time around

Re: [PATCH xserver 2/2] kdrive: Squash a new unused variable warning

Hi, On 8 April 2016 at 16:48, Adam Jackson wrote: > keyboard.c:46:21: warning: ‘linux_to_x’ defined but not used ... just bin it? You've been adding way too much code lately. Cheers, daniel ___ xorg-devel@lists.x.org: X.Org

Re: ARMSOC X11 plugin issues

Hi, On 4 April 2016 at 11:45, Siarhei Siamashka wrote: > This really must be something new, because I don't remember anything > like this when skimming through the EULA back in 2013. Making the EULA > even more restrictive seems to contradict with the promise of Jem

Re: [PATCH xserver 2/4 v3] xwayland: add a server sync before repeating keys

Hi, On 9 March 2016 at 09:31, Olivier Fourdan wrote: > @@ -748,6 +783,9 @@ seat_handle_capabilities(void *data, struct wl_seat *seat, > ActivateDevice(xwl_seat->keyboard, TRUE); > } > EnableDevice(xwl_seat->keyboard, TRUE); > +master =

Re: [PATCH xserver] xwayland: do not include frequency in mode name

..@redhat.com> What a shame we can't yet legislate against stupidity. Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] xwayland: Make it possible to force CLOCK_MONOTONIC

ring HPET. I don't know if that still holds up on modern systems. > FWIW, I would be just as fine with always forcing CLOCK_MONOTONIC for Xwayland > if the command line argument seems unnecessary. This one is : Reviewed-by: Daniel Stone <dani...@collabora.com> and just forcing Xwayl

Re: [PATCH xserver 2/2] xwayland: add a server sync before repeating keys

Hi, On 8 March 2016 at 12:08, Olivier Fourdan <four...@gmail.com> wrote: > On 8 March 2016 at 13:06, Olivier Fourdan <four...@gmail.com> wrote: >> On 8 March 2016 at 12:59, Daniel Stone <dan...@fooishbar.org> wrote: >>> On 7 March 2016 at 17:45, Olivier

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 8 March 2016 at 12:07, Pekka Paalanen wrote: > If one justification for server-side repeat is that if the compositor > is hosed and the user cannot see how many characters have been > repeated, then you could as well solve that in the client too, by > throttling your

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 8 March 2016 at 09:15, Pekka Paalanen wrote: > On Mon, 7 Mar 2016 19:25:54 +0100 > Hans de Goede wrote: >> On 07-03-16 19:23, Hans de Goede wrote: >> > On 07-03-16 18:44, Olivier Fourdan wrote: >> > Why not simply rely on the keyrepeat of the

Re: [PATCH xserver 2/2] xwayland: add a server sync before repeating keys

Hi, On 7 March 2016 at 17:45, Olivier Fourdan wrote: > Key repeat is handled by the X server, but input events need to be > processed and forwarded by the Wayland compositor first. > > Make sure the Wayland compositor is actually processing events, to > avoid repeating keys

[PATCH v2] Add hybrid full-size/empty-clip mode to SetRootClip

to work correctly, but keep the clip emptied so exposures are never generated. Signed-off-by: Daniel Stone <dani...@collabora.com> Tested-by: Olivier Fourdan <ofour...@redhat.com> Cc: Adam Jackson <a...@redhat.com> --- v2: - Renamed enum values for aesthetic purity - Better commen

Re: [PATCH] xwayland: Use drm buffers for cursors if available

On 10 February 2016 at 17:08, Kristian Høgsberg wrote: > On Wed, Feb 10, 2016 at 7:39 AM, Emil Velikov > wrote: >> On 5 February 2016 at 08:42, Pekka Paalanen wrote: >> >>> umm, do we really want to add even more uses of the

Re: [PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

Hi Olivier, On 8 February 2016 at 16:00, Olivier Fourdan wrote: >> Tested by starting with a single output, manually checking >> screenInfo.screens[0]->root->{winSize,borderSize,borderClip,clipList} >> with gdb, hotplugging an output, verifying the regions again and also >>

[PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

to work correctly, but keep the clip emptied so exposures are never generated. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Olivier Fourdan <ofour...@redhat.com> Cc: Adam Jackson <a...@redhat.com> --- dix/window.c | 18 -- hw/xwayland/xway

[PATCH] Add hybrid full-size/empty-clip mode to SetRootClip

tion info / XRandR. This patch introduces a hybrid mode, where we update winSize and borderSize for the root window, enabling sprite confinement to work correctly, but keep the clip emptied so exposures are never generated. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Olivier Fourdan

Re: [PATCH] xwayland: Clear pending cursor frame callbacks on pointer enter

can > continue submitting new cursor frames. > > Signed-off-by: Rui Matos <tiagoma...@gmail.com> Ah, that explains a lot ... thanks Rui! Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.o

Re: [PATCH libX11] XKB: fix XkbGetKeyboardByName with Xming server

UnlockDisplay(dpy); > SyncHandle(); > return xkb; This case seems like it shouldn't return success, but instead jump to BAILOUT; if there's extra unconsumed data, either the server is broken, or we've missed something. With that fixed: Reviewed-by: Daniel Stone <dani...

Re: [PATCH libX11 v2] XKB: fix XkbGetKeyboardByName with Xming server

cause of the issue and Adam Jackson <a...@redhat.com> for helping > with the analysis! > > Signed-off-by: Olivier Fourdan <ofour...@redhat.com> Reviewed-by: Daniel Stone <dani...@collabora.com> ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] sync: Don't allow creating a system counter before sync is initialized

oked f937c3d501. I'm 100% sure it's a thing I saw happen in real life (maybe with IDLETIME?), but maybe it's no a longer a thing with the Xext rework. Either way, a problem which should be solved another way: Acked-by: Daniel Stone <dani...@collabora.co

Re: [PATCH v3 06/10] kdrive: add options to set default XKB properties

Hi, On 4 December 2015 at 11:37, Laércio de Sousa wrote: > 2015-04-05 3:22 GMT-03:00 Jeremy Huddleston Sequoia : >> While you're at it, would you mind updating Xephyr to support matching the >> parent server's keyboard layout (similar

Re: [PATCH v2 0/4] XWayland: Support key focus array correctly

On 24 November 2015 at 01:42, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Nov 20, 2015 at 03:37:27PM +0000, Daniel Stone wrote: >> This aims to support the XWayland equivalent of KeymapNotify correctly, >> in particular fixing Alt-Tab. Without this pa

[PATCH v2 0/4] XWayland: Support key focus array correctly

Hi, One year later, a follow-up to: http://lists.x.org/archives/xorg-devel/2014-November/044627.html This aims to support the XWayland equivalent of KeymapNotify correctly, in particular fixing Alt-Tab. Without this patch, when you Alt-Tab to an XWayland client, it receives Alt as a fully-fledged

[PATCH v2 3/4] Input: Add focus-in event source

Add a new event source type for keypress events synthesised from focus notifications (e.g. KeymapNotify from the parent server, when running nested). This is used to keep the keys-down array in sync with the host server's, without sending actual keypress events to clients. Signed-off-by: Daniel

[PATCH v2 1/4] XKB: Split filter execution into a separate function

Move the giant state machine which maps from a key action to actually running the filters into a separate function, to be used when adding KeyFocusIn. Signed-off-by: Daniel Stone <dani...@collabora.com> Tested-by: Giulio Camuffo <giuliocamu...@gmail.com> Reviewed-by: Peter Hutterer

[PATCH v2 2/4] Input: Add DeviceEventSource enum

Add a flag to DeviceEvents, giving the source of the event. Currently this only supports a 'normal' flag, but will be used later to add a 'focus-in' flag, noting events synthesised from key/button arrays on focus-in notifications. Signed-off-by: Daniel Stone <dani...@collabora.com> --

[PATCH v2 4/4] XWayland: Use FocusIn events for keyboard enter

-by: Daniel Stone <dani...@collabora.com> --- hw/xwayland/xwayland-input.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) v2: Unchanged. diff --git a/hw/xwayland/xwayland-input.c b/hw/xwayland/xwayland-input.c index 0515eb9..473f306 100644 --- a/hw/xwayland/xwayland-input.c ++

Re: [PATCH xwayland 1/2] xwayland: Update actual screen and root window size on output hot plug

rom the earlier iteration though, is that for me, I was seeing this being called when xwl_screen->screen is NULL, thus a segfault on startup. Are you not seeing the same? Assuming this is tested and working, then for the series: Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/3] Input: Add KeyFocusIn internal event

Hi, On 28 November 2014 at 06:02, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Nov 24, 2014 at 10:17:33PM +0000, Daniel Stone wrote: >> diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c >> index c6cbf56..c075115 100644 >> --- a/xkb/xkbActions.c >> +++

Re: [PATCH 1/2] xwayland: Don't (double) destroy RANDR resources in CloseScreen

Jackson a...@redhat.com Reviewed-by: Daniel Stone dani...@collabora.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/2] xwayland: Don't (double) destroy input resources in CloseScreen

) by 0x430246: CloseDownDevices (devices.c:1047) by 0x43E3EB: dix_main (main.c:333) by 0x30D70206FF: (below main) (libc-start.c:289) Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Daniel Stone dani...@collabora.com Cheers, Daniel

Re: [PATCH] xwayland: Throttle our cursor surface updates with a frame callback

is the right thing to do. Signed-off-by: Rui Matos tiagoma...@gmail.com Thanks! Reviewed-by: Daniel Stone dani...@collabora.com Keith, please pull. Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PATCH xwayland] xwayland: Throttle our cursor surface updates with a frame callback

Hi, On 25 May 2015 at 20:15, Rui Matos tiagoma...@gmail.com wrote: In some extreme cases with animated cursors at a high frame rate we could end up filling the wl_display outgoing buffer and end up with wl_display_flush() failing. In any case, using the frame callback to throttle ourselves

Re: [PATCH] xwayland: Fix error strings

On 6 May 2015 at 04:07, Robert Ancell robert.anc...@canonical.com wrote: Fix missing newlines from error string and fix grammar. Thanks Robert. Keith, please merge directly: Reviewed-by: Daniel Stone dani...@collabora.com Cheers, Daniel Signed-off-by: Robert Ancell robert.anc...@canonical.com

Re: [PATCH v2 10/17] Convert XKB to new *allocarray functions

suddenly becomes unsafe. My brain started leaking out my face halfway through reviewing this diff though, and auditing all sz/num users would be a bit of a nightmare. So, on the grounds that this makes things better rather than in any way worse: Acked-by: Daniel Stone dani...@collabora.com Cheers

Re: [PATCH] HideCursor/ShowCursor: Fix the interpretation of the window argument

would likely break existing code, and the main usage of this protocol (magnifiers) only needs the global behavior, so change the protocol to document the actual behavior. Yeah, have bumped up against that before in Clutter. Reviewed-by: Daniel Stone dani...@collabora.com Cheers, Daniel

Re: [PATCH] xwayland-input: Remove our XYToWindow handler

On 23 February 2015 at 15:40, Daniel Stone dan...@fooishbar.org wrote: On 21 February 2015 at 19:53, Jasper St. Pierre jstpie...@mecheye.net wrote: This was built as a hack for simple Wayland compositors like Weston which were lazy and didn't want to configure windows server-side when moved

Re: [PATCH 02/17] Let calloc handle multiplication

Hi, On 1 April 2015 at 10:18, walter harms wha...@bfs.de wrote: what is the strategy here ? xnfcalloc never fails, but exits on OOM conditions. other function return BADALLOC. You said it - 'never fails'. That's what the nf stands for. Cheers, Daniel

Re: [PATCH] kbproto: Fix typo in XkbSARedirectSetVMods

Hi, On 9 March 2015 at 19:13, wetts...@gmail.com wrote: An apparent copy/paste bug in the macro XkbSARedirectSetVMods, which breaks using RedirectKey actions with virtual modifiers. Signed-off-by: Andreas Wettstein wetts...@gmail.com Reviewed-by: Daniel Stone dani...@collabora.com Cheers

Re: [PATCH] symbols: Fix sdksyms.sh to cope with gcc5

on Fedora 22. Tested-by: Daniel Stone dani...@collabora.com Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH:xf86-video-mga] Fix pointer cast warning.

Hi, On 25 February 2015 at 10:31, Tormod Volden lists.tor...@gmail.com wrote: On Tue, Feb 24, 2015 at 7:36 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: This code makes no sense to me. exaGetPixmapFirstPixel() returns a pixel value. Interpreting that as a pointer to the first pixel must

Re: [PATCH] xwayland-input: Remove our XYToWindow handler

with both Weston and Mutter and neither of them require any changes, and it fixes comboboxes and menus. If somebody then wants to revert 73698d4, that's fine by me, so we reduce the amount of API that DDXen have. Signed-off-by: Jasper St. Pierre jstpie...@mecheye.net Acked-by: Daniel Stone dani

Re: [PATCH] xwayland-input: Don't assume all input is children of the focused window

Hi, On 20 February 2015 at 09:47, Olivier Fourdan ofour...@redhat.com wrote: It works, as long as the window is not moved, as soon as the toplevel window is moved, the translated coordinates seem correct but the window returned by miSpriteTrace() is not, e.g. I get the mutter guard window

Re: [Mesa-dev] Implement GLX_EXT_buffer_age for DRI2

Hi, On 20 January 2015 at 21:49, Dave Airlie airl...@gmail.com wrote: On 19 January 2015 at 21:00, Chris Wilson ch...@chris-wilson.co.uk wrote: In order to suport GLX_EXT_buffer_age in DRI2, we need to pass back the last swap buffer count that the back buffer was defined for. For simplicity,

Re: Migrating away from using cpp for startx and xinitrc in xinit

Hi, On Tuesday, February 10, 2015, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: It seems that using cpp for startx and xinitrc in the xinit port is coming back to bite us now as different C preprocessors don't exactly process non-C files in ways that we might want.

Re: [PATCH 4/4] Check for __linux__ instead of linux during compilation

libpciaccess On 6 February 2015 at 17:49, Jasper St. Pierre jstpie...@mecheye.net wrote: What project is this for? There's no src/common_init.c in Xorg, of course. On Fri, Feb 6, 2015 at 9:29 AM, Emil Velikov emil.l.veli...@gmail.com wrote: From: Eero Tamminen eero.t.tammi...@intel.com

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

Hi, On 17 December 2014 at 02:33, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Dec 16, 2014 at 08:15:31AM +, Daniel Stone wrote: Are you sure this is right? Won't this change it from returning root_[xy] with current MD pointer co-ordinates to nothing/rubbish? no, this actually

Re: [PATCH libXt] asprintf needs _GNU_SOURCE on some platforms

Hi, On 26 January 2015 at 16:51, Rob Clark robdcl...@gmail.com wrote: diff --git a/configure.ac b/configure.ac index 3633ec6..e60e88d 100644 --- a/configure.ac +++ b/configure.ac @@ -66,7 +66,7 @@ fi AC_SUBST([CC_FOR_BUILD]) DEFAULT_CPPFLAGS_FOR_BUILD=${CPPFLAGS}

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

Hi, On 16 December 2014 at 04:43, Peter Hutterer peter.hutte...@who-t.net wrote: @@ -1157,18 +1139,6 @@ GetKeyboardEvents(InternalEvent *events, DeviceIntPtr pDev, int type, set_key_up(pDev, key_code, KEY_POSTED); } -clipValuators(pDev, mask); - -set_valuators(pDev,

Re: [PATCH] dix: offset touch root coordinates by ScreenRec origins (#86655)

Hi, On 11 December 2014 at 22:29, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Dec 11, 2014 at 11:51:58AM -0800, Keith Packard wrote: GetKeyboardEvents, GetDixTouchEnd also call event_set_root_coordinates without adjusting the device coordinates. Are those also wrong?

Re: [PATCH] os/xsha1.c: Add license and copyright attribution.

Hi, On Thursday, December 11, 2014, Carl Worth cwo...@cworth.org wrote: I'm interested in copying this code to the mesa project, but before doing that it seems prudent to have the license and copyright attributions in place before copying that. Please use the standard-form license statement

Re: [PATCH 3/3] XWayland: Use FocusIn events for keyboard enter

Hi, On 28 November 2014 at 06:09, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 25, 2014 at 09:30:59PM +, Daniel Stone wrote: On 25 November 2014 at 02:38, Keith Packard kei...@keithp.com wrote: Yeah, I'm fine with figuring out how to make it perfect; if the above patch

Re: [PATCH 2/3] Input: Add KeyFocusIn internal event

Hi, On 28 November 2014 at 06:02, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Nov 24, 2014 at 10:17:33PM +, Daniel Stone wrote: diff --git a/Xi/exevents.c b/Xi/exevents.c index b0bc47e..cd2924a 100644 --- a/Xi/exevents.c +++ b/Xi/exevents.c @@ -810,6 +810,7

Re: [PATCH 3/3] XWayland: Use FocusIn events for keyboard enter

Hi, On 25 November 2014 at 02:38, Keith Packard kei...@keithp.com wrote: Daniel Stone dan...@fooishbar.org writes: Because that's still a bunch of work, I think it's just: -wl_array_for_each(k, xwl_seat-keys) -QueueKeyboardEvents(xwl_seat-keyboard, KeyPress, *k + 8, mask

[PATCH 0/3] XWayland: Support focus key array correctly

Hi, This one has a pretty long and tortured history, beginning with: https://bugzilla.gnome.org/show_bug.cgi?id=727178 and culminating in: http://lists.freedesktop.org/archives/wayland-devel/2014-November/018268.html and the related thread. The tl;dr for those of you not wishing to read an

[PATCH 2/3] Input: Add KeyFocusIn internal event

will produce different results to AltGr→Shift. In this case, we need to lift the _actual_ modifier state from the parent server, however this is a much larger job. Signed-off-by: Daniel Stone dani...@collabora.com Tested-by: Giulio Camuffo giuliocamu...@gmail.com --- Xi/exevents.c | 8

[PATCH 3/3] XWayland: Use FocusIn events for keyboard enter

-by: Daniel Stone dani...@collabora.com Tested-by: Giulio Camuffo giuliocamu...@gmail.com --- hw/xwayland/xwayland-input.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/xwayland/xwayland-input.c b/hw/xwayland/xwayland-input.c index b8c543c..c6a9c43 100644 --- a/hw/xwayland

[PATCH 1/3] XKB: Split filter execution into a separate function

Move the giant state machine which maps from a key action to actually running the filters into a separate function, to be used when adding KeyFocusIn. Signed-off-by: Daniel Stone dani...@collabora.com Tested-by: Giulio Camuffo giuliocamu...@gmail.com --- xkb/xkbActions.c | 144

Re: [PATCH 3/3] XWayland: Use FocusIn events for keyboard enter

Hi, On 25 Nov 2014, at 12:34 am, Keith Packard kei...@keithp.com wrote: Daniel Stone dani...@collabora.com writes: wl_keyboard::enter is the equivalent of FocusIn + KeymapNotify: it notifies us that the surface/window has now received the focus, and provides us a set of keys which

Re: tile property contents

Hi, On 15 October 2014 10:29, Thierry Reding thierry.red...@gmail.com wrote: Just for my understanding, is it typical for each of these panels to be standalone (own housing, ...) or are there monitors that actually take two connectors and each of them drives a different part of the same

Re: [PATCH] xf86xv.h cannot be included without first including xorg-server.h.

server ABI. Not including xorg-server.h first is terminally broken; this is just one symptom. Stefan: Reviewed-by: Daniel Stone dani...@collabora.com Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH] vmmouse_client.h: Include xorg-server.h before xf86_OSproc.h

xorg-server.h), causing os.h to redefine it. Signed-off-by: Stefan Dirsch sndir...@suse.de Reviewed-by: Daniel Stone dani...@collabora.com (But I do wish these wrappers weren't part of the public API ... !) Cheers, Daniel ___ xorg-devel@lists.x.org

Re: [PATCH 08/19] xfree86: Remove xv clip notify driver hook

colourkeying. Since no-one else has made such hardware purchasing (and/or life, having written that DDX support): Reviewed-by: Daniel Stone dani...@collabora.com -d On 25 September 2014 23:35, Eric Anholt e...@anholt.net wrote: Adam Jackson a...@redhat.com writes: Nothing's using it. Reviewed

Re: [PATCH 03/19] input: Remove unused SetKeySymsMap

, and meticulously kept them both in sync. That was a terrible idea, so we no longer do that. Reviewed-by: Daniel Stone dani...@collabora.com Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info

Re: xf86-video-intel: tools/virtual.c

Hi, On Tuesday, August 26, 2014, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: I would strongly suggest you transition to using strlcpy() instead. Please, no: it's truncation mode isn't a useful one, in that it results in the app failing to function at all, or silently doing the

Re: [PATCH] xkb: ignore floating slave devices when updating from master (#81885)

R-b. -d On Monday, August 11, 2014, Peter Hutterer peter.hutte...@who-t.net wrote: ping? On Mon, Aug 04, 2014 at 10:47:03AM +1000, Peter Hutterer wrote: Introduced in 45fb3a934dc0db51584aba37c2f9d73deff9191d. When a device is enabled, the master's locked state is pushed to the slave. If

Re: [PATCH] xkb: ignore floating slave devices when updating from master (#81885)

R-b. -d On Monday, August 11, 2014, Peter Hutterer peter.hutte...@who-t.net wrote: ping? On Mon, Aug 04, 2014 at 10:47:03AM +1000, Peter Hutterer wrote: Introduced in 45fb3a934dc0db51584aba37c2f9d73deff9191d. When a device is enabled, the master's locked state is pushed to the slave. If

Re: [PATCH 1/3] randr: Suppress debug messages from prime

Hi, On 23 July 2014 12:35, Chris Wilson ch...@chris-wilson.co.uk wrote: Hide the ErrorF used for debugging behind an ifdefed out macro. Why not DebugF()? Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 20/22] xkb: Remove some fascinating paranoia from event emission

On 22 July 2014 16:46, Adam Jackson a...@redhat.com wrote: XkbInterestPtrs are created by clients that already exist, meaning, clients that have already had ProcVector installed as something other than InitialProcVector. Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Daniel Stone

Re: [PATCH] xwayland: Only disable/enable devices on capabilities change

A little confusing at first, but looks OK to me. Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

Re: [PATCH] xfree86: Remove i2c multimedia modules

in about fifteen months, and does not build against 1.16 in any case, so this is all dead code. Signed-off-by: Adam Jackson a...@redhat.com All kinds of not sad to see these go. Reviewed-by: Daniel Stone dani...@collabora.com ___ xorg-devel@lists.x.org

Re: [PATCH 0/9] Rewrite include/servermd.h (v2)

wouldn't have needed, had this series already been merged...) For the series: Reviewed-by: Daniel Stone dani...@collabora.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH] xwayland-input: Always set the xkb group index on modifiers events

to have working on the next GNOME release. Agreed to all of the above, but, wouldn't we be better off waiting for a modifiers event straight after enter? Although that's another thing which really needs encoding into the protocol ... oh well. Reviewed-by: Daniel Stone dani...@collabora.com Cheers

Re: [PATCH] headers: Fix build errors with latest glibc

Hi, On 14 July 2014 13:51, Hans de Goede hdego...@redhat.com wrote: On 07/14/2014 02:43 PM, Julien Cristau wrote: On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote: Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making

Re: Request for account on people.freedesktop.org

Hi, On 3 July 2014 16:56, Check Nyah check.n...@gmail.com wrote: Currently setting up my environment for my work on the X server, it looks like i'll have to create my own branch of X server from airlied's clone on cgit.freedesktop.org. Ill like to know if i'm required to create my own branch

Re: [PATCH] xserver: don't call struct members bool.

Hi, On 1 July 2014 23:07, Dave Airlie airl...@gmail.com wrote: When you include files from mesa that might want to use stdbool things get messed up. This is an API break I think and I've no idea what drivers might use this, so we can hold off on it. Yeah, I just hit this yesterday. You're

Re: [PATCH] headers: Fix build errors with latest glibc

Hi, On 2 July 2014 20:14, Hans de Goede hdego...@redhat.com wrote: include/os.h defines protyptes for various non ansi-c str functions, such as str[n]casecmp and strndup. The definition of the prototypes is guarded by #ifndef HAVE_STRFOO, but HAVE_STRFOO is defined by xorg-server.h which is

Re: [PATCH 2/2] xwayland: Implement throttling for surfaces based on the frame event

enter patch are: Reviewed-by: Daniel Stone dani...@collabora.com Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] libx11 xkb/XKBMAlloc.c fix check for map-num_types

Hi, On 5 June 2014 15:46, walter harms wha...@bfs.de wrote: fix: check for map-num_types overflow compiletestested, i have no example to check this condition but i guess that this was the original author intended This isn't an overflow check, but one to ensure that we always have at least

Re: [PATCH] xfree86: Add modesetting to list of fallback drivers

for all (or many) devices need to be last in the list. Since the modesetting driver works for many devices, it needs to be considered a fallback driver. Signed-off-by: Søren Sandmann s...@redhat.com Acked-by: Daniel Stone dani...@collabora.com ___ xorg

Re: [PATCH] xfree86: Add modesetting to list of fallback drivers

Hi, On 29 May 2014 20:21, Søren Sandmann sandm...@cs.au.dk wrote: To make X -configure work properly, the output of fixup_video_driver_list() should be in order of preference. Otherwise, the config file may use the incorrect driver for some devices. In particular, the drivers that work for

Re: [PATCH 04/13] glamor: Use glamor_program and GL_LINES for 0-width lines

Hi, On 13 May 2014 18:32, Keith Packard kei...@keithp.com wrote: Daniel Stone dan...@fooishbar.org writes: Not only that, but _all_ buffers in GLES2 are write-only: there's not even an extension that allows you to map a VBO for read. That's because GLES hates you. And me. I agree

Re: [PATCH 2/3] xwayland: Build without xshmfence

include guarded? The other two, though: Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/3] xwayland: Build without xshmfence

Hi, On 8 April 2014 18:21, Kristian Høgsberg k...@bitplanet.net wrote: On Tue, Apr 8, 2014 at 10:13 AM, Daniel Stone dan...@fooishbar.org wrote: Doesn't this also need the syncshm.h include guarded? No, the header is just the protoype for miSyncShmScreenInit(). Oh sure, was just

[PATCH v2] Add pScreen-NameWindowPixmap hook

This hook allows drivers to be notified when a pixmap gains a new ID. (ABI break.) Signed-off-by: Daniel Stone dani...@collabora.com --- composite/compext.c | 13 - include/scrnintstr.h | 3 +++ 2 files changed, 15 insertions(+), 1 deletion(-) v2: Change return type to return

Re: [PATCH] default to stub int10 implementation on arm

Signed-off-by: Rob Clark robdcl...@gmail.com Acked-by: Daniel Stone dani...@collabora.com Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] dix/dispatch: DoGetImage: Use a single buffer

Hi, On 1 April 2014 05:54, Keith Packard kei...@keithp.com wrote: Aaron Plattner aplatt...@nvidia.com writes: Can't the max image size be multiple gigabytes? That seems a little large to describe as close to running out of heap space. The problem is that we're going to buffer that in

[PATCH] Add pScreen-NameWindowPixmap hook

This hook allows drivers to be notified when a pixmap gains a new ID. (ABI break.) Signed-off-by: Daniel Stone dani...@collabora.com --- composite/compext.c | 6 ++ include/scrnintstr.h | 3 +++ 2 files changed, 9 insertions(+) Is this in time for the ABI break? It's for quite a niche

Re: [PATCH] mi: Hush extension initialization (#75870)

.) Reviewed-by: Daniel Stone dan...@fooishbar.org Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] xkb: Fix ISOLock

Hi, On 24 March 2014 20:53, wettstein...@solnet.ch wrote: That is a long way, I am afraid. To demonstrate the correctness of the X-server implementation by means of a libxkbcommon implementation, the implementations and the environment they live in must be equivalent. Even though the

<    1   2   3   4   5   6   7   8   9   10   >