[PATCH v2 03/14] linux: xf86OpenConsole: Don't detach from controlling tty when it is our vt

2014-02-04 Thread Hans de Goede
. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/os-support/linux/lnx_init.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/os-support/linux/lnx_init.c b/hw/xfree86/os-support/linux/lnx_init.c index 9ccf261..85709c6 100644

[PATCH v2 11/14] systemd-logind: Hookup systemd-logind integration

2014-02-04 Thread Hans de Goede
This commits makes the changes necessary outside of the systemd-logind core to make the server use systemd-logind managed fds for input devices and drm nodes. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/config.c| 13 ++ config/udev.c

[PATCH v2 12/14] systemd-logind: Add delayed input device probing

2014-02-04 Thread Hans de Goede
just for this seems overkill. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/common/xf86Xinput.c | 49 +--- hw/xfree86/common/xf86Xinput.h | 1 + hw/xfree86/os-support/linux/systemd-logind.c | 3 ++ 3 files changed, 49

[PATCH v2 14/14] xf86OpenSerial: Add support server managed fds

2014-02-04 Thread Hans de Goede
Try to get a server managed fd from the Options before trying to open the device node ourselves. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/os-support/shared/posix_tty.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/os-support/shared

[PATCH v2 13/14] config-udev: Don't try to add drm devices twice

2014-02-04 Thread Hans de Goede
(/dev/dri/card0) By filtering out duplicate drm devices we avoid these confusing messages. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- config/udev.c | 4 1 file changed, 4 insertions(+) diff --git a/config/udev.c b/config/udev.c index

[PATCH v2 08/14] OdevAttribute: Remove unowned flag from OdevAttributes head

2014-02-04 Thread Hans de Goede
The OdevAttributes struct should just be a head of the attributes list, and not contain various unrelated flags. Instead add a flags field to struct xf86_platform_device and use that. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/common/xf86Module.h | 2 +- hw

Re: [PATCH v2 04/14] xf86Xinput: Modify API for server-managed fd support

2014-02-04 Thread Hans de Goede
Hi, On 02/04/2014 01:03 PM, Mark Kettenis wrote: From: Hans de Goede hdego...@redhat.com Date: Tue, 4 Feb 2014 12:49:10 +0100 With systemd-logind support, the xserver, rather then the drivers will be responsible for opening/closing the fd for input devices. This commit adds a new

Re: [PATCH v2 04/14] xf86Xinput: Modify API for server-managed fd support

2014-02-04 Thread Hans de Goede
Hi, On 02/04/2014 02:12 PM, Mark Kettenis wrote: Date: Tue, 04 Feb 2014 13:16:21 +0100 From: Hans de Goede hdego...@redhat.com The systemd-logind API uses separate major and minor numbers rather then a dev_t. I don't think the design of the Xorg driver API should be blindly copied from

Re: [PATCH 1/6] xfree86: device name and driver are not const char

2014-02-04 Thread Hans de Goede
Hi, On 02/05/2014 06:18 AM, Peter Hutterer wrote: Allocated in one place, freed in another. You use unchecked strdup in patch 2 and 3, please use XNFstrdup. Other then that the series looks good, so with the above amended this is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH 2/7] xkb: add a call to init an XkbRMLVOSet from const chars

2014-02-03 Thread Hans de Goede
Hi, On 02/03/2014 01:07 AM, Peter Hutterer wrote: On Fri, Jan 31, 2014 at 05:30:58PM +0100, Hans de Goede wrote: Hi, On 01/31/2014 12:36 AM, Peter Hutterer wrote: On Thu, Jan 30, 2014 at 09:40:33AM +0100, Hans de Goede wrote: Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: Just forcing

Re: [PATCH 2/7] xkb: add a call to init an XkbRMLVOSet from const chars

2014-01-31 Thread Hans de Goede
Hi, On 01/31/2014 12:36 AM, Peter Hutterer wrote: On Thu, Jan 30, 2014 at 09:40:33AM +0100, Hans de Goede wrote: Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: Just forcing everything to const char* is not helpful, compiler warnings are supposed to warn about broken code. Forcing

Re: [PATCH 1/7] Xi: remove superfluous cast.

2014-01-30 Thread Hans de Goede
: Reviewed-by: Hans de Goede hdego...@redhat.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/7] xkb: add a call to init an XkbRMLVOSet from const chars

2014-01-30 Thread Hans de Goede
Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: Just forcing everything to const char* is not helpful, compiler warnings are supposed to warn about broken code. Forcing everything to const when it clearly isn't less than ideal. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---

Re: [PATCH 3/7] input: un-constify InputAttributes

2014-01-30 Thread Hans de Goede
changes and fix the test up instead. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Please use XNFstrdup instead of strdup (or add explicit error checking) with that changed: Reviewed By: Hans de Goede hdego...@redhat.com Regards, Hans --- config/udev.c| 14

Re: [PATCH 4/7] Revert os: xstrtokenize takes and returns const char * now

2014-01-30 Thread Hans de Goede
Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: This reverts commit d0339a5c66846c9f14e3b584e34688520a0916ab. seriously, what the fuck? Are we making xstrdup() return a const char now too? Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed By: Hans de Goede

Re: [PATCH 5/7] input: un-constify dev-name

2014-01-30 Thread Hans de Goede
this wrong, but that is not an excuse to add more code getting it wrong. With that changed: Reviewed By: Hans de Goede hdego...@redhat.com Regards, Hans --- Xi/extinit.c | 4 ++-- dix/devices.c | 2 +- include/inputstr.h | 2 +- test/touch.c | 20 +++- 4 files

Re: [PATCH 6/7] Revert xfree86/parser: make strings in xf86MatchGroup const

2014-01-30 Thread Hans de Goede
Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: This reverts commit f71de60355cc76810657f40c7b5461af86b34bf7. What warnings? Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed By: Hans de Goede hdego...@redhat.com Regards, Hans --- hw/xfree86/parser

Re: [PATCH 2/7] xkb: add a call to init an XkbRMLVOSet from const chars

2014-01-30 Thread Hans de Goede
Hi, On 01/30/2014 09:40 AM, Hans de Goede wrote: Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: Just forcing everything to const char* is not helpful, compiler warnings are supposed to warn about broken code. Forcing everything to const when it clearly isn't less than ideal. Signed

Re: [PATCH 7/7] Revert xfree86/common: handle string constants in xf86Xinput configuration

2014-01-30 Thread Hans de Goede
Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: This reverts commit 22592855e90d23013ba7f9e945d567725cb44bf3. What warning was this supposed to fix? Looks good: Reviewed By: Hans de Goede hdego...@redhat.com Regards, Hans Signed-off-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH 2/7] xkb: add a call to init an XkbRMLVOSet from const chars

2014-01-30 Thread Hans de Goede
Hi, On 01/30/2014 10:18 AM, Mark Kettenis wrote: Date: Thu, 30 Jan 2014 09:40:33 +0100 From: Hans de Goede hdego...@redhat.com This should use the new XkbInitRules rather then diy strdup, so as to be balanced wrt to the XkbFreeRMLVOSet call. That may be true, but it is better to do

Re: [PATCH 3/7] input: un-constify InputAttributes

2014-01-30 Thread Hans de Goede
Hi, On 01/30/2014 02:26 PM, Julien Cristau wrote: On Thu, Jan 30, 2014 at 09:43:37 +0100, Hans de Goede wrote: Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: Introduced in fecc7eb1cf66db64728ee2d68cd9443df7e70879 and reverts most of that but it's helpfully mixed with other stuff

Re: [PATCH 3/7] input: un-constify InputAttributes

2014-01-30 Thread Hans de Goede
Hi, On 01/30/2014 02:54 PM, Hans de Goede wrote: Hi, On 01/30/2014 02:26 PM, Julien Cristau wrote: On Thu, Jan 30, 2014 at 09:43:37 +0100, Hans de Goede wrote: Hi, On 01/30/2014 12:51 AM, Peter Hutterer wrote: Introduced in fecc7eb1cf66db64728ee2d68cd9443df7e70879 and reverts most

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-29 Thread Hans de Goede
Hi, On 01/29/2014 01:05 AM, Peter Hutterer wrote: On Tue, Jan 28, 2014 at 10:12:30AM +0100, Hans de Goede wrote: 8d972e0c xf86Xinput: Modify API for server-managed fd support I worry a little that drivers won't necessarily support this - would be nice to check by forcing them to define

Re: [PATCH 11/12] config-udev: Refactor input device addition for delayed input device probing

2014-01-29 Thread Hans de Goede
Hi, On 01/29/2014 01:42 AM, Peter Hutterer wrote: On Wed, Jan 15, 2014 at 03:32:25PM +0100, Hans de Goede wrote: With systemd-logind we need to delay input device probing when switched away (iow not on the active vt). This is a preparation patch for this. Signed-off-by: Hans de Goede hdego

Re: [PULL] systemd integration patches

2014-01-28 Thread Hans de Goede
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 01/28/2014 12:39 AM, Keith Packard wrote: Hans de Goede hdego...@redhat.com writes: Hans de Goede (5): dbus-core: Make dbus-core no longer mutually exclusive with udev dbus-core: Attempt to connect to dbus ASAP xf86Events: split

Re: [PATCH 07/12] hotplug: Modify OdevAttributes for server-managed fd support

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 08:01 AM, Dave Airlie wrote: On 16 Jan 2014 00:33, Hans de Goede hdego...@redhat.com wrote: With systemd-logind support, the xserver, rather then the drivers will be responsible for opening/closing the fd for drm nodes. The initial open will happen on probe from config

Re: [PATCH 05/12] xf86Events: add Enable/DisableInputDeviceForVTSwitch functions

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 07:35 AM, Peter Hutterer wrote: On Wed, Jan 15, 2014 at 03:32:19PM +0100, Hans de Goede wrote: Factor this code out into functions so that it can be re-used for the systemd-logind device pause/resume paths. Signed-off-by: Hans de Goede hdego...@redhat.com I'd probably

Re: [PULL] systemd integration patches

2014-01-28 Thread Hans de Goede
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 01/28/2014 09:08 AM, Hans de Goede wrote: Hi, On 01/28/2014 12:39 AM, Keith Packard wrote: Hans de Goede hdego...@redhat.com writes: Hans de Goede (5): dbus-core: Make dbus-core no longer mutually exclusive with udev dbus-core

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 07:46 AM, Peter Hutterer wrote: On Thu, Jan 23, 2014 at 02:58:17PM +0100, Hans de Goede wrote: Hi, On 01/23/2014 01:56 PM, Daniel Stone wrote: Hi, On 23 January 2014 11:16, Hans de Goede hdego...@redhat.com wrote: Ok, I've put it back in config (while keeping the other

Re: [PATCH 08/12] systemd-logind: Add systemd-logind core

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 08:15 AM, Peter Hutterer wrote: On Wed, Jan 15, 2014 at 03:32:22PM +0100, Hans de Goede wrote: This commits add the bulk of the systemd-logind integration code, but does not hook it up yet other then calling its init and fini functions, which don't do that much. snip

Re: [PATCH 08/12] systemd-logind: Add systemd-logind core

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 08:52 AM, David Herrmann wrote: Hi Peter On Tue, Jan 28, 2014 at 8:15 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Jan 15, 2014 at 03:32:22PM +0100, Hans de Goede wrote: This commits add the bulk of the systemd-logind integration code, but does not hook

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-28 Thread Hans de Goede
Hi, On 01/23/2014 02:58 PM, Hans de Goede wrote: Hi, On 01/23/2014 01:56 PM, Daniel Stone wrote: snip 8d972e0c xf86Xinput: Modify API for server-managed fd support I worry a little that drivers won't necessarily support this - would be nice to check by forcing them to define

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 02:14 PM, Julien Cristau wrote: On Tue, Jan 28, 2014 at 11:33:01 +0100, Hans de Goede wrote: As for the worries of drivers not being prepared to deal with this, systemd_logind_take_fd will only succeed for evdev devices, and AFAIK we've only 2 drivers for those evdev

Re: [PULL] systemd integration patches

2014-01-28 Thread Hans de Goede
Hi, On 01/28/2014 05:35 PM, Keith Packard wrote: Hans de Goede hdego...@redhat.com writes: Correction, Peter Hutterer has just reviewed the other 3 and given his: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Awesome! So all are reviewed now, can you pull as is, or do you want

Re: Intent todo a libxtrans-1.3.3 release coming Monday

2014-01-27 Thread Hans de Goede
Hi, On 01/23/2014 05:33 PM, Jon TURNEY wrote: On 23/01/2014 10:40, Hans de Goede wrote: I've just pushed the 2 systemd socket activation patches by Łukasz Stelmach for libxtrans to libxtrans master. I intend to cut a 1.3.3 release with these patches in there Monday. So if there are any

[PULL] systemd integration patches

2014-01-27 Thread Hans de Goede
to 646b5d885f15e4ca884a4c4da2d296e14d9fe972: xf86Events: add Enable/DisableInputDeviceForVTSwitch functions (2014-01-27 14:44:36 +0100) - Hans de Goede (5): dbus-core: Make dbus-core no longer mutually exclusive with udev dbus-core: Attempt

[ANNOUNCE] xtrans 1.3.3

2014-01-27 Thread Hans de Goede
and Imake SIGNALRETURNSINT Hans de Goede (1): xtrans 1.3.3 Jon TURNEY (1): Add TransIsListening() Mark Kettenis (3): Remove unused static inlines Fix alignment issues in FD passing code Don't restrict FD passing to Linux Solaris Łukasz Stelmach (2): Define

Intent todo a libxtrans-1.3.3 release coming Monday

2014-01-23 Thread Hans de Goede
Hi All, I've just pushed the 2 systemd socket activation patches by Łukasz Stelmach l.stelm...@samsung.com for libxtrans to libxtrans master. I intend to cut a 1.3.3 release with these patches in there Monday. So if there are any objections, or any pending changes you would like to see make

Re: [PATCH RESEND] xfree86: Keep a non-seat0 X server from touching VTs (#71258)

2014-01-23 Thread Hans de Goede
Hi, On 01/22/2014 08:12 PM, Keith Packard wrote: Hans de Goede hdego...@redhat.com writes: After the 1.15 release I'll send a pull request for this to get added into xserver git master. I haven't seen a pull request for this yet? I have this in the same branch as the systemd socket

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-23 Thread Hans de Goede
Hi, On 01/19/2014 06:17 PM, Daniel Stone wrote: Hi, On 18 January 2014 16:27, Hans de Goede hdego...@redhat.com wrote: On 01/17/2014 02:08 PM, Daniel Stone wrote: On 15 January 2014 14:32, Hans de Goede hdego...@redhat.com wrote: With systemd-logind the dbus-core will be used for more

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-23 Thread Hans de Goede
Hi, On 01/23/2014 01:56 PM, Daniel Stone wrote: Hi, On 23 January 2014 11:16, Hans de Goede hdego...@redhat.com wrote: Ok, I've put it back in config (while keeping the other changes like making it no longer mutually exclusive with udev). I've pushed the updated version here: http

Re: [PATCH 0/3] linux: Allow console switching to work without root rights

2014-01-22 Thread Hans de Goede
Hi, On 01/22/2014 03:17 AM, Peter Hutterer wrote: On Tue, Jan 21, 2014 at 09:47:31AM +0100, Hans de Goede wrote: Hi, On 01/21/2014 05:44 AM, Peter Hutterer wrote: On Thu, Jan 16, 2014 at 11:24:48AM +0100, Hans de Goede wrote: This patch-set makes it possible to run without as non-root

Re: [PATCH 0/3] linux: Allow console switching to work without root rights

2014-01-22 Thread Hans de Goede
Hi, On 01/22/2014 11:41 AM, Peter Hutterer wrote: On 22/01/2014 18:40 , Hans de Goede wrote: Hi, On 01/22/2014 03:17 AM, Peter Hutterer wrote: On Tue, Jan 21, 2014 at 09:47:31AM +0100, Hans de Goede wrote: Hi, On 01/21/2014 05:44 AM, Peter Hutterer wrote: On Thu, Jan 16, 2014 at 11:24

[PATCH v2 0/2] linux: Allow console switching to work without root rights

2014-01-22 Thread Hans de Goede
Hi All, Here is v2 of my Allow console switching to work without root rights patch-set. Changes: -Drop linux: xf86OpenConsole: open vt before detaching from terminal This causes the server to not get its vt as controlling tty when started without a controlling tty (as gdm does), which in turn

[PATCH v2 2/2] linux: xf86OpenConsole: Don't detach from controlling tty when it is our vt

2014-01-22 Thread Hans de Goede
. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/os-support/linux/lnx_init.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/os-support/linux/lnx_init.c b/hw/xfree86/os-support/linux/lnx_init.c index bead72e..a1e6f63 100644

[PATCH v2 1/2] linux: xf86OpenConsole remove root-rights check for keeptty option

2014-01-22 Thread Hans de Goede
There is no reason why keeptty cannot be used without root-rights. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/os-support/linux/lnx_init.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/xfree86/os-support/linux

Re: [PATCH 2/3] linux: xf86OpenConsole: open vt before detaching from terminal

2014-01-21 Thread Hans de Goede
Hi, On 01/21/2014 06:11 AM, Peter Hutterer wrote: On Thu, Jan 16, 2014 at 11:24:50AM +0100, Hans de Goede wrote: This is a preparation patch for automatically doing keeptty when the server gets passed the current vt as vt to use on the cmdline. I found the commit message a bit confusing

Resurrecting uvesafb and turning it into a kms driver ?

2014-01-21 Thread Hans de Goede
Hi, I've started a discussion on fedora-devel about what to do with old-style userspace mode setting drivers when the suid root bit is removed from the X server binary: https://lists.fedoraproject.org/pipermail/devel/2014-January/194123.html I started this discussion there because to me the

Re: [PATCH 0/3] linux: Allow console switching to work without root rights

2014-01-21 Thread Hans de Goede
Hi, On 01/21/2014 05:44 AM, Peter Hutterer wrote: On Thu, Jan 16, 2014 at 11:24:48AM +0100, Hans de Goede wrote: This patch-set makes it possible to run without as non-root without -sharevts. With the caveat that the user must specify the vt from which X is started as the vt to run on (as both

Re: Resurrecting uvesafb and turning it into a kms driver ?

2014-01-21 Thread Hans de Goede
Hi, On 01/21/2014 12:57 PM, David Herrmann wrote: Hi On Tue, Jan 21, 2014 at 9:36 AM, Hans de Goede hdego...@redhat.com wrote: Hi, I've started a discussion on fedora-devel about what to do with old-style userspace mode setting drivers when the suid root bit is removed from the X server

Re: [PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-18 Thread Hans de Goede
Hi, On 01/17/2014 02:08 PM, Daniel Stone wrote: Hi, On 15 January 2014 14:32, Hans de Goede hdego...@redhat.com wrote: With systemd-logind the dbus-core will be used for more then just config. This patch also makes the building of the dbus-core and udev no longer mutually exclusive

[PATCH 3/3] linux: xf86OpenConsole: Don't detach from tty when running on the active tty

2014-01-16 Thread Hans de Goede
-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/os-support/linux/lnx_init.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/xfree86/os-support/linux/lnx_init.c b/hw/xfree86/os-support/linux/lnx_init.c index 5f7d39b..52e629b 100644 --- a/hw/xfree86/os-support/linux/lnx_init.c

[PATCH 0/3] linux: Allow console switching to work without root rights

2014-01-16 Thread Hans de Goede
Hi All, This patch-set makes it possible to run without as non-root without -sharevts. With the caveat that the user must specify the vt from which X is started as the vt to run on (as both gdm and startx do by default). With this patch-set + my systemd-logind patches I can login as user on a

[PATCH 1/3] linux: xf86OpenConsole remove root-rights check for keeptty option

2014-01-16 Thread Hans de Goede
There is no reason why keeptty cannot be used without root-rights. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/os-support/linux/lnx_init.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/xfree86/os-support/linux/lnx_init.c b/hw/xfree86/os-support/linux/lnx_init.c

[PATCH 2/3] linux: xf86OpenConsole: open vt before detaching from terminal

2014-01-16 Thread Hans de Goede
This is a preparation patch for automatically doing keeptty when the server gets passed the current vt as vt to use on the cmdline. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/os-support/linux/lnx_init.c | 43 -- 1 file changed, 20 insertions

[PATCH 02/12] dbus-core: Attempt to connect to dbus ASAP

2014-01-15 Thread Hans de Goede
For systemd-logind integration we need the dbus connection to be available before enumerating input and gfx devices. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/common/dbus-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/common/dbus

[PATCH 04/12] xf86Events: refactor xf86VTLeave error handling

2014-01-15 Thread Hans de Goede
Use kernel goto style error handling for xf86VTSwitchAway() failure. This makes it much easier to read the straight path. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/common/xf86Events.c | 94 +- 1 file changed, 46 insertions(+), 48

[PATCH 10/12] config-udev: Don't try to add drm devices twice

2014-01-15 Thread Hans de Goede
messages. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/udev.c | 4 1 file changed, 4 insertions(+) diff --git a/config/udev.c b/config/udev.c index c1a5c91..9579bf2 100644 --- a/config/udev.c +++ b/config/udev.c @@ -113,6 +113,10 @@ device_added(struct udev_device *udev_device

[PATCH 11/12] config-udev: Refactor input device addition for delayed input device probing

2014-01-15 Thread Hans de Goede
With systemd-logind we need to delay input device probing when switched away (iow not on the active vt). This is a preparation patch for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/udev.c | 150 +- 1 file changed, 85

[PATCH 03/12] xf86Events: split xf86VTSwitch into xf86VTLeave and xf86VTEnter functions

2014-01-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/common/xf86.h | 2 + hw/xfree86/common/xf86Events.c | 273 + 2 files changed, 145 insertions(+), 130 deletions(-) diff --git a/hw/xfree86/common/xf86.h b/hw/xfree86/common/xf86.h index

[PATCH 07/12] hotplug: Modify OdevAttributes for server-managed fd support

2014-01-15 Thread Hans de Goede
+ minor numbers, since we are breaking ABI anyways also add major and minor fields for easy storage / retreival of these, as well as a utility function for getting a platform device by devnum. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/config.c | 6 +- hw

[RFC 00/12] Use systemd-logind to manage /dev/... nodes for us

2014-01-15 Thread Hans de Goede
systemd-logind has the ability to manage /dev/... nodes for us, this includes not only opening them for us, but also getting/setting drm master on vtenter/vtleave for drm nodes, and revoking access on vtleave + providing a new fd on vtenter for evdev nodes. Using systemd-logind under Linux for

[PATCH 12/12] config-udev: Add delayed input device probing

2014-01-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- config/udev.c| 35 ++-- hw/xfree86/os-support/linux/systemd-logind.c | 4 include/hotplug.h| 4 3 files changed, 41 insertions(+), 2 deletions

[PATCH xf86-video-intel] intel: Add support for server managed fds

2014-01-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- src/intel_device.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/intel_device.c b/src/intel_device.c index 4d08a6e..4378e66 100644 --- a/src/intel_device.c +++ b/src/intel_device.c @@ -42,6

[PATCH 08/12] systemd-logind: Add systemd-logind core

2014-01-15 Thread Hans de Goede
This commits add the bulk of the systemd-logind integration code, but does not hook it up yet other then calling its init and fini functions, which don't do that much. Signed-off-by: Hans de Goede hdego...@redhat.com --- configure.ac | 21 ++ hw/xfree86/common

[PATCH 01/12] dbus-core: Move to hw/xfree86/common dir

2014-01-15 Thread Hans de Goede
With systemd-logind the dbus-core will be used for more then just config. This patch also makes the building of the dbus-core and udev no longer mutually exclusive and removes the config_ prefix from the dbus-core symbols. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/Makefile.am

[PATCH 06/12] xf86Xinput: Modify API for server-managed fd support

2014-01-15 Thread Hans de Goede
of these. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/common/xf86Module.h | 2 +- hw/xfree86/common/xf86Xinput.c | 16 hw/xfree86/common/xf86Xinput.h | 3 +++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86Module.h b/hw/xfree86

[PATCH 09/12] systemd-logind: Hookup systemd-logind integration

2014-01-15 Thread Hans de Goede
This commits makes the changes necessary outside of the systemd-logind core to make the server use systemd-logind managed fds for input devices and drm nodes. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/config.c| 5 ++- config/udev.c

[PATCH 05/12] xf86Events: add Enable/DisableInputDeviceForVTSwitch functions

2014-01-15 Thread Hans de Goede
Factor this code out into functions so that it can be re-used for the systemd-logind device pause/resume paths. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/xfree86/common/xf86.h | 4 hw/xfree86/common/xf86Events.c | 52 +++--- 2 files

Re: Using systemd-logind Session.TakeControl() from Xorg, input needed

2013-12-12 Thread Hans de Goede
Hi, On 12/11/2013 06:56 PM, Laércio de Sousa wrote: Sorry for the intromission, but this can be more or less related to your needs. I've submitted a patch to xorg-devel that blocks VT access for non-seat0 X servers i.e. those started with -seat option set to any value different from seat0.

Re: Using systemd-logind Session.TakeControl() from Xorg, input needed

2013-12-12 Thread Hans de Goede
Hi, On 12/12/2013 02:31 PM, Laércio de Sousa wrote: Hans, systemd currently ships a multi-seat-x wrapper (http://cgit.freedesktop.org/systemd/systemd/tree/src/login/multi-seat-x.c) for cases where X.Org doesn't work well with multiseat. In the beginning, it was much bigger, but now, as

[PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation v6

2013-12-12 Thread Hans de Goede
Hi All, Here is v6 of this patchset (which should be the final version), new this time around: -Changed SYSTEMD autofoo vars and defines to SYSTEMD_DAEMON to clearly differentiate them from the upcoming SYSTEMD_LOGIND support -Re-added #undef HAVE_SYSTEMD_DAEMON line to include/dix-config.h.in

[PATCH libxtrans v6 1/2] Define TRANS_RECEIVED flag for transports

2013-12-12 Thread Hans de Goede
From: Łukasz Stelmach l.stelm...@samsung.com The flag is to be used to mark transports related to sockets received from systemd. Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- Xtrans.c

Re: [PATCH RESEND] xfree86: Keep a non-seat0 X server from touching VTs (#71258)

2013-12-12 Thread Hans de Goede
Hi, On 12/12/2013 05:22 PM, Laércio de Sousa wrote: Updated patch following Hans de Goede's advice. Thanks, added to my tree with the 2 elements of the test swapped as discussed. I've also changed the test from: if (!((flags HW_SKIP_CONSOLE) || ServerIsNotSeat0())) to: if (!(flags

[PATCH libxtrans v6 2/2] Enable systemd socket activation

2013-12-12 Thread Hans de Goede
...@samsung.com Cc: Karol Lewandowski k.lewando...@samsung.com Cc: Lennart Poettering lenn...@poettering.net Cc: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl Cc: Peter Hutterer peter.hutte...@who-t.net Cc: walter harms wha...@bfs.de Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer

Re: Using systemd-logind Session.TakeControl() from Xorg, input needed

2013-12-05 Thread Hans de Goede
Hi All, First of all thanks to everyone in this thread for the input. Since a lot has been said in various mails I'm going to try and summarize it all here, rather then sending a reply to each and every mail in the thread. It seems that the best and most feasible way to make Xorg properly

Re: Using systemd-logind Session.TakeControl() from Xorg, input needed

2013-12-05 Thread Hans de Goede
Hi, On 12/05/2013 04:05 PM, Ray Strode wrote: Hi, - Original Message - Ray Strode also said: You can't shut down an X server unless it's in the foreground.. I can remember having done that without problems just yesterday when working on systemd socket activation for the xserver. I've

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-04 Thread Hans de Goede
Hi, On 12/03/2013 08:20 PM, Kristian Høgsberg wrote: On Tue, Dec 3, 2013 at 1:48 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 12/02/2013 09:54 PM, Kristian Høgsberg wrote: On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede hdego...@redhat.com wrote: Hi All, Hi, I didn't follow all

Using systemd-logind Session.TakeControl() from Xorg, input needed

2013-12-04 Thread Hans de Goede
Hi All, I've been looking into using systemd-logind Session.TakeControl() and friends from the xserver, so that the xserver can let logind open/close the device nodes for it, and then hopefully will no longer need root rights. Sofar I've mainly been finding investigating / finding my way around

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation

2013-12-03 Thread Hans de Goede
Hi, On 12/02/2013 09:36 PM, Julien Cristau wrote: On Mon, Dec 2, 2013 at 20:50:33 +0100, Hans de Goede wrote: Given that this is mostly for more embedded setups and it does not work with xdm/gdm, I'm not sure shipping these as example is a good idea. They won't be usable ootb in anyway

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-03 Thread Hans de Goede
Hi, On 12/02/2013 09:54 PM, Kristian Høgsberg wrote: On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede hdego...@redhat.com wrote: Hi All, Hi, I didn't follow all this in detail, but I'm not sure that we need Xtrans patches at all. The server already has ListenOnOpenFD() in os/connection.c

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Hans de Goede
Hi, On 12/02/2013 02:33 PM, Łukasz Stelmach wrote: It was 2013-11-30 sob 01:42, when Peter Hutterer wrote: On 29/11/2013 19:36 , Łukasz Stelmach wrote: It was 2013-11-29 pią 06:00, when Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:23:07PM +0100, Hans de Goede wrote: From: Łukasz

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Hans de Goede
Hi, On 11/28/2013 07:34 PM, Gaetan Nadon wrote: On 13-11-28 10:23 AM, Hans de Goede wrote: +AC_ARG_WITH([systemd], + AS_HELP_STRING([--with-systemd], [support systemd socket activation]), + [], [with_systemd=check]) +have_systemd=check Can I trouble you to replace check with auto

[PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-02 Thread Hans de Goede
Hi All, Here is v5 (I'm starting the numbering where Łukasz stopped) of the systemd socket activation patch-set. This version addresses all review comments made in response to my previous posting of this set. Testing can still be done like this: 1) Create a file named

[PATCH libxtrans 1/2] Define TRANS_RECEIVED flag for transports

2013-12-02 Thread Hans de Goede
From: Łukasz Stelmach l.stelm...@samsung.com The flag is to be used to mark transports related to sockets received from systemd. Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- Xtrans.c

Re: [PATCH 2/2] Enable systemd socket activation

2013-12-02 Thread Hans de Goede
Hi, On 11/29/2013 05:37 AM, Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:21:14PM +0100, Hans de Goede wrote: From: Łukasz Stelmach l.stelm...@samsung.com Receive file descriptors of open sockets from systemd instead of creating them. --- Xtrans.c | 82

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Hans de Goede
Hi, On 11/29/2013 06:00 AM, Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:23:07PM +0100, Hans de Goede wrote: From: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com --- configure.ac | 28

[PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Hans de Goede
From: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com --- configure.ac | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[PATCH libxtrans 2/2] Enable systemd socket activation

2013-12-02 Thread Hans de Goede
...@samsung.com Cc: Karol Lewandowski k.lewando...@samsung.com Cc: Lennart Poettering lenn...@poettering.net Cc: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl Cc: Peter Hutterer peter.hutte...@who-t.net Cc: walter harms wha...@bfs.de Cc: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Hans de

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation

2013-12-02 Thread Hans de Goede
Hi, On 11/29/2013 05:38 AM, Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:21:12PM +0100, Hans de Goede wrote: Hi All, As I already mentioned in my self-introduction mail I'm a new member of Red Hat's graphics team. One of the first things I'll be working on is systemd integration

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-11-29 Thread Hans de Goede
Hi, On 11/29/2013 10:36 AM, Łukasz Stelmach wrote: It was 2013-11-29 pią 06:00, when Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:23:07PM +0100, Hans de Goede wrote: From: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de

Re: [PATCH] [RFC] socket activation code for xserver

2013-11-28 Thread Hans de Goede
Hi, On 11/28/2013 09:54 AM, Łukasz Stelmach wrote: It was 2013-11-27 śro 11:37, when Hans de Goede wrote: Hi Łukasz, So I was taking a closer look at the libxtrans patch today, and I noticed that it does not build. It adds a check for trans-flagsTRANS_RECEIVED inside the main loop

[PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation

2013-11-28 Thread Hans de Goede
Hi All, As I already mentioned in my self-introduction mail I'm a new member of Red Hat's graphics team. One of the first things I'll be working on is systemd integration, specifically support for the new systemd-logind org.freedesktop.login1.Session TakeControl / TakeDevice and friends dbus

[PATCH 1/2] Define TRANS_RECEIVED flag for transports

2013-11-28 Thread Hans de Goede
From: Łukasz Stelmach l.stelm...@samsung.com The flag is to be used to mark transports related to sockets received from systemd. Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com --- Xtrans.c| 28 Xtrans.h

[PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-11-28 Thread Hans de Goede
From: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com --- configure.ac | 28 1 file changed, 28 insertions(+) diff --git a/configure.ac b/configure.ac index 6c4a609

[PATCH 2/2] Enable systemd socket activation

2013-11-28 Thread Hans de Goede
...@samsung.com Cc: Karol Lewandowski k.lewando...@samsung.com Cc: Lennart Poettering lenn...@poettering.net Cc: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl Cc: Peter Hutterer peter.hutte...@who-t.net Cc: walter harms wha...@bfs.de Cc: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Hans de

Re: [PATCH] [RFC] socket activation code for xserver

2013-11-27 Thread Hans de Goede
-by: Hans de Goede hdego...@redhat.com --- Xtrans.c| 82 - Xtransint.h | 1 + 2 files changed, 82 insertions(+), 1 deletion(-) diff --git a/Xtrans.c b/Xtrans.c index 735d7b8..8b67194 100644 --- a/Xtrans.c +++ b/Xtrans.c @@ -48,6 +48,9

Re: [PATCH] [RFC] socket activation code for xserver

2013-11-25 Thread Hans de Goede
Hi Łukasz, I'm a new member of Red Hat's graphics team. At the request of Peter Hutterer I've been looking at your systemd socket activation patches. Applying / building them was not a problem. My initial thought for testing socket activation was to write the necessary unit files and patch gdm

Re: [PATCH] [RFC] socket activation code for xserver

2013-11-25 Thread Hans de Goede
Hi, On 11/25/2013 03:24 PM, Łukasz Stelmach wrote: It was 2013-11-25 pon 14:49, when Łukasz Stelmach wrote: It was 2013-11-25 pon 13:46, when Hans de Goede wrote: Hi Łukasz, Hello, nice to ... meet you :-) I'm a new member of Red Hat's graphics team. At the request of Peter Hutterer I've

Self introduction Hans de Goede

2013-11-15 Thread Hans de Goede
Hi All, My name is Hans de Goede, and I'm active as a FOSS contributor / developer since 1997. Recently I've mainly been working on hwmon kernel drivers, usb webcam kernel drivers and userspace support libs, usb emulation and redirection in qemu, libusb and usbdevfs. I've been working

<    3   4   5   6   7   8   9   >