The previous implementation had duplicated code depending on which
standard is being used (i.e., DRI1 and / or EXA).
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 110 +++---
1 file changed, 30 insertions(+), 80 deletions(-)
diff --git a/src
Move acquiring of the option settings into r128AcquireOption and
r128UMSOption functions.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 170 +++---
1 file changed, 97 insertions(+), 73 deletions(-)
diff --git a/src/r128_driver.c b/src
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 04295a5..30a7a21 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -1196,7 +1196,8 @@ static Bool R128PreInitControllers
The turn on timing is premature. Wait until completion of the
initialization process.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index a3b7ac4..04295a5 100644
--- a/src
Signed-off-by: Kevin Brace
---
src/r128.h| 2 +-
src/r128_driver.c | 42 +-
src/r128_exa.c| 13 -
3 files changed, 26 insertions(+), 31 deletions(-)
diff --git a/src/r128.h b/src/r128.h
index 2df674f..5e6502b 100644
--- a/src/r128
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 39 ++-
1 file changed, 14 insertions(+), 25 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 1642ea9..ed560b7 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -1643,30 +1643,6
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 39 ---
1 file changed, 12 insertions(+), 27 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index e2de57d..1642ea9 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -1667,30 +1667,6
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_driver.c | 42 +-
src/r128_exa.c| 19 ---
3 files changed, 21 insertions(+), 41 deletions(-)
diff --git a/src/r128.h b/src/r128.h
index 032c40b..2df674f 100644
--- a/src
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index afa41ca..32beddd 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -1748,8 +1748,6 @@ Bool R128ScreenInit(SCREEN_INIT_ARGS_DECL
Moving them away from R128ScreenInit callback function. This is how
other DDXs do it.
Signed-off-by: Kevin Brace
---
src/r128_accel.c | 1 -
src/r128_driver.c | 48 +++-
src/r128_exa.c| 12
3 files changed, 43 insertions(+), 18
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 6c1a9e9..773038c 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -1031,7 +1031,7 @@ static Bool R128PreInitCursor
Stop the use of #include to include r128_exa_render.c inside
r128_exa.c.
Signed-off-by: Kevin Brace
---
src/Makefile.am | 23 --
src/r128.h| 24 +++
src/r128_accel.c | 22 +-
src/r128_exa.c| 31
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index e34b1cd..6c1a9e9 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -137,7 +137,6 @@ typedef enum {
OPTION_BUFFER_SIZE,
OPTION_PAGE_FLIP
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 170 ++
1 file changed, 94 insertions(+), 76 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index d21117a..c4a1019 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index c4a1019..e34b1cd 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -109,9 +109,6 @@
#endif
-#define USE_CRT_ONLY 0
It is no longer used.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 57f4d05..d21117a 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -121,7 +121,6 @@ typedef enum {
OPTION_NOACCEL
Since SWCursor option is referenced only once, it should be handled
inside R128PreInit callback function rather than R128ScreenInit
callback function.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 +
src/r128_driver.c | 9 -
2 files changed, 9 insertions(+), 1 deletion(-)
diff
Since SWCursor option is referenced only once, it should be handled
inside R128PreInit callback function rather than R128ScreenInit
callback function.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 +
src/r128_driver.c | 9 -
2 files changed, 9 insertions(+), 1 deletion(-)
diff
Since AccelMethod and RenderAccel options are referenced only once,
it should be handled inside R128PreInit callback function rather
than R128ScreenInit callback function.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 62 ++-
1 file
Since NoAccel option is referenced only once, it should be handled
inside R128PreInit callback function rather than R128ScreenInit
callback function.
Signed-off-by: Kevin Brace
---
src/r128.h| 2 ++
src/r128_driver.c | 20
2 files changed, 14 insertions(+), 8
Starting the process of separating legacy XAA and newer EXA
initialization code.
Signed-off-by: Kevin Brace
---
src/r128.h| 3 ++-
src/r128_accel.c | 44 +++-
src/r128_driver.c | 51 ++-
src
Fix for cross build failure
Kevin Brace (31):
Move the location where R128PreInitGamma is called
Move assignment of color depth variables away from R128PreInitVisual
Move the assignment to monitor field of ScrnInfoRec record
Move R128PreInitVisual and R128PreInitGamma ca
Fix for cross build failure
Kevin Brace (31):
Move the location where R128PreInitGamma is called
Move assignment of color depth variables away from R128PreInitVisual
Move the assignment to monitor field of ScrnInfoRec record
Move R128PreInitVisual and R128PreInitGamma ca
Fix for cross build failure
Kevin Brace (31):
Move the location where R128PreInitGamma is called
Move assignment of color depth variables away from R128PreInitVisual
Move the assignment to monitor field of ScrnInfoRec record
Move R128PreInitVisual and R128PreInitGamma ca
Stop the use of #include to include r128_exa_render.c inside
r128_exa.c.
Signed-off-by: Kevin Brace
---
src/Makefile.am | 23 --
src/r128.h| 24 +++
src/r128_accel.c | 22 +-
src/r128_exa.c| 31
From: Dylan Aïssi
Signed-off-by: Dylan Aïssi
---
src/r128_exa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/r128_exa.c b/src/r128_exa.c
index 1bbf470..5099915 100644
--- a/src/r128_exa.c
+++ b/src/r128_exa.c
@@ -484,7 +484,7 @@ R128EXAInit(ScreenPtr pScreen)
}
From: Helmut Grohne
configure.ac fails to cross build from source, because it abuses
AC_CHECK_FILE for finding headers. AC_CHECK_FILE is supposed to find
files on the host system. You cannot usually expect the host system
to have headers, so this use is incorrect. It happens to also break
cross
;
"major version"."minor version"."patch level") more frequently between minor
versions?
If I were to adopt this approach, I think the next development version after
Version 6.11.0 is, 6.11.99.
Is this correct?
Kevin Brace
Brace Computer Laboratory blo
Location where the backup of r128_drv.so was stored")/r128_drv.so
/usr/lib/xorg/modules/drivers/
Let me know how the patch works.
If the patch works, I will like to release a new version of xf86-video-r128
soon.
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
___
. With this fix, there is no longer the need to
specify the supported frequency range of the monitor inside xorg.conf.
The code was tested on RAGE 128 Pro Ultra 16 MB AGP.
Signed-off-by: Kevin Brace
---
src/r128_output.c | 60 ++-
1 file changed, 33
Signed-off-by: Kevin Brace
---
src/r128_output.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/r128_output.c b/src/r128_output.c
index 41a2533..f11acde 100644
--- a/src/r128_output.c
+++ b/src/r128_output.c
@@ -280,10 +280,10 @@ static
Signed-off-by: Kevin Brace
---
src/init.c | 3 +--
src/init301.c | 10 ++
src/sis310_accel.c | 4 +---
3 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/src/init.c b/src/init.c
index a232cb7..4f84b0c 100644
--- a/src/init.c
+++ b/src/init.c
@@ -2669,7 +2669,7
Signed-off-by: Kevin Brace
---
src/sis_driver.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/sis_driver.c b/src/sis_driver.c
index 4e51e2e..31a7ada 100644
--- a/src/sis_driver.c
+++ b/src/sis_driver.c
@@ -9316,7 +9316,9 @@ SISMergedPointerMoved(SCRN_ARG_TYPE arg, int x, int y
Signed-off-by: Kevin Brace
---
src/Makefile.am | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 52523a9..3b7d7d7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -32,16 +32,17 @@ sis_drv_la_SOURCES = \
300vtbl.h
Hi,
I have not seen any movement in obtaining xorg/driver commit privilege.
https://bugs.freedesktop.org/show_bug.cgi?id=106605
Please note that several of my r128 DDX patches have been committed by Connor
Behan.
Regards,
Kevin Brace
Brace Computer Laboratory blog
https
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 4918a0e..4cc95e6 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -1264,7 +1264,7 @@ Bool R128PreInit
The variable sizes were not matching the intended print format.
Signed-off-by: Kevin Brace
---
src/r128_accel.c | 8
src/r128_driver.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/r128_accel.c b/src/r128_accel.c
index ab04b25..0ad4edc 100644
--- a/src
Deprecating R128TRACE macro in favor of DEBUG macro used inside
OpenChrome DDX.
Signed-off-by: Kevin Brace
---
src/r128.h| 13 +++---
src/r128_accel.c | 57
src/r128_crtc.c | 117 +-
src
Merge it into R128LegacyMS function.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 87395a7..c272a30 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -1242,6
It does not make sense for this function to be inside r128_driver.c
since it is only called from a function inside r128_crtc.c.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_crtc.c | 78 +++
src/r128_driver.c | 73
r128_crtc.c is the more logical place this function should be located.
R128PLLWaitForReadUpdateComplete and R128PLLWriteUpdate functions were
moved as well.
Signed-off-by: Kevin Brace
---
src/r128_crtc.c | 89 +++
src/r128_driver.c | 89
r128_crtc.c is the more logical place this function should be located.
R128PLL2WaitForReadUpdateComplete and R128PLL2WriteUpdate functions were
moved as well.
Signed-off-by: Kevin Brace
---
src/r128_crtc.c | 85 ++
src/r128_driver.c | 86
It does not make sense for this function to be inside r128_driver.c
since it is only called from a function inside r128_output.c.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_driver.c | 13 -
src/r128_output.c | 13 +
3 files changed, 13 insertions
r128_crtc.c is the more logical place this function should be located.
Signed-off-by: Kevin Brace
---
src/r128_crtc.c | 20
src/r128_driver.c | 20
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/r128_crtc.c b/src/r128_crtc.c
r128_output.c is the more logical place this function should be located.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 10 --
src/r128_output.c | 10 ++
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 3a20bbd
r128_crtc.c is the more logical place this function should be located.
Signed-off-by: Kevin Brace
---
src/r128_crtc.c | 18 ++
src/r128_driver.c | 18 --
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/r128_crtc.c b/src/r128_crtc.c
index
It does not make sense for this function to be inside r128_driver.c
since it is only called from a function inside r128_crtc.c.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_crtc.c | 28
src/r128_driver.c | 28
3
It does not make sense for this function to be inside r128_driver.c
since it is only called from a function inside r128_crtc.c.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_crtc.c | 55 +++
src/r128_driver.c | 55
Signed-off-by: Kevin Brace
---
src/r128.h| 6 ++
src/r128_driver.c | 6 --
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/r128.h b/src/r128.h
index aa98dd0..6142ff8 100644
--- a/src/r128.h
+++ b/src/r128.h
@@ -498,6 +498,12 @@ do
It does not make sense for this function to be inside r128_driver.c
since it is only called from a function inside r128_crtc.c.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_crtc.c | 55 +++
src/r128_driver.c | 55
It does not make sense for this function to be inside r128_driver.c
since it is only called from a function inside r128_crtc.c.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_crtc.c | 28
src/r128_driver.c | 28
3
driver commit privilege.
Moving forward, I will always post the patches for r128 DDX code and leave it
there for 3 to 5 days in case you want to comment on it.
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
> Sent: Monday, June 11, 2018 at 7:04 AM
> From: "C
, and I
am willing to invest time in it.
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
> Sent: Tuesday, June 05, 2018 at 8:16 PM
> From: "Connor Behan"
> To: "Michel Dänzer" , "Kevin Brace"
> Cc: xorg-devel@lists.x.org
> Sub
It does not make sense for this function to be inside r128_driver.c
since it is only called from a function inside r128_crtc.c.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_crtc.c | 82 +++
src/r128_driver.c | 82
It does not make sense for this function to be inside r128_driver.c
since it is only called from a function inside r128_crtc.c.
Signed-off-by: Kevin Brace
---
src/r128.h| 1 -
src/r128_crtc.c | 111 ++
src/r128_driver.c | 109
Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
> Sent: Wednesday, June 06, 2018 at 3:28 PM
> From: "Adam Jackson"
> To: "Kevin Brace" , xorg-devel@lists.x.org
> Subject: Re: Obtaining Xorg DDX commit privilege
>
> I'm fine with this, but w
plethora of display devices, a lot more
hardware initialization often have to happen, and I did not think it was
desirable for that to occur this early within PreInit callback.
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
> Sent: Wednesday, June 06, 2018 at 12:06 PM
>
., PowerMac), so I figured, why not do anything even if we are
using an x86 processor?
In general, I am looking to reduce the calls to VBE, and I think r128 should
ultimately only handle DDX UMS and DRM KMS at most.
In other words, VBE and FBDEV should not be used.
Kevin Brace
Brace Computer
xf86-video-* DDXs.
I did post several patches over at xorg-driver-ati mailing list if that is what
is needed to earn this privilege.
I hope someone who handles freedesktop.org account matters intervenes soon.
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
In preparation of adding a new mode setting code path.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 67 +++
1 file changed, 38 insertions(+), 29 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 0b30b83..aaa4245
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index b29b191..dd3521c 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -680,29 +680,31
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index dd3521c..0b30b83 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -1278,9 +1278,6 @@ Bool R128PreInit(ScrnInfoPtr pScrn
This removes a VBE (VESA BIOS Extension) related call when probing.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 5c526f7..b29b191 100644
--- a/src
This is similar to how the sample code for PreInit callback function
shown in XFree86 DDX Design (ddxDesign.pdf) design guide does it.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
This is similar to how the sample code for PreInit callback function
shown in XFree86 DDX Design (ddxDesign.pdf) design guide does it.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
This is similar to how the sample code for PreInit callback function
shown in XFree86 DDX Design (ddxDesign.pdf) design guide does it.
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/r128_driver.c b/src
Signed-off-by: Kevin Brace
---
src/r128_driver.c | 35 ---
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/src/r128_driver.c b/src/r128_driver.c
index 347c804..8bfa784 100644
--- a/src/r128_driver.c
+++ b/src/r128_driver.c
@@ -643,8 +643,6
Server
Version 1.21 development cycle, that will be appreciated.
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists
olution.
I hope this serious performance bug can be fixed by the time of X Server 1.20
release and maybe backported to 1.18 and 1.19.
Regards,
Kevin Brace
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
I
-video-openchrome
User focused OpenChrome mailing list:
https://lists.freedesktop.org/mailman/listinfo/openchrome-users
Development focused OpenChrome mailing list:
https://lists.freedesktop.org/mailman/listinfo/openchrome-devel
Regards,
Kevin Brace
The OpenChrome Project maintainer
Hi Michael,
> Sent: Monday, January 02, 2017 at 11:02 AM
> From: Michael <macal...@netbsd.org>
> To: "Kevin Brace" <kevinbr...@gmx.com>
> Cc: xorg-devel@lists.x.org, CK <nibb...@gmx.us>
> Subject: Re: VT8623 [Apollo CLE266]
>
> Hello,
>
>
generation OpenChrome DRM mainlined with Linux kernel
at some point, but it might take a year or more for this to happen since the
code still contains too many bugs left by the previous developer.
Regards,
Kevin Brace
The OpenChrome Project maintainer / developer
, but not with OpenChrome for
now due to its KMS bug in the drm-openchrome).
Of course, I still see the rendering bugs, and I will like to fix it for people
who still care about it.
Regards,
Kevin Brace
___
xorg-driver-ati mailing list
xorg-driver-ati
Signed-off-by: Kevin Brace <kevinbr...@gmx.com>
---
src/Makefile.am | 1 -
src/r128_exa.c| 675 ++-
src/r128_exa_render.c | 705 --
3 files changed, 674 insertions(+), 707 del
Hi,
My name is Kevin Brace and I am the current project maintainer of OpenChrome
project for VIA Technologies IGP.
I have managed two new releases of OpenChrome in the past 5 months.
https://lists.freedesktop.org/archives/openchrome-users/2016-April/007254.html
https://lists.freedesktop.org
While the compilation script was updated, for some reason, the source
code did not get the update.
Signed-off-by: Kevin Brace <kevinbr...@gmx.com>
---
src/r128_crtc.c |6 ++
src/r128_output.c |6 ++
2 files changed, 12 insertions(+)
diff --git a/src/r128_crtc.c
Hi Pekka,
Can I include your name in the commit I will put into OpenChrome shortly?
It will look like this.
Suggested-by: Pekka Paalanen <"Your e-mail">
Signed-off-by: Kevin Brace <kevinbr...@gmx.com>
Let me know if it is okay.
If you do not want your name included, I will
Hi,
I just want some clarifications on ClockRange and ClockRanges.
I will like to know which version of x.org xserver got rid of ClockRanges type.
I was compiling OpenChrome on Ubuntu and Lubuntu 10.04, and was getting a
warning regarding pointer type.
This is the only warning I get when I
-devel/2015-November/thread.html
I have about close to 20 patches I will like to apply.
Regards,
Kevin Brace
___
xorg@lists.x.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: http://lists.x.org/mailman/listinfo/xorg
Your
Replaces VIA_VM800 label with VIA_P4M800PRO label inside via_driver.c
due to the fact that there is no such product as VM800 chipset from
VIA Technologies. Of course, references to VIA_VM800 label in other
files were also replaced as well. The VM800 chipset the source code
refers to really is
201 - 280 of 280 matches
Mail list logo