Re: [PATCH:libXv 4/7] Require ANSI C89 pre-processor, drop pre-C89 token pasting support

2013-06-23 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sun, 23 Jun 2013 11:53:47 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- src/Xvlibint.h | 15 --- 1 file changed, 15 deletions(-) diff --git

Re: [PATCH:libXv 1/7] Remove unnecessary casts from Xmalloc calls

2013-06-23 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sun, 23 Jun 2013 11:53:44 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- src/Xv.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions

Re: [PATCH:libXpm] Close fd if fdopen() or xpmPipeThrough() fails in OpenWriteFile()

2013-04-22 Thread Mark Kettenis
initialized at line 332 with open fd leaks when strcmp(.Z, (filename + (len - 2))) != 0 at line 337 and strcmp(.gz, (filename + (len - 3))) != 0 at line 340. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- src

Re: [xserver 1.14/master] dixstruct.h: fix segfaults - char is unsigned for ARM and PowerPC architectures

2013-04-22 Thread Mark Kettenis
xserver into usable for ARM - ping? Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 04/18] test/input: Fix double-aligned test in dix_valuator_alloc() on m68k

2013-03-27 Thread Mark Kettenis
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Wed, 27 Mar 2013 14:20:37 +0100 On m68k, doubles are not 64-bit aligned, just like on i386 and sh. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- test/input.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH 1/7] randr: fix set but unused warnings

2013-02-13 Thread Mark Kettenis
For the series: Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] test/input: Replace negative architecture test by test for 64-bit

2013-02-12 Thread Mark Kettenis
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Tue, 12 Feb 2013 11:17:22 +0100 The test for double-aligned members in dix_valuator_alloc() currently depends on if !defined(__i386__) !defined(__sh__). This covers m68k, where it fails. According to the comment, the test should be

Re: [PATCH] test/input: Replace negative architecture test by test for 64-bit

2013-02-12 Thread Mark Kettenis
Sender: geert.uytterhoe...@gmail.com Date: Tue, 12 Feb 2013 14:03:50 +0100 On Tue, Feb 12, 2013 at 1:40 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Geert Uytterhoeven ge...@linux-m68k.org Date: Tue, 12 Feb 2013 11:17:22 +0100 The test for double-aligned members

Re: [PATCH] If neither HAL nor udev backends are enabled, warn the user

2013-02-05 Thread Mark Kettenis
Date: Mon, 4 Feb 2013 08:17:26 +1000 From: Peter Hutterer peter.hutte...@who-t.net On Fri, Feb 01, 2013 at 11:09:41AM +0100, Mark Kettenis wrote: Date: Fri, 1 Feb 2013 09:20:38 +1000 From: Peter Hutterer peter.hutte...@who-t.net If both are missing, input device hotplugging

Re: [PATCH] If neither HAL nor udev backends are enabled, warn the user

2013-02-01 Thread Mark Kettenis
Date: Fri, 1 Feb 2013 09:20:38 +1000 From: Peter Hutterer peter.hutte...@who-t.net If both are missing, input device hotplugging will not work out of the box. While we still have a DBus-API or the user may want to set AAD off all the time, the most likely source of this is misconfiguration

Re: [PATCH 2/6] dbe: Cleanup in CloseScreen hook not ext CloseDown

2012-11-07 Thread Mark Kettenis
From: Daniel Stone dan...@fooishbar.org Date: Wed, 7 Nov 2012 17:58:19 +1100 From: Robert Bragg rob...@linux.intel.com Instead of registering an extension CloseDownProc when adding the dbe extension this patch hooks into pScreen-CloseScreen so that the chain of pScreen-DestroyWindow

Re: [PATCH 4/6] xfree86: Remove deprecated unimplemented xf86MapReadSideEffects

2012-10-18 Thread Mark Kettenis
changed, 17 deletions(-) Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 5/6] mipointer: Remove deprecated miPointerCurrentScreen

2012-10-18 Thread Mark Kettenis
| 5 - 3 files changed, 1 insertion(+), 19 deletions(-) Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH:xscope 04/24] Convert some for loops to use C99-style inline variable declarations

2012-09-03 Thread Mark Kettenis
Date: Sat, 01 Sep 2012 10:21:14 -0700 From: Alan Coopersmith alan.coopersm...@oracle.com On 09/ 1/12 03:33 AM, Mark Kettenis wrote: From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 31 Aug 2012 22:17:46 -0700 Please don't do this. Some OpenBSD platforms are still stuck

Re: [PATCH:xscope 04/24] Convert some for loops to use C99-style inline variable declarations

2012-09-01 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 31 Aug 2012 22:17:46 -0700 Please don't do this. Some OpenBSD platforms are still stuck with GCC 2.95.3. GCC 2.95.3 is almost a C99 compiler, but doesn't support the C99 (mis)feature of allowing variable declarations after

Re: [PATCH:xscope 09/24] Convert remaining bcopy() calls to memcpy()

2012-09-01 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 31 Aug 2012 22:17:51 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org common.c |2 +- fd.c |2 +- server.c |6 +++--- 3 files changed, 5

Re: [PATCH:xscope 06/24] SaveBytes: drop unnecessary casts in bcopy() call

2012-09-01 Thread Mark Kettenis
alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- server.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH:xscope 07/24] Convert remaining sprintf calls to snprintf

2012-09-01 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 31 Aug 2012 22:17:49 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- common.c |2 +- fd.c |8 +--- prtype.c |4 ++-- scope.c |6

Re: [PATCH:xscope 17/24] Print UTF8_STRING properties as text if locale uses UTF-8 charset

2012-09-01 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 31 Aug 2012 22:17:59 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- configure.ac |2 +- prtype.c | 19 --- scope.c | 24

Re: [PATCH:xscope 21/24] Refactor fd closing into CloseFD helper function

2012-09-01 Thread Mark Kettenis
sockets. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com See comments below. Otherwise: Reviewed-by: Mark Kettenis kette...@openbsd.org --- fd.c| 23 +-- fd.h|1 + scope.c | 12 +++- 3 files changed, 21 insertions(+), 15 deletions

Re: [PATCH xserver 1/1] list: Use offsetof() to determine member offsets within a structure

2012-08-29 Thread Mark Kettenis
Date: Wed, 29 Aug 2012 16:35:50 +1000 From: Peter Hutterer peter.hutte...@who-t.net On Tue, Aug 28, 2012 at 10:38:08AM -0700, Jeremy Huddleston Sequoia wrote: Some compilers have difficulty with the previous implementation which relies on undefined behavior according to the C standard.

Re: [PATCH xserver 1/1] list: Use offsetof() to determine member offsets within a structure

2012-08-29 Thread Mark Kettenis
Date: Wed, 29 Aug 2012 08:09:14 -0700 From: Alan Coopersmith alan.coopersm...@oracle.com On 08/28/12 11:59 PM, Jeremy Sequoia wrote: On 08/28/12, *Peter Hutterer * peter.hutte...@who-t.net wrote: -#define __container_of(ptr, sample, member) \ -(void

Re: [PATCH lib/libxtrans] If Socket is getting interrupted with signal EINTR, after re attempts we are closing socket connection, which is wrong.

2012-08-23 Thread Mark Kettenis
From: Arvind Umrao arvind.um...@oracle.com Date: Thu, 23 Aug 2012 16:07:39 +0530 Code changes are integrated in Solaris and now I am trying to give back to community. If Socket is getting interrupted with signal EINTR, we should keep socket in progress state(TRANS_IN_PROGRESS) instead of

Re: [PATCH xorg-gtest 01/11] Add Red Hat copyright notices

2012-08-16 Thread Mark Kettenis
From: Peter Hutterer peter.hutte...@who-t.net Date: Thu, 16 Aug 2012 16:36:34 +1000 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- COPYING | 1 + include/xorg/gtest/evemu/xorg-gtest-device.h | 1 +

Re: libdrm-2.4.37: use ETIMEDOUT instead of ETIME?

2012-08-07 Thread Mark Kettenis
From: Matt Turner matts...@gmail.com Date: Tue, 17 Jul 2012 12:04:26 -0700 On Tue, Jul 17, 2012 at 11:58 AM, Thomas Klausner w...@netbsd.org wrote: On Tue, Jul 17, 2012 at 07:02:56AM -0700, Matt Turner wrote: On Mon, Jul 16, 2012 at 11:34 AM, Thomas Klausner w...@netbsd.org wrote:

Re: [PATCH] Fix statement not reached warning in _DMXXineramaActive

2012-05-22 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Mon, 21 May 2012 14:47:45 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- hw/dmx/dmx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH] int10/vbe: don't use xf86Screens. (ABI) (v2)

2012-05-16 Thread Mark Kettenis
Date: Wed, 16 May 2012 10:16:24 +0100 From: Dave Airlie airl...@gmail.com @@ -340,7 +341,7 @@ vbeDoEDID(vbeInfoPtr pVbe, pointer pDDCModule)      if (!DDC_data)          return NULL; -    pMonitor = xf86InterpretEDID(pVbe-pInt10-scrnIndex, DDC_data); +    pMonitor =

Re: [PATCH] int10/vbe: don't use xf86Screens. (ABI) (v2)

2012-05-16 Thread Mark Kettenis
Date: Wed, 16 May 2012 10:31:26 +0100 From: Dave Airlie airl...@gmail.com On Wed, May 16, 2012 at 10:24 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Wed, 16 May 2012 10:16:24 +0100 From: Dave Airlie airl...@gmail.com @@ -340,7 +341,7 @@ vbeDoEDID(vbeInfoPtr pVbe

Re: [PATCH 0/4] BUG_RETURN_VAL macros

2012-05-15 Thread Mark Kettenis
From: Peter Hutterer peter.hutte...@who-t.net Date: Tue, 15 May 2012 20:26:37 +1000 I got annoyed having to write constructs like BUG_WARN(foo); if (foo) return FALSE; and similar. glib has useful macros like g_return_if_fail and similar, these are macros that essentially do the

Re: [PATCH] xfree86: use udev to provide device enumeration for kms devices (v4

2012-05-14 Thread Mark Kettenis
From: Dave Airlie airl...@gmail.com Date: Mon, 14 May 2012 08:42:50 +0100 So the bit below is what effectively defines the interface for the new platform bus probe? You basically pass the a list of attributes to the driver probe routine and which then gets to decide whether it wants to attach

Re: [PATCH 1/4] Convert sbusPaletteKey to latest DevPrivate API

2012-05-14 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Mon, 14 May 2012 11:19:08 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- Already being used in the Xorg 1.12 packages for Solaris, since we can't build

Re: [PATCH libXau] Free XauFileName() static buffer at exit

2012-04-21 Thread Mark Kettenis
From: Chase Douglas chase.doug...@canonical.com Date: Fri, 20 Apr 2012 14:18:59 -0700 XauFileName() may allocate and return a static buffer. The only way to ensure it is freed is to deallocate it when the program exits. Which is fairly pointless given that the program is exiting anyway. I

Re: [PATCH 1/6] Add global variable inSignalContext

2012-04-06 Thread Mark Kettenis
From: Chase Douglas chase.doug...@canonical.com Date: Fri, 6 Apr 2012 11:25:54 -0700 This will be used for checking for proper logging when in signal context. To be really safe, isSignalContext should be sig_atomic_t. Cheers, Mark ___

Re: [PATCH xserver 2/2] xfree86: add support for Cygwin

2012-03-29 Thread Mark Kettenis
Date: Wed, 28 Mar 2012 23:05:51 -0500 From: Yaakov (Cygwin/X) yselkow...@users.sourceforge.net On 2012-03-28 22:19, Alan Coopersmith wrote: On 03/27/12 10:16 PM, Yaakov (Cygwin/X) wrote: + +i2c/libi2c.la: + $(MAKE) -C $(@D) $(@F) + +dixmods/libdixmods.la: + $(MAKE) -C $(@D)

Re: [PULL to discuss] Remove kdrive, Xnest, and Xvfb

2012-03-27 Thread Mark Kettenis
Date: Tue, 27 Mar 2012 06:03:03 -0700 From: Jamey Sharp ja...@minilop.net On 3/26/12, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 03/26/12 09:07 PM, Jamey Sharp wrote: Maybe I have it right this time: On Debian, there's no problem, because /usr/bin/X is a trivial suid wrapper

Re: [RFC] server-private and public header separation

2012-03-24 Thread Mark Kettenis
This is just a quickfire patch to show the principle, it has not been tested much. Plus, it's more of an idea right now, not sure if I'll find the time to do it. Right now, we export virtually everything including the gory bits of every struct. Which causes us to break the ABI whenever we

Re: [PATCH] Use O_CLOEXEC for internal file descriptors

2012-02-27 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Mon, 27 Feb 2012 11:35:20 -0500 Well, almost all of them. zlib doesn't support e in the mode string in gzopen() though it will silently accept and ignore it, and Solaris appears not to support e in the mode string at all. Neither does OpenBSD. And

Re: [PATCH] Use O_CLOEXEC for internal file descriptors

2012-02-27 Thread Mark Kettenis
Date: Mon, 27 Feb 2012 10:41:15 -0800 From: Alan Coopersmith alan.coopersm...@oracle.com On 02/27/12 08:35 AM, Adam Jackson wrote: Well, almost all of them. zlib doesn't support e in the mode string in gzopen() though it will silently accept and ignore it, and Solaris appears not to

Re: [PATCH libXi] Fix bus error on MIPS N32 for bug #38331.

2012-02-20 Thread Mark Kettenis
From: =?UTF-8?q?Micha=C5=82=20Mas=C5=82owski?= m...@mtjm.eu Date: Mon, 20 Feb 2012 20:09:30 +0100 XIValuatorClassInfo might have an address of 4 bytes modulo 8, while it contains a double which needs 8 byte alignment. This is fixed by adding extra padding before instances of this

Re: [PATCH:listres] Replace computed printf format string with static string

2012-02-12 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 10 Feb 2012 19:33:38 -0800 Allows format string analysis by gcc other code checkers. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org

Re: [PATCH] Remove XAA

2012-01-21 Thread Mark Kettenis
Hi, The following commit is available in the 'xaa' branch of git://people.freedesktop.org/~daniels/xserver - I think the commit message explains it fairly well. I've got patches to intel, ati, mach64 and mga to fix their builds in the absence of XAA; a lot of other drivers[0] still

Re: [PATCH:intel-gpu-tools 3/6] Use sched_yield if pthread_yield is not available

2012-01-06 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 6 Jan 2012 14:37:18 -0800 Despite the name implying it's a standard part of the POSIX threads API, pthread_yield is actually non-standard and not entirely portable. For systems like Solaris that don't have it, fall back to

Re: [PATCH] vgahw: Fix DACDelay() macro to use the driver's vtable

2012-01-04 Thread Mark Kettenis
timing as reading from the real I/O ports. But I guess there's nothing really that can be done about that. Tested-by: Jeff Chua jeff.chua.li...@gmail.com Signed-off-by: Adam Jackson a...@redhat.com So, Reviewed-by: Mark Kettenis kette...@openbsd.org --- hw/xfree86/vgahw/vgaHW.h |8

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Mark Kettenis
X-Original-To: xorg-devel@lists.x.org From: Daniel Stone dan...@fooishbar.org Date: Wed, 4 Jan 2012 17:02:30 + Fixes a compiler warning due to discarding the const qualifier as it comes back from the option code. If Daniel Kurtz's analysis of the problem is right, and I believe it is,

Re: [PATCH synaptics] Constify priv-device

2012-01-04 Thread Mark Kettenis
Date: Wed, 4 Jan 2012 19:01:31 + From: Daniel Stone Hi, If Daniel Kurtz's analysis of the problem is right, and I believe it is, then this diff is just as wrong as the previous diff from Peter. It also means that the real culprit is Peter's change to constify

Re: [PATCH libpciaccess] OpenBSD: Implement map_legacy and legacy_io

2012-01-03 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sat, 31 Dec 2011 15:08:52 -0500 On Dec 31, 2011, at 2:50 PM, Mark Kettenis wrote: From: Jeremy Huddleston jerem...@apple.com Date: Sat, 31 Dec 2011 10:28:11 -0500 There is a logic error in the preprocessing which seems to assume

Re: [PATCH xf86-video-ati] Update for new vgaHW API.

2012-01-01 Thread Mark Kettenis
matthieu.he...@laas.fr Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH libpciaccess] OpenBSD: Implement map_legacy and legacy_io

2011-12-31 Thread Mark Kettenis
diff. I'll probably push this somewhere next week. Signed-off-by: Mark Kettenis kette...@openbsd.org Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr Tested-by: Matthieu Herrb matthieu.he...@laas.fr --- src/openbsd_pci.c | 153 ++- src

Re: Patches for xf86-video-{tdfx,trident,xgi}

2011-12-30 Thread Mark Kettenis
From: Johannes Obermayr johannesoberm...@gmx.de Date: Fri, 30 Dec 2011 12:50:18 +0100 --- src/vb_i2c.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/vb_i2c.c b/src/vb_i2c.c index 96e26e3..6fc95c9 100755 --- a/src/vb_i2c.c +++ b/src/vb_i2c.c @@

Re: [PATCH] Check MGAAllocAdaptor() for memory allocation failure

2011-12-29 Thread Mark Kettenis
...@oracle.com --- src/mga_video.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) Can't make things worse. Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

[PATCH libpciaccess] OpenBSD: Implement map_legacy and legacy_io

2011-12-29 Thread Mark Kettenis
Signed-off-by: Mark Kettenis kette...@openbsd.org Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr Tested-by: Matthieu Herrb matthieu.he...@laas.fr --- src/openbsd_pci.c | 155 ++- src/pciaccess_private.h |1 + 2 files changed, 154

Re: [xproto: PATCH] Xmd.h: amd64-x32 ABI defines sizeof(long) == sizeof (void*) == 4

2011-12-28 Thread Mark Kettenis
From: Lu, Hongjiu hongjiu...@intel.com Date: Wed, 28 Dec 2011 14:34:09 + __AMD64__ is defined when 64bit x86 instruction set is used, which is true for x32. The difference is x32 doesn't define __LP64__. Chapter 7, Development Environment, of the AMD64 ABI (the non-x32 version) does

Re: [xproto: PATCH] Xmd.h: amd64-x32 ABI defines sizeof(long) == sizeof (void*) == 4

2011-12-20 Thread Mark Kettenis
Date: Tue, 20 Dec 2011 08:41:44 -0800 From: Alan Coopersmith alan.coopersm...@oracle.com Are you sure that every real amd64 platform that uses __amd64__ defines __LP64__ as well? Not sure if you'd call 64-bit Windows a real amd64 platform, but given that Microsoft made the brilliant

Re: [PATCH:libSM 6/8] Remove a bunch of unnecessary casts with malloc free calls

2011-12-06 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Mon, 5 Dec 2011 20:06:19 -0800 With modern compilers and headers, they cause more problems than they solve and just hide real issues. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette

Re: [PATCH:libSM 5/8] Replace malloc(strlen) + strcpy sets with strdup calls

2011-12-06 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Mon, 5 Dec 2011 20:06:18 -0800 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- src/sm_client.c |5 + src/sm_genid.c |6 ++ src/sm_manager.c

Re: [PATCH:libSM 2/8] Move and rename temp[4] definition to reduce confusion with temp[256]

2011-12-06 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Mon, 5 Dec 2011 20:06:15 -0800 Both variables were locals in different scope levels of the same function, leading to both confusing code and gcc -Wshadow warnings: sm_genid.c: In function 'SmsGenerateClientID': sm_genid.c:160:10:

Re: [PATCH:libxtrans 4/4] Rename index stat variables to stop gcc -Wshadow warnings

2011-12-06 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Mon, 5 Dec 2011 20:36:32 -0800 It doesn't like local variables with the same name as system library functions. Which IMHO is totally ridiculous and makes -Wshadow useless, since it means that any namespace pollution from system

Re: [PATCH:libxtrans 3/4] Remove unnecessary casts on malloc, calloc free calls

2011-12-06 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Mon, 5 Dec 2011 20:36:31 -0800 Minor nit; see below. Reviewed-by: Mark Kettenis kette...@openbsd.org Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Xtrans.c | 10 +- Xtranslcl.c | 26

Re: [PATCH:libxtrans 2/4] Replace malloc(strlen)+strcpy with strdup

2011-12-06 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Mon, 5 Dec 2011 20:36:30 -0800 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- Xtrans.c| 26 +++--- Xtranslcl.c |8 ++-- 2 files

Re: [PATCH 4/6] xfree86: Remove the pretense of EDID v2 support

2011-12-02 Thread Mark Kettenis
(and, for the monitors mentioned, it probably is only 128). Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- hw/xfree86/ddc/ddcProperty.c | 47 +++-- 1 files changed, 4 insertions(+), 43 deletions

Re: [PATCH 2/6] xfree86: Drop DDC1 support

2011-12-02 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 1 Dec 2011 16:50:57 -0500 This was an ancient hack to try to fetch the EDID block by reusing the vertical sync pin as a serial line. It's never been very reliable, and DDC2 was introduced in 1994 which is plenty recent enough. Hmm, if

Re: [PATCH 6/6] xfree86: Remove most of EDID printing

2011-12-01 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 1 Dec 2011 16:51:01 -0500 The important part of this is the mode list, which we already print in another form. Everything else is cosmetic and better done in the session. Sorry, but I disagree. The EDID information is useful when debugging

Re: [PATCH] pkgconfig files should be installed to $(libdir)

2011-11-23 Thread Mark Kettenis
From: Gaetan Nadon mems...@videotron.ca Date: Thu, 17 Nov 2011 09:04:36 -0500 We need to comply with the FHS standard. If we don't, other installations will break as they use a /usr/share as a common filesystem for architecture independent data. The location is not really a project

Re: [PATCH:libFS 1/2] Change FSOpenServer and FSServerName to take const char * args.

2011-11-12 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 11 Nov 2011 21:43:04 -0800 diff --git a/src/FSServName.c b/src/FSServName.c index 022be82..a535b38 100644 --- a/src/FSServName.c +++ b/src/FSServName.c @@ -59,12 +59,12 @@ in this Software without prior written authorization

Re: [PATCH:xfs 3/4] Move os/config.h into os/config.c

2011-11-12 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 11 Nov 2011 22:49:09 -0800 The only file that needed the only remaining definition was config.c, so there's no point keeping a header file around for a single #define Dunno, there is a school of thought that says that

Re: [PATCH:libFS 2/2] Mark pattern argument to FSListFonts* as const char *

2011-11-12 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 11 Nov 2011 21:43:05 -0800 Needed to fix gcc -Wwrite-strings warnings in clients such as fslsfonts diff --git a/src/FSlibInt.c b/src/FSlibInt.c index 5a33b64..eea9840 100644 --- a/src/FSlibInt.c +++ b/src/FSlibInt.c @@

Re: [PATCH:xfs 1/4] Make CONFIG_ERR_* values be strings instead of indexes in ConfigErrors array

2011-11-12 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 11 Nov 2011 22:49:07 -0800 Allows gcc to check printf format strings instead of just giving warnings. Since these #defines are only used in config.c, define them directly there, instead of in the config.h header that no one else

Re: [PATCH:xfs 4/4] Use config.h for autoconf output now that there's no conflict

2011-11-12 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 11 Nov 2011 22:49:10 -0800 Now that os/config.h is gone, no reason to special case and have xfs-config.h for the autoconf generated header. Ah, *there* is your reason for getting rid of the config.h file. Makes more sense now.

Re: [PATCH xserver 1/1] xfree86: Fix powerpc build with -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast

2011-11-03 Thread Mark Kettenis
with *virtual* addresses, which are guaranteed to fit into an uintptr_t. Signed-off-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Mark Kettenis kette...@openbsd.org If you guys trust such a thing for a Linux-only diff from me ;). --- hw/xfree86/os-support/linux/lnx_video.c |8

Re: [PATCH] xfree86: Fix powerpc build with -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast

2011-11-02 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Tue, 01 Nov 2011 19:07:42 -0700 On Nov 1, 2011, at 5:48 PM, Daniel Stone wrote: Hi, On 1 November 2011 22:05, Jeremy Huddleston jerem...@apple.com wrote: While this does fix the build failure, I'd much rather change memType to be

Re: [PATCH] kdrive: switch to new InputOption API.

2011-10-25 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Mon, 24 Oct 2011 19:41:00 -0700 On Oct 24, 2011, at 7:05 PM, Keith Packard wrote: And, do we allow the use of strndup in the server? Alan just asked that a few days ago ;). I wouldn't be against using strndup, but there would need

Re: [PATCH 1/2] xfree86: Fix type of IOPortBase to be a pointer

2011-10-16 Thread Mark Kettenis
This addresses issues on 64bit systems where the IOPortBase is higher in memory space. -_X_EXPORT unsigned int IOPortBase; /* Memory mapped I/O port area */ +_X_EXPORT pointer IOPortBase; /* Memory mapped I/O port area */ Sorry, but you can't do it that way, at least not without making

Re: [PATCH v2] mieq: Provide better adaptability and diagnostics during mieq overflow

2011-10-16 Thread Mark Kettenis
from signal handlers. So you can't use malloc(3) and free(3) to grow the queue. Signed-off-by: Jeremy Huddleston jerem...@apple.com Sorry, Nacked-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH] xfree86: Fix prototype for ConfigFilter

2011-10-16 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sun, 16 Oct 2011 02:27:08 -0700 This allows scan.c to build with -Wincompatible-pointer-types Build regression introduced by: efa5269f23c2237eb5368bf5245ffbbf35714153 Signed-off-by: Jeremy Huddleston jerem...@apple.com Guess it would

Re: [PATCH v2] mieq: Provide better adaptability and diagnostics during mieq overflow

2011-10-16 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sun, 16 Oct 2011 04:59:42 -0700 Did you not see v3 which was sent before your email? ;) Nope. Looks like v3 fixes that indeed. ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH v4] dix: add utility functions for double to/fro FP1616/FP3232 conversion

2011-10-15 Thread Mark Kettenis
) does. The only benefit I can see that the ldexp(3) variant has, is that it is more portable. So I wouldn't call this an optimization. And the comment makes the line (too) long, so I would just drop it. Same for the other comments that are similar. Either way. Reviewed-by: Mark Kettenis kette

Re: [PATCH] xfree86: Add Loongson MIPS support

2011-10-15 Thread Mark Kettenis
Date: Thu, 13 Oct 2011 20:26:18 -0700 From: Matt Kraai kr...@ftbfs.org Also, that code is pretty much going to be made obsolete by Jeremy Huddleston's pci bus cleanup diff. A better approach would be to convert the relevant drivers for loongson to use the new pci_io_xxx interfaces in

Re: [PATCH-V4] xserver: Optional backtrace handler

2011-10-13 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Wed, 12 Oct 2011 19:28:00 -0700 On Oct 12, 2011, at 6:12 PM, Alan Coopersmith wrote: On 10/12/11 10:50 AM, Keith Packard wrote: 2. I'd love to figure out how to fork at the time of the error; this would encourage people to actually

Re: [PATCH] xfree86: Add Loongson MIPS support

2011-10-12 Thread Mark Kettenis
Date: Wed, 12 Oct 2011 07:48:00 -0700 From: Alan Coopersmith alan.coopersm...@oracle.com On 10/11/11 11:58 PM, Matt Kraai wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=41038 --- hw/xfree86/dri/sarea.h |2 ++ hw/xfree86/os-support/linux/lnx_video.c

Re: [PATCH:libpciaccess] Solaris: Give better error on realloc failure

2011-10-05 Thread Mark Kettenis
that print messages on stderr like this. But printing half-truths is even worse. So if you need one: Reviewed-by: Mark Kettenis kette...@openbsd.org Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/solx_devfs.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sun, 2 Oct 2011 01:11:50 -0700 On Oct 2, 2011, at 00:10, Matthieu Herrb wrote: Was the libpciaccess issue solved ? You're referring to the missing support from libpciaccess, yes? I'm still waiting on comments from my comments on

Re: [patch] Initialize all screens

2011-09-28 Thread Mark Kettenis
Date: Wed, 28 Sep 2011 20:23:22 +1000 From: Alistair Leslie-Hughes leslie_alist...@hotmail.com diff --git a/dix/devices.c b/dix/devices.c index 0ccf252..644e3e7 100644 --- a/dix/devices.c +++ b/dix/devices.c @@ -351,6 +351,7 @@ EnableDevice(DeviceIntPtr dev, BOOL sendevent)

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-26 Thread Mark Kettenis
Date: Sat, 24 Sep 2011 15:16:49 + From: Daniel Stone dan...@fooishbar.org Hi, On 24 September 2011 13:26, Mark Kettenis mark.kette...@xs4all.nl wrote: It's still work.  And it probably inflicts pain on people like Micahel Daenzer who maintain drivers for older xserver releases. Â

[PATCH xf86-video-chips] PciTag is unused when using libpciaccess

2011-09-26 Thread Mark Kettenis
This should be the right thing to do regardless whether the pci bus cleanup gets committed. Signed-off-by: Mark Kettenis kette...@openbsd.org --- src/ct_driver.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/ct_driver.h b/src/ct_driver.h index 10a24d4..39eeb6e

Re: [PATCH xf86-video-chips] Build fixes for ABI_VIDEODRV_VERSION 12

2011-09-26 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sat, 24 Sep 2011 12:24:56 -0700 On Sep 24, 2011, at 05:28, Mark Kettenis wrote: That doesn't help us. PCITAG is gone, and CARD32 is being used instead. XSERVER_LIBPCIACCESS is still defined. Perhaps *both* changes are necessary

[PATCH] PciTag is unused when using libpciaccess

2011-09-26 Thread Mark Kettenis
This should be the right thing to do regardless whether the pci bus cleanup gets committed. Signed-off-by: Mark Kettenis kette...@openbsd.org --- src/ct_driver.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/ct_driver.h b/src/ct_driver.h index 10a24d4..39eeb6e

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-26 Thread Mark Kettenis
Date: Sat, 24 Sep 2011 18:31:11 +0200 From: Matthieu Herrb matthieu.he...@laas.fr Still only a partial review; looking into the changes to the interfaces that map video memory now. I wanted to look, and more importantly test them, but so far the IOADRESS fallout (plus a few other stuff

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Fri, 23 Sep 2011 20:21:54 -0700 On Sep 23, 2011, at 16:22, Jeremy Huddleston wrote: I'm also testing it on tifa32-linux tinderbox: http://tinderbox.x.org/builds/2011-09-23-0007 A few failures in various video drivers ... but they

Re: [PATCH xf86-video-chips] Build fixes for ABI_VIDEODRV_VERSION 12

2011-09-24 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sat, 24 Sep 2011 00:03:45 -0700 1) Include pciaccess.h for IOADDRESS How does this help you? Nothing in libpciaccess defines IOADDRESS, and adding that typedef to pciaccess.h seems wrong to me. See my previous mail for an easier solution.

Re: [PATCH xf86-video-chips] Build fixes for ABI_VIDEODRV_VERSION 12

2011-09-24 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sat, 24 Sep 2011 04:13:14 -0700 On Sep 24, 2011, at 03:11, Mark Kettenis wrote: From: Jeremy Huddleston jerem...@apple.com Date: Sat, 24 Sep 2011 00:03:45 -0700 1) Include pciaccess.h for IOADDRESS How does this help you

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sat, 24 Sep 2011 04:11:31 -0700 Only a few drivers actually use domainIOBase, but among those are xf86-video-vesa and xf86-video-vmware drivers, which are pretty important ones. The others are xf86-video-ark, xf86-video-sis and

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Thu, 22 Sep 2011 19:52:05 -0700 The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 -0700) are available in the git repository at:

Re: [PATCH 1/2] Add some intramodule dependencies

2011-09-20 Thread Mark Kettenis
Date: Mon, 19 Sep 2011 15:24:19 -0700 From: Alan Coopersmith alan.coopersm...@oracle.com On 09/19/11 15:12, Aaron Plattner wrote: On Mon, Sep 19, 2011 at 02:51:07PM -0700, Alan Coopersmith wrote: libshadow depends on libfb for fbGetWinPrivateKey libvbe depends on libint10 for

Re: [PATCH libpciaccess] PCI: set correct mask value when matching for bridges.

2011-09-07 Thread Mark Kettenis
From: Egbert Eich e...@freedesktop.org Date: Wed, 7 Sep 2011 16:44:48 +0200 The mask must not be zero otherwise the matching condition will never be true: ((val mask) == set). --- src/common_bridge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] [glint] Fix uploading YV12 data to texture buffer on BE machines

2011-08-13 Thread Mark Kettenis
From: Matt Turner matts...@gmail.com Date: Sat, 13 Aug 2011 17:01:36 -0400 On Fri, Mar 11, 2011 at 10:51 PM, Matt Turner matts...@gmail.com wrote: On Mon, Feb 28, 2011 at 11:32 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: On BE machines various hardware byteswapping options

Re: [PATCH 2/4] Properly register session with utmp.

2011-08-08 Thread Mark Kettenis
From: =?UTF-8?q?Mat=C4=9Bj=20Cepl?= mc...@redhat.com Date: Mon, 8 Aug 2011 21:26:48 +0200 I guess we should have corresponding sessreg -d call in config/TakeConsole as well, right? diff --git a/config/GiveConsole b/config/GiveConsole index f8a8c6d..d201a5c 100644 ---

Re: [PATCH 4/4] Add a missing search for libdl to configure.ac.

2011-08-08 Thread Mark Kettenis
From: =?UTF-8?q?Mat=C4=9Bj=20Cepl?= Date: Mon, 8 Aug 2011 21:26:50 +0200 Patch by Adam Jackson ajax at redhat dot com Signed-off-by: Matěj Cepl mc...@redhat.com --- configure.ac |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac

Re: [PATCH 2/4] Properly register session with utmp.

2011-08-08 Thread Mark Kettenis
Date: Mon, 08 Aug 2011 12:57:45 -0700 From: Alan Coopersmith alan.coopersm...@oracle.com On 08/08/11 12:45, Mark Kettenis wrote: From: =?UTF-8?q?Mat=C4=9Bj=20Cepl?= mc...@redhat.com Date: Mon, 8 Aug 2011 21:26:48 +0200 I guess we should have corresponding sessreg -d call in config

Re: [PATCH 3/4] Send a USER_LOGIN event like other Linux login programs do.

2011-08-08 Thread Mark Kettenis
From: =?UTF-8?q?Mat=C4=9Bj=20Cepl?= mc...@redhat.com Date: Mon, 8 Aug 2011 21:26:49 +0200 https://bugzilla.redhat.com/469357 Patch by Steve Grubb sgrubb at redhat dot com Hmm, isn't PAM already supposed to take care of that (through the pam_audit module)? configure.ac| 22

Re: [PATCH 1/4] Use explicitly /bin/sh for running of Xwilling script via su.

2011-08-08 Thread Mark Kettenis
From: =?UTF-8?q?Mat=C4=9Bj=20Cepl?= mc...@redhat.com Date: Mon, 8 Aug 2011 21:26:47 +0200 su nobody -c command uses a default shell of the user, which in case of nobody is (at least on Linux distros) /sbin/nologin. Makes sense to me. Reviewd-by: Mark Kettenis kette...@openbsd.org

<    1   2   3   4   5   6   >