Re: [BUG pixman] f9c91ee2f27eaea68d8c3a130bf7d4bc0c860834 breaks compilation

2012-07-09 Thread Matt Turner
On Mon, Jul 9, 2012 at 1:55 AM, Knut Petersen knut_peter...@t-online.de wrote: Søren, the bad commit was supposed to fix a gcc -O0 compile problem, but it breaks gcc -O0 compilation here. Reverting f9c91ee2 fixes the problem for me. Is this build automated? If it's an automated build that

Re: [PATCH] Change memcpy to memmove in fbBlt

2012-05-30 Thread Matt Turner
, width);         return;     } -- 1.7.7 We had a similar patch in a Gentoo overlay but without any description of why it's needed. Knowing now what its purpose is, Acked-by: Matt Turner matts...@gmail.com Although, I'm surprised there isn't a bug link or similar attached to this patch. If it can

Re: [PATCH 2/2] glproto: Add define for GLX_EXT_create_context_es2_profile

2012-05-23 Thread Matt Turner
GLX_CONTEXT_MINOR_VERSION_ARB      0x2092 @@ -297,6 +298,7 @@ extern C {  #define GLX_CONTEXT_CORE_PROFILE_BIT_ARB   0x0001  #define GLX_CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB   0x0002 +#define GLX_CONTEXT_ES2_PROFILE_BIT_EXT    0x0004  /*  * GLX_ARB_create_context_robustness -- 1.7.6.5 Reviewed-by: Matt Turner matts

Re: [PATCH 1/2] glproto: Fix typo in name of GLX_LOSE_CONTEXT_ON_RESET_ARB

2012-05-23 Thread Matt Turner
GLX_LOST_CONTEXT_ON_RESET_ARB      0x8252 +#define GLX_LOSE_CONTEXT_ON_RESET_ARB      0x8252  #ifdef __cplusplus  }  #endif -- 1.7.6.5 Indeed, see http://www.opengl.org/registry/specs/ARB/glx_create_context_robustness.txt Reviewed-by: Matt Turner matts...@gmail.com ___ xorg

[PATCH 1/3] compiler.h: split MIPS and ARM code

2012-05-10 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/common/compiler.h | 55 - 1 files changed, 48 insertions(+), 7 deletions(-) diff --git a/hw/xfree86/common/compiler.h b/hw/xfree86/common/compiler.h index 0abdfb6..27bce92 100644 --- a/hw

[PATCH 2/3] compiler.h: change MIPS IOPortBase to ioBase

2012-05-10 Thread Matt Turner
This will allow us to use the existing __powerpc__ code paths in lnx_video.c. Also remove unnecessary casts. Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/common/compiler.h| 33 -- hw/xfree86/os-support/linux/lnx_video.c |5 +++- 2

[PATCH 3/3] Make MIPS use existing PowerPC code paths in lnx_video.c

2012-05-10 Thread Matt Turner
This allows X to work on the Lemote Yeeloong laptop. Signed-off-by: Matt Turner matts...@gmail.com --- ioBase_phys = 0x1fd0 is certainly a hack, and almost definitely breaks X on SGI MIPS systems. How can I do this more cleanly? It seems mips doesn't have pciconfig_iobase. hw/xfree86/dri

[PATCH modesetting] configure.ac: remove DRI and RENDER

2012-05-08 Thread Matt Turner
Driver doesn't support either of these. Signed-off-by: Matt Turner matts...@gmail.com --- configure.ac |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index aa4ae9f..30f875c 100644 --- a/configure.ac +++ b/configure.ac @@ -53,14 +53,8

Re: [PATCH libXau] Free XauFileName() static buffer at exit

2012-04-20 Thread Matt Turner
On Fri, Apr 20, 2012 at 5:18 PM, Chase Douglas chase.doug...@canonical.com wrote: XauFileName() may allocate and return a static buffer. The only way to ensure it is freed is to deallocate it when the program exits. Signed-off-by: Chase Douglas chase.doug...@canonical.com ---  AuFileName.c |

libXaw vs libXaw3d

2012-04-02 Thread Matt Turner
On Mon, Apr 2, 2012 at 5:13 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 04/ 2/12 03:21 AM, Marty Jack wrote: Unknown if you might have meant to add libXaw3d 1.6.2 I did not, as nothing else in the katamari depends on it, and if you're building a new system from scratch you may

[ANNOUNCE] libXaw3d 1.6.2

2012-03-29 Thread Matt Turner
1.6.2 has some fixes for *old* bugs, sometimes fixed 10 years ago in libXaw. Markus Steinborn (3): Correct XtNthumbProc usage Avoid integer overflow Add XawTextGetSink for compatibility with libXaw Matt Turner (6): Fix parameters of FloatInRange Fix use-after-free

[PATCH libXaw3d] Fix ... ?

2012-03-14 Thread Matt Turner
/xc/lib/Xaw/MultiSrc.c.diff?r1=1.1r2=1.2 Signed-off-by: Matt Turner matts...@gmail.com --- I don't know what this actually fixes. src/MultiSrc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/MultiSrc.c b/src/MultiSrc.c index b53fa50..1ac3283 100644 --- a/src

[PATCH libXaw3d] Fix use-after-free in DestroyAllIM

2012-03-01 Thread Matt Turner
Fixes segmentation fault when closing gv. Found at http://gitorious.org/xaw3d/xaw3d/commit/23b3ca50395f180cba4a923eb8827dcc961629da Fixes: https://bugs.gentoo.org/show_bug.cgi?id=406487 Signed-off-by: Matt Turner matts...@gmail.com --- Original author of this patch is unknown. If you know, let

[PATCH libXaw3d] Fix parameters of FloatInRange

2012-02-29 Thread Matt Turner
Introduced in f6cd786d1. Reported-by: Jean-Pierre Demailly jean-pierre.demai...@ujf-grenoble.fr Signed-off-by: Matt Turner matts...@gmail.com --- src/Scrollbar.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Scrollbar.c b/src/Scrollbar.c index be74ed3..5667327

Re: [PATCH xrandr] Document --brightness option in --help message

2012-02-26 Thread Matt Turner
needed change. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH libxkbcommon 0/2] Use flex and bison features

2012-02-24 Thread Matt Turner
On Fri, Feb 24, 2012 at 3:18 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: On Fri, Feb 24, 2012 at 02:58:32AM +0200, Ran Benita wrote: These patches break yacc and lex compatibility mainly for removing the global state from the parser, which I think is expected given that this is a library.

Re: [PATCH libxkbcommon 0/2] Use flex and bison features

2012-02-24 Thread Matt Turner
On Fri, Feb 24, 2012 at 4:05 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: On Fri, Feb 24, 2012 at 04:02:09PM -0500, Matt Turner wrote: On Fri, Feb 24, 2012 at 3:18 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: On Fri, Feb 24, 2012 at 02:58:32AM +0200, Ran Benita wrote: These patches

Re: [PATCH libxkbcommon 0/2] Use flex and bison features

2012-02-24 Thread Matt Turner
On Fri, Feb 24, 2012 at 4:38 PM, Matthieu Herrb matthieu.he...@laas.fr wrote: Notwithstanding the issues with (not) using GPLv3 tools at Apple (and probably other companies), in OpenBSD and NetBSD at least we want to be able to build X with the tools present in the base system. Don't you sort

Re: libpciaccess-0.13

2012-02-24 Thread Matt Turner
On Fri, Feb 24, 2012 at 4:52 PM, Jeremy Huddleston jerem...@apple.com wrote: Alan's commit to libpciaccess reminded me that we should tag and release 0.13 soon so a stable version is available to coincide with the stable 1.12.0 server release.  Does anyone have anything pending in

Re: [PATCH Xaw3D] fix segfaults on tip popups. #46124

2012-02-15 Thread Matt Turner
On Wed, Feb 15, 2012 at 2:05 PM, Devin J. Pohly djpohly+x...@gmail.com wrote: From: Devin J. Pohly djpohly+x...@gmail.com When XAW_INTERNATIONALIZATION isn't defined, some uninitialized stack data was being passed to XtGetValues.  This makes it not do that. Fixes:

[ANNOUNCE] libXaw3d 1.6.1

2012-02-15 Thread Matt Turner
Devin J. Pohly (1): Fix segfaults on tip popups Gaetan Nadon (1): Make --enable-internationalization default Jeremy Huddleston (3): Include stdlib.h for abs() Cleanup shadow declarations Build fix for int-pointer cast errors Matt Turner (6): Include

[PATCH] Make --enable-internationalization default

2012-02-01 Thread Matt Turner
From: Gaetan Nadon mems...@videotron.ca libXaw3d-1.5 was built with internationalization by default and software such as gv and xterm require it. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45153 Signed-off-by: Matt Turner matts...@gmail.com --- configure.ac | 12 +++- 1

Re: [PATCH] Make --enable-internationalization default

2012-02-01 Thread Matt Turner
On Wed, Feb 1, 2012 at 12:19 PM, Matt Turner matts...@gmail.com wrote: From: Gaetan Nadon mems...@videotron.ca libXaw3d-1.5 was built with internationalization by default and software such as gv and xterm require it. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45153 Signed-off

[PATCH libXaw3d] Include headers instead of using extern definitions

2012-02-01 Thread Matt Turner
Caught a mistake in SmeThreeD.h: smeThreeDWidgetClass was declared instead of smeThreeDObjectClass. Also fixes redundant redeclaration warnings. Signed-off-by: Matt Turner matts...@gmail.com --- include/X11/Xaw3d/SmeThreeD.h |2 +- src/AllWidgets.c | 74

[PATCH libXaw3d 1/2] Include WidgetNode.h from AllWidgets.h

2012-02-01 Thread Matt Turner
Makes these two files closer to the libXaw originals. Signed-off-by: Matt Turner matts...@gmail.com --- include/X11/Xaw3d/AllWidgets.h |2 ++ src/AllWidgets.c |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/include/X11/Xaw3d/AllWidgets.h b/include/X11

[PATCH libXaw3d 2/2] Add multiSink and multiSrc to AllWidgets.c

2012-02-01 Thread Matt Turner
Noticed when comparing with libXaw's AllWidgets.c. --- src/AllWidgets.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/AllWidgets.c b/src/AllWidgets.c index 21c683b..d0ec9d0 100644 --- a/src/AllWidgets.c +++ b/src/AllWidgets.c @@ -47,6 +47,7 @@ in this Software

[PATCH libXaw] Include headers instead of using extern definitions

2012-02-01 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/AllWidgets.c | 67 +++-- 1 files changed, 29 insertions(+), 38 deletions(-) diff --git a/src/AllWidgets.c b/src/AllWidgets.c index 27be437..3b13438 100644 --- a/src/AllWidgets.c +++ b/src

Re: Slow XQueryPointer?

2012-01-27 Thread Matt Turner
On Fri, Jan 27, 2012 at 5:32 AM, Lauri Kasanen c...@gmx.com wrote: You don't have to convert the entire app to XCB to be able to use it for just one or two calls, for example, most of xdpyinfo uses libX11 calls still, but the loop to list extensions uses xcb to be able to send all the queries

[PATCH glint] Remove uses of xf86PciInfo.h

2012-01-25 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/IBMramdac.c|1 - src/TIramdac.c |1 - src/glint.h| 24 +++--- src/glint_dga.c|1 - src/glint_driver.c | 237 ++-- src/glint_regs.h |5 + src

Re: [PATCH] Make --enable-internationalization default

2012-01-24 Thread Matt Turner
On Tue, Jan 24, 2012 at 4:45 PM, Thomas Dickey dic...@his.com wrote: Actually the issue relative to xterm was reported over in GenToo this week. Samuli and I are Gentoo developers It seems that xorg changes have broken a more than 10-year old packaging arrangement. Sorry for trying to

Re: [PATCH] Make --enable-internationalization default

2012-01-24 Thread Matt Turner
On Tue, Jan 24, 2012 at 6:38 PM, Thomas Dickey dic...@his.com wrote: On Tue, Jan 24, 2012 at 05:40:11PM -0500, Gaetan Nadon wrote: On 12-01-24 05:06 PM, Matt Turner wrote: On Tue, Jan 24, 2012 at 4:45 PM, Thomas Dickey dic...@his.com wrote: Actually the issue relative to xterm was reported

Re: [PATCH] Remove XAA

2012-01-23 Thread Matt Turner
On Mon, Jan 23, 2012 at 2:24 AM, Dave Airlie airl...@gmail.com wrote: Oh it helps me a lot, when you are trying to rework the X server ABI to be hotplug capable, the less useless ancient untestable pieces of crap you have to port makes the chance of users with modern hardware getting a modern

[PATCH] Include XAW3D_CPPFLAGS in xaw3d.pc Cflags

2012-01-23 Thread Matt Turner
Software depending on libXaw3d seems to require this. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45144 Signed-off-by: Matt Turner matts...@gmail.com --- xaw3d.pc.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xaw3d.pc.in b/xaw3d.pc.in index b243c52

[PATCH] Make --enable-internationalization default

2012-01-23 Thread Matt Turner
xterm and gv need it. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45153 Signed-off-by: Matt Turner matts...@gmail.com --- configure.ac |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 8dd3984..8e47424 100644

Re: [PATCH] Remove XAA

2012-01-22 Thread Matt Turner
On Sun, Jan 22, 2012 at 4:01 PM, Daniel Stone dan...@fooishbar.org wrote: Hi, On 22 January 2012 14:33, Mark Kettenis mark.kette...@xs4all.nl wrote: No way!  XAA works for accelerated scrolling and makes a significant difference on slow CPUs.  It often works better for EXA.  If there is

[PATCH] Remove another if (E != NULL) check around free(E)

2011-11-29 Thread Matt Turner
I wonder if there are any other patterns we haven't seen yet? Reviewed-by: Jamey Sharp ja...@minilop.net Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/fbdevhw/fbdevhw.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/fbdevhw/fbdevhw.c b/hw

Re: [PATCH libXp] fix build: Return 0 instead of NULL in XpGetPdmStartParams()

2011-11-23 Thread Matt Turner
On Tue, Nov 22, 2011 at 7:47 PM, Tobias Droste tdro...@gmx.de wrote: Status is defined as int - NULL is not a valid return value Do you need to cast 0 to Status, in that case? ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 6/6] Convert some malloc + strncpy pairs into strndup calls

2011-10-28 Thread Matt Turner
On Fri, Oct 28, 2011 at 8:34 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com I think these can be converted as well. Xext/xselinux_ext.c:SELinuxCopyContext dix/dixfonts.c:SetFontPathElements

Re: PATCH document -background none option

2011-10-13 Thread Matt Turner
On Thu, Oct 13, 2011 at 8:06 AM, Michal Suchanek hramr...@centrum.cz wrote: On 12 October 2011 02:40, Alan Coopersmith alan.coopersm...@oracle.com wrote: I'd change that to:  For security reasons this is not the default, as the screen contents  might show a previous user session. Are you

Re: [PATCH] xfree86: Add Loongson MIPS support

2011-10-12 Thread Matt Turner
On Wed, Oct 12, 2011 at 2:58 AM, Matt Kraai kr...@ftbfs.org wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=41038 ---  hw/xfree86/dri/sarea.h                  |    2 ++  hw/xfree86/os-support/linux/lnx_video.c |   20 ++--  2 files changed, 20 insertions(+), 2

Re: [PATCH libXaw3d 0/5] Warning fixes

2011-10-06 Thread Matt Turner
On Mon, Oct 3, 2011 at 11:34 PM, Guillem Jover guil...@hadrons.org wrote: Hi! Here's some changes I had laying around. regards, guillem Guillem Jover (5):  Disable unused input and unput lex functions  Remove unused label  Only use variable t in MoveThumb() on XAW_ARROW_SCROLLBARS  

[PATCH libXaw3d] Remove worthless isupper/islower checks

2011-10-06 Thread Matt Turner
Was toupper() *really* expensive when this was written? :) Also, initialize action_type with toupper(), since the check immediately following assumes that its value is uppercase. Signed-off-by: Matt Turner matts...@gmail.com --- src/Paned.c |9 ++--- 1 files changed, 2 insertions(+), 7

[PATCH libXaw3d] Include stdlib.h for abs()

2011-10-06 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/List.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/List.c b/src/List.c index b491000..6b9fe13 100644 --- a/src/List.c +++ b/src/List.c @@ -39,6 +39,7 @@ in this Software without prior written authorization from

[PATCH libXaw3d] Remove unused variable 'i'

2011-10-06 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/XawIm.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/XawIm.c b/src/XawIm.c index 92b92cd..b01f0d0 100644 --- a/src/XawIm.c +++ b/src/XawIm.c @@ -1287,8 +1287,6 @@ CompileResourceList(XtResourceList res

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Matt Turner
swapping them just destroys their values. Give your Tested-by/Reviewed-by and we'll get it committed. Thanks, Matt From e0628cee60f9de96f4f229bc9e618113c532251c Mon Sep 17 00:00:00 2001 From: Matt Turner matts...@gmail.com Date: Tue, 4 Oct 2011 10:01:50 -0400 Subject: [PATCH] Fix xselinux after

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Matt Turner
On Tue, Oct 4, 2011 at 2:33 PM, Michal Suchanek hramr...@centrum.cz wrote: BTW it adds a warning about stuff variable being unused  - probably defined in one of the macros. It's because the swap macros stopped taking a second argument. Matt ___

Re: Maintaining backwards compatibility with swap macros

2011-10-03 Thread Matt Turner
On Mon, Oct 3, 2011 at 1:16 AM, Jeremy Huddleston jerem...@freedesktop.org wrote: Ok, given your agreement here, I'll go ahead with this if you don't beat me to it. --Jeremy Yes, if you have some time, please proceed. Matt ___

Re: Maintaining backwards compatibility with swap macros

2011-10-02 Thread Matt Turner
:50, Matt Turner wrote: Dave pointed out that there are a couple drivers (sis, sisusb, vmware) that use the swapl/swaps macros. My recent patch series dropped the n argument from the macros, causing these drivers to not build. Ideally, we'd like a deprecation warning when the second argument

Re: [PATCH 4/8] Introduce swap_uint{16, 32} functions, used in swap{l, s}

2011-09-28 Thread Matt Turner
On Tue, Aug 16, 2011 at 10:58 PM, Matt Turner matts...@gmail.com wrote: Signed-off-by: Matt Turner matts...@gmail.com ---  include/misc.h |   30 --  1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/include/misc.h b/include/misc.h index d991c0a

[PATCH] Remove incorrect in swap_uint32

2011-09-28 Thread Matt Turner
Caused by commit 893e86a4, and hidden by the (char *) cast. Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index 1fea73e..180b3c1 100644 --- a/include/misc.h +++ b/include

Building DRI-disabled drivers with DRI-enabled xserver

2011-09-26 Thread Matt Turner
Hi, It seems impossible currently to build DDXs with --disable-dri against an X server built with DRI. The X server's xorg-server.h file defines XF86DRI, which is included by the DDX's config.h files. In config.h, if --enable-dri is passed, XF86DRI is defined to 1. With --disable-dri, /* #undef

Re: Building DRI-disabled drivers with DRI-enabled xserver

2011-09-26 Thread Matt Turner
On Mon, Sep 26, 2011 at 7:22 PM, Matt Turner matts...@gmail.com wrote: Hi, It seems impossible currently to build DDXs with --disable-dri against an X server built with DRI. The X server's xorg-server.h file defines XF86DRI, which is included by the DDX's config.h files. In config.h

[PATCH xf86-video-mga 1/4] Remove xalloc/xcalloc/xrealloc/xfree

2011-09-26 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/mga_dga.c|2 +- src/mga_dri.c| 70 +++--- src/mga_driver.c | 28 ++-- src/mga_merge.c | 22 src/mga_storm.c |2 +- src/mga_vga.c|6

[PATCH xf86-video-mga 2/4] Remove if(E != NULL) checks around free(E)

2011-09-26 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/mga_dri.c| 24 src/mga_driver.c | 20 ++-- src/mga_merge.c |6 ++ src/mga_video.c |3 +-- 4 files changed, 17 insertions(+), 36 deletions(-) diff --git a/src/mga_dri.c b/src

[PATCH xf86-video-mga 3/4] Fix printf format specifier warning

2011-09-26 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/mga_exa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mga_exa.c b/src/mga_exa.c index f292327..e5eaa92 100644 --- a/src/mga_exa.c +++ b/src/mga_exa.c @@ -865,7 +865,7 @@ mgaExaInit(ScreenPtr pScreen

[PATCH xf86-video-mga 4/4] Remove calls to xf86IsPc98()

2011-09-26 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/mga_driver.c | 14 +- src/mga_merge.c |2 +- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/mga_driver.c b/src/mga_driver.c index dcbfabf..4af36ca 100644 --- a/src/mga_driver.c +++ b/src/mga_driver.c

Re: [PATCH xf86-video-mga 1/4] Remove xalloc/xcalloc/xrealloc/xfree

2011-09-26 Thread Matt Turner
On Tue, Sep 27, 2011 at 12:11 AM, Jamey Sharp ja...@minilop.net wrote: On Mon, Sep 26, 2011 at 10:41:49PM -0400, Matt Turner wrote: --- a/src/mga_video.c +++ b/src/mga_video.c @@ -131,8 +131,7 @@ void MGAInitVideo(ScreenPtr pScreen)           num_adaptors = 1;           adaptors = newAdaptor

Maintaining backwards compatibility with swap macros

2011-09-25 Thread Matt Turner
Dave pointed out that there are a couple drivers (sis, sisusb, vmware) that use the swapl/swaps macros. My recent patch series dropped the n argument from the macros, causing these drivers to not build. Ideally, we'd like a deprecation warning when the second argument is given, but by removing

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Matt Turner
On Fri, Sep 23, 2011 at 10:10 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Jeremy Huddleston jerem...@apple.com Date: Thu, 22 Sep 2011 19:52:05 -0700 The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb:   Merge remote-tracking branch 'mattst88/for-keith'

Re: [PATCH] Fix misc.h changes from d206d52f657c to work with Sun compilers

2011-09-22 Thread Matt Turner
)) +static inline int __builtin_constant_p(int x)  {        return 0;  } +# endif  #endif  /* byte swap a 32-bit value */ -- 1.7.3.2 I see that I specified the wrong return type. That was silly. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel

Re: [PATCH v2] Address regressions from e8ff555b95baab66cc7d060c1e7f9fdd49d3802f

2011-09-22 Thread Matt Turner
) \                        *(x) = lswaps(*(x)); \                else \                        swap_uint16((uint16_t *)(x)); \ -- 1.7.6.1 Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH] Address regressions from e8ff555b95baab66cc7d060c1e7f9fdd49d3802f

2011-09-22 Thread Matt Turner
to hear from Matt, and ideally Alan Coopersmith as to whether this seems reasonable to them as well. Yep, it looks good to me. Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: [PULL] bswap cleanup and misc patches

2011-09-21 Thread Matt Turner
On Wed, Sep 21, 2011 at 4:43 PM, Keith Packard kei...@keithp.com wrote: On Fri, 2 Sep 2011 19:05:28 -0400, Matt Turner matts...@gmail.com wrote: Please pull from my tree. It contains four miscellaneous patches that were reviewed months ago and clean ups to the bswap macros. Thanks

Re: Bus layer cleanups

2011-09-20 Thread Matt Turner
On Mon, Sep 19, 2011 at 3:23 AM, Jamey Sharp ja...@minilop.net wrote: I've built each patch in the series and minimally tested that each resulting server works with the xf86-video-nested driver, a window manager, and an xterm. That means I'm not testing most of the changed code paths, but I'm

Re: Bus layer cleanups

2011-09-20 Thread Matt Turner
On Tue, Sep 20, 2011 at 11:00 PM, Jeremy Huddleston jerem...@apple.com wrote: Comparing the end result of this patchset before and after the cleanup reveals this change.  Was this intentional or did something slip through when restructuring? $ git diff

Re: [RFC] Bugzilla Cleanup

2011-09-19 Thread Matt Turner
On Mon, Sep 19, 2011 at 3:17 AM, Jeremy Huddleston jerem...@freedesktop.org wrote: So, one of the things talked about at XDC was just how icky bugzilla has become.  There are a ton of open bugs which haven't been touched in ages and either don't apply any more or don't have sufficient

Re: [PATCH:libXaw3d 1/2] Fix several unused variable warnings

2011-09-17 Thread Matt Turner
from, XawTextPosition to)       text.ptr = \n;  #ifdef XAW_INTERNATIONALIZATION   else { +      static wchar_t wide_CR[ 2 ];       wide_CR[0] = _Xaw_atowc(XawLF);       wide_CR[1] = 0;       text.ptr = (char*) wide_CR; Reviewed-by: Matt Turner matts...@gmail.com I did this the other day

Re: [PATCH:libXaw3d 2/2] Add LayYYWrap() prototype to LayYY.h

2011-09-17 Thread Matt Turner
_X_HIDDEN int  LayYYwrap (void);  /* Functions autogenerated from laylex.l into laylex.c */  extern _X_HIDDEN int  LayYYlex (void); -- Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH] savage: Fix Xv scaling on non-native resolutions

2011-09-17 Thread Matt Turner
On Sat, Sep 17, 2011 at 5:22 AM, Tormod Volden lists.tor...@gmail.com wrote: From: Hans-Juergen Mauser hjmau...@gmx.net If I set the resolution to 800x600 for example (to be able to use the TV output in full screen mode), I only can see 800/1024 = 0,78 of the real video width, no matter if

Re: [PATCH 1/9] dmx: Fix a non-constant printf format string warning.

2011-09-17 Thread Matt Turner
On Sat, Sep 17, 2011 at 4:22 AM, Jamey Sharp ja...@minilop.net wrote: Signed-off-by: Jamey Sharp ja...@minilop.net ---  hw/dmx/input/lnx-keyboard.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dmx/input/lnx-keyboard.c b/hw/dmx/input/lnx-keyboard.c index

Re: [PATCH] savage: Fix Xv scaling on non-native resolutions

2011-09-17 Thread Matt Turner
On Sat, Sep 17, 2011 at 11:52 AM, Matt Turner matts...@gmail.com wrote: I'm wondering why the added lines don't have (float) casts when the x1, y1 lines do? If they're not necessary, perhaps a follow-on patch would be nice. And now I see the other email you already sent

Re: [PATCH] savage: Avoid unnecessary float calculation in video display

2011-09-17 Thread Matt Turner
) / psav-XExp2;        dstBox-y2 = (dstBox-y2 * psav-YExp1) / psav-YExp2;        dstBox-x1 += psav-displayXoffset; -- Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: drivers to de-support (was: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires)

2011-09-17 Thread Matt Turner
On Fri, Sep 16, 2011 at 9:36 PM, Michael macallan1...@gmail.com wrote: Hello, On Fri, 16 Sep 2011 21:13:10 -0400 Matt Turner matts...@gmail.com wrote: Which goes back to another question raised at XDC - is it time to start dropping support for video drivers the way we have for input

Re: [PATCH 2/9] dmx: Fix some no previous prototype warnings by making functions static.

2011-09-17 Thread Matt Turner
__glEvalComputeK(GLenum target) +static GLint __glEvalComputeK(GLenum target)  {     switch (target) {     case GL_MAP1_VERTEX_4: -- Reviewed-by: Matt Turner matts...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH xserver/hw/xfree86/modes/xf86Crtc.c] trivial memory leak

2011-09-17 Thread Matt Turner
@@ xf86CrtcCreate (ScrnInfoPtr         scrn,        crtcs = malloc((xf86_config-num_crtc + 1) * sizeof (xf86CrtcPtr));     if (!crtcs)     { +       free(crtc-gamma_red);        free(crtc);        return NULL;     } Good catch. Reviewed-by: Matt Turner matts...@gmail.com

[PATCH libXaw3d 1/2] Fix a couple unused function warnings

2011-09-17 Thread Matt Turner
Functions were only called inside ifdef blocks, but were defined outside. Signed-off-by: Matt Turner matts...@gmail.com --- src/TextAction.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/TextAction.c b/src/TextAction.c index 7d1afcb..8d8fe00 100644 --- a/src

[PATCH libXaw3d 2/2] Fix a couple of unused variable warnings

2011-09-17 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- src/ThreeD.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/ThreeD.c b/src/ThreeD.c index 754b6e2..586242d 100644 --- a/src/ThreeD.c +++ b/src/ThreeD.c @@ -346,7 +346,6 @@ AllocTopShadowPixel (Widget new) XColor

Re: drivers to de-support (was: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires)

2011-09-17 Thread Matt Turner
On Sat, Sep 17, 2011 at 8:55 PM, Michael macallan1...@gmail.com wrote: Hello, On Sat, 17 Sep 2011 11:59:29 -0400 Matt Turner matts...@gmail.com wrote: Where's the SGI O2's video driver? It's still not hosted on FDO. I thought that was one reason you were getting commit access. cvs

Re: [PULL] bswap cleanup and misc patches

2011-09-17 Thread Matt Turner
On Fri, Sep 2, 2011 at 7:05 PM, Matt Turner matts...@gmail.com wrote: The following changes since commit 0caeef6146bee5fb1827ab25db191685dde9d4b4:  Version bumped to 1.11 (2011-08-26 16:46:13 -0700) are available in the git repository at:  git://people.freedesktop.org/~mattst88/xserver

Bus layer cleanups

2011-09-16 Thread Matt Turner
ajax sent the original series out in Sept 2010 and has added some more on top of it since then. His original message was On Sep 21, 2010, at 6:28 PM, Adam Jackson wrote: This attempts to tackle Tiago's (justified) hatred for the IOADDRESS type in a slightly more elegant way. We move more of

[PATCH 01/16] xfree86: Move xf86GetClocks to vgahw

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com This is really a vga-specific hack anyway. The only modern driver that uses it is trident, but it's already loaded vgahw by the time it would call xf86GetClocks. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/common/xf86.h |6 ---

[PATCH 02/16] int10: Port to pciaccess' legacy IO API

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/int10/generic.c |5 ++- hw/xfree86/int10/helper_exec.c | 36 hw/xfree86/int10/xf86int10.c | 61 +++-

[PATCH 03/16] vgahw: Move IO domain setup to IO dispatch vector setup

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/vgahw/vgaHW.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/vgahw/vgaHW.c b/hw/xfree86/vgahw/vgaHW.c index 2ecea1c..f23b799 100644 --- a/hw/xfree86/vgahw/vgaHW.c

[PATCH 04/16] vgahw: Don't default to standard (port space) access routines

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com In fact, don't default to anything; drivers must explicitly say which kind they want, and they are strongly encouraged to do MMIO if possible. This is an ABI change in that drivers that don't will crash, but drivers that are explicit will work with both old and

[PATCH 05/16] vgahw: Port to pciaccess IO space routines

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/vgahw/vgaHW.c | 95 +++--- hw/xfree86/vgahw/vgaHW.h | 20 +++--- 2 files changed, 54 insertions(+), 61 deletions(-) diff --git a/hw/xfree86/vgahw/vgaHW.c

[PATCH 06/16] pci: Port xf86MapLegacyIO to pciaccess

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com Per-domain I/O is now something drivers must manually request, and must keep track of within their own state rather than in the ScrnInfoRec. It's not really possible to split that into two steps without an additional intermediate ABI break, so don't even try.

[PATCH 07/16] linux: Use pci_device_get_parent_bridge instead of open-coding it

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/os-support/bus/linuxPci.c | 41 +- 1 files changed, 1 insertions(+), 40 deletions(-) diff --git a/hw/xfree86/os-support/bus/linuxPci.c

[PATCH 08/16] bus: remove some dead struct fields

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/os-support/shared/vidmem.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/xfree86/os-support/shared/vidmem.c b/hw/xfree86/os-support/shared/vidmem.c index

[PATCH 09/16] linux: Remove pre-2.6 PCI interface support

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com If you haven't ported 2.6 to your architecture in the intervening seven years, you can keep running older servers. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/os-support/bus/linuxPci.c | 32 ++-- 1 files changed, 2

[PATCH 10/16] linux: Remove ia64 domain I/O support code

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com pciaccess handles this now. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|7 +- hw/xfree86/os-support/linux/Makefile.am |4 - hw/xfree86/os-support/shared/ia64Pci.c | 188 --- 3

[PATCH 11/16] xfree86: Remove unused bios_devmem.c

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/os-support/Makefile.am |3 - hw/xfree86/os-support/shared/bios_devmem.c | 75 2 files changed, 0 insertions(+), 78 deletions(-) delete mode 100644

[PATCH 12/16] pci: Remove the PCITAG type

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/int10/helper_exec.c |2 +- hw/xfree86/os-support/bus/Pci.c |6 -- hw/xfree86/os-support/bus/xf86Pci.h |2 -- 3 files changed, 1 insertions(+), 9 deletions(-) diff --git

[PATCH 13/16] int10: Use pciaccess rom fetch for !PC machines

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com ... instead of rolling our own, badly. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/int10/generic.c | 58 +--- 1 files changed, 1 insertions(+), 57 deletions(-) diff --git a/hw/xfree86/int10/generic.c

[PATCH 14/16] pci: Remove xf86MapDomainMemory

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com This is slightly draconian, but that API is just awful. In all but one case in the callers it's used to get a map of some legacy VGA memory, and it would be cleaner for the caller to just call pci_device_map_legacy. The sole exception is in the vesa driver,

[PATCH 15/16] int10: Port internal users off xf86MapVidMem

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com This API is apparently semi-deprecated even by XFree86 standards, and there are only four drivers left using it. Let's start chopping it off. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/int10/generic.c |4 ++--

[PATCH 16/16] incomplete: Remove xf86{Un,}MapVidMem

2011-09-16 Thread Matt Turner
From: Adam Jackson a...@redhat.com And man does a lot of support code just fall away when you do that. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/os-support/bsd/alpha_video.c | 151 - hw/xfree86/os-support/bsd/arm_video.c | 102 ---

Re: Bus layer cleanups

2011-09-16 Thread Matt Turner
have this series somewhere public, so I can just git merge it rather than git-am all of this? Thanks! Yep, I pushed it to git://people.freedesktop.org/~mattst88/xserver ioaddress Thanks for testing. :) Matt On Sep 16, 2011, at 12:50 PM, Matt Turner wrote: ajax sent the original series

Re: drivers to de-support (was: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires)

2011-09-16 Thread Matt Turner
On Fri, Sep 16, 2011 at 7:53 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 09/16/11 01:54, Jeremy Huddleston wrote: On Sep 15, 2011, at 8:31 AM, Gaetan Nadon wrote: A bonus would be a list of drivers that do use pciaccess (maybe not in the commit text!). A complete list of

Re: [PATCH] x86emu: There is no NO_INLINE implementation of unaligned access here.

2011-09-15 Thread Matt Turner
/xfree86/x86emu/sys.c @@ -49,7 +49,6 @@  #include string.h  #endif -# ifndef NO_INLINE  #  ifdef __GNUC__ Trivial, but the indentatino of ifdef __GNUC__ should probably be changed as well. Either way, Reviewed-by: Matt Turner matts...@gmail.com

Re: Xserver driver merging pros cons

2011-09-15 Thread Matt Turner
On Thu, Sep 15, 2011 at 11:45 AM, Jesse Barnes jbar...@virtuousgeek.org wrote: Pros:  1) easier to propagate API changes across drivers (just like Linux)     1a) thus easier to change ABI I suppose that's true. How often are we breaking the ABI though? How often do we break the ABI and it

<    1   2   3   4   5   6   7   >