AW: "Modern C" and the X.Org software

2023-12-13 Thread Walter Harms
Hi Alan, just for my understanding. You compiled everything and only these few thinks showed up. Or is more like an iceberg only the tip is there and we should do something ? CU Von: xorg-devel im Auftrag von Alan Coopersmith Gesendet: Montag, 11.

AW: Hitting X limit in launching maximum number of vkcube instances

2023-08-24 Thread Walter Harms
Hi Anuj, i did not follow the diskussion in detail, so maybe this was already purposed: Some years ago in an unrelated project i also hit the max file pointer limit. The reason seemed obvious but in the end it turned out the be something different. Did you check you hit the expected limit when

AW: Overexposed desktop

2023-07-12 Thread Walter Harms
The reduce the number of components involved: when you are at your console and you start X :2 does anything change ? - yes i am forced to use this crappy mail frontend ... Von: xorg im Auftrag von Igor Rylov Gesendet: Mittwoch, 12.

AW: PATCH libX11 2/2] ChkIfEv.c: fix wrong handling of dpy->in_ifevent

2023-01-27 Thread Walter Harms
maybe i missed a point, is it possible that dpy->in_ifevent will underflow ? re, wh Von: xorg-devel im Auftrag von Ulrich Sibiller Gesendet: Mittwoch, 30. November 2022 23:47 An: xorg-devel@lists.x.org Betreff: PATCH libX11 2/2] ChkIfEv.c: fix wrong

AW: Yet another leak in Xlib

2022-10-18 Thread Walter Harms
will sombody close the hole in the documentation ? Von: xorg-devel im Auftrag von Po Lu Gesendet: Dienstag, 4. Oktober 2022 04:38 An: Thomas Dickey Cc: xorg-devel@lists.x.org Betreff: Re: Yet another leak in Xlib Thomas Dickey writes: > looks okay

AW: Motif/Xt: Dynamically resize the visible item count of an XmList

2022-03-21 Thread Walter Harms
Hello, for my understand of Widget programming it is a question of the widget itself. It has some code inside to handle the resize event and in this moment there seems no update of the visible_item_count. Von: xorg im Auftrag von Holger Sebert

AW: [PATCH] xrdb: Add actual querying capabilities to -query

2021-06-20 Thread Walter Harms
Hi, thx for the patch. NTL it is better for the general look if you use a name for sign-off that is more easy to pronounce. for a starter: yes, i think we can drop support for solaris 4 :) IMHO, the idea is good. I am struggling a bit with reusing the query option but thats not a showstopper.

AW: [Xlib] Ignoring BadAccess errors

2021-04-21 Thread Walter Harms
since no one feels the need to answer is will try: Having those exceptions is obviously a hack to allow clients to continue on "minor" errors. e.g. BadAccess can be generated by xgrab*() and may work in a second attempt. NTL this should be documented in the doc. regarding you original

AW: New libxcvt library

2021-04-16 Thread Walter Harms
Hi, i think it is a good idea. Can you give a hint how big that lib is ? Even when the idea is good it is not really helpful to have to many different libs hanging around. I read Keith Packard was already considering putting that into xrandr, if its not to big i would say it would be a good idea

AW: Error in Xmanager

2021-03-12 Thread Walter Harms
Hi Qiu Guotao, your are on the X11 mailing list, we are concerned with the inner workings of X11. xmanager seens to be a commerical program: https://www.netsarang.com/en/xmanager/ The side has a technical support on the top/right. Mots likely they can help better. re, wh

AW: [PATCH] mi: sprite: SaveUnderCursor2

2021-03-09 Thread Walter Harms
hi Madhurkiran Harikrishnan, my experience is that readability reduced rapidly with indent-level. I would suggest: if ( ! DevHasCursor(pDev) continue; pCursorInfo = GetSprite(pDev); if (!pCursorInfo) continue; // just to shrink the if () // no braces needed if ( pCursorInfo->isUp &&

AW: Xorg core dump Device or resource busy

2021-02-25 Thread Walter Harms
this sounds like a reproduceable bug in the I/o handling. I hope someone on the list is reading and can fix that, as i am not an expoert on these io-things. re, wh Von: Mykola Sokolov Gesendet: Donnerstag, 25. Februar 2021 16:40:27 An: Walter Harms Cc

AW: Xorg core dump Device or resource busy

2021-02-25 Thread Walter Harms
Gesendet: Donnerstag, 25. Februar 2021 11:57:45 An: Walter Harms Cc: xorg@lists.x.org Betreff: Re: Xorg core dump Device or resource busy Hi Walter, I don't think that this is a new issue. I think it got worse after replacing mouses and keyboards. What do you mean by manual start? If I re

AW: Xorg core dump Device or resource busy

2021-02-25 Thread Walter Harms
Hi, some minor questions: 1. Is this a new issue ? (e.g. after a recent update ?) 2. Does this happen also with a manual start ? re, wh Von: xorg im Auftrag von Mykola Sokolov Gesendet: Donnerstag, 25. Februar 2021 10:10:12 An: xorg@lists.x.org

AW: X Logical Font Description and HiDPI

2021-02-04 Thread Walter Harms
Hi Andrey, not being an expert on X11 fonts i would like to condense your question a bit; when you use a scaleable font: > -monotype-courier new-medium-r-normal--*-120-*-*-m-*-iso10646-1 > -monotype-courier new-medium-r-normal--0-120-0-0-m-0-iso10646-1 you expect a font depending on you DPI

AW: xdm login window blinks

2021-01-19 Thread Walter Harms
Hi Intmail, How do you use XDM ? X -query or otherwise ? Von: xorg im Auftrag von intmai...@gmail.com Gesendet: Dienstag, 19. Januar 2021 15:56:21 An: xorg@lists.x.org Betreff: xdm login window blinks Hello, I am using server with remote terminal .

AW: AW: AW: Preparing for libX11 1.7.0

2020-11-20 Thread Walter Harms
nobody expects this to become bug free. The point was to raise awareness that the same class (heap-use-after-free) are still reported. Von: Alan Coopersmith Gesendet: Donnerstag, 19. November 2020 18:07 An: Walter Harms; Keith Packard; Matthieu Herrb

AW: AW: Preparing for libX11 1.7.0

2020-11-19 Thread Walter Harms
in XQueryExtension Von: Keith Packard Gesendet: Dienstag, 17. November 2020 03:11 An: Alan Coopersmith; Walter Harms; Matthieu Herrb; xorg-de...@lists.freedesktop.org Cc: Vittorio Zecca Betreff: Re: AW: Preparing for libX11 1.7.0 Alan Coopersmith writes: > ht

AW: AW: Preparing for libX11 1.7.0

2020-11-18 Thread Walter Harms
to close this thread: the problem reported by Vittorio Zecca seems to have vanished with the git version. It does no show up anymore. Vittorio can not reproduce the problem, also. re, wh Von: xorg-devel im Auftrag von Walter Harms Gesendet

AW: AW: Preparing for libX11 1.7.0

2020-11-17 Thread Walter Harms
-devel im Auftrag von Keith Packard Gesendet: Dienstag, 17. November 2020 08:33 An: Vittorio Zecca Cc: xorg-de...@lists.freedesktop.org; Walter Harms Betreff: Re: AW: Preparing for libX11 1.7.0 Vittorio Zecca writes: > Even easier to reproduce running /usr/bin/wish if you have tk installed.

AW: Preparing for libX11 1.7.0

2020-11-16 Thread Walter Harms
before the actions start, i would like to point out that Vittorio Zecca reported a use-after-free in LibX11. It is reproduceable and it is found with libtk. jm2c wh Von: xorg-devel im Auftrag von Matthieu Herrb Gesendet: Montag, 16. November 2020

test , please ignore

2020-11-13 Thread Walter Harms
test ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

AW: sanitized version of libX11 crashes on heap-use-after-free in _XimUnRegisterIMInstantiateCallback

2020-11-10 Thread Walter Harms
Hello, i would like to try an fix it. But i need the reproduce first, can you provide a minimal example.c for me ? wh Von: xorg im Auftrag von Vittorio Zecca Gesendet: Montag, 9. November 2020 07:56:43 An: xorg@lists.x.org Betreff: sanitized version of

AW: XDMCP on TCP

2020-09-17 Thread Walter Harms
everybody is welcome to send patches. re, wh Von: xorg [xorg-boun...@lists.x.org] im Auftrag von Mubarak Qahtani [mubarak.qaht...@outlook.sa] Gesendet: Donnerstag, 17. September 2020 03:12 An: xorg@lists.x.org Betreff: XDMCP on TCP Hi All, Is there

AW: Update the keyboard layouts

2020-06-06 Thread Walter Harms
hi, you are mixing two things; 1. acceptance of patches upsteam (e.g. here with xorg) here you find everything in git. 2. packaging the code for users, normally you see the binary code only. this is done by the package maintainer. the binaries are distributed as deb (in case of

AW: AW: Implementing PseudoColor support on TrueColor screens

2020-06-02 Thread Walter Harms
a assume this is intentional backwards ? for (int x = width-1; x >= 0; x--) { if st2d_8to24table contains no rubbish the colors should be ok now, are they ? what means "squashed image" ? a scaling problem ? To make things more easy to debug, can you save image->data where you know what who that

AW: Implementing PseudoColor support on TrueColor screens

2020-06-02 Thread Walter Harms
the correct way to do is use XPutPixel(). color these days if pretty easy color=0/r/g/b You need a lookuptable for 256 colors (=st2d_8to24table[i] ?) and that should it be. re, wh Von: xorg im Auftrag von Sleep Gesendet: Dienstag, 2. Juni 2020

AW: BadAccess to a GrabButton

2020-05-04 Thread Walter Harms
Hi Sam Varshavchik, could you please elaborate a bit what you are doing exactly ? Someone should be able to replicate that you are doing. You have a (simple) programm you can share ? Even pseudo code would be ok. re, wh Von: xorg im Auftrag von Sam

AW: [PATCH xserver v2] xfree86: Refine drm modes on continuous freq panel

2020-04-15 Thread Walter Harms
Von: xorg-devel im Auftrag von Aaron Ma Gesendet: Dienstag, 14. April 2020 11:28 An: xorg-devel@lists.x.org; aaron...@canonical.com Betreff: [PATCH xserver v2] xfree86: Refine drm modes on continuous freq panel EDID1.4 replaced GTF Bit with Continuous

AW: AW V2: [PATCH xserver] xfree86: Refine drm modes on continuous freq panel

2020-04-14 Thread Walter Harms
Von: Aaron Ma Gesendet: Dienstag, 14. April 2020 10:30 An: Walter Harms; xorg-devel@lists.x.org Betreff: Re: AW V2: [PATCH xserver] xfree86: Refine drm modes on continuous freq panel On 4/13/20 5:11 PM, Walter Harms wrote

AW V2: [PATCH xserver] xfree86: Refine drm modes on continuous freq panel

2020-04-13 Thread Walter Harms
Von: xorg-devel im Auftrag von Aaron Ma Gesendet: Samstag, 11. April 2020 12:14 An: xorg-devel@lists.x.org; aaron...@canonical.com Betreff: [PATCH xserver] xfree86: Refine drm modes on continuous freq panel EDID1.4 replaced GTF Bit with Continuous or

AW: [PATCH xserver] xfree86: Refine drm modes on continuous freq panel

2020-04-13 Thread Walter Harms
Von: xorg-devel im Auftrag von Aaron Ma Gesendet: Samstag, 11. April 2020 12:14 An: xorg-devel@lists.x.org; aaron...@canonical.com Betreff: [PATCH xserver] xfree86: Refine drm modes on continuous freq panel EDID1.4 replaced GTF Bit with Continuous or

AW: Why does X11 generate an extra SHIFT when I press Shift+KP_1 ?

2020-02-16 Thread Walter Harms
When i try this i get the following list of events: KeyPress Shift_L KeyPress KP_End (on my kbd this is kp_1) KeyRelease KP_End KeyRelease Shift_L did you check your results without filter ? re, wh KeyPress event, serial 32, synthetic NO, window 0x5e1, root 0x7e, subw 0x0, time

AW: how to start xvfb from Arch linux ARM64 architecture

2020-01-29 Thread Walter Harms
It is very sad to read the android is getting more and more incompatible to his ancestor linux. Some time ago i played and used a phone a x-terminal, did you ever considered that ? re, wh Von: xorg im Auftrag von Mgr. Janusz Chmiel Gesendet:

Re: How to start with X?

2020-01-24 Thread walter harms
If you are interessted in widget programming, this may be helpful: https://github.com/xtforever/xtcw re, wh Am 22.01.2020 18:26, schrieb Emanuele Petriglia: > Hi! > > I would like to learn how to create a C graphical application without > using some toolkit for hobby. I know that there are two

Re: [PATCH] Flush buffer in time for global (un)lock xserver operation

2019-12-12 Thread walter harms
Am 12.12.2019 03:13, schrieb Chen Gang: >> On Wed, 2019-12-04 at 18:24 +0800, cheng...@emindsoft.com.cn wrote: >>> From: Chen Gang >>> >>> The global (un)lock xserver operations will have effect to the whole >>> system, and all the other gui apps have to be blocked, so the operations >>>

Re: Xorg freezes

2019-12-04 Thread walter harms
Am 04.12.2019 07:11, schrieb Fabin Mundattil: > I have Ubuntu 18 running Google Chrome. Google chrome freezes my machine. I > figured it out that the hardware acceleration is the issue. From what I > understand, something like this shouldn't freeze Xorg. I need to disable > GLX, DRI2 and DRI3 in

Re: [PATCH] libx11-1.6.7: Flush buffer in time for global (un)lock xserver operation

2019-11-27 Thread walter harms
Am 27.11.2019 04:52, schrieb Chen Gang: > Oh, sorry, XFlush should be replaced by _XFlush. > it looks reasonable, NTL can you provide an example works.c vs. not_works.c ? re, wh > On 2019/11/27 上午11:47, Chen Gang wrote: >> The global (un)lock xserver operations will have effect to the

gitlab migration user flodding mailbox

2019-11-19 Thread walter harms
hi List, i get flodded from gitlab migration user by a discussion * Re: amd | System crashes when radeon firmware blob (R520_cp.bin) is installed (#238) I suspect that this is a misconfiguration as i have nothing todo with that, Is there anyone who can fix that ? re, wh

Re: compile simple code on ubuntu linux , error

2019-08-26 Thread walter harms
Am 26.08.2019 00:30, schrieb Turtle Rock: > unablw to initialize font: -5Adobe-courier-r-normal***120* > > on ubuntu 19.04 > window pc wireless modem > > this is from compile/run simple c++ graphic program from book example, (big > c++ 2nd ed, page 77) > > looking to see any

Re: [PATCH app/xev] parse state to describe in-use modifiers

2019-08-14 Thread walter harms
Am 14.08.2019 04:36, schrieb Benjamin Elijah Griffin: > Example for : > > KeyPress event, serial 28, synthetic NO, window 0x2a1, > root 0x176, subw 0x0, time 605237548, (-825,547), root:(303,559), > state 0x4, keycode 54 (keysym 0x63, c), same_screen YES, > modifier: control >

Re: [PATCH xf86-video-cirrus] Declare an I2C bus name string as a static type for alp_i2c.c (walter harms)

2019-07-19 Thread walter harms
your patch, it will show up in the log and a seconde person has a chance to figure out what was going on. re, wh > Regards, > > Kevin Brace > Brace Computer Laboratory blog > https://bracecomputerlab.com > > >> Date: Thu, 18 Jul 2019 09:02:52 +0200 >> From: walter

Re: [PATCH xf86-video-cirrus] Declare an I2C bus name string as a static type for alp_i2c.c

2019-07-18 Thread walter harms
HI, thx for your patch, would you like to explain why ? what problem do you try to solve ? re, wh Am 18.07.2019 04:55, schrieb Kevin Brace: > Signed-off-by: Kevin Brace > --- > src/alp_i2c.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/alp_i2c.c

Re: X.Org modules which could use some help to release

2019-07-15 Thread walter harms
Am 15.07.2019 13:02, schrieb Thomas Klausner: > On Sun, Jul 14, 2019 at 06:34:20PM -0700, Alan Coopersmith wrote: >> These I skipped because we don't package them in Solaris and I don't know if >> anyone else still uses them or they should just be archived now: >> - app/beforelight >> -

Re: X.Org modules which could use some help to release

2019-07-15 Thread walter harms
Am 15.07.2019 03:34, schrieb Alan Coopersmith: > As you may have noticed, I've been working through the various modules to make > releases of those with significant enough change to justify a release (i.e. > more than just the autogen.sh cleanups & gitlab README/configure.ac updates). > >

Re: libXres cannot find Xutil.h and Xlibint.h

2019-06-23 Thread walter harms
Am 23.06.2019 20:04, schrieb alexandre schenberg: > Hello. I have been trying to compile libXres and have failed to do so, > presumably because Xres cannot find Xutil.h and Xlibint.h due to some reason. > Here is the beggining of the problem: > make[2]: Entering directory >

Re: [ANNOUNCE] libXt 1.2.0

2019-06-22 Thread walter harms
Am 22.06.2019 02:11, schrieb Alan Coopersmith: > On 6/21/19 4:54 PM, Chris Sorenson wrote: >> Thanks for your work on this guys, those of us who still depend >> professionally on Xt and Motif really appreciate it! >> >> Now, can you please remove "Xt is a similarly deprecated library for >>

Re: support question regarding X11 1.20.1

2019-06-20 Thread walter harms
Am 19.06.2019 23:10, schrieb Greenamyer, Shaun: > Hey guys, > I hope this message isn't an annoyance but I'm not sure the best place to > turn right now. > I am having an issue with my X windows not getting "erased" when the window > is closed. I'm probably not explaining well which is why my

Re: Fault reports and bug fixes and expectations

2019-06-18 Thread walter harms
Am 18.06.2019 18:33, schrieb Adam Jackson: > On Mon, 2019-06-17 at 10:31 +, Wheatley, Martin R wrote: > >> If Oracle will only take the Xorg source rather (as opposed to fixing >> it - or even discussing a fix with Xorg - and pushing the fix back to >> Xorg) who and when will the issue be

Re: libXt release

2019-06-17 Thread walter harms
Hello Matt, Thomas Dickey has an impressive array of systems where he can test. Is there a way to test on more systems ? We still have a bunch of #ifdef stuff. I would like see tests on AIX, SUN and WIN32 so we can figure out what is relevant. re, wh Am 17.06.2019 02:08, schrieb Thomas

Re: rfc: WIN32 vs _WIN32 and more

2019-05-21 Thread walter harms
Am 20.05.2019 21:09, schrieb Jon Turney: > On 17/05/2019 21:00, Thomas Dickey wrote: >> On Fri, May 17, 2019 at 10:08:47AM +0200, walter harms wrote: >>> Hi list, >>> is there a common ground for using OS related defines ? >>> I was look at some libs and fou

Re: rfc: WIN32 vs _WIN32 and more

2019-05-17 Thread walter harms
Am 17.05.2019 21:51, schrieb Thomas Dickey: > On Fri, May 17, 2019 at 04:26:10PM +0200, walter harms wrote: >> >> >> Am 17.05.2019 13:01, schrieb James Larrowe: >>> I use _WIN32 or __WIN32__ depending on the context. >>> >> my idea was to redu

Re: rfc: WIN32 vs _WIN32 and more

2019-05-17 Thread walter harms
Am 17.05.2019 21:57, schrieb Thomas Dickey: > On Fri, May 17, 2019 at 10:08:47AM +0200, walter harms wrote: >> Hi list, >> is there a common ground for using OS related defines ? >> I was look at some libs and found some defines that >> look pretty ancient. And s

Re: rfc: WIN32 vs _WIN32 and more

2019-05-17 Thread walter harms
Am 17.05.2019 13:01, schrieb James Larrowe: > I use _WIN32 or __WIN32__ depending on the context. > my idea was to reduce the number of defines :) the problem is that i have no way to test what would happen if i replace WIN32 with _WIN32. So the question is left, is WIN32 still used ? re,

rfc: WIN32 vs _WIN32 and more

2019-05-17 Thread walter harms
Hi list, is there a common ground for using OS related defines ? I was look at some libs and found some defines that look pretty ancient. And some like WIN32 vs _WIN32 seems to confuse other people also ( ask you search engine) I found also: ISC * MOTOROLA * VMS* USG* hpux sgi sparc sun

Re: Proposed addition to CodingStyle web page about assert(a && b)

2019-05-05 Thread walter harms
Am 05.05.2019 09:11, schrieb Matthieu Herrb: > On Sat, May 04, 2019 at 03:47:31PM -0700, Adam Richter wrote: >> Hi, everyone. >> >> I would like to propose that whoever has the ability to edit the web >> page add a line like the following to >> https://www.x.org/wiki/CodingStyle/ : >> >> -

update

2019-04-30 Thread walter harms
hi, es gab ein update für inno.x auf der 183.121. Sichbar vor allem ist das es nun ein startscript gibt (inno.sh) das aus/an schalten der sonde erfolgt nun extern im script *immer* wenn sich das programm beendet hat. re, wh ___ xorg-devel@lists.x.org:

Re: [DEVEL] XftTextExtents8 function and spaces characters

2019-04-24 Thread walter harms
Hi, i did not see an answer so i will try: The docu says: "XftTextExtents8 computes the pixel extents of "string" when drawn with "font". " IMHO: the point here is: "pixel extents" i read "find the last pixel" white space has no pixel so it should be ignored. In that logic leading spaces get not

Re: [PATCH 4/9] xkbtext: fix copy-paste error

2019-03-24 Thread Walter Harms
> Konstantin Kharlamov hat am 24. März 2019 um 00:51 > geschrieben: > > > As can be seen in diff, nOut is always 0 here. The code was likely > copy-pasted from comparisons further below. > > Fixes LGTM warning "Comparison is always false because nOut <= 0." > > Signed-off-by: Konstantin

Re: Problem with mapping a key to multiple characters (Unicode + diacritic symbol)

2019-03-19 Thread Walter Harms
> Pierre-Luc Angles hat am 19. März 2019 um > 00:14 geschrieben: > > > Thanks for your answers! > > I do not have ideas if Ilya or Walter is right for the configuration of > /etc/profile... Do others have an idea? > It is a matter of taste actualy, i do not like to interfere with

Re: Problem with mapping a key to multiple characters (Unicode + diacritic symbol)

2019-03-18 Thread Walter Harms
> Ilya Anfimov hat am 18. März 2019 um 16:24 geschrieben: > > > On Mon, Mar 18, 2019 at 03:56:16PM +0100, Pierre-Luc Angles wrote: > > Dear Ilya, dear ??en, dear all, > > > > Thanks for your messages. > > > > The font that I am using with this keys is Junicode. > > > > A big thank you to

Re: [PATCH xf86-video-trident 1/3] Tab to spaces conversion for blade_accel.c

2019-02-21 Thread Walter Harms
maybe it is cheaper to kill the dead code instead of fixing white space ? re, wh > Kevin Brace hat am 21. Februar 2019 um 20:55 geschrieben: > > > Signed-off-by: Kevin Brace > --- > src/blade_accel.c | 491 > +++--- > 1 file changed, 244

Re: Let's merge mkfontdir into mkfontscale

2019-02-19 Thread Walter Harms
> Alan Coopersmith hat am 19. Februar 2019 um > 03:40 geschrieben: > > > Maintaining a separate repo & set of tarball releases for a 3 line > shell script wrapper around mkfontscale and its man page just doesn't > seem to have been a good use of time for the past 15 years, so let's > stop

Re: [PATCH xf86-input-synaptics] Use fabs() instead of abs() on double values.

2019-02-10 Thread Walter Harms
> Matthieu Herrb hat am 10. Februar 2019 um 17:29 > geschrieben: > > > Silences clang warnings. > > Signed-off-by: Matthieu Herrb seems resonable Reviewed-by: Walter Harms wharms@bfs,de > --- > src/synaptics.c | 8 > 1 file changed, 4 insertions(+),

Re: [PATCH xf86-video-neomagic] Use fabs() instead of abs() on double value.

2019-02-10 Thread Walter Harms
> Matthieu Herrb hat am 10. Februar 2019 um 17:20 > geschrieben: > > > Silences clang warnings. > > Signed-off-by: Matthieu Herrb Reviewed-by: Walter Harms wharms@bfs,de > --- > src/neo_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH xf86-input-joystick] Silence clang warnings on floating point abs() / pow() calls.

2019-02-10 Thread Walter Harms
> Matthieu Herrb hat am 10. Februar 2019 um 17:15 > geschrieben: > > > Signed-off-by: Matthieu Herrb > --- > src/jstk_axis.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/jstk_axis.c b/src/jstk_axis.c > index cb4a004..37bb66b 100644 > ---

Re: [PATCH app/xinit] Buffer overflow with many arguments.

2019-02-08 Thread Walter Harms
> > $ xinit $(seq 1 500) > > Signed-off-by: Tobias Stoeckmann works for me Reviewed-by: Walter Harms wharms@bfs,de > --- > Integrated calculation as suggested by Walter with style according to > rest of the code. > --- > xinit.c | 7 --- > 1 file chang

Re: [xorgproto] Remove RCS Ids

2019-01-31 Thread walter harms
nclude/X11/extensions/xcalibratewire.h > +++ b/include/X11/extensions/xcalibratewire.h > @@ -1,6 +1,4 @@ > /* > - * $Id: xcalibratewire.h,v 1.1.1.1 2004/06/02 19:18:47 pb Exp $ > - * > * Copyright © 2003 Philip Blundell > * > * Permission to use, copy, mo

Re: having issues..

2019-01-29 Thread Walter Harms
> Jeff Welch hat am 28. Januar 2019 um 20:32 geschrieben: > > > Hey guys.. im having trouble when trying to run startx to start GNOME Desktop. > See below. > hi, there was a patch from Michal Srb some time ago, are you willing to test ? re, wh > > > [jwelch@Jeff-CentOS-Server /]$

Re: xwd: ./dsimple.c:277:17: warning: macro expands to multiple statements [-Wmultistatement-macros]

2019-01-26 Thread Walter Harms
Perhaps it is better to remove the #define totaly. just my 2 cents, re, wh > "MEERSMAN Koen (EXT)" hat am 24. Januar > 2019 um 11:00 geschrieben: > > > Hi > > When compiling dsimple.c with -Wall we get warning: > > ./dsimple.c: In function 'Select_Window_Args': >

Re: [PATCH app/xinit] Buffer overflow with many arguments.

2019-01-22 Thread Walter Harms
re, > > wh > > There is still a pseudo-magical - 2 missing there, to keep space for the > last NULL assignment. > > But I'm fine with both. As long as 98 is the result. :) > > this is my version, like your patch but the array limit is now calculated. NTL the program needs

Re: [PATCH] XF86keysym: Add XF86XK_RotationLockToggle

2019-01-22 Thread Walter Harms
> Hans de Goede hat am 21. Januar 2019 um 20:23 > geschrieben: > > > Add XF86XK_RotationLockToggle keysym, to be used as mapping for evdev's > KEY_ROTATE_LOCK_TOGGLE. > > I've a Point of View P1006W-232 Windows tablet which actually has a > rotate-lock toggle-button. The latest kernel

Re: [PATCH app/xinit] Buffer overflow with many arguments.

2019-01-19 Thread Walter Harms
> Tobias Stoeckmann hat am 18. Januar 2019 um 21:59 > geschrieben: > > > Command line arguments are copied into clientargv and serverargv without > verifying that enough space is available. A high amount of arguments can > therefore trigger a buffer overflow like this: > > $ xinit $(seq 1

Re: [PATCH v2] Fix checking for valid argument of --dpi

2018-12-30 Thread Walter Harms
> Pali Rohár hat am 29. Dezember 2018 um 18:45 > geschrieben: > > > On Monday 26 November 2018 22:17:24 Pali Rohár wrote: > > Function strtod() sets strtod_error to the pointer of the first invalid > > character and therefore it does not have to be first character from input. > > When input

brocken link

2018-12-25 Thread Walter Harms
Hi list, i was looking for some documentation in: https://www.x.org/releases/current/doc/man/man5/xorg.conf.5.xhtml The link for evdev(4) -> https://www.x.org/releases/current/doc/man/man4/evdev.4.xhtml does not exists. merry xmas, wh ___

Re: [PATCH app/twm 1/2] When replacing a colormap, free old map, not new one

2018-10-11 Thread Walter Harms
> Alan Coopersmith hat am 30. September 2018 um > 23:44 geschrieben: > > > Found by Oracle's Parfait 2.2 static analyzer: > > Error: Use after free >Use after free [use-after-free] (CWE 416): > Use after free of pointer Scr > at line 421 of src/util.c in function

Re: [PATCH libXpm] After fdopen(), use fclose() instead of close() in error path

2018-10-11 Thread Walter Harms
> Alan Coopersmith hat am 1. Oktober 2018 um 00:14 > geschrieben: > > > Found by Oracle's Parfait 2.2 static analyzer: > > Error: File Leak >File Leak [file-ptr-leak]: > Leaked File fp > at line 94 of lib/libXpm/src/RdFToBuf.c in function > 'XpmReadFileToBuffer > '. >

Re: [PATCH] devices: break after finding and removing device from lists

2018-09-12 Thread Walter Harms
> Dave Airlie hat am 12. September 2018 um 03:40 > geschrieben: > > > From: Dave Airlie > > Coverity complains about a use after free in here after the > freeing, I can't follow the linked list so well, but whot > says the device can only be on one list once, so break should > fix it. > >

Re: [PATCH app/sessreg] Replace strncpy calls with a sane version that always terminates

2018-09-12 Thread Walter Harms
> Peter Hutterer hat am 12. September 2018 um 06:50 > geschrieben: > > > Fixes coverity complaints about potentially unterminated strings > > Signed-off-by: Peter Hutterer > --- > sessreg.c | 26 +- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --git

Re: [PATCH app/fonttosfnt 5/5] Replace _BSD_SOURCE with _DEFAULT_SOURCE

2018-07-31 Thread Walter Harms
> Peter Hutterer hat am 31. Juli 2018 um 03:53 > geschrieben: > > > /usr/include/features.h:184:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE > are deprecated, use _DEFAULT_SOURCE" [-Wcpp] > # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" Why is is needed

Re: [PATCH app/xev] xev: fix 'mode' in default case (version 2)

2018-07-28 Thread Walter Harms
Hello Eitan, thx for your effort just a general remark: be verbose what you are changing and why (it took me a while to notice the , -> ; change) exspecialy if it fixed a bug (e.g. "... otherwise abc is never assigned.") Dito changes in patches, it is ok to fix a patch, just write it inside like:

Re: [PATCH app/xauth 2/2] Sort entries from most specific to most generic.

2018-06-19 Thread Walter Harms
> Michal Srb hat am 7. Juni 2018 um 16:01 geschrieben: > > > On čtvrtek 7. června 2018 14:59:44 CEST Walter Harms wrote: > > I was thinking about a more permanent solution and sofar i see the correct > > way would to add the two functions to libXau since

Re: [PATCH app/xauth 2/2] Sort entries from most specific to most generic.

2018-06-07 Thread Walter Harms
> Michal Srb hat am 6. Juni 2018 um 08:34 geschrieben: > > > On úterý 5. června 2018 17:46:05 CEST Walter Harms wrote: > > MMh, so far i understand you do an add and then sort the whole thing. > > perhaps it would be more easy to start with a sorted field an

Re: [PATCH app/xauth 2/2] Sort entries from most specific to most generic.

2018-06-05 Thread Walter Harms
> Michal Srb hat am 31. Mai 2018 um 15:12 geschrieben: > > > There is no point in adding entry or merging lists if a FamilyWild entry would > end in front of any entry, or entry without display number would end in front > of entry with number. > > This sorts all entries in order: > *

Re: How to specify a larger font for an application?

2018-05-14 Thread Walter Harms
> Leslie Turriff hat am 11. Mai 2018 um 10:06 geschrieben: > > > I normally use the X2 text editor for most of my file editing, but > although > it is an excellent editor, its default font is too small for me to read > easily, so I'm looking for a way to change

Re: [PATCH xscope] Improve help and manpage.

2018-05-08 Thread Walter Harms
> Alan Coopersmith hat am 6. Mai 2018 um 04:35 > geschrieben: > > > On 07/ 8/13 05:40 PM, Stéphane Aulery wrote: > > Add some details on the verbosity and options -T and -A. > > These two options are not very clear to me. > > > > Signed-off-by: Stéphane Aulery

Re: [PATCH util/makedepend V2] Quote colons in filenames/paths

2018-05-06 Thread Walter Harms
> Alan Coopersmith hat am 5. Mai 2018 um 20:11 > geschrieben: > > > From: Antonio Larrosa > > Makefile doesn't like colons in filenames/paths so they must > be quoted in the output. Otherwise makedepend doesn't work with > full paths that

Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

2018-04-17 Thread Walter Harms
> Frank Binns hat am 16. April 2018 um 22:17 > geschrieben: > > > Adam Jackson writes: > > > ms_queue_vblank() returns false on failure. > > > > Reported-by: Chris Wilson > > Signed-off-by: Adam Jackson >

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

2018-04-05 Thread Walter Harms
> Daniel Stone <dan...@fooishbar.org> hat am 5. April 2018 um 16:08 geschrieben: > > > On 5 April 2018 at 15:06, Walter Harms <wha...@bfs.de> wrote: > >> Daniel Stone <dani...@collabora.com> hat am 5. April 2018 um 15:58 > >> geschriebe

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

2018-04-05 Thread Walter Harms
> Daniel Stone hat am 5. April 2018 um 15:58 > geschrieben: > > > drmmode_crtc_set_mode has a loop nested inside another loop, where both > of them were using 'i' as the loop iterator. Rename it to avoid an > infinite loop. > > Signed-off-by: Daniel Stone

Re: [PATCH:libXaw] Fix xload crashes if the window is wider than 2048 pixels

2018-03-25 Thread Walter Harms
> Alan Coopersmith hat am 25. März 2018 um 07:45 > geschrieben: > > > https://bugs.freedesktop.org/show_bug.cgi?id=96670 > > Signed-off-by: Alan Coopersmith > --- > > I wasn't sure if the size of valuedata could be changed without

Re: [PATCH xserver] present: cap the version returned to the client

2018-03-19 Thread Walter Harms
> Emil Velikov hat am 19. März 2018 um 17:04 > geschrieben: > > > From: Emil Velikov > > As per the protocol, the server should not return version greater than > the one supported by the client. > > Add a spec quote and tweak the

Re: [PATCH libX11] Use flexible array member instead of fake size.

2018-03-15 Thread Walter Harms
> Michal Srb hat am 15. März 2018 um 09:50 geschrieben: > > > The _XimCacheStruct structure is followed in memory by two strings containing > fname and encoding. The memory was accessed using the last member of the > structure `char fname[1]`. That is a lie, prohibits us from

Re: [PATCH xorgproto] randr: MONITORINFO has outputs, not crtcs

2018-02-06 Thread walter harms
It would be nice to have an explanation why this change. re, wh Am 06.02.2018 02:03, schrieb Giuseppe Bilotta: > --- > randrproto.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/randrproto.txt b/randrproto.txt > index c06bc90..f57301d 100644 > ---

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

2018-02-05 Thread walter harms
Am 05.02.2018 11:24, schrieb Giuseppe Bilotta: > On Mon, Feb 5, 2018 at 10:44 AM, walter harms <wha...@bfs.de> wrote: >> >> Am 05.02.2018 02:47, schrieb Giuseppe Bilotta: >>> { >>> double sx, sy; >>> + char junk; >>&g

Re: [PATCH xrandr v4 2/5] xrandr: stricter --scale argument parsing

2018-02-05 Thread walter harms
Am 05.02.2018 02:47, schrieb Giuseppe Bilotta: > We used to accept something like --scale 2x3junk as a valid input > (scaling x by 2 and y by 3), even though this isn't really a valid > scaling factor. > > Fix by making sure there is nothing after the parsed number(s). > > Signed-off-by:

Re: [PATCH xf86-video-vesa 3/4] Use VBEFreeVBEInfo not free

2018-01-31 Thread walter harms
Am 31.01.2018 16:48, schrieb Adam Jackson: > A VbeInfoBlock has substructure, just freeing the object will leak. > Unfortunately VBEFreeVBEInfo does not check for NULL first so we have > to. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=25029 > Signed-off-by: Adam Jackson

Re: [PATCH xserver] os: Fix strtok/free crash in ComputeLocalClient

2017-12-07 Thread walter harms
Am 06.12.2017 12:16, schrieb Tomasz Śniatowski: > Don't reuse cmd for strtok output to ensure the proper pointer is > freed afterwards. > > The code incorrectly assumed the pointer returned by strtok(cmd, ":") > would always point to cmd. However, strtok(str, sep) != str if str > begins with

Re: Xstartup handle DISPLAY=(null) correctly

2017-11-20 Thread walter harms
at what circumstances can DISPLAY == '(null)' ? looks more like a bug in an Xserver. re, wh Am 20.11.2017 06:40, schrieb xiaoguang wang: > > > > ___ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel >

Re: touchpad

2017-11-11 Thread walter harms
Am 11.11.2017 00:35, schrieb Lucas Barros: > I, i was installing synaptics and while following the instructions, i > opened the terminal and made cd to the right directory and made > ./configure, but after whem i made make it didn t do anything it just > printed > > make: *** Nenhum alvo

  1   2   3   4   5   6   >