[PATCH] xfree86: Bump ABI versions (video: 19, extension: 9)

2014-10-29 Thread Aaron Plattner
Among other things, commit b851ca968b7cce6d1a6438c05d3d5c8832249704 added a NameWindowPixmap function pointer to ScreenRec, shifting some of the fields around. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- Since the merge window closed yesterday with the xserver 1.17 RC 1 release

Re: [PATCH] xfree86: Bump ABI versions (video: 19, extension: 9)

2014-10-30 Thread Aaron Plattner
On 10/30/2014 01:58 PM, Keith Packard wrote: Aaron Plattner aplatt...@nvidia.com writes: Among other things, commit b851ca968b7cce6d1a6438c05d3d5c8832249704 added a NameWindowPixmap function pointer to ScreenRec, shifting some of the fields around. Signed-off-by: Aaron Plattner aplatt

[PATCH] os: Server terminated successfully is not an error

2014-11-21 Thread Aaron Plattner
caused a problem. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- Is X_NOTICE too weird to use? X_INFO would work too. For reference, X_NOTICE is (!!) and X_INFO is (II). os/log.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/os/log.c b/os/log.c index 7348ad4a2ea1

Re: [PATCH] mi: Fix regression in arc drawing

2014-11-21 Thread Aaron Plattner
are redundant, nuke 'em. Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com --- mi/miarc.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/mi/miarc.c b/mi/miarc.c index 7bbe5b3..c98862c 100644 --- a/mi/miarc.c +++ b/mi/miarc.c @@ -115,21

Re: [PATCH] dummy: Add support for custom resolutions (RandR 1.2)

2014-11-21 Thread Aaron Plattner
On 11/13/2014 10:33 AM, Nicolas Boichat wrote: Defining and setting custom resolutions at runtime is not currently possible with dummy, which is unconvenient for remote desktop applications, see: http://lists.x.org/archives/xorg-devel/2014-September/043928.html This patch adds support XRandR

Re: Is xrandr Border property really immutable

2014-11-21 Thread Aaron Plattner
On 11/16/2014 11:02 AM, Stefan Bruens wrote: Hi everyone, while reading through the randr protocol specification [1], I stumbled on the Border property having the Immutable flag set. Either I did not understand the flag correctly, or it should be removed. The Immutable flag is super

[PATCH xev] Add a -event parameter to control the event mask

2012-06-22 Thread Aaron Plattner
It's annoying to have to sift through a lot of unrelated events if all you care about is one specific class of events (e.g. RandR events). Add a -event parameter that can be used to tune which events to select. When not specified, all events are selected. Signed-off-by: Aaron Plattner aplatt

Re: [PATCH xev] Add a -event parameter to control the event mask

2012-06-25 Thread Aaron Plattner
On 06/24/2012 06:21 PM, Peter Hutterer wrote: On Fri, Jun 22, 2012 at 01:45:47PM -0700, Aaron Plattner wrote: It's annoying to have to sift through a lot of unrelated events if all you care about is one specific class of events (e.g. RandR events). Add a -event parameter that can be used

[PATCH xev v2] Add a -event parameter to control the event mask

2012-06-25 Thread Aaron Plattner
It's annoying to have to sift through a lot of unrelated events if all you care about is one specific class of events (e.g. RandR events). Add a -event parameter that can be used to tune which events to select. When not specified, all events are selected. Signed-off-by: Aaron Plattner aplatt

Re: [PATCH xev v3] Add a -event parameter to control the event mask

2012-06-25 Thread Aaron Plattner
On 06/25/2012 04:52 PM, Peter Hutterer wrote: From: Aaron Plattner aplatt...@nvidia.com It's annoying to have to sift through a lot of unrelated events if all you care about is one specific class of events (e.g. RandR events). Add a -event parameter that can be used to tune which events

Re: [PATCH 2/2] randr: add provider object (v3.1)

2012-06-27 Thread Aaron Plattner
Thanks for writing this up. Comments below. On 06/25/2012 04:19 AM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com A provider object represents a GPU or virtual device that provides rendering or output services to the X server. This is the first rev of a protocol to enumerate

Re: [PATCH 2/2] randr: add provider object (v3.1)

2012-06-28 Thread Aaron Plattner
On 06/28/2012 03:21 AM, Dave Airlie wrote: On Thu, Jun 28, 2012 at 10:36 AM, Dave Airlie airl...@gmail.com wrote: /* Event selection bits */ #define RRScreenChangeNotifyMask (1L 0) /* V1.2 additions */ #define RRCrtcChangeNotifyMask (1L 1) #define RROutputChangeNotifyMask

Re: [PATCH] randr: add provider object (v5.1)

2012-06-28 Thread Aaron Plattner
On 06/28/2012 03:25 AM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com A provider object represents a GPU or virtual device that provides rendering or output services to the X server. This is the first rev of a protocol to enumerate providers devices, set their roles, and provide

[PATCH] randr: Fix REQUEST vs. REQUEST_SIZE_MATCH mismatch

2012-06-29 Thread Aaron Plattner
ProcRRGetScreenSizeRange uses REQUEST(xRRGetScreenSizeRangeReq) followed by REQUEST_SIZE_MATCH(xRRGetScreenSizeRangeReq). This happens to work out because both requests have the same size, so this is not a functional change, just a cosmetic one. Signed-off-by: Aaron Plattner aplatt...@nvidia.com

Re: [PATCH] randr: Fix REQUEST vs. REQUEST_SIZE_MATCH mismatch

2012-06-29 Thread Aaron Plattner
On 06/29/2012 12:57 PM, Alan Coopersmith wrote: On 06/29/12 12:22 PM, Aaron Plattner wrote: ProcRRGetScreenSizeRange uses REQUEST(xRRGetScreenSizeRangeReq) followed by REQUEST_SIZE_MATCH(xRRGetScreenSizeRangeReq). This happens to work out because d'oh, this should read REQUEST_SIZE_MATCH

[PATCH v2] randr: Fix REQUEST vs. REQUEST_SIZE_MATCH mismatch

2012-06-29 Thread Aaron Plattner
ProcRRGetScreenSizeRange uses REQUEST(xRRGetScreenSizeRangeReq) followed by REQUEST_SIZE_MATCH(xRRGetScreenInfoReq). This happens to work out because both requests have the same size, so this is not a functional change, just a cosmetic one. Signed-off-by: Aaron Plattner aplatt...@nvidia.com

Re: [PATCH:libX11 1/2] XCreate{Pix, Bit}map...Data: Free pixmap in error path if XCreateGC fails

2012-07-02 Thread Aaron Plattner
Leak Leaked X Resource pix at line 70 of CrPFBData.c in function 'XCreatePixmapFromBitmapData'. pix initialized at line 66 with XCreatePixmap Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com -- Aaron --- src

Re: effective API/ABI surfaces

2012-07-02 Thread Aaron Plattner
On 07/02/2012 03:22 AM, Dave Airlie wrote: Hi, Just wondering about what sort of things are considered ABI breaks in reality, From my understanding, I should be able to a) add new members to end of ScreenRec. b) add new members to xf86ScrnInfoRec in the reserved sections. Can I though add

Re: [PATCH 05/36] xf86: cleanup helper code to use a pointer.

2012-07-03 Thread Aaron Plattner
); Spacing got messed up here. Otherwise, Reviewed-by: Aaron Plattner aplatt...@nvidia.com -- Aaron /* * EnableDisableFBAccess now gets initialized in InitOutput() - * xf86Screens[i]-EnableDisableFBAccess = xf86EnableDisableFBAccess; + * pScrn-EnableDisableFBAccess

Re: [PATCH 04/36] dix: introduce gpu screens. (v3)

2012-07-03 Thread Aaron Plattner
On 07/02/2012 03:12 AM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com diff --git a/render/glyph.c b/render/glyph.c index acb573f..c121e64 100644 --- a/render/glyph.c +++ b/render/glyph.c @@ -687,6 +687,8 @@ miGlyphs(CARD8 op, PicturePtr GetGlyphPicture(GlyphPtr glyph, ScreenPtr

[PATCH] xf86: Re-export extension disable flags

2012-07-16 Thread Aaron Plattner
These flags were unexported by commit a1d41e311c21eb6627caa0d168e070ceaf90806f, which moved the declarations around and lost the _X_EXPORT attributes in the process. Since drivers need these and it's late in the release cycle, just re-export them for now. Signed-off-by: Aaron Plattner aplatt

[PATCH] dix: don't use new as a parameter name

2012-07-20 Thread Aaron Plattner
new is a reserved word in C++. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- include/screenint.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/screenint.h b/include/screenint.h index e36b4d8..e61cd33 100644 --- a/include/screenint.h +++ b/include

Re: [PATCH modesetting] Implement -driverFunc

2012-07-20 Thread Aaron Plattner
On 07/19/2012 03:15 PM, Adam Jackson wrote: Copied from fbdev, makes it so we can run without iopl. Signed-off-by: Adam Jackson a...@redhat.com --- src/driver.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/src/driver.c b/src/driver.c index

Re: [PATCH modesetting] Implement -driverFunc

2012-07-20 Thread Aaron Plattner
On 07/20/2012 03:28 PM, Adam Jackson wrote: On 7/20/12 3:44 PM, Aaron Plattner wrote: On 07/19/2012 03:15 PM, Adam Jackson wrote: +static Bool +ms_driver_func(ScrnInfoPtr scrn, xorgDriverFuncOp op, void *data) +{ +xorgHWFlags *flag; + +switch (op) { +case GET_REQUIRED_HW_INTERFACES

Re: [PATCH test/xts 04/18] Build Xt3

2012-07-25 Thread Aaron Plattner
On 07/24/2012 12:00 PM, Peter Harris wrote: Signed-off-by: Peter Harris phar...@opentext.com This causes the build to fail on my system: make[4]: Entering directory `/home/aaron/git/x/xts/xts5/Xt3' CCLD CompositeWidget ../../xts5/src/.libs/libxts5.so: undefined reference to

Re: [PATCH 0/3] Post-XAAectomy cleanup

2012-07-25 Thread Aaron Plattner
that was fixed long ago though (never having had any nVidia hardware, it's pretty hard for me to test such things). According to git, I disabled it by default in April of 2007 and deleted the option to let users turn it back on in January of this year. So, Acked-by: Aaron Plattner aplatt

[PATCH xts] doc: fix man page installation and distcheck

2012-07-26 Thread Aaron Plattner
in the rule to copy the README to XTS.txt. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- Makefile.am |4 ++-- configure.ac |4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 87040d2..9083bb6 100644 --- a/Makefile.am +++ b

Re: [PATCH xts] doc: fix man page installation and distcheck

2012-07-26 Thread Aaron Plattner
On 07/25/2012 11:29 PM, Aaron Plattner wrote: When asciidoc and xmlto are available, HAVE_DOCTOOLS. This turns on code that Whoops, sent this too soon. This sentence no verb. This should read, HAVE_DOCTOOLS is enabled defines miscmandir = $(MISC_MAN_DIR) and sets miscman_DATA = XTS

Re: [PATCH xts] doc: fix man page installation and distcheck

2012-07-26 Thread Aaron Plattner
On 07/26/2012 09:23 PM, Peter Hutterer wrote: On Wed, Jul 25, 2012 at 11:29:02PM -0700, Aaron Plattner wrote: When asciidoc and xmlto are available, HAVE_DOCTOOLS. This turns on code that defines miscmandir = $(MISC_MAN_DIR) and sets miscman_DATA = XTS.$(MISC_MAN_SUFFIX). However

Re: [RFC PATCH] xfree86: Lid status hack

2012-07-30 Thread Aaron Plattner
On 07/30/2012 01:08 PM, Alex Deucher wrote: On Mon, Jul 30, 2012 at 3:43 PM, Adam Jackson a...@redhat.com wrote: If more than one output is connected, and there's only one ACPI lid device, proxy the state of the lid into the LVDS / eDP connectivity. This way we don't suffer from broken

[PATCH] xfree86: Bump extension ABI to 7.0

2012-08-17 Thread Aaron Plattner
Commit 9d457f9c55f12106ba44c1c9db59d14f978f0ae8 added an array of DevPrivateSetRec structures in the middle of the ScreenRec, which throws off extension modules trying to call things like pScreen-DestroyPixmap. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- hw/xfree86/common/xf86Module.h

Re: [PATCH 0/3 v2] xrandr: fix misc --gamma bugs

2012-08-24 Thread Aaron Plattner
On 08/24/2012 03:53 PM, Andy Ritger wrote: As I understand it: the gamma-correction tables configured through XRR[GS]etCrtcGamma store 16:16:16 X Colors. An X Color has some number of significant bits, stored in the MSBs of the X Color (reported in Visual::bits_per_rgb, though the

[PATCH xrandr 0/2] Fix warnings

2012-08-24 Thread Aaron Plattner
help make it cleaner, but hopefully this is a start. Aaron Plattner (2): xrandr: Fix string constness bugs xrandr: Fix variable declaration warnings xrandr.c | 431 -- 1 file changed, 223 insertions(+), 208 deletions

[PATCH xrandr 1/2] xrandr: Fix string constness bugs

2012-08-24 Thread Aaron Plattner
’ discards ‘const’ qualifier from pointer target type [enabled by default] /X/include/X11/extensions/Xrandr.h:383:1: note: expected ‘char *’ but argument is of type ‘const char *’ Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 23 --- 1 file changed, 12

[PATCH xrandr 2/2] xrandr: Fix variable declaration warnings

2012-08-24 Thread Aaron Plattner
to be more specific (e.g. output - config_output) so the more generic variable in the inner scope (e.g. the 'output' variable used to iterate over all outputs) doesn't have to change. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 408

Re: [PATCH:libXrandr] Constify a couple string arguments that are just copied, not modified

2012-09-01 Thread Aaron Plattner
: expected ‘char *’ but argument is of type ‘const char *’ Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com I almost sent this exact patch out, but never got around to it. Thanks for fixing this. Reviewed-by: Aaron Plattner aplatt...@nvidia.com -- Aaron --- include/X11

Re: [PATCH v2 4/4] dix: Delete mibstore.h

2012-09-10 Thread Aaron Plattner
); driver/xf86-video-intel/src/sna/sna_driver.c:887: miInitializeBackingStore(screen); driver/xf86-video-intel/src/intel_driver.c:962: miInitializeBackingStore(screen); Some of these are important, so Nacked-by: Aaron Plattner aplatt...@nvidia.com -- Aaron On 09/05/2012 03:38 PM, Daniel

Re: [PATCH v2 0/4] dix: Remove more backing store leftovers

2012-09-10 Thread Aaron Plattner
of mibstore.h dix: Remove refs to mi backing store from docs Patches 1 through 3, Reviewed-by: Aaron Plattner aplatt...@nvidia.com -- Aaron dix: Delete mibstore.h exa/exa_priv.h | 1 - fb/fb.h | 1 - hw/dmx/doc/dmx.xml | 12 ++-- hw/kdrive

Re: [PATCH] Use new pixman_glyph_cache_t API that will be in pixman 0.28.0

2012-09-12 Thread Aaron Plattner
I ran some cairo-perf-trace numbers on Xorg with an accelerated driver. xorg-server-1.13.0, glyph cache disabled: [ # ] backend test min(s) median(s) stddev. count [ 0] xlibfirefox-particles 40.857 40.865 0.02%6/6 [ 1] xlib

Re: [PATCH] Use new pixman_glyph_cache_t API that will be in pixman 0.28.0

2012-09-12 Thread Aaron Plattner
On 09/12/2012 08:38 AM, Søren Sandmann wrote: Aaron Plattner aplatt...@nvidia.com writes: I ran some cairo-perf-trace numbers on Xorg with an accelerated driver. xorg-server-1.13.0, glyph cache disabled: [ # ] backend test min(s) median(s) stddev. count [ 0

Re: [PATCH] miext/damage: Only wrap into the GC ops chain if there's a listener (v3)

2012-09-20 Thread Aaron Plattner
the serial number of the affected drawable (and all children if it's a window) so subsequent drawing against the damage will trigger another ValidateGC pass and we wrap in/out correctly. Spotted by Aaron Plattner. Signed-off-by: Adam Jackson a...@redhat.com --- miext/damage/damage.c | 30

Re: [PATCH 1/7] xfree86: Bump video ABI to 14

2012-09-24 Thread Aaron Plattner
) #define ABI_XINPUT_VERSIONSET_ABI_VERSION(18, 0) #define ABI_EXTENSION_VERSION SET_ABI_VERSION(7, 0) #define ABI_FONT_VERSION SET_ABI_VERSION(0, 6) Given the rest of these changes, Reviewed-by: Aaron Plattner aplatt...@nvidia.com ___ xorg

Re: gc funcs and ops at screen level

2012-10-02 Thread Aaron Plattner
On 10/02/2012 05:45 PM, Dave Airlie wrote: It seems wierd that we have the GC carrying around a pointer to each of these, when I don't see any evidence we can't just stash one set of ops/funcs per screen. Did we every, do we currently to anyone knowledge modify gc ops or funcs at anything less

Re: [PATCH] xfree86: add xf86UpdateDesktopDimensions()

2012-10-02 Thread Aaron Plattner
(18, 0) #define ABI_EXTENSION_VERSION SET_ABI_VERSION(7, 0) #define ABI_FONT_VERSION SET_ABI_VERSION(0, 6) Reviewed-by: Aaron Plattner aplatt...@nvidia.com Good to get Andy's review too since he's the one working around this particular bug. -- Aaron

Re: [PATCH] xf86: take next pointer before calling handler

2012-10-08 Thread Aaron Plattner
On 10/08/2012 10:54 AM, Keith Packard wrote: * PGP Signed by an unknown key Maarten Lankhorst maarten.lankho...@canonical.com writes: Taking a pointer to ih-next before calling the event handler fixes this. Yay, more open coded lists. Any way we could encourage you to replace it with a

[PATCH] config/udev: get driver suggestions from udev

2012-10-17 Thread Aaron Plattner
with a given drm device using rules that look like this: SUBSYSTEM==drm, DRIVERS==i915, ENV{xorg_drivers}=intel Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- config/udev.c | 23 --- hw/xfree86/common/xf86platformBus.c | 20 +++- include

[PATCH] config/udev: fix removing GPU device format string mistake

2012-10-17 Thread Aaron Plattner
udev.c: In function 'device_removed': udev.c:270:9: warning: format '%d' expects argument of type 'int', but argument 3 has type 'const char *' [-Wformat] Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- There are plenty of other format warnings, but this one was particularly egregious

Re: [PATCH] config/udev: get driver suggestions from udev

2012-10-17 Thread Aaron Plattner
On 10/17/2012 04:12 PM, Peter Hutterer wrote: On Wed, Oct 17, 2012 at 03:02:53PM -0700, Aaron Plattner wrote: If the udev device corresponding to a platform drm device has an xorg_drivers property associated with it, treat that as a comma-separated list of driver suggestions to use. Otherwise

Re: [PATCH 07/12] render: fix shadow warnings

2012-10-29 Thread Aaron Plattner
On 10/28/2012 12:27 PM, walter harms wrote: Am 28.10.2012 04:01, schrieb Yaakov (Cygwin/X): From: Yaakov Selkowitz yselkow...@users.sourceforge.net Signed-off-by: Yaakov Selkowitz yselkow...@users.sourceforge.net --- render/picturestr.h |8 1 files changed, 4 insertions(+), 4

Re: [PATCH 1/4] xfree86: Remove some unused variables

2012-11-08 Thread Aaron Plattner
These all seem fine to me. For the series, Reviewed-by: Aaron Plattner aplatt...@nvidia.com -- Aaron On 11/08/2012 05:50 AM, Thierry Reding wrote: GCC complains about these variables being set but not used, so they can just as well be removed. Signed-off-by: Thierry Reding thierry.red

Re: xf86-video-tegra or xf86-video-modesetting?

2012-11-26 Thread Aaron Plattner
On 11/24/2012 01:09 PM, Thierry Reding wrote: Hi, With tegra-drm going into Linux 3.8 and NVIDIA posting initial patches for 2D acceleration on top of it, I've been looking at the various ways how this can best be leveraged. The most obvious choice would be to start work on an xf86-video-tegra

Re: [PATCH xwd] Translate window by -geometry

2012-11-29 Thread Aaron Plattner
From c851a7b1e8c817853210be85beb34c8679a004d1 Mon Sep 17 00:00:00 2001 From: Matt Vollrath m...@endpoint.com Date: Fri, 2 Nov 2012 17:55:12 + Subject: [PATCH xwd] Translate window by -geometry This is intended to allow dumps of arbitrary sections of the root window. Signed-off-by:

Re: [PATCH xtest] Allow space in read buffer for CRLF and NUL

2012-12-06 Thread Aaron Plattner
I'll take your word for it that tcc does what the message says. A comment above linebuf mentioning why it's 515 bytes might be nice, but in any case, Reviewed-by: Aaron Plattner aplatt...@nvidia.com On 12/04/2012 03:38 PM, Peter Harris wrote: tcc will limit output lines to 512 characters

Re: [PATCH v2] xf86: take next pointer before calling handler

2012-12-06 Thread Aaron Plattner
Seems fine. Reviewed-by: Aaron Plattner aplatt...@nvidia.com -- Aaron On 12/04/2012 02:21 AM, Maarten Lankhorst wrote: Stopping acpid before Xorg with valgrind --free-fill=df results in this crash backtrace: ==2670== Invalid read of size 8 ==2670==at 0x1B9CB0: xf86Wakeup (xf86Events.c

Re: [PATCH] xfree86/hotplug: cleanup properly if the screen fails to initialise

2012-12-12 Thread Aaron Plattner
-off-by: Dave Airlie airl...@redhat.com Seems reasonable, so Reviewed-by: Aaron Plattner aplatt...@nvidia.com Should InitOutput make its calls to AddGPUScreen similarly non-fatal? Also, should the !xf86GPUScreens[i]-configured failure path also call xf86UnclaimPlatformSlot? -- Aaron

Re: [PATCH] xfree86: print message to the log when zapping the server

2012-12-12 Thread Aaron Plattner
Peter reminded me that this is not called from a signal handler. Reviewed-by: Aaron Plattner aplatt...@nvidia.com -- Aaron On 12/11/2012 05:02 PM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86Events.c | 1 + 1 file changed, 1

Re: [PATCH driver/xf86-video-nested] Remove miInitializeBackingStore()

2012-12-20 Thread Aaron Plattner
); -miInitializeBackingStore(pScreen); xf86SetBackingStore(pScreen); miDCInitialize(pScreen, xf86GetPointerScreenFuncs()); Ping? It's weird that it called this but nothing includes mibstore.h. In any case, Reviewed-by: Aaron Plattner aplatt...@nvidia.com -- Aaron

[PATCH] dix: Make small bitfields that store enums unsigned

2012-12-21 Thread Aaron Plattner
this: client-clientState = ClientStateGone; assert(client-clientState == ClientStateGone); // this assert fails Also change the signedness of nearby bitfields to match. Cc: Adam Jackson a...@redhat.com Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- include/dixstruct.h | 12

Re: [PATCH xrandr] xrandr: print primary output

2013-01-02 Thread Aaron Plattner
On 12/26/2012 11:49 PM, Pierre-Loup A. Griffais wrote: Ping; anyone feel like merging this? To ssh://git.freedesktop.org/git/xorg/app/xrandr b26fd53..094b40e master - master -- Aaron Thanks, - Pierre-Loup On 12/19/2012 12:35 PM, Pierre-Loup A. Griffais wrote: I could have sworn

Re: [PATCH xts] Set XT_DISPLAYHOST for remote connections

2013-01-04 Thread Aaron Plattner
On 01/02/2013 02:38 PM, Peter Harris wrote: Some tests segfault if XT_DISPLAY is set and XT_DISPLAYHOST is not. Signed-off-by: Peter Harris phar...@opentext.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com Which test? I did set DISPLAY=localhost:1 and verified that XT_DISPLAYHOST ends

[PATCH xts] xts5: include xtrans CFLAGS when building libXst

2013-01-04 Thread Aaron Plattner
If xtrans is installed in a weird location, libXst fails to build: ConnDis.c:43:31: fatal error: X11/Xtrans/Xtrans.h: No such file or directory Fix this by including $(XT_CFLAGS) to pick up the path to Xtrans.h. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xts5/src/libproto

[PATCH] randr: unref the provider shared pixmap the appropriate number of times

2013-01-23 Thread Aaron Plattner
be decremented when the slave pixmap is destroyed. Fix this by just unreffing the pixmap twice in RRCrtcDetachScanoutPixmap. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- randr/rrcrtc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c index e82d050

[PATCH] man: Add -event to the command synopsis

2013-01-29 Thread Aaron Plattner
Commit d33b2c81bd931d581e5ce4b36f99ee60a76e740d added an option, -event, to allow the user to select which events to display. I remembered to add it to the man page's OPTIONS, section, but not to the command summary in the SYNOPSIS section. Signed-off-by: Aaron Plattner aplatt...@nvidia.com

[PATCH xrandr] man: document provider options

2013-02-04 Thread Aaron Plattner
I hope I got the --setprovideroffloadsink parameters the right way around. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- man/xrandr.man | 17 + 1 file changed, 17 insertions(+) diff --git a/man/xrandr.man b/man/xrandr.man index f04d2ed..2455756 100644 --- a/man

[PATCH xrandr 1/2] xrandr: make providers a first-class citizen

2013-02-05 Thread Aaron Plattner
Create a struct _provider to match the existing output, crtc, etc. objects. Build that from a new get_providers() function. Use that to populate the list when querying the providers. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 62

[PATCH xrandr 0/2] Provider handling fixes

2013-02-05 Thread Aaron Plattner
(authored by Dave) that bumps the reported extension version to 1.4. Aaron Plattner (2): xrandr: make providers a first-class citizen xrandr: look for providers by name or xid xrandr.c | 157 +++ 1 file changed, 128 insertions(+), 29

[PATCH xrandr 2/2] xrandr: look for providers by name or xid

2013-02-05 Thread Aaron Plattner
and RandR 1.4 isn't supported. Make get_screen robust against being called multiple times. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 99 +++- 1 file changed, 79 insertions(+), 20 deletions(-) diff --git a/xrandr.c b

[PATCH] randr: bump advertised RandR version to 1.4

2013-02-05 Thread Aaron Plattner
From: Dave Airlie airl...@gmail.com Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com Tested-by: Aaron Plattner aplatt...@nvidia.com --- I did a quick grep of the drivers and they all either ignore RANDR_INTERFACE_VERSION as returned

[PATCH xrandr 2/5] Bug #37043: adjust refresh rates for doublescan and interlace

2013-02-06 Thread Aaron Plattner
These two flags halve and double, respectively, the effective refresh rate of a mode. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/xrandr.c b/xrandr.c index b0e8cec..54e0ca8 100644

[PATCH xrandr 0/5] Low-hanging fruit

2013-02-06 Thread Aaron Plattner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This series fixes a number of simple bugs, plus a warning I accidentally introduced. Once these are in, I'll make an xrandr-1.3.6 release. Aaron Plattner (5): Bug #29603: document that there might be multiple preferred modes Bug #37043: adjust

[PATCH xrandr 4/5] Bug #14118: print usage() to stdout, proper errors for bad arguments

2013-02-06 Thread Aaron Plattner
. and exits. Use that to print proper error messages. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 297 --- 1 file changed, 153 insertions(+), 144 deletions(-) diff --git a/xrandr.c b/xrandr.c index a9bd9e5..7fb0b0b

[PATCH xrandr 3/5] Bug #11397: check that numeric --orientation arguments are in range

2013-02-06 Thread Aaron Plattner
that out-of-range numeric values are rejected properly. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xrandr.c b/xrandr.c index 54e0ca8..a9bd9e5 100644 --- a/xrandr.c +++ b/xrandr.c @@ -2591,8 +2591,8 @@ main (int

[PATCH xrandr 1/5] Bug #29603: document that there might be multiple preferred modes

2013-02-06 Thread Aaron Plattner
the *first* preferred mode. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- man/xrandr.man | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/xrandr.man b/man/xrandr.man index 2455756..900095c 100644 --- a/man/xrandr.man +++ b/man/xrandr.man @@ -78,7 +78,7 @@ screen

[PATCH xrandr 5/5] Cast XID to unsigned int to suppress a printf warning

2013-02-06 Thread Aaron Plattner
-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xrandr.c b/xrandr.c index 7fb0b0b..adc11a6 100644 --- a/xrandr.c +++ b/xrandr.c @@ -642,7 +642,7 @@ print_name (const name_t *name) { name_kind_t kind = name-kind

[PATCH] DPMS: include GPU screens in DPMS code

2013-02-07 Thread Aaron Plattner
Otherwise, displays driven by GPU screens remain on all the time. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- hw/xfree86/common/xf86DPMS.c | 45 ++-- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/hw/xfree86/common/xf86DPMS.c b

Re: [PATCH libXScrnSaver] Fix typo in man page: XScreenSaverSaverRegister()

2013-02-08 Thread Aaron Plattner
On 02/08/2013 01:36 AM, Daniel Martin wrote: Signed-off-by: Daniel Martin consume.no...@gmail.com --- man/Xss.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xss.man b/man/Xss.man index 91f0ccf..e2c13f1 100644 --- a/man/Xss.man +++ b/man/Xss.man @@

Re: [ANNOUNCE] xorg-server 1.13.2.901 (1.13.3-rc1)

2013-02-16 Thread Aaron Plattner
Oops, I forgot to send this to the list too. Original Message Subject: Re: [ANNOUNCE] xorg-server 1.13.2.901 (1.13.3-rc1) Date: Sat, 16 Feb 2013 22:48:30 -0800 From: Aaron Plattner aplatt...@nvidia.com To: Matt Dew mar...@osource.org On 13-02-15 11:27 PM, Matt Dew wrote: Hi

Re: [PATCH xts] Remove pad adjustments from Xproto/GetImage/PutImage

2013-02-19 Thread Aaron Plattner
On 12/17/2012 12:38 PM, Peter Harris wrote: GetImage adjusts the length field incorrectly, and PutImage does not adjust the length field at all. Since the only stored images are those from GetImage, it makes more sense to remove the pad code entirely than to fix it. Signed-off-by: Peter Harris

[ANNOUNCE] xts 0.99.1

2013-02-19 Thread Aaron Plattner
333991 317 265 8 065 9 0 0 +TOTAL1007 5563 443696 670 26810 074 9 0 0 Aaron Plattner (7): Bump version to 0.99.1 tet: Ignore SIGWINCH (terminal window size change) xts5: Define X11_t and TRANS_CLIENT to get

[PATCH modular] release.sh: use Cc: rather than CC:

2013-02-19 Thread Aaron Plattner
git-send-email ignores CC headers, so using that to send announcements generated by release.sh fails to actually carbon copy the Cc'd list. Use Cc instead. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH modesetting] match PCI class 3, any subclass

2013-02-20 Thread Aaron Plattner
that by ignoring the low 16 bits of the class in the pci_id_match table. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- src/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/driver.c b/src/driver.c index 05b6176..87ba272 100644 --- a/src/driver.c +++ b/src

Re: Initial DRI3000 protocol specs available

2013-02-20 Thread Aaron Plattner
On 02/19/13 19:45, Keith Packard wrote: * PGP Signed by an unknown key Here's the spec for DRI3: The DRI3 Extension Version 1.0 2013-2-19 Keith Packard

Re: [ANNOUNCE] xts 0.99.1

2013-02-24 Thread Aaron Plattner
On 02/24/13 05:08, Knut Petersen wrote: On 20.02.2013 05:32, Aaron Plattner wrote: This release re-enables all of the Xt* test scenarios, along with the ShapeEx scenario. It also fixes a few test bugs. Some tests are still expected to fail, which is why this is still version 0.99.* rather

[PATCH xrandr] Print spaces between XA_ATOM property values

2013-02-28 Thread Aaron Plattner
. In addition, some drivers create property values with spaces in them, so put commas between entries to disambiguate. For example, Broadcast RGB: Automatic supported: Automatic, Full, Limited 16:235 Do the same for properties with multiple valid ranges. Signed-off-by: Aaron

Re: [PATCH] DPMS: include GPU screens in DPMS code

2013-03-04 Thread Aaron Plattner
On 02/07/2013 09:16 AM, Aaron Plattner wrote: Otherwise, displays driven by GPU screens remain on all the time. Ping? CRTs do make good space heaters, but that probably shouldn't be a design goal of the X server. :) Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- hw/xfree86

Re: [PATCH] libfontenc: setCode(): fix realloc invocation

2013-03-04 Thread Aaron Plattner
a pointer to the dynamically-allocated buffer). 2. Allocate enough memory for (*encsize) shorts, instead of (*encsize) bytes; see the call to malloc just above the realloc call. Signed-off-by: Nickolai Zeldovich nicko...@csail.mit.edu Yikes, that's pretty bad! Reviewed-by: Aaron Plattner aplatt

Re: [PATCH] xserver: add monitor Option ZoomModes

2013-03-04 Thread Aaron Plattner
On 11/21/2012 04:12 AM, v...@picaros.org wrote: Add support for the Option ZoomModes in a monitor section: Section Monitor Identifier a21inch Option PreferredMode 1600x1200 Option ZoomModes 1600x1200 1280x1024 1280x1024 640x480 EndSection ZoomModes seems like an unfortunate name to

[PATCH] fb: Rename wfbDestroyGlyphCache

2013-03-06 Thread Aaron Plattner
Renaming this function was missed in commit 9cbcb5bd6a5360a128d15b77a02d8d3351f74366, so both libfb.so and libwfb.so define functions named fbDestroyGlyphCache. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- fb/wfbrename.h | 1 + 1 file changed, 1 insertion(+) diff --git a/fb

Re: Initial DRI3000 protocol specs available

2013-03-07 Thread Aaron Plattner
On 03/06/2013 10:35 PM, Keith Packard wrote: * PGP Signed by an unknown key Owen Taylor otay...@redhat.com writes: A complex scheme where the compositor and the server collaborate on the implementation of SwapRegion seems fragile to me, and still doesn't get some details right - like the swap

[PATCH] xf86: return NULL for xf86CompatOutput if config-compat_output is -1

2013-03-15 Thread Aaron Plattner
) by 0x862322F: intel_output_init (intel_display.c:1416) by 0x8623F22: intel_mode_pre_init (intel_display.c:1780) by 0x8626088: I830PreInit (intel_driver.c:625) by 0x49873B: InitOutput (xf86Init.c:606) by 0x4257B8: main (main.c:204) Signed-off-by: Aaron Plattner aplatt...@nvidia.com

Re: [PATCH] xf86: return NULL for xf86CompatOutput if config-compat_output is -1

2013-03-18 Thread Aaron Plattner
On 03/18/2013 11:47 AM, Chris Wilson wrote: On Mon, Mar 18, 2013 at 11:31:59AM -0700, Keith Packard wrote: Aaron Plattner aplatt...@nvidia.com writes: If there is no compat output, config-compat_output is -1 and xf86CompatOutput reads before the beginning of the outputs array. Didn't Dave

Re: xrandr providers and offloading to displaylink usb card

2013-03-18 Thread Aaron Plattner
On 03/18/2013 10:08 AM, Sam Lanning wrote: On 07/01/13 07:03, Dave Airlie wrote: On Mon, Jan 7, 2013 at 10:23 AM, Sam Lanning s...@samlanning.com wrote: Hi There, I have a displaylink usb adapter which i have been trying to get working with my setup for a while. when i run xrandr

Re: [PATCH] xserver: add monitor Option ZoomModes

2013-03-19 Thread Aaron Plattner
; +} + +count++; +next = gettoken(next, token, len); +} +} + +return count; +} The revised patch v2 is here below. Servaas. Thanks for making these changes. Version 2 looks good to me: Reviewed-by: Aaron Plattner aplatt...@nvidia.com --- hw

Re: [PATCH xf86-video-nv] Include xf86Modes.h to use functions from hw/xfree86/modes/xf86Modes.c.

2013-03-24 Thread Aaron Plattner
On 03/21/13 13:15, Robert Morell wrote: On Thu, Mar 21, 2013 at 08:59:06AM -0700, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com Reviewed-by: Robert Morell rmor...@nvidia.com Me too. I verified that xf86Modes.h goes back to at least xserver 1.2 (xf86-video-nv

Re: Where is the function xf1bppScreenInit()?

2013-04-25 Thread Aaron Plattner
On 04/25/2013 02:37 AM, ZHANG Zhaolong wrote: Hi all, I am reading xf86-video-vga-4.0.0.5 source code. It shows that: if (pGenericPriv-ShadowFB) call fbScreeInit(); else call xf1bppScreenInit(); The same flow is in xf86-video-cirrus-1.3.2 too. But where is the

Re: [PATCH 4/4] gpu: call CreateScreenResources for GPU screens

2013-04-29 Thread Aaron Plattner
On 01/07/2013 05:31 PM, Dave Airlie wrote: From: Fedora X Ninjas x...@fedoraproject.org I didn't think we needed this before, but after doing some more work with reverse optimus it seems like it should be called. Signed-off-by: Dave Airlie airl...@redhat.com This patch is shipping in Ubuntu

Re: [git pull] randr - reviewed patches.

2013-04-29 Thread Aaron Plattner
On 04/29/13 17:15, Dave Airlie wrote: The following changes since commit 451ba4bd41b82acd4aec6236ba121e00cfeb311b: hw/xfree86: Only report SetDesiredModes() failed if at least one modeset fails (2013-04-29 09:10:06 -0700) are available in the git repository at:

Re: [git pull] randr - reviewed patches.

2013-04-30 Thread Aaron Plattner
On 04/30/2013 05:42 AM, Dave Airlie wrote: On Tue, Apr 30, 2013 at 1:51 PM, Aaron Plattner aplatt...@nvidia.com wrote: On 04/29/13 17:15, Dave Airlie wrote: The following changes since commit 451ba4bd41b82acd4aec6236ba121e00cfeb311b: hw/xfree86: Only report SetDesiredModes() failed

[PATCH] xfree86: don't enable anything in xf86InitialConfiguration for GPU screens

2013-04-30 Thread Aaron Plattner
the warning about no outputs being found on GPU screens, since that's expected. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- Dave, this fixes the black screen problem with gpu: call CreateScreenResources for GPU screens hw/xfree86/modes/xf86Crtc.c | 16 +--- 1 file changed, 13

Re: [PATCH] xfree86: detach scanout pixmaps when detaching output GPUs

2013-05-01 Thread Aaron Plattner
On 04/30/2013 11:30 PM, Dave Airlie wrote: On Wed, May 1, 2013 at 7:14 AM, Aaron Plattner aplatt...@nvidia.com wrote: Commit 8f4640bdb9d3988148e09a08d2c7e3bab1d538d6 fixed a bit of a chicken-and-egg problem by detaching GPU screens when their providers are destroyed, which happens before

<    1   2   3   4   5   6   >