Re: Requiring newer autoconf for X.Org packages?

2022-08-31 Thread Daniel Stone
Hi, On Tue, 30 Aug 2022 at 22:42, Alan Coopersmith wrote: > We document autoconf 2.62 as the minimum release required in: > https://www.x.org/wiki/Building_the_X_Window_System/ > and most modules have AC_PREREQ([2.60]). If I recall correctly, a decade > ago > we didn't want to force use of

Re: 504 to gitlab.freedesktop.org

2022-06-13 Thread Daniel Stone
Hi, On Mon, 13 Jun 2022 at 08:39, Daniel Stone wrote: > Yes, that's what's happening. Our (multi-host-replicated etc) Ceph > storage setup has entered a degraded mode due to the loss of a couple > of disks - no data has been lost but the cluster is currently unhappy. > We're wal

Re: 504 to gitlab.freedesktop.org

2022-06-13 Thread Daniel Stone
On Mon, 13 Jun 2022 at 05:17, Peter Hutterer wrote: > On Sun, Jun 12, 2022 at 05:57:05PM -0700, Jeremy Sequoia wrote: > > I was going to spend a little bit of time putting out an update to XQuartz > > to address a few bugs that I've been meaning to squash, but I'm having a bit > > of an issue

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-16 Thread Daniel Stone
Hi Tomek, On Mon, 16 Mar 2020 at 12:55, Tomek Bury wrote: > I've been wrestling with the sync problems in Wayland some time ago, but only > with regards to 3D drivers. > > The guarantee given by the GL/GLES spec is limited to a single graphics > context. If the same buffer is accessed by 2

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-16 Thread Daniel Stone
Hi, On Mon, 16 Mar 2020 at 15:33, Tomek Bury wrote: > > GL and GLES are not relevant. What is relevant is EGL, which defines > > interfaces to make things work on the native platform. > Yes and no. This is what EGL spec says about sharing a texture between > contexts: Contexts are different

Re: gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
Hi Jan, On Fri, 28 Feb 2020 at 10:09, Jan Engelhardt wrote: > On Friday 2020-02-28 08:59, Daniel Stone wrote: > >I believe that in January, we had $2082 of network cost (almost > >entirely egress; ingress is basically free) and $1750 of > >cloud-storage cost (almost all

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund wrote: > On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: > > Yeah, changes on vulkan drivers or backend compilers should be > > fairly > > sandboxed. > > > > We also have tools that only work for intel stuff, that should never > > trigger

Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
On Fri, 28 Feb 2020 at 08:48, Dave Airlie wrote: > On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > The last I looked, Google GCP / Amazon AWS / Azure were all pretty > > comparable in terms of what you get and what you pay for them. > > Obviously providers like Packet

Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > b) we probably need to take a large step back here. > > Look at this from a sponsor POV, why would I give X.org/fd.o > sponsorship money that they are just giving straight to google to pay > for hosting credits? Google are profiting in some minor

Re: gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
Hi Matt, On Thu, 27 Feb 2020 at 23:45, Matt Turner wrote: > We're paying 75K USD for the bandwidth to transfer data from the > GitLab cloud instance. i.e., for viewing the https site, for > cloning/updating git repos, and for downloading CI artifacts/images to > the testing machines (AFAIU). I

Re: Radeonhd repo not migrated to gitlab.

2019-03-13 Thread Daniel Stone
Hi Kevin, On Wed, 13 Mar 2019 at 16:00, Kevin Brace wrote: > I am not here to side with either one of you (i.e., Luc or you), but I have > been wondering why some of the older, neglected (I use the word "underserved" > to describe it) DDXs in general have weird git and ssh clone addresses. >

Re: Radeonhd repo not migrated to gitlab.

2019-03-07 Thread Daniel Stone
On Fri, 8 Mar 2019 at 10:52, Luc Verhaegen wrote: > A quick look over other > requests back then showed me that it usually took you many days, often > weeks, to answer new project requests. But when _i_ asked, a not too > supportive reply was quickly received. I've snipped most of the misleading

Re: Radeonhd repo not migrated to gitlab.

2019-03-07 Thread Daniel Stone
On Fri, 8 Mar 2019 at 10:15, Luc Verhaegen wrote: > On Fri, Mar 08, 2019 at 10:12:17AM +0900, Daniel Stone wrote: > > I'll admit that somewhere between writing migration scripts, migrating > > the other 1,268 repos from git.fd.o, maintaining our new and old > > infrastru

Re: Radeonhd repo not migrated to gitlab.

2019-03-07 Thread Daniel Stone
On Fri, 8 Mar 2019 at 09:52, Luc Verhaegen wrote: > On Fri, Mar 08, 2019 at 06:37:21AM +0900, Daniel Stone wrote: > > FWIW, It was unique amongst all Xorg repos in that it didn't have a > > .git suffix on the directory (i.e. its path was > > /srv/git.freedesktop.org/git/x

Re: Radeonhd repo not migrated to gitlab.

2019-03-07 Thread Daniel Stone
On Fri, 8 Mar 2019 at 04:35, Adam Jackson wrote: > On Wed, 2019-03-06 at 17:04 +0100, Luc Verhaegen wrote: > > Is there a reason why, of _all_ drivers listed in > > > > https://cgit.freedesktop.org/xorg/driver > > > > the Radeonhd repository at > > > >

Re: Maintainer / Owner privileges at xf86-video-vmware

2019-02-22 Thread Daniel Stone
Hi Thomas, On Fri, 22 Feb 2019 at 13:18, Thomas Hellstrom wrote: > I was trying to add Deepak Rawat as a member on the xf86-video-vmware > project on fdo gitlab. Turns out I have only developer privileges > there. Could someone please raise that to maintainer or owner? Bouncing this over to

Re: [Xcb] Migrating XCB to GitLab

2019-02-16 Thread Daniel Stone
Hi, On Sat, 16 Feb 2019 at 18:21, Josh Triplett wrote: > On February 16, 2019 6:03:36 AM PST, Daniel Stone > wrote: > >In doing the move, I think it makes sense to move the XCB modules in > >under the xorg/ tree. I've suggested a module map here: > >https://gitlab.fre

Migrating XCB to GitLab

2019-02-16 Thread Daniel Stone
Hi all, As has been pretty well documented, I'd like to migrate XCB to GitLab to join the rest of fd.o and X.Org (apart from the kernel and Mesa). Whilst cgit/anongit would remain as mirrors, they would be read-only; the sole push point would be GitLab. More details are here, but essentially you

Re: [RFC] Allow fd.o to join forces with X.Org

2018-10-29 Thread Daniel Stone
Hi, On Fri, 26 Oct 2018 at 11:57, Daniel Vetter wrote: > On Fri, Oct 26, 2018 at 10:13:51AM +1000, Peter Hutterer wrote: > > On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter wrote: > > > On Wed, Oct 17, 2018 at 2:05 PM Daniel Stone wrote: > > > > Yeah, I thi

Re: [RFC] Allow fd.o to join forces with X.Org

2018-10-29 Thread Daniel Stone
Hi, On Fri, 26 Oct 2018 at 11:57, Daniel Vetter wrote: > On Fri, Oct 26, 2018 at 10:13:51AM +1000, Peter Hutterer wrote: > > On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter wrote: > > > On Wed, Oct 17, 2018 at 2:05 PM Daniel Stone wrote: > > > > Yeah, I thi

Re: [RFC] Allow fd.o to join forces with X.Org

2018-10-17 Thread Daniel Stone
On Tue, 16 Oct 2018 at 08:17, Peter Hutterer wrote: > On Mon, Oct 15, 2018 at 10:49:24AM -0400, Harry Wentland wrote: > > + \item Support free and open source projects through the > > freedesktop.org > > + infrastructure. For projects outside the scope of item (\ref{1}) > > support > >

Re: [RFC] Allow fd.o to join forces with X.Org

2018-10-17 Thread Daniel Stone
On Tue, 16 Oct 2018 at 08:17, Peter Hutterer wrote: > On Mon, Oct 15, 2018 at 10:49:24AM -0400, Harry Wentland wrote: > > + \item Support free and open source projects through the > > freedesktop.org > > + infrastructure. For projects outside the scope of item (\ref{1}) > > support > >

Re: Smooth gdm -> GNOME3 session transition broken with 1.20 modesetting driver

2018-09-05 Thread Daniel Stone
Hi Hans, On Wed, 5 Sep 2018 at 19:23, Hans de Goede wrote: > Under Fedora 29 (xserver-1.20) the transition from GDM to > the GNOME3 session is no longer smooth, it seems that the > screen is cleared to black when the Xserver starts instead > of inheriting the framebuffer contents from GDM as

Re: [PATCH] xwayland: fix access to invalid pointer

2018-08-28 Thread Daniel Stone
imensions - you disconnect one of them - you want newly-connected legacy clients to get the correct DPI value through the connection handshake I'm finding that usecase hard to care enough about that to justify how ugly it is compared to this, so this patch is: Reviewed-by: Daniel Stone Cheers,

Re: Window scaling (aka owner sizes)

2018-08-27 Thread Daniel Stone
On Mon, 27 Aug 2018 at 19:19, Keith Packard wrote: > Daniel Stone writes: > > It's the other way around. Wayland only has surface-relative > > co-ordinates, so we take those and then translate them back into the > > X11 global co-ordinate space. > > Oh, so if we k

Re: Window scaling (aka owner sizes)

2018-08-27 Thread Daniel Stone
Hi, On Mon, 27 Aug 2018 at 18:45, Keith Packard wrote: > Robert Mader writes: > > I can post my WIP work (will have to clean it up and rebase to current > > master). > > That said, I'm very interested to see this go forward and am very > > willing to help :) > > I don't know how device

Re: [ANN] edid-decode maintenance info

2018-08-13 Thread Daniel Stone
Hi, On Sun, 12 Aug 2018 at 21:53, Alan Coopersmith wrote: > On 06/22/18 01:12 AM, Hans Verkuil wrote: > > Thank you for this information. I looked through all the bug reports and > > 100607, 100340 and 93366 were already fixed before I took over maintenance. > > > > I just fixed 89348 and 93777

Re: gitlab migration (including account update plans, please read)

2018-07-29 Thread Daniel Stone
Hi Alan, On Sun, 29 Jul 2018 at 16:53, Alan Coopersmith wrote: > On 07/29/18 03:07 AM, Daniel Stone wrote: > > This took a little longer than hoped, but all the repos have now been moved. > > Huge thanks for doing this. > > I updated all my local clones with: > > git

Re: gitlab migration (including account update plans, please read)

2018-07-29 Thread Daniel Stone
Hi, On Mon, 23 Jul 2018 at 16:24, Adam Jackson wrote: > My earlier assertion about the git url not being changed is only true > for pulls. For pushes, you will indeed need to update the remote to the > new URL: > > $ git remote set-url origin ssh://g...@gitlab.freedesktop.org/xorg/xserver > >

Re: [PATCH xserver] xf86-video-modesetting: Lease planes as well if using atomic

2018-06-27 Thread Daniel Stone
s to why we add ncrtc twice (for the primary plane). But, with that (and no need to pass it through the list again): Reviewed-by: Daniel Stone Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/x

Re: [PATCH xserver] xf86-video-modesetting: Don't enable UNIVERSAL_PLANES separately

2018-06-27 Thread Daniel Stone
atomic, then we > won't have selected a plane for each crtc, and this will break lease > creation which requires planes for each output when universal_planes > is enabled. Reviewed-by: Daniel Stone ___ xorg-devel@lists.x.org: X.Org development Arch

Re: [PATCH xserver v2 1/2] glamor: Unbreak glamor_fd_from_pixmap()

2018-06-21 Thread Daniel Stone
Hey Lyude, On Thu, 21 Jun 2018 at 00:13, Lyude Paul wrote: > -/* Pixmaps with multi-planes/modifier are not supported in this > interface */ > -if (ret != 1 || offsets[0] != 0) { > -while (ret > 0) > -close(fds[--ret]); > +ret = _glamor_fds_from_pixmap(screen,

Re: gitlab migration

2018-06-13 Thread Daniel Stone
Hi Felix, On Wed, 13 Jun 2018 at 10:24, Felix Miata wrote: > Daniel Stone composed on 2018-06-13 09:24 (UTC+0100): > > Felix Miata wrote: > >> James Cloos composed on 2018-06-12 17:38 (UTC-0400): > >> > BZ is superior to GL (or GH or the like). > > >>

Re: gitlab migration

2018-06-13 Thread Daniel Stone
Hi Felix, On Wed, 13 Jun 2018 at 04:17, Felix Miata wrote: > James Cloos composed on 2018-06-12 17:38 (UTC-0400): > > Two comments: > > > BZ is superior to GL (or GH or the like). > > Strongly agree, especially for returning useful search results!!! What kind of searches have you tried which

Re: gitlab migration

2018-06-13 Thread Daniel Stone
On Tue, 12 Jun 2018 at 22:36, James Cloos wrote: > >>>>> "DS" == Daniel Stone writes: > DS> No need to test; it's guaranteed to fail since we require Recaptcha > DS> for login due to massive spam issues. > > Which is of course grossly unethical a

Re: gitlab migration

2018-06-12 Thread Daniel Stone
Hi Alexander, On 12 June 2018 at 14:53, Alexander E. Patrakov wrote: > Daniel Stone : >> > That said, I could not even create an account with a noscript/xhtml basic >> > browser (if you want to test that, install the famous noscript module with >> > an >

Re: gitlab migration

2018-06-12 Thread Daniel Stone
Hi Sylvain, On 12 June 2018 at 13:38, wrote: > On Tue, Jun 12, 2018 at 12:34:31PM +0100, Daniel Stone wrote: >> GitLab has a pretty comprehensive and well-documented API which might >> help if you don't want to use a web browser. There are also clients >> like 'lab

Re: gitlab migration

2018-06-12 Thread Daniel Stone
Hi Michel, On 11 June 2018 at 11:33, Michel Dänzer wrote: > On 2018-06-08 08:08 PM, Adam Jackson wrote: >> I'd like us to start moving repos and bug tracking into gitlab. >> Hopefully everyone's aware that gitlab exists and why fdo projects are >> migrating to it. If not, the thread about Mesa's

Re: gitlab migration

2018-06-12 Thread Daniel Stone
Hi Sylvain, It looks like Mutt is mangling email addresses - I've fixed Michel's. On 11 June 2018 at 14:30, wrote: > On Mon, Jun 11, 2018 at 12:33:52PM +0200, Michel Dänzer wrote: >> Adding the amd-gfx list, in cases somebody there has concerns or other >> feedback. > > For feedback: > I

Re: gitlab migration

2018-06-11 Thread Daniel Stone
On 9 June 2018 at 00:11, Eric Anholt wrote: > Adam Jackson writes: >> I'd like us to start moving repos and bug tracking into gitlab. >> Hopefully everyone's aware that gitlab exists and why fdo projects are >> migrating to it. If not, the thread about Mesa's migration provides >> some useful

Re: [PATCH xserver] glamor: Enable modifier support for xfree86 too

2018-06-07 Thread Daniel Stone
On 6 June 2018 at 20:56, Adam Jackson wrote: > This was left disabled in 1.20.0, it's time to start being sure it > works. > > Signed-off-by: Adam Jackson Acked-by: Daniel Stone ___ xorg-devel@lists.x.org: X.Org development Ar

Re: [PATCH xkbcomp] Ignore xkb_keycodes.maximum of > 255

2018-06-07 Thread Daniel Stone
f > 255. This doesn't set the "high_keycode_warned" on purpose so we get this for > the first key that actually matters. Reviewed-by: Daniel Stone ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel I

Re: Obtaining Xorg DDX commit privilege

2018-06-06 Thread Daniel Stone
Hi Kevin, On 5 June 2018 at 23:37, Kevin Brace wrote: > I did ask freedesktop.org to grant me commit privilege to xf86-video-* DDX > repositories, but I have yet to hear from them. > > https://bugs.freedesktop.org/show_bug.cgi?id=106605 For accounts, freedesktop.org are just a very low-value

Re: Stepping back

2018-05-15 Thread Daniel Stone
Hi, On 15 May 2018 at 06:43, Alan Coopersmith wrote: > On 05/14/18 12:58 PM, Keith Packard wrote: >> Adam Jackson writes: >>> tl;dr: I will not be release manager for 1.21, nor for anything >>> thereafter either, and this time that's probably

Re: [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Daniel Stone
On 5 May 2018 at 10:15, Mike Lothian wrote: > Out of interest can you try running the vulkan smoketest, I'm seeing this: > > smoketest > terminate called after throwing an instance of 'std::runtime_error' > what(): VkResult -101004 returned > Aborted (core dumped)

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

2018-05-04 Thread Daniel Stone
Hi Mario, On 4 May 2018 at 13:14, Mario Kleiner wrote: > Indeed, i found a Mesa bug yesterday which can cause Mesa's > PresentPixmap request to spuriously feed garbage targetMSC's > into the driver under some conditions. However, while other > video drivers seem to

Re: [PATCH xserver] xwayland: Avoid using epoxy_has_egl()

2018-05-01 Thread Daniel Stone
On 30 April 2018 at 19:10, Adam Jackson <a...@redhat.com> wrote: > There's no real point - if we don't have EGL then the extension check is > also going to fail - and the entrypoint is new in 1.5.0, which we don't > need to require yet. Reviewed-by: Daniel Stone <dan

[PATCH xserver] dri3: Don't call vfuncs on old DRI3 screens

2018-04-24 Thread Daniel Stone
Only call the get_supported_modifiers vfunc if the DRI3 screen struct is sufficiently new. Signed-off-by: Daniel Stone <dani...@collabora.com> --- dri3/dri3_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri3/dri3_screen.c b/dri3/dri3_screen.c index 23e

Re: [PATCH xserver] dri3: Clamp to 1.0 if not all screens support 1.2

2018-04-24 Thread Daniel Stone
v1.2 for, e.g., UDL? I've sent another one I just spotted by inspection, but this is: Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] dri3: Fix DRI3.2 support for drivers other than modesetting-ddx.

2018-04-24 Thread Daniel Stone
Hi Adam, On 24 April 2018 at 20:52, Adam Jackson <a...@nwnk.net> wrote: > On Tue, 2018-04-24 at 11:42 +0100, Daniel Stone wrote: >> On 24 April 2018 at 09:17, Mario Kleiner <mario.kleiner...@gmail.com> wrote: >> > Both xf86-video-intel and xf86-video-nouveau cause Op

Re: [PATCH xserver] dri3: Fix DRI3.2 support for drivers other than modesetting-ddx.

2018-04-24 Thread Daniel Stone
Hi Mario, On 24 April 2018 at 09:17, Mario Kleiner wrote: > Both xf86-video-intel and xf86-video-nouveau cause OpenGL > clients to fail when used with DRI3 on server 1.20 with Mesa 18.1. > > Reason is that the servers DRI3 version is now unconditionally > reported as

Re: [PATCH xserver 3/3] xwayland: Add glamor egl_backend for EGLStreams

2018-04-24 Thread Daniel Stone
it as unpleasant as the commit message details, but I'm not sure how you'd do it better, and it is at least minimally intrusive to the rest. Acked-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development A

Re: [PATCH xserver 2/3] xwayland: Add xwayland-config.h

2018-04-24 Thread Daniel Stone
On 20 April 2018 at 19:38, Adam Jackson <a...@redhat.com> wrote: > Just a small autogenerated header that will soon contain more then just > one macro. > > Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by: Daniel Ston

Re: [PATCH xserver 1/3] xwayland: Decouple GBM from glamor

2018-04-24 Thread Daniel Stone
ere, the change to expecting_event is unnecessary; the previous code explicitly decremented and re-incremented to make it clear which event was which, and the change meant I had to double back and read through the whole init flow again. The current code is still

Re: [PATCH xserver v2] xwayland: avoid using freed xwl_window on unrealize

2018-04-19 Thread Daniel Stone
Hi, On 19 April 2018 at 16:05, Olivier Fourdan wrote: > (gdb) f 9 > #9 xwl_present_frame_callback (data=0x184cb10, callback=, > time=) at xwayland-present.c:192 > 192wl_callback_destroy(xwl_window->present_frame_callback); > (gdb) list > 187 struct

Re: [PATCH xserver 15/15] dri3: correctly handle failed get_supported_modifiers requests

2018-04-06 Thread Daniel Stone
Hi, On 6 April 2018 at 12:18, Emil Velikov wrote: > On 4 April 2018 at 19:51, Adam Jackson wrote: >> This, combined with 10/15, means you will now throw BadImplementation >> when we used to succeed and simply report no modifiers. I can't think >> of a

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-06 Thread Daniel Stone
Hi, On 6 April 2018 at 09:48, Mike Lothian wrote: > Thanks for reminding me about GLX vs EGL > > The config option in KDE was removed from the System Setting app and can > only be adjusted manually in in ~/.config/kwinrc > > GLPlatformInterface=egl > > This might explain why

[PATCH xserver v3 3/3] modesetting: Actually get framebuffer ID

2018-04-05 Thread Daniel Stone
We would fail to get the FB ID if it wasn't already imported, since we were checking to see if the pointer was NULL (it never was) rather than if the content of the pointer was 0. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Olivier Fourdan <ofour...@redhat.com

[PATCH xserver v3 1/3] modesetting: Don't reuse iterator in nested loop

2018-04-05 Thread Daniel Stone
drmmode_crtc_set_mode has a loop nested inside another loop, where both of them were using 'i' as the loop iterator. Rename it to avoid an infinite loop. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Michel Dänzer

[PATCH xserver v3 2/3] dri3: Set stride and size for old clients

2018-04-05 Thread Daniel Stone
For old clients using the fd_from_pixmap entrypoint, make sure we set stride and size correctly. Noticed by inspection. Signed-off-by: Daniel Stone <dani...@collabora.com> --- dri3/dri3_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dri3/dri3_screen.c b/dri3/dri3_screen.c

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

2018-04-05 Thread Daniel Stone
On 5 April 2018 at 15:06, Walter Harms <wha...@bfs.de> wrote: >> Daniel Stone <dani...@collabora.com> hat am 5. April 2018 um 15:58 >> geschrieben: >> -for (i = 0; i < xf86_config->num_output; i++) { >> -xf

[PATCH xserver v2 2/2] dri3: Set stride and size for old clients

2018-04-05 Thread Daniel Stone
For old clients using the fd_from_pixmap entrypoint, make sure we set stride and size correctly. Noticed by inspection. Signed-off-by: Daniel Stone <dani...@collabora.com> --- dri3/dri3_screen.c | 2 ++ 1 file changed, 2 insertions(+) Sorry, accidentally sent the previous without

[PATCH xserver 2/2] dri3: Set stride and size for old clients

2018-04-05 Thread Daniel Stone
For old clients using the fd_from_pixmap entrypoint, make sure we set stride and size correctly. Noticed by inspection. Signed-off-by: Daniel Stone <dani...@collabora.com> --- dri3/dri3_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dri3/dri3_screen.c b/dri3/dri3_screen.c

[PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

2018-04-05 Thread Daniel Stone
drmmode_crtc_set_mode has a loop nested inside another loop, where both of them were using 'i' as the loop iterator. Rename it to avoid an infinite loop. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Michel Dänzer <michel.daen...@amd.com> --- hw/xfree86/drivers

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

2018-04-05 Thread Daniel Stone
Hi Mike, On 5 April 2018 at 09:03, Mike Lothian wrote: > I got different behavior with modesetting and the intel ddx I can try with the Intel DDX later on today. > Both didn't render anything, but I think one was crashing over and > over (I think systemd kept restarting it

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

2018-04-05 Thread Daniel Stone
Hi Mike, On 5 April 2018 at 07:10, Mike Lothian wrote: > I've just tested with those patches, it still doesn't work without that revert > > If you're testing this on kwin can you make sure you're using one of > the OpenGL options on the renderer rather than XRender I'm

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-04 Thread Daniel Stone
Hi Mario, On 4 April 2018 at 17:40, Mario Kleiner <mario.kleiner...@gmail.com> wrote: > On Wed, Apr 4, 2018 at 6:19 PM, Daniel Stone <dan...@fooishbar.org> wrote: >> Ugh. I've applied your pageflip patch, lfrb's two-patch atomic fix >> series and my fix-old-clients ser

Re: [PATCH xserver 1/2] modesetting: Use atomic modesetting to set DPMS mode

2018-04-04 Thread Daniel Stone
parate the code motion from the changes, into more granular commits than this. I found this a bit hard to review without referring back to both old and new versions constantly as I went. Regardless, this series is: Tested-by: Daniel Stone <dani...@collabora.co

Re: [PATCH xserver] modesetting: Fix page flipping harder under DRI 3.2.

2018-04-04 Thread Daniel Stone
sted on NV-96 for nouveau, HD-5770 for radeon, Intel Ivybridge > with Linux 4.13 and drm-next to fix page flipping. Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: htt

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-04 Thread Daniel Stone
Hi Mario, On 4 April 2018 at 06:22, Mario Kleiner wrote: > Ok, so it's probably a mesa bug in the egl dri3 backend caused by the > new DRI3.1 multibuffers support. > > If on current mesa master, in egl_dri2.c:dri2_setup_extensions(), i > force

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

2018-04-04 Thread Daniel Stone
Hi Mike, On 4 April 2018 at 09:12, Mike Lothian wrote: > Kwin doesn't seem to start with the following commit: > > commit abb9b58d1af9a0286162e52ef9db390d0c950fc1 > Author: Thierry Reding > Date: Fri Mar 16 14:24:21 2018 +0100 > > present:

[PATCH xserver 5/7] glamor: Reallocate pixmap storage without modifiers if necessary

2018-04-04 Thread Daniel Stone
modifiers from modifier-aware GBM/EGL/KMS. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Adam Jackson <a...@redhat.com> --- glamor/glamor_egl.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c ind

[PATCH xserver 6/7] glamor: Fall back to non-modifier allocations

2018-04-04 Thread Daniel Stone
If we try to allocate with particular modifiers but it fails, try to fall back to non-modifier allocations. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Adam Jackson <a...@redhat.com> --- glamor/glamor_egl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deleti

[PATCH xserver 7/7] glamor: Add fd_from_pixmap hook

2018-04-04 Thread Daniel Stone
internal buffer storage using exotic modifiers from modifier-aware GBM/EGL/KMS. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Adam Jackson <a...@redhat.com> --- glamor/glamor_egl.c | 27 +++ 1 file changed, 27 insertions(+) diff --

[PATCH xserver 4/7] glamor: Push make_exportable into callers

2018-04-04 Thread Daniel Stone
-by: Daniel Stone <dani...@collabora.com> Reported-by: Adam Jackson <a...@redhat.com> --- glamor/glamor_egl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 0e771b6d2..dd6a9a2df 100644 --- a/glamor/glamor_egl.c

[PATCH xserver 3/7] glamor: Track if BO allocation used modifiers

2018-04-04 Thread Daniel Stone
a compositing manager on an old GLX/EGL stack on top of an X server which allocates internal buffer storage using exotic modifiers from modifier-aware GBM/EGL/KMS. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Adam Jackson <a...@redhat.com> --- gla

[PATCH xserver 2/7] drmmode: Track if BO allocation used modifiers

2018-04-04 Thread Daniel Stone
a compositing manager on an old GLX/EGL stack on top of an X server which allocates internal buffer storage using exotic modifiers from modifier-aware GBM/EGL/KMS. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Adam Jackson <a...@redhat.com> --- hw/xfree86/drivers

[PATCH xserver 0/7] Fix modifier server / non-mod client

2018-04-04 Thread Daniel Stone
Hi, This series fixes running a modifier-aware server with a non-modifier-aware DRI3 compositing manager. We'd thought of and dealt with the case where we had legacy/non-modifier-aware clients, but slipped up with non-modifier-aware compositing managers. Glamor would allocate pixmaps with the

[PATCH xserver 1/7] dri3: Use single-FD screen call for single-FD request

2018-04-04 Thread Daniel Stone
exotic modifiers from modifier-aware GBM/EGL/KMS. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Adam Jackson <a...@redhat.com> --- dri3/dri3_priv.h| 3 +++ dri3/dri3_request.c | 16 +--- dri3/dri3_screen.c | 40 +

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-03 Thread Daniel Stone
On 3 April 2018 at 16:36, Mario Kleiner wrote: > Btw. another new problem, which i haven't had time to track down at > all is that desktop composition under EGL seems to be totally broken. > Tested on KUbuntu 16.0.4 LTS with xserver master + mesa master last > thursday

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-04-03 Thread Daniel Stone
Hi Mario, On 3 April 2018 at 15:44, Mario Kleiner wrote: > Those are fine according to my testing, they fix mode-setting under > both depth24 and 30. > > However as testing shows, still not sufficient for pageflipping if the > kms driver doesn't support full atomic

Re: [PATCH xserver] modesetting: Fix up some XXX from removing GLAMOR_HAS_DRM_*

2018-03-29 Thread Daniel Stone
Hi Mario, On 29 March 2018 at 00:47, Mario Kleiner wrote: > On Thu, Mar 22, 2018 at 7:47 PM, Adam Jackson wrote: >> @@ -2244,18 +2247,19 @@ drmmode_output_dpms(xf86OutputPtr output, int mode) >> { >> drmmode_output_private_ptr drmmode_output =

Re: [PATCH xserver] modesettings: Use actual crtc position for pageflip

2018-03-29 Thread Daniel Stone
On 29 March 2018 at 08:42, Olivier Fourdan <ofour...@redhat.com> wrote: > Otherwise the same content is shown on all outputs. Yeah, good point. Reviewed-by: Daniel Stone <dani...@collabora.comm> ___ xorg-devel@lists.x.org: X.Org devel

Re: [PATCH xserver 2/2] modesetting: Fix reported size when using atomic modesetting

2018-03-29 Thread Daniel Stone
t also requires https://patchwork.freedesktop.org/series/40860/ and > with this, this patch is: > > Tested-by: Olivier Fourdan <ofour...@redhat.com> > Reviewed-by: Olivier Fourdan <ofour...@redhat.com> Reviewed-by: Daniel Stone <dani...@collabora.com> __

Re: [PATCH xserver 1/2] modesetting: Ignore alpha channel when importing BOs for modesetting

2018-03-29 Thread Daniel Stone
On 29 March 2018 at 08:43, Olivier Fourdan <ofour...@redhat.com> wrote: > Looks good to me. > > Tested-by: Olivier Fourdan <ofour...@redhat.com> > Reviewed-by: Olivier Fourdan <ofour...@redhat.com> And to me: Reviewed-by: Danie

Re: [PATCH xserver 3/3] modesetting/drmmode: Use drmModeGetFB2

2018-03-27 Thread Daniel Stone
Hi Emil, On 26 March 2018 at 16:22, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 23 March 2018 at 13:50, Daniel Stone <dani...@collabora.com> wrote: >> Much like AddFB -> AddFB2, GetFB2 lets us get multiple buffers back as >> well as modifier information. Thi

Re: [PATCH xserver 2/3] modesetting/drmmode: Use glamor_pixmap_from_fds

2018-03-27 Thread Daniel Stone
Hi, On 26 March 2018 at 16:11, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 23 March 2018 at 13:50, Daniel Stone <dani...@collabora.com> wrote: >> +for (i = 0; i < 4 && handles[i]; i++) { >> +err = drmPrimeHandleToFD(drmm

[PATCH xserver 2/3] modesetting/drmmode: Use glamor_pixmap_from_fds

2018-03-23 Thread Daniel Stone
. Signed-off-by: Daniel Stone <dani...@collabora.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 52 +++- 1 file changed, 42 insertions(+), 10 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/drivers/modesetting/drmmode_dis

[PATCH xserver 0/3] Use DRM GetFB2 ioctl

2018-03-23 Thread Daniel Stone
Hi, This short patchset makes modesetting use the shiny, new, and completely not at all merged GetFB2 DRM ioctl: https://lists.freedesktop.org/archives/dri-devel/2018-March/170512.html When starting Xorg with -background none, it uses GetFB to interrogate the current framebuffer, importing it

[PATCH xserver 1/3] modesetting/drmmode: Remove unused flink call

2018-03-23 Thread Daniel Stone
We don't use flink in the GetFB import path anymore, as we do an FD-based import instead. Signed-off-by: Daniel Stone <dani...@collabora.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/xfree86/drivers/modes

[PATCH xserver 3/3] modesetting/drmmode: Use drmModeGetFB2

2018-03-23 Thread Daniel Stone
Much like AddFB -> AddFB2, GetFB2 lets us get multiple buffers back as well as modifier information. This lets us use -background none with multiplanar formats, or modifiers which can't be inferred via a magic side channel. Signed-off-by: Daniel Stone <dani...@collabora.com> --- h

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-12 Thread Daniel Stone
time machine, that would probably be the first thing I would change about the modifiers API. Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-

Re: [PATCH xserver] glamor/xwayland: Add depth 30 format mapping for DRI 3.2 as well.

2018-03-09 Thread Daniel Stone
On 9 March 2018 at 03:58, Mario Kleiner <mario.kleiner...@gmail.com> wrote: > Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Daniel Stone <dani...@collabora.com> ___ xorg-devel@lists.x.org: X.Org devel

Re: [PATCH xserver] glamor: Restore glamor_fd_from_pixmap and glamor_pixmap_from_fd

2018-03-06 Thread Daniel Stone
stride, depth, bpp); > + > +if (ret == FALSE) { > +screen->DestroyPixmap(pixmap); > +return NULL; > +} > +return pixmap; > +} Any reason to not make this just 'return glamor_pixmap_from_fds(screen, 1, , width, height, , &{

[ANNOUNCE] libxcb 1.13

2018-03-05 Thread Daniel Stone
@param names in manually written headers Correct @param "e" to "error" in xcb_poll_for_reply*() Christian Linhart (4): move symbol lookup of sumof expr to the parser optionally build the GE extension add support for eventstruct enable xinput by defa

[ANNOUNCE] xcb-proto 1.13

2018-03-05 Thread Daniel Stone
event. Christian Linhart (5): move symboltable lookup of sumof expr to the parser xinput: typedef for event_type_base add support for eventstruct SendExtensionEvent uses eventstruct xinput: remove TODO that is done Daniel Stone (2): xcbgen: Add support for lists

Re: [PATCH xserver] xkb: XkbSetMap on the lastSlave needs to change the master

2018-03-05 Thread Daniel Stone
it was also a bad choice. Acked-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH v8 00/14] DRI3 multi-plane and modifier support

2018-02-27 Thread Daniel Stone
Hi, On 28 February 2018 at 01:19, Daniel Stone <dani...@collabora.com> wrote: > The major change is that the DRI3 protocol version has been bumped from > 1.1 to 1.2, as there was previously a dri3proto-1.1 release, only > carrying a 1.0 protocol version. We bump the v

[PATCH xorgproto v8 01/14] dri3: Add modifier/multi-plane requests, bump to v1.2

2018-02-27 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne <l...@collabora.com> DRI3 version 1.2 adds support for explicit format modifiers, including multi-planar buffers. Signed-off-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Louis-Francis Ratté-Boulianne <l...@collabora.com> --

[PATCH xserver v8 08/14] modesetting: Get supported formats/modifiers for scanout

2018-02-27 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne <l...@collabora.com> Retrieve IN_FORMATS property from the plane. It gives the allowed formats and modifiers for BO allocation. Signed-off-by: Louis-Francis Ratté-Boulianne <l...@collabora.com> Reviewed-by: Daniel Stone <dani..

  1   2   3   4   5   6   7   8   9   10   >