[PATCH keyboard] Removing unused SetKbdRepeat

2011-01-06 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/bsd_kbd.c | 20 src/hurd_kbd.c |7 --- src/sun_kbd.c |8 src/xf86OSKbd.h |2 -- 4 files changed, 0 insertions(+), 37 deletions(-) diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c

[PATCH keyboard] Fix default options for PC98

2011-01-06 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/kbd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index 629b534..2dac655 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -190,7 +190,7 @@ KbdPreInit(InputDriverPtr drv, InputInfoPtr

[PATCH keyboard] bsd: Fix print wscons type keyboard for Sun5

2011-01-06 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/bsd_kbd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c index d0cedcd..ebaeae5 100644 --- a/src/bsd_kbd.c +++ b/src/bsd_kbd.c @@ -413,9 +413,9 @@

[PATCH] EXA: Pad size of system memory copy for 1x1 pixmaps (bug #32803).

2011-01-06 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Fixes https://bugs.freedesktop.org/show_bug.cgi?id=32803 . Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_mixed.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exa/exa_mixed.c b/exa/exa_mixed.c index

Re: [PATCH] EXA: Pad size of system memory copy for 1x1 pixmaps (bug #32803).

2011-01-06 Thread Dave Airlie
2011/1/6 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer daen...@vmware.com Fixes https://bugs.freedesktop.org/show_bug.cgi?id=32803 . Signed-off-by: Michel Dänzer daen...@vmware.com Reviewed-by: Dave Airlie airl...@redhat.com ---  exa/exa_mixed.c |    2 +-  1 files changed, 1

Re: [PATCH] include: purge foo(int /*bar*/) function declarations.

2011-01-06 Thread Mark Kettenis
Date: Thu, 6 Jan 2011 14:29:59 +1000 From: Peter Hutterer peter.hutte...@who-t.net because, really, comments should be for comments. Not sure this is a good idea, at least not in public headers. The problem is that if you have extern void foo(int bar); and for some reason bar is #defined

Re: [PATCH] include: purge foo(int /*bar*/) function declarations.

2011-01-06 Thread Thomas Dickey
On Thu, 6 Jan 2011, Mark Kettenis wrote: Date: Thu, 6 Jan 2011 14:29:59 +1000 From: Peter Hutterer peter.hutte...@who-t.net because, really, comments should be for comments. Not sure this is a good idea, at least not in public headers. Agree. Code submissions on this list are

Re: [PATCH] include: purge foo(int /*bar*/) function declarations.

2011-01-06 Thread Peter Hutterer
On 6/01/11 19:25 , Mark Kettenis wrote: Date: Thu, 6 Jan 2011 14:29:59 +1000 From: Peter Huttererpeter.hutte...@who-t.net because, really, comments should be for comments. Not sure this is a good idea, at least not in public headers. note that we're not talking about about libX11 headers

Re: [PATCH] input: add valuator_mask_free() to free a valuator mask.

2011-01-06 Thread Chase Douglas
On 01/05/2011 11:34 PM, Peter Hutterer wrote: On Wed, Jan 05, 2011 at 11:00:33PM -0500, Chase Douglas wrote: On 01/05/2011 10:12 PM, Peter Hutterer wrote: Expecting the caller to free the mask requires us to keep it in a single memory block (which may be an issue lateron), aside from leaving

Re: [PATCH xserver 05/17] Test: Input: Test up to supported server, not protocol, events

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:57 PM, Daniel Stone wrote: When building against a newer inputproto, the server may support fewer than XI_LASTEVENT events. We already have XI2LASTEVENT for the highest event number supported by the server, so use that instead. Signed-off-by: Daniel Stone

Re: [PATCH xserver 06/17] Input: Export SpriteRec for use in public API

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:57 PM, Daniel Stone wrote: Change its definition to be more in line with other structs, so we can use it from input.h. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Chase Douglas chase.doug...@canonical.com ___

Re: [PATCH xserver 07/17] Input: Make RootWindow() take a sprite instead of device

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:57 PM, Daniel Stone wrote: GetCurrentRootWindow already works for the device case, although not as an lvalue. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Chase Douglas chase.doug...@canonical.com ___

Re: [PATCH] include: purge foo(int /*bar*/) function declarations.

2011-01-06 Thread Alan Coopersmith
On 01/ 6/11 01:25 AM, Mark Kettenis wrote: extern void foo(int class); which won't compile if you include the header file from C++. The subset of these that Xorg exports to loadable modules like drivers are already incompatible with C++ (note the lack of extern C {} wrappers). --

Re: [PATCH xserver 08/17] Input: Pass sprite instead of device to FixUpEventFromWindow

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:57 PM, Daniel Stone wrote: Since FixUpEventFromWindow only uses the sprite trace to determine the window stack, pass in a sprite instead of hardcoding the device sprite, so we can deliver to windows other than the one currently containing the sprite. Signed-off-by: Daniel

[PATCH modular 1/2] build.sh: use meaningful names for parameter variables

2011-01-06 Thread Gaetan Nadon
This makes it easier to review code diff. Reported-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Gaetan Nadon mems...@videotron.ca --- build.sh | 122 +++--- 1 files changed, 69 insertions(+), 53 deletions(-) diff --git

[PATCH modular 2/2] build.sh: remove *) empty fallback case

2011-01-06 Thread Gaetan Nadon
That makes it consistent in the script Signed-off-by: Gaetan Nadon mems...@videotron.ca --- build.sh | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/build.sh b/build.sh index 4d7b3ee..de96a47 100755 --- a/build.sh +++ b/build.sh @@ -548,8 +548,6 @@

Re: [PATCH] Include ShmGetImage tests for x11perf

2011-01-06 Thread Adam Jackson
On Thu, 2011-01-06 at 13:25 +, Chris Wilson wrote: I noticed that there were no corresponding tests for ShmGetImage to attempt to measure the performance of readback without the overhead of pushing those pixels over the wire. This adds a test based on GetImage, but it has a bug where the

Re: [PATCH] ClickPad support v4

2011-01-06 Thread Chris Bagwell
On Wed, Jan 5, 2011 at 9:20 PM, AIC a...@hi.t-com.hr wrote: Kevin O'Connor ke...@... writes: Setting AreaBottomEdge=3800 did make the mouse jitter on button press go away (at the cost of a smaller touchpad area).  (Of course, this would still need to work once left/right/middle button

[PATCH modular 3/3] build.sh: rebuild a failing target with Automake silent rules disabled

2011-01-06 Thread Gaetan Nadon
With Automake silent rules enabled, the compiler error message is displayed but not the command that caused it. This patch will re-issue the make command that failed, but this time with the V=1 alongside the MAKEFLAGS env variable. A message is issued to not confuse the user as to why the target

Re: [PATCH inputproto] Add touch classes and events, bump to 2.1

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:58 PM, Daniel Stone wrote: Introduce multitouch support through a new TouchClass, as well as new TouchBegin, TouchEnd and TouchMotion events. Bump to version 2.1. Looks good! I have a few comments below, a couple that I want to resolve before adding my reviewed-by tag.

Re: [PATCH xserver 10/17] Input: Handle grabs with no Xi 1.x equivalent

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:58 PM, Daniel Stone wrote: Don't try to search for an Xi 1.x grab in CheckPassiveGrabsOnWindow for events with no Xi 1.x equivalent. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Chase Douglas chase.doug...@canonical.com

Re: [PATCH xserver 11/17] Input: Export GetEventMask

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:58 PM, Daniel Stone wrote: Make it non-static, add to headers. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Chase Douglas chase.doug...@canonical.com ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 12/17] Input: Make CheckPassiveGrabsOnWindow return grab, export

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:58 PM, Daniel Stone wrote: Change CheckPassiveGrabsOnWindow to return the GrabPtr it used (or NULL if none) rather than a boolean, and export it. Also add an additional boolean 'activate' parameter; use TRUE for existing behaviour, or FALSE to only find the grab and then

Re: [PATCH xserver 13/17] Input: Bump input major ABI for multitouch

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:58 PM, Daniel Stone wrote: Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Chase Douglas chase.doug...@canonical.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH xserver 15/17] Input: Add flags to DeviceEvent

2011-01-06 Thread Chase Douglas
On 12/28/2010 12:58 PM, Daniel Stone wrote: Add a flags member which will be copied wholesale into the resultant xXIDeviceEvent. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Chase Douglas chase.doug...@canonical.com ___

Re: [PATCH xserver 16/17] Input: Add initial multitouch support from Xi 2.1

2011-01-06 Thread Daniel Stone
Hi, On Thu, Jan 06, 2011 at 10:18:00AM +1000, Peter Hutterer wrote: On Tue, Dec 28, 2010 at 05:58:07PM +, Daniel Stone wrote: Xi 2.1 adds TouchClasses to devices, as well as TouchBegin, TouchMotion and TouchEnd events, to allow support for multiple touchpoints on a single device.

Re: [PATCH] EXA: Pad size of system memory copy for 1x1 pixmaps (bug #32803).

2011-01-06 Thread Michel Dänzer
On Don, 2011-01-06 at 08:38 -0800, Keith Packard wrote: Merged. f348028..6358a60 master - master Thanks Keith. This is a candidate for the 1.9 (and 1.8) branch. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast |

Re: [PATCH modular 2/2] build.sh: remove *) empty fallback case

2011-01-06 Thread Dan Nicholson
On Thu, Jan 6, 2011 at 7:37 AM, Gaetan Nadon mems...@videotron.ca wrote: That makes it consistent in the script Signed-off-by: Gaetan Nadon mems...@videotron.ca Reviewed-by: Dan Nicholson dbn.li...@gmail.com ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xserver 16/17] Input: Add initial multitouch support from Xi 2.1

2011-01-06 Thread Chase Douglas
On 01/06/2011 12:57 PM, Daniel Stone wrote: On Thu, Jan 06, 2011 at 10:18:00AM +1000, Peter Hutterer wrote: On Tue, Dec 28, 2010 at 05:58:07PM +, Daniel Stone wrote: +typedef struct _TouchClassRec { +TouchAxisInfoPtr axes; +unsigned shortnum_axes; +

Re: [PATCH] EXA: Pad size of system memory copy for 1x1 pixmaps (bug #32803).

2011-01-06 Thread Jeremy Huddleston
On Jan 6, 2011, at 10:46, Michel Dänzer wrote: On Don, 2011-01-06 at 08:38 -0800, Keith Packard wrote: Merged. f348028..6358a60 master - master Thanks Keith. This is a candidate for the 1.9 (and 1.8) branch. 93b75c7..a3c7b86 server-1.9-branch - server-1.9-branch

[PULL] Cursor confinement ABI

2011-01-06 Thread Adam Jackson
Apologies for no r-b on the list, but: 17:53 daniels ajax: v2 gets my rb 17:56 daniels (not near email atm) --- The following changes since commit 6358a60065eef167d4e5f4afd981ff26deeba80d: EXA: Pad size of system memory copy for 1x1 pixmaps (bug #32803). (2011-01-06 08:37:27 -0800) are

Re: [PATCH xserver 16/17] Input: Add initial multitouch support from Xi 2.1

2011-01-06 Thread Chase Douglas
On 01/06/2011 02:30 PM, Chase Douglas wrote: 2. This is missing the previously discussed ability to request that the server buffer touch events until the client becomes the owner of the events. My proposal is to rename XIAllowTouchEvents to XIModifyTouchEventDelivery, and have it handle touch

Re: [PATCH:xrdb 2/3] Replace complex malloc calculations with asprintf()

2011-01-06 Thread Alan Coopersmith
On 01/ 5/11 05:32 PM, Guillem Jover wrote: This will make the return value be 1 less than written. And len should be checked here too, in case this call failed, which could happen due to memory exhaustion for example (depending on the implementation). Though in the specific case of xrdb, the

[PATCH:xrdb 2/3 v2] Replace complex malloc calculations with asprintf()

2011-01-06 Thread Alan Coopersmith
Includes simple local implemenation of asprintf if configure doesn't find one in system libraries. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Julien Cristau jcris...@debian.org --- Modified to fix issues raised during review by Guillem Jover configure.ac |3 +-

[PATCH 0/3] Fedora hack merge

2011-01-06 Thread Adam Jackson
A collection of things I've been carrying too long in Fedora. Should be uncontroversial though, I'm just tired of rebasing them. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH 1/3] os: Add -displayfd option.

2011-01-06 Thread Adam Jackson
This option specifies a file descriptor in the launching process. X will scan for an available display number and write that number back to the launching process, at the same time as SIGUSR1 generation. This means display managers don't need to guess at available display numbers. As a

[PATCH 2/3] xfree86: If the driver found modes on an output, don't add more

2011-01-06 Thread Adam Jackson
Inferring modes from sync ranges is only valid if the monitor says it's valid. If the monitor says it's valid, then we'll have already added those modes during EDID block parse. If it doesn't, then we should believe it. If there's no EDID for an output, but sync ranges from the config, we'll

[PATCH 3/3] xfree86: Fix the sdk headers to be multilib-safe

2011-01-06 Thread Adam Jackson
Use _LP64 (verified on gcc and sun compilers) instead of _XSERVER64 in internal header usage, and always define _XSERVER64 for modules if _LP64 is defined. Prevents differing xorg-server.h between 32 and 64 bit packages. Signed-off-by: Adam Jackson a...@redhat.com --- include/colormapst.h |

Re: [PATCH 3/3] xfree86: Fix the sdk headers to be multilib-safe

2011-01-06 Thread Alan Coopersmith
On 01/ 6/11 02:29 PM, Adam Jackson wrote: Use _LP64 (verified on gcc and sun compilers) instead of _XSERVER64 in internal header usage, and always define _XSERVER64 for modules if _LP64 is defined. Prevents differing xorg-server.h between 32 and 64 bit packages. diff --git

Re: [PATCH 2/3] xfree86: If the driver found modes on an output, don't add more

2011-01-06 Thread Alex Deucher
On Thu, Jan 6, 2011 at 5:29 PM, Adam Jackson a...@redhat.com wrote: Inferring modes from sync ranges is only valid if the monitor says it's valid.  If the monitor says it's valid, then we'll have already added those modes during EDID block parse.  If it doesn't, then we should believe it. If

Re: [PATCH xserver 16/17] Input: Add initial multitouch support from Xi 2.1

2011-01-06 Thread Peter Hutterer
On Thu, Jan 06, 2011 at 02:32:30PM -0500, Chase Douglas wrote: On 01/06/2011 12:57 PM, Daniel Stone wrote: On Thu, Jan 06, 2011 at 10:18:00AM +1000, Peter Hutterer wrote: On Tue, Dec 28, 2010 at 05:58:07PM +, Daniel Stone wrote: +typedef struct _TouchClassRec { +TouchAxisInfoPtr

[PULL 1.9] xfree86(ish) updates

2011-01-06 Thread Adam Jackson
Not entirely xf86 ddx, but all things that hardware server users can hit. --- The following changes since commit a3c7b86472aed80cf16edcfe2b77a92d4f3d196f: EXA: Pad size of system memory copy for 1x1 pixmaps (bug #32803). (2011-01-06 11:58:00 -0800) are available in the git repository at:

Re: [PATCH xserver 16/17] Input: Add initial multitouch support from Xi 2.1

2011-01-06 Thread Peter Hutterer
On Thu, Jan 06, 2011 at 05:57:45PM +, Daniel Stone wrote: /** + * Ensure a window trace is present in ti-sprite, constructing one for + * TouchBegin events. + */ +static Bool +EnsureTouchSprite(DeviceIntPtr sourcedev, TouchPointInfoPtr ti, DeviceEvent *ev) +{ +

Re: [PATCH 1/3] os: Add -displayfd option.

2011-01-06 Thread Alan Coopersmith
On 01/ 6/11 02:28 PM, Adam Jackson wrote: This option specifies a file descriptor in the launching process. X will scan for an available display number and write that number back to the launching process, at the same time as SIGUSR1 generation. This means display managers don't need to guess

Re: [PATCH:xrdb 2/3] Replace complex malloc calculations with asprintf()

2011-01-06 Thread Guillem Jover
On Thu, 2011-01-06 at 14:24:15 -0800, Alan Coopersmith wrote: On 01/ 5/11 05:32 PM, Guillem Jover wrote: This will make the return value be 1 less than written. And len should be checked here too, in case this call failed, which could happen due to memory exhaustion for example (depending

[PATCH:xrdb 2/2 v3] Replace complex malloc calculations with asprintf()

2011-01-06 Thread Alan Coopersmith
Includes simple local implemenation of asprintf if configure doesn't find one in system libraries. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Julien Cristau jcris...@debian.org --- This time after actually remembering to commit the changes promised in v2.

Re: [PATCH 1/3] os: Add -displayfd option.

2011-01-06 Thread Alan Coopersmith
On 01/ 6/11 03:02 PM, Julien Cristau wrote: On Thu, Jan 6, 2011 at 17:28:59 -0500, Adam Jackson wrote: +for (i = 0; i 65535 - 1024; i++) Should this be 65535 - 6000? Or 65535 - X_TCP_PORT ? -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris

[PULL] grab fix, valuator_mask_free() addition

2011-01-06 Thread Peter Hutterer
note that the valuator_mask_free() patch requires an ABI minor bump again, but I'd like to wait with it until the evdev patches are done, just in case we find something else we need. The following changes since commit f3480286aeb3009623d8d4b0202eadda0049552d: composite: Support updating an

Re: [PATCH 3/3] xfree86: Fix the sdk headers to be multilib-safe

2011-01-06 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 6 Jan 2011 17:29:01 -0500 Use _LP64 (verified on gcc and sun compilers) instead of _XSERVER64 in internal header usage, and always define _XSERVER64 for modules if _LP64 is defined. Prevents differing xorg-server.h between 32 and 64 bit

[PATCH] Xi: reset remainders when warping the device.

2011-01-06 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xi/xiwarppointer.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Xi/xiwarppointer.c b/Xi/xiwarppointer.c index 7276e6f..c01b115 100644 --- a/Xi/xiwarppointer.c +++ b/Xi/xiwarppointer.c @@ -192,6 +192,8 @@

[PATCH xserver] Xorg.man: fix whitespace issues

2011-01-06 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xfree86/doc/man/Xorg.man.pre | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/xfree86/doc/man/Xorg.man.pre b/hw/xfree86/doc/man/Xorg.man.pre index 86e89a9..6fa334c 100644 ---

[PATCH xserver] Xquartz: build Xquartz man pages using XORG_MANPAGE_SECTIONS

2011-01-06 Thread Gaetan Nadon
Nothing requires the use of a C preprocessor Using standard file exentions (.man) Use standard directory and makefile Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xquartz/doc/Makefile.am | 19 --- hw/xquartz/doc/{Xquartz.man.pre = Xquartz.man} |

[PATCH xserver] Xquartz: strip the man page code from cpprules.in

2011-01-06 Thread Gaetan Nadon
This is dead code which will not be used in the future. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xquartz/bundle/cpprules.in | 22 ++ 1 files changed, 2 insertions(+), 20 deletions(-) diff --git a/hw/xquartz/bundle/cpprules.in b/hw/xquartz/bundle/cpprules.in

[PATCH xserver] Xnest: build Xnest man pages using XORG_MANPAGE_SECTIONS

2011-01-06 Thread Gaetan Nadon
Nothing requires the use of a C preprocessor Using standard file exentions (.man) means no need for .gitignore Use standard directory and makefile Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 + hw/xnest/.gitignore |

[PATCH xserver] XWin: build XWin man pages using XORG_MANPAGE_SECTIONS

2011-01-06 Thread Gaetan Nadon
Nothing requires the use of a C preprocessor Using standard file exentions (.man) means no need for .gitignore Use standard directory and makefile Now can be built easily on any platform in the man directory Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac