Re: [PATCH] glx: Fix lifetime tracking for pixmaps

2011-03-30 Thread Michel Dänzer
On Die, 2011-03-29 at 09:48 -0400, Adam Jackson wrote: On Tue, 2011-03-29 at 10:09 +0200, Michel Dänzer wrote: On Mon, 2011-03-28 at 12:40 -0400, Adam Jackson wrote: diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 9b4bc9e..9d60bdb 100644 --- a/glx/glxcmds.c +++ b/glx/glxcmds.c

[PATCH v2 2/2] [libXau] XauGet*AuthByAddr: use XauGetFileName instead of XauFileName

2011-03-30 Thread Erkki Seppälä
XauGetFileName is a thread-safe variant of XauFileName. Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi --- AuGetAddr.c | 12 +++- AuGetBest.c | 12 +++- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git

[PATCH v2 1/2] [libXau] XauGetFileName: added a thread-safe variant of XauFileName

2011-03-30 Thread Erkki Seppälä
XauGetFileName has argument char **buffer, which can be used to provide an existing buffer for XauGetFileName to store the result in. *buffer can be NULL, in which case a newly allocated block of memory will be allocated and stored at *buffer. The function also provides means to signal the

[PATCH v2 0/2] [libXau] XauGetFileName: added a thread-safe variant of XauFileName

2011-03-30 Thread Erkki Seppälä
Well, we decided to take the suggestions into account nevertheles and create a thread-safe variant of XauFileName, that is used internally by libXau and thus reduces the impact to multi-threaded programs that use that function directly instead of the new XauGetFileName. I imagine the number of

[PATCH 00/16] More static analysis fixes for Xlib

2011-03-30 Thread Ander Conselvan de Oliveira
This series contains fixes for problems found in Xlib thought static code analysis. Ander Conselvan de Oliveira (16): Fix memory leak with broken bitmap files in XReadBitmapFileData FSWrap: fix potential leak in copy_string_list Fix leaks in _XimEncodingNegotiation error paths. Fix memory

[PATCH 03/16] Fix leaks in _XimEncodingNegotiation error paths.

2011-03-30 Thread Ander Conselvan de Oliveira
name_ptr and detail_ptr weren't free'd in some before returning False. Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/im/ximcp/imDefIm.c | 53 ++- 1 files changed, 27 insertions(+), 26 deletions(-) diff

[PATCH 01/16] Fix memory leak with broken bitmap files in XReadBitmapFileData

2011-03-30 Thread Ander Conselvan de Oliveira
Bitmap file data is read looping through the lines in the input file. If there is extra data after the bitmap, these lines will be processed and if this data represents another bitmap it will replace the one read before causing the memory allocated for bits to leak. This changes the code to stop

[PATCH 02/16] FSWrap: fix potential leak in copy_string_list

2011-03-30 Thread Ander Conselvan de Oliveira
If list_count is 0, dst would be allocated and leaked. Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- src/FSWrap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/FSWrap.c b/src/FSWrap.c index a947093..94d94fb 100644 ---

[PATCH 04/16] Fix memory leaks on _XimProtoCreateIC error paths.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/im/ximcp/imDefIc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/im/ximcp/imDefIc.c b/modules/im/ximcp/imDefIc.c index be74a2c..9283c49 100644 ---

[PATCH 08/16] Fix memory leaks on _XimCbDispatch error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/im/ximcp/imCallbk.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules/im/ximcp/imCallbk.c b/modules/im/ximcp/imCallbk.c index 866b27c..6275bbf 100644 ---

[PATCH 05/16] Fix memory leak on _XimGetAttributeID error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/im/ximcp/imRmAttr.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c index 5035df5..0471f3d 100644 ---

[PATCH 07/16] Fix memory leak on _XimCommitRecv error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/im/ximcp/imDefLkup.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/im/ximcp/imDefLkup.c b/modules/im/ximcp/imDefLkup.c index f818faa..996d36a 100644 ---

[PATCH 09/16] om: Fix memory leak on read_EncodingInfo error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/om/generic/omGeneric.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/om/generic/omGeneric.c b/modules/om/generic/omGeneric.c index c78c0a9..0029093 100644 ---

[PATCH 11/16] om: Fix memory leak on get_font_name error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/om/generic/omGeneric.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/om/generic/omGeneric.c b/modules/om/generic/omGeneric.c index 0029093..ec2abc0 100644 ---

[PATCH 15/16] xcms: Fix error on LINEAR_RGB_InitSCCData error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Due to what looks like a copy paste error, pScreenData-pBlueTbl would be accessed after being free'd. Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- src/xcms/LRGB.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xcms/LRGB.c

[PATCH 10/16] Fix memory leak on _XimGetAttributeID error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/im/ximcp/imRmAttr.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/im/ximcp/imRmAttr.c b/modules/im/ximcp/imRmAttr.c index 0471f3d..d91aa7d 100644 ---

[PATCH 16/16] xcms: Fix memory leaks on LINEAR_RGB_InitSCCData error path.

2011-03-30 Thread Ander Conselvan de Oliveira
pScreenData is replaced when building per visual intensity tables. If malloc failed the old value of pScreenData (stored also in pScreenDefaultData) was being leaked. Also, property_return wasn't free'd in that case. Signed-off-by: Ander Conselvan de Oliveira

[PATCH 12/16] om: Fix potential memory leak in init_om.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- modules/om/generic/omGeneric.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/modules/om/generic/omGeneric.c b/modules/om/generic/omGeneric.c index

[PATCH 14/16] Fix memory leak in XXorRegion error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- src/Region.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/Region.c b/src/Region.c index e960ad1..2350cd3 100644 --- a/src/Region.c +++ b/src/Region.c @@ -1449,8 +1449,12 @@

[PATCH 13/16] Fix memory leak on XShrinkRegion error path.

2011-03-30 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan-de-olive...@nokia.com --- src/Region.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/Region.c b/src/Region.c index 45a0bda..e960ad1 100644 --- a/src/Region.c +++ b/src/Region.c @@ -384,7 +384,8 @@

Re: [PATCHv3 13/14] xfree86: fix bad free configInputDevices

2011-03-30 Thread Dan Nicholson
On Tue, Mar 29, 2011 at 8:08 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: introduced in e1165632bdfbd720889ed1adf5f7ab338032c0ee. Actually, it would have been an earlier commit since Peter just moved this code to a convenience function in that commit. Anyway... Signed-off-by: Tiago

Re: [PATCH] damage: Remove the 'damage window' resource type

2011-03-30 Thread Soeren Sandmann
Adam Jackson a...@redhat.com writes: This may be more correct in that it cleans up the Damage. I think it's less correct in that you break existing clients. FreeDamageExtWin() deletes the Damage XID, but the spec mentions nothing about magically garbage-collecting Damages just because their

Re: [PATCH 10/10] render: fix memory leaks in ProcRenderCompositeGlyphs

2011-03-30 Thread Soeren Sandmann
Tiago Vignatti tiago.vigna...@nokia.com writes: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- render/render.c | 25 - 1 files changed, 12 insertions(+), 13 deletions(-) Reviewed-by: Soren Sandmann s...@redhat.com Soren

[PATCH v2 xserver 1/2] xkb: Introduce helper function to handle similar reallocations.

2011-03-30 Thread Rami Ylimäki
This is preparation for a memory leak fix and doesn't contain any functional changes. Note that two variables are generally used for reallocation and clearing of arrays: geom-sz_elems (reallocation) and geom-num_elems (clearing). The interface of XkbGeomRealloc is deliberately kept simple and it

[PATCH v2 xserver 2/2] xkb: Prevent leaking of XKB geometry information on copy.

2011-03-30 Thread Rami Ylimäki
Currently shapes, sections and doodads may leak on copy. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi --- xkb/xkbUtils.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-)

[PATCH v2 xserver 0/2] Fix for XKB geometry leaks when mapping changes

2011-03-30 Thread Rami Ylimäki
v1 -- Running setxkbmap repeatedly to change the keyboard mapping may lead to leaking of geometry related XKB data. The setxkbmap command does XkbGetKbdByName request, which copies keymap using XkbCopyKeymap, but the copying doesn't always release allocated pointers in _XkbCopyGeom. v2 -- This

Re: multitouch and synaptics clickpad status

2011-03-30 Thread Chase Douglas
(Sorry for the line wrap or any ill formatted text. Thunderbird is buggy and won't show me messages when I have soo many unread :). I'm having to use Mail on OS X.) On Mar 4, 2011, at 1:54 PM, Daniel Kurtz wrote: Back in October Chase Douglas [1] kicked off a flurry of patches and

Re: [PATCH] glx: Fix lifetime tracking for pixmaps

2011-03-30 Thread Adam Jackson
On 3/30/11 2:53 AM, Michel Dänzer wrote: So, is this expected to fix the same bugs the previous reference counting patches were supposed to, and possibly more? For pixmaps, certainly. I've got piglit tests for windows and pbuffers in progress too, so I guess we'll see whether those need

[PATCH 1/2] Add RegionInitBoxes(), and fix some buggy callers of RegionInit().

2011-03-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com The interface to RegionInit(): RegionInit (RegionPtr pReg, BoxPtr rect, int size); is very confusing because it doesn't take a list of boxes, it takes *one* box, but if that box is NULL, it initializes an empty region with 'size' rectangles

Re: [PATCH 2/2] Make RegionInit() and RegionCreate() take just a box and no size

2011-03-30 Thread Soeren Sandmann
Søren Sandmann sandm...@cs.au.dk writes: This patch changes the interface to take just one box and fixes all the callers accordingly. Apparently, I missed a RegionCreate() in mirect.c: - pClip = RegionCreate(NULL, 1); + pClip = RegionCreate(NULL); Also, the open drivers

[PATCH 2/4] render: Remove unused variables

2011-03-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com In CompositeTriStrip() pScreen and ps are not used. In CompositeTriFan(), pScreen is not used. Signed-off-by: Soren Sandmann s...@redhat.com --- render/picture.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git

[PATCH 1/4] render: Delete PictureGradientColor()

2011-03-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com PictureGradientColor(), INTERPOLATE_PIXEL_256() and premultiply() are not used by anything. Signed-off-by: Soren Sandmann s...@redhat.com --- render/picture.c| 45 - render/picturestr.h |5 -

[PATCH 3/4] render: Remove unused fields in the source picture structs

2011-03-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com The fields class, stopRange, colorTable and colorTableSize are not used by any current code. Signed-off-by: Soren Sandmann s...@redhat.com --- render/picture.c| 13 - render/picturestr.h | 25 - 2 files

[PATCH 4/4] render: Remove unused TriStrip and TriFan typedefs

2011-03-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com Signed-off-by: Soren Sandmann s...@redhat.com --- render/picturestr.h | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/render/picturestr.h b/render/picturestr.h index c536c38..7b7f911 100644 ---

[PATCH] fb: Call miCompositeSourceValidate() on the source in fbShapes()

2011-03-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen ssp@l3000.localdomain Signed-off-by: Soren Sandmann s...@redhat.com --- fb/fbtrap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fb/fbtrap.c b/fb/fbtrap.c index 612fae7..b5c5a61 100644 --- a/fb/fbtrap.c +++ b/fb/fbtrap.c @@ -111,6 +111,8

[PATCH 1/2] render: Move miCompositeRects() into fb as fbCompositeRects().

2011-03-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com It is not used anywhere else. Signed-off-by: Soren Sandmann s...@redhat.com --- fb/fbpict.c| 47 +- fb/fbpict.h|7 ++ render/Makefile.am |1 - render/mipict.c|2 +- render/mipict.h|7 --

[PATCH 2/2] render: Delete miRenderPixelToColor() and miRenderColorToPixel().

2011-03-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com They are not used anymore. Signed-off-by: Soren Sandmann s...@redhat.com --- render/mipict.c | 84 --- render/mipict.h | 10 -- 2 files changed, 0 insertions(+), 94 deletions(-) diff --git

Re: [PATCH 1/2] Add RegionInitBoxes(), and fix some buggy callers of RegionInit().

2011-03-30 Thread Keith Packard
On Wed, 30 Mar 2011 11:34:09 -0400, Søren Sandmann sandm...@cs.au.dk wrote: This patch adds a new function RegionInitBoxes() and fixes those instances to call that instead. What's the memory allocation story here? Does RegionInitBoxes allocate space and copy the provided boxes in (in which

Re: [ANNOUNCE] xorg-sgml-doctools 1.7

2011-03-30 Thread Cyril Brulebois
Hi Gaetan, Gaetan Nadon mems...@videotron.ca (29/03/2011): Gaetan Nadon (3): config: comment, minor upgrade, quote and layout configure.ac DocBook/XML: add support for docbook external references Version bump: 1.7 building an updated package, a few new files come up, which

Re: [PATCH 1/2] render: Move miCompositeRects() into fb as fbCompositeRects().

2011-03-30 Thread Soeren Sandmann
Søren Sandmann sandm...@cs.au.dk writes: From: Søren Sandmann Pedersen s...@redhat.com It is not used anywhere else. Actually, ignore this one. miCompositeRects() is used indirectly by exa since exaCompositeRects() is not actually a wrapper of ps-CompositeRects as I thought. Soren

Re: [ANNOUNCE] xorg-sgml-doctools 1.7

2011-03-30 Thread Gaetan Nadon
On Wed, 2011-03-30 at 18:59 +0200, Cyril Brulebois wrote: Hi Gaetan, Gaetan Nadon mems...@videotron.ca (29/03/2011): Gaetan Nadon (3): config: comment, minor upgrade, quote and layout configure.ac DocBook/XML: add support for docbook external references Version bump:

Re: [ANNOUNCE] xorg-sgml-doctools 1.7

2011-03-30 Thread Cyril Brulebois
Gaetan Nadon mems...@videotron.ca (30/03/2011): Both of these are new files, replacing xorg.xsl […] This is correct. There has to be one master db per format. It points to a real filename such as secint.html, secint.pdf, etc... Thanks for confirming. For example, gnome-help can read

Re: [PULL] xserver-next, 2011-03-28

2011-03-30 Thread Keith Packard
On Mon, 28 Mar 2011 13:07:26 -0400, Adam Jackson a...@nwnk.net wrote: Adam Jackson (14): glx: Remove noop dispatch table glx: Lobotomize _glapi_get_proc_address glx: Update some glapi comments glx: Flatten -DXFree86Server glx: Fix _glapi_add_dispatch

Re: [PATCH 1/2] Add RegionInitBoxes(), and fix some buggy callers of RegionInit().

2011-03-30 Thread Soeren Sandmann
Keith Packard kei...@keithp.com writes: On Wed, 30 Mar 2011 11:34:09 -0400, Søren Sandmann sandm...@cs.au.dk wrote: This patch adds a new function RegionInitBoxes() and fixes those instances to call that instead. What's the memory allocation story here? Does RegionInitBoxes allocate space

Re: [PATCH 1/2] fb: drop defines that aren't used/necessary anymore.

2011-03-30 Thread Keith Packard
On Tue, 29 Mar 2011 09:55:56 +0200 (CEST), Mark Kettenis mark.kette...@xs4all.nl wrote: Unfortunately this sort of automatically generated diffs have some drawbacks... Yeah, we should probably have a follow-on manual patch that cleans up the results of the automatic one. Otherwise, we'll just

Re: [PATCH 1/2] Add RegionInitBoxes(), and fix some buggy callers of RegionInit().

2011-03-30 Thread Keith Packard
On Wed, 30 Mar 2011 19:53:40 +0200, Soeren Sandmann sandm...@cs.au.dk wrote: But it probably still does make sense to handle these errors explicitly. New patch below. Looks good to me. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpxDCyBFimjB.pgp Description:

Re: [PATCH xserver 4/5] dmx: modernize doxygen generation.

2011-03-30 Thread Matt Dew
On 03/29/2011 08:04 PM, Gaetan Nadon wrote: The configuration and stylesheet were very old. The stylesheet is not checked-in, use the generated one. The header is not checked-in, use the generated one. Add datetime and projectname in default footer. Developer documentation is not installed

Re: [PATCH xserver 4/5] dmx: modernize doxygen generation.

2011-03-30 Thread Gaetan Nadon
On Wed, 2011-03-30 at 12:30 -0600, Matt Dew wrote: On 03/29/2011 08:04 PM, Gaetan Nadon wrote: The configuration and stylesheet were very old. The stylesheet is not checked-in, use the generated one. The header is not checked-in, use the generated one. Add datetime and projectname in

[PATCH xserver 1/9] doc: use common makefile for developers documentation

2011-03-30 Thread Gaetan Nadon
The user/specs docs now have external references support. Developers doc are not installed so they do not participate. However, using a similar makefile shared amongst developers document reduces maintenance and is forward looking. Man pages being out of here, reorg developers docs under the same

[PATCH xserver 2/9] dmx/doc: use common makefile for developers documentation

2011-03-30 Thread Gaetan Nadon
The user/specs docs now have external references support. Developers doc are not installed so they do not participate. However, using a similar makefile shared amongst developers document reduces maintenance and is forward looking. Signed-off-by: Gaetan Nadon mems...@videotron.ca ---

[PATCH xserver 3/9] dmx: split DocBook/XML and Doxygen makefile targets

2011-03-30 Thread Gaetan Nadon
Maintaining either requires full knowledge of both. It's not obvious one has to check the usage of global variables in devbook.am when maintaining doxygen target. Or vice-versa. Being in their respective directory, one less thing to worry about. Signed-off-by: Gaetan Nadon mems...@videotron.ca

[PATCH xserver 5/9] dmx: fix warning for doxygen explicit links

2011-03-30 Thread Gaetan Nadon
Explicit links to functions in another file are not supported. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/dmx/dmxwindow.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dmx/dmxwindow.c b/hw/dmx/dmxwindow.c index c3b4700..704fcff 100644 ---

[PATCH xserver 6/9] man: relocate manual pages in the man subdir outside doc

2011-03-30 Thread Gaetan Nadon
The convention is to have the manual pages in a man subdir which is not under a doc dir. The doc dir contains users docs. This will move man pages out of the way for upcoming DocBook patches. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am |2 ++

[PATCH xserver 7/9] doc: add external doc references support to Xserver-DTrace

2011-03-30 Thread Gaetan Nadon
This makefile is used to build the 60+ docbooks in xorg. Dtrace is a user document and should be located under doc subdir. This user document can now refer to external user/specs docs or can be referred to by such documnets. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac

[PATCH xserver 8/9] doc: relocate xserver.ent in the package root directory

2011-03-30 Thread Gaetan Nadon
This is the appropriate location for reusable configuration and/or makefile artifacts as opposed to picking one of the subdirs where it is used. It shields them from future doc reorg as every subdir will refer to the root package which never changes location. Signed-off-by: Gaetan Nadon

[PATCH xserver 9/9] doc: use devbook.am for developers documentation

2011-03-30 Thread Gaetan Nadon
Relocate the docs under the doc subdir. Remove redundant xml subdir. The xmlrules set of makefiles are no longer used. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 - doc/.gitignore |4 +++ doc/Makefile.am| 16

Re: [PATCH v2 xserver 0/2] Fix for XKB geometry leaks when mapping changes

2011-03-30 Thread Peter Hutterer
On Wed, Mar 30, 2011 at 04:47:29PM +0300, Rami Ylimäki wrote: v1 -- Running setxkbmap repeatedly to change the keyboard mapping may lead to leaking of geometry related XKB data. The setxkbmap command does XkbGetKbdByName request, which copies keymap using XkbCopyKeymap, but the copying

Re: [PATCH 2/2 v2] Handle non continuous valuator data in getValuatorEvents

2011-03-30 Thread Simon Thum
On 03/29/2011 03:39 AM, Peter Hutterer wrote: On Mon, Mar 28, 2011 at 04:04:48PM -0400, Chase Douglas wrote: This allows for masked valuators to be handled properly in XI 1.x events. Any unset valuators in the device event are set to the last known value when transmitted on the wire through XI

Re: [PATCH] damage: Remove the 'damage window' resource type

2011-03-30 Thread Christopher James Halse Rogers
On Wed, 2011-03-30 at 15:35 +0200, Soeren Sandmann wrote: Adam Jackson a...@redhat.com writes: This may be more correct in that it cleans up the Damage. I think it's less correct in that you break existing clients. FreeDamageExtWin() deletes the Damage XID, but the spec mentions nothing

[PATCH 2/9] Xrandr.man: Fix grammar.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index df585d1..fea196a 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -121,7 +121,7 @@ Specifies which screen. .IP

[PATCH 4/9] Xrandr.man: Try to make some sense.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 0124181..8aa572a 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -224,7 +224,7 @@ Randr, the coordinate system is

[PATCH 3/9] Xrandr.man: Build full sentences, possibly easier to read.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index fea196a..0124181 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -178,14 +178,17 @@ typedef struct { }

Try to make Xrandr's manpage a bit easier on the eyes

2011-03-30 Thread Cyril Brulebois
Hi, here are some patches I came up with while I was playing around with some XRR* functions. *BIG FAT WARNING*: I'm not a native speaker, or writer. All in all, shouldn't be too hard to review, since it's only about: | man/Xrandr.man | 81

[PATCH 1/9] Xrandr.man: Remove trailing spaces.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man | 52 ++-- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 23a3970..df585d1 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man

[PATCH 5/9] Xrandr.man: Fix typo.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 8aa572a..36905cc 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -275,7 +275,7 @@ of the server. If RandR is not

[PATCH 6/9] Xrandr.man: Build full sentences for easier reading.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 36905cc..14dcb51 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -308,9 +308,9 @@ information if it fails and

[PATCH 7/9] Xrandr.man: Fix missing closing parenthesis.

2011-03-30 Thread Cyril Brulebois
Also fix the closing tag (\fP instead of \fI). Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 14dcb51..75481fa 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@

[PATCH 9/9] Xrandr.man: Document how to request notifications.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index bcb8a47..f7c0088 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -185,7 +185,9 @@ structure contains a possible

[PATCH 8/9] Xrandr.man: Fix parenthesis escaping.

2011-03-30 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- man/Xrandr.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/Xrandr.man b/man/Xrandr.man index 75481fa..bcb8a47 100644 --- a/man/Xrandr.man +++ b/man/Xrandr.man @@ -94,7 +94,7 @@ void XRRSelectInput\^(\^Display

[libxrandr] Try to make Xrandr's manpage a bit easier on the eyes

2011-03-30 Thread Cyril Brulebois
Cyril Brulebois k...@debian.org (31/03/2011): here are some patches I came up with while I was playing around with some XRR* functions. And of course I forgot --subject-prefix, sorry for that. All of them are for libxrandr, which shouldn't be too hard to guess anyway… KiBi. signature.asc

Re: Try to make Xrandr's manpage a bit easier on the eyes

2011-03-30 Thread Peter Hutterer
On Thu, Mar 31, 2011 at 03:59:38AM +0200, Cyril Brulebois wrote: Hi, here are some patches I came up with while I was playing around with some XRR* functions. *BIG FAT WARNING*: I'm not a native speaker, or writer. All in all, shouldn't be too hard to review, since it's only about: |

Re: Try to make Xrandr's manpage a bit easier on the eyes

2011-03-30 Thread Alan Coopersmith
On 03/30/11 06:59 PM, Cyril Brulebois wrote: Hi, here are some patches I came up with while I was playing around with some XRR* functions. *BIG FAT WARNING*: I'm not a native speaker, or writer. All in all, shouldn't be too hard to review, since it's only about: | man/Xrandr.man |

[PATCH] fb: drop fbCopyWindowProc its the same as fbCopyNtoN

2011-03-30 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com From what I can see these functions act the exact same way, that is unless I'm missing something subtle. Signed-off-by: Dave Airlie airl...@redhat.com --- fb/fb.h | 13 - fb/fbwindow.c | 55

Re: [PATCH 1/2] fb: drop defines that aren't used/necessary anymore.

2011-03-30 Thread Dave Airlie
On Thu, Mar 31, 2011 at 5:04 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Keith Packard kei...@keithp.com Date: Wed, 30 Mar 2011 10:55:04 -0700 On Tue, 29 Mar 2011 09:55:56 +0200 (CEST), Mark Kettenis mark.kettenis@xs4= all.nl wrote: Unfortunately this sort of automatically

[PATCH] fb: drop fbCopyRegion and fbDoCopy

2011-03-30 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com these were migrated to mi a while back. Signed-off-by: Dave Airlie airl...@redhat.com --- fb/fb.h | 27 --- fb/fbcopy.c | 33 - fb/wfbrename.h

[PATCH] [RFC] dix: don't use CopyWindow in driver level interface.

2011-03-30 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This splits CopyWindow before the exa/fb layers, and uses a new interface called PixmapCopyRegion to do the actual copy. The main point of this is a step towards removing WindowPtr's from the interface that drivers see or use. I've only lightly tested this

[PATCH v2 11/17] eventcomm: move need_grab into a proto-specific struct.

2011-03-30 Thread Peter Hutterer
Don't just assign a BOOL to proto_data, use a struct for readability. This changes nothing in the code, especially since need_grab is always false. The current code assumes that if a proto_data field is present, we respect the need_grab from this field. Otherwise, we always try to grab. need_grab

[PATCH] fb: cleanup fbChangeWindowAttributes

2011-03-30 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This cleans up the duplication in fbChangeWindowAttributes, and fixes a bug if the fb24_32ReformatTile ever failed, since the old code would happily dereference it in the fbEvenTile call a few lines later. Signed-off-by: Dave Airlie airl...@redhat.com ---