[PULL] XQuartz brownbag buildfix

2011-04-28 Thread Jeremy Huddleston
The following changes since commit f6d4e75ec55ac6812f9dead42ecdffb9614578c7: Merge remote-tracking branch 'jturney/master' (2011-04-27 12:08:51 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (1): XQuartz:

[PATCH font-util 1/2] bdftruncate: Properly support -w and +w

2011-04-28 Thread Jeremy Huddleston
Regression introduced by fb486bb1a5038912d064291b12c7aef5da3d8b63 Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston jerem...@apple.com --- bdftruncate.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/bdftruncate.c b/bdftruncate.c index

Re: Question about the modesetting on X server

2011-04-28 Thread Julien Cristau
On Thu, Apr 28, 2011 at 00:25:40 -0700, Alan Coopersmith wrote: On 04/27/11 10:26 PM, Huang, FrankR wrote: Okay. I understand that. But how the X server knows that no cliens are connected again? It keeps a count of open clients, increments it when a new client connects, decrements it

clang static analysis updated with tinderbox

2011-04-28 Thread Jeremy Huddleston
I'm in the process of updating my tinderboxes to run clang static analysis and upload the results. Currently only yuffie (XQuartz) has data available, and I'll be updating my linux tinerboxes in the next few days once yuffie is going smoothly. Hopefully cjb can integrate this a bit nicer into

[PATCH font-util 1/2 v2] bdftruncate: Properly support -w and +w

2011-04-28 Thread Jeremy Huddleston
Regression introduced by fb486bb1a5038912d064291b12c7aef5da3d8b63 Found-by: clang static analyzer Signed-off-by: Jeremy Huddleston jerem...@apple.com --- bdftruncate.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/bdftruncate.c b/bdftruncate.c

Re: [PATCH 3/6] Use abs() on integers, not fabs()

2011-04-28 Thread Michel Dänzer
On Mit, 2011-04-27 at 19:33 -0400, Matt Turner wrote: Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/modes/xf86Crtc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c index c2814d4..92c75b1

Re: [PATCH resend 0/11] remove duplicated includes

2011-04-28 Thread Daniel Stone
On Sun, Apr 24, 2011 at 07:47:58PM -0700, Jeremy Huddleston wrote: Hi Nicolas, I've merged these into my tree (and reviewed the xwin patch which was missing review). They'll be included in my next PULL to keithp (once my clang warning patches are reviewed ... v2 on its way). Damnit, I

Re: [PATCH] Move event filter initializer out of the structure itself

2011-04-28 Thread Daniel Stone
On Fri, Apr 22, 2011 at 10:19:39PM -0700, Alan Coopersmith wrote: When kept in the structure, it causes the entire MAXDEVICES * 128 masks to be stored in the data segment and loaded from the file, and also leads to worries about later generations inheriting changes across server reset.

Re: [PATCH] dix: only transform valuators when we need them.

2011-04-28 Thread Daniel Stone
On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote: Why don't we change this to: if (lround(p.v[0]) != dev-last.valuators[0]) valuator_mask_set(mask, 0, lround(p.v[0])); else valuator_mask_unset(mask, 0); The proposed fix will cause valuators to be sent with repeated

Re: [PATCH 1/2] Add _X_UNUSED attribute to designate unused variables and silence warnings

2011-04-28 Thread Daniel Stone
On Wed, Apr 27, 2011 at 05:25:40PM -0700, Jeremy Huddleston wrote: Signed-off-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH] os: Add missing _X_ATTRIBUTE_PRINTF to va_list variants

2011-04-28 Thread Daniel Stone
On Sun, Apr 24, 2011 at 07:58:33PM -0700, Jeremy Huddleston wrote: Signed-off-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Daniel Stone dan...@fooishbar.org ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-28 Thread Daniel Stone
On Wed, Apr 27, 2011 at 07:33:01PM -0400, Matt Turner wrote: Text size reduction of ~33k (1.8%): text data bss dec hex filename 1879739 72212 55328 2007279 1ea0ef hw/xfree86/Xorg.before 1845291 72212 55328 1972831 1e1a5f hw/xfree86/Xorg On

[PULL] Accumulated small input changes

2011-04-28 Thread Daniel Stone
Hi Keith, The following changes since commit 918a9c99cf2ebc73acb34b95f597904b93c690d9: Merge remote-tracking branch 'jeremyhu/master' (2011-04-22 11:20:16 -0700) are available in the git repository at: git://people.freedesktop.org/~daniels/xserver for-keith All fairly trivial input

Re: doxygen help (xserver won't make dist due to missing hw/dmx/doc/html/main.html)

2011-04-28 Thread Jon TURNEY
On 29/03/2011 14:13, Gaetan Nadon wrote: On Mon, 2011-03-28 at 23:29 -0700, Jeremy Huddleston wrote: As a followup, it seems that my 'make dist' in recent 1.9.x releases was actually not rebuilding hw/dmx/doc/html but using an existing version built back in October. I'm only noticing this

Re: [PULL] Accumulated small input changes

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 15:55:34 +0100, Daniel Stone dan...@fooishbar.org wrote: Daniel Stone (4): Input: Add DeepestSpriteWin macro I think this would be nicer if it were an inline function. -- keith.pack...@intel.com pgp62G4Sa55Oi.pgp Description: PGP signature

Re: [PULL] Accumulated small input changes

2011-04-28 Thread Daniel Stone
Hi, On Thu, Apr 28, 2011 at 09:18:44AM -0700, Keith Packard wrote: On Thu, 28 Apr 2011 15:55:34 +0100, Daniel Stone dan...@fooishbar.org wrote: Daniel Stone (4): Input: Add DeepestSpriteWin macro I think this would be nicer if it were an inline function. Sure, I've made it an

Re: doxygen help (xserver won't make dist due to missing hw/dmx/doc/html/main.html)

2011-04-28 Thread Jeremy Huddleston
Yep, +1 for nuking generated doc files from EXTRA_DIST I recall Gaetan sent a patch to xorg-devel to do that (which I believe I reviewed). It doesn't look like it has landed yet though. On Apr 28, 2011, at 09:12, Jon TURNEY wrote: On 29/03/2011 14:13, Gaetan Nadon wrote: On Mon,

Re: [PATCH 3/6] Use abs() on integers, not fabs()

2011-04-28 Thread Matt Turner
2011/4/28 Michel Dänzer mic...@daenzer.net: On Mit, 2011-04-27 at 19:33 -0400, Matt Turner wrote: Signed-off-by: Matt Turner matts...@gmail.com ---  hw/xfree86/modes/xf86Crtc.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c

[PATCH] GLX/DRI2: fix swap complete handling

2011-04-28 Thread Jesse Barnes
The swap complete event wasn't being handled fully; because XEvents are only 32 bytes long, we were getting junk for the sbc_lo value. If the server supports it, unpack the new structure, otherwise just return 0 for the sbc value instead of garbage. --- configure.ac|4 ++--

[PATCH] Fix swap complete event size

2011-04-28 Thread Jesse Barnes
XEvents are limited to 32 bytes, so use some creative stuffing to fit all the bits we'd like to supply. --- configure.ac |2 +- dri2proto.h |9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 5b78d6b..9505f56 100644 ---

[RFC] swap event handling fixes

2011-04-28 Thread Jesse Barnes
I obviously failed to count the swap event structure size after adding and removing fields a few times, and didn't even account for padding. The end result is that clients today won't receive the sbc_lo field at all, and so will likely stuff junk into that field on the client side (or zero at

[PATCH] DRI2/GLX: fix swap event handling

2011-04-28 Thread Jesse Barnes
Use the new swap event structure packing and send it to the client if possible. This means tracking client version information when clients connect. If they don't support the new packing, they'll get the old bits and fill junk into their sbc values when they receive the event. If they do support

[PATCH libX11] docbook: Don't use --nonet in XSLTPROC_FLAGS

2011-04-28 Thread Jeremy Huddleston
We are explicitly pulling in resources from the net, so this would always fail. %.html.db: %.xml $(chapters) $(AM_V_GEN)$(XSLTPROC) $(XSLTPROC_FLAGS) \ http://docbook.sourceforge.net/release/xsl/current/xhtml/docbook.xsl $ %.fo.db: %.xml $(chapters)

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-28 Thread Siarhei Siamashka
On Thu, Apr 28, 2011 at 2:33 AM, Matt Turner matts...@gmail.com wrote: diff --git a/include/misc.h b/include/misc.h index 803f5ba..b7a3fd2 100644 --- a/include/misc.h +++ b/include/misc.h @@ -240,32 +240,17 @@ xstrtokenize(const char *str, const char* separators);  #define SwapRestL(stuff) \

Re: [PULL] Accumulated small input changes

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 17:43:05 +0100, Daniel Stone dan...@fooishbar.org wrote: Sure, I've made it an inline function now, but removed Peter's R-b. Do you (or anyone else) want to review it? :) Looks fairly reasonable, the only comment is that if spriteTraceGood is zero, we've got serious

Re: [PATCH] Pack swap complete bits into an XEvent

2011-04-28 Thread Eric Anholt
On Thu, 28 Apr 2011 13:27:19 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: The defintion of the swap complete event was wrong; XEvents are only 32 bytes long, and with padding the swap event was longer. So use some creative packing to get all the bits we want transmitted. Requires a

Re: [PATCH] Pack swap complete bits into an XEvent

2011-04-28 Thread Jesse Barnes
On Thu, 28 Apr 2011 14:33:58 -0700 Eric Anholt e...@anholt.net wrote: On Thu, 28 Apr 2011 13:27:19 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: The defintion of the swap complete event was wrong; XEvents are only 32 bytes long, and with padding the swap event was longer. So use

Re: [PATCH] DRI2/GLX: fix swap event handling

2011-04-28 Thread Eric Anholt
On Thu, 28 Apr 2011 13:27:22 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Use the new swap event structure packing and send it to the client if possible. This means tracking client version information when clients connect. If they don't support the new packing, they'll get the old

Re: [PULL] hw/xwin: Find GL specs, rather than downloading them

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 19:38:01 +0100, Jon TURNEY jon.tur...@dronecode.org.uk wrote: I've tested make check/dist/distcheck on linux and cygwin with this change, so hopefully no more lurking surprises :-) Does this change make 'distcheck' on Linux generate different bits than 'distcheck' on

Re: [PATCH] Pack swap complete bits into an XEvent

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 13:27:19 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: The defintion of the swap complete event was wrong; XEvents are only 32 bytes long, and with padding the swap event was longer. So use some creative packing to get all the bits we want transmitted. Requires a

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 23:36:12 +0300, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: -#define swapl(x, n) { \ -                n = ((char *) (x))[0];\ -                ((char *) (x))[0] = ((char *) (x))[3];\ -                ((char *) (x))[3] = n;\ -                n = ((char *)

Re: [PULL] hw/xwin: Find GL specs, rather than downloading them

2011-04-28 Thread Jon TURNEY
On 28/04/2011 22:55, Keith Packard wrote: On Thu, 28 Apr 2011 19:38:01 +0100, Jon TURNEY jon.tur...@dronecode.org.uk wrote: I've tested make check/dist/distcheck on linux and cygwin with this change, so hopefully no more lurking surprises :-) Does this change make 'distcheck' on Linux

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-28 Thread Matt Turner
On Thu, Apr 28, 2011 at 4:36 PM, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Thu, Apr 28, 2011 at 2:33 AM, Matt Turner matts...@gmail.com wrote: diff --git a/include/misc.h b/include/misc.h index 803f5ba..b7a3fd2 100644 --- a/include/misc.h +++ b/include/misc.h @@ -240,32 +240,17

Re: [PATCH libX11] docbook: Don't use --nonet in XSLTPROC_FLAGS

2011-04-28 Thread Dan Nicholson
On Thu, Apr 28, 2011 at 1:33 PM, Jeremy Huddleston jerem...@apple.com wrote: We are explicitly pulling in resources from the net, so this would always fail. %.html.db: %.xml  $(chapters)        $(AM_V_GEN)$(XSLTPROC) $(XSLTPROC_FLAGS) \        

Re: [PATCH libX11] docbook: Don't use --nonet in XSLTPROC_FLAGS

2011-04-28 Thread Jeremy Huddleston
On Apr 28, 2011, at 5:25 PM, Dan Nicholson wrote: This isn't true. If your xml catalog is setup correctly, the url will be converted to a local file. In /etc/xml/catalog on my F13 box: rewriteURI uriStartString=http://docbook.sourceforge.net/release/xsl/current;

Re: [PATCH libX11] docbook: Don't use --nonet in XSLTPROC_FLAGS

2011-04-28 Thread Gaetan Nadon
On Thu, 2011-04-28 at 17:25 -0700, Dan Nicholson wrote: On Thu, Apr 28, 2011 at 1:33 PM, Jeremy Huddleston jerem...@apple.com wrote: We are explicitly pulling in resources from the net, so this would always fail. %.html.db: %.xml $(chapters) $(AM_V_GEN)$(XSLTPROC)

Re: [PATCH libX11] docbook: Don't use --nonet in XSLTPROC_FLAGS

2011-04-28 Thread Jeremy Huddleston
This is what I observed as well. The xsltproc flags were derived from the xsltproc command issued by xmlto which is just a wrapper srcipt. It looks like a problem with the catalog installed with docbook-xsl-1.76.1 ... ugg... I hate generating docs. ?xml version=1.0 encoding=utf-8? catalog

[PATCH xserver RESEND2 3/9] dmx: split DocBook/XML and Doxygen makefile targets

2011-04-28 Thread Gaetan Nadon
Maintaining either requires full knowledge of both. It's not obvious one has to check the usage of global variables in devbook.am when maintaining doxygen target. Or vice-versa. Being in their respective directory, one less thing to worry about. Signed-off-by: Gaetan Nadon mems...@videotron.ca

[PATCH xserver RESEND2 5/9] dmx: fix warning for doxygen explicit links

2011-04-28 Thread Gaetan Nadon
Explicit links to functions in another file are not supported. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/dmx/dmxwindow.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dmx/dmxwindow.c b/hw/dmx/dmxwindow.c index c3b4700..704fcff 100644 ---

[PATCH xserver RESEND2 6/9] man: relocate manual pages in the man subdir outside doc

2011-04-28 Thread Gaetan Nadon
The convention is to have the manual pages in a man subdir which is not under a doc dir. The doc dir contains users docs. This will move man pages out of the way for upcoming DocBook patches. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am |2 ++

[PATCH xserver RESEND2 7/9] doc: add external doc references support to Xserver-DTrace

2011-04-28 Thread Gaetan Nadon
This makefile is used to build the 60+ docbooks in xorg. Dtrace is a user document and should be located under doc subdir. This user document can now refer to external user/specs docs or can be referred to by such documnets. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac

[PATCH xserver RESEND2 8/9] doc: relocate xserver.ent in the package root directory

2011-04-28 Thread Gaetan Nadon
This is the appropriate location for reusable configuration and/or makefile artifacts as opposed to picking one of the subdirs where it is used. It shields them from future doc reorg as every subdir will refer to the root package which never changes location. Signed-off-by: Gaetan Nadon

[PATCH xserver RESEND2 9/9] doc: use devbook.am for developers documentation

2011-04-28 Thread Gaetan Nadon
Relocate the docs under the doc subdir. Remove redundant xml subdir. The xmlrules set of makefiles are no longer used. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 - doc/.gitignore |4 +++ doc/Makefile.am| 16

Re: doxygen help (xserver won't make dist due to missing hw/dmx/doc/html/main.html)

2011-04-28 Thread Gaetan Nadon
On Thu, 2011-04-28 at 09:45 -0700, Jeremy Huddleston wrote: I recall Gaetan sent a patch to xorg-devel to do that (which I believe I reviewed). It doesn't look like it has landed yet though. I could not find any review tag, sorry if I missed it. I reposted anyway. signature.asc Description:

Re: doxygen help (xserver won't make dist due to missing hw/dmx/doc/html/main.html)

2011-04-28 Thread Jeremy Huddleston
On Apr 28, 2011, at 5:52 PM, Gaetan Nadon wrote: On Thu, 2011-04-28 at 09:45 -0700, Jeremy Huddleston wrote: I recall Gaetan sent a patch to xorg-devel to do that (which I believe I reviewed). It doesn't look like it has landed yet though. I could not find any review tag, sorry if I

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-28 Thread Gaetan Nadon
On Wed, 2011-04-27 at 19:13 -0700, Dan Nicholson wrote: On Wed, Apr 27, 2011 at 5:32 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 04/27/11 03:54 AM, Dan Nicholson wrote: IMO, you should at least AC_SUBST the variable if you want to use it somewhere else. I just wanted to

[PATCH xserver 1/9] doc: use common makefile for developers documentation

2011-04-28 Thread Gaetan Nadon
The user/specs docs now have external references support. Developers doc are not installed so they do not participate. However, using a similar makefile shared amongst developers document reduces maintenance and is forward looking. Man pages being out of here, reorg developers docs under the same

[PATCH xserver 2/9] dmx/doc: use common makefile for developers documentation

2011-04-28 Thread Gaetan Nadon
The user/specs docs now have external references support. Developers doc are not installed so they do not participate. However, using a similar makefile shared amongst developers document reduces maintenance and is forward looking. Reviewed-by Jeremy Huddleston jerem...@apple.com Signed-off-by:

[PATCH xserver 3/9] dmx: split DocBook/XML and Doxygen makefile targets

2011-04-28 Thread Gaetan Nadon
Maintaining either requires full knowledge of both. It's not obvious one has to check the usage of global variables in devbook.am when maintaining doxygen target. Or vice-versa. Being in their respective directory, one less thing to worry about. Reviewed-by Jeremy Huddleston jerem...@apple.com

[PATCH xserver 5/9] dmx: fix warning for doxygen explicit links

2011-04-28 Thread Gaetan Nadon
Explicit links to functions in another file are not supported. Reviewed-by Jeremy Huddleston jerem...@apple.com Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/dmx/dmxwindow.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dmx/dmxwindow.c

[PATCH xserver 9/9] doc: use devbook.am for developers documentation

2011-04-28 Thread Gaetan Nadon
Relocate the docs under the doc subdir. Remove redundant xml subdir. The xmlrules set of makefiles are no longer used. Reviewed-by Jeremy Huddleston jerem...@apple.com Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 - doc/.gitignore |

Re: [PATCH libX11] docbook: Don't use --nonet in XSLTPROC_FLAGS

2011-04-28 Thread Dan Nicholson
On Thu, Apr 28, 2011 at 5:46 PM, Jeremy Huddleston jerem...@apple.com wrote: This is what I observed as well. The xsltproc flags were derived from the xsltproc command issued by xmlto which is just a wrapper srcipt. It looks like a problem with the catalog installed with docbook-xsl-1.76.1

`PKG_CHECK_MODULES(X, xproto)'?

2011-04-28 Thread Fred Liu
Hi, I am following the instruction from Building all modules with the build scripts to build X11R76 as following: util/modular/build.sh $PREFIX ... ... ./configure: line 4899: syntax error near unexpected token `X,' ./configure: line 4899: `PKG_CHECK_MODULES(X, xproto)' build.sh: autogen.sh