Re: [PATCH] Remove another if (E != NULL) check around free(E)

2011-09-28 Thread Jeremy Huddleston
On Sep 26, 2011, at 7:58 PM, Matt Turner wrote: I wonder if there are any other patterns we haven't seen yet? Well clang static analyzer should help with that, but I just realized it was having issues. I'll try to fix it tomorrow for tomorrow evening's tinderbox run. --Jeremy

Re: [PATCH util/modular] build.sh: aiptek, acecad and penmount are unmaintained

2011-09-28 Thread Dirk Wallenstein
On Tue, Sep 27, 2011 at 09:22:46AM -0400, Gaetan Nadon wrote: On Tue, 2011-09-27 at 11:19 +1000, Peter Hutterer wrote: Remove them from the build script, they may not work against the server. Signed-off-by: Peter Hutterer [1]peter.hutte...@who-t.net --- build.sh |3 --- 1 files

Re: [PATCH util/modular] build.sh: aiptek, acecad and penmount are unmaintained

2011-09-28 Thread Dirk Wallenstein
On Wed, Sep 28, 2011 at 09:04:35AM +0200, Dirk Wallenstein wrote: On Tue, Sep 27, 2011 at 09:22:46AM -0400, Gaetan Nadon wrote: On Tue, 2011-09-27 at 11:19 +1000, Peter Hutterer wrote: Remove them from the build script, they may not work against the server. Signed-off-by: Peter

Re: [PATCH util/modular] build.sh: aiptek, acecad and penmount are unmaintained

2011-09-28 Thread Peter Hutterer
On 28/09/11 17:04 , Dirk Wallenstein wrote: On Tue, Sep 27, 2011 at 09:22:46AM -0400, Gaetan Nadon wrote: On Tue, 2011-09-27 at 11:19 +1000, Peter Hutterer wrote: Remove them from the build script, they may not work against the server. Signed-off-by: Peter

[PATCH-V3] xserver: Optional backtrace handler

2011-09-28 Thread Barry Scott
It is useful to be able to run an external program to analyse a crashed server process. The server will run a user supplied program in a subprocess of the server. The subprocess is created when the server starts up so that all resources needed to create the subprocess are available. It is not

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-28 Thread Søren Sandmann
zhigang gong zhigang.g...@gmail.com writes: I am not very familiar with either cairo/pixman, just know that it is used in spice, and it has a GL backend. There is also clutter, and some other open source 2D GL rendering libraries (qt canvas is also interesting, although I guess it's C++). How

[patch] Initialize all screens

2011-09-28 Thread Alistair Leslie-Hughes
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27845 Best Regards Alistair Leslie-Hughes From 58a1d8462fd3e8cd0fdeac18659f426bc0aa5c4a Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes leslie_alist...@hotmail.com Date: Wed, 28 Sep 2011 20:17:38 +1000 Subject: [PATCH] Initialize all

Re: [patch] Initialize all screens

2011-09-28 Thread Mark Kettenis
Date: Wed, 28 Sep 2011 20:23:22 +1000 From: Alistair Leslie-Hughes leslie_alist...@hotmail.com diff --git a/dix/devices.c b/dix/devices.c index 0ccf252..644e3e7 100644 --- a/dix/devices.c +++ b/dix/devices.c @@ -351,6 +351,7 @@ EnableDevice(DeviceIntPtr dev, BOOL sendevent)

[PATCH xdm] Support systemd startup notification.

2011-09-28 Thread Michał Górny
If libsystemd-daemon support is enabled, xdm uses it to announce its startup as soon as the session is established. This gives the user opportunity to delay I/O-intensive operations until the X server is started so that they would not interfere with its loading while keeping the machine busy when

Re: [PATCH xdm] Support systemd startup notification.

2011-09-28 Thread Jamey Sharp
I don't see any issues with this patch except: On 9/28/11, Michał Górny mgo...@gentoo.org wrote: --- a/configure.ac +++ b/configure.ac @@ -146,6 +146,7 @@ if test x$USE_SELINUX != xno ; then fi # Check whether to install systemd unit files, as suggested in daemon(7). +# When a full patch

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-28 Thread Michel Dänzer
On Die, 2011-09-27 at 21:50 +0800, zhigang gong wrote: 3. Only support Intel platform currently. As glamor depends on KMS + MESA/EGL + GBM, currently only intel gfx device get supported. A Gallium based EGL driver (e.g. r3/600g, nouveau or llvmpipe) can support all of the above, any

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-28 Thread Alon Levy
On Wed, Sep 28, 2011 at 11:51:16AM +0800, zhigang gong wrote: On Wed, Sep 28, 2011 at 1:41 AM, Alon Levy al...@redhat.com wrote: On Tue, Sep 27, 2011 at 09:50:06PM +0800, zhigang gong wrote: Hi Keith, Here is the pull request to merge glamor. Basically, it has three parts. The first

[PATCH] edid: Add quirk for Acer Aspire One 110

2011-09-28 Thread Ross Burton
At least one revision of the AAO reports a 190x110mm maximum size but a 451x113mm mode. X.Org Bug 41141 https://bugs.freedesktop.org/show_bug.cgi?id=41141 Signed-off-by: Ross Burton r...@linux.intel.com --- hw/xfree86/modes/xf86EdidModes.c |5 + 1 files changed, 5 insertions(+), 0

Re: [PATCH xf86-video-vmware] Use dixLookupWindow instead of LookupWindow on Xorg 1.5 later

2011-09-28 Thread Jamey Sharp
Looks sane to me, for whatever that's worth: Reviewed-by: Jamey Sharp ja...@minilop.net On 9/27/11, Alan Coopersmith alan.coopersm...@oracle.com wrote: The LookupWindow function was deprecated in xserver commit ed75b056511ccb4 and removed during the Xorg 1.11 merge window by commit

Re: [PATCH] fix doPolyText use-after-free issue

2011-09-28 Thread Jeremy Huddleston
I missed this point at first. The context is that in 'bail', c is accessed and expected to be the old value. Candidate for 1.11-branch Reviewed-by: Jeremy Huddleston jerem...@apple.com I think something is wrong with your mailer (or maybe mine). I was unable to git-am this patch. Can you

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-28 Thread zhigang gong
2011/9/28 Michel Dänzer mic...@daenzer.net: On Die, 2011-09-27 at 21:50 +0800, zhigang gong wrote: 3. Only support Intel platform currently. As glamor depends on KMS + MESA/EGL + GBM, currently only intel gfx device get supported. A Gallium based EGL driver (e.g. r3/600g, nouveau or

Re: [PATCH] Remove another if (E != NULL) check around free(E)

2011-09-28 Thread Jeremy Huddleston
This looks like a pretty good run of the analyzer: http://people.freedesktop.org/~jeremyhu/analyzer/tifa-linux32/20110927-1930 Some drivers didn't build though due to the swap macro change, but the rest look to have good results: http://tinderbox.x.org/builds/2011-09-28-0004 On Sep 27, 2011, at

Re: [PATCH:libXft] Add const attributes to fix gcc -Wwrite-strings warnings

2011-09-28 Thread Alan Coopersmith
On 09/26/11 03:56 PM, Aaron Plattner wrote: XftDefaultParseBool could probably use a const too. Included that one too. Should these be _Xconst rather than plain old const? Does anyone #define _Xconst to override the definition in Xfuncproto.h? I don't think that's needed for internal

Re: [PATCH] edid: Add quirk for Acer Aspire One 110

2011-09-28 Thread Daniel Stone
Hi, On 28 September 2011 11:46, Ross Burton r...@linux.intel.com wrote: At least one revision of the AAO reports a 190x110mm maximum size but a 451x113mm mode. X.Org Bug 41141 https://bugs.freedesktop.org/show_bug.cgi?id=41141 Signed-off-by: Ross Burton r...@linux.intel.com Reviewed-by:

[PATCH] misc.h: GCC's 'error' attribute was introduced in GCC 4.3

2011-09-28 Thread Aaron Plattner
Older versions of GCC produce a warning when this attribute is used. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- include/misc.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index 1fea73e..193b10f 100644 ---

Re: [Pull Request] Glamor: A 2D rendering acceleration implementation based on OpenGL

2011-09-28 Thread Corbin Simpson
2011/9/28 zhigang gong zhigang.g...@gmail.com: 2011/9/28 Michel Dänzer mic...@daenzer.net: On Die, 2011-09-27 at 21:50 +0800, zhigang gong wrote: 3. Only support Intel platform currently. As glamor depends on KMS + MESA/EGL + GBM, currently only intel gfx device get supported. A Gallium

Re: [PATCH] edid: Add quirk for Acer Aspire One 110

2011-09-28 Thread Jeremy Huddleston
Candidate for 1.11 Reviewed-by: Jeremy Huddleston jerem...@apple.com Is there anyone who can do a Tested-by? On Sep 26, 2011, at 7:00 AM, Ross Burton wrote: At least one revision of the AAO reports a 190x110mm maximum size but a 451x113mm mode. X.Org Bug 41141

Re: [PATCH:libxtrans 00/10] Warning cleanups

2011-09-28 Thread Jeremy Huddleston
Series Reviewed-by: Jeremy Huddleston jerem...@apple.com On Sep 27, 2011, at 2:28 PM, Alan Coopersmith wrote: These greatly reduce the warning noise generated by the libxtrans code when building the X server, libX11, and other modules using libxtrans. Alan Coopersmith (10): Fix warnings

Re: [PATCH-V3] xserver: Optional backtrace handler

2011-09-28 Thread Jeremy Huddleston
After some thought, I think it's a good idea to not wait for the handler to exit. It may want to do some extra processing that it doesn't need the process hanging around for. You probably meant one of these to be backtrace_handler_stdin: +close(backtrace_handler_stdout); +

Re: [PATCH] misc.h: GCC's 'error' attribute was introduced in GCC 4.3

2011-09-28 Thread Jeremy Huddleston
A similar fix is already in my pending PULL request with additional changes for SunCC. http://cgit.freedesktop.org/~jeremyhu/xserver/commit/?h=for-keithid=4cf6820858e48e5e3f73b1dbdfbb1f2b14d9a12f On Sep 28, 2011, at 9:55 AM, Aaron Plattner wrote: Older versions of GCC produce a warning when

Re: [PATCH resend 1/3] Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs.

2011-09-28 Thread Aaron Plattner
Xserer-spec.xml still lists ChangeClip in the mi section in the list of server routines for porting, and DestroyClip in the ddx section. Can't you drop the CT_PIXMAP case in xnestChangeClip? I guess it doesn't actually matter since it's just dead code and it gets removed in patch 2/3

Re: [PATCH] misc.h: GCC's 'error' attribute was introduced in GCC 4.3

2011-09-28 Thread Jamey Sharp
This is subsumed by earlier proposed patches; see this thread: http://lists.x.org/archives/xorg-devel/2011-September/025497.html On Wed, Sep 28, 2011 at 09:55:26AM -0700, Aaron Plattner wrote: Older versions of GCC produce a warning when this attribute is used. Signed-off-by: Aaron Plattner

Re: [patch] Initialize all screens

2011-09-28 Thread Julien Cristau
On Wed, Sep 28, 2011 at 20:23:22 +1000, Alistair Leslie-Hughes wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27845 So I don't know this code, but the other suggestion in the report feels more correct... Cheers, Julien ___

Re: [PATCH resend 1/3] Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs.

2011-09-28 Thread Jamey Sharp
On Wed, Sep 28, 2011 at 11:02:42AM -0700, Aaron Plattner wrote: Xserer-spec.xml still lists ChangeClip in the mi section in the list of server routines for porting, and DestroyClip in the ddx section. Good catch! Amended locally and on my published review-pending branch, thanks. Can't you

Re: [PATCH resend 2/3] Make GC clientClip always be a region.

2011-09-28 Thread Aaron Plattner
On 09/26/2011 10:53 PM, Jamey Sharp wrote: Nothing ever set clientClip to anything but a region or NULL, so delete the clientClipType field and change clientClip from (pointer) to (RegionPtr). Signed-off-by: Jamey Sharpja...@minilop.net --- dix/gc.c | 51

Re: [PATCH xdm] Support systemd startup notification.

2011-09-28 Thread Gaetan Nadon
On Wed, 2011-09-28 at 16:25 +0200, Michał Górny wrote: If libsystemd-daemon support is enabled, xdm uses it to announce its startup as soon as the session is established. This gives the user opportunity to delay I/O-intensive operations until the X server is started so that they would not

[PATCH xdm] Support systemd startup notification.

2011-09-28 Thread Michał Górny
If libsystemd-daemon support is enabled, xdm uses it to announce its startup as soon as the session is established. This gives the user opportunity to delay I/O-intensive operations until the X server is started so that they would not interfere with its loading while keeping the machine busy when

Re: [PATCH 4/8] Introduce swap_uint{16, 32} functions, used in swap{l, s}

2011-09-28 Thread Aaron Plattner
On 08/16/2011 07:58 PM, Matt Turner wrote: Signed-off-by: Matt Turnermatts...@gmail.com --- include/misc.h | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/include/misc.h b/include/misc.h index d991c0a..6034c72 100644 ---

Re: [PATCH resend 2/3] Make GC clientClip always be a region.

2011-09-28 Thread Jamey Sharp
On Wed, Sep 28, 2011 at 11:48:38AM -0700, Aaron Plattner wrote: On 09/26/2011 10:53 PM, Jamey Sharp wrote: - for (i = nRects; i-- 0; ) { ... +for (i = nRects; i-- 0; ) { Whitespace error: i-- 0 The patch got mangled somewhere in transit. In my git tree, and in Patchwork, it is

Re: [PATCH xdm] Support systemd startup notification.

2011-09-28 Thread Gaetan Nadon
On Wed, 2011-09-28 at 21:25 +0200, Michał Górny wrote: If libsystemd-daemon support is enabled, xdm uses it to announce its startup as soon as the session is established. This gives the user opportunity to delay I/O-intensive operations until the X server is started so that they would not

Re: [PATCH resend 2/3] Make GC clientClip always be a region.

2011-09-28 Thread Jamey Sharp
On Wed, Sep 28, 2011 at 01:13:26PM -0700, Aaron Plattner wrote: Reviewed-by: Aaron Plattner aplatt...@nvidia.com Thanks! On 09/28/2011 12:58 PM, Jamey Sharp wrote: Yeah, I don't think that belongs in this commit. Actually, I want to delete Xnest entirely, along with all the other non-xfree86

[PULL] build fix, GC clipping cleanup

2011-09-28 Thread Jamey Sharp
Hi Keith! Here's some reviewed code deletion (hooray!) and the fix to make kdrive build again after the last pull. The following changes since commit afb1fe695d197187a301c19863a128a65389b15c: Merge remote-tracking branch 'whot/next' (2011-09-26 20:24:15 -0700) are available in the git

Re: [PATCH 4/8] Introduce swap_uint{16, 32} functions, used in swap{l, s}

2011-09-28 Thread Matt Turner
On Tue, Aug 16, 2011 at 10:58 PM, Matt Turner matts...@gmail.com wrote: Signed-off-by: Matt Turner matts...@gmail.com ---  include/misc.h |   30 --  1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/include/misc.h b/include/misc.h index

[PATCH] Remove incorrect in swap_uint32

2011-09-28 Thread Matt Turner
Caused by commit 893e86a4, and hidden by the (char *) cast. Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index 1fea73e..180b3c1 100644 --- a/include/misc.h +++

Re: [Patch] glamor: Don't build glamor egl/gbm related code if GLAMOR_DDX disabled

2011-09-28 Thread Alan Coopersmith
That fixes it and lets the build complete for me, thanks. Tested-by: Alan Coopersmith alan.coopersm...@oracle.com -alan- On 09/27/11 08:06 PM, zhigang gong wrote: Alan, I think you tried Xephyr-glamor at first and met the compilation failure. Here is a patch to fix that, please help

Re: [PATCH] Remove incorrect in swap_uint32

2011-09-28 Thread Aaron Plattner
On 09/28/2011 02:27 PM, Matt Turner wrote: Caused by commit 893e86a4, and hidden by the (char *) cast. Signed-off-by: Matt Turnermatts...@gmail.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com This also fixes the XTS UNRESOLVED results, so Tested-by: Aaron Plattner aplatt...@nvidia.com

Re: [PATCH] Remove incorrect in swap_uint32

2011-09-28 Thread Thomas Dickey
On Wed, 28 Sep 2011, Matt Turner wrote: Caused by commit 893e86a4, and hidden by the (char *) cast. That's an example of why just adding casts is not always a good idea. Another way to do this would be to provide a local variable with the right type (and generally at no cost, due to

Re: [PATCH resend 3/3] CreateRootWindow: Set root windows' drawable.x/y to -pScreen-x/y.

2011-09-28 Thread Aaron Plattner
On 09/26/2011 10:53 PM, Jamey Sharp wrote: A window's DrawableRec's x and y fields contain the offsets to be applied to protocol-visible window-relative coordinates in order to make those coordinates screen-relative instead. When Xinerama is active, coordinates relative to the root window need

Re: [PATCH] Remove incorrect in swap_uint32

2011-09-28 Thread Peter Hutterer
On Wed, Sep 28, 2011 at 05:27:45PM -0400, Matt Turner wrote: Caused by commit 893e86a4, and hidden by the (char *) cast. Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/misc.h

Re: [PATCH v2] Input: Add smooth-scrolling support

2011-09-28 Thread Peter Hutterer
On Wed, Sep 28, 2011 at 01:30:58AM +0100, Daniel Stone wrote: Hi, On 23 September 2011 02:22, Peter Hutterer peter.hutte...@who-t.net wrote: +    if (*current_ax != -1 axnum != *current_ax) +    { +        ax = dev-valuator-axes[*current_ax]; +        if (ax-scroll.type == type +  

[PATCH v3] Input: Add smooth-scrolling support to GetPointerEvents

2011-09-28 Thread Peter Hutterer
For scroll wheel support, we used to send buttons 4/5 and 6/7 for horizontal/vertical positive/negative scroll events. For touchpads, we really want more fine-grained scroll values. GetPointerEvents now accepts both old-school scroll button presses, and new-style scroll axis events, while

[PATCH libXi] Remove superfluous assignment of lib-classes in XIQueryDevices.

2011-09-28 Thread Peter Hutterer
A few lines south from here we malloc lib-classes, this assignment is a leftover from 225071e2e67fb65a0258397212f9826c9b25e078. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/XIQueryDevice.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

Re: [PATCH xfontsel] Remove USE_TEXT_WIDGET (bug 8966)

2011-09-28 Thread Alan Coopersmith
On 10/26/10 04:06 PM, Jesse Adkins wrote: It was included in the initial revision. The bug dates back to 2006, so I think it's safe to say that this never worked. Signed-off-by: Jesse Adkinsjesserayadk...@gmail.com Since it's been almost a year and no one has objected to the removal of the

Re: [PATCH] Input: Fix frac calculation on [Raw]DeviceEvent conversion

2011-09-28 Thread Peter Hutterer
On Sun, Sep 25, 2011 at 08:44:26PM +0200, Max Schwarz wrote: (1UL 32) evaluates to 0 (at least here), so do the fraction calculation in two steps as in libXi. Fractions on xXIRawEvent were not multiplied at all, which also gave 0 as result. Signed-off-by: Max Schwarz m...@x-quadraht.de ---