Re: [RFC] Xdummy standalone binary or -dummy switch

2011-09-30 Thread Antoine Martin
[snip] I meant to reply to Jamey, but couldn't find his reply in my mailbox.. What are those limitations? 1) root-only limitations on the configuration options for the location of the config and log files. This makes sense when the server runs as root and gets (almost?) full access to all

Re: [PATCH] render: export TriStrip and TriFan to the drivers

2011-09-30 Thread Chris Wilson
On Thu, 15 Sep 2011 14:37:01 -0700, Aaron Plattner aplatt...@nvidia.com wrote: Reviewed-by: Aaron Plattner aplatt...@nvidia.com Thanks for doing this, it was bugging me that we couldn't wrap these functions at this level. Only somewhat related, but what do you think of the idea of creating

Re: [PATCH RESEND xserver 1/3] Xserver-spec: add release information

2011-09-30 Thread Gaetan Nadon
On Fri, 2011-09-30 at 08:55 +1000, Peter Hutterer wrote: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net for the patch but I wonder if this is really useful. With modular releases the katamari version doesn't mean that much anymore. I'd say you could just leave the X Version 11 in and

[PATCH xserver 1/3] ddx-Design: add X Version and Release information

2011-09-30 Thread Gaetan Nadon
Acked-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xfree86/doc/ddxDesign.xml |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/doc/ddxDesign.xml b/hw/xfree86/doc/ddxDesign.xml index 0290960..98c5d0e 100644

[PATCH xserver 2/3] ddxDesign: remove server version from the document title

2011-09-30 Thread Gaetan Nadon
Such version information is already written in the appropriate location Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xfree86/doc/ddxDesign.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH xserver 3/3] ddxDesign: drop the url in the coporate authors list

2011-09-30 Thread Gaetan Nadon
It was such an eyesore once rendered in html. Now it looks like other authors. Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xfree86/doc/ddxDesign.xml |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH xserver 1/3] Xserver-spec: add release information

2011-09-30 Thread Gaetan Nadon
It has been added in all docs (X Version 11, Release 7.6) Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Gaetan Nadon mems...@videotron.ca --- doc/Xserver-spec.xml |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/Xserver-spec.xml

[PATCH xserver 3/3] Xserver-spec: use appropriate copyright markup

2011-09-30 Thread Gaetan Nadon
Use docbook copyright markup for year and holder. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Gaetan Nadon mems...@videotron.ca --- doc/Xserver-spec.xml |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/doc/Xserver-spec.xml b/doc/Xserver-spec.xml

[PATCH xserver 2/3] Xserver-spec: re-order markup to follow outpout order

2011-09-30 Thread Gaetan Nadon
No content change, no layout/ordering change. It is easier to find title at the top. Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Gaetan Nadon mems...@videotron.ca --- doc/Xserver-spec.xml | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-)

[PULL] Add a 'wscons' autoconf mechanism to configure input devices on BSD

2011-09-30 Thread Matthieu Herrb
Hi, This change has been acked by Peter. The following changes since commit f54852edc35a2831a4cd91906188101ea19904e1: Add a 'wscons' autoconf mechanism to configure input devices on BSD. (2011-09-30 10:10:32 +0200) are available in the git repository at:

[PATCH xserver] record: Prevent out of bounds access when recording a reply.

2011-09-30 Thread Rami Ylimäki
Any pad bytes in replies are written to the client from a zeroed array. However, record extension tries to incorrectly access the pad bytes from the end of reply data. Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi --- include/os.h|3

[resend PATCH] sdksyms.sh may not be executable.

2011-09-30 Thread Matthieu Herrb
Use $(SHELL) to run it. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- hw/xfree86/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am index e3ef14f..4f08772 100644 --- a/hw/xfree86/Makefile.am +++

Re: [resend PATCH] sdksyms.sh may not be executable.

2011-09-30 Thread Gaetan Nadon
On Fri, 2011-09-30 at 14:36 +0200, Matthieu Herrb wrote: Use $(SHELL) to run it. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- hw/xfree86/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am

Re: [RFC] Xdummy standalone binary or -dummy switch

2011-09-30 Thread Michal Suchanek
On 30 September 2011 08:45, Antoine Martin anto...@nagafix.co.uk wrote: I guess distributors will then have to ship two copies of /usr/bin/Xorg, one that is suid-root and one that isn't? (until we can get rid of the suid one entirely, one day) I think Debian runs Xorg through suid wrapper,

Re: [resend PATCH] sdksyms.sh may not be executable.

2011-09-30 Thread Matthieu Herrb
On Fri, Sep 30, 2011 at 09:25:09AM -0400, Gaetan Nadon wrote: On Fri, 2011-09-30 at 14:36 +0200, Matthieu Herrb wrote: Use $(SHELL) to run it. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- hw/xfree86/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] dix: add valuator_mask_fetch_double()

2011-09-30 Thread Chase Douglas
On 09/29/2011 09:29 PM, Peter Hutterer wrote: Using this call simplifies callers that don't know if the mask bit is set. Before: if (valuator_mask_isset(mask, valnum)) value = valuator_mask_get_double(mask, valnum)); else value = someothervalue; Now: if

Re: [RFC] Xdummy standalone binary or -dummy switch

2011-09-30 Thread Jamey Sharp
On 9/29/11, Antoine Martin anto...@nagafix.co.uk wrote: OK, I've looked for at all the places that use getuid or getuid, and found: * os-support/* some checks for euid!=0 for console stuff / KeepTTY, which I have left alone * parser/write.c also left alone for now - I can look into it too if

Re: [RFC] Xdummy standalone binary or -dummy switch

2011-09-30 Thread Alan Coopersmith
if ( (geteuid() != getuid()) ) { It's not that simple to check for elevated privs in a world with saved setids and other forms of privilege manipulation - issetugid() is useful if it's available - for instance see: http://cgit.freedesktop.org/xorg/lib/libX11/tree/src/xlibi18n/lcFile.c#n234 --

Re: [PATCH] dix: add valuator_mask_fetch_double()

2011-09-30 Thread Daniel Stone
Hi, On 30 September 2011 17:18, Chase Douglas chase.doug...@canonical.com wrote: On 09/29/2011 09:29 PM, Peter Hutterer wrote: Using this call simplifies callers that don't know if the mask bit is set. Before:   if (valuator_mask_isset(mask, valnum))     value =

Re: [PATCH] dix: add valuator_mask_fetch_double()

2011-09-30 Thread Chase Douglas
On 09/30/2011 03:55 PM, Daniel Stone wrote: Hi, On 30 September 2011 17:18, Chase Douglas chase.doug...@canonical.com wrote: On 09/29/2011 09:29 PM, Peter Hutterer wrote: Using this call simplifies callers that don't know if the mask bit is set. Before: if (valuator_mask_isset(mask,

Re: [PATCH] dix: add valuator_mask_fetch_double()

2011-09-30 Thread Daniel Stone
Hi, On 1 October 2011 00:32, Chase Douglas chase.doug...@canonical.com wrote: On 09/30/2011 04:07 PM, Daniel Stone wrote: e.g.: double valuator_mask_fetch_double(struct valuator_mask *mask, int index) {     if (valuator_mask_isset(mask, index)         return valuator_mask_get_double(mask,