Re: [PATCH] input: fix mouse wheel support for DGA clients

2012-05-23 Thread Peter Hutterer
On Mon, May 21, 2012 at 09:39:43PM +0200, Marcin Slusarz wrote: On Mon, May 21, 2012 at 05:05:45PM +1000, Peter Hutterer wrote: On Mon, May 21, 2012 at 01:16:40AM +0200, Marcin Slusarz wrote: xf86-input-evdev (since smooth scrolling support was added) can send mouse motion and wheel

[PATCH] prevent X crash on pressing multimedia buttons, again

2012-05-23 Thread Michal Suchanek
Hello, So it's there again on 1.12 branch. Something dereferences valuator without checking it exists. Attaching patch Thanks Michal 0001-Fix-yet-another-crash-in-pointer-event-queuing.patch Description: Binary data ___ xorg-devel@lists.x.org:

Re: lack of reviewers

2012-05-23 Thread Michal Suchanek
On 23 May 2012 06:34, Peter Hutterer peter.hutte...@who-t.net wrote: On 18/05/12 21:17 , Michal Suchanek wrote: On 18 May 2012 12:40, Peter Huttererpeter.hutte...@who-t.net  wrote: On 18/05/12 19:26 , Michal Suchanek wrote: On 18 May 2012 01:14, Peter Huttererpeter.hutte...@who-t.net    

[PATCH 3/6] xf86: make xf86DeleteScreen take a ScrnInfoPtr

2012-05-23 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com stop passing indices into this function. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/common/xf86.h |2 +- hw/xfree86/common/xf86Bus.c|2 +- hw/xfree86/common/xf86Helper.c | 10 -- hw/xfree86/common/xf86Init.c |

API changes, one rereview and a few misc ones

2012-05-23 Thread Dave Airlie
Hi guys, the first patch is a repost dealing with a suggestion from ajax that we really didn't need the block/wakeupData pointers. The next 4 are minor API changes the drop some other scrnIndex, the dix one is a probably not used in anywhere outside the dix itself, the final patch just adds a

[PATCH 2/6] xf86: fix xf86IsScreenPrimary interface to take a pScrn (API/ABI)

2012-05-23 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/common/xf86.h |2 +- hw/xfree86/common/xf86Helper.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/common/xf86.h b/hw/xfree86/common/xf86.h index

[PATCH 1/6] xserver: convert block/wakeup handlers to passing ScreenPtr (ABI/API) (v2)

2012-05-23 Thread Dave Airlie
Instead of passing an index, pass the actual ScreenPtr. This allows more moving towards not abusing xf86Screens + screenInfo. v2: drop the blockData/wakeupData args as per ajax's suggestion. Signed-off-by: Dave Airlie airl...@redhat.com --- composite/compalloc.c |5 ++---

[PATCH 6/6] xf86: add a define to denote the new non-index interfaces are being used

2012-05-23 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This can be used by drivers to provide compatible APIs. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/common/xf86.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86.h b/hw/xfree86/common/xf86.h

[PATCH 4/6] xf86/xv: remove scrnIndexfrom xf86FindXvOptions.

2012-05-23 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Move this interface to taking an ScrnInfoPtr. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/common/xf86.h |2 +- hw/xfree86/common/xf86Helper.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 5/6] dix: make Create/Free scratch pixmaps take a ScreenPtr

2012-05-23 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com While technically an API/ABI change I doubt anyone uses it, but it helps in splitting screens up. Signed-off-by: Dave Airlie airl...@redhat.com --- dix/main.c |4 ++-- dix/pixmap.c | 10 +- include/pixmap.h |4 ++-- 3 files

[PATCH] dix/gc: consolidate GC object creation in one place

2012-05-23 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com The standard GC create and scratch GC create were 90% the same really, and I have a need in the future for creating GC objects without the other bits, so wanted to avoid a third copy. Signed-off-by: Dave Airlie airl...@redhat.com --- dix/gc.c | 108

Re: [PATCH 2/6] xf86: fix xf86IsScreenPrimary interface to take a pScrn (API/ABI)

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: -xf86IsScreenPrimary(int scrnIndex); +xf86IsScreenPrimary(ScrnInfoPtr pScrn); Reviewed-by: Keith Packard kei...@keithp.com (Are there still drivers using this API?) -- keith.pack...@intel.com pgpzc7215aFkv.pgp Description: PGP signature

Re: [PATCH 1/6] xserver: convert block/wakeup handlers to passing ScreenPtr (ABI/API) (v2)

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Instead of passing an index, pass the actual ScreenPtr. This allows more moving towards not abusing xf86Screens + screenInfo. v2: drop the blockData/wakeupData args as per ajax's suggestion. Reviewed-by: Keith Packard kei...@keithp.com (I wonder if we

Re: [PATCH 3/6] xf86: make xf86DeleteScreen take a ScrnInfoPtr

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com stop passing indices into this function. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgp9A4oqSvDvg.pgp Description: PGP signature

Re: [PATCH 4/6] xf86/xv: remove scrnIndexfrom xf86FindXvOptions.

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: Move this interface to taking an ScrnInfoPtr. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgphoe920Ym5Q.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 5/6] dix: make Create/Free scratch pixmaps take a ScreenPtr

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com While technically an API/ABI change I doubt anyone uses it, but it helps in splitting screens up. Reviewed-by: Keith Packard kei...@keithp.com Bool -CreateScratchPixmapsForScreen(int scrnum)

Re: [PATCH 6/6] xf86: add a define to denote the new non-index interfaces are being used

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com This can be used by drivers to provide compatible APIs. (bikeshed -- the name isn't very descriptive, but meh) Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpHSFq8Ai7XX.pgp Description:

Re: [PATCH] dix/gc: consolidate GC object creation in one place

2012-05-23 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: The standard GC create and scratch GC create were 90% the same really, and I have a need in the future for creating GC objects without the other bits, so wanted to avoid a third copy. Reviewed-by: Keith Packard kei...@keithp.com --

[PATCH 2/2] glproto: Add define for GLX_EXT_create_context_es2_profile

2012-05-23 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- glxtokens.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/glxtokens.h b/glxtokens.h index cc4bca3..5e6bbea 100644 --- a/glxtokens.h +++ b/glxtokens.h @@ -286,6 +286,7

[PATCH 1/2] glproto: Fix typo in name of GLX_LOSE_CONTEXT_ON_RESET_ARB

2012-05-23 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- glxtokens.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glxtokens.h b/glxtokens.h index 1ed2fd3..cc4bca3 100644 --- a/glxtokens.h +++ b/glxtokens.h @@ -304,7 +304,7

[PATCH] glx: Revert part of 9838b703

2012-05-23 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The server does not want GL extension prototypes. It never links with anything that could possibly provide implementations of these functions. It *is* the provide, and it does not provde these symbols. All this does is create hundreds of warnings

Re: [PATCH] cvt: add -i/--interlaced to documentation

2012-05-23 Thread Alan Coopersmith
On 05/20/12 04:54 AM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com cvt.c currently says: /* * I'm not documenting --interlaced for obvious reasons, even though I did * implement it. I also can't deny having looked at gtf here. */ Are those reasons no longer valid? (Sadly

Re: [PATCH 2/2] glproto: Add define for GLX_EXT_create_context_es2_profile

2012-05-23 Thread Matt Turner
On Wed, May 23, 2012 at 4:51 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com ---  glxtokens.h |    2 ++  1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/glxtokens.h b/glxtokens.h

Re: [PATCH 1/2] glproto: Fix typo in name of GLX_LOSE_CONTEXT_ON_RESET_ARB

2012-05-23 Thread Matt Turner
On Wed, May 23, 2012 at 4:51 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com ---  glxtokens.h |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glxtokens.h b/glxtokens.h

Re: [PATCH] prevent X crash on pressing multimedia buttons, again

2012-05-23 Thread Peter Hutterer
On Wed, May 23, 2012 at 11:27:51AM +0200, Michal Suchanek wrote: From b824be59ebf7e9847e9e851eeb6e6c3d80c9a764 Mon Sep 17 00:00:00 2001 From: Michal Suchanek hramr...@gmail.com Date: Wed, 23 May 2012 11:22:05 +0200 Subject: [PATCH] Fix yet another crash in pointer event queuing.

[PATCH xorg-gtest] Update source files to use new headers

2012-05-23 Thread Peter Hutterer
introduced in e1c010f23272e61c28c73aa603b477ba6fbae875 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- examples/xorg-gtest-example.cpp |2 +- src/device.cpp |2 +- src/environment.cpp |4 ++-- src/process.cpp |2 +-

Re: [PATCH 2/2 xorg-gtest] Namespace xorg-gtest header filenames

2012-05-23 Thread Peter Hutterer
On Mon, May 21, 2012 at 10:54:08AM -0700, Chase Douglas wrote: On 05/20/2012 02:55 PM, Peter Hutterer wrote: On Fri, May 18, 2012 at 01:23:32PM -0700, Chase Douglas wrote: Due to the default automake compilation flags including -I. -I.., it is possible to pick up an xorg-gtest header like

Re: [PATCH v2 2/2] End physically active touches when device is disabled

2012-05-23 Thread Peter Hutterer
On Fri, May 18, 2012 at 02:05:02PM -0700, Chase Douglas wrote: Otherwise: * We can't end the touches while device is disabled * New touches after enabling the device may erroneously be mapped to old logical touches Signed-off-by: Chase Douglas chase.doug...@canonical.com Reviewed-by:

Re: [PATCH v3 1/3] Add xorg-gtest integration test framework

2012-05-23 Thread Peter Hutterer
pulled the branch you sent me that contained (amongst others) this patchset. On Fri, May 18, 2012 at 02:02:04PM -0700, Chase Douglas wrote: Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Changes since v2: * Refreshed xorg-gtest.m4 and Makefile-xorg-gtest.am for xorg-gtest

[PATCH] Xext: include dix-config.h

2012-05-23 Thread Peter Hutterer
silences In file included from ../include/misc.h:111:0, from hashtable.c:2: ./include/os.h:559:1: warning: redundant redeclaration of 'strndup' [-Wredundant-decls] Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/hashtable.c |4 1 file changed, 4 insertions(+) diff

Re: [PATCH] Xext: include dix-config.h

2012-05-23 Thread Alan Coopersmith
On 05/23/12 08:34 PM, Peter Hutterer wrote: silences In file included from ../include/misc.h:111:0, from hashtable.c:2: ./include/os.h:559:1: warning: redundant redeclaration of 'strndup' [-Wredundant-decls] Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/hashtable.c |

Re: [PATCH v4 07/16] Print backtrace in a signal-safe manner

2012-05-23 Thread Peter Hutterer
On Mon, May 14, 2012 at 02:14:28PM -0700, Chase Douglas wrote: Backtraces are often printed in signal context, such as when a segfault occurs. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- os/backtrace.c | 49 + 1 file

Re: [PATCH v4 05/16] Add LogMessageVerbSigSafe() for logging messages while in signal context

2012-05-23 Thread Peter Hutterer
On Mon, May 14, 2012 at 02:14:26PM -0700, Chase Douglas wrote: Signed-off-by: Chase Douglas chase.doug...@canonical.com --- Changes since v3: * Rebased onto master - Log writing now occurs in LogSWrite, which is now signal-safe * Removed timestamp logging, it's not safe to get the current

Re: [PATCH 0/2] fix private leaks on Xvfb

2012-05-23 Thread Peter Hutterer
On Fri, May 11, 2012 at 09:31:48PM +0200, Julien Cristau wrote: dixResetPrivates complains about 4 device privates and 1 pixmap private still allocated at Xvfb reset. Seems like these are the two XTEST and two Xvfb slaves, and the screen pixmap allocated by miCreateScreenResources(). both