Re: [PATCH 0/3] Implement randr 1.4 events.

2013-10-08 Thread Dave Airlie
On Mon, Oct 7, 2013 at 8:26 PM, Michal Srb m...@suse.com wrote: In order to get support for providers in GUI tools, xserver has to send the new randr 1.4 events and some older events (RROutputChangeNotify and RRCrtcChangeNotify) have to be send when they happen on output provider screen.

[PATCH] configure.ac: Include missing proto declarations in SDK_REQUIRED_MODULES

2013-10-08 Thread Emil Velikov
Commits a1d41e311c21e, 7d859bd87834d 3ed2c6e11298c made extinit.h require the XF86 Big Font, XRes ScrnSaver proto headers, but failed to add them to the SDK_REQUIRED_MODULES so pkg-config would find them for driver builds. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Daniel

Re: glamor-egl, parameter checking

2013-10-08 Thread Zhigang Gong
On Wed, Sep 25, 2013 at 06:29:07PM -0700, Seth Arnold wrote: Hello, I recently gave glamor-egl a very quick audit, and found some issues that I wanted to run past someone who would know the code better than I do. - _glamor_poly_lines(): - unchecked malloc() return value - if n = 1 is

RE: glamor: Changes to 'master'

2013-10-08 Thread Zhigang Gong
Don't know why I wrote the wrong bugzilla number in the commit log. The correct one is as below, sorry for that. https://bugs.freedesktop.org/show_bug.cgi?id=69683 You can find in the log, I proposed how to fix the bug, and Raul help to test the idea and found it can fix the bug for him.

Re: [PATCH 0/3] Implement randr 1.4 events.

2013-10-08 Thread Guillem Jover
Hi! On Mon, 2013-10-07 at 13:26:30 +0300, Michal Srb wrote: […] 6 files changed, 143 insertions(+) mode change 100644 = 100755 hw/xfree86/common/xf86platformBus.c mode change 100644 = 100755 randr/randr.c mode change 100644 = 100755 randr/randrstr.h mode change 100644 = 100755

[PATCH modular] build.sh: add libevdev as required by evdev input driver

2013-10-08 Thread Gaetan Nadon
This is a wrapper library for evdev devices. It is a dependency for xf86-input-evdev and more modules later. Only recent kernel versions are supported and there is currently no check at configuration time, so you just get compile errors. Building from tar file will not work at the moment as the

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Ian Romanick
On 10/02/2013 02:51 PM, Adam Jackson wrote: I broke this, back in: commit a48dadc98a28c969741979b70b7a639f24f4cbbd Author: Adam Jackson a...@redhat.com Date: Mon Mar 21 11:59:29 2011 -0400 glx: Reimplement context tags In that, I changed the glx client state to not

Re: [PATCH 1/4] glx: Remove current context cache

2013-10-08 Thread Ian Romanick
Patches 1, 3, and 4 are Reviewed-by: Ian Romanick ian.d.roman...@intel.com I sent out separate comments about 2. On 10/02/2013 02:51 PM, Adam Jackson wrote: This is something of a pessimization, since now we'll call the provider's MakeCurrent hook more often. But that's correct, since the

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Mouse
--- a/glx/createcontext.c +++ b/glx/createcontext.c @@ -320,7 +320,7 @@ __glXDisp_CreateContextAttribsARB(__GLXclientState * cl, GLbyte * pc) ctx-id = req-context; ctx-share_id = req-shareList; ctx-idExists = True; -ctx-isCurrent = False; +ctx-currentClient =

Re: glamor-egl, parameter checking

2013-10-08 Thread Seth Arnold
On Tue, Oct 08, 2013 at 04:22:30PM +0800, Zhigang Gong wrote: This function is to draw lines with at lest two points. So n = 1 is not a realisitic input. Hello, welcome back from your time off. Thanks so much for giving my comments a look, I appreciate the time you've put into it. Thanks,

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Ian Romanick
On 10/08/2013 10:19 AM, Mouse wrote: --- a/glx/createcontext.c +++ b/glx/createcontext.c @@ -320,7 +320,7 @@ __glXDisp_CreateContextAttribsARB(__GLXclientState * cl, GLbyte * pc) ctx-id = req-context; ctx-share_id = req-shareList; ctx-idExists = True; -ctx-isCurrent =

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Mouse
-ctx-isCurrent = False; +ctx-currentClient = False; Should this maybe be 0 instead of False? Good catch. It's just luck that False is #defined as 0. :) It should, of course, be NULL. Well, I'd actually disagree; I think NULL should never be used - see my blah post of 2009-10-09

Re: [PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

2013-10-08 Thread Daniel Stone
Hi, On 8 October 2013 19:22, Mouse mo...@rodents-montreal.org wrote: Good catch. It's just luck that False is #defined as 0. :) It should, of course, be NULL. Well, I'd actually disagree; I think NULL should never be used - see my blah post of 2009-10-09

[PATCH] Use new pixman_glyph_cache_t API that will be in pixman 0.28.0

2013-10-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com This new API allows glyphs to be cached in a data structure in pixman, and entire glyph strings to be composited in one go. Also bump pixman dependency to 0.27.2. Results from the cairo peformance test suite running against Xvfb with a screen size

[PATCH] xf86AddBusDeviceToConfigure(): Store device in DevToConfig[i].pVideo

2013-10-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com After fc3ab84d the pVideo field in DevToConfig[i] is no longer initialized, so it's always NULL. This causes the duplicate finding algorithm in the beginning of the function to not work anymore as it is based on this field. The symptom of this bug is

Re: [PATCH modular] build.sh: add libevdev as required by evdev input driver

2013-10-08 Thread Peter Hutterer
On Tue, Oct 08, 2013 at 10:06:41AM -0400, Gaetan Nadon wrote: This is a wrapper library for evdev devices. It is a dependency for xf86-input-evdev and more modules later. Only recent kernel versions are supported and there is currently no check at configuration time, so you just get compile

Re: [PATCH 2/2] damageext: Xineramify (v4)

2013-10-08 Thread Aaron Plattner
On 10/02/2013 08:56 AM, Adam Jackson wrote: v4: Use the new PostDispatchCallback, to avoid recursing through FlushCallback - WriteToClient - FlushCallback - ... Screen 0 holds the real damage for all drawable types; the window report hooks for other screens look up screen 0 and pile on.

Re: [PATCH] Use new pixman_glyph_cache_t API that will be in pixman 0.28.0

2013-10-08 Thread Søren Sandmann
Søren Sandmann sandm...@cs.au.dk writes: From: Søren Sandmann Pedersen s...@redhat.com Please ignore this old patch, which was sent by mistake Soren ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH] Avoid use-after-free in dix/dixfonts.c: doImageText() [CVE-2013-4396]

2013-10-08 Thread Alan Coopersmith
Save a pointer to the passed in closure structure before copying it and overwriting the *c pointer to point to our copy instead of the original. If we hit an error, once we free(c), reset c to point to the original structure before jumping to the cleanup code that references *c. Since one of the

Re: [PATCH 2/2] damageext: Xineramify (v4)

2013-10-08 Thread Aaron Plattner
On 10/08/2013 03:28 PM, Aaron Plattner wrote: On 10/02/2013 08:56 AM, Adam Jackson wrote: v4: Use the new PostDispatchCallback, to avoid recursing through FlushCallback - WriteToClient - FlushCallback - ... Screen 0 holds the real damage for all drawable types; the window report hooks for