Re: [PATCH v2] OS/ACPI: Make socket to acpid is non-blocking

2013-11-15 Thread Egbert Eich
On Thu, Nov 14, 2013 at 01:20:44PM +0900, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: static CARD32 lnxACPICheckTimer(OsTimerPtr timer, CARD32 now, pointer arg) { +struct timeval timeval = { 0, 0 }; DebugF(ACPI: trying to reopen\n); -if

Re: Fwd: [oss-security] I miss LSD, slides, paper and tools relating to finding UNIX system level vulnerabilities (as given at 44CON)

2013-11-15 Thread Mark Kettenis
Date: Fri, 15 Nov 2013 02:16:19 -0500 (EST) From: Mouse mo...@rodents-montreal.org My understanding is that the new code, by passing shared memory through fd is a lot better since [...] In those respects, yes. But it's worse in that it requires write access to a filesystem - a

[PATCH libXrender] Fix request length calculation for XRenderCompositeText32

2013-11-15 Thread Clemens Eisserer
Hi, Request length calculation inside XRenderCompositeText32 is broken for the case where the number of glyphs fits exactky inside the last xGlyphElt. In XRenderCompositeText8 and XRenderCompositeText16 this case is handled properly, somehow the -1 got missing in XRenderCompositeText32.

Re: [PATCH v2] OS/ACPI: Make socket to acpid is non-blocking

2013-11-15 Thread Egbert Eich
On Fri, Nov 15, 2013 at 11:25:49AM +0100, Egbert Eich wrote: On Thu, Nov 14, 2013 at 01:20:44PM +0900, Keith Packard wrote: Egbert Eich e...@freedesktop.org writes: static CARD32 lnxACPICheckTimer(OsTimerPtr timer, CARD32 now, pointer arg) { +struct timeval timeval = { 0,

Re: Fwd: [oss-security] I miss LSD, slides, paper and tools relating to finding UNIX system level vulnerabilities (as given at 44CON)

2013-11-15 Thread Dr. David Alan Gilbert
* Alan Coopersmith (alan.coopersm...@oracle.com) wrote: As we expand our use of shared memory via the new extensions, we should try to make sure we're not making more problems along the lines of those mentioned in the presentation linked below associated whitepaper published at:

[PATCH v3] OS/ACPI: Make socket to acpid is non-blocking

2013-11-15 Thread Egbert Eich
If a connect to the acpid socket is delayed connect will hang stalling the Xserver. To avoid this this create a non-blocking socket. If connect returns EINPROGRESS use select() and getsockopt() to check for completion of the connect request. Use a different timeout to select() wether we connect

Re: Fwd: [oss-security] I miss LSD, slides, paper and tools relating to finding UNIX system level vulnerabilities (as given at 44CON)

2013-11-15 Thread Mouse
My understanding is that the new code, by passing shared memory through fd is a lot better since [...] In those respects, yes. But it's worse in that it requires write access to a filesystem - a filesystem which supports mmap - with space enough to hold the shared memory segments, which

Self introduction Hans de Goede

2013-11-15 Thread Hans de Goede
Hi All, My name is Hans de Goede, and I'm active as a FOSS contributor / developer since 1997. Recently I've mainly been working on hwmon kernel drivers, usb webcam kernel drivers and userspace support libs, usb emulation and redirection in qemu, libusb and usbdevfs. I've been working for

Re: [PATCH] hw/xfree86: Make strings in DriverRec and ScrnInfoRec const

2013-11-15 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: This avoids compiler warnings when initializing with string constants. Signed-off-by: Keith Packard kei...@keithp.com I've apparently misplaced my patch that did the same thing. Reviewed-by: Eric Anholt e...@anholt.net pgpf7MVcX5gyJ.pgp Description:

Re: modular: Changes to 'master'

2013-11-15 Thread Rob Clark
Well, to be fair, a number of the DDX drivers don't build on ARM. I remove them locally in my in my xorg.modules. I don't claim to be a jhbuild expert, but it is probably easier to have everything in xorg.modules, and let people remove the depends for what they don't want to build. It seems

Re: modular: Changes to 'master'

2013-11-15 Thread Jon TURNEY
On 15/11/2013 19:27, Rob Clark wrote: Well, to be fair, a number of the DDX drivers don't build on ARM. I remove them locally in my in my xorg.modules. I don't claim to be a jhbuild expert, but it is probably easier to have everything in xorg.modules, and let people remove the depends for

Re: modular: Changes to 'master'

2013-11-15 Thread Gaetan Nadon
On 13-11-15 02:32 PM, Jon TURNEY wrote: On 15/11/2013 19:27, Rob Clark wrote: Well, to be fair, a number of the DDX drivers don't build on ARM. I remove them locally in my in my xorg.modules. I don't claim to be a jhbuild expert, but it is probably easier to have everything in xorg.modules,

[PATCH] xfree86: Prefer fbdev to vesa

2013-11-15 Thread Adam Jackson
On UEFI machines you'd prefer fbdev to grab efifb instead of vesa trying to initialize and failing in a way we can't unwind from. On BIOS machines this is harmless: either there is an fbdev driver and it'll probably be more capable, or there's not and vesa will kick in anyway. Signed-off-by:

Re: [PATCH] xfree86: Prefer fbdev to vesa

2013-11-15 Thread Alex Deucher
On Fri, Nov 15, 2013 at 3:15 PM, Adam Jackson a...@redhat.com wrote: On UEFI machines you'd prefer fbdev to grab efifb instead of vesa trying to initialize and failing in a way we can't unwind from. On BIOS machines this is harmless: either there is an fbdev driver and it'll probably be more

Re: [PATCH] xfree86: Prefer fbdev to vesa

2013-11-15 Thread Eric Anholt
Adam Jackson a...@redhat.com writes: On UEFI machines you'd prefer fbdev to grab efifb instead of vesa trying to initialize and failing in a way we can't unwind from. On BIOS machines this is harmless: either there is an fbdev driver and it'll probably be more capable, or there's not and

[PATCH 2/3] configure.ac: Require libpciaccess for platform bus support

2013-11-15 Thread Connor Behan
There is currently no reason to build with --enable-config-udev-kms and --disable-pciaccess but anyone who tries this should know that the build will fail. Signed-off-by: Connor Behan connor.be...@gmail.com --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac

[PATCH 1/3] configure.ac: Add whitespace near PCI configuration

2013-11-15 Thread Connor Behan
Signed-off-by: Connor Behan connor.be...@gmail.com --- configure.ac | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/configure.ac b/configure.ac index 1e6f813..e8597a7 100644 --- a/configure.ac +++ b/configure.ac @@ -1801,24 +1801,23 @@ if

[PATCH 3/3] configure.ac: Require libpciaccess for int10

2013-11-15 Thread Connor Behan
A --disable-pciaccess build will fail with an int10 module other than stub. Signed-off-by: Connor Behan connor.be...@gmail.com --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 5e621e0..a843770 100644 --- a/configure.ac +++ b/configure.ac

[PATCH:libX11] Don't need to link libX11-xcb against libX11

2013-11-15 Thread Alan Coopersmith
libX11-xcb only accesses data structures defined in X11 headers, it doesn't call any functions or reference any global variables in libX11 itself. (Seems to have been left from previous XCL implementation.) Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/Makefile.am |1 -

Re: [PATCH:libX11] Don't need to link libX11-xcb against libX11

2013-11-15 Thread Thomas Klausner
On Fri, Nov 15, 2013 at 06:03:25PM -0800, Alan Coopersmith wrote: libX11-xcb only accesses data structures defined in X11 headers, it doesn't call any functions or reference any global variables in libX11 itself. (Seems to have been left from previous XCL implementation.) You should bump the

[PATCH:appres 01/17] Print which option was in error along with usage message

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- appres.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/appres.c b/appres.c index 2f43d2d..fad870f 100644 --- a/appres.c +++ b/appres.c @@ -156,8 +156,11 @@ main (int argc, char *argv[])

[PATCH:fstobdf 09/17] Print error and usage on invalid arg, instead of ignoring it

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fstobdf.c |5 + 1 file changed, 5 insertions(+) diff --git a/fstobdf.c b/fstobdf.c index 5fe4816..255d82e 100644 --- a/fstobdf.c +++ b/fstobdf.c @@ -109,6 +109,11 @@ main(int argc, char *argv[]) printf(%s\n,

[PATCH:fstobdf 08/17] Add -version option to print version

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fstobdf.c | 14 -- man/fstobdf.man |6 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/fstobdf.c b/fstobdf.c index bcdffbc..5fe4816 100644 --- a/fstobdf.c +++ b/fstobdf.c @@ -43,6 +43,10

[PATCH:iceauth 11/17] Fix noexistent typo in error message

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- process.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/process.c b/process.c index 97bcfa9..09cb7ef 100644 --- a/process.c +++ b/process.c @@ -1060,7 +1060,7 @@ static int do_help ( if (n == 0) {

[PATCH:fstobdf 07/17] Print which option was in error along with usage message

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- fstobdf.c| 19 ++- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index 1dbf55a..0ef434b 100644 --- a/configure.ac +++ b/configure.ac @@

[PATCH:fslsfonts 05/17] Print which option was in error along with usage message

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- fslsfonts.c | 35 --- 2 files changed, 25 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index e828085..58a4607 100644 --- a/configure.ac +++

[PATCH:mkfontscale 14/17] Add missing newline to usage output

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- mkfontscale.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfontscale.c b/mkfontscale.c index a67f283..1194145 100644 --- a/mkfontscale.c +++ b/mkfontscale.c @@ -118,7 +118,7 @@ usage(void) {

[PATCH:bdftopcf 02/17] Print which option was in error along with usage message

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- bdftopcf.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/bdftopcf.c b/bdftopcf.c index 1b24aa1..2208fee 100644 --- a/bdftopcf.c +++ b/bdftopcf.c @@ -145,6 +145,8 @@ main(int argc, char *argv[]) else {

[PATCH:iceauth 10/17] Actually print command list in usage message

2013-11-15 Thread Alan Coopersmith
The xauth routine this was based on took three arguments: a file pointer, a command name, and a prefix. If a command name is given, prints help on that command, else if it's null, prints help on all commands. The iceauth version has only two arguments: file pointer command name. It was being

[PATCH 00/17] CLI option handling updates for various apps

2013-11-15 Thread Alan Coopersmith
One of the tasks I've been doing at work is looking at what it will take to bring our software into compliance with the latest accessibility standards, specifically http://www.w3.org/TR/wcag2ict/ which seems to be one of the standards which many countries will be adopting in their acessibility

[PATCH:bitmap 03/17] Print which option was in error along with usage message

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- atobm.c | 26 +++--- bmtoa.c |8 +++- configure.ac |2 +- 3 files changed, 27 insertions(+), 9 deletions(-) diff --git a/atobm.c b/atobm.c index 040fecb..ef6da7e 100644 --- a/atobm.c +++

[PATCH:fstobdf 06/17] Spell out -server in usage message to match man page

2013-11-15 Thread Alan Coopersmith
Code matches -s*, so either form works, but better to have them agree. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fstobdf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fstobdf.c b/fstobdf.c index 8d029a5..db168c9 100644 --- a/fstobdf.c +++

[PATCH:fslsfonts 04/17] Add -version option to print version

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fslsfonts.c |9 + man/fslsfonts.man |3 +++ 2 files changed, 12 insertions(+) diff --git a/fslsfonts.c b/fslsfonts.c index 6ff6a2d..9de741e 100644 --- a/fslsfonts.c +++ b/fslsfonts.c @@ -43,6 +43,10 @@ in this

[PATCH:iceauth 13/17] Print which option was in error along with usage message

2013-11-15 Thread Alan Coopersmith
Special case -u, since it's documented as printing the usage message (sort of like an ancient --help), so shouldn't be called unrecognized. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- iceauth.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff

[PATCH:mkfontscale 16/17] Make usage() always exit(1)

2013-11-15 Thread Alan Coopersmith
Avoid duplicating exit(1) calls after every single call to usage() Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- mkfontscale.c | 12 +++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index

[PATCH:mkfontscale 15/17] Add -v flag to print program version

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- man/mkfontscale.man |5 + mkfontscale.c |5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/man/mkfontscale.man b/man/mkfontscale.man index 4aa88ab..cb18458 100644 --- a/man/mkfontscale.man +++

Re: [PATCH:libX11] Don't need to link libX11-xcb against libX11

2013-11-15 Thread Alan Coopersmith
On 11/15/13 06:18 PM, Thomas Klausner wrote: On Fri, Nov 15, 2013 at 06:03:25PM -0800, Alan Coopersmith wrote: libX11-xcb only accesses data structures defined in X11 headers, it doesn't call any functions or reference any global variables in libX11 itself. (Seems to have been left from

[PATCH:iceauth 12/17] Add -V flag to print version

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- iceauth.c |4 man/iceauth.man |2 ++ 2 files changed, 6 insertions(+) diff --git a/iceauth.c b/iceauth.c index e729ed5..c1688c0 100644 --- a/iceauth.c +++ b/iceauth.c @@ -63,6 +63,7 @@ usage (void) -q

[PATCH:mkfontscale 17/17] Print which option was in error along with usage message

2013-11-15 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- mkfontscale.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/mkfontscale.c b/mkfontscale.c index d27bb8d..a494f93 100644 --- a/mkfontscale.c +++ b/mkfontscale.c @@ -113,11 +113,12 @@

Re: [PATCH] xfree86: Prefer fbdev to vesa

2013-11-15 Thread Dave Airlie
On Sat, Nov 16, 2013 at 6:15 AM, Adam Jackson a...@redhat.com wrote: On UEFI machines you'd prefer fbdev to grab efifb instead of vesa trying to initialize and failing in a way we can't unwind from. On BIOS machines this is harmless: either there is an fbdev driver and it'll probably be more

typo on dev doc

2013-11-15 Thread westlake
http://xorg.freedesktop.org/wiki/Development/Documentation/PointerAcceleration/ The AccelerationProfile [integer] subsection, -1 none for common courtesy isn't it supposed to be '0 none' ? :) (xinput --set-prop command doesn't warrant -1, but does so starting from 0) Not a high priority, and

[PATCH:xpr] Remove unneeded uses of math.h -lm

2013-11-15 Thread Alan Coopersmith
Can't see why they were ever needed. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Makefile.am |2 +- x2pmp.c |1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index c96f863..8b75b07 100644 --- a/Makefile.am +++