Re: [PATCH] Revert xkb: ProcesssPointerEvent must work on the VCP if it gets the VCP

2014-04-02 Thread Hans de Goede
Hi, On 04/02/2014 06:22 AM, Peter Hutterer wrote: This was the wrong fix to the problem, and it triggered a change in XKB behavior: previously a button event would unlock a latched modifier, now it doesn't anymore. https://bugs.freedesktop.org/show_bug.cgi?id=73155 Note that the new

Re: Xorg copyright infrigement

2014-04-02 Thread Mateusz Jończyk
Hello, W dniu 02.04.2014 07:53, Dave Airlie pisze: +/* + * Generate a CVT standard mode from HDisplay, VDisplay and VRefresh. + * + * These calculations are stolen from the CVT calculation spreadsheet written + * by Graham Loveridge. He seems to be claiming no copyright and there seems

Re: Xorg copyright infrigement

2014-04-02 Thread Mateusz Jończyk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 W dniu 02.04.2014 14:33, Mateusz Jończyk pisze: I will write to the email address mentioned in the spreadsheet. Let's see if it is active. Graham Loveridge is currently a Senior Vice President in Pixelworks:

[PATCH] input: Remove invalid bug checks.

2014-04-02 Thread Michal Srb
Commit 2f1aedcaed8fd99b823d451bf1fb02330c078f67 added several bug checks. Some of them are not correct. Checks in Init(Ptr|String|Bell|Led|Integer)FeedbackClassDeviceStruct verify that no feedback struct was set yet, but that is not required. If any feedback structs are already present, the

Re: [PATCH 05/21] glamor: SetWindowPixmap is not related to RENDER

2014-04-02 Thread Alexander E. Patrakov
02.04.2014 06:29, Keith Packard wrote: Move the configuration of screen-SetWindowPixmap out from under the Signed-off-by: Keith Packard kei...@keithp.com Looks like git has mangled the commit message by thinking that #ifdef at the beginning of the line (after the the) is a comment. ---

Re: [PATCH 05/21] glamor: SetWindowPixmap is not related to RENDER

2014-04-02 Thread Keith Packard
Alexander E. Patrakov patra...@gmail.com writes: 02.04.2014 06:29, Keith Packard wrote: Move the configuration of screen-SetWindowPixmap out from under the Signed-off-by: Keith Packard kei...@keithp.com Looks like git has mangled the commit message by thinking that #ifdef at the beginning

Re: [PATCH 2/8] glamor: the render Composite hook must call SourceValidate

2014-04-02 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: This call is required for correct operation of the Render extension, in particular it is necessary for software cursors and Composite to work correctly. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor_render.c | 4 1 file

Re: [PATCH 3/8] glamor: Stop calling eglMakeCurrent (.., EGL_NO_SURFACE)

2014-04-02 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: This eliminates a huge cost when using EGL. Signed-off-by: Keith Packard kei...@keithp.com It also, as far as I've heard, causes segfaults when you use indirect GLX. I never quite got my patchset for global GL context management finished (I think I

Re: [PATCH 4/8] glamor: SetWindowPixmap is not related to RENDER

2014-04-02 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Move the configuration of screen-SetWindowPixmap out from under the I think you accidentally some words Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 02/16] glamor: Compute supported GLSL version and save in screen private

2014-04-02 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: This currently computes the GLSL version in a fairly naïve fashion, and leaves that in the screen private for other users. This will let us update the version computation in one place later on. Signed-off-by: Keith Packard kei...@keithp.com ---

Re: [PATCH 04/16] glamor: Replace fallback preparation code

2014-04-02 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: These offer a simpler and more efficient means for temporarily transitioning to CPU-accessible memory for fallback implementations. diff --git a/glamor/glamor_prepare.c b/glamor/glamor_prepare.c new file mode 100644 index 000..97029f9 ---

Re: [PATCH 05/16] glamor: Add glamor_program based fill/set/get spans

2014-04-02 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: This accelerates spans operations using GPU-based geometry computation Signed-off-by: Keith Packard kei...@keithp.com +static Bool +glamor_fill_spans_gl(DrawablePtr drawable, + GCPtr gc, + int n, DDXPointPtr

Re: [PATCH 02/16] glamor: Compute supported GLSL version and save in screen private

2014-04-02 Thread Eric Anholt
Eric Anholt e...@anholt.net writes: Keith Packard kei...@keithp.com writes: This currently computes the GLSL version in a fairly naïve fashion, and leaves that in the screen private for other users. This will let us update the version computation in one place later on. Signed-off-by: Keith

Re: [PATCH 3/8] glamor: Stop calling eglMakeCurrent (.., EGL_NO_SURFACE)

2014-04-02 Thread Keith Packard
Eric Anholt e...@anholt.net writes: It also, as far as I've heard, causes segfaults when you use indirect GLX. I never quite got my patchset for global GL context management finished (I think I know what the remaining bug was now), but we probably shouldn't land this until that's done.

Re: [PATCH 2/8] glamor: the render Composite hook must call SourceValidate

2014-04-02 Thread Keith Packard
Eric Anholt e...@anholt.net writes: These two calls are also done by miComputeCompositeRegion, which is called very soon after this -- did you observe an actual bug that was fixed by this patch? No, I was just reviewing code and noticed that this call wasn't in the 'usual' spot. I'd forgotten

Re: [PATCH 4/8] glamor: SetWindowPixmap is not related to RENDER

2014-04-02 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Keith Packard kei...@keithp.com writes: Move the configuration of screen-SetWindowPixmap out from under the I think you accidentally some words I started the next line with '#ifdef'... I've fixed that locally -- keith.pack...@intel.com

Re: [PATCH 06/16] glamor: Add glamor_program based poly_fill_rect

2014-04-02 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: This accelerates poly_fill_rect using GPU-based geometry computation Signed-off-by: Keith Packard kei...@keithp.com I applied the same quads fix as for spans: diff --git a/glamor/glamor_rects.c b/glamor/glamor_rects.c index 8b50129..7731ede 100644 ---

Re: [PATCH 02/16] glamor: Compute supported GLSL version and save in screen private

2014-04-02 Thread Keith Packard
Eric Anholt e...@anholt.net writes: --- a/glamor/glamor_program.c +++ b/glamor/glamor_program.c @@ -45,9 +45,8 @@ use_tile(PixmapPtr pixmap, GCPtr gc, glamor_program *prog, void *arg) static const glamor_facet glamor_fill_tile = { .name = tile, -.version = 130, -.vs_exec

Re: [PATCH 02/16] glamor: Compute supported GLSL version and save in screen private

2014-04-02 Thread Keith Packard
Eric Anholt e...@anholt.net writes: did I say dropped? I've now separated it out to a new commit: Ok, thanks. -- keith.pack...@intel.com pgpLFD5ICYP1N.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 05/16] glamor: Add glamor_program based fill/set/get spans

2014-04-02 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Here's what I squashed in to fix it: Ok, that works. -wellipse500 goes from about 4k/sec before your patch, to ~8k/sec in the fallback loop, to ~100k/sec in desktop mode. We can speed up the ES path at some point. These glTexParameteri()s are

Re: [PATCH 06/16] glamor: Add glamor_program based poly_fill_rect

2014-04-02 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Keith Packard kei...@keithp.com writes: This accelerates poly_fill_rect using GPU-based geometry computation Signed-off-by: Keith Packard kei...@keithp.com I applied the same quads fix as for spans: Cool. I hope to never have a machine that has only

[PULL] Reviewed glamor changes

2014-04-02 Thread Eric Anholt
keithp was saying he was holding the merge window open for a few last bits of glamor and wayland stuff for 1.16. This is as far as I was able to review of keithp's code today. Note that there are a few squashes of bugfixes to keithp's code that I wrote and didn't get explicit acks on. I've also

Re: [PATCH 04/16] glamor: Replace fallback preparation code

2014-04-02 Thread Keith Packard
Eric Anholt e...@anholt.net writes: GLES2 only allows WRITE_ONLY in the glMapBuffer interface (and only when GL_OES_mapbuffer is available), which the old path avoided. I think your change just totally breaks fallbacks in gles2. So, in GLES2 mode, we just need to malloc memory and download

Re: [PATCH v3] xf86LogInit: log to XDG_DATA_HOME when not running as root

2014-04-02 Thread Peter Hutterer
On Tue, Apr 01, 2014 at 11:24:17AM +0200, Hans de Goede wrote: When no logfile was specified (xf86LogFileFrom == X_DEFAULT) and we're not running as root log to $XDG_DATA_HOME/xorg/Xorg.#.log as Xorg won't be able to log to the default /var/log/... when it is not running as root.

[PULL] XDG_DATA_DIR logging, build fixes, logind monitoring, accessibility revert...

2014-04-02 Thread Peter Hutterer
..and ponies, there's always bloody ponies. they're everywhere! The following changes since commit bda6fdc71c25b0c3f3747f445103a1995a5713f4: Merge remote-tracking branch 'whot/for-keith' (2014-03-25 16:06:03 -0700) are available in the git repository at:

Re: Re-send of patches

2014-04-02 Thread Michael Thayer
Hello, On 31/03/14 11:16, Michael Thayer wrote: I currently have three patches in the air waiting for review and hopefully integration. It would be great if someone found time to go over them. Trying again here. I was hoping to get these into 1.16, but I am getting more and more doubtful