Re: [PATCH 1/7] render: Inline common FindGlyph case

2015-05-12 Thread Keith Packard
Dave Airlie airl...@gmail.com writes: +GlyphHashPtr hash = glyphSet-hash; +GlyphRefPtr gr = hash-table[id % hash-hashSet-size]; I'm not sure if I'm right, but should this check gr == DeletedGlyph? I think you probably mean: gr-glyph == DeletedGlyph gr-glyph != NULL Yes,

Re: [PATCH 2/7] Add 'likely' and 'unlikely' macros

2015-05-12 Thread Kenneth Graunke
On Monday, May 11, 2015 09:23:53 PM Keith Packard wrote: These two macros provide hints to the compiler about common code paths to help it optimize a bit better. Signed-off-by: Keith Packard kei...@keithp.com --- include/misc.h | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH 2/7] Add 'likely' and 'unlikely' macros

2015-05-12 Thread Julien Cristau
On Mon, May 11, 2015 at 21:23:53 -0700, Keith Packard wrote: These two macros provide hints to the compiler about common code paths to help it optimize a bit better. Signed-off-by: Keith Packard kei...@keithp.com --- include/misc.h | 8 1 file changed, 8 insertions(+) diff

Re: [PATCH 5/7] glamor: compute GLSL version from GL_SHADING_LANGUAGE_VERSION

2015-05-12 Thread Kenneth Graunke
On Monday, May 11, 2015 09:23:56 PM Keith Packard wrote: This replaces a kludge which used the GL version as a proxy for the GLSL version. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff

Re: [PATCH] glamor: fix build when DRI3 is not defined

2015-05-12 Thread Keith Packard
Jonathan Gray j...@jsg.id.au writes: Looks reasonable to me... Reviewed-by: Kenneth Graunke kenn...@whitecape.org Thanks for the review. Any chance someone could merge this and the other glamor patch? Both have been merged. 145ae03..00f7941 master - master -- -keith

Re: [PATCH 5/7] glamor: compute GLSL version from GL_SHADING_LANGUAGE_VERSION

2015-05-12 Thread Matt Turner
On Tue, May 12, 2015 at 7:56 AM, Keith Packard kei...@keithp.com wrote: Kenneth Graunke kenn...@whitecape.org writes: If you care about making that work, I recommend swiping Piglit's piglit_get_glsl_version() function, available here:

Re: [PATCH 2/7] Add 'likely' and 'unlikely' macros

2015-05-12 Thread walter harms
Just for my curiosity .. is there any benchmark that shows that this actually improves something re, wh Am 12.05.2015 06:23, schrieb Keith Packard: These two macros provide hints to the compiler about common code paths to help it optimize a bit better. Signed-off-by: Keith Packard

Re: [PATCH 0/5] Xephyr: Numerous issues

2015-05-12 Thread Keith Packard
Egbert Eich e...@freedesktop.org writes: Egbert Eich (5): Xephyr: Don't crash when no command line argument is specified Xephyr: Print default server display number if none is specified Xephyr: Fix compile when debugging is enabled Xephyr: Fix screen image draw for the non-Glamor

Re: [PATCH 4/7] glamor: Remove destination drawable argument from glamor_set_texture

2015-05-12 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: This argument wasn't used at all. Signed-off-by: Keith Packard kei...@keithp.com Reviewed-by: Eric Anholt e...@anholt.net signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 5/7] glamor: compute GLSL version from GL_SHADING_LANGUAGE_VERSION

2015-05-12 Thread Keith Packard
Matt Turner matts...@gmail.com writes: Looks like the code blames to Chad in commit 112eaa05, so that would be copyright Intel 2011. Thanks, I've adjusted the copyright I stuck in the file :-) git://people.freedesktop.org/~keithp/xserver glamor-new-glyphs -- -keith signature.asc

[PATCH] Fix border tile origin when background is ParentRelative

2015-05-12 Thread Peter Harris
According to http://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#requests:CreateWindow The border tile origin is always the same as the background tile origin. ChangeWindowAttributes goes to some effort to make sure it repaints the border tile whenever the background origin may have

Re: [PATCH 3/7] glamor: Pass depth to glamor_pm_is_solid and glamor_set_planemask

2015-05-12 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Instead of passing the destination drawable, just pass the depth, as the underlying functions need only that to check whether the planemask is going to work. This API change will allow higher level functions to not need the destination pixmap. The gc

Re: [PATCH 7/7] glamor: Replace CompositeGlyphs code

2015-05-12 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: New composite glyphs code uses the updated glamor program infrastructure to create efficient shaders for drawing render text. Glyphs are cached in two atlases (one 8-bit, one 32-bit) in a simple linear fashion. When the atlas fills, it is discarded and

Re: [PATCH 6/7] glamor: Adapt glamor_program API to handle render acceleration

2015-05-12 Thread Eric Anholt
Summary: Tiny nitpicks, one functional concern. Keith Packard kei...@keithp.com writes: This extends the existing API to support options needed for render accleratoin, including an additional fragment, 'combine', (which acceleration provides a place to perform the source IN mask operation

Re: About xf86-video-armsoc integration

2015-05-12 Thread Xinliang Liu
On 12 May 2015 at 21:03, Guillaume Tucker guillaume.tuc...@arm.com wrote: Then i run startx, i can see the desktop on the monitor. But i found that the X process doesn't load any EGL and GLES libs by seeing the info of /proc/X process ID/task/*/smaps file. Most X11 desktop environments

[PATCH 2/4] xwayland: Remove a useless out-of-memory check

2015-05-12 Thread Dima Ryazanov
snprintf does not allocate memory, so we can never get an out-of-memory error. (Also, the error handler would free xwl_output after it was already registered as an event listener.) Signed-off-by: Dima Ryazanov d...@gmail.com --- hw/xwayland/xwayland-output.c | 6 +- 1 file changed, 1

Re: About xf86-video-armsoc integration

2015-05-12 Thread Guillaume Tucker
Then i run startx, i can see the desktop on the monitor. But i found that the X process doesn't load any EGL and GLES libs by seeing the info of /proc/X process ID/task/*/smaps file. Most X11 desktop environments use OpenGL, not OpenGL ES. Then like most embedded GPUs, Mali-450 only

[PATCH 1/4] xwayland: Remove the output from the list after destroying it

2015-05-12 Thread Dima Ryazanov
Signed-off-by: Dima Ryazanov d...@gmail.com --- hw/xwayland/xwayland-output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xwayland/xwayland-output.c b/hw/xwayland/xwayland-output.c index 155cbc1..1d75d0b 100644 --- a/hw/xwayland/xwayland-output.c +++ b/hw/xwayland/xwayland-output.c @@

About xf86-video-armsoc integration

2015-05-12 Thread Xinliang Liu
Hello, Recently, i am working on enabling mali 450 gpu at debian xorg X windows for hikey board which is one of 96boards https://www.96boards.org/. I first implement xf86-video-armsoc(ver1.1.0) video driver, compile and cp armsoc_drv.so to directory /usr/lib/xorg/modules/drivers. And then compile

[PATCH 4/4] xwayland: Destroy xwl_output when wl_output gets removed

2015-05-12 Thread Dima Ryazanov
This makes Xwayland correctly handle a monitor getting unplugged. Signed-off-by: Dima Ryazanov d...@gmail.com --- hw/xwayland/xwayland-output.c | 1 + hw/xwayland/xwayland.c| 16 hw/xwayland/xwayland.h| 1 + 3 files changed, 18 insertions(+) diff --git

Re: About xf86-video-armsoc integration

2015-05-12 Thread Xinliang Liu
On 12 May 2015 at 21:03, Guillaume Tucker guillaume.tuc...@arm.com wrote: Hi Guillaume, thank you for reply:-) Then i run startx, i can see the desktop on the monitor. But i found that the X process doesn't load any EGL and GLES libs by seeing the info of /proc/X process ID/task/*/smaps

Re: About xf86-video-armsoc integration

2015-05-12 Thread Show Liu
Hi Xinliang, I just wanna share my experience on Arndale with you. for me, I put all libraries on /usr/lib/mali/ then touch 1 conf file in /etc/ld.so.conf.d/ like mali.conf and echo the mali libraries path into it. and renew the ld.cache using ldconfig. After startx, I can run the test program

[PATCH 3/4] xwayland: Keep a list of wayland globals

2015-05-12 Thread Dima Ryazanov
The logic is pretty much copied from weston's clients/window.c. Signed-off-by: Dima Ryazanov d...@gmail.com --- hw/xwayland/xwayland.c | 25 - hw/xwayland/xwayland.h | 8 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/hw/xwayland/xwayland.c

Re: [PATCH] Allow system call restarts upon signal interruption

2015-05-12 Thread Michel Dänzer
On 13.05.2015 07:39, Daniel Drake wrote: The X server frequently deals with SIGIO and SIGALRM interruptions. If process execution is inside certain blocking system calls when these signals arrive, e.g. with the kernel blocked on a contended semaphore, the system calls will be interrupted.

Re: [PATCH 6/7] glamor: Adapt glamor_program API to handle render acceleration

2015-05-12 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Summary: Tiny nitpicks, one functional concern. Keith Packard kei...@keithp.com writes: This extends the existing API to support options needed for render accleratoin, including an additional fragment, 'combine', (which acceleration provides a place to

Re: [PATCH 7/7] glamor: Replace CompositeGlyphs code

2015-05-12 Thread Keith Packard
Eric Anholt e...@anholt.net writes: I think this explanation is what I wanted in this block: /* If we're dealing with 1-bit glyphs, we upload them to * the cache as normal 8-bit alpha, since that's what GL * can handle. */

[PATCH] Allow system call restarts upon signal interruption

2015-05-12 Thread Daniel Drake
The X server frequently deals with SIGIO and SIGALRM interruptions. If process execution is inside certain blocking system calls when these signals arrive, e.g. with the kernel blocked on a contended semaphore, the system calls will be interrupted. Some system calls are automatically restartable

Re: [PATCH 3/7] glamor: Pass depth to glamor_pm_is_solid and glamor_set_planemask

2015-05-12 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Keith Packard kei...@keithp.com writes: Instead of passing the destination drawable, just pass the depth, as the underlying functions need only that to check whether the planemask is going to work. This API change will allow higher level functions to not

Re: About xf86-video-armsoc integration

2015-05-12 Thread Xinliang Liu
On 13 May 2015 at 10:02, Show Liu show@linaro.org wrote: Hi Show liu, thank you for your sharing. Hi Xinliang, I just wanna share my experience on Arndale with you. for me, I put all libraries on /usr/lib/mali/ then touch 1 conf file in /etc/ld.so.conf.d/ like mali.conf and echo the

Re: [PATCH] Fix border tile origin when background is ParentRelative

2015-05-12 Thread Keith Packard
Peter Harris phar...@opentext.com writes: According to http://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#requests:CreateWindow The border tile origin is always the same as the background tile origin. ChangeWindowAttributes goes to some effort to make sure it repaints the border

Re: [PATCH] Allow system call restarts upon signal interruption

2015-05-12 Thread Keith Packard
Jasper St. Pierre jas...@endlessm.com writes: I don't see how that's the case. The select() call should never block, see: http://cgit.freedesktop.org/xorg/xserver/tree/os/connection.c#n1000 From select(2): If both fields of the timeval structure are zero, then select() returns

Re: [PATCH 2/7] Add 'likely' and 'unlikely' macros

2015-05-12 Thread Keith Packard
Julien Cristau jcris...@debian.org writes: X11/Xfuncproto.h defines _X_LIKELY and _X_UNLIKELY, are those not good enough? Yes, those will do just fine; I completely missed them. -- -keith signature.asc Description: PGP signature ___

Re: [PATCH] Allow system call restarts upon signal interruption

2015-05-12 Thread Jasper St. Pierre
(Resending from the email address I'm subscribed to, sorry for the noise) I don't see how that's the case. The select() call should never block, see: http://cgit.freedesktop.org/xorg/xserver/tree/os/connection.c#n1000 From select(2): If both fields of the timeval structure are zero, then

Re: [PATCH] Allow system call restarts upon signal interruption

2015-05-12 Thread Jasper St. Pierre
I don't see how that's the case. The select() call should never block, see: http://cgit.freedesktop.org/xorg/xserver/tree/os/connection.c#n1000 From select(2): If both fields of the timeval structure are zero, then select() returns immediately. On Tue, May 12, 2015 at 7:18 PM, Michel

Re: [PATCH 5/7] glamor: compute GLSL version from GL_SHADING_LANGUAGE_VERSION

2015-05-12 Thread Keith Packard
Kenneth Graunke kenn...@whitecape.org writes: If you care about making that work, I recommend swiping Piglit's piglit_get_glsl_version() function, available here: http://cgit.freedesktop.org/piglit/tree/tests/util/piglit-shader.c#n28 Thanks. What kind of copyright holder is 'The Piglit

Re: [PATCH 2/2] modesetting: Include dix-config.h from dumb_bo.c

2015-05-12 Thread Keith Packard
Alex Deucher alexdeuc...@gmail.com writes: On Mon, Mar 16, 2015 at 9:21 PM, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com Fixes mmap failures with 32-bit builds. Signed-off-by: Michel Dänzer mic...@daenzer.net For the series: Reviewed-by: Alex