Re: [patch xdm 4/4] Unifdef X_NO_SYS_UN

2015-12-03 Thread Alan Coopersmith
On 12/ 2/15 03:22 AM, Matthieu Herrb wrote: Nothing has set that since the modularization Signed-off-by: Matthieu Herrb --- xdm/choose.c | 5 + xdm/netaddr.c | 4 +--- xdm/prngc.c | 4 +--- xdm/socket.c | 4 +--- xdm/xdmcp.c | 4 +--- 5 files changed, 5

Re: [patch xdm 2/4] Remove SCO, Unixware, OS/2 support

2015-12-03 Thread Alan Coopersmith
On 12/ 2/15 03:22 AM, Matthieu Herrb wrote: Signed-off-by: Matthieu Herrb --- config/Xsession.cpp | 18 -- greeter/verify.c| 97 + include/dm.h| 8 ++--- xdm/dm.c| 7

Re: [patch xdm 1/4] Remove #if 0'd code

2015-12-03 Thread Alan Coopersmith
On 12/ 2/15 03:22 AM, Matthieu Herrb wrote: Signed-off-by: Matthieu Herrb --- chooser/chooser.c | 37 - include/dm.h | 3 --- xdm/choose.c | 11 xdm/dm.c | 25 - xdm/xdmcp.c | 81

Re: [PATCH:xserver] Missing memory allocation checks.

2015-12-03 Thread Alan Coopersmith
On 11/30/15 12:54 PM, Miod Vallat wrote: This is a potpourri of missing memory allocation checks. Routines will return BadAlloc whenever possible, or fall back to a different behaviour, whenever possible. Unfortunately some functions are void and can not propagate failure to their callers.

[PATCH:libX11] Bug 93184: read_EncodingInfo invalid free

2015-12-03 Thread Alan Coopersmith
Free the correct bits of memory if we run out and need to unwind Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93184 Signed-off-by: Alan Coopersmith --- modules/om/generic/omGeneric.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] xserver: Fix configure.ac check for libsystemd/-daemon

2015-12-03 Thread Pekka Paalanen
On Fri, 27 Nov 2015 15:57:21 + Bob Ham wrote: > The configure script looks for the libsystemd-daemon pkg-config > module. If the configure script finds it, the script will add > libsystemd-daemon to a list of modules which are used to consolidate > CFLAGS and LIBS. >

Re: [PATCH] xserver: Fix configure.ac check for libsystemd/-daemon

2015-12-03 Thread Emil Velikov
Hi guys, We had a similar patch from an intel dev not too long ago, although it never got polished afaics. On 3 December 2015 at 11:39, Pekka Paalanen wrote: > On Fri, 27 Nov 2015 15:57:21 + > Bob Ham wrote: > >> The configure script looks for

[PATCH xfree86 v2] systemd-logind.c: don't parse VT settings for non-seat0 X servers

2015-12-03 Thread Laércio de Sousa
Since non-seat0 X servers no longer touch VTs, I believe these settings are unnecessary. Signed-off-by: Laércio de Sousa --- hw/xfree86/os-support/linux/systemd-logind.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: Deliver input events only to window owner

2015-12-03 Thread Keith Packard
Peter Hutterer writes: > that's going to be fun to work out. raw events are delivered to the root > window only so you don't really know which client they get delivered to. > They're before the actual event in the pipe, and in some cases the event > isn't delivered to

Re: Deliver input events only to window owner

2015-12-03 Thread Peter Hutterer
On Thu, Dec 03, 2015 at 02:55:22AM -0600, Keith Packard wrote: > Peter Hutterer writes: > > > that's going to be fun to work out. raw events are delivered to the root > > window only so you don't really know which client they get delivered to. > > They're before the

[PATCH xserver] prime: Damage full destination rectangle when we start dirty tracking

2015-12-03 Thread Michel Dänzer
From: Michel Dänzer This makes sure that the destination pixmap contents will be fully initialized. Without this, a PRIME output starts out with garbage. Signed-off-by: Michel Dänzer --- dix/pixmap.c | 21 + 1 file changed,

Re: Deliver input events only to window owner

2015-12-03 Thread Peter Hutterer
On Thu, Dec 03, 2015 at 01:51:35AM -0600, Keith Packard wrote: > Peter Hutterer writes: > > > note that this does not handle XI2 raw keyboard events, they will need to be > > handled as well. > > Hrm. So, there's a problem here -- raw events get delivered separately >

Re: [PATCH] xserver: Fix configure.ac check for libsystemd/-daemon

2015-12-03 Thread Bob Ham
On Fri, 2015-11-27 at 15:57 +, Bob Ham wrote: > With this patch, we set a variable depending on which > pkg-config module is found and add that to the module list instead. *ping* -- Bob Ham Software Engineer Open First Collabora is hiring! Please check

Re: [patch xdm 3/4] Remove support for UNRELIABLE_SIGNALS

2015-12-03 Thread Alan Coopersmith
On 12/ 2/15 07:41 AM, Adam Jackson wrote: On Wed, 2015-12-02 at 12:22 +0100, Matthieu Herrb wrote: Nothing has been setting this since the modularization.x Not sure this is correct. Even with the first two patches from this series applied, we have: dmt:~/git/app/xdm% grep -C3 UNRELIABLE

[PATCH:libX11] Bug 93183: _XDefaultOpenIM memory leak in out-of-memory error path

2015-12-03 Thread Alan Coopersmith
free(local_impart) since that's where the allocated memory is stored immediately from the calloc call, instead of relying on the pointer being copied into im->private, since that only happens after the call to goto Error2. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93183

Re: [PATCH xserver] prime: Damage full destination rectangle when we start dirty tracking

2015-12-03 Thread Alex Deucher
On Thu, Dec 3, 2015 at 3:04 AM, Michel Dänzer wrote: > From: Michel Dänzer > > This makes sure that the destination pixmap contents will be fully > initialized. Without this, a PRIME output starts out with garbage. > > Signed-off-by: Michel Dänzer