Re: [PATCH xserver 2/3] modesetting: Remove some dead code

2016-09-09 Thread Aaron Plattner
On 08/16/2016 02:10 AM, Hans de Goede wrote: > The "if (pixmap) ..." block this commit removes is inside an > "if (pixmap == NULL) ..." block, so it will never execute. > > Signed-off-by: Hans de Goede > --- > hw/xfree86/drivers/modesetting/dri2.c | 2 -- > 1 file changed,

Re: Proposed X server 1.19 schedule

2016-09-09 Thread Aaron Plattner
On 09/06/2016 12:27 PM, Keith Packard wrote: > Adam Jackson writes: > >> ... move the non-critical bug deadline to 2016-10-01? Still leaves >> three weeks for critical fixes. Either way, looks plausible to me. I >> don't personally have any non-bug changes I want to land before

Re: [PATCH xserver 00/12] xwayland: Pointer confinement and warping

2016-09-09 Thread Jonas Ådahl
On Fri, Sep 09, 2016 at 10:38:32AM -0600, Keith Packard wrote: > Peter Hutterer writes: > > > Keith, I think the ABI changes should go in before we lock down, this is a > > pretty important feature for the Wayland transition and our release cycles > > aren't exactly

Re: [PATCH xserver 00/12] xwayland: Pointer confinement and warping

2016-09-09 Thread Keith Packard
Peter Hutterer writes: > Keith, I think the ABI changes should go in before we lock down, this is a > pretty important feature for the Wayland transition and our release cycles > aren't exactly predictable at this point. Yeah, the ABI changes look harmless enough,

Re: [RESEND xserver] glx: Always enable EXT_texture_from_pixmap for DRI glx

2016-09-09 Thread Adam Jackson
On Fri, 2016-09-09 at 16:02 +0200, Hans de Goede wrote: >  glx/glxdri2.c  | 6 -- https://lists.freedesktop.org/archives/xorg-devel/2016-September/050853.html - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 1/2] Hold input lock for deviceProc

2016-09-09 Thread Keith Packard
Peter Hutterer writes: > not needed but it won't hurt. Right, it seemed easier to just hold locks across all calls than to try to document why locks weren't required everywhere. I did have one place where I didn't want to grab the lock and added a comment there. >

Re: [PATCH] xwayland: Close the shm fd as early as possible

2016-09-09 Thread Olivier Fourdan
> > > [...] > > > > > > the idea here looks fine to me. > > > > > > However, I've been wondering, surely there was a reason why it wasn't > > > coded like this in the first place? > > > > > > Could you check if this patch causes Xwayland to create lots of > > > wl_buffers it will never attach

[RESEND xserver 0/1] glx: Always enable EXT_texture_from_pixmap for DRI glx

2016-09-09 Thread Hans de Goede
Hi All, I know that when this was sent before it was not liked because things should really be fixed in Mesa, but in the mean time no-one has stepped up and fixed Mesa. Without this patch 1.19 will regress users who rely on llvmpipe, e.g. people running gnome as desktop in VMs, so I believe that

[RESEND xserver] glx: Always enable EXT_texture_from_pixmap for DRI glx

2016-09-09 Thread Hans de Goede
Prior to commit f95645c6f700 ("glx: Don't enable EXT_texture_from_pixmap unconditionally") DRI glx would always advertise EXT_texture_from_pixmap. That commit moved the setting of the extension in the extension bits from __glXInitExtensionEnableBits to its callers so that

modesetting driver maintenance

2016-09-09 Thread Hans de Goede
Hi All, I've several modesetting driver patches which have been awaiting review for a while now: https://patchwork.freedesktop.org/patch/105350/ https://patchwork.freedesktop.org/patch/105351/ https://patchwork.freedesktop.org/patch/105352/ https://patchwork.freedesktop.org/patch/107096/

Re: [PATCH v7 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

2016-09-09 Thread Hans de Goede
Hi, On 09-09-16 03:11, Michel Dänzer wrote: On 08/09/16 07:08 PM, Hans De Goede wrote: When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_use is not set, but we still need to adjust the mouse position for things to work. This

[PATCH v8 xserver 6/7] xf86Cursor: Deal with rotation on GPU screens using a hw-cursor

2016-09-09 Thread Hans de Goede
When a slave-output is rotated the transformation is done on the blit from master to slave GPU, so crtc->transform_in_use is not set, but we still need to adjust the mouse position for things to work. This commit modifies xf86_crtc_transform_cursor_position to not rely on

Re: [PATCH xserver] Bump ABI versions

2016-09-09 Thread Jonas Ådahl
On Fri, Sep 09, 2016 at 05:38:12PM +0900, Michel Dänzer wrote: > On 09/09/16 05:12 PM, Jonas Ådahl wrote: > > Bump both the xinput and videodrv versions. The xinput due to the added > > valuator mask setter, and videodrv due to the added vfuncs to the > > Screen struct. > > > > Signed-off-by:

Re: [PATCH xserver] Bump ABI versions

2016-09-09 Thread Michel Dänzer
On 09/09/16 05:12 PM, Jonas Ådahl wrote: > Bump both the xinput and videodrv versions. The xinput due to the added > valuator mask setter, and videodrv due to the added vfuncs to the > Screen struct. > > Signed-off-by: Jonas Ådahl > --- > hw/xfree86/common/xf86Module.h | 4

Re: [RESEND,v4] xfree86: Immediately handle failure to set HW cursor

2016-09-09 Thread Alexandre Courbot
Hi Hans, apologies for the delayed reply! On Thu, Sep 1, 2016 at 11:24 PM, Hans de Goede wrote: > Hi, > > On 22-06-16 10:48, Alexandre Courbot wrote: >> >> There is currently no reliable way to report failure to set a HW >> cursor. Still such failures can happen if e.g. the

[PATCH xserver] Bump ABI versions

2016-09-09 Thread Jonas Ådahl
Bump both the xinput and videodrv versions. The xinput due to the added valuator mask setter, and videodrv due to the added vfuncs to the Screen struct. Signed-off-by: Jonas Ådahl --- hw/xfree86/common/xf86Module.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH xserver 00/12] xwayland: Pointer confinement and warping

2016-09-09 Thread Peter Hutterer
On Thu, Sep 08, 2016 at 06:46:29PM +0800, Jonas Ådahl wrote: > Hi, > > This series adds support for raw pointer events, pointer confinement and > introduces pointer warp emulation to implement pointer-lock like features > clients use pointer warping for. > > Raw pointer events is done by adding