Re: [PATCH xserver v2] damage: Validate source pictures bound to windows before unwrapping

2017-02-08 Thread Michel Dänzer
On 09/02/17 03:06 AM, Adam Jackson wrote: > On Tue, 2017-02-07 at 11:57 -0500, Alex Deucher wrote: >> On Tue, Feb 7, 2017 at 3:38 AM, Michel Dänzer >> wrote: >>> From: Michel Dänzer >>> >>> The lower layers also do this, but no damage may be reported

[PATCH xserver] dmx: fix linking again by brute-forcing

2017-02-08 Thread Mihail Konev
On Ubuntu 17.04 daily, the following error is seen, (disappears when librender.a is put before libos.a on the resulting collect2 linker command line (seen by CFLAGS='-v')): ../../render/.libs/librender.a(glyph.o): In function `HashGlyph': /mnt/xserver/render/glyph.c:168: undefined reference

Re: [PATCH xserver] randr,render: link some necessary symbols into

2017-02-08 Thread Mihail Konev
On Thu, Feb 09, 2017 at 10:48:14AM +0500, Mihail Konev wrote: > this patch looks to be making more sense than per-OS adjustments (In the sense it does record "A depends on B", whereas reordering does not, while being a "per-OS-adjustment" too). ___

[PATCH xserver] randr,render: link some necessary symbols into

2017-02-08 Thread Mihail Konev
Fixes dmx build, even on Ubuntu 17.04 alpha, where just adding librender at the end of Xdmx doesn't work (librender HashGlyph then cannot find x_sha1_init from libos). This links some libos.a functions into render, and some librender.a ones into randr. Adjust the subdirectory order to allow for

Re: [PATCH xserver] xwayland: replace hardcoded function name with __func__ in error msg

2017-02-08 Thread Peter Hutterer
On Wed, Feb 08, 2017 at 02:46:16AM -0500, Olivier Fourdan wrote: > Hey Peter, > > > > LGTM - Yo get rid of two \n along the way, but I think there were not > > > needed in the first place so: > > > > oops. no, they're neeed so I added them back (and also to the instance where > > it was

Re: [PATCH v5 xserver 7/6] tests: fix --disable-xorg build

2017-02-08 Thread Mihail Konev
On Mon, Jan 16, 2017 at 02:47:26PM -0500, Adam Jackson wrote: > On Sat, 2017-01-14 at 15:19 +0500, Mihail Konev wrote: > > Commit ead5064581665ff40c177dd1b447949f1420e209 missed that xi1/ > > and xi2/ were conditioned on XORG, and made xfree86-only tests to be > > built unconditionally. > > Ifdef

Re: [PATCH xserver 2/2 v4] xwayland: Apply output rotation for screen size

2017-02-08 Thread Adam Jackson
On Wed, 2017-02-08 at 13:20 -0500, Olivier Fourdan wrote: > Yeah... It's all confusing! Sorry! > > Those are the two patches: > > https://patchwork.freedesktop.org/patch/137446/ > https://patchwork.freedesktop.org/patch/137635/ Merged: remote: I: patch #137446 updated using rev

Re: [PATCH xserver 2/2 v4] xwayland: Apply output rotation for screen size

2017-02-08 Thread Olivier Fourdan
Hey Adam, - Original Message - > On Wed, 2017-02-08 at 09:23 +0100, Olivier Fourdan wrote: > > Previously, we would swap the width/height of the Xwayland output based > > on the output rotation, so that the overall screen size would match the > > actual rotation of each output. > > This

Re: [PATCH xserver v2] damage: Validate source pictures bound to windows before unwrapping

2017-02-08 Thread Alex Deucher
On Wed, Feb 8, 2017 at 1:06 PM, Adam Jackson wrote: > On Tue, 2017-02-07 at 11:57 -0500, Alex Deucher wrote: >> On Tue, Feb 7, 2017 at 3:38 AM, Michel Dänzer >> wrote: >> > From: Michel Dänzer >> > >> > The lower layers also do this,

Re: [PATCH xserver 2/2 v4] xwayland: Apply output rotation for screen size

2017-02-08 Thread Adam Jackson
On Wed, 2017-02-08 at 09:23 +0100, Olivier Fourdan wrote: > Previously, we would swap the width/height of the Xwayland output based > on the output rotation, so that the overall screen size would match the > actual rotation of each output. This series makes sense, but I'm a little lost on which

Re: [PATCH xserver v2] damage: Validate source pictures bound to windows before unwrapping

2017-02-08 Thread Adam Jackson
On Tue, 2017-02-07 at 11:57 -0500, Alex Deucher wrote: > On Tue, Feb 7, 2017 at 3:38 AM, Michel Dänzer > wrote: > > From: Michel Dänzer > > > > The lower layers also do this, but no damage may be reported there, > > since we unwrap before calling

Re: [PATCH xserver] dmx: fix linking

2017-02-08 Thread Adam Jackson
On Sat, 2017-02-04 at 00:03 +0500, Mihail Konev wrote: > diff --git a/hw/dmx/Makefile.am b/hw/dmx/Makefile.am > index eef84cb66a76..38d6ac409e76 100644 > --- a/hw/dmx/Makefile.am > +++ b/hw/dmx/Makefile.am > @@ -80,7 +80,8 @@ XDMX_LIBS = \ >   >  Xdmx_LDFLAGS = $(LD_EXPORT_SYMBOLS_FLAG) >  

Re: [PATCH xwayland] xwayland: Add hack for FWXGA resolution #99574

2017-02-08 Thread Adam Jackson
On Fri, 2017-02-03 at 02:41 -0500, Olivier Fourdan wrote: > > For some applications (like fullscreen games) it matters for XRandr > > resolution to be correctly set and equal to root window resolution. > > > > In XServer there is already hack for this, adapted it for XWayland. > > > > Fixes:

Re: [PATCH xserver 0/2] present: Allow flipping with PRIME slave outputs

2017-02-08 Thread Adam Jackson
On Thu, 2017-02-02 at 15:56 -0500, Alex Deucher wrote: > For the series: > Reviewed-by: Alex Deucher remote: I: patch #136239 updated using rev b5b292896f647c85f03f53b20b2f03c0e94de428. remote: I: patch #136238 updated using rev

Re: [PATCH xserver] glamor: Paint first and last pixel of lines

2017-02-08 Thread Adam Jackson
On Wed, 2017-02-08 at 14:44 +0100, Max Staudt wrote: > On 02/07/2017 09:06 PM, Keith Packard wrote: > > > > Max Staudt writes: > > > > > OpenGL implementations are allowed to be imprecise in drawing line caps. > > > This patch expands on the original workaround in dc9fa908. > >

Re: [xserver PULL master] modesetting HW cursor patches

2017-02-08 Thread Adam Jackson
On Thu, 2017-02-02 at 11:43 +0100, Michael Thayer wrote: > Respectful but rather frustrated ping.  Is it still worth my trying to  > get these changes in or should I just give up? Sorry for the delay. The cursor code is that perfect horrifying intersection of input and output that means I hate

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-08 Thread Martin Peres
On 06/02/17 17:50, Martin Peres wrote: On 03/02/17 10:04, Daniel Vetter wrote: On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: On 01/02/17 22:05, Manasi Navare wrote: On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: Jani Nikula writes:

Re: [PATCH xserver] glamor: Paint first and last pixel of lines

2017-02-08 Thread Max Staudt
On 02/07/2017 09:06 PM, Keith Packard wrote: > Max Staudt writes: > >> OpenGL implementations are allowed to be imprecise in drawing line caps. >> This patch expands on the original workaround in dc9fa908. > > Yeah, finding a way to work around GL differences seems like a good

[PATCH xserver 2/2 v4] xwayland: Apply output rotation for screen size

2017-02-08 Thread Olivier Fourdan
Previously, we would swap the width/height of the Xwayland output based on the output rotation, so that the overall screen size would match the actual rotation of each output. Problem is the RandR's ConstrainCursorHarder() handler will also apply the output rotation, meaning that when the output