Re: xserver extensions/hooks: freeing client resources

On 2/1/24 7:03 AM, Enrico Weigelt, metux IT consult wrote: Hello folks, I'm currently writing an extension that's storing per-client data. Where's is the right place to free up all resources ? I guess the client state xace hook - but what's the difference between retained and gone ? I don't

Re: SCM_RIGHTS: XTrans vs ssh forwarding with MIT-SHM clients

At least on Arch Linux, getpeereid() is only defined in bsd/unistd.h and Meson doesn't seem to find it. HAVE_GETPEEREID is undefined and GetLocalClientCreds() ends up in the `defined(SO_PEERCRED)` path. I agree that it's just broken on platforms that have getpeereid(). -- Aaron On 1/18/23

Re: Xorg build fails due to "Failed to clone lib/libxcvt"

On 5/26/22 3:00 PM, Jérémy Hervé wrote: Dear Xorg-Devel List, I am trying to build the Xorg server. I am using the instructions available here : https://wiki.x.org/wiki/Building_the_X_Window_System/ and chose the option "Build Process Based on build.sh Script". I type the following command

Re: [RFC] Release schedule for X server 21.1

Hi Povilas, thanks so much for driving this release! This schedule sounds fine to me. Unless you say otherwise, I'm going to consider the ABI frozen at this point and mark it as officially supported for the next NVIDIA driver release. Sincerely, Aaron On 8/9/21 4:57 PM, Povilas Kanapickas

Re: xserver release process

On 10/8/19 1:19 PM, Hans de Goede wrote: Hi, On 08-10-2019 18:28, Adam Jackson wrote: In short, releases need to happen, and we have CI, so let's just pop a release out on scheduled dates assuming CI passes. Given that the Xorg xserver has a lot of hw interaction, we are never going to

Re: RFC - GLX Extension to control GLXVND dispatching for PRIME GPU offloading

On 4/17/19 8:51 AM, Kyle Brenneman wrote: For GPU offloading in libglvnd, where individual clients can run with an alternate GPU and client-side vendor library, we'd need some way for that alternate vendor library to communicate with its server-side counterpart. Normally, the server's GLXVND

Re: what does "+"(preferred) means in xrandr?

"preferred" generally means that the Extended Display Information Data (EDID) from the monitor indicates that that mode most closely matches the native timings of the display. All modes listed by RandR for a given monitor should work with that monitor, but the preferred mode should work best (for

Re: [PATCH] meson: Add configuration of listening on tcp, unix and local

On 06/26/2018 06:12 PM, Peter Hutterer wrote: On Tue, Jun 26, 2018 at 01:07:23PM -0700, Aaron Plattner wrote: On 06/24/2018 11:45 PM, Laurent Carlier wrote: Le samedi 16 juin 2018, 13:00:01 CEST Laurent Carlier a écrit : bugzilla: https://bugs.kde.org/show_bug.cgi?id=395419 bugzilla: https

Re: [PATCH] meson: Add configuration of listening on tcp, unix and local

On 06/24/2018 11:45 PM, Laurent Carlier wrote: > Le samedi 16 juin 2018, 13:00:01 CEST Laurent Carlier a écrit : >> bugzilla: https://bugs.kde.org/show_bug.cgi?id=395419 >> bugzilla: https://bugs.archlinux.org/task/59025 >> >> Signed-off-by: Laurent Carlier Seems to

Re: [PATCH xserver] configure: Remove unused CONFIGFILE

On 06/11/2018 12:10 PM, Adam Jackson wrote: This isn't used for anything, which is just as well, because /etc/xorg.conf is not in fact a path xserver will try to use. Bugzilla: https://bugs.freedesktop.org/8890 Signed-off-by: Adam Jackson Reviewed-by: Aaron Plattner I checked and confirmed

[PATCH xserver] meson: Define DEFAULT_LIBRARY_PATH as join_paths(get_option('prefix'), get_option('libdir'))

'libdir' defaults to 'lib', so running X -showDefaultLibPath just prints 'lib' instead of '/usr/lib' or '/usr/local/lib'. Use joint_paths() to get the correct full path. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- The NVIDIA driver installer noticed this meson vs. autoconf diff

[PATCH xserver] meson: Set XCONFIGFILE to 'xorg.conf' instead of '/etc/xorg.conf'

tc/X11/etc/xorg.conf'. Fix this by just hard-coding XCONFIGFILE to 'xorg.conf'. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- include/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/meson.build b/include/meson.build index 691e9f0743af.

[PATCH xserver] meson: Fix module_dir configuration (v2)

' default path, but use join_paths() unconditionally (Thierry Reding) Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- meson.build | 9 +++-- meson_options.txt | 2 +- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index 6571d0

Re: [PATCH xserver] meson: Fix module_dir configuration

On 04/06/2018 09:59 PM, Aaron Plattner wrote: > On 04/03/2018 02:27 AM, Thierry Reding wrote: >> On Mon, Apr 02, 2018 at 02:31:20PM -0700, Aaron Plattner wrote: >>> meson.build has code to set the module_dir variable to >>> ${libdir}/xorg/modules if the module

Re: [PATCH xserver] meson: Fix module_dir configuration

On 04/03/2018 02:27 AM, Thierry Reding wrote: On Mon, Apr 02, 2018 at 02:31:20PM -0700, Aaron Plattner wrote: meson.build has code to set the module_dir variable to ${libdir}/xorg/modules if the module_dir option string is empty. However, this has several problems: 1. The variable is only used

[PATCH xserver] xfree86: Restore newline before "X Protocol Version" string

string. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- hw/xfree86/common/xf86Init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c index ea42ec946167..3c5cc7097c49 100644 --- a/hw/xfree86/common/xf86

[PATCH xserver] meson: Fix module_dir configuration

and meson. E.g. if ${prefix} is /X, then you get autoconf: moduledir=/X/lib/xorg/modules meson:moduledir=/X/xorg/modules Fix this by using the module_dir variable when generating xorg-server.pc, and by removing the default value for the module_dir option. Signed-off-by: Aaron Plattner

Re: [PATCH xserver 2/3] meson: Distribute more SDK headers

Thanks, Thierry! I started working on a change to do this, but didn't get very far before you beat me to it. On 03/29/2018 04:07 AM, Thierry Reding wrote: > From: Thierry Reding > > Install missing headers to the SDK directory to allow external modules > to properly build

Re: [PATCH xserver 7/8] dix: Remove colormap private fixup

On 01/31/2018 12:15 PM, Aaron Plattner wrote: > On 01/31/2018 07:54 AM, Adam Jackson wrote: >> The old xfree86 colormap system was the only thing that would register a >> colormap private after the colormap was created. Since that's gone now >> we can remove the special case.

Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

On 01/09/2018 10:08 AM, Aaron Plattner wrote: > On 01/09/2018 08:51 AM, Adam Jackson wrote: >> We weren't cancelling the old timer when changing cursors, making things >> go all crashy. Logically we could always cancel the timer first, but >> then we'd have to call TimerSe

Re: [PATCH xserver 1/2] animcur: Fix transitions between animated cursors

t will cancel the previous timer whereas before it wouldn't. Are there any weird cases where failing to change the cursor is expected and canceling animation of the previous cursor would be a problem? Assuming not, both changes Reviewed-by: Aaron Plattner <aplatt...@nvidia.com> I'll try to p

Re: [PATCH xserver] animcur: Move timer into pDev->spriteInfo->anim

On 01/09/2018 08:49 AM, Adam Jackson wrote: > On Mon, 2018-01-08 at 15:02 -0800, Aaron Plattner wrote: >> Commit 094a63d56fbfb9e23210cc9ac538fb198af37cee moved the timer that handles >> animated cursors from the per-screen AnimCurScreenRec into the per-cursor >> AnimCurRe

[PATCH xserver] animcur: Move timer into pDev->spriteInfo->anim

mated cursor to another. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> Reported-by: https://devtalk.nvidia.com/default/topic/1028172/linux/titan-v-ubuntu-16-04lts-and-387-34-driver-crashes-badly/post/5230967/#5230967 --- I'm not convinced that I fully understood how these timers work

Re: [PATCH xserver 3/4] animcur: Run the timer from the device, not the screen

On 01/08/2018 01:07 PM, Adam Jackson wrote: On Mon, 2018-01-08 at 12:39 -0800, Aaron Plattner wrote: Nothing like deploying code in the wild to find bugs. :( Hah! So it goes. The user on the forum reported a crash after this patch and I reproduced it locally: Thread 1 "Xorg"

Re: [PATCH xserver 3/4] animcur: Run the timer from the device, not the screen

Nothing like deploying code in the wild to find bugs. :( The user on the forum reported a crash after this patch and I reproduced it locally: Thread 1 "Xorg" received signal SIGSEGV, Segmentation fault. 0x55604b0b8acd in dixGetPrivateAddr (privates=0x3e8, key=0x55604b40ace0 ) at

Re: [PATCH xserver 1/4] animcur: Use fixed-size screen private

On 11/12/2017 04:35 PM, Robert Morell wrote: On Mon, Nov 06, 2017 at 03:19:51PM -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson --- render/animcur.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/render/animcur.c

Re: [PATCH] Add NonDesktop output property and behaviors.

Sorry for the extremely slow reply. I started writing this and then forgot about it when I went on vacation. I've been out of the loop since I got back so I apologize if the discussion has moved on and the responses below are stale. On 10/20/2017 12:53 PM, Keith Packard wrote: Aaron Plattner

Re: [PATCH xserver] xfree86: fix gamma compute when palette_size > 256

On 10/30/2017 03:28 AM, Michel Dänzer wrote: On 30/10/17 07:33 AM, Qiang Yu wrote: palette_(red|green|blue)_size > crtc->gamma_size (=256) this may happen when screen has per RGB chanel > 8bit, i.e. 30bit depth screen 10bit per RGB. Is palette_size > gamma_size really useful though? Seems to

Re: [PATCH] Add NonDesktop output property and behaviors.

that the underlying operating system will provide this information and have it reflected to X applications through this extension. Signed-off-by: Keith Packard <kei...@keithp.com> I think this makes sense. Comments below. Reviewed-by: Aaron Plattner <aplatt...@nvidia.com> --- randrpr

Re: [RFC] DeepColor Visual Class Extension

On 09/11/2017 09:10 AM, Adam Jackson wrote: > On Mon, 2017-08-14 at 19:17 -0700, Alex Goins wrote: > >> 2. DeepColor Visual Class >> >> The DeepColor extension defines a new visual class, DeepColor. >> >> DeepColor visuals do not make use of the red_mask, green_mask, blue_mask, or >>

Re: xf86-video-dummy patch series - was "Cleanups Redux"

On 08/05/2017 08:02 AM, Antoine Martin wrote: > On 17/12/16 02:04, Emil Velikov wrote: >> Hi Bob, >> >> On 9 December 2016 at 22:25, Bob Terek wrote: >>> >>> On 12/09/2016 03:13 AM, Emil Velikov wrote: >>> On 6 December 2016 at 22:41, Bob Terek wrote:

Re: [PATCH xserver] composite: Make compIsAlternateVisual safe even if Composite is off

return FALSE; Sure, can't hurt. Reviewed-by: Aaron Plattner <aplatt...@nvidia.com> -- nvpublic ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [RFC] DeepColor Visual Class Extension

On 07/18/2017 07:18 AM, Adam Jackson wrote: > On Mon, 2017-07-17 at 18:04 -0700, Alex Goins wrote: >> This is our latest iteration on the design of the visual class for use with >> HDR >> drawables, handling how colorspace/encoding and pixel format are specified >> and >> interpreted. We've been

Re: [RFC] Server side glvnd

Adding Kyle to To -- he's been working on something similar. On 07/18/2017 08:43 AM, Adam Jackson wrote: > I've been thinking about how to get multiple GL stacks to coexist > within the server, along the lines of libglvnd on the client side. This > is a bit of a brain dump, the intrepid can find

Re: twm deadlocks the server

On 07/03/2017 10:41 PM, Antoine Martin wrote: Hi, I've just come across this easy DoS with twm and X.Org X Server 1.19.3 from Fedora 26. Steps: /usr/libexec/Xorg -noreset -novtswitch -config /etc/xpra/xorg.conf :10& #verify we can access the display: DISPLAY=:10 xprop -root #start xterm so we

Re: [PATCH xrandr v2 1/2] xrandr: allow a single value for --scale

On 06/22/2017 03:39 PM, Giuseppe Bilotta wrote: This allows using e.g. --scale 0.5 as a shorthand for --scale 0.5x0.5 Signed-off-by: Giuseppe Bilotta --- man/xrandr.man | 7 --- xrandr.c | 8 ++-- 2 files changed, 10 insertions(+), 5 deletions(-)

Re: [PATCH xserver] xfree86/modes: Use RRTransformEqual in xf86RandR12CrtcSet

On 06/19/2017 01:57 AM, Michel Dänzer wrote: On 16/06/17 03:25 PM, Aaron Plattner wrote: On 06/15/2017 07:31 PM, Michel Dänzer wrote: From: Michel Dänzer <michel.daen...@amd.com> The memcmp didn't catch when e.g. only the filter changed. Tested by alternately running xrandr --output D

Re: [PATCH xserver] xfree86/modes: Use RRTransformEqual in xf86RandR12CrtcSet

On 06/15/2017 07:31 PM, Michel Dänzer wrote: From: Michel Dänzer The memcmp didn't catch when e.g. only the filter changed. Tested by alternately running xrandr --output DVI-I-0 --scale-from 3840x2160 --filter bilinear xrandr --output DVI-I-0 --scale-from 3840x2160

[PATCH xserver] randr: Use RRTransformEqual in RRCrtcPendingTransform

by running xrandr --output DP-1 --mode 1920x1080 --rate 144 --scale 0.5x0.5 --filter nearest follwed by xrandr --output DP-1 --mode 1920x1080 --rate 144 --scale 0.5x0.5 --filter bilinear Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- randr/rrcrtc.c | 5 ++--- 1 file chan

Re: [PATCH 3/2 xserver] travis: Enable ccache.

On 06/01/2017 01:59 PM, Eric Anholt wrote: We bind-mount the cache directory into the container. Cuts build time from about 4 minutes to 2. Signed-off-by: Eric Anholt --- .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.travis.yml

[PATCH app/xrandr] man: Document the new --filter option

Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- I noticed elsewhere that in PDF versions of the man pages, \- expands as U+2212 MINUS SIGN and - expands to U+002D HYPHEN-MINUS. So I think our use of - and \- is backwards. I didn't try to fix that here. man/xrandr.man | 8 +

Re: [PATCH xrandr] Adding a "--filter" flag

I fixed up a few things from this and pushed it. Can you please update https://patchwork.freedesktop.org/patch/146123/ ? remote: Updating patchwork state for https://patchwork.freedesktop.org/project/Xorg/list/ remote: E: failed to find patch for rev 6ac2afc0d7d8d51d4085767b901667393c11061b.

Re: [PATCH xserver] xfree86: fix autoConfigDevice() regression that skipped all but the first driver match

On 05/09/2017 04:51 PM, Eric Anholt wrote: Aaron Plattner <aplatt...@nvidia.com> writes: Commit 112d0d7d01b9 lost the initialization of the variable i in the loop to add secondary driver matches to the list of configs: @@ -398,8 +412,8 @@ autoConfigDevice(GDevPtr preconf_

[PATCH xserver] xfree86: fix autoConfigDevice() regression that skipped all but the first driver match

Reported-by: Eric Anholt <e...@anholt.net> Cc: Adam Jackson <a...@redhat.com> Fixes: 112d0d7d01b9 ("xfree86: Improved autoconfig drivers matching") Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- Resend: forgot to Cc the list. hw/xfree86/common/xf86AutoConf

Re: [PATCH] Improved autoconfig drivers matching

On 05/03/2017 01:11 PM, Adam Jackson wrote: > On Mon, 2017-05-01 at 18:03 +0900, Michel Dänzer wrote: >> On 28/04/17 04:11 AM, Adam Jackson wrote: >>> Fixed up (and rebased and made meson-aware) and merged: >>> >>> To ssh://git.freedesktop.org/git/xorg/xserver >>>1549e3037..112d0d7d0 master

Re: [PATCH] Improved autoconfig drivers matching

On 05/03/2017 01:11 PM, Adam Jackson wrote: > On Mon, 2017-05-01 at 18:03 +0900, Michel Dänzer wrote: >> On 28/04/17 04:11 AM, Adam Jackson wrote: >>> Fixed up (and rebased and made meson-aware) and merged: >>> >>> To ssh://git.freedesktop.org/git/xorg/xserver >>>1549e3037..112d0d7d0 master

Re: [PATCH xserver 2/3] Use #ifdef instead of #if for features to make Meson easier.

On 04/26/2017 11:21 AM, Eric Anholt wrote: > Aaron Plattner <aplatt...@nvidia.com> writes: > >> We try to do exactly the opposite in our internal driver build, because >> it's too easy to accidentally do something like >> >> #ifdef GLAMOUR_HAS_GBM >> &g

Re: [PATCH xserver 2/3] Use #ifdef instead of #if for features to make Meson easier.

We try to do exactly the opposite in our internal driver build, because it's too easy to accidentally do something like #ifdef GLAMOUR_HAS_GBM And mistakes like that don't always cause obvious build failures like this would. So we build everything with -Wundef -Werror=undef and try to use #if

Re: [PATCH] Improved autoconfig drivers matching

Another customer ran into this recently. Adam, can this be merged? I don't think Emil's reply was a nack. On 07/12/2016 04:31 PM, Emil Velikov wrote: On 23 July 2015 at 00:42, Karol Kosik wrote: Implementation of new drivers matching algorithm. New approach doesn't add

[PATCH rendercheck] Skip shmblend if SHM pixmaps aren't supported

of failed request: 4 (RenderCreatePicture) Resource id in failed request: 0x3200215 Serial number of failed request: 806 Current serial number in output stream: 811 Fix this by skipping the shmblend tests if the extension is missing or doesn't support pixmaps. Signed-off-by: Aaron Plattner

Re: [PATCH xserver] dix: Move {Change, Copy, Destroy}Clip from GCFuncs to Screen

On 03/07/2017 02:44 PM, Keith Packard wrote: > Aaron Plattner <aplatt...@nvidia.com> writes: > >> They don't do anything interesting with {Change, Copy, Destroy}Clip, though. > > Yeah, can we just get rid of these and replace them with calls to the mi > versions now

Re: [PATCH xserver] dix: Move {Change, Copy, Destroy}Clip from GCFuncs to Screen

On 03/02/2017 03:35 PM, Adam Jackson wrote: > On Thu, 2017-03-02 at 13:20 -0800, Keith Packard wrote: >>> Adam Jackson writes: >>> The "call down" convention would need to know to scan ahead to find >>> the next non-null fptr for the slot either way, but that's not really >>>

Re: [PATCH libX11] _XDefaultError: set XlibDisplayIOError flag before calling exit

On 02/21/2017 08:16 AM, Arthur Huillet wrote: > With Jamey's review and Julien's questions answered, would someone > please push that change to libX11, unless there are objections to the > patch? > > Thank you $ git push upstream HEAD:master Counting objects: 4, done. Delta compression using up

Re: [PATCH xserver 4/7] xfree86: Remove Option "BiosBase"

On 02/14/2017 12:30 PM, Adam Jackson wrote: Just no. The ddxDesign chunk removes the whole para about xf86FixPciResource, since it turns out that function doesn't exist at all anymore. i128 and mga do use this slot, but they oughtn't. Signed-off-by: Adam Jackson ---

Re: [PATCH 0/7] ScrnInfoRec cleanup

Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Also Reviewed-by: Aaron Plattner <aplatt...@nvidia.com> > The sis driver does inspect this > member, but hilariously does so only so it can print the same > information as the core does. Hilarious. common/xf86C

Re: [PATCH xserver 11/19] xfree86: Remove DriverRec1 compat struct

On 01/24/2017 04:36 PM, Emil Velikov wrote: On 23 January 2017 at 19:32, Adam Jackson wrote: The idea here is that the driver might have once been old enough to not have the driverFunc slot in DriverRec, with the module ABI not having changed when it was added. That was ages

Re: [PATCH xserver 02/19] xfree86: remove unused path from the LoadModule API

ot;brother". Other than that, > > Reviewed-by: Eric Anholt <e...@anholt.net> Reviewed-by: Aaron Plattner <aplatt...@nvidia.com> We don't use LoadModule in our driver, and if we do start loading extra stuff, it'll probably be with LoadSubModule anyway. -- Aaron _

Re: [ANNOUNCE] xorg-server 1.18.99.902

On 10/28/2016 09:50 AM, Keith Packard wrote: > Here's 1.19-RC2, which should be pretty close to 1.19. Hi Keith, Can I consider the ABI frozen at this point, so we can get the ball rolling on official driver support? -- Aaron > The only serious bug I'm aware of at this point is a crash in >

Re: [PATCH 1/1] Simplify, statement is always true.

On 09/21/2016 05:08 PM, Maya Rashish wrote: > pVideo->bus is uint8_t, always less than 256. > > Signed-off-by: Maya Rashish > --- > hw/xfree86/common/xf86pciBus.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/hw/xfree86/common/xf86pciBus.c

Re: [PATCH] remove dead code in dummy driver

On 09/22/2016 04:30 PM, Bob Terek wrote: > On 09/21/2016 10:22 AM, Aaron Plattner wrote: >> On 09/20/2016 02:07 AM, Eric Engestrom wrote: >>> On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: >>>> Signed-off-by: Antoine Martin <anto...@nagafix

[PATCH xf86-video-dummy v2] Remove pointless empty functions

These functions might be useful in a real driver, but with no hardware, they're pointless. Get rid of them. v2: Rebase, get rid of pointless calls to DUMMYAdjustFrame, return TRUE from DUMMYSwitchMode. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- src/dummy_driver.

Re: [PATCH] remove dead code in dummy driver

On 09/20/2016 02:07 AM, Eric Engestrom wrote: > On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: >> Signed-off-by: Antoine Martin > > Reviewed-by: Eric Engestrom Looks good to me too (although I'm cheating since this chunk is

Re: Proposed X server 1.19 schedule

On 09/13/2016 10:27 PM, Timo Aaltonen wrote: On 09.09.2016 20:18, Aaron Plattner wrote: On 09/06/2016 12:27 PM, Keith Packard wrote: Adam Jackson <a...@nwnk.net> writes: ... move the non-critical bug deadline to 2016-10-01? Still leaves three weeks for critical fixes. Either way,

Re: [PATCH:xserver] OsSigHandler should not show rtld errors for unrelated signals

seem worth trying to suppress the dlsym error in that case too. Reviewed-by: Aaron Plattner <aplatt...@nvidia.com> > Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> > --- > os/osinit.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > >

Re: [PATCH xserver 2/3] modesetting: Remove some dead code

creen->DestroyPixmap(pixmap); > free(private); > free(buffer); > return NULL; > Well this one is certainly obvious. Reviewed-by: Aaron Plattner <aplatt...@nvidia.com> ___ xorg-devel@lists.x.org: X.

Re: Proposed X server 1.19 schedule

On 09/06/2016 12:27 PM, Keith Packard wrote: > Adam Jackson writes: > >> ... move the non-critical bug deadline to 2016-10-01? Still leaves >> three weeks for critical fixes. Either way, looks plausible to me. I >> don't personally have any non-bug changes I want to land before

Re: [PATCH v6 xserver 7/7] xf86Cursor: Add hw cursor support for prime

On 09/07/2016 08:51 AM, Hans de Goede wrote: > Hi, > > On 07-09-16 17:38, Aaron Plattner wrote: >> On 09/07/2016 08:24 AM, Hans de Goede wrote: >>> Hi, >>> >>> On 07-09-16 17:02, Aaron Plattner wrote: >>>> Adding Alex. >>>> >>

Re: [PATCH v6 xserver 7/7] xf86Cursor: Add hw cursor support for prime

On 09/07/2016 08:24 AM, Hans de Goede wrote: Hi, On 07-09-16 17:02, Aaron Plattner wrote: Adding Alex. On 09/07/2016 05:26 AM, Hans de Goede wrote: From: Dave Airlie <airl...@redhat.com> Currently with PRIME if we detect a secondary GPU, we switch to using SW cursors, this isn't o

Re: [PATCH v6 xserver 7/7] xf86Cursor: Add hw cursor support for prime

evices. This patch checks on each slave screen if hw cursors are enabled, and also calls set cursor and move cursor on all screens. Cc: Aaron Plattner <aplatt...@nvidia.com> Signed-off-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Reviewed-by: Mi

Re: [PATCH] xace: Fix XaceCensorImage to actually censor the right part of the image

Aargh, stupid borders. I always forget about them. I guess this is why we have regression tests. On 08/18/2016 09:11 AM, Adam Jackson wrote: > On Thu, 2016-08-18 at 11:09 +0900, Michel Dänzer wrote: > >> Unfortunately, this broke two XTS tests: >> >> xts5@xlib9@xgetimage@7 >>

[PATCH] xace: Fix XaceCensorImage to actually censor the right part of the image

https://lists.x.org/archives/xorg/2016-August/058165.html Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- Xext/xace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Xext/xace.c b/Xext/xace.c index 91c74d591267..a3a83a20c08a 100644 --- a/Xext/xace.c +++ b/Xext/xace

Re: [PATCH xserver 2/4] xfree86: remove unused path from the LoadModule API

On 04/17/2016 01:07 PM, Emil Velikov wrote: Similar to its little brothre - LoadSubModule. Currently all call sites provide NULL anyway ;-) Cc: Aaron Plattner <aplatt...@nvidia.com> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- Aaron, are you guys using the argument i

Re: [PATCH xserver 1/2] xfree86/modes: Fix HW cursor clipping for crtc->driverIsPerformingTransform

On 01/29/2016 07:23 AM, Keith Packard wrote: > Michel Dänzer writes: > >> I'm not sure that makes sense; e.g. it seems inconsistent with leaving >> the cursor image untransformed in the driverIsPerformingTransform case. >> It seems to me like the idea behind

Re: [PATCH] privates: Clear screen-specific keys during CloseScreen

On 09/16/2015 07:34 PM, Keith Packard wrote: > Aaron Plattner <aplatt...@nvidia.com> writes: > >> The modesetting driver corrupts memory when used after a server regeneration >> because not enough memory is allocated for its pixmap privates. This hap

[PATCH v2] privates: Clear screen-specific keys during CloseScreen

e call to CloseScreen, in case a driver's CloseScreen needs a screen private for something. Finally, add a call to dixFreeScreenSpecificPrivates() for GPU screens. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- Keith, I was thinking about your suggestion of ignoring key->initialized back

[PATCH v3] privates: Clear screen-specific keys during CloseScreen

s. v2: Just set key->initialized to FALSE and move dixFreeScreenSpecificPrivates() calls to after CloseScreen. v3: Move dixFreeScreenSpecificPrivates() calls back to just before CloseScreen. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- Third time's the charm? dix/main.c

Re: [PATCH v2] privates: Clear screen-specific keys during CloseScreen

On 09/17/2015 03:57 PM, Keith Packard wrote: > Aaron Plattner <aplatt...@nvidia.com> writes: > >> The modesetting driver corrupts memory when used after a server regeneration >> because not enough memory is allocated for its pixmap privates. This hap

[PATCH] privates: Clear screen-specific keys during CloseScreen

tes(). Finally, add a call to dixFreeScreenSpecificPrivates() for GPU screens. Signed-off-by: Aaron Plattner <aplatt...@nvidia.com> --- dix/main.c | 1 + dix/privates.c | 34 +++--- 2 files changed, 24 insertions(+), 11 deletions(-) diff --git a/dix/mai

Re: [PATCH] Improved autoconfig drivers matching

On 07/22/2015 04:42 PM, Karol Kosik wrote: Implementation of new drivers matching algorithm. New approach doesn't add duplicate drivers and ease drivers matching phase. Signed-off-by: Karol Kosik kko...@nvidia.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com though it might be good

Re: [PATCH 2/7] fb: Make rootless-agnostic

On 10/17/2013 10:30 AM, Adam Jackson wrote: Reviewed-by: Jasper St. Pierre jstpie...@mecheye.net Signed-off-by: Adam Jackson a...@redhat.com We just tracked down a bug to this ROOTLESS define, so Reviewed-by: Aaron Plattner aplatt...@nvidia.com Karol is working on verifying that this patch

Re: [PATCH 2/7] fb: Make rootless-agnostic

- From: Aaron Plattner Sent: Friday, July 17, 2015 9:44 AM To: Adam Jackson; xorg-devel@lists.x.org Cc: Karol Kosik Subject: Re: [PATCH 2/7] fb: Make rootless-agnostic On 10/17/2013 10:30 AM, Adam Jackson wrote: Reviewed-by: Jasper St. Pierre jstpie...@mecheye.net Signed-off-by: Adam

Re: [PATCH] cursor: add hw cursor support for prime (v2)

On 07/14/2015 05:15 PM, Dave Airlie wrote: Currently with PRIME if we detect a secondary GPU, we switch to using SW cursors, this isn't optimal, esp for the intel/nvidia combinations, we have no choice for the USB offload devices. This patch checks on each slave screen if hw cursors are

[PATCH] xfree86: Bump video driver ABI version to 20

Commit 90db5edf119187f8b1b9207c8c384d6cd7ef9edc modified the signature of StartPixmapTrackingProcPtr, so drivers implementing that need to use the updated definition. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- hw/xfree86/common/xf86Module.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 4/6] modesetting: reverse prime support

On 06/25/2015 03:56 PM, Dave Airlie wrote: + +screenpix = screen-GetScreenPixmap(screen); +screen-width = screenpix-drawable.width = total_width; +screen-height = screenpix-drawable.height = max_height; Directly setting the width/height of a pixmap? That seems

Re: [PATCH 01/16] cursor: drop ARGB_CURSOR

Deucher alexander.deuc...@amd.com Signed-off-by: Dave Airlie airl...@redhat.com Yes please. Reviewed-by: Aaron Plattner aplatt...@nvidia.com FWIW, I removed the checks for these from our driver in 2008. --- dix/cursor.c | 8 hw/kdrive/ephyr/ephyrcursor.c | 4

Re: [PATCH 02/16] xf86Rotate: remove unused macros.

On 06/25/2015 04:51 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com These macros aren't used anywhere. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/modes/xf86Rotate.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/xfree86/modes/xf86Rotate.c

Re: xvfb: add randr support (v2)

On 06/08/2015 03:14 PM, Siim Põder wrote: Hi This was sent to xorg-devel a few years ago. It still applies and still appears to work. I resending this because it affects me. Comments or application to the tree would be greatly appreciated :) The motivation for getting this is chrome

Re: [PATCH 1/8] dix: Unexport various implementation details

On 06/02/2015 11:14 AM, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- dix/colormap.c| 337 +- dix/dispatch.c| 1 + dix/dixfonts.c| 12 +- dix/enterleave.c | 2 +- dix/enterleave.h

Re: [PATCH 3/8] render: Hide/unexport some implementation details

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/02/2015 11:15 AM, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com I think these are all fine. Reviewed-by: Aaron Plattner aplatt...@nvidia.com - -- Aaron --- render/glyph.c | 10 +- render/glyphstr.h | 36

Re: [PATCH 2/8] randr: Unexport some implementation details

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/02/2015 11:15 AM, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com --- randr/randrstr.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/randr/randrstr.h b/randr/randrstr.h index

Re: [PATCH 5/8] dga: Hide a bunch of implementation details

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/02/2015 11:15 AM, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com I sure wish DGA would just die already. Reviewed-by: Aaron Plattner aplatt...@nvidia.com - -- Aaron --- hw/xfree86/common/dgaproc.h | 62

Re: [PATCH 4/8] xfree86: Hide some pre-randr mode validation details

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/02/2015 11:15 AM, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com I'm happy to say that we don't use any of these, so Reviewed-by: Aaron Plattner aplatt...@nvidia.com - -- Aaron --- hw/xfree86/common/xf86.h | 11

Re: [PATCH v2 2/2] systemd-logind: Only use systemd-logind integration together with keeptty

On 05/16/2015 01:03 AM, Hans de Goede wrote: Hi, On 15-05-15 22:21, Aaron Plattner wrote: On 04/30/2015 05:24 AM, Hans de Goede wrote: systemd-logind integration does not work when starting X on a new tty, as that detaches X from the current session and after hat systemd-logind revokes all

Re: [PATCH v2 2/2] systemd-logind: Only use systemd-logind integration together with keeptty

...@redhat.com I can confirm that this fixes VT switching for X servers started from an SSH session on Arch Linux, which I use all the time for debugging. So Tested-by: Aaron Plattner aplatt...@nvidia.com I was afraid not using -keeptty was going to break using a debugger, but it looks like it works

Re: [PATCH] randrproto: clarify output XID lifetimes.

in this document are careful to capitalize it RandR. Otherwise, Reviewed-by: Aaron Plattner aplatt...@nvidia.com +randr output disappears. This is to clarify that going forward the +X server will not remove outputs dynamically, just mark them as +disconnected. + 1.99 Acknowledgments Our thanks

Re: [PATCH] composite: Don't bother copying the pixmap for ForgetGravity windows (v2)

Does this cause flickering when resizing windows and the compositor reads the new window pixmap before the app has a chance to respond to the events? On 04/23/2015 01:24 PM, Jasper St. Pierre wrote: If a window has ForgetGravity in its bitGravity, that very likely means it will repaint on the

Re: [PATCH xrandr] Split verbose mode printing into a helper function

On 04/22/2015 12:10 AM, Kenneth Graunke wrote: On Thursday, April 09, 2015 11:18:58 AM Aaron Plattner wrote: Combine the two forms of verbose mode printing into a single function. Pass the 'current' and 'preferred' flags as arguments. This fixes the code that prints unassociated modes

Re: [PATCH] Add amdgpu as a default driver for AMD GPUs

Is there any chance you could use the new OutputClass match rules in /usr/share/X11/xorg.conf.d rather than adding to this list? On 04/20/2015 08:08 PM, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com Its Probe hook bails cleanly when it can't initialize, in which case the ati

Re: [PATCH 2/3] modesetting: add dynamic connector hotplug support (MST) (v2)

On 04/19/2015 08:52 PM, Dave Airlie wrote: On 14 April 2015 at 13:12, Keith Packard kei...@keithp.com wrote: Dave Airlie airl...@gmail.com writes: So we hot unplug, we remove the output XID from the server, in parallel the client does an operation with the output XID it has gotten already,

[PATCH xrandr] Split verbose mode printing into a helper function

Combine the two forms of verbose mode printing into a single function. Pass the 'current' and 'preferred' flags as arguments. This fixes the code that prints unassociated modes to print the flags as well. Signed-off-by: Aaron Plattner aplatt...@nvidia.com --- xrandr.c | 62

  1   2   3   4   5   6   >