[PATCH libXdmcp] Fix compilation error when arc4random_buf is not available

Not sure how I missed that, but I did. Also rename emulate_getrandom_buf() into insecure_getrandom_buf() as requested in the previous patch reviews. Last, getbits() expects an unsigned char, so remove the warning. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com> --- Obviou

[PATCH libXdmcp v2] Use getentropy() if arc4random_buf() is not available

getentropy() on a supported glibc and kernel. If the call fails, fall back to the current (vulnerable) code. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com> --- changes in v2: - use the getentropy() from glibc, not the plain syscall - make it clear that arc4random_buf()

[PATCH libICE v2] Use getentropy() if arc4random_buf() is not available

getentropy() on a supported glibc and kernel. If the call fails, fall back to the current (partly vulnerable) code. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com> --- changes in v2: - use the getentropy() from glibc, not the plain syscall - make it clear that arc4random_buf()

Re: [PATCH libXdmcp] Use getrandom() syscall if available

On Mon, Apr 3, 2017 at 9:17 PM, Mark Kettenis wrote: > OpenBSD does not have a getrandom(3) function in libc. The OpenBSD > postion is that the arc4random(3) family of functions is always the > preferred way to get proper random numbers as all the other interfaces > have

Re: [PATCH libXdmcp] Use getrandom() syscall if available

On Mon, Apr 3, 2017 at 9:27 PM, Alan Coopersmith <alan.coopersm...@oracle.com> wrote: > On 04/ 3/17 12:17 PM, Mark Kettenis wrote: >>> >>> From: Benjamin Tissoires <benjamin.tissoi...@gmail.com> >>> Date: Mon, 3 Apr 2017 17:52:32 +0200 >>> &

Re: [PATCH libXdmcp] Use getrandom() syscall if available

On Mon, Apr 3, 2017 at 4:02 PM, Alan Coopersmith <alan.coopersm...@oracle.com> wrote: > On 04/ 3/17 05:52 AM, Benjamin Tissoires wrote: >> >> This allows to fix CVE-2017-2625 on Linux platforms without pulling in >> libbsd. >> The syscall getrandom is available s

Re: [PATCH libXdmcp] Use getrandom() syscall if available

On Mon, Apr 3, 2017 at 3:17 PM, walter harms <wha...@bfs.de> wrote: > > > Am 03.04.2017 14:52, schrieb Benjamin Tissoires: >> This allows to fix CVE-2017-2625 on Linux platforms without pulling in >> libbsd. >> The syscall getrandom is available since kernel v3.1

[PATCH libICE] Use getrandom() syscall if available

the glibc getrandom() call given that it's only available in glibc 2.25, and the #if dance is already messy here. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com> --- configure.ac | 3 +++ src/iceauth.c | 79 ++- 2 files c

[PATCH libXdmcp] Use getrandom() syscall if available

getrandom() call given that it's only available in glibc 2.25, and the #if dance is already messy here. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com> --- Key.c| 12 configure.ac | 3 +++ 2 files changed, 15 insertions(+) diff --git a/Key.c b/Key.c

Re: [PATCH xserver] xfree86: add NoMatchFoo directives for InputClass sections

On Fri, Dec 11, 2015 at 10:42 AM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Fri, Dec 11, 2015 at 09:58:34AM +0100, Benjamin Tissoires wrote: >> Hi Peter, >> >> On Fri, Dec 11, 2015 at 12:58 AM, Peter Hutterer >> <peter.hutte...@who-t.net> wrot

Re: [PATCH xserver] xfree86: add NoMatchFoo directives for InputClass sections

Hi Peter, On Fri, Dec 11, 2015 at 12:58 AM, Peter Hutterer wrote: > InputClass sections use various MatchFoo directives to decide which device to > apply to. This usually works fine for specific snippets but has drawbacks for > snippets that apply more generally to a

[PATCH:libXfont] bdfReadCharacters: Allow negative DWIDTH values

The fix for CVE-2015-1804 prevent DWIDTH to be negative. However, the spec states that DWIDTH [...] is a vector indicating the position of the next glyph’s origin relative to the origin of this glyph. So negative values are correct. Found by trying to compile XTS. Signed-off-by: Benjamin

Re: [PATCH synaptics] Support the new Lenovo X1 Carbon 3rd trackpoint buttons

...@who-t.net --- FWIW: Tested-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cheers, Benjamin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH util-modular] release.sh: add evemu special hooks

Evemu is a freedesktop project and can benefit from release.sh One special case has been added to match the tag format used internally (vX.Y.Z) Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- It would be nice if release.sh could also handle evemu. Cheers, Benjamin

Re: [PATCH] config: search for PnPID on all parents (#75513)

but not triggered the actual code. Here you go: Tested-by: Benjamin Tissoires benjamin.tissoi...@gmail.com tested under udev and hal backends. Cheers, Benjamin config/hal.c | 16 +--- config/udev.c | 15 +++ 2 files changed, 24 insertions(+), 7 deletions(-) diff --git

Re: [PATCH synaptics 3/4] eventcomm: drop some use of mtdev

On Tue, Mar 11, 2014 at 1:27 AM, Peter Hutterer peter.hutte...@who-t.net wrote: When checking the device don't open a new mtdev instance, use the existing libevdev struct. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/eventcomm.c | 99

Re: [PATCH synaptics 1/4] eventcomm: fix wrong event code for SYN_REPORT

On Tue, Mar 11, 2014 at 1:27 AM, Peter Hutterer peter.hutte...@who-t.net wrote: This was supposed to emulate a SYN_REPORT event so that the upper layers process what's in the queue. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/eventcomm.c | 2 +- 1 file changed, 1

Re: [PATCH synaptics 0/4] Drop mtdev from synaptics

are touchpads so this code is superfluous. Looks good, the entire series is: Reviewed-by: Hans de Goede hdego...@redhat.com Besides the small nitpick in 3/4, this series is also: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com Cheers, Benjamin

Re: [PATCH evtest] Use versionsort instead of alphasort

On Fri, May 31, 2013 at 7:46 AM, Peter Hutterer peter.hutte...@who-t.net wrote: Having /dev/input/event10 sort after /dev/input/event9 almost makes me think the future is here. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Benjamin Tissoires benjamin.tissoi...@gmail.com

[ANNOUNCE] evemu 1.1.0

since 1.0.10 - Benjamin Tissoires (15): Test for device grab .gitignore: add tools/evemu-event Clean mixed declarations and code add evemu-test-runner into .gitignore remove -D_GNU_SOURCE=1 from CFLAGS disable -Werror

[PATCH synaptics] Fix stack smash in clickpad_guess_clickfingers()

From: Benjamin Tissoires benjamin.tissoi...@redhat.com Apple Magic Trackpad can report 16 slots. In clickpad_guess_clickfingers() the array allocated on the stack contains only 10 slots. As (.num_mt_mask == .num_slots), the function writes out of the bounds of close_point. Dynamically allocating

Re: [PATCH evdev 2/2] Add SYN_DROPPED handling #59702

On Wed, Jan 23, 2013 at 3:19 AM, Chung-yih Wang cyw...@chromium.org wrote: If an evdev client cannot consume evdev events in its queue fast enough, the evdev kernel driver will enqueue a SYN_DROPPED event and clear the queue once the client's queue is full. The result is that the X driver will

[PATCH libXI] Add missing XI_RawTouch* in XInputCopyCookie

-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- Hi guys, well, I'm not 100% sure of this, but at least, it my tests don't print these errors... Cheers, Benjamin src/XExtInt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/XExtInt.c b/src/XExtInt.c index 57d071d..507573b

[PATCH evdev 0/8] cleanup and handling of proximity for multitouch devices

of each slot. Patches 7-8 handle these particular devices (proximity). Cheers, Benjamin Benjamin Tissoires (8): initialize pEvdev-slot_state to SLOTSTATE_EMPTY num_slots should take into account the .mtdev field Use last_mt_vals_slot() instead of directly using pEvdev-cur_slot Ignore out

[PATCH evdev 1/8] initialize pEvdev-slot_state to SLOTSTATE_EMPTY

This prevents the creation of a touch in case no multitouch event came before the very first EV_SYN. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- src/evdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/evdev.c b/src/evdev.c index 619bce6..27b0e76 100644

[PATCH evdev 2/8] num_slots should take into account the .mtdev field

The current implementation assume that multitouch devices following the Multitouch Protocol A (those requiring mtdev) present 10 touches, no matter mtdev decides. num_slots should be relying on mtdev when it is available. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- src

[PATCH evdev 3/8] Use last_mt_vals_slot() instead of directly using pEvdev-cur_slot

Everywhere else in the code, pEvdev-cur_slot is never used directly, but through the function last_mt_vals_slot which standardize it. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- src/evdev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src

[PATCH evdev 4/8] Ignore out-of-range slots information

Getting an out of range ABS_MT_SLOT value means that either the kernel driver is broken or the device is sending more slots that it advertised. In both cases, it's a bug in the kernel and processing the incoming events for this bad slot may introduce end-user problems. Signed-off-by: Benjamin

[PATCH evdev 5/8] Do not rely on mtdev for devices following mt-protocol B

Mtdev is only usefull for protocol A devices (quite a few now). For all the others, it adds some memory and process which is not required as it just passes the events to the caller. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- src/evdev.c | 26 +++--- 1

[PATCH evdev 7/8] Store per-slot touch state

the touch property to true or false. The benefit of it is that we can now easily add proximity support and several touch begin/end within the same slot. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- src/evdev.c | 47 +++ src

[PATCH evdev 8/8] handle multitouch events whithin proximity

ABS_MT_DISTANCE controls whether the finger is touching the sensor or not. When the slot is opened, if the device reports ABS_MT_DISTANCE, we should rely on it to set the right value of touch. If not, then the creation of the slot means that the touch began. Signed-off-by: Benjamin Tissoires

[PATCH xserver] Add missing labels for multitouch valuators

ABS_MT_DISTANCE exists since kernel v2.6.38, ABS_MT_TOOL_X|Y appeared in v3.6. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- Hi Peter, as requested, this is an update of the latest input definitions made in the kernel. It's been a long time since I submitted patches

[PATCH evdev] Add missing mt axis labels

update evdev according to latest changes in input.h Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com --- Hi Peter, well, I doubt we should bump the ABI number for just 3 labels in xserver. So I'm not sure about the #ifdef here. Don't hesitate to send any comments. Cheers

Re: [PATCH 10/20] Switch to use IsFloating()

On 02/22/2011 11:31 PM, Peter Hutterer wrote: On Tue, Feb 22, 2011 at 08:17:32AM +0100, Benjamin Tissoires wrote: Hi Peter, Except two unnecessary parenthesis here, you can add my Reviewed-by for the series ;) On 02/18/2011 04:52 AM, Peter Hutterer wrote: [...] diff --git a/Xi

Re: [PATCH 10/20] Switch to use IsFloating()

Hi Peter, Except two unnecessary parenthesis here, you can add my Reviewed-by for the series ;) On 02/18/2011 04:52 AM, Peter Hutterer wrote: This is not a straightforward search/replacement due to a long-standing issue. dev-u.master is the same field as dev-u.lastSlave. Thus, if dev is a

Re: [PATCH 18/20] xkb: Fix a check for MASTER_KEYBOARD

Hi Peter, On 02/18/2011 04:52 AM, Peter Hutterer wrote: Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- xkb/xkb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xkb/xkb.c b/xkb/xkb.c index 43d847a..169c604 100644 --- a/xkb/xkb.c +++ b/xkb/xkb.c @@

Re: [PATCH evdev v3] Add third button emulation.

I Peter, I did not made an exhaustive review, but at least, you can add my 'tested-by'. Thanks a lot for the work. Cheers, Benjamin On 02/04/2011 12:45 AM, Peter Hutterer wrote: New properties: Evdev Third Button Emulation → switch on/off Evdev Third Button Emulation Timeout → timeout

Re: [PATCH evdev v2] Add third button emulation.

Hi Peter, well, I still have troubles (again, based on the backport to 2.6.0). ;) On 02/02/2011 07:35 AM, Peter Hutterer wrote: New properties: Evdev Third Button Emulation → switch on/off Evdev Third Button Emulation Timeout → timeout until event is delivered Evdev Third Button Emulation

Re: [PATCH evdev] Add third button emulation.

On 01/31/2011 10:52 PM, Peter Hutterer wrote: On Mon, Jan 31, 2011 at 11:48:08AM +0100, Benjamin Tissoires wrote: Thanks, that seems to be a good feature for touchscreen devices! I've got one problem: on which tree does this patch applies? (I've tried against the branch master of xf86-input

Re: [PATCH evdev] Add third button emulation.

if it's related to the backport or not). Maybe I'm totally wrong (because the valuator stuff changed some logic), in case I apologize for using your time. ;) Cheers, Benjamin On 02/01/2011 10:08 AM, Benjamin Tissoires wrote: On 01/31/2011 10:52 PM, Peter Hutterer wrote: On Mon, Jan 31, 2011

Re: [PATCH evdev] Add third button emulation.

Hi Peter, Thanks, that seems to be a good feature for touchscreen devices! I've got one problem: on which tree does this patch applies? (I've tried against the branch master of xf86-input-evdev): error: patch failed: src/evdev.c:453 error: src/evdev.c: patch does not apply error: patch

Re: EVIOC mechanism for MT slots

To:     Ping Cheng pingli...@gmail.com CC:     Henrik Rydberg rydb...@euromail.se, Andrew Morton a...@linux-foundation.org, linux-in...@vger.kernel.org, linux-ker...@vger.kernel.org, Mika Kuoppala mika.kuopp...@nokia.com, Peter Hutterer peter.hutte...@who-t.net, Benjamin Tissoires tisso...@cena.fr

Re: [PATCH] evdev: rename EvdevCacheCompare() to EvdevCache()

Hi Peter, On 12/10/2010 01:28 PM, Peter Korsgaard wrote: Since 59056e656c64 (Remove the reopen timer logic) from last year, EvdevCacheCompare() is only used for caching ioctl values and not for comparing, so remove the unused compare logic and rename the function to EvdevCache().

Re: [PATCHv2] evdev: rename EvdevCacheCompare() to EvdevCache()

Reviewed-by: Benjamin Tissoires benjamin.tissoi...@enac.fr On 12/10/2010 04:16 PM, Peter Korsgaard wrote: Since 59056e656c64 (Remove the reopen timer logic) from last year, EvdevCacheCompare() is only used for caching ioctl values and not for comparing, so remove the unused compare logic

Re: [RFC] Multi-Touch (MT) support - arbitration or not

Le 08/11/2010 04:51, Peter Hutterer a écrit : fwiw, I'm not sure arbitrate is the right word here, filtering seems easier to understand in this context. I guess arbitrate would apply more if we emit the events across multiple devices like in the bamboo case. that's mostly bikeshedding though, my

Re: [PATCH evdev] evdev: added property Evdev Axes Rotation. #27688

Hi, Le 29/10/2010 07:37, Peter Hutterer a écrit : On Sun, Oct 24, 2010 at 01:45:03PM +0200, Paolo D'Apice wrote: The evdev driver does not allow to set a custom axes rotation as the mousedrv driver does with the option AngleOffset. This option is necessary for some trackballs, for example the

Re: [PATCH evdev 2/2] Reshuffle to avoid the need for XI86_CONFIGURED.

Le 28/10/2010 05:11, Peter Hutterer a écrit : On Tue, Oct 26, 2010 at 10:11:17AM +1000, Peter Hutterer wrote: Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- src/evdev.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/evdev.c

Re: How to create an floating device in Xorg input driver?

Hi, If I understand correctly, you are trying to work with the patches I submitted, nearly a year ago. First, I would just say that the work concerning this branch of evdev is not maintained as it has a lot of problems (limit of the maximum count of contact, etc). Multitouch will be

Re: [PATCH evdev 2/2] Reshuffle to avoid the need for XI86_CONFIGURED.

-by: Benjamin Tissoires tisso...@cena.fr Cheers, Benjamin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH evdev 1/2] Input API 12 requires a valuator mode for each axis.

Quite easy to review this one... ;) Reviewed-by: Benjamin Tissoires tisso...@cena.fr Le 26/10/2010 02:11, Peter Hutterer a écrit : Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- src/evdev.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src

Re: [PATCH evdev 2/2] Reshuffle to avoid the need for XI86_CONFIGURED.

Le 26/10/2010 02:11, Peter Hutterer a écrit : Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- src/evdev.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 018843f..940f24d 100644 --- a/src/evdev.c +++

Re: [PATCH evdev] Rename abs/rel/prox to abs_queued/rel_queued/prox_queued.

Reviewed-by: Benjamin Tissoires tisso...@cena.fr Le 20/10/2010 02:46, Peter Hutterer a écrit : Mainly to avoid confusing between pEvdev-prox and pEvdev-proximity and to better express what these fields are actually holding. Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- src

Re: [PATCH evdev] Use an array for the proximity bits.

Reviewed-by: Benjamin Tissoires tisso...@cena.fr Le 20/10/2010 02:47, Peter Hutterer a écrit : Instead of two lists that need to be kept in sync, just store the bits in an array and run through them. Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- src/evdev.c | 51

[PATCH evdev] Add the names of the valuators for the multitouch properties

Thoses definitions have been included in the kernel and in the X server. However, the evdev driver has not been updated accordingly. Without these definitions, the multitouch axes are not correctly labelled. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- This patch is in my queue since

Re: [PATCH evdev v2] Add proximity support.

pEvdev-num_queue; i++) Hi Peter, though it helps understanding the patch, the test on -prox is not necessary (return 0 above). Except that small thing, Reviewed-by: Benjamin Tissoires tisso...@cena.fr Cheers, Benjamin +{ +if (pEvdev-queue[i].type == EV_QUEUE_PROXIMITY

Re: [PATCH evdev 2/3] Add proximity support.

Le 12/10/2010 03:38, Peter Hutterer a écrit : On Mon, Oct 11, 2010 at 12:58:06PM +0200, Benjamin Tissoires wrote: Hi Peter, see my comments: Le 11/10/2010 01:33, Peter Hutterer a écrit : When one of the tools comes into proximity, queue up a proximity event and send it accordingly. Signed

Re: [PATCH evdev 2/4] Don't pass pointers around to first_v and num_v.

Le 12/10/2010 03:20, Peter Hutterer a écrit : On Mon, Oct 11, 2010 at 01:09:50PM +0200, Benjamin Tissoires wrote: Hi Peter, Le 11/10/2010 01:23, Peter Hutterer a écrit : We only use them as values, no need for the addresses. Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- src

Re: [RFC] Multitouch proposal v2 + implementation

Hi Daniel, though I'm not a toolkit guy, I wanted to add some comments mainly from the discussions we had at XDS (and from what I understood). I've also added Denis in copy as he was present at XDS and may need to add sth. Le 20/09/2010 06:45, Daniel Stone a écrit : Hi all, This is my

Re: [PATCH 3/4] Implement MT Slots protocol support

Le 23/06/2010 16:04, Chase Douglas a écrit : From: Benjamin Tissoirestisso...@cena.fr The MT Slots protocol sends only the ABS_MT_* values that have changed from a previous set of events. We use the ABS_MT_SLOT value as an index into an array of MT valuators. (see

Re: [PATCH evdev 0/3] Preliminary support of multitouch (rev4)

Le 18/06/2010 06:56, Peter Hutterer a écrit : On Fri, Jun 18, 2010 at 12:18:00AM -0400, Rafi Rubin wrote: On Thu, Jun 17, 2010 at 11:51:34AM -0400, Chase Douglas wrote: On Thu, 2010-06-17 at 12:16 +1000, Peter Hutterer wrote: On Thu, Jun 10, 2010 at 05:47:57PM +0200, Benjamin Tissoires wrote

Re: [PATCH evdev 0/3] Preliminary support of multitouch (rev4)

Le 17/06/2010 10:58, Henrik Rydberg a écrit : Peter Hutterer wrote: On Thu, Jun 10, 2010 at 05:47:57PM +0200, Benjamin Tissoires wrote: Even if there is an interesting thread concerning the use of multitouch on xorg-devel, I still send the up-to-date patches to enable multitouch as valuators

Re: [PATCH evdev 0/3] Preliminary support of multitouch (rev4)

Le 18/06/2010 08:53, Peter Hutterer a écrit : On Fri, Jun 18, 2010 at 08:46:17AM +0200, Benjamin Tissoires wrote: Le 18/06/2010 06:56, Peter Hutterer a ?crit : On Fri, Jun 18, 2010 at 12:18:00AM -0400, Rafi Rubin wrote: On Thu, Jun 17, 2010 at 11:51:34AM -0400, Chase Douglas wrote: On Thu

[PATCH evdev 0/3] Preliminary support of multitouch (rev4)

Hi, Even if there is an interesting thread concerning the use of multitouch on xorg-devel, I still send the up-to-date patches to enable multitouch as valuators. Changes since last time: * Remove the detection of the maximum number of touches based on the tracking ID * changes in comments

[PATCH evdev 1/3] Add the names of the valuators for the multitouch properties

The driver has to know the correct labels of the ABS_MT_* events. However, to keep compatibility with older xserver that don't define the corresponding labels, this patch does not inject them in the list. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 29

[PATCH evdev 2/3 v4] Add the new valuators for multitouch

and ABS_MT_POSITION_Y at their first position. Note that I currently assume that all definitions between ABS_MT_TOUCH_MAJOR and below ABS_MT_PRESSURE are MT-related. This can be changed by re-defining EVDEV_FIRST_MT_AXIS and EVDEV_LAST_MT_AXIS. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c

[PATCH evdev 3/3 v4] Dummy process of MT events (protocol A).

available place, i.e. it does not override older mt values. This is valid as this protocol forces the device to send all the values at each frame. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 42 +++--- src/evdev.h |1 + 2 files changed

[PATCH evdev 1/3] Add the names of the valuators for the multitouch properties

The driver has to know the correct labels of the ABS_MT_* events. However, to keep compatibility with older xserver that don't define the corresponding labels, this patch does not inject them in the list. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 29

[PATCH evdev 0/3] Preliminary support of multitouch (rev3)

Hi, here the third version of the mt patches. Changes since last time: - typos and indents fixed - introduced 3 defines: EVDEV_FIRST_MT_AXIS, EVDEV_LAST_MT_AXIS and EVDEV_XI_MULTITOUCHDEVICE. - changes in git commit messages to be more explicit (I hope) - swapped free(atoms) and

[PATCH evdev 3/3] Dummy process of MT events (protocol A). (rev3)

available place, i.e. it does not override older mt values. This is valid as this protocol forces the device to send all the values at each frame. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 36 +--- src/evdev.h |1 + 2 files changed, 34

Re: [PATCH evdev 2/3] Add the new valuators for multitouch (rev3)

Le 02/06/2010 15:09, Henrik Rydberg a écrit : +static int +EvdevMTAddExtraValuators(EvdevPtr pEvdev, int total_num_axes) +{ +int num_axes = 0; +int mt_num_valuators = 0; + +if (!(pEvdev-flags EVDEV_MULTITOUCH)) +return total_num_axes; + +mt_num_valuators =

Re: [PATCH evdev 3/3] Dummy process of MT events (protocol A). (rev3)

Le 02/06/2010 15:13, Henrik Rydberg a écrit : B @@ -545,7 +548,15 @@ EvdevProcessAbsoluteMotionEvent(InputInfoPtr pInfo, struct input_event *ev) if (EvdevWheelEmuFilterMotion(pInfo, ev)) return; -pEvdev-vals[pEvdev-axis_map[ev-code]] = value; +if (ev-code

Re: [PATCH evdev 2/3] Add the new valuators for multitouch (rev2)

Thanks Peter (I also cross send to the right mailing list address as I made a mistake the first time I send these patches) Le 01/06/2010 03:35, Peter Hutterer a écrit : On Sun, May 30, 2010 at 03:08:58PM +0200, Benjamin Tissoires wrote: The step one in implementing multitouch in evdev

Re: [PATCH evdev 3/3] Dummy process MT events (protocol A). (rev2)

through the diff to satisfy their curiosity ;) other than that, just a two typos/language fixups On Sun, May 30, 2010 at 03:08:59PM +0200, Benjamin Tissoires wrote: In case the driver receives a mt event, it stores it at the first available place, i.e. it does not overrides older mt values

[PATCH evdev 0/3] Preliminary support of multitouch (rev2)

Here is finally the new set of patches to enable a preliminary support of multitouch into Xorg. Changes since last time: - squashed patches Detection of multitouch device and Add the new valuators for multitouch - renamed the field mt_num_valuators to mt_current_touchpoint - namespace for

[PATCH evdev 1/3] Add the names of the valuators for the multitouch properties

The driver has to know the correct labels of the ABS_MT_* events. However, to keep compatibility with older xserver that don't define the corresponding labels, this patch does not inject them in the list. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 29

[PATCH evdev 2/3] Add the new valuators for multitouch (rev2)

and ABS_MT_POSISTION_Y at their first position. Note that I currently assume that all definitions above ABS_MT_TOUCH_MAJOR and below ABS_MAX are MT-related. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 177 ++- src/evdev.h |6

[PATCH evdev 3/3] Dummy process MT events (protocol A). (rev2)

In case the driver receives a mt event, it stores it at the first available place, i.e. it does not overrides older mt values. At the end, in the EV_SYNC event, it only sends the values it has filled. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 36

[PATCH evdev 0/3] Preliminary support of multitouch (rev2)

Here is finally the new set of patches to enable a preliminary support of multitouch into Xorg. Changes since last time: - squashed patches Detection of multitouch device and Add the new valuators for multitouch - renamed the field mt_num_valuators to mt_current_touchpoint - namespace for

[PATCH evdev 1/3] Add the names of the valuators for the multitouch properties

The driver has to know the correct labels of the ABS_MT_* events. However, to keep compatibility with older xserver that don't define the corresponding labels, this patch does not inject them in the list. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 29

[PATCH evdev 2/3] Add the new valuators for multitouch (rev2)

and ABS_MT_POSISTION_Y at their first position. Note that I currently assume that all definitions above ABS_MT_TOUCH_MAJOR and below ABS_MAX are MT-related. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 177 ++- src/evdev.h |6

[PATCH evdev 3/3] Dummy process MT events (protocol A). (rev2)

In case the driver receives a mt event, it stores it at the first available place, i.e. it does not overrides older mt values. At the end, in the EV_SYNC event, it only sends the values it has filled. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 36

[PATCH xserver resent] xf86ScaleAxis: support for high resolution devices

High resolution devices was generating integer overflow. For instance the wacom Cintiq 21UX has an axis value up to 87000. Thus the term (dSx * (Cx - Rxlow)) is greater than MAX_INT32. Using 64bits integer avoids such problem. Signed-off-by: Philippe Ribet ri...@cena.fr Signed-off-by: Benjamin

Re: [PATCH xserver] xf86ScaleAxis: support for high resolution devices

Le 12/04/2010 09:17, Philippe Ribet a écrit : Dan Nicholson wrote: On Fri, Apr 9, 2010 at 7:51 AM, Benjamin Tissoirestisso...@cena.fr wrote: High resolution devices was generating integer overflow. For instance the wacom Cintiq 21UX has an axis value up to 87000. Thus the term (dSx * (Cx -

Re: [PATCH evdev 3/5] Add the new valuators for multitouch

Sorry for the delay, I was quite busy this time... I'm worried about EvdevAddAbsClass getting a bit too messy with this. If I'm not mistaken, you can quite trivially move this if (flags MULTITOUCH) condition into a EvdevMTCountValuators() and the loop to init all axes into a

Re: [PATCH evdev 5/5] Keep the states of multitouch events

--- a/src/evdev.c +++ b/src/evdev.c @@ -556,12 +556,10 @@ EvdevProcessAbsoluteMotionEvent(InputInfoPtr pInfo, struct input_event *ev) if (ev-code ABS_MT_TOUCH_MAJOR) pEvdev-vals[pEvdev-axis_map[ev-code]] = value; -else if (pEvdev-current_num_multitouch

[PATCH xserver] xf86ScaleAxis: support for high resolution devices

High resolution devices was generating integer overflow. For instance the wacom Cintiq 21UX has an axis value up to 87000. Thus the term (dSx * (Cx - Rxlow)) is greater than MAX_INT32. Using 64bits integer avoids such problem. Signed-off-by: Philippe Ribet ri...@cena.fr Signed-off-by: Benjamin

[PATCH evdev 0/5] Preliminary support of multitouch

Hello everybody, I started the development of multitouch in the evdev driver. As the goal of the evdev driver is to provide raw information from the kernel, I did not included any gestures nor filtering. Currently, I have the following limitations: - the number of simultaneous reported

[PATCH evdev 1/5] Add the names of the valuators for the multitouch properties

The driver has to know the correct labels of the ABS_MT_* events. However, to keep compatibility with older xserver that don't define the corresponding labels, this patch does not inject them in the list. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 29

[PATCH evdev 2/5] Detection of multitouch devices

This patch does nothing except detecting multitouch devices and putting this detection in the log. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 22 +- src/evdev.h |1 + 2 files changed, 22 insertions(+), 1 deletions(-) diff --git a/src/evdev.c b

[PATCH evdev 3/5] Add the new valuators for multitouch

-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 51 ++- src/evdev.h |5 + 2 files changed, 55 insertions(+), 1 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index b84af7f..7e59601 100644 --- a/src/evdev.c +++ b/src/evdev.c

[PATCH evdev 4/5] Dummy process MT events.

In case the driver receive a mt event, it stores it at the first available place, i.e. it does not overrides older mt values. At the end, in the EV_SYNC event, it only send the values it has filled. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 31

[PATCH evdev 5/5] Keep the states of multitouch events

by the device - the device reports all multitouch fields at each frame Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 73 -- src/evdev.h | 11 + 2 files changed, 76 insertions(+), 8 deletions(-) diff --git a/src

Re: [RFC] Multitouch support, step one

Le 16/03/2010 02:58, Peter Hutterer a écrit : An other point for keeping the valuator trackingID. Some device (stantum and magicmouse) send a trackingID different than touch point. i.e. the trackingID is between 1 and 255 on the stantum, and between 1 and 16 on the magic mouse. I don't know if

Re: [RFC] Multitouch support, step one

I do not want to break this discussion, but I think that the work you mentioned is a little bit aside of the original subject. I rapidly had a look at the code and it seems to be a driver for trackpads with multitouch enabled. It's really a good job, but I thought the original proposal of

Re: [RFC] Multitouch support, step one

Peter, I did not found the time last week to respond, so I will do now Le 15/03/2010 09:50, Peter Hutterer a écrit : On Mon, Mar 15, 2010 at 06:36:15PM +1100, Carsten Haitzler wrote: On Mon, 15 Mar 2010 16:56:05 +1000 Peter Huttererpeter.hutte...@who-t.net said: cool - no comment here means

Re: [PATCH] added labels for multitouch valuators

So here is the new version after corrections of the two patches. ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] added labels for multitouch valuators

Thoses definitions have been included in the kernel but the X server is not updated accordingly. Without these definitions, the multitouch axes are not correctly labelled. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- Xi/xiproperty.c | 11 +++ include/xserver

[PATCH evdev] Added the names of the valuators for the multitouch properties

Thoses definitions have been included in the kernel but the X server and the evdev driver are not updated accordingly. Without these definitions, the multitouch axes are not correctly labelled. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 27

[PATCH] added labels for multitouch valuators

as stable. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- Xi/xiproperty.c | 10 ++ include/xserver-properties.h | 10 ++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/Xi/xiproperty.c b/Xi/xiproperty.c index ea66c54..1438491 100644 --- a/Xi

[PATCH evdev] Added the names of the valuators for the multitouch properties

that kernel will be marked as stable. Signed-off-by: Benjamin Tissoires tisso...@cena.fr --- src/evdev.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 58ffcea..1e4dad1 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -2272,6

  1   2   >